D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in GridDelegate.qml:147
> This was a deliberate choice, to make sure that the delegate got selected 
> when one of its buttons got clicked. But yeah selected may not necessarily 
> require clicked, so maybe it wasn't the best way of doing it. If you can 
> think of a better way to ensure that, then by all means, please don't 
> hesitate to send a patch!

Right! That makes sense, yes - i'll try and work out if we can't get that done 
with a few less side effects :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: leinir, Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, 
GB_2, kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> leinir wrote in GridDelegate.qml:147
> Just came across having both a function called on clicking the thumbnail 
> (using the onClicked handler) and on actions being triggered, and both now 
> get triggered at the same time. Was this a deliberate choice? I can of course 
> work around it by not using the onClicked handler and just putting a click 
> handler into the thumbnail delegate, but it seems like this is the sort of 
> thing the GridDelegate is supposed to avoid :) (for my purposes: clicking the 
> thumbnail opens a page with detailed information about the item represented 
> by the thumbnail, and clicking the action causes things to be done to the 
> item without opening that page).

This was a deliberate choice, to make sure that the delegate got selected when 
one of its buttons got clicked. But yeah selected may not necessarily require 
clicked, so maybe it wasn't the best way of doing it. If you can think of a 
better way to ensure that, then by all means, please don't hesitate to send a 
patch!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: leinir, Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, 
GB_2, kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> GridDelegate.qml:147
> +onClicked: {
> +delegate.clicked()
> +modelData.trigger()

Just came across having both a function called on clicking the thumbnail (using 
the onClicked handler) and on actions being triggered, and both now get 
triggered at the same time. Was this a deliberate choice? I can of course work 
around it by not using the onClicked handler and just putting a click handler 
into the thumbnail delegate, but it seems like this is the sort of thing the 
GridDelegate is supposed to avoid :) (for my purposes: clicking the thumbnail 
opens a page with detailed information about the item represented by the 
thumbnail, and clicking the action causes things to be done to the item without 
opening that page).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: leinir, Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, 
GB_2, kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:6258f33fce3a: [GridViewKCM] improve contrast and 
legibility for delegates inline hover… (authored by ngraham).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50990=50991

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50990.
ngraham added a comment.


  Reverse the order of clicking and triggering, since it looks a bit nicer this 
way

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50982=50990

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Kai Uwe Broulik]

broulik added a comment.


  +1 I think this is a fine tradeoff between aesthetics and usability

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Very nice!

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50982.
ngraham added a comment.


  Use theme-following version for various reasons

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50976=50982

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Actually there is a real issue here. Disabled button icons are much less 
legible with the dark version. The enabled version of the delete button is less 
legible too (red-on-black vs red-on-gray) I think we need to go with the 
version that 100% follows the color scheme instead of always being dark.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Now that I think about it, Elisa also has a variant of this UI that would be 
much better if it adopted this visual style, and i think that one would look 
good with dark buttons too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#406032 , @ngraham wrote:
  
  > Or we could just use frikkin' light buttons. :)
  
  
  I think dark buttons just draw too much attention and doesn't really fit. 
When using the colorscheme the contrast of the button icons should still be 
good, since there is a solid background.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Or we could just use frikkin' light buttons. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Well, this view is used in a lot of different places, so it's not like only 
one thing does it this way now.
  
  But we could do it in Gwenview too, which has the same basic UI but uses 
light buttons. Also maybe we could think about adjusting Dolphin's selection 
marker UI to match it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  Well, I really don't like that this is the only thing that has dark buttons. 
It is inconsistent and just looks out of place. We should probably do some more 
discussion elsewhere if we want do this in other places too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  The buttons are dynamic and are chosen by the individual KCM; what you 
propose would be out of scope even if it were possible.
  
  I think we're going to stay with this basic design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  another option we put the delete button only
  and align it to the corner of the thumbnail
  make it circle button
  and ditch the other one
  no need for it here
  what do u think

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#406019 , @Codezela wrote:
  
  > how about make it global under
  >  beside add image button aligned left
  >  tow buttons disablef by default
  
  
  No, that was the old design we moved away from. The new thing is inline 
buttons.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  how about make it global under
  beside add image button aligned left
  tow buttons disablef by default

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Yeah, the dark version has grown on me too. I'm going to go with that for 
now. The diff is smaller too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50976.
ngraham added a comment.


  Go with the dark version

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50879=50976

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Stefan Brüns]

bruns added a comment.


  The inline version looks a little bit more polished, while the other one 
looks literally "just put on top". The "button" version though somewhat 
resembles the "selection" buttons/emblems in dolphin.
  
  There is a very tiny issue with the button version, although the buttons do 
not overlap, they do touch the text, at least for any full height characters 
("l,i,t,k, ...").

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405368 , @ngraham wrote:
  
  > One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  >
  > Here are our two options:
  >
  > F6588077: Inline dark buttons.gif 
  >
  > F6588078: Slightly escaping light buttons.gif 

  >
  > Maybe we should just take a vote.
  
  
  I like version 2 best, I think the contrast is good enough.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405368 , @ngraham wrote:
  
  > One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  >
  > Here are our two options:
  >
  > F6588077: Inline dark buttons.gif 
  >
  > F6588078: Slightly escaping light buttons.gif 

  >
  > Maybe we should just take a vote.
  
  
  Both are very compelling, I must say! I like version 1 better.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  
  Here are our two options:
  
  F6588077: Inline dark buttons.gif 
  
  F6588078: Slightly escaping light buttons.gif 

  
  Maybe we should just take a vote.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Chris Rizzitello]

rizzitello added a comment.


  I think it looks better slightly off the edge of the item and I agree that if 
its on the item its looks much better with the shaded bar under it.  To improve 
the contrast we could make the button our highlight color when hovered.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Filip Fila]

filipf added a comment.


  Round buttons looked nice, but the square buttons fit in a lot more with 
Breeze.
  
  As for the color, in a vacuum I think the dark buttons look better, but 
contextually they feel weird to me as well. We're used to everything following 
the color scheme.
  
  Inline vs. vertical offset seems like a tomayto tomatoh thing. The offset 
does seem a bit snazzier a bit though, but I don't seem to able to articulate 
why exactly.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  The dark inline buttons entirely within the thumbnail are growing on me. I'll 
sleep on it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405214 , @ngraham wrote:
  
  > I want to point out that the original problem was not that the buttons 
lacked contrast, but that the //icons// were illegible with a variety of 
thumbnail contents. This problem is 100% solved by using a real button with 
background that uses the system color scheme in some capacity (theme-following 
or inverted). Whether the button backgrounds should be theme-following or 
inverted is an aesthetic judgment, not a usability one.
  
  
  Exactly. My argument is to support the direction for usability purposes and 
add an aesthetic element that helps contrast. I think others in the discussion 
want to stop at the usability fix, I want to push that a little more and add 
the aesthetic element.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  I want to point out that the original problem was not that the buttons lacked 
contrast, but that the //icons// were illegible with a variety of thumbnail 
contents. This problem is 100% solved by using a real button with background 
that uses the system color scheme in some capacity (theme-following or 
inverted). Whether the button backgrounds should be theme-following or inverted 
is an aesthetic judgment, not a usability one.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405210 , @abetts wrote:
  
  > In D18649#405209 , @GB_2 wrote:
  >
  > > In D18649#405200 , @ngraham 
wrote:
  > >
  > > > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  > > >
  > > > F6587345: Screenshot_20190204_130444.png 

  > > >
  > > > I have to admit, it ain't half bad.
  > >
  > >
  > > I still think it looks better if it follows the color scheme.
  >
  >
  > Why do you think that? Context?
  
  
  For the reasons @ngraham gave.
  It just doesn't look right IMO.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405209 , @GB_2 wrote:
  
  > In D18649#405200 , @ngraham 
wrote:
  >
  > > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  > >
  > > F6587345: Screenshot_20190204_130444.png 

  > >
  > > I have to admit, it ain't half bad.
  >
  >
  > I still think it looks better if it follows the color scheme.
  
  
  Why do you think that? Context?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405200 , @ngraham wrote:
  
  > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  >
  > F6587345: Screenshot_20190204_130444.png 

  >
  > I have to admit, it ain't half bad.
  
  
  I still think it looks better if it follows the color scheme.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405200 , @ngraham wrote:
  
  > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  >
  > F6587345: Screenshot_20190204_130444.png 

  >
  > I have to admit, it ain't half bad.
  
  
  Thank you for trying it out Nate. I appreciate your willingness to take turns 
in our thinking.
  
  I agree, it doesn't look bad. If it was placed the way you proposed, at the 
top right, or bottom right, a little over the image frame, it would stand out 
even more. Either way works for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  
  F6587345: Screenshot_20190204_130444.png 

  
  I have to admit, it ain't half bad.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405180 , @ngraham wrote:
  
  > In D18649#405179 , @abetts wrote:
  >
  > > I was thinking of dark buttons mostly. Something along these lines\
  > >
  > > https://dribbble.com/shots/5204192-Buttons-Dark
  > >
  > > I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.
  >
  >
  >
  >
  > 1. If there's a problem with Breeze colors, we should fix it there rather 
than working around this in downstream software
  
  
  I disagree on this point. I feel the problem we experience is the belief that 
breeze colors should be slapped on every element on the desktop. There is 
nothing wrong with Breeze colors, but we should allow for variations within 
without thinking that Breeze needs to change. I am suggesting that we can make 
these buttons show more contrast by "not" using the main gray breeze color as 
the background for them. Instead we use something a little more subtle and that 
can help our line-art icons stand out. You proposed a really good idea of 
floating buttons but we have bumped into the same problem we did before, that 
the contrast of these buttons is not great.
  
  > 2. If anything I think the gray color used for our button backgrounds is 
too dark, not too light. Right now it's the exact same color as the window 
background. Most other color schemes make buttons a bit lighter, and I think 
that looks better in general
  > 3. The only elements that use a dark background with the Breeze light theme 
are tooltips; making only these buttons dark would be inconsistent with every 
other button in every other piece of KDE software
  
  And to the user, what does this mean? I think it means something to us, but 
not necessarily them. I don't see users saying, "OMG, this button is dark, not 
light, that color belongs in tooltips... KDE is so inconsistent..." To me, what 
works here is practicality. By trying to align the concepts to the rest of the 
desktop environment, we are limiting ourselves from providing good contrast and 
practical functionality.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Kai Uwe Broulik]

broulik added a comment.


  Can we put the buttons at least fully inside the frame? With the boxes 
halfway outside it looks weird imho

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405179 , @abetts wrote:
  
  > I was thinking of dark buttons mostly. Something along these lines\
  >
  > https://dribbble.com/shots/5204192-Buttons-Dark
  >
  > I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.
  
  
  
  
  1. If there's a problem with Breeze colors, we should fix it there rather 
than working around this in downstream software
  2. If anything I think the gray color used for our button backgrounds is too 
dark, not too light. Right now it's the exact same color as the window 
background. Most other color schemes make buttons a bit lighter, and I think 
that looks better in general
  3. The only elements that use a dark background with the Breeze light theme 
are tooltips; making only these buttons dark would be inconsistent with every 
other button in every other piece of KDE software

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405162 , @GB_2 wrote:
  
  > I think it looks good.
  
  
  I was thinking of dark buttons mostly. Something along these lines\
  
  https://dribbble.com/shots/5204192-Buttons-Dark
  
  I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  I think it looks good.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  I like this version because it feels slightly more conventional with the 
square-ish KDE-style buttons. A blend of old and new, so to speak. It says, "I 
may be modern and sleek, but I'm still a powerful KDE app, not some garbage 
mobile UI inappropriately applied to the traditional desktop you know and love."
  
  At least, that's what it says to me. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405156 , @ngraham wrote:
  
  > Use square buttons and put them on the bottom right, not the top right
  
  
  The functionality seems great! We might need to do more padding with labels. 
Is there any way we can style the buttons in different ways? Colors, shades, 
etc? I don't mind the square but doesn't look very good when it uses regular 
breeze colors.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50879.
ngraham added a comment.


  Use square buttons and put them on the bottom right, not the top right

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50869=50879

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405153 , @ngraham wrote:
  
  > Nah, it's actually fine:
  >
  > F6587198: Screenshot_20190204_122428.png 

  
  
  Oh, ok, then it's fine!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Nah, it's actually fine:
  
  F6587198: Screenshot_20190204_122428.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  Now that I think about it though, the buttons overlap the label of the label 
text is long...

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405146 , @ngraham wrote:
  
  > Like this? Or fully contained within the thumbnail?
  >
  > F6587190: Screenshot_20190204_122020.png 

  
  
  This is good!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Like this? Or fully contained within the thumbnail?
  
  F6587190: Screenshot_20190204_122020.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405137 , @ngraham wrote:
  
  > Not sure I catch your meaning, sorry. How big should the square buttons be? 
I kinda like them at that size TBH. Gwenview also has inline square hover 
buttons like this and it's fine.
  
  
  Ok, but can we put them on the bottom right?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Not sure I catch your meaning, sorry. How big should the square buttons be? I 
kinda like them at that size TBH. Gwenview also has inline square hover buttons 
like this and it's fine.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405094 , @ngraham wrote:
  
  > In D18649#405091 , @GB_2 wrote:
  >
  > > What if the buttons just looked normal and not so big and not as circles?
  >
  >
  > With regular-sized square buttons:
  >
  > F6587075: Small square buttons.png 
  
  
  Maybe twice as big buttons on the bottom right?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405091 , @GB_2 wrote:
  
  > What if the buttons just looked normal and not so big and not as circles?
  
  
  With regular-sized square buttons:
  
  F6587075: Small square buttons.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  Just some variations on Nate's idea:
  
  https://dribbble.com/shots/4981650-Floating-Button-Micro-Interaction
  
  https://dribbble.com/shots/2619684-Expense-Floating-Button
  
  The floating buttons is a very Android-unique feature. Not sure we are 
copying that if we utilize something similar. But I think it is very effective. 
It keeps the action buttons where the actions are happening. This also reminds 
me of the way that the mobile version of pinterest works.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  What if the buttons just looked normal and not so big and not as circles?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405082 , @ngraham wrote:
  
  > In D18649#405081 , @abetts wrote:
  >
  > > In D18649#405078 , @ngraham 
wrote:
  > >
  > > > Use round buttons in the corner rather than an inline toolbar
  > >
  > >
  > > What does it look like now?
  >
  >
  > Test Plan section updates with new screenshots. :)
  
  
  That looks very interesting. Very Android in the way that the buttons are 
laid out. I like them. I think it is a good direction. It may be a bit rough, I 
will propose some examples along this idea.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#405081 , @abetts wrote:
  
  > In D18649#405078 , @ngraham 
wrote:
  >
  > > Use round buttons in the corner rather than an inline toolbar
  >
  >
  > What does it look like now?
  
  
  Test Plan section updates with new screenshots. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405078 , @ngraham wrote:
  
  > Use round buttons in the corner rather than an inline toolbar
  
  
  What does it look like now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50869.
ngraham added a comment.


  Use round buttons in the corner rather than an inline toolbar

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50662=50869

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I'll work on that.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Filip Fila]

filipf added a comment.


  ^ I agree, I really like that emblems solution now that I've seen it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a subscriber: andreask.
ngraham added a comment.


  This is a variant of the issue we've seen with desktop icons and UI elements 
on the login screen: there is no way to ensure legibility against arbitrary 
backgrounds without a contrast-adding element of some sort, like a shadow or a 
flat color background There is no other way.
  
  Now, that doesn't mean that the contrast element needs to be a horizontal bar 
at the bottom of the delegate like I've got it here. @andreask posted a mockup 
of something that looked pretty nice to me:
  
  F6582097: Screenshot_20190201_163049.png 

  
  But there has to be //some// contrast-adding element, or else it is 
inevitable that the icon will be illegible with some backgrounds.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Filip Fila]

filipf added a comment.


  There's definitely a legibility issue here. I do, however, think the gradient 
is a sleeker solution. The problem for me has actually been with the icons 
themselves. They're too scrawny and become more legible when thicker:
  
  F6582065: Screenshot_20190202_001342.png 

  
  Especially when they're like this:
  
  F6582057: Screenshot_20190202_001403.png 

  
  My fave solution would be to tweak the icons (maybe have special ones just 
for this use case) and to strengthen the gradient more. But this solution here 
works as well and it's not a big deal.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#403336 , @ngraham wrote:
  
  > In D18649#40 , @abetts wrote:
  >
  > > I love that implementation. I bounced back ideas with Marco long ago 
about this. I think we should implement it in all other KCMs with similar 
representations.
  >
  >
  > Yep, if this patch lands, then it will apply to all of them automatically. 
The screenshots are just depictions of how it happens to look with the Colors 
KCM.
  
  
  Looks great Nate, thanks!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#40 , @abetts wrote:
  
  > I love that implementation. I bounced back ideas with Marco long ago about 
this. I think we should implement it in all other KCMs with similar 
representations.
  
  
  Yep, if this patch lands, then it will apply to all of them automatically. 
The screenshots are just depictions of how it happens to look with the Colors 
KCM.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  I love that implementation. I bounced back ideas with Marco long ago about 
this. I think we should implement it in all other KCMs with similar 
representations.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Yeah, that was why I went with 0.8. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#403326 , @ngraham wrote:
  
  > Here's 0.65 opacity instead: F6581631: 0.65 opacity.png 

  
  
  Ok, the previous was better because you could see the red trash icon better.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Here's 0.65 opacity instead: F6581631: 0.65 opacity.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  Good idea, but I think it's a bit too dark.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the delegates' inline hover buttons can be very difficult to see, 
because they're
  (mostly) white and don't get much background contrast, and the thumbnail 
lightens too, further
  reducing contrast against white icons.
  
  This patch improves the situation by replacing the current geadient 
background bar with a
  darker semi-transparent solid color.
  
  BUG: 395510
  FIXED-IN: 5.55

TEST PLAN
  Colors KCM, before: F6581603: Colors KCM grid delegates, before 

  
  Colors KCM, after: F6581604: Colors KCM grid delegates, after 


REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns