D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a task: T10325: 5.16 Login screen redesign.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a dependent revision: D19129: [sddm-theme] Apply new username 
prompt and user list icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414802 , @ngraham wrote:
  
  > I love it. Looks perfect to me now.
  
  
  Thanks :D Will be landing it shortly

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  I love it. Looks perfect to me now.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51997.
rooty added a comment.


  Use more integers

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51993=51997

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51993.
rooty added a comment.


  Make Z's larger

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51985=51993

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment.


  I actually did resize this one too because you can never be quite sure which 
22 px icon will be used hahahah
  And I grazed the top margin a little bit but I actually managed to stay 
within all the other margins

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51985.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51982=51985

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Actually those concerns should be in the icon theme patch, never mind.
  
  I'm good with this now! Thoughts, other #vdg 
 people? Shall we land this?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a comment.


  Oh and one more minor thing: the Zs look a bit small in Kickoff and 
especially Kicker when using a non-high-DPI display:
  
  F6621746: Screenshot_20190218_105639.png 

  
  F6621748: Screenshot_20190218_105747.png 

  
  I guess the moon and snowflake iconography will have to hold the line :)
  
  The new switch user also doesn't seem to handle being scaled down very well. 
Can we make it a tiny bit bigger if it's not already at the edge of its margins?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51982.
rooty added a comment.


  Remove second filled in user from 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51954=51982

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a comment.


  Almost perfect! I have one remaining visual nitpick:
  
  F6621734: Black.png 
  
  Can we make the small version of the switch user icon have a body that's not 
filled in with Shade Black? That way it will match the small versions of all 
the icons user-style icons, all of which have outline bodies and black heads.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Filip Fila
filipf added a comment.


  I think the current revision is quite nice. We could always pick apart 
details and other potential solutions, but the icons get the point across and 
look good.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414339 , @ndavis wrote:
  
  > That last little square in the username bothers me.
  
  
  If only I could use text/lettering...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51954.
rooty added a comment.


  Remove second square from username bar

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51938=51954

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Noah Davis
ndavis added a comment.


  In D19020#414317 , @rooty wrote:
  
  > In D19020#414300 , @abetts wrote:
  >
  > > Well, maybe it is time to call it and be done. I don't think we are going 
to please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.
  >
  >
  > You're right, and thanks for giving me the nudge I needed :D
  >
  > Okay so, I propose the icon remain the way it is right now:
  >  F6620691: image.png 
  > because
  >  (1) we can't use an I beam with or without dots (the label is too vague)
  >  (2) we could use a long bar, but it looks kind of like a progress bar
  >  (3) we could use a circle, but we technically don't need to - and this 
sort of stresses the fact that it's an entirely different login screen that 
it'll take you to
  
  
  That last little square in the username bothers me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414300 , @abetts wrote:
  
  > Well, maybe it is time to call it and be done. I don't think we are going 
to please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.
  
  
  You're right, and thanks for giving me the nudge I needed :D
  
  Okay so, I propose the icon remain the way it is right now:
  F6620691: image.png 
  because
  (1) we can't use an I beam with or without dots (the label is too vague)
  (2) we could use a long bar, but it looks kind of like a progress bar
  (3) we could use a circle, but we technically don't need to - and this sort 
of stresses the fact that it's an entirely different login screen that it'll 
take you to

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51938.
rooty added a comment.


  Center user prompt icon vertically

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51920=51938

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Andres Betts
abetts added a comment.


  Well, maybe it is time to call it and be done. I don't think we are going to 
please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414285 , @abetts wrote:
  
  > I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  >
  > "Enter User"
  >  "Type User"
  >  "Change User"
  
  
  haha it was actually changed to Type User then to Other... because we 
couldn't settle on a name, and thr fact that Verb + User sounds worse 
(grammatically) than Verb + Username (and Username is too long)
  
  Change User also doesn't capture what the screen does
  
  I think the label that truly captures that button is "Use Prompt" but it 
looks so ... weird :D

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Andres Betts
abetts added a comment.


  I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  
  "Enter User"
  "Type User"
  "Change User"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414231 , @trickyricky26 
wrote:
  
  > As they are now it's long, short, long (exact same length as rectangle 
number 1), shorter than height (which looks bad imo). There are no medium 
lengths and the same length is used twice. I would suggest giving every bar a 
different length.
  >
  > If you're going to remove the spaces, this won't be an issue, but I would 
not remove the spaces until we are certain that spaces are not allowed in the 
real thing.
  
  
  Oh I don't mind removing the spaces
  F6620461: image.png 
  But people have complained that the end result looks like a progress bar...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment.


  As they are now it's long, short, long (exact same length as rectangle number 
1), shorter than height (which looks bad imo). There are no medium lengths and 
the same length is used twice. I would suggest giving every bar a different 
length.
  
  If you're going to remove the spaces, this won't be an issue, but I would not 
remove the spaces until we are certain that spaces are not allowed in the real 
thing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment.


  In D19020#414224 , @trickyricky26 
wrote:
  
  > I like it!
  >
  > I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  >  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.
  
  
  You're right about the spaces, I'll remove them
  But what do you mean by less regular in width?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment.


  I like it!
  
  I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51920.
rooty added a comment.


  Replace "Other..." icon with newer version

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51909=51920

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment.


  @abetts
  
  F6620144: image.png 
  
  This is what I came up for the login/password field idea. What do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51909.
rooty added a comment.


  Add new switch user icons

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51821=51909

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a dependent revision: D19074: [breeze-icons] Implement new suspend 
and hibernate icons in Breeze icon theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51821.
rooty added a comment.


  Fix suspend icon height

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51793=51821

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51793.
rooty added a comment.


  Use Zs instead of stars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51727=51793

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham added a comment.


  Yeah in and of itself, the snowflake is good. I think it just needs something 
added to it so it doesn't look like it turns on the air conditioning as Kai 
alluded to. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a comment.


  In D19020#412775 , @ngraham wrote:
  
  > +1 on the List Users icon. Perfect.
  >
  > For the Type User icon, I'm not sure it needs to be in a circle. With the 
new moon-style suspend icon on the left side, it might be better to have a 
non-round icon on the right side to balance it out.
  >
  > I like the moon iconography in general. However I'm not as big a fan of the 
stars. They feel too regular, and the whole effect makes me think of the symbol 
for Islam: F6616841: islam-symbol-300x300.jpg 

  >
  > Likewise, I don't think the new Hibernate symbol works on its own. Alone, 
it's just a snowflake, which to me means "snow" or "cooling" or "winter 
weather".
  >
  > I think both of these symbols would benefit from having three Zs in the 
top-right corner like we discussed earlier. That would tie them both together 
conceptually as well as reinforce the concept that they're both modes of sleep.
  >
  > Something like this (warning: crude icon butchery incoming):
  >
  > F6616845: Screenshot_20190215_074707.png 

  
  
  But you're okay with the snowflake?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 on the List Users icon. Perfect.
  
  For the Type User icon, I'm not sure it needs to be in a circle. With the new 
moon-style suspend icon on the left side, it might be better to have a 
non-round icon on the right side to balance it out.
  
  I like the moon iconography in general. However I'm not as big a fan of the 
stars. They feel too regular, and the whole effect makes me think of the symbol 
for Islam: F6616841: islam-symbol-300x300.jpg 

  
  Likewise, I don't think the new Hibernate symbol works on its own. Alone, 
it's just a snowflake, which to me means "snow" or "cooling" or "winter 
weather".
  
  I think both of these symbols would benefit from having three Zs in the 
top-right corner like we discussed earlier. That would tie them both together 
conceptually as well as reinforce the concept that they're both modes of sleep.
  
  Something like this (warning: crude icon butchery incoming):
  
  F6616845: Screenshot_20190215_074707.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Noah Davis
ndavis added a comment.


  In D19020#412584 , @broulik wrote:
  
  > What's the air conditioning do? suspend to disk?
  >
  > +1 on the moon for suspend
  
  
  Yes. The previous symbol was a sun-like symbol (22px old version left of 32px 
new version): https://irc-attachments.kde.org/N8WwzDwg/file_13313.jpg

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Kai Uwe Broulik
broulik added a comment.


  What's the air conditioning do? suspend to disk?
  
  +1 on the moon for suspend

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty edited the summary of this revision.
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty updated this revision to Diff 51727.
rooty added a comment.


  Add suspend moon/crescent and hibernate snowflake (thanks Noah!)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51718=51727

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty retitled this revision from "[breeze-icons] WIP, Add "Type User" and 
"List Users" icons" to "[breeze-icons] Revamp system.svgz".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns