D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3b88babfed6c: [breeze-icons] Use new suspend, hibernate 
and switch user icons in Breeze icon… (authored by rooty).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51996=52002

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it. Looks perfect to me now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51996.
rooty added a comment.


  Make all the Z's bigger

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51986=51996

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414750 , @ngraham wrote:
  
  > Or they could all be a bit bigger, and the snowflake versions could simply 
take up a teensy bit more of the snowflake's top-right corner.
  
  
  Yeah I made all the Z's bigger, it should be better now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  Or they could all be a bit bigger, and the snowflake versions could simply 
take up a teensy bit more of the snowflake's top-right corner.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  F6621821: image.png 
  
  I'm gonna edit system.svgz too, for consistency's sake

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  Just for the smaller versions.
  
  Yes, let's add Hibernate too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414706 , @ngraham wrote:
  
  > That could work, yeah. Give it a try!
  
  
  22 px or 32 px too?
  
  Because the 32 px version matches the desktop theme 32 px version as is
  
  P.S. What about hibernate? I don't have that icon in Kickoff but other people 
might?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  That could work, yeah. Give it a try!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414689 , @ngraham wrote:
  
  > The Zs look a bit small in Kickoff and especially Kicker when using a 
non-high-DPI display:
  >
  > F6621746: Screenshot_20190218_105639.png 

  >
  > F6621748: Screenshot_20190218_105747.png 

  >
  > We might need to simplify the icons for the small sizes and/or make the Zs 
bigger.
  
  
  What about just two (big) Z's?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51986.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51910=51986

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  The Zs look a bit small in Kickoff and especially Kicker when using a 
non-high-DPI display:
  
  F6621746: Screenshot_20190218_105639.png 

  
  F6621748: Screenshot_20190218_105747.png 

  
  We might need to simplify the icons for the small sizes and/or make the Zs 
bigger.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51910.
rooty added a comment.


  Implement the newer versions of all three icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51889=51910

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51889.
rooty added a comment.


  Use symbolic links instead (icons are already present)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51888=51889

BRANCH
  new-suspend-hibernate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#413824 , @ngraham wrote:
  
  > While you're at it, can you also replace `system-switch-user` in the Breeze 
icon theme with the much better version that's in the Breeze Plasma theme?
  
  
  I'm so sorry, I didn't even notice before making the diff - there are two 
icons in the system.svgz (Breeze desktop theme) that look really similar:
  "system-switch-user" (one user + arrow): F6619519: image.png 

  and "system-users" (two users): F6619521: image.png 

  
  I accidentally replaced system-switch-user in the //icon// theme with 
system-users (not system-switch-user) in the desktop theme.
  
  Should I roll that back? Or should I make the appropriate modifications to 
"look and feel" so the Plasma theme would use the two user icon instead of the 
one user + arrow one?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty retitled this revision from "[breeze-icons] Implement new suspend 
hibernate and switch user icons in Breeze icon theme" to "[breeze-icons] Use 
new suspend, hibernate and switch user icons in Breeze icon theme".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns