D23225: Allow 0 in line ranges in vim mode.
This revision was automatically updated to reflect the committed changes. Closed by commit R39:066004396d57: fix vi mode unit test (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23225?vs=63944&id=63973#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23225?vs=63944&id=63973 REVISION DETAIL https://phabricator.kde.org/D23225 AFFECTED FILES autotests/src/vimode/emulatedcommandbar.cpp To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
cullmann added a comment. Jonathan, could you take a look? Thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
cullmann reopened this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
dfaure added a comment. The unittest doesn't seem to pass on CI: https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/ FAIL! : EmulatedCommandBarTest::EmulatedCommandBarTests() Compared values are not the same Actual (kate_document->text()): "bar\nbar\nbar" Expected (expected_text): "foo\nfoo\nbar" Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)] REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
This revision was automatically updated to reflect the committed changes. Closed by commit R39:622bd6c94803: Allow 0 in line ranges in vim mode. (authored by verner, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23225?vs=63943&id=63944 REVISION DETAIL https://phabricator.kde.org/D23225 AFFECTED FILES autotests/src/vimode/emulatedcommandbar.cpp src/vimode/commandrangeexpressionparser.cpp To: verner, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks for taking care ;=) I you use the vi mode, we have more open vi mode bugs that need some love: https://bugs.kde.org/buglist.cgi?bug_severity=critical&bug_severity=grave&bug_severity=major&bug_severity=crash&bug_severity=normal&bug_severity=minor&bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&list_id=1655504&order=component%20DESC%2Cbug_status%20DESC%2Cbug_severity%2Cpriority%2Cassigned_to%2Cbug_id&product=frameworks-ktexteditor&product=kate&query_format=advanced (vi input component) We have some hack to fix one of them here, that needs some research: https://phabricator.kde.org/D19408 REPOSITORY R39 KTextEditor BRANCH fix/vim_mode_accept_0_as_line_index (branched from master) REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
verner added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23225: Allow 0 in line ranges in vim mode.
verner created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. verner requested review of this revision. REVISION SUMMARY Vim numbers lines starting from 1. However, in command ranges such as, e.g., 0,$s/foo/bar/g it accepts zero as a line number and treats it as 1. This commit implements the same behaviour for kate. REPOSITORY R39 KTextEditor BRANCH fix/vim_mode_accept_0_as_line_index (branched from master) REVISION DETAIL https://phabricator.kde.org/D23225 AFFECTED FILES autotests/src/vimode/emulatedcommandbar.cpp src/vimode/commandrangeexpressionparser.cpp To: verner Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
