D23926: Move "Details" tab to second place in Properties dialog

2020-04-20 Thread Matej Mrenica 
mthw abandoned this revision.
mthw added a comment.


  I don't have the time (nor skill really) to work on this. Feel free to take 
over if you want to.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, 
trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, bruns, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, 
mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-04-20 Thread Björn Feber 
GB_2 added a comment.


  Ping :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, 
skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in kpropertiesdialog.cpp:645
>   /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: 
> ‘class KService’ has no member named ‘serviceId’
> 
> `QStringLiteral`

Build failure from this issue is not resolved yet

> kpropertiesdialog.h:251
> + */
> +void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, 
> int index);
> +

Remove `KPropertiesDialog::` from this function definition

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Matej Mrenica 
mthw updated this revision to Diff 77450.
mthw added a comment.


  Sorry about that, I should have checked waht I am sending.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=77445=77450

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  For future reference, you can rebase like so:
  
git fetch
git rebase origin/master
  
  Also please make sure your code at least compiles before submitting a patch 
or a change to an existing patch.

INLINE COMMENTS

> kpropertiesdialog.cpp:645
> +
> +if (ptr->serviceId() == 
> QStringLitteral("baloofilepropertiesplugin")) {
> +q->insertPluginAt(plugin, 1);

/home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: ‘class 
KService’ has no member named ‘serviceId’

`QStringLiteral`

> kpropertiesdialog.h:251
> + */
> +void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, 
> int index)
>  

missing the semicolon

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Matej Mrenica 
mthw updated this revision to Diff 77445.
mthw added a comment.


  I don't really know how to do a rebase propertly so I hope I managed to do 
the same manually.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=77388=77445

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Nathaniel Graham 
ngraham added a comment.


  This needs a rebase.

INLINE COMMENTS

> kpropertiesdialog.cpp:643
> +if (ptr->serviceId() == 
> QStringLitteral("baloofilepropertiesplugin")) {
> +q->insertPluginAt(plugin,1);
> +} else {

space before the comma

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-11 Thread Matej Mrenica 
mthw updated this revision to Diff 77388.
mthw added a comment.


  - Made recomemded changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=66003=77388

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-09 Thread Méven Car 
meven added a comment.


  In D23926#624753 , @mthw wrote:
  
  > @meven So, the first version of this diff is good enough?
  
  
  Well no I missed @ngraham points that still stands.
  And your current code result with the same effect anyway as long as we miss 
the condition "only if details plugin"
  
  We don't have a "clean" way to do this.
  One way to do the trick would be to look at the `KService::Ptr ` `icon()` 
which will return "baloo" or the `storageId()` that should give 
"baloofilepropertiesplugin.desktop" for the baloo details plugin.
  The storageId method should be preferred as less likely to change.
  
if (ptr->serviceId() == QStringLitteral("baloofilepropertiesplugin")) {
q->insertPluginAt(plugin,1);
} else {
q->insertPlugin(plugin);
}
  
  Should be close enough to a working somewhat satisfying solution
  
  I hope this helps.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-09 Thread Matej Mrenica 
mthw added a comment.


  @meven So, the first version of this diff is good enough?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2020-03-09 Thread Méven Car 
meven added a comment.


  In D23926#538778 , @mthw wrote:
  
  > > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, 
you'd want to do something more like this:
  > > 
  > > 
  > > 
  > >   if (plugin == "details"  /* this is pseudocode */) {
  > >   q->insertPluginAt(plugin, 1);
  > >   } else {
  > >   q->insertPlugin(plugin);
  > >   }
  > > 
  > > 
  > > I'm actually not sure how to check for what the plugin is though. Maybe 
someone from #frameworks  can help.
  >
  > This is mostly done but we still need to do this the check, but neither me 
nor @ngraham know how to do it.
  
  
  An alternative would be to move the whole block inserting 
KPropertiesDialog/Plugin before "KChecksumsPlugin".
  AFAIK there are only two KPropertiesDialog/Plugin, so this would move details 
and baloo both of before the rest, which is fine IMO.
  You would not need an integer parameter to `insertPluginAt` anymore.

INLINE COMMENTS

> kpropertiesdialog.cpp:586
>  
> +
>  if (KFilePermissionsPropsPlugin::supports(m_items)) {

Not needed, if you could remove

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-10-11 Thread Matej Mrenica 
mthw added a comment.


  Any progress on this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-27 Thread Matej Mrenica 
mthw added a comment.


  > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd 
want to do something more like this:
  > 
  > 
  > 
  >   if (plugin == "details"  /* this is pseudocode */) {
  >   q->insertPluginAt(plugin, 1);
  >   } else {
  >   q->insertPlugin(plugin);
  >   }
  > 
  > 
  > I'm actually not sure how to check for what the plugin is though. Maybe 
someone from #frameworks  can help.
  
  This is mostly done but we still need to do this the check, but neither me 
nor @ngraham know how to do it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-27 Thread Björn Feber 
GB_2 added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Nathaniel Graham 
ngraham added reviewers: cfeck, pino.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw updated this revision to Diff 66003.
mthw added a comment.


  Don't move the commented-out code, better description in header, formatting.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65988=66003

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw updated this revision to Diff 65988.
mthw added a comment.


  Changes made, if clause still not there

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65986=65988

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Nathaniel Graham 
ngraham added a comment.


  More or less! A new things:
  
  1. Don't forget to add the function definition for 
`KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, int index)` 
to the header file
  2. Revert the change where you moved that section; it's now unnecessary
  3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd 
want to do something more like this:
  
  
  
if (plugin == "details"  /* this is pseudocode */) {
q->insertPluginAt(plugin, 1);
} else {
q->insertPlugin(plugin);
}
  
  I'm actually not sure how to check for what the plugin is though. Maybe 
someone from #frameworks  can help.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw added a comment.


  I didn't know what to do with this
  
  > ...check to see if the plugin we've just created is the Details plugin,...
  
  Also the "Generator" should probably go back where it was right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw updated this revision to Diff 65986.
mthw added a comment.


  Do you mean something like this? Only a wild guess, C lang is not my strength.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65977=65986

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 for the general idea. However this implementation only incidentally does 
what you want it to do. I apologize for steering you this way in the bug 
report, because it looks a bit more complicated than I thought, and we may have 
to puzzle through a more complex change.
  
  So right now, the ordering goes like this:
  
  - General tab
  - Permissions tab
  - Checksums tab
  - Auto-generated tabs that depend on the context (of which Details is one)
  
  So if we just move the auto-generated section to the second position, we 
can't actually guarantee that Details always comes first in that list.
  
  What you could maybe do is add a new function 
`KPropertiesDialog::insertPluginAt()` that takes an int value `index` and 
inserts the plugin at that position in the index with 
`d->m_pageList.insert(index, plugin);`, then around line 628, check to see if 
the plugin we've just created is the Details plugin, and use the new function 
to specifically insert it at index 1 (which is position 2 since we start 
counting from zero).
  
  Does that sound like a plan? I'll be happy to help you through it!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Björn Feber 
GB_2 added a comment.


  +1
  Next time please also add VDG as a subsriber and reviewer if there is a UI 
related change :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Björn Feber 
GB_2 added reviewers: Frameworks, VDG.
GB_2 added a project: VDG.
GB_2 added subscribers: Frameworks, Dolphin, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw edited the summary of this revision.
mthw added a reviewer: Dolphin.
mthw added a project: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23926: Move "Details" tab to second place in Properties dialog

2019-09-13 Thread Matej Mrenica 
mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.

REVISION SUMMARY
  This change moves the "Details" tab to second place because it makes more 
sense. //more later

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: mthw
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns