D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:00213a3a0906: kconfig_compiler : generate kconfig 
settings with subgroup (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77426=80841

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks, meven
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Méven Car]

meven accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks, meven
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  In D27133#625924 , @apol wrote:
  
  > The patch and the feature sound good to me, the resulting xml feels a bit 
weird and could use some clarification.
  
  
  Thank you for your comment.
  
  I agree it looks a bit odd, nested group element would be more xmlish.
  We choose a simpler approach as moving in the kconfig_compiler code isn't 
easy and the need was for one kcm (notifications).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Aleix Pol Gonzalez]

apol added a comment.


  The patch and the feature sound good to me, the resulting xml feels a bit 
weird and could use some clarification.

INLINE COMMENTS

> test_subgroups.kcfg:21
> +
> +
> +

It feels odd to reference the parent name rather than having a group inside the 
other.

Why don't we do something like:

  
  //entries
  
  //entries
  
  

Might be missing something.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  @dfaure, any opinion on this revision ?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77426.
crossi added a comment.


  rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77049=77426

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi marked 5 inline comments as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77049.
crossi added a comment.


  rename attribute to parentGroupName

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=76833=77049

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi planned changes to this revision.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in test_subgroups.kcfg:10
> Now that I see it, I think I'd go for "parentGroupName" since this is not 
> referential and really about the name (like the name parameter)

`parentGroupName` sounds more explicit, I will replace with it.

> ervin wrote in KConfigSourceGenerator.cpp:354
> Unrelated right, this is not due to your patch, or am I confused?

It was there before my patch, just pointing it for later.

Fortunately, some of the concerns have been addressed in D27497 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kconfigcompiler_test.cpp:80
>  "test_signal",
> +"test_notifiers",
>  "test_translation_kde",

This seems unrelated... So we had this test case available but it was in fact 
never run?

> test_subgroups.kcfg:10
> +
> +
> +

Now that I see it, I think I'd go for "parentGroupName" since this is not 
referential and really about the name (like the name parameter)

> test_subgroups.kcfg:20
> +
> +

Probably worth also having cases with:

- the group name being parameterized but not the parentGroup
- both name and parentGroup not be parameterized

Just to have all the possible combinations.

> KConfigSourceGenerator.cpp:354
>  
> +// TODO : Some compiler option won't work or generate bogus settings file.
> +// * Does not manage properly Notifiers=true kcfgc option for parameterized 
> entries :

Unrelated right, this is not due to your patch, or am I confused?

> KConfigXmlParser.cpp:502
>  
> +QString parentGroup = e.attribute(QStringLiteral("parentGroup"));
> +

I'd const auto it, or at least const.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 76833.
crossi added a comment.


  rework: introduce parentGroup attribute to group element

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75059=76833

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi planned changes to this revision.
crossi added a comment.


  Thanks for your comments.
  
  A new attribute to the group element would be more readable and easier to 
edit/maintain.
  
  To generate code like :
  
KConfig config;
KConfigGroup generalGroup( , "General" );
KConfigGroup colorsGroup = config.group( "Colors" );
  
  kcfg will look like :
  


true


  
  Currently, I only need one level of subgroup, let's keep it simple and drop 
the group separator stuff for the moment.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[David Faure]

dfaure added a comment.


  OK. `man ascii` says 0x1d is "GS (group separator)", not completely bogus :)
  
  I wonder how/why it becomes  in XML, but quick googling says that 
entity seems to be '␝' which indeed reads GS :)
  
  At the KConfig level, this is good for catching people who don't use the 
proper APIs that encapsulate that stuff :-)
  But at the kconfig_compiler level, people want to be able to write XML files 
by hand.
  So "modifying the schema to be able to specify subgroups in the XML" sounds 
like the way to go, not coming up with yet another weird character (it might as 
well be this one then, for consistency).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin added a comment.


  In D27133#617577 , @dfaure wrote:
  
  > I really have zero experience with this stuff, but you're asking for my 
opinion nonetheless, so you'll get it, as crappy as it might be :-)
  >
  > Your comment refers to "group separator" as if it was an existing notion in 
KConfig. Can you point me where? Grepping for '241' or for 'separator' gives 
nothing.
  >  Do KConfig files use this already? Or is this all kconfig_compiler 
specific?
  >  I told you, I'm clueless :-)
  
  
  Right, on the C++ side you'd have to look for \x1d

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[David Faure]

dfaure added a comment.


  I really have zero experience with this stuff, but you're asking for my 
opinion nonetheless, so you'll get it, as crappy as it might be :-)
  
  Your comment refers to "group separator" as if it was an existing notion in 
KConfig. Can you point me where? Grepping for '241' or for 'separator' gives 
nothing.
  Do KConfig files use this already? Or is this all kconfig_compiler specific?
  I told you, I'm clueless :-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin added a comment.


  @dfaure, any opinion on the separator character? It came from me checking 
which character is forbidden in group names, and it seems that only "group 
separator" is, so it started a bit like a joke with "I wonder if we'd need to 
patch KConfigSkeleton at all for subgroups if we pass that in a name", turns 
out we don't really and seeing how it look in the XML is... meh.
  
  I see two ways out: modifying the schema to be able to specify subgroups in 
the XML or hijacking a different character that no one use in the wild (which 
would mean looking at every single kcfg out there... not easy).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75056.
crossi added a comment.


  fix compiling error for kcfgfile arg="true"

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75032=75056

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75059.
crossi added a comment.


  update tests

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75056=75059

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> crossi wrote in KConfigSourceGenerator.cpp:335
> I'm open for another separator, btw this part is not intended for the user, 
> they have super user friendly KCM to edit their settings.
> 
> Adding nested  as you mentioned has bigger impact on compiler, xsd, 
> and so on.

Here, I meant kcfg user, i.e dev users, since kconfig is a lib

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigSourceGenerator.cpp:335
> This character won't be easy on the user.
> Ideally we perhaps would want to allow users to add  
> 
> We could use alternatively attributes.

I'm open for another separator, btw this part is not intended for the user, 
they have super user friendly KCM to edit their settings.

Adding nested  as you mentioned has bigger impact on compiler, xsd, and 
so on.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75032.
crossi added a comment.


  remove TODO comment that was addressed

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=74938=75032

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> KConfigSourceGenerator.cpp:335
> +// TODO : what happened when same group is repeated ?
> +if (mCurrentGroup.contains(QStringLiteral("\u241D"))) {
> +stream() << "  " << itemPath(entry, cfg()) << "->setGroup(cg" << 
> QString(entry->group.split(QStringLiteral("\u241D")).last()).remove(QRegExp(QStringLiteral("\\W")))
>  << ");\n";

This character won't be easy on the user.
Ideally we perhaps would want to allow users to add  

We could use alternatively attributes.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin added reviewers: dfaure, Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 74938.
crossi added a comment.


  noop

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=74937=74938

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi created this revision.
crossi added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D27059 , add group separator to 
generate kconfig settings with subgroups

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns