D27913: Icons for emoji categories

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:90ed6fdf4317: Icons for emoji categories (authored by Guo 
Yunhe i...@guoyunhe.me).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27913?vs=77169=77393

REVISION DETAIL
  https://phabricator.kde.org/D27913

AFFECTED FILES
  icons-dark/actions/22/animal.svg
  icons-dark/actions/22/food.svg
  icons-dark/actions/22/smiley.svg
  icons/actions/22/animal.svg
  icons/actions/22/food.svg
  icons/actions/22/smiley.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27913: Icons for emoji categories

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I think I'll want to update some of these icons in the future, particularly 
the animal icon since that's using another project's mascot. Still, I don't 
think it'll be a problem since the TeX lion doesn't seem to have an official 
icon logo.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze, ndavis
Cc: ndavis, apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27913: Icons for emoji categories

[Aleix Pol Gonzalez]

apol added a comment.


  In D27913#624990 , @guoyunhe wrote:
  
  > D27915  is for the change. The ibus 
dict comes with untranslated categories name. The category names may change. 
But it seems the dict hasn't been updated that often.
  
  
  Ah, you are right. Well then +1 from my end overall.
  
  I'd say it brings control over the UX so it makes sense.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27913: Icons for emoji categories

[Yunhe Guo]

guoyunhe added a comment.


  D27915  is for the change. The ibus dict 
comes with untranslated categories name. The category names may change. But it 
seems the dict hasn't been updated that often.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27913: Icons for emoji categories

[Aleix Pol Gonzalez]

apol added a comment.


  In D27913#624850 , @ngraham wrote:
  
  > It seems like there are two goals here:
  >
  > - Use monochrome icons
  > - Be able to choose which icon is shown in the sidebar.
  >
  >   I don't have strong opinions about #1, but I agree that #2 is useful. 
However do we have to use breeze icons for this? Couldn't we adjust the code to 
choose a specific emoji rather than always using the first one in the grid view?
  
  
  I don't have strong opinions about #1. regarding #2 I'd say that if we want 
to decide what to show there, we can just as well show icons from the icon 
theme.
  
  Also I wonder if it will be any easy to implement since categories are coming 
from ibus and the category name comes translated.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27913: Icons for emoji categories

[Nathaniel Graham]

ngraham added a comment.


  It seems like there are two goals here:
  
  - Use monochrome icons
  - Be able to choose which icon is shown in the sidebar.
  
  I don't have strong opinions about #1, but I agree that #2 is useful. However 
do we have to use breeze icons for this? Couldn't we adjust the code to choose 
a specific emoji rather than always using the first one in the grid view?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27913: Icons for emoji categories

[Yunhe Guo]

guoyunhe added a comment.


  In D27913#624159 , @ngraham wrote:
  
  > If we do this, then won't the category icons look different from the actual 
emoji icons when using a font where the emojis look different?
  
  
  Hi @ngraham , the main idea is to make the left panel use only Breeze icons.
  
  Reference design in Telegram Desktop:
  
  F8145244: image.png 
  
  In WhatsApp:
  
  F8145247: image.png 
  
  In this way we can choose what the icon look like.
  
  Current implementation renders the first emoji in the category. You can see 
the "Objects" category is a "Muted" emoji. And the "Symbols" icon is an "ATM" 
emoji. They don't fit the category very well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27913: Icons for emoji categories

[Nathaniel Graham]

ngraham added a comment.


  If we do this, then won't the category icons look different from the actual 
emoji icons when using a font where the emojis look different?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27913: Icons for emoji categories

[Yunhe Guo]

guoyunhe added a dependent revision: D27915: Use breeze icons for categories.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

[Yunhe Guo]

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27913

AFFECTED FILES
  icons-dark/actions/22/animal.svg
  icons-dark/actions/22/food.svg
  icons-dark/actions/22/smiley.svg
  icons/actions/22/animal.svg
  icons/actions/22/food.svg
  icons/actions/22/smiley.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns