D28834: Add metadata properties to calendar

2020-11-18 Thread Nicolas Fella 
nicolasfella abandoned this revision.
nicolasfella added a comment.


  moving to invent: 
https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/19

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dvasin, rodsevich, cgiboudeaux, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Volker Krause 
vkrause added a comment.


  In D28834#648405 , @winterz wrote:
  
  > I don't know how things are done in frameworks but it seems to me that the 
KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now
  
  
  This is handled automatically, no need to change this.

INLINE COMMENTS

> calendar.h:101
> +*/
> +enum CalendarType
> +{

As already noted in the previous review, "type" isn't the best naming for 
something that is about access control/permission IMHO.

A possible alternative name could be something like "AccessMode", or maybe even 
just bool isReadOnly.

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter 
winterz added a comment.


  I don't know how things are done in frameworks but it seems to me that the 
KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter 
winterz accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella 
nicolasfella marked an inline comment as done.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 80150.
nicolasfella added a comment.


  - default to ReadWrite
  - rename icon to iconname to reflect that it's just the name

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28834?vs=80140=80150

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

AFFECTED FILES
  src/calendar.cpp
  src/calendar.h
  src/calendar_p.h

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter 
winterz added a comment.


  looks good.
  nice touch using Q_EMIT.

INLINE COMMENTS

> calendar_p.h:81
> +QString mIcon;
> +CalendarType mType;
>  };

CalendarType mType = ReadWrite ?

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella 
nicolasfella added a dependent revision: D24443: Add a plugin system.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella 
nicolasfella added reviewers: Frameworks, KDE PIM, vkrause.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil