D29198: filenamesearch:/ define a title for the query

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:e076d8668f67: filenamesearch:/ define a title for the 
query (authored by meven).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29198?vs=81330=81788

REVISION DETAIL
  https://phabricator.kde.org/D29198

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Ismael Asensio]

iasensio accepted this revision.
iasensio added a comment.


  Sorry I missed the ping.
  Along with D29197 , it looks nice to me.

INLINE COMMENTS

> dolphinsearchbox.cpp:479
> +return i18nc("@title UDS_DISPLAY_NAME for a KIO directory listing. %1 is 
> the query the user entered.",
> + "Query Results from '%1'", text);
> +}

Please, align the two strings

> elvisangelaccio wrote in dolphinsearchbox.h:164
> Please drop the `get` prefix.

I'd move this line up to separate private methods from private member variables

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29198_1

REVISION DETAIL
  https://phabricator.kde.org/D29198

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven added a comment.


  @iasensio Does this look good to you.
  
  Btw @elvisangelaccio I am editing the filenamesearch:/ ioslave in D29197 
 so I know this can't create an issue.
  The title in the baloo case also ends up in the ioslave query url's argument 
title.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29198_1

REVISION DETAIL
  https://phabricator.kde.org/D29198

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven updated this revision to Diff 81330.
meven marked an inline comment as done.
meven added a comment.


  Rename DolphinSearchBox::getQueryTitle to DolphinSearchBox::queryTitle

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29198?vs=81246=81330

BRANCH
  arcpatch-D29198_1

REVISION DETAIL
  https://phabricator.kde.org/D29198

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a subscriber: iasensio.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  LGTM but I'd like input from @iasensio too.

INLINE COMMENTS

> dolphinsearchbox.h:164
>  private:
> +QString getQueryTitle(const QString& text) const;
> +

Please drop the `get` prefix.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29198

REVISION DETAIL
  https://phabricator.kde.org/D29198

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven updated this revision to Diff 81246.
meven added a comment.


  Cleanup after unwanted changes

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29198?vs=81244=81246

BRANCH
  arcpatch-D29198

REVISION DETAIL
  https://phabricator.kde.org/D29198

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven updated this revision to Diff 81244.
meven added a comment.


  Information Panel: show early icons for folders

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29198?vs=81234=81244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29198

AFFECTED FILES
  src/panels/information/informationpanelcontent.cpp
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, elvisangelaccio, Dolphin, Frameworks.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 420354

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29198

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29198: filenamesearch:/ define a title for the query

[Méven Car]

meven added a comment.


  Relates (but does not depend) with D29197 

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29198

To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, 
firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov