D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma, ahiemstra
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Arjen Hiemstra]

ahiemstra accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma, ahiemstra
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham added a comment.


  @ahiemstra #frameworks  #plasma 
 ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham updated this revision to Diff 82786.
ngraham marked an inline comment as done.
ngraham added a comment.


  Address review comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82311=82786

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SpinBox.qml:54
> +// Because we're stomping the Text Input's own mouse handling
> +textField.forceActiveFocus()
> +}

You can do `mouse.accepted = false` instead of forceActiveFocus to allow the 
mouse press to go to items below it. However, you might instead want to use 
DragHandler's onActiveChanged for this, as that signals when the actual drag is 
active.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Andres Betts]

abetts added a comment.


  +1 from me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham added a comment.


  In D29534#666554 , @ndavis wrote:
  
  > I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the panel height up and down.
  
  
  That would be a comment for D29535 , but 
I will repeat my argument here: I think that drag is the least important 
interaction method for panel thickness adjustment since you typically want to 
make fine adjustments or arrive at a specific value, both of which are unsuited 
for drag-based interactions. Nevertheless, I have implemented drag-adjustment 
in the spinbox control here to not lose it, which also yields the advantage 
that other potential Plasma components that use a spinbox will benefit from it.
  
  We can improve the look of this control in another patch. To my knowledge it 
hasn't been used at all so it wouldn't surprise me if it's a bit unpolished.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Noah Davis]

ndavis added a comment.


  I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the height up and down.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Nathaniel Graham]

ngraham retitled this revision from "Implement wheel/touchpad scrolling for 
SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox 
control".
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns