D4972: Start drag with press and hold on touch events
This revision was automatically updated to reflect the committed changes. Closed by commit R296:86bbebdee213: Start drag with press and hold on touch events (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4972?vs=12273=15978 REVISION DETAIL https://phabricator.kde.org/D4972 AFFECTED FILES src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp src/qmlcontrols/draganddrop/DeclarativeDragArea.h To: davidedmundson, #plasma, mart Cc: mart, hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D4972: Start drag with press and hold on touch events
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. good idea! REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma, mart Cc: mart, hein, broulik, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D4972: Start drag with press and hold on touch events
mart added a comment. the discussion seems to me a bit unrelated with the review in itself. for me the patch is ok, +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: mart, hein, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4972: Start drag with press and hold on touch events
broulik added a comment. Even Qt's own `Drag` attached property crashes when the item it's attached to is deleted as I had to experience, cf https://phabricator.kde.org/D4976 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: hein, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4972: Start drag with press and hold on touch events
hein added a comment. So do Task Manager and Folder View. Because DragArea is kind of broken and will crash Plasma if it's deleted during the drag (which happens quite often when you remove something by DND). REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: hein, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4972: Start drag with press and hold on touch events
davidedmundson added a comment. Kicker uses a normal mouse area for drag starting, then a different plasmoid specific C++ helper for mimedata REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4972: Start drag with press and hold on touch events
broulik added a comment. Kickoff also uses DragArea iirc, I tend to use Qt's own Drag thing, though, but if we have better/proper touchscreen support in there then, might be worth re-considering. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4972: Start drag with press and hold on touch events
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch consists of two changes: - starting drags on press and hold - not starting drags when the event is from a touch event This means a user can scroll on a widget explorer with a touch screen correctly without it immediately starting a drag, but can still drag an item using a press and hold pattern. BUG: 368698 TEST PLAN Scrolled in Widget Explorer Added widget with press and hold Surprisingly that's the only Plasma usage of DragArea. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4972 AFFECTED FILES src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp src/qmlcontrols/draganddrop/DeclarativeDragArea.h To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
