D8923: Offer QWindow API for KJobWidgets:: decorators
This revision was automatically updated to reflect the committed changes. Closed by commit R288:02053c0ff28f: Offer QWindow API for KJobWidgets:: decorators (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8923?vs=22686&id=23820#toc REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22686&id=23820 REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks, dfaure Cc: dfaure, kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kjobwidgets.h:76 > + * This is required on Wayland to properly position the menu. > + * @since 5.41 > + */ Unlikely at this point (tagging today). REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 To: apol, #frameworks, dfaure Cc: dfaure, kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
kfunk added inline comments. INLINE COMMENTS > apol wrote in kjobwidgets.cpp:67 > Note I didn't change any code, I just moved it around. > > Removing the cast still seems to work, so I'll do that. > Note I didn't change any code, I just moved it around. Whoops, sorry. Didn't notice. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D8923 To: apol, #frameworks Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > kfunk wrote in kjobwidgets.cpp:67 > `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef > QT_PREPEND_NAMESPACE(quintptr) WId;` > > Besides: `QVariant::fromValue(window->winId())` should work just fine, or? Note I didn't change any code, I just moved it around. Removing the cast still seems to work, so I'll do that. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D8923 To: apol, #frameworks Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
apol updated this revision to Diff 22686. apol marked an inline comment as done. apol added a comment. Remove cast REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22685&id=22686 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
kfunk added inline comments.
INLINE COMMENTS
> kjobwidgets.cpp:67
> +if (window) {
> +job->setProperty("window-id",
> QVariant::fromValue(qptrdiff(window->winId(;
> +}
`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef
QT_PREPEND_NAMESPACE(quintptr) WId;`
Besides: `QVariant::fromValue(window->winId())` should work just fine, or?
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D8923
To: apol, #frameworks
Cc: kfunk
D8923: Offer QWindow API for KJobWidgets:: decorators
apol updated this revision to Diff 22685. apol added a comment. Better API REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22684&id=22685 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks
D8923: Offer QWindow API for KJobWidgets:: decorators
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY This way we can do the same with non-widget windows REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks
