Re: Minimum required cmake version

[Sven Brauch]

Hey,

thanks for the discussion. I've changed the required cmake version to
3.0 for all frameworks, hope I didn't miss any.

Best regards,
Sven

On 27/12/16 17:48, Sven Brauch wrote:
> Hi,
> 
> building on CentOS 6.8, I noticed some frameworks (namely KAuth,
> KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
> be related with moc'ing the Q_GADGET macro. Still, they specify cmake
> 2.8 as the minimum required cmake version.
> 
> Do we
>  - attempt to fix this with cmake 2.8
>  - bump the required cmake version to 3.0 for these frameworks
>  - bump the required cmake version to 3.0 for all frameworks?
> 
> Greetings,
> Sven
> 




signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[Sven Brauch]

On 03/01/17 14:13, David Faure wrote:
>> No objection.
> 
> I do, however, have an objection to untested commits.
> 
> Sven, your commits broke knewstuff and some other modules.
> 
> CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/
> ECMGeneratePriFile.cmake:137 (message):
>   Required variable PROJECT_VERSION_STRING not set before
>   ECM_GENERATE_PRI_FILE() call.  Did you call ecm_setup_version?
> Call Stack (most recent call first):
>   src/core/CMakeLists.txt:94 (ecm_generate_pri_file)
> 
> Changing the min required cmake version also changes the default values for a 
> number of cmake policies, so you need to adjust the cmakelists.txt 
> accordingly.

I'm sorry. I completely forgot changing the minimum cmake version
changes these defaults (and thus actually affects behaviour). I'll look
into it right now.





signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[Sven Brauch]

Hey,

On 03/01/17 14:13, David Faure wrote:
> Sven, your commits broke knewstuff and some other modules.
> 
> CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/
> ECMGeneratePriFile.cmake:137 (message):
>   Required variable PROJECT_VERSION_STRING not set before
>   ECM_GENERATE_PRI_FILE() call.  Did you call ecm_setup_version?
> Call Stack (most recent call first):
>   src/core/CMakeLists.txt:94 (ecm_generate_pri_file)
> 
> Changing the min required cmake version also changes the default values for a 
> number of cmake policies, so you need to adjust the cmakelists.txt 
> accordingly.
I ported everything to the new default policy settings and also fixed
several cmake warnings the switch to 3.0 introduced. The only thing I
don't know how to port is one place in sonnet, there I just set the old
policy for now.

Apologies once more for the noise and breakage!

Best,
Sven




signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[David Faure]

On lundi 2 janvier 2017 10:43:37 CET David Faure wrote:
> On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote:
> > On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne  wrote:
> > > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
> > >> Hey,
> > >> 
> > >> On 27/12/16 19:30, Aleix Pol wrote:
> > >> > +1 on changing to 3.0.
> > >> 
> > >> Thanks for your opinion on the matter. I also think we should just bump
> > >> it, 3.0 is old enough -- as said it's even easily available on CentOS
> > >> 6.
> > >> 
> > >> Question is, should I change it on _all_ frameworks or just those using
> > >> Q_GADGET (i.e. those which actually need cmake 3)?
> > > 
> > > If we change the CMake requirement for one framework it should be
> > > changed for them all.  They are tested, released, and supported as a
> > > unit even though they have separate tiers and could theoretically be put
> > > together in a piecemeal fashion.
> > > 
> > > There might also be an easy way to change it in extra-cmake-modules but
> > > I think some of the buildsystem devs would know more about that.
> > > 
> > > Regards,
> > > 
> > >  - Michael Pyne
> > 
> > +1
> 
> No objection.

I do, however, have an objection to untested commits.

Sven, your commits broke knewstuff and some other modules.

CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/
ECMGeneratePriFile.cmake:137 (message):
  Required variable PROJECT_VERSION_STRING not set before
  ECM_GENERATE_PRI_FILE() call.  Did you call ecm_setup_version?
Call Stack (most recent call first):
  src/core/CMakeLists.txt:94 (ecm_generate_pri_file)

Changing the min required cmake version also changes the default values for a 
number of cmake policies, so you need to adjust the cmakelists.txt 
accordingly.

(Do not just set the policies to OLD, that's the wrong way to go)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Minimum required cmake version

[David Faure]

On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote:
> On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne  wrote:
> > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
> >> Hey,
> >> 
> >> On 27/12/16 19:30, Aleix Pol wrote:
> >> > +1 on changing to 3.0.
> >> 
> >> Thanks for your opinion on the matter. I also think we should just bump
> >> it, 3.0 is old enough -- as said it's even easily available on CentOS 6.
> >> 
> >> Question is, should I change it on _all_ frameworks or just those using
> >> Q_GADGET (i.e. those which actually need cmake 3)?
> > 
> > If we change the CMake requirement for one framework it should be
> > changed for them all.  They are tested, released, and supported as a
> > unit even though they have separate tiers and could theoretically be put
> > together in a piecemeal fashion.
> > 
> > There might also be an easy way to change it in extra-cmake-modules but
> > I think some of the buildsystem devs would know more about that.
> > 
> > Regards,
> > 
> >  - Michael Pyne
> 
> +1

No objection.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Minimum required cmake version

[Aleix Pol]

On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne  wrote:
> On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
>> Hey,
>>
>> On 27/12/16 19:30, Aleix Pol wrote:
>> > +1 on changing to 3.0.
>> Thanks for your opinion on the matter. I also think we should just bump
>> it, 3.0 is old enough -- as said it's even easily available on CentOS 6.
>>
>> Question is, should I change it on _all_ frameworks or just those using
>> Q_GADGET (i.e. those which actually need cmake 3)?
>
> If we change the CMake requirement for one framework it should be
> changed for them all.  They are tested, released, and supported as a
> unit even though they have separate tiers and could theoretically be put
> together in a piecemeal fashion.
>
> There might also be an easy way to change it in extra-cmake-modules but
> I think some of the buildsystem devs would know more about that.
>
> Regards,
>  - Michael Pyne

+1
Aleix

Re: Minimum required cmake version

[Michael Pyne]

On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
> Hey,
> 
> On 27/12/16 19:30, Aleix Pol wrote:
> > +1 on changing to 3.0.
> Thanks for your opinion on the matter. I also think we should just bump
> it, 3.0 is old enough -- as said it's even easily available on CentOS 6.
> 
> Question is, should I change it on _all_ frameworks or just those using
> Q_GADGET (i.e. those which actually need cmake 3)?

If we change the CMake requirement for one framework it should be
changed for them all.  They are tested, released, and supported as a
unit even though they have separate tiers and could theoretically be put
together in a piecemeal fashion.

There might also be an easy way to change it in extra-cmake-modules but
I think some of the buildsystem devs would know more about that.

Regards,
 - Michael Pyne

Re: Minimum required cmake version

[Sven Brauch]

Hey,

On 27/12/16 19:30, Aleix Pol wrote:
> +1 on changing to 3.0.
Thanks for your opinion on the matter. I also think we should just bump
it, 3.0 is old enough -- as said it's even easily available on CentOS 6.

Question is, should I change it on _all_ frameworks or just those using
Q_GADGET (i.e. those which actually need cmake 3)?

Best,
Sven



signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[Sune Vuorela]

On 2016-12-27, Aleix Pol  wrote:
> Now everything makes sense, thanks!
>
> I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't
> in 2.8.11.
> +1 on changing to 3.0.

As a datapoint, Debian stable has cmake 3.0

/Sune

Re: Minimum required cmake version

[Aleix Pol]

On Tue, Dec 27, 2016 at 7:25 PM, Sven Brauch  wrote:
> On 27/12/16 19:23, Aleix Pol wrote:
>> Makes sense, although you still won't be able to compile these
>> frameworks on CentOS 6.8 even if we fix that, right?
> I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of
> "cmake". That's why I was running cmake 2.8 so far, and noticed this issue.
>
> It doesn't prevent me from compiling, it just doesn't make sense to
> specify 2.8 as the minimum if it doesn't actually work (and was
> confusing to find out).
>
> Sven
>

Now everything makes sense, thanks!

I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't
in 2.8.11.
+1 on changing to 3.0.

Aleix

Re: Minimum required cmake version

[Sven Brauch]

On 27/12/16 19:23, Aleix Pol wrote:
> Makes sense, although you still won't be able to compile these
> frameworks on CentOS 6.8 even if we fix that, right?
I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of
"cmake". That's why I was running cmake 2.8 so far, and noticed this issue.

It doesn't prevent me from compiling, it just doesn't make sense to
specify 2.8 as the minimum if it doesn't actually work (and was
confusing to find out).

Sven



signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[Aleix Pol]

On Tue, Dec 27, 2016 at 7:20 PM, Sven Brauch  wrote:
> Hi,
>
> On 27/12/16 19:18, Aleix Pol wrote:
>> Have you checked that changing to cmake 3.0 actually solves this
>> problem?
> I have 3.6 on the same system and with that it works. I don't have 3.0. :/
>
> However, 3.0 docs explicitly mentions Q_GADGET.

Makes sense, although you still won't be able to compile these
frameworks on CentOS 6.8 even if we fix that, right?

Aleix

Re: Minimum required cmake version

[Sven Brauch]

Hi,

On 27/12/16 19:18, Aleix Pol wrote:
> Have you checked that changing to cmake 3.0 actually solves this
> problem?
I have 3.6 on the same system and with that it works. I don't have 3.0. :/

However, 3.0 docs explicitly mentions Q_GADGET.

Greetings,
Sven



signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

[Aleix Pol]

On Tue, Dec 27, 2016 at 5:48 PM, Sven Brauch <m...@svenbrauch.de> wrote:
> Hi,
>
> building on CentOS 6.8, I noticed some frameworks (namely KAuth,
> KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
> be related with moc'ing the Q_GADGET macro. Still, they specify cmake
> 2.8 as the minimum required cmake version.
>
> Do we
>  - attempt to fix this with cmake 2.8
>  - bump the required cmake version to 3.0 for these frameworks
>  - bump the required cmake version to 3.0 for all frameworks?
>
> Greetings,
> Sven

Hi Sven,
Have you checked that changing to cmake 3.0 actually solves this
problem? If so, I'd say 3.0 (June 2014) is an acceptable minimum cmake
version.

Aleix

Minimum required cmake version

[Sven Brauch]

Hi,

building on CentOS 6.8, I noticed some frameworks (namely KAuth,
KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
be related with moc'ing the Q_GADGET macro. Still, they specify cmake
2.8 as the minimum required cmake version.

Do we
 - attempt to fix this with cmake 2.8
 - bump the required cmake version to 3.0 for these frameworks
 - bump the required cmake version to 3.0 for all frameworks?

Greetings,
Sven




signature.asc
Description: OpenPGP digital signature