Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 16, 2013, 11:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39719 --- Ship it! Looks good to me. Thanks for taking care of adding the doc I did not write. - Aurélien Gâteau On Sept. 8, 2013, 10:54 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 8, 2013, 10:54 a.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 8, 2013, 8:54 a.m.) Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Looks good to me. Aurélien? Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
On Sept. 1, 2013, 8:31 a.m., David Faure wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42 Missing documentation (in particular about the ownership being transferred to the decorator) hmm, do we really want that, btw? I thought the highlighter was also going to be used elsewhere? [I'm lacking context a little bit, for a full understanding] We want to avoid the code duplication in KTextEdit which has the same code for making a context menu as the SpellCheckDecorator installs. That has a setHighlighter() method so naturally in order to re-use the decorator I need to be able to set a highlighter here. Relevant other patch is here: https://git.reviewboard.kde.org/r/112283/ (not published because I need to get this in first.. and due to changes I now need to rewrite that other patch anyway). - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39051 --- On Aug. 27, 2013, 9:21 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 27, 2013, 9:21 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 6:42 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs (updated) - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 5:53 p.m.) Review request for KDE Frameworks. Changes --- Add documentation to all parts of SpellCheckDecorator Change setHighlighter to not take ownership (Highlighter will only have the lifespan of the QTextEdit anyway) Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs (updated) - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
On Sept. 1, 2013, 8:31 a.m., David Faure wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42 Missing documentation (in particular about the ownership being transferred to the decorator) hmm, do we really want that, btw? I thought the highlighter was also going to be used elsewhere? [I'm lacking context a little bit, for a full understanding] David Edmundson wrote: We want to avoid the code duplication in KTextEdit which has the same code for making a context menu as the SpellCheckDecorator installs. That has a setHighlighter() method so naturally in order to re-use the decorator I need to be able to set a highlighter here. Relevant other patch is here: https://git.reviewboard.kde.org/r/112283/ (not published because I need to get this in first.. and due to changes I now need to rewrite that other patch anyway). I understand the need for a setter. My question is about ownership: should the decorator really own (and therefore delete) that highlighter? Won't that lead to double deletions if the textedit also owns it? - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39051 --- On Sept. 6, 2013, 5:53 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 5:53 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39491 --- Looks ok to me, apart from the formatting of the documentation blocks. (the /** should be alone on its line, everywhere) Maybe Aurélien should review this though. tier1/sonnet/src/ui/spellcheckdecorator.h http://git.reviewboard.kde.org/r/112281/#comment29095 Last I checked (ok, 8 years ago), doxygen requires this to be on three different lines. (the short form is /// docu, but we usually rather use the full form instead) - David Faure On Sept. 6, 2013, 5:53 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 5:53 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
On Aug. 26, 2013, 7:08 a.m., Kevin Ottens wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 40 http://git.reviewboard.kde.org/r/112281/diff/1/?file=184608#file184608line40 I would rather have a setter than an extra ctor parameter if possible. Since we already have a getter... David Edmundson wrote: The rationale behind it was that I don't want to create a default Highlighter only to delete it. The Highlighter constructor is somewhat expensive as it loads the dictionary. If we really want a set/get approach, I could do something like KTextEdit currently does where it only creates a default highlighter on demand (i.e in the highlighter() and onContextMenuEvent() methods if one has not currently been set. OK, please have the default created on demand then. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review38580 --- On Aug. 25, 2013, 11:40 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 25, 2013, 11:40 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d87040d922885e05459e5d33baa5d1a874 tier1/sonnet/src/ui/spellcheckdecorator.cpp 72999662c6478481087e1c2c9b0bac5baeabd8f4 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 27, 2013, 9:21 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs (updated) - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator
On Aug. 26, 2013, 7:08 a.m., Kevin Ottens wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 40 http://git.reviewboard.kde.org/r/112281/diff/1/?file=184608#file184608line40 I would rather have a setter than an extra ctor parameter if possible. Since we already have a getter... The rationale behind it was that I don't want to create a default Highlighter only to delete it. The Highlighter constructor is somewhat expensive as it loads the dictionary. If we really want a set/get approach, I could do something like KTextEdit currently does where it only creates a default highlighter on demand (i.e in the highlighter() and onContextMenuEvent() methods if one has not currently been set. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review38580 --- On Aug. 25, 2013, 11:40 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 25, 2013, 11:40 p.m.) Review request for KDE Frameworks. Description --- Allow setting a custom highlighter on the spell check decorator -- This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit. Diffs - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d87040d922885e05459e5d33baa5d1a874 tier1/sonnet/src/ui/spellcheckdecorator.cpp 72999662c6478481087e1c2c9b0bac5baeabd8f4 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
