Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Feb. 20, 2014, 12:09 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: khtml Description --- khtml and other components from frameworks should use kde5_install , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs
On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote: Does kde5_install_icons even exist? I can't find its definition in extra-cmake-modules. You say you've done no testing; surely you should at least have tried a fresh configure, compile and install of khtml? Alex Merry wrote: Also, I would ignore khtml for now. It needs a substantial porting effort to remove its dependency on kde4support, and I don't think that's a priority for us right now. Ah, that CMakeLists.txt file should just be removed. It is never used, and the images are just for testing and should definitely not be installed. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/#review47308 --- On Jan. 12, 2014, 8:01 p.m., Siddharth Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Jan. 12, 2014, 8:01 p.m.) Review request for KDE Frameworks. Repository: khtml Description --- khtml and other components from frameworks should use kde5_install , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/#review47308 --- Does kde5_install_icons even exist? I can't find its definition in extra-cmake-modules. You say you've done no testing; surely you should at least have tried a fresh configure, compile and install of khtml? - Alex Merry On Jan. 12, 2014, 8:01 p.m., Siddharth Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Jan. 12, 2014, 8:01 p.m.) Review request for KDE Frameworks. Repository: khtml Description --- khtml and other components from frameworks should use kde5_install , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs
On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote: Does kde5_install_icons even exist? I can't find its definition in extra-cmake-modules. You say you've done no testing; surely you should at least have tried a fresh configure, compile and install of khtml? Also, I would ignore khtml for now. It needs a substantial porting effort to remove its dependency on kde4support, and I don't think that's a priority for us right now. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/#review47308 --- On Jan. 12, 2014, 8:01 p.m., Siddharth Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Jan. 12, 2014, 8:01 p.m.) Review request for KDE Frameworks. Repository: khtml Description --- khtml and other components from frameworks should use kde5_install , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114987/ --- (Updated Jan. 12, 2014, 8:01 p.m.) Review request for KDE Frameworks. Changes --- kde5_install Summary (updated) - khtml and other components from frameworks should use kde5_install , remove kde4 refs Repository: khtml Description (updated) --- khtml and other components from frameworks should use kde5_install , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
