Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated Juli 3, 2015, 9:16 nachm.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h 83572a0 src/kicondialog.cpp 75f9f01 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
On März 13, 2015, 10:25 vorm., Christoph Feck wrote: Hopefully I did not miss anything this time :) Done - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77409 --- On März 13, 2015, 6:36 vorm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 13, 2015, 6:36 vorm.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h 83572a0 src/kicondialog.cpp 75f9f01 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 13, 2015, 6:36 vorm.) Review request for KDE Frameworks. Changes --- Use separate class for the event filter Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs (updated) - src/kicondialog.h 83572a0 src/kicondialog.cpp 75f9f01 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77409 --- Ship it! Hopefully I did not miss anything this time :) - Christoph Feck On March 13, 2015, 6:36 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 13, 2015, 6:36 a.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h 83572a0 src/kicondialog.cpp 75f9f01 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1e9af6c54470e890597739f8f2189b0743a00b6f by Kai Uwe Broulik to branch master. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 12, 2015, 7:10 nachm.) Review request for KDE Frameworks. Changes --- Remove spontaneous check. I think I misunderstood what it was all about. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs (updated) - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- Ship it! Ship It! - Christoph Feck On March 12, 2015, 7:10 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:10 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
On March 12, 2015, 7:15 p.m., Christoph Feck wrote: Ship It! Thinking again, the way you use the eventFilter (for the KIconDialog object), it still will not work with derived classes not recompiled. You need to create a separate (child) object which has the eventFilter method, and watch the KIconDialog events this way. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77394 --- On March 12, 2015, 7:57 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 12, 2015, 7:57 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 11, 2015, 10:56 nachm.) Review request for KDE Frameworks. Changes --- Use eventFilter Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs (updated) - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77320 --- src/kicondialog.cpp https://git.reviewboard.kde.org/r/122893/#comment53104 I do not understand the check for spontaneous. Is there a case where showIcons does not need to be called when receiving a showEvent? If this is to avoid stealing the focus, it probably needs to be moved down to the setFocus call. - Christoph Feck On March 11, 2015, 10:56 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 11, 2015, 10:56 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77276 --- I don't know whether this is binary compatible. It is not. A class compiled against the old KIconDialog sees no reimplementation for the showEvent method, and thus calls the parent's showEvent. Please try an event filter if this needs to be fixed. - Christoph Feck On March 10, 2015, 7:32 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 10, 2015, 7:32 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
