Re: Review Request 123551: Introduce the deprecated plugin system for now
On May 3, 2015, 10:21 p.m., David Faure wrote: This sounds like something that should go into KF 5.10. If this is temporary code then doing it only if new-style plugins haven't been found doesn't really matter much IMHO. Yes, that's the idea. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79808 --- On April 29, 2015, 1:16 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated April 29, 2015, 1:16 a.m.) Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Repository: kpeople Description --- Also support the old backend plugin system in KPeople until dependencies can adopt the new format. Diffs - CMakeLists.txt 6452c2d metainfo.yaml 7259adb src/CMakeLists.txt eba092c src/personpluginmanager.cpp 365280e src/widgets/CMakeLists.txt bfe1188 src/widgets/actions.cpp 2f1d60d src/widgets/persondetailsview.cpp 7c18c74 Diff: https://git.reviewboard.kde.org/r/123551/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123551: Introduce the deprecated plugin system for now
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79808 --- Ship it! This sounds like something that should go into KF 5.10. If this is temporary code then doing it only if new-style plugins haven't been found doesn't really matter much IMHO. - David Faure On April 28, 2015, 11:16 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated April 28, 2015, 11:16 p.m.) Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Repository: kpeople Description --- Also support the old backend plugin system in KPeople until dependencies can adopt the new format. Diffs - CMakeLists.txt 6452c2d metainfo.yaml 7259adb src/CMakeLists.txt eba092c src/personpluginmanager.cpp 365280e src/widgets/CMakeLists.txt bfe1188 src/widgets/actions.cpp 2f1d60d src/widgets/persondetailsview.cpp 7c18c74 Diff: https://git.reviewboard.kde.org/r/123551/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123551: Introduce the deprecated plugin system for now
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated May 3, 2015, 10:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Changes --- Submitted with commit e8caa0ad969a6675de59949e175b0b898a20a4f0 by Aleix Pol to branch master. Repository: kpeople Description --- Also support the old backend plugin system in KPeople until dependencies can adopt the new format. Diffs - CMakeLists.txt 6452c2d metainfo.yaml 7259adb src/CMakeLists.txt eba092c src/personpluginmanager.cpp 365280e src/widgets/CMakeLists.txt bfe1188 src/widgets/actions.cpp 2f1d60d src/widgets/persondetailsview.cpp 7c18c74 Diff: https://git.reviewboard.kde.org/r/123551/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123551: Introduce the deprecated plugin system for now
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79650 --- Maybe you want to query kservice only in case plugins haven't been found via KPluginLoader? - Hrvoje Senjan On April 29, 2015, 1:16 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated April 29, 2015, 1:16 a.m.) Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Repository: kpeople Description --- Also support the old backend plugin system in KPeople until dependencies can adopt the new format. Diffs - CMakeLists.txt 6452c2d metainfo.yaml 7259adb src/CMakeLists.txt eba092c src/personpluginmanager.cpp 365280e src/widgets/CMakeLists.txt bfe1188 src/widgets/actions.cpp 2f1d60d src/widgets/persondetailsview.cpp 7c18c74 Diff: https://git.reviewboard.kde.org/r/123551/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
