Re: Review Request 113657: Fix Standalone Configuration of DNSSD
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43351 --- Ship it! I think that's fine to keep the modules private, they're not used anywhere else AFAIK. We use kdnssd instead of avahi or such directly. If we find more users later on then we can put the effort to have them in ECM of course. - Kevin Ottens On Nov. 7, 2013, 1:30 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 7, 2013, 1:30 p.m.) Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:21 a.m.) Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Changes --- Fixing the issue raised about KF5_VERSION Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs (updated) - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43396 --- This review has been submitted with commit 39e87ae731a0972f3dbc532f1832527582551a00 by David E. Narvaez to branch frameworks. - Commit Hook On Nov. 11, 2013, 12:21 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:21 a.m.) Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:25 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113657/#review43202
---
It's going in the right direction, but I am wondering whether the Find*.cmake
files should go to extra-cmake-modules instead of being part of the framework.
You should add Steve (skelly) to the review to get his opinion.
tier2/dnssd/CMakeLists.txt
http://git.reviewboard.kde.org/r/113657/#comment31147
Missing ${KF5_VERSION}
- Aurélien Gâteau
On Nov. 6, 2013, 1:36 a.m., David Narváez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113657/
---
(Updated Nov. 6, 2013, 1:36 a.m.)
Review request for KDE Frameworks and Aurélien Gâteau.
Repository: kdelibs
Description
---
Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when
building with DNSSD and factored out the Frameworks version.
Diffs
-
cmake/modules/CMakeLists.txt 7910270
cmake/modules/FindAvahi.cmake
cmake/modules/FindDNSSD.cmake 8604bd5
tier2/dnssd/CMakeLists.txt 2cfcc40
Diff: http://git.reviewboard.kde.org/r/113657/diff/
Testing
---
1. Configure with cmake
2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1
Configures OK in both cases. Builds OK in case 1, does not build yet in case
2.
Thanks,
David Narváez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: It's going in the right direction, but I am wondering whether the Find*.cmake files should go to extra-cmake-modules instead of being part of the framework. You should add Steve (skelly) to the review to get his opinion. Well, the idea was to have them all in extra-cmake-modules. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 --- On Nov. 6, 2013, 12:36 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 6, 2013, 12:36 a.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: It's going in the right direction, but I am wondering whether the Find*.cmake files should go to extra-cmake-modules instead of being part of the framework. You should add Steve (skelly) to the review to get his opinion. Aleix Pol Gonzalez wrote: Well, the idea was to have them all in extra-cmake-modules. I'm adding both ervin and skelly to the review because of this comment a couple of meetings ago: [Tuesday, October 29, 2013] [11:43:21 AM] ervin depends if that's the only framework using them and they are not interesting to the outside, keeping them in a cmake/ folder is ok, but they shouldn't be installed in that case - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 --- On Nov. 7, 2013, 1:30 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 7, 2013, 1:30 p.m.) Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 7, 2013, 1:30 p.m.) Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
