Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 26, 2014, 7:22 a.m., István Kapcsándi wrote:
src/CMakeLists.txt, line 17
https://git.reviewboard.kde.org/r/115078/diff/3/?file=234996#file234996line17
maybe I'm wrong but my logic says that this should be
install(FILES ${kglobalaccel_component_xml} DESTINATION
${DBUS_INTERFACES_INSTALL_DIR} RENAME
kf5_org.kde.KGlobalAccel.Component.xml)
Good spot, but it is already fixed in 1d861e0d0513b5e67bdf71e4879ce405fcdcf971.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review48281
---
On Jan. 21, 2014, 4:24 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/
---
(Updated Jan. 21, 2014, 4:24 p.m.)
Review request for KDE Frameworks and Martin Gräßlin.
Repository: kglobalaccel
Description
---
don't install dbus interface files in kglobalaccel, these overlap with the
equivalent files in kdelibs4 which causes problems for some distributions
Diffs
-
src/CMakeLists.txt d48e92e
Diff: https://git.reviewboard.kde.org/r/115078/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review48281
---
src/CMakeLists.txt
https://git.reviewboard.kde.org/r/115078/#comment34165
maybe I'm wrong but my logic says that this should be
install(FILES ${kglobalaccel_component_xml} DESTINATION
${DBUS_INTERFACES_INSTALL_DIR} RENAME kf5_org.kde.KGlobalAccel.Component.xml)
- István Kapcsándi
On Jan. 21, 2014, 4:24 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/
---
(Updated Jan. 21, 2014, 4:24 p.m.)
Review request for KDE Frameworks and Martin Gräßlin.
Repository: kglobalaccel
Description
---
don't install dbus interface files in kglobalaccel, these overlap with the
equivalent files in kdelibs4 which causes problems for some distributions
Diffs
-
src/CMakeLists.txt d48e92e
Diff: https://git.reviewboard.kde.org/r/115078/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 5:39 p.m., Thomas Lübking wrote: and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? KF/5 would be broken then, would it not? What about having a common data package downstream? No it wouldn't be broken, it would continue to compile using the .xml files it has locally. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47587 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 9:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 5:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 5:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ Martin Gräßlin wrote: How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? Martin Gräßlin wrote: Oh and I think review request https://git.reviewboard.kde.org/r/115079/ illustrates the problem. As the file doesn't get installed any more, we need to copy it everywhere where it's going to be used. This looks like a very sub-optimal solution. The xml file would be included in the kde-workspace source directly ( https://git.reviewboard.kde.org/r/115079/ ) - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Changes --- new tactic, rename the interface file (but keep the interface name the same) Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs (updated) - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ Martin Gräßlin wrote: How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? Martin Gräßlin wrote: Oh and I think review request https://git.reviewboard.kde.org/r/115079/ illustrates the problem. As the file doesn't get installed any more, we need to copy it everywhere where it's going to be used. This looks like a very sub-optimal solution. Jonathan Riddell wrote: The xml file would be included in the kde-workspace source directly ( https://git.reviewboard.kde.org/r/115079/ ) New patch follows Hrvoje Senjan's suggestion to rename the interface file but keep the interface name the same - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 21, 2014, 2:49 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47879 --- I like this approach better (though I don't know whether that's causing problems on the DBus side). Maybe we could keep the files as they are and just rename at install? - Martin Gräßlin On Jan. 21, 2014, 3:49 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 2:55 p.m., Martin Gräßlin wrote: I like this approach better (though I don't know whether that's causing problems on the DBus side). Maybe we could keep the files as they are and just rename at install? new patch attached - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47879 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- something went wrong with the latest patch. CMake looks fine but it includes the renamed files. - Martin Gräßlin On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Changes --- rename file only at install time Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs (updated) - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47887 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 4:16 p.m., Martin Gräßlin wrote: something went wrong with the latest patch. CMake looks fine but it includes the renamed files. Jonathan Riddell wrote: Maybe I'm going mad but I don't see any renamed files in it. Here's the same patch in a pastebin http://paste.ubuntu.com/6792111/ I blame review board. It showed me the new CMakeLists.txt but still the renamed files... Now it works. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 3:16 p.m., Martin Gräßlin wrote: something went wrong with the latest patch. CMake looks fine but it includes the renamed files. Maybe I'm going mad but I don't see any renamed files in it. Here's the same patch in a pastebin http://paste.ubuntu.com/6792111/ - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 3:23 p.m., Martin Gräßlin wrote: Ship It! Many thanks to Jonathan for working on this, and Martin for giving a green light! ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47887 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47894 --- This review has been submitted with commit fc7deb7e9d7a641495729380746821dae140fb6b by Jonathan Riddell to branch master. - Commit Hook On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) I think the idea is to move the xml file to kde-workspace somehow? - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47583 --- https://git.reviewboard.kde.org/r/115079/ is matching part in kde-workspace - Jonathan Riddell On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47587 --- and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? KF/5 would be broken then, would it not? What about having a common data package downstream? - Thomas Lübking On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. - Martin Gräßlin On Jan. 17, 2014, 5:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 5:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
