Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48374 --- Ship it! Just one more thing to check, then go ahead and commit it. src/kcompletion.h https://git.reviewboard.kde.org/r/115206/#comment34207 Does doxygen properly generate a link for this without the leading KCompletion::? - Alex Merry On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 27, 2014, 7:14 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48411 --- This review has been submitted with commit 5074495472c51c5139e91f1fe77b01ffcb49e725 by David Gil to branch master. - Commit Hook On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 27, 2014, 12:20 p.m., Alex Merry wrote: src/kcompletion.h, line 831 https://git.reviewboard.kde.org/r/115206/diff/2/?file=240658#file240658line831 Does doxygen properly generate a link for this without the leading KCompletion::? Yes, it does. I've checked in downloadmanager.h, in knewstuff, where there's a SortOrder enum and it's referenced as @see SortOrder. And in kxmlguiwindow.h there's a StandardWindowOptions enum referenced as @see StandardWindowOptions. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review48374 --- On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks. Changes --- Addressed all issues told by Alex, except the one in the signal matches(), which AFAICS is not necessary. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs (updated) - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 501 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line501 One sentence: This signal is emitted by makeCompletion() when a match is found. David Gil Oliva wrote: Since more methods emit this signal, I have rephrased it further. makeCompletion() doesn't emit empty strings, but previousMatch() and nextMatch() do emit empty strings when there is no match. In the next days I will update the patch. /** * This signal is emitted by makeCompletion() when a match is found. * @param item the match. In previousMatch() and nextMatch() it can * be a QString() if none is found. */ Alex Merry wrote: How about /** * This signal is emitted when a match is found. * * In particular, makeCompletion(), previousMatch() and nextMatch() all * emit this signal; makeCompletion() will only emit it when a match is * found, but the other methods will always emit it (and so may emit it * with an empty string). * * @param item the matching item, or QString() if there were no more * matching items. */ And a similar thing for matches(). I think matches() is ok, since it is only used by makeCompletion(). - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 26, 2014, 10:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 501 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line501 One sentence: This signal is emitted by makeCompletion() when a match is found. David Gil Oliva wrote: Since more methods emit this signal, I have rephrased it further. makeCompletion() doesn't emit empty strings, but previousMatch() and nextMatch() do emit empty strings when there is no match. In the next days I will update the patch. /** * This signal is emitted by makeCompletion() when a match is found. * @param item the match. In previousMatch() and nextMatch() it can * be a QString() if none is found. */ How about /** * This signal is emitted when a match is found. * * In particular, makeCompletion(), previousMatch() and nextMatch() all * emit this signal; makeCompletion() will only emit it when a match is * found, but the other methods will always emit it (and so may emit it * with an empty string). * * @param item the matching item, or QString() if there were no more * matching items. */ And a similar thing for matches(). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 21, 2014, 11:12 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 103 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line103 You remove the hyphen from auto-completion ealier, but not here. David Gil Oliva wrote: Yes, I drop the hyphen from auto-completion when it works as a noun. But here (and in many other places) is working as a compound adjective. Some sources about compound adjectives and hyphens: http://writersrelief.com/blog/2008/03/hyphen-rules-dont-let-misused-hyphens-muddle-your-adjectives-or-your-writing/ http://www.grammarbook.com/punctuation/hyphens.asp Nevertheless, I may be wrong. If so, please tell me. OK, fair enough. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 21, 2014, 11:12 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: Thanks for working on apidox! Sorry for the large number of comments... Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by one tomorrow (just wanted to comment about something I clearly don't agree). On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 103 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line103 You remove the hyphen from auto-completion ealier, but not here. Yes, I drop the hyphen from auto-completion when it works as a noun. But here (and in many other places) is working as a compound adjective. Some sources about compound adjectives and hyphens: http://writersrelief.com/blog/2008/03/hyphen-rules-dont-let-misused-hyphens-muddle-your-adjectives-or-your-writing/ http://www.grammarbook.com/punctuation/hyphens.asp Nevertheless, I may be wrong. If so, please tell me. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 21, 2014, 11:12 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
