T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Noah Davis]

ndavis added a comment.


  I could probably make the python script instead, but I'm in the same spot 
when it comes to writing CMake.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a comment.


  I haven't been working on it. There's an outstanding request to do this in a 
combination of CMake and Python, so it's cross-platform for Windows users of 
Breeze Icons too (see D27557#622879 
). Honestly I need to re-do the 
existing thing before that. But it's hard to gin up the motivation since I find 
working with CMake for anything more trivial than bumping a dependency version 
to be exceptionally unpleasant.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  @ngraham How’s your progress with the bash script? I’m currently trying to 
understand bash syntax. Maybe I can do it, if you don’t have done it already.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  Now we have less than 130 icons which are different in icons/ and 
icons-dark/, and less than 100 icons which we should keep as dark version. 
Maybe we can keep event less.
  
  I have sorted them into two files.
  
  F8221155: dark_icons_to_keep.txt 
  
  F8221154: dark_icons_to_remove.txt 

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Noah Davis]

ndavis added a comment.


  In T12855#224570 , @davidhurka 
wrote:
  
  > Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 
50% transparency, while rating has 100% opacity? That makes my compare script 
go wild, and I think it doesn’t look intended.
  
  
  Any inconsistencies in the `-symbolic` icons are probably unintentional

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 
50% transparency, while rating has 100% opacity? That makes my compare script 
go wild, and I think it doesn’t look intended.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a comment.


  Ah, that was an oversight on my behalf. I changed the rating icon to be black 
to fix a bug where it becomes invisible on a selected item. I probably forgot 
to change it to be white for the dark version. :/

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  By the way I looked through the 319 icons.
  
  - Some icons actually need fixing in icons/.
  - The emblem rating is blue in icons-dark/, because it links to another 
class. We can:
- Leave rating in icons-dark/
- Change the light version to be blue too
  - (Probably) All mimetype icons in size 32px and 64px look significantly 
different in light and dark

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  I have to take some short notes here.
  
  I have written a .sed script which we can use to convert icons/ files to 
icons-dark/ files. It does the same substitutions as my perl script above, but 
matches only in the stylesheet. That means, fixed colors will not be changed. 
That should fix things like this: F8199106: devices_64_network-rj45-female.png 

  
  The script must be called with the -E option, because it uses new POSIX 
regexes.
  
$ sed -E -f swap_colors.sed -i file/to-change.svg
  
  F8200468: swap_colors.sed 
  Of course you may give it a better name.
  
  Open questions are:
  
  - The icons in applets/ use #314045 as ColorScheme-ViewBackground, altough 
Icon_Workflow_Tips defines #232629. I think it should really be #232629, 
because that is the color which is actually used by the Breeze Dark theme. 
swap_colors.sed substitutes to #232629. The following picture illustrates what 
that means: (Auto-generated left, original right) F8200470: montage.png 
 I think we can do it how swap_colors.sed 
does it now, and get rid of icons-dark/applets/.
  - Icon_Workflow_Tips defines #232629 for ColorScheme-Text, but many icons 
have #4d4d4d as ColorScheme-Text, for example those in icons/applets/, but also 
some in icons-dark/actions/. The latter is a mistake which will be fixed by 
auto-generating. The former is currently respected by swap_colors.sed, and 
auto-generated icons correspond to those in icons-dark. (I think the icons 
should actually use #232629, but than can be fixed independently.)
  
  Next steps:
  
  - Run the compare-dark-light.pl again with the new swap_colors.sed script, to 
be sure it does color swapping fine now.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I was planning to. It would probably be helpful to do the cleanup first 
though.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  Can you write a bash script which copies the icon files to icons-dark/ and 
substitutes the colors? Apparently you know how to do that, my bash skills are 
a bit worse.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  I have created montages of the different icons. The original files to the 
left, the generated to the right. (Hover the images to see the file path)
  
  There are false positives:
  F8199094: categories_32_applications-development.png 

  
  Many have title bar buttons or panel buttons which should not be recolored:
  F8199096: categories_32_applications-engineering.png 

  F8199101: devices_64_computer.png 
  
  Many have more subtle differences (look at the screws):
  F8199104: devices_64_drive-partition.png 

  
  Many have big differences (which can maybe be avoided by improving the color 
substitution):
  F8199106: devices_64_network-rj45-female.png 

  
  Sometimes the generated ones look better (debatable):
  F8199111: emblems_22_rating.png 
  F8199113: actions_32_cursor-cross.png 
  
  In some icons I don’t see whether the difference is intended (look at the 
border):
  F8199116: actions_16_format-border-set-left.png 

  
  The script takes the output file of compare-dark-light.pl as argument. First 
you need to create the directory montages/.
  F8199092: montage-apparently-different-icons.pl 


TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a comment.


  None whatsoever. :)
  
  I suspect that most of the dark icons that are different from their light 
counterparts could be auto-ted and the differences are errors. So yeah, for any 
that aren't, the built script would simply avoid making an auto-generated 
version during compilation if there's already a handmade version in place. This 
would make it completely obvious which dark icons are handmade on purpose, 
since they would be the only dark monochrome icons in the source repo.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, 
LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a parent task: T11950: Reduce the pain of working on monochrome 
Breeze icons.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, 
ndavis, firef, ngraham, bruns, skadinna, aaronhoneycutt, mbohlender