Re: plasma-framework in kdereview
On Saturday 26 April 2014 10:56:00 Kevin Ottens wrote: Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the rest of frameworks ;-)) Thanks for looking into it. I checked with Burkhard Lück too and he said it was fine on the doc side as well. We just ended a clean up pass with Aurélien to make sure it was compliant with all the active policies, so it's now OK on our side as well. As far as I'm concerned it's ready to move in frameworks now. So you know, I got the OK from Ben for an early move as the main stakeholders did their duty of reviewing and we got a sprint going on. David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid hacking in an outdated checkout :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Saturday, April 26, 2014, David Faure fa...@kde.org wrote: David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid hacking in an outdated checkout :) Awesome, thanks :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
plasma-framework in kdereview
Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains: * libplasma: it's the old plasma library that used to be in kdelibs * QML plugins that depend from libplasma, they are old too, and come from kde- runtime * libplasmaquick: a library that depends from libplasma and QtQuick: it's completely for internal use right now (just like the majority of the qtquick library) eventually it may become public in the future, so it doesn't install any header, not part of the public api. * at least one plasma theme: the shipped QML components don't really work without it, so one is core * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Friday 25 April 2014 15:14:46 you wrote: * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. that's exactly why i want it there, and the fact that is a framework has been decided like, 3 years ago? So, do we really have to move it there? Imho would be prudent to keep it yes somewhere else where api/abi stability is not mandatory. that's exactly the reason why libplasmaquick doesn't install any header, that doesn't have committed compatibility, for sure I don't want any api/abi change whatsoever in libplasma, and for sure not in any qml component. Also, right now there is only one user of this framework (plasma-desktop), I would wait until at least we have 2 more shells based on it to commit to any stability. the user of libplasma doesn't have anything to do being a shell the user of any of its qml components doesn't have anything in being a shell. I want us to be mature enough to commit to some stability. If we can't commit to this minimum level of discipline, I wouldn't expect anybobody else to take it seriously in any way. I wouldn't even manage to encourage with a straight face anyone to ever write a 3rd party plasmoid. -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. So, do we really have to move it there? Imho would be prudent to keep it somewhere else where api/abi stability is not mandatory. Also, right now there is only one user of this framework (plasma-desktop), I would wait until at least we have 2 more shells based on it to commit to any stability. Wasn't/isn't libplasma supposed to be used also by other applications (amarok was the main user I guess)? It always was. wether they want to use it or not it's their problem and this attitude of pest dependency deeply bothers me and makes me not much really motivated to keep working on it. yes, it has a lot of dependencies and is not optimal. f i would have it primarly as ligthtweight libraries i would split it at lest in 3-4 parts, but i think it's better preventing the fragmentation of little libraries in this case -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
On Friday 25 April 2014 15:14:46 Àlex Fiestas wrote: On Friday 25 April 2014 12:34:32 Marco Martin wrote: Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains: * libplasma: it's the old plasma library that used to be in kdelibs * QML plugins that depend from libplasma, they are old too, and come from kde- runtime * libplasmaquick: a library that depends from libplasma and QtQuick: it's completely for internal use right now (just like the majority of the qtquick library) eventually it may become public in the future, so it doesn't install any header, not part of the public api. * at least one plasma theme: the shipped QML components don't really work without it, so one is core * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. Huh? So, do we really have to move it there? Imho would be prudent to keep it somewhere else where api/abi stability is not mandatory. Well... it's been planned this way for three years if not more. Before that it was in kdelibs. Also, right now there is only one user of this framework (plasma-desktop), That's because the other users weren't ported to KF5 yet. But there's definitely more plasma users (amarok comes to mind, skrooge too iirc), not really shells. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the rest of frameworks ;-)) I'll be fixed once Aurelien does the patch for all frameworks defining the cmake variable for the domain. There's one thing that someone needs to think about and is this two strings in the qml files QueryDialog.qml:52:property string acceptButtonText: i18n(Ok) QueryDialog.qml:53:property string rejectButtonText: i18n(Cancel) That either need to load the catalog manually (the cmake define won't help here) or they need to specify the domain or they need to be killed and use som kguistdthing that provides those translations. Cheers, Albert the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains: * libplasma: it's the old plasma library that used to be in kdelibs * QML plugins that depend from libplasma, they are old too, and come from kde- runtime * libplasmaquick: a library that depends from libplasma and QtQuick: it's completely for internal use right now (just like the majority of the qtquick library) eventually it may become public in the future, so it doesn't install any header, not part of the public api. * at least one plasma theme: the shipped QML components don't really work without it, so one is core * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: plasma-framework in kdereview
Hello, On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the rest of frameworks ;-)) Thanks for looking into it. I checked with Burkhard Lück too and he said it was fine on the doc side as well. We just ended a clean up pass with Aurélien to make sure it was compliant with all the active policies, so it's now OK on our side as well. As far as I'm concerned it's ready to move in frameworks now. I'll be fixed once Aurelien does the patch for all frameworks defining the cmake variable for the domain. There's one thing that someone needs to think about and is this two strings in the qml files QueryDialog.qml:52:property string acceptButtonText: i18n(Ok) QueryDialog.qml:53:property string rejectButtonText: i18n(Cancel) That either need to load the catalog manually (the cmake define won't help here) or they need to specify the domain or they need to be killed and use som kguistdthing that provides those translations. OK, thanks. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
