D15084: Change documentation to reflect the real toolchain CMake name

[Aleix Pol Gonzalez]

apol added a comment.


  Thanks!

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15084

To: bport, apol, alexeymin
Cc: alexeymin, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15089: Add syntax highlighting for SELinux kernel policy language

[Nibaldo González]

nibags added a comment.


  I'll do the commit this week, because I want to do a last test...

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-selinux

REVISION DETAIL
  https://phabricator.kde.org/D15089

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14983: Set breeze as fallback icon theme

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks sound to me.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14983

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

[Antonio Rojas]

arojas added a comment.


  In D15091#316243 , @rdieter wrote:
  
  > I was asking mostly because that's what pyqt upstream strongly suggested 
(to use all sip_flags) when I asked them.
  
  
  Oh, if upstream recommends it then I guess it should cause no issues.  That 
would allow dropping quite some code from FindPythonModuleGeneration.cmake. 
And, as a bonus, if would fix the annoying issue that KF5 bindings require 
PyQt5 to be recompiled (and patched) for every new patch version of Qt. Is 
there an upstream thread/post for reference?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

[Ben Cooksley]

Hi all,

We currently have a severe bug in ECM's AddTest macro due to it's
behaviour around the setting of QT_PLUGIN_PATH. On Windows it would
appear that the code in ECMAddTest mangles the environment variable,
removing crucial paths that the CI system includes within this
variable which are needed for applications and tests to function.

As a consequence of this, several projects tests are broken, and some
of these only fail by timeout. This has the effect of blocking Windows
CI builders for several hours in some instances simply due to tests
that are hanging and timing out as a result of being unable to load
plugins.

Can we please either short circuit this logic (and not try to set
QT_PLUGIN_PATH on Windows) or figure out the correct logic to be used
in this instance?

My suspicion is that CMake treats ';' specially, which means that when
the macro re-includes the existing content of the variable it gets
mangled by CMake, resulting in the entire content of that variable
being rendered unreadable.

Alternatively, CMAKE_LIBRARY_OUTPUT_DIRECTORY could have a trailing
backslash, which has certainly caused issues elsewhere.

Thanks,
Ben

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/205/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Aug 2018 09:27:21 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D15021: Workaround bug with native rendering and opacity in TextField text

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2faa71a55a75: Workaround bug with native rendering and 
opacity in TextField text (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15021?vs=40297=40542

REVISION DETAIL
  https://phabricator.kde.org/D15021

AFFECTED FILES
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

To: davidedmundson, #plasma, broulik
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15091: Compile python bindings with the same sipname used by PyQt

[Rex Dieter]

rdieter added a comment.


  These 2 threads:
  https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040759.html
  https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040771.html

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15125: Improve skip offset handling, allow to skip full line on no match

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Nice find! And a nice showcase of a contribution we wouldn't have gotten 
without MIT relicensing I guess :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15125

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15125: Improve skip offset handling, allow to skip full line on no match

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
cullmann added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  e.g. doMatch for regex stuff will use -1 as skipOffset.
  But -1 was not handled at all and you matched again and again.

TEST PLAN
  make && make test works
  
  with patch:
  Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 2552ms
  
  - Finished testing of TestHighlighterTest *
  
  without patch:
  
  Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 3250ms
  
  - Finished testing of TestHighlighterTest *
  
  perf shows improvements, too, found during some AbsInt internal profiling .P

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15125

AFFECTED FILES
  src/lib/abstracthighlighter.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15127: Fix typos for "Show line count"

[Shubham]

shubham created this revision.
shubham added reviewers: cullmann, vkrause.
shubham added projects: KTextEditor, Frameworks.
Herald added a project: Kate.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
shubham requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15127

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15127: Fix typos for "Show line count"

[Shubham]

shubham updated this revision to Diff 40564.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15127?vs=40563=40564

REVISION DETAIL
  https://phabricator.kde.org/D15127

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15125: Improve skip offset handling, allow to skip full line on no match

[Christoph Cullmann]

cullmann added a comment.


  ;=)
  Yeah, given I can spend now some work-time on profiling things as we start to 
use the current master for our tools, I hope I can contribute some more things 
like this.
  A colleague has seen a massive slow-down compared to our old highlighter for 
some internal format and given it just has a few regex rules and a keyword 
list, this is a bit strange, need to see if this alone solves it.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15125

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15091: Compile python bindings with the same sipname used by PyQt

[Antonio Rojas]

arojas planned changes to this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

[Nathaniel Graham]

ngraham added a comment.


  So do we have any firm conclusions here? The current state is already rather 
broken both conceptually and in practice, as illustrated by the "before" images.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, 
ngraham

D15127: Fix typos for "Show line count"

[Shubham]

shubham edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15127

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15125: Improve skip offset handling, allow to skip full line on no match

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:184483443f4f: Improve skip offset handling, allow to skip 
full line on no match (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15125?vs=40557=40566

REVISION DETAIL
  https://phabricator.kde.org/D15125

AFFECTED FILES
  src/lib/abstracthighlighter.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Christoph Cullmann]

cullmann updated this revision to Diff 40572.
cullmann added a comment.


  optimize html exporter, 23% => 15% of runtime for applyFormat in unit test

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15129?vs=40571=40572

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15129

AFFECTED FILES
  src/lib/htmlhighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15127: Fix typos for "Show line count"

[Shubham]

shubham added a comment.


  Going to land this now

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15127

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15127: Fix typos for "Show line count"

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with this.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15127

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D14991: Track state acked by XDG Client

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Edit. I need to track in shellclient anyway for positionAfterResize. May as 
well do it all there

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14991

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Very nice, thank you!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15129

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Christoph Cullmann]

cullmann updated this revision to Diff 40573.
cullmann added a comment.


  add my copyright, too

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15129?vs=40572=40573

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15129

AFFECTED FILES
  src/lib/htmlhighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15127: Fix typos for "Show line count"

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4c43ab238ec2: Fix typos for Show line count 
(authored by shubham).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15127?vs=40564=40575

REVISION DETAIL
  https://phabricator.kde.org/D15127

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp

To: shubham, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15091: Compile python bindings with the same sip flags used by PyQt

[Antonio Rojas]

arojas updated this revision to Diff 40570.
arojas retitled this revision from "Compile python bindings with the same 
sipname used by PyQt" to "Compile python bindings with the same sip flags used 
by PyQt".
arojas edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15091?vs=40479=40570

REVISION DETAIL
  https://phabricator.kde.org/D15091

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake
  find-modules/run-sip.py

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

TEST PLAN
  make && make test
  
  before, perf tells for
  
  perf record -g ./bin/htmlhighlighter_test
  
  > Rule::match 40% & KeywordListRule::doMatch 26%
  
  
  after the patch
  
  > Rule::match 17% & KeywordListRule::doMatch 4.5%
  =
  
  binary search was slower, contains is much faster on the VERY small strings

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15129

AFFECTED FILES
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Christoph Cullmann]

cullmann added a comment.


  And yes, you see even the costs for the auto defData = 
DefinitionData::get(m_def.definition()); as a high percentage, close to the 
total costs of KeywordListRule::doMatch now.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15129

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.11/2/
 Project:
Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 28 Aug 2018 20:44:55 +
 Build duration:
2 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15134

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I fixed the tests again by adding the m_defData back.
  I am not sure, if that really is the right fix.
  That was like this before, but can't by accident the refData just point again 
to a new definition object that is newly allocated?
  Should we use a DefinitionRef there?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15134

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 189 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/189/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Aug 2018 22:30:11 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2515/3130)68%
(1783/2609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(608/619)62%
(356/570)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib89%
(25/28)89%
(25/28)86%
(1714/1997)74%
(1230/1655)

D14922: Assert if trying to use a KCatalog without a QCoreApplication

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D14922

To: aacid, dfaure
Cc: dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Dominik Haumann]

dhaumann added a comment.


  Very nice.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15129

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.10 - Build # 37 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.10/37/
 Project:
Frameworks karchive kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Aug 2018 21:50:51 +
 Build duration:
1 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.karchivetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)77%
(27/35)77%
(27/35)78%
(4249/5462)54%
(1824/3408)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(1176/1185)52%
(538/1027)src84%
(21/25)84%
(21/25)77%
(3073/4010)58%
(1286/2205)tests0%
(0/4)0%
(0/4)0%
(0/267)0%
(0/176)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 188 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/188/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 28 Aug 2018 22:06:45 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.syntaxrepository_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)83%
(33/40)83%
(33/40)67%
(2107/3123)58%
(1521/2613)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(7/8)88%
(7/8)63%
(385/615)32%
(182/570)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib89%
(25/28)89%
(25/28)77%
(1529/1994)69%
(1142/1659)

D15131: add acronym ASCII to general.entities

[Burkhard Lück]

lueck created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  16 hits in trunk l10n-kf5/documentation

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15131

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15131: add acronym ASCII to general.entities

[Luigi Toscano]

ltoscano accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15131

To: lueck, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D14674: handle non-ASCII encodings of file names in tar archives

[Albert Astals Cid]

aacid added a comment.


  @ibragimovrinat KArchiveTest::testTarShortNonASCIINames is failing both in CI 
[1] and for me locally
  
  23:54:20 FAIL!  : KArchiveTest::testTarShortNonASCIINames() Compared values 
are not the same
  23:54:20Actual   (listing.count()): 0
  23:54:20Expected (1)  : 1
  23:54:20Loc: [/home/jenkins/workspace/Frameworks karchive kf5-qt5 
SUSEQt5.9/autotests/karchivetest.cpp(815)]
  
  Can you have a look please?
  
  [1] 
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/30/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: aacid, xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, 
michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

[Albert Astals Cid]

aacid added a comment.


  @ibragimovrinat ah my fault, arc didn't create the tar.gz file 
correctly from the diff

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: aacid, xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, 
michaelh, ngraham, bruns

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1508e568d858: decrease StateData space by more than 50% 
and half the number of needed mallocs (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15134?vs=40584=40585

REVISION DETAIL
  https://phabricator.kde.org/D15134

AFFECTED FILES
  autotests/foldingtest.cpp
  autotests/htmlhighlighter_test.cpp
  autotests/test-config.h.in
  autotests/testhighlighter.cpp
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14674: handle non-ASCII encodings of file names in tar archives

[Albert Astals Cid]

aacid added a comment.


  @ibragimovrinat Actually can you please send me that tarball file to 
aa...@kde.org ? I don't seem to be able to recreate that from the diff file you 
attached.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: aacid, xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, 
michaelh, ngraham, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 134 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/134/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 28 Aug 2018 22:30:11 +
 Build duration:
6 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2515/3130)68%
(1783/2609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(608/619)62%
(356/570)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib89%
(25/28)89%
(25/28)86%
(1714/1997)74%
(1230/1655)

Re: KDE apps have missing icons when not on Breeze

[Albert Astals Cid]

El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va 
escriure:
> Missatge de Albert Vaca  del dia dj., 16 d’ag. 2018 a
> les 13:57:
> 
> > Hi everyone,
> >
> > If we want to reach more potential users, we have to make sure KDE
> > apps look properly in every desktop. Take a look at how KDE apps look
> > in Gnome, you will see there are lots of missing icons.
> >
> > https://imgur.com/a/nkeiryb
> >
> > It think it is important to get this fixed, as it can make people not
> > use our apps.
> >
> > Note that, on the other hand, Gnome apps look good in Plasma even when
> > Breeze doesn't have the icons they need. This is because they fall
> > back to their own theme when an icon is not found in the system theme:
> > I just tested it setting the icon theme to Breeze on Gnome, and
> > deleting the "actions" directory from Breeze, they show the Gnome
> > icons instead.
> >
> > Anyone has a suggestion on how to fix this?
> >
> 
> If we can get this accepted into Qt
> https://codereview.qt-project.org/#/c/237025/
> Which i think we could since it mimics nicely the setThemeName
> functionality.
> 
> We can then just add a Q_COREAPP_STARTUP_FUNCTION in KIconTheme that does
>   QIcon::setFallbackThemeName("breeze");
> 
> And that'd be a one place fix all solution.

FWIW this just landed 
https://phabricator.kde.org/D14983

Cheers,
  Albert

> 
> Cheers,
>   Albert
> 
> 
> >
> > (Please CC me as I'm not subscribed to the list.)
> >
> > Albert
> >

D14983: Set breeze as fallback icon theme

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D14983

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 133 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/133/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 28 Aug 2018 22:06:45 +
 Build duration:
4 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.syntaxrepository_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)83%
(33/40)83%
(33/40)67%
(2107/3123)58%
(1521/2613)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(7/8)88%
(7/8)63%
(385/615)32%
(182/570)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib89%
(25/28)89%
(25/28)77%
(1529/1994)69%
(1142/1659)

D14674: handle non-ASCII encodings of file names in tar archives

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Someone still needs to land this in the karchive repo, no? :) @ibragimovrinat 
I assume this is your first contribution, so you cannot yet push commits 
yourself, right? For that we will need an email address for the authorship of 
this patch in the commit, next to your name "Rinat Ibragimov". Which address 
can we use?
  
  (Only saw this while doing house-keeoing on my phab list, as before not 
enough clue about katchive currently, so needs someone else to land this, some 
of the reviewers should be able.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.9 - Build # 30 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/30/
 Project:
Frameworks karchive kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 28 Aug 2018 21:50:51 +
 Build duration:
4 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.karchivetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)77%
(27/35)77%
(27/35)78%
(4249/5462)54%
(1824/3408)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(1176/1185)52%
(538/1027)src84%
(21/25)84%
(21/25)77%
(3073/4010)58%
(1286/2205)tests0%
(0/4)0%
(0/4)0%
(0/267)0%
(0/176)

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  less space used by the object itself and only one vector instead of two => 
half of the needed allocations

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15134

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.11/2/
 Project:
Frameworks karchive kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 28 Aug 2018 21:50:51 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.karchivetest

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

cullmann added a comment.


  I improved the unit tests, too.
  No need to call diff if the files are really equal, improves testing speed + 
makes the tests much nicer to use as benchmarks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15134

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

cullmann updated this revision to Diff 40584.
cullmann added a comment.


  compare of references works without diff, just missing diff output
  this avoid spawning processes at all if all tests are fine
  
  > nicer to use unit test (as long as they work) for perf
  

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15134?vs=40583=40584

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15134

AFFECTED FILES
  autotests/foldingtest.cpp
  autotests/htmlhighlighter_test.cpp
  autotests/test-config.h.in
  autotests/testhighlighter.cpp
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9556855dcf18: improve performance of 
Rule::isWordDelimiter and KeywordListRule::doMatch (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15129?vs=40573=40579

REVISION DETAIL
  https://phabricator.kde.org/D15129

AFFECTED FILES
  src/lib/htmlhighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/14/
 Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 28 Aug 2018 22:06:45 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.folding_testFailed: TestSuite.htmlhighlighter_testFailed: TestSuite.syntaxrepository_testFailed: TestSuite.testhighlighter_test

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmpf, thought tests did work :P But memory faults are hard.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15134

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2827c4fc89eb: add defData again for valid state check 
(authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15134?vs=40585=40587#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15134?vs=40585=40587

REVISION DETAIL
  https://phabricator.kde.org/D15134

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15136: Fixed a typeo

[Scott Sloan]

ssloan created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
ssloan requested review of this revision.

REVISION SUMMARY
  Fixed a typeo in the index size output
  BUG: 397843

REPOSITORY
  R293 Baloo

BRANCH
  bug397843 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15136

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: ssloan
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15131: add acronym ASCII to general.entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:0d36318396e2: add acronym ASCII to general.entities 
(authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15131?vs=40578=40597

REVISION DETAIL
  https://phabricator.kde.org/D15131

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/53/
 Project:
Frameworks kdoctools kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 29 Aug 2018 03:41:08 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D15136: Fixed a typeo

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Thanks
  can you commit it ? Do you have commit access ?

REPOSITORY
  R293 Baloo

BRANCH
  bug397843 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15136

To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15136: Fixed a typeo

[Scott Sloan]

ssloan added a comment.


  New to this, so I don’t have commit access.

REPOSITORY
  R293 Baloo

BRANCH
  bug397843 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15136

To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks kactivities kf5-qt5 FreeBSDQt5.11 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20FreeBSDQt5.11/2/
 Project:
Frameworks kactivities kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 29 Aug 2018 04:36:32 +
 Build duration:
50 sec and counting

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  Missing previously.

TEST PLAN
  git add and commit worked.

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D15113

AFFECTED FILES
  COPYING.GPLv2
  COPYING.LGPLv2.0
  COPYING.LGPLv2.1

To: fvogt, #frameworks

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

[Luca Beltrame]

lbeltrame added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15113

To: fvogt, #frameworks
Cc: lbeltrame