D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added a comment.


  In D18601#402905 , @bruns wrote:
  
  > I think this becomes better structured when you:
  >
  > 1. Create one function per file type, with parameters (Taglib::Filestream, 
KFM::PropertyMap)
  > 2. From this function, call a generic `updateProperties(oldProperties, 
newProperties) -> mergedProperties`
  > 3. Call the type specific function from TaglibWriter::write(...)
  >
  >   Especially when taking the changes for writing the rating into account, 
this would make the code easier to read - handling of different types just once 
(not once for reading and once for writing), and no upcasting/dynamic_cast of 
Taglib::File*.  It also saves the heap allocation of the concrete TagLib::File 
implementation.
  
  
  Done. It requires a little bit more of boilerplate code, but I have not 
strong preference.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...and add logic to "Spelling.." and "Spelling (from cursor)" actions
  when there is a selection.
  

  
  This way the behavior fit to other actions where the selection as
  precedence over some default target and we have one entry less in menus.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

AFFECTED FILES
  src/spellcheck/spellcheckdialog.cpp
  src/spellcheck/spellcheckdialog.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 updated this revision to Diff 50703.
trickyricky26 added a comment.


  - Use a less flat gradient with a silver ringer

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50280=50703

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D14927: KConfig: handle directory symlinks correctly.

[David Faure]

dfaure added a comment.


  ping?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14927

To: dfaure, adridg, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[loh tar]

loh.tar added a comment.


  For my taste could be "Spelling (from cursor)" the only offered action 
(logic). Always to check from the start is rarely useful, but I guess no one 
like that idea.
  
  The current patch should cause no harm, except that someone need to reassign 
some shortcut or added tool bar button.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18638: Avoid using trimmed method

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  A better name would be "hasOnlySpaces" (with the opposite return value), but 
OK.

REPOSITORY
  R246 Sonnet

BRANCH
  remove_using_trimmed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18638

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12477: Add unit test to see that :/ files can work

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:276
> You should probably add a warning when `extractorList.size() > 1`, as in this 
> case the extractor you run would be arbitrary.
> 
> Though, I am currently not aware of cases where one mimetype is supported by 
> several extractors.

I plan to factor this out afterwards in order to share between the different 
tests, I will incorporate it there.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 50705.
astippich added a comment.


  - rebase on latest parent revision

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18603?vs=50501=50705

BRANCH
  enhance_taglibwriter2

REVISION DETAIL
  https://phabricator.kde.org/D18603

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18089: KLauncher: handle processes exiting without error

[David Faure]

dfaure closed this revision.
dfaure added a comment.


  Pushed as 
https://commits.kde.org/kinit/c29988a97b3ae7abc0d196a1166eb16ee6c3fa95

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Sorry for the delay

REPOSITORY
  R303 KInit

BRANCH
  klauncher-kateSessionManager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 10:39:05 +
 Build duration:
2 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7178/9546)55%
(3542/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3044/3136)53%
(1290/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 10:39:05 +
 Build duration:
3 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 10:39:15 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D9822: Add benchmarks for KDirWatch

[David Faure]

dfaure added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Hi Milian,
  
  The benchNotifyWatcher() test seems to fail on CI. Can you take a look?
  
  
https://build.kde.org/job/Frameworks/view/Everything/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/6/testReport/projectroot/autotests/kdirwatch_qfswatch_unittest/
  
  FAIL!  : KDirWatch_UnitTest::benchNotifyWatcher() Compared values are not the 
same
  
Actual   ((spy.count())): 7442
Expected (numFiles) : 7810
Loc: [/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 
SUSEQt5.10/autotests/kdirwatch_unittest.cpp(843)]

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9822

To: mwolff, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/5/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 02 Feb 2019 10:18:06 +
 Build duration:
2 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 247 lines...]LC_ALL= 'en_US.UTF-8'ANDROID_NDK_HOST  = 'linux-x86_64'MAIL  = '/var/mail/user'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/5/display/redirect'SHLVL = '1'OLDPWD= '/home/user'PWD   = '/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11'JENKINS_URL   = 'https://build.kde.org/'BUILD_DISPLAY_NAME= '#5'QT_SELECT = 'qt5'PKG_CONFIG_PATH   = '/opt/Qt/5.11.3/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'QT_PATH   = '/opt/Qt'LD_LIBRARY_PATH   = '/opt/Qt/5.11.3/android_armv7/lib:/opt/kdeandroid-deps/lib'ANDROID_HOME  = '/opt/android-sdk'PATH  = '/opt/Qt/5.11.3/android_armv7/bin:/opt/kdeandroid-deps/bin:/opt/cmake/bin:/opt/Qt/5.11.3/android_armv7/bin:/opt/android-sdk/tools:/opt/android-sdk/tools/bin:/opt/android-sdk/platform-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'BUILD_URL = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/5/'QMAKEFEATURES = '/opt/Qt/5.11.3/android_armv7/mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.11.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Targeting API '14' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Selected GCC toolchain 'arm-linux-androideabi-4.9'-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could NOT find QRencode (missing: QRencode_LIBRARIES QRencode_INCLUDE_DIRS) -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * Qt5Network (required version >= 5.11.3) * Qt5Qml (required version >= 5.11.3) * Qt5Quick-- The following REQUIRED packages have been found: * ECM (required version >= 5.54.0), Extra CMake Modules.,  * Qt5Core * Qt5Gui * Qt5Test * Qt5Widgets * Qt5 (required version >= 5.10.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * Dmtx, The Datamatrix library, -- The following REQUIRED packages have not been found: * QRencode, The QRencode library, CMake Error at /opt/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:93 (feature_summary)-- Configuring incomplete, errors occurred!See also 

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Dominik Haumann]

dhaumann added a comment.


  In general I am ok eith this. Although it's a tiny bit less transparent to 
the user.

INLINE COMMENTS

> spellcheckdialog.cpp:74
>  {
> -spellcheck(m_view->cursorPosition());
> +if (m_view->selection()) {
> +spellcheckSelection();

I don't like the fact that the function says "spellcheckFromCursor, and then 
internally does something different. Can this be improved by having the logic 
somewhere else?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/3/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 10:39:05 +
 Build duration:
2 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7188/9546)55%
(3549/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3050/3136)53%
(1290/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3344/4662)61%
(1954/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich updated this revision to Diff 50704.
astippich added a comment.


  - rewrite for better readability and to avoid heap allocation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18601?vs=50497=50704

BRANCH
  rewrite_taglib2

REVISION DETAIL
  https://phabricator.kde.org/D18601

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 10:39:15 +
 Build duration:
5 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D12477: Add unit test to see that :/ files can work

[David Faure]

dfaure added a comment.


  Right, this would fail if the part was not using QFile, indeed. Still, at the 
level of the KParts frameworks itself it's all fine ;)

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

CI for prison: missing dependency

[David Faure]

On samedi 2 février 2019 11:20:28 CET CI System wrote:
> -- The following REQUIRED packages have not been found:
> 
> * QRencode, The QRencode library,

Can this be added to the CI?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/7/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 10:39:15 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kglobalsettingstestFailed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21576/45962)38%
(13026/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11355/11759)50%
(7165/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(735/9697)6%
(314/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Fabian Vogt]

fvogt added a comment.


  In D18662#403612 , @ndavis wrote:
  
  > @fvogt LCP said a Qt bug was the reason that the icons weren't working 
correctly and that you would know more about it. I never got around to asking 
you though. Do you know which bug it is?
  
  
  I don't remember any bug with fallback names. The only one that is vaguely 
related is https://bugs.kde.org/show_bug.cgi?id=402172, but I doubt it's that 
one.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
  pointers and handle IDs in other cases (e.g. when get fails with
  MDB_BAD_TXN) and wreaks havoc in the application.
  
  This is a bit of a hacky fix since long-term solution probably requires
  more rigorous refactoring of the Baloo Engine. There's a lot of
  duplicate code and uninitialized values, which makes it hard to track
  the misuse of LMDB API.
  
  However this should fix a good deal of crashes, probably more.
  
  BUG: 361186
  BUG: 390823
  BUG: 372880
  BUG: 395888
  BUG: 367480
  BUG: 403720

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:409
> What are the differences between the various mp3 test cases?

It tests all possible ratings, since the commonly used numbers are somewhat 
arbitrary, and I wanted to make sure writing and extracting works

> bruns wrote in taglibwriter.cpp:153
> This should probably go into a separate file, togheter with the inverse 
> transform.
> 
> This can then be tested independently, i.e.
> 
>   for rating in {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10} {
> r = wmpRating(rating);
> Q_ASSERT(rating = balooRating(r)); }

We have to test the rest anyway, so I don't see much benefit in this honestly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12477: Add unit test to see that :/ files can work

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D12477#403709 , @dfaure wrote:
  
  > Still, at the level of the KParts frameworks itself it's all fine ;)
  
  
  Which "level" do you mean here? This test only works by pure chance given the 
current implementation detail of NotepadPart. It is not  testing something part 
of the API contract,

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:55 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/9/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 13:16:29 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:16:29 +
 Build duration:
1 hr 9 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:40 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:19:00 +
 Build duration:
1 hr 17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  I'm working on an alternative user interface for this. Stay tuned!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18676: Improve keyboard controls of the checksum widget

[Connor Farrell]

cfarrell created this revision.
cfarrell added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfarrell requested review of this revision.

REVISION SUMMARY
  Previously when using the tab key to navigate the widget,
  it would select the calculate buttons in the order:
  SHA1->SHA256->MD5
  This patch moves MD5 to be the first selection to match the visuals

TEST PLAN
  Manual testing on several files.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18676

AFFECTED FILES
  src/widgets/checksumswidget.ui

To: cfarrell, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:18:06 +
 Build duration:
5 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D18676: Improve keyboard controls of the checksum widget

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:04082f3c2ce1: Improve keyboard controls of the checksum 
widget (authored by cfarrell, committed by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18676?vs=50725=50733

REVISION DETAIL
  https://phabricator.kde.org/D18676

AFFECTED FILES
  src/widgets/checksumswidget.ui

To: cfarrell, #vdg, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:19:19 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(113/168)67%
(113/168)60%
(5696/9487)43%
(2227/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file66%
(25/38)66%
(25/38)51%
(862/1677)42%
(443/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:04 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:50:08 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
1 hr 15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
1 hr 31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/7/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 13:15:11 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6347/8464)43%
(10135/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5765/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:13:24 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5684/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(850/1675)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:17:41 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 13:19:00 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:19:52 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:22:04 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:20:47 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7179/9546)55%
(3545/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3045/3136)53%
(1293/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Stasiek Michalski]

hellcp added a comment.


  It's not really a workaround, all of those icons are valid when  it comes to 
YaST, however previous batch of YaST icons into Breeze was build on idea that 
icon `xyz-abc.svg` will fallback to `xyz.svg` inside the same icon theme. In 
QIcon::fromTheme that is the case IF icon `xyz-abc.svg` does not exist in 
hicolor or any other fallback theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18516: Fix end of folding region in rules with lookAhead=true

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think that lookAhead rules don't publish their length sounds like a sane 
improvement.
  
  All in all, I think the folding still has some general issues in how we 
handle it.
  
  e.g. I have ATM "interesting" highlighted areas for the folding of doxygen 
comments.
  
  I don't think we need to have an extra bool, one might later internally 
handle it differently with extra attributes in the hl files, like a 
lookAheadEndRegion as proposed, if we really don't like the general change.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-region-lookahead

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: loh.tar; removed: cullmann.
cullmann added a comment.


  We have cancel now ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: cullmann, #ktexteditor, #vdg, loh.tar
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: cullmann, #ktexteditor, #vdg, loh.tar
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  I'm working on an alternative user interface for this feature. Stay tuned!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

[Denis Karpovskii]

GeeXT created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GeeXT requested review of this revision.

REVISION SUMMARY
  This patch creates symlinks (for every application I've
  found on Flathub and for which Breeze icon theme has an icon) to let
  flatpak-provided .desktop files point to breeze-provided icons.
  
  Flatpak-exported .desktop files use different icon names
  (e. g. org.kde.okular instead of just okular) and because of that
  flatpak-provided .desktop files show in menus and panels with their
  default icons instead of breeze-provided icons even when Breeze icon
  theme is used.

TEST PLAN
  This can be tested by applying the patch and installing the icon
  theme into ~/.local/share/icons. Reboot/relogin may be necessary.
  Then to see the changes you can install org.gimp.GIMP from flathub.
  Without the patch GIMP uses its default icon in application
  menus/panels/docks/etc. With the patch it will use the
  breeze-provided icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  flatpak-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18673

AFFECTED FILES
  icons-dark/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/org.kde.elisa.svg
  icons-dark/apps/22/org.videolan.VLC.svg
  icons-dark/apps/32/org.videolan.VLC.svg
  icons-dark/apps/48/com.elsevier.MendeleyDesktop.svg
  icons-dark/apps/48/com.google.AndroidStudio.svg
  icons-dark/apps/48/com.sublimetext.three.svg
  icons-dark/apps/48/com.syntevo.SmartGit.svg
  icons-dark/apps/48/com.valvesoftware.Steam.svg
  icons-dark/apps/48/com.viber.Viber.svg
  icons-dark/apps/48/cx.ring.Ring.svg
  icons-dark/apps/48/fr.free.Homebank.svg
  icons-dark/apps/48/fr.handbrake.ghb.svg
  icons-dark/apps/48/io.atom.Atom.svg
  icons-dark/apps/48/io.brackets.Brackets.svg
  icons-dark/apps/48/io.github.Fontforge.svg
  icons-dark/apps/48/net.scribus.Scribus.svg
  icons-dark/apps/48/nl.openoffice.bluefish.svg
  icons-dark/apps/48/org.audacityteam.Audacity.svg
  icons-dark/apps/48/org.blender.Blender.svg
  icons-dark/apps/48/org.clementine_player.Clementine.svg
  icons-dark/apps/48/org.codeblocks.codeblocks.svg
  icons-dark/apps/48/org.darktable.Darktable.svg
  icons-dark/apps/48/org.filezillaproject.Filezilla.svg
  icons-dark/apps/48/org.gimp.GIMP.svg
  icons-dark/apps/48/org.gnu.emacs.svg
  icons-dark/apps/48/org.inkscape.Inkscape.svg
  icons-dark/apps/48/org.kde.elisa.svg
  icons-dark/apps/48/org.kde.kapman.svg
  icons-dark/apps/48/org.kde.katomic.svg
  icons-dark/apps/48/org.kde.kblocks.svg
  icons-dark/apps/48/org.kde.kdenlive.svg
  icons-dark/apps/48/org.kde.kdiamond.svg
  icons-dark/apps/48/org.kde.kjumpingcube.svg
  icons-dark/apps/48/org.kde.klines.svg
  icons-dark/apps/48/org.kde.kolourpaint.svg
  icons-dark/apps/48/org.kde.kontact.svg
  icons-dark/apps/48/org.kde.okular.svg
  icons-dark/apps/48/org.kde.skrooge.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-base.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-calc.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-draw.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-impress.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-main.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-math.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-startcenter.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-writer.svg
  icons-dark/apps/48/org.octave.Octave.svg
  icons-dark/apps/48/org.qbittorrent.qBittorrent.svg
  icons-dark/apps/48/org.qownnotes.QOwnNotes.svg
  icons-dark/apps/48/org.quassel_irc.QuasselClient.svg
  icons-dark/apps/48/org.synfig.SynfigStudio.svg
  icons-dark/apps/48/org.telegram.desktop.svg
  icons-dark/apps/48/org.tordini.flavio.Minitube.svg
  icons-dark/apps/48/org.videolan.VLC.svg
  icons/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/org.kde.elisa.svg
  icons/apps/22/org.videolan.VLC.svg
  icons/apps/32/org.videolan.VLC.svg
  icons/apps/48/com.elsevier.MendeleyDesktop.svg
  icons/apps/48/com.google.AndroidStudio.svg
  icons/apps/48/com.sublimetext.three.svg
  icons/apps/48/com.syntevo.SmartGit.svg
  icons/apps/48/com.valvesoftware.Steam.svg
  icons/apps/48/com.viber.Viber.svg
  icons/apps/48/cx.ring.Ring.svg
  icons/apps/48/fr.free.Homebank.svg
  icons/apps/48/fr.handbrake.ghb.svg
  icons/apps/48/io.atom.Atom.svg
  icons/apps/48/io.brackets.Brackets.svg
  icons/apps/48/io.github.Fontforge.svg
  icons/apps/48/net.scribus.Scribus.svg
  icons/apps/48/nl.openoffice.bluefish.svg
  icons/apps/48/org.audacityteam.Audacity.svg
  icons/apps/48/org.blender.Blender.svg
  icons/apps/48/org.clementine_player.Clementine.svg
  icons/apps/48/org.codeblocks.codeblocks.svg
  icons/apps/48/org.darktable.Darktable.svg
  icons/apps/48/org.filezillaproject.Filezilla.svg
  icons/apps/48/org.gimp.GIMP.svg
  icons/apps/48/org.gnu.emacs.svg
  

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Changes the icon for the "None" item in grid view KCMs (present in the Splash 
Screen KCM) to differentiate it from other items that have no preview.
  F6583130: Grid View KCM None Item Icon.png 


TEST PLAN
  Open the Splash Screen KCM.

REPOSITORY
  R296 KDeclarative

BRANCH
  use-different-icon-for-none-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18675

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  Yes, I think people are correct that these modal dialogs are annoying. I'm 
working on something to show the errors and warnings inline at the moment when 
you're typing the file/folder name in the first place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:24:44 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7189/9546)56%
(3553/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3051/3136)53%
(1294/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3344/4662)61%
(1954/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/12/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
47 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13324)18%
(1813/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:44 +
 Build duration:
1 hr 21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7178/9546)55%
(3543/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3044/3136)53%
(1291/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis added a comment.


  I think I'll just land this. It fixes a bug caused by my misunderstanding of 
how YaST currently works.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18665: Cleanup taglib writer test

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Cleanup taglib writer test and add
  a warning when they are multiple extractors
  available, which may influence extraction
  results.

REPOSITORY
  R286 KFileMetaData

BRANCH
  simplify_writing_test

REVISION DETAIL
  https://phabricator.kde.org/D18665

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added a dependent revision: D18665: Cleanup taglib writer test.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18665: Cleanup taglib writer test

[Alexander Stippich]

astippich added a dependency: D18604: Implement support for writing rating 
information for taglib writer.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18665

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:40 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:32 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: apol, smartins.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  clazy 1.5 renamed its plugin from from ClangLazy.so to ClazyPlugin.so

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:22:31 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:32 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:42 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
1 hr 8 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D18638: Avoid using trimmed method

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:ef9c9253e5b4: Avoid using trimmed method (authored by 
mlaurent).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18638?vs=50631=50710

REVISION DETAIL
  https://phabricator.kde.org/D18638

AFFECTED FILES
  src/ui/highlighter.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 13:15:40 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:11 +
 Build duration:
1 hr 4 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Christoph Cullmann]

cullmann added a comment.


  ;=) given ::spellcheck() has the same magic, I don't think we really need to 
rename the function.
  And spellcheckSelectionOrFromCursor is a bit strange, too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 15:24:41 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D18676: Improve keyboard controls of the checksum widget

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18676

To: cfarrell, #vdg, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:15 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:05 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:18:06 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33026/48362)51%
(15896/31078)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4453/4754)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1563/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)67%
(721/1069)57%
(266/465)src.search100%
(7/7)100%
 

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/6/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 02 Feb 2019 13:21:40 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 247 lines...]PKG_CONFIG_PATH   = '/opt/Qt/5.11.3/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'BUILD_NUMBER  = '6'PATH  = '/opt/Qt/5.11.3/android_armv7/bin:/opt/kdeandroid-deps/bin:/opt/cmake/bin:/opt/Qt/5.11.3/android_armv7/bin:/opt/android-sdk/tools:/opt/android-sdk/tools/bin:/opt/android-sdk/platform-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'_ = '/usr/bin/java'ANDROID_NDK_ROOT  = '/opt/android-ndk'USER  = 'user'ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'QMAKESPEC = 'android-g++'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.11.3/android_armv7:/opt/kdeandroid-deps'JOB_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/'HUDSON_URL= 'https://build.kde.org/'LC_ALL= 'en_US.UTF-8'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/display/redirect'QT_PATH   = '/opt/Qt'ANDROID_NDK_TOOLS_PREFIX  = 'arm-linux-androideabi'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'DEBIAN_FRONTEND   = 'noninteractive'JENKINS_URL   = 'https://build.kde.org/'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.11.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Targeting API '14' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Selected GCC toolchain 'arm-linux-androideabi-4.9'-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could NOT find QRencode (missing: QRencode_LIBRARIES QRencode_INCLUDE_DIRS) -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * Qt5Network (required version >= 5.11.3) * Qt5Qml (required version >= 5.11.3) * Qt5Quick-- The following REQUIRED packages have been found: * ECM (required version >= 5.54.0), Extra CMake Modules.,  * Qt5Core * Qt5Gui * Qt5Test * Qt5Widgets * Qt5 (required version >= 5.10.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * Dmtx, The Datamatrix library, -- The following REQUIRED packages have not been found: * QRencode, The QRencode library, CMake Error at /opt/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:07 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 13:19:31 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 13:20:47 +
 Build duration:
38 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7188/9546)56%
(3554/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3051/3136)53%
(1294/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3344/4662)61%
(1954/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18116: Don't show document load trouble twice

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Just to be sure:
  
  We can apply D18117  and don't need to 
change here anything or?

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:19c936621729: Improve the Notfication Bell Icon by using 
the KAlarm design (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50703=50727

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Note: this will break with older clazy versions. I'm not sure how to prevent 
that.
  One could argue that a developer interested in clazy should probably run the 
latest version anyway...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:48 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:296
>  if(ENABLE_CLAZY)
> -set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClangLazy${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
> +set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
>  endif()

You can use

  find_library(CLAZY ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX})
  if(NOT CLAZY)

  else

  endif()

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Antonio Rojas]

arojas added a comment.


  You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to  '-Xclang 
-add-plugin -Xclang clazy' for the plugin to be actually loaded.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18662: Add and rename some YaST icons and symlinks

[Noah Davis]

ndavis retitled this revision from "Add and rename some YaST icon symlinks" to 
"Add and rename some YaST icons and symlinks".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns