D19691: ViewInternal: Review drop event

[loh tar]

loh.tar updated this revision to Diff 53702.
loh.tar retitled this revision from "[WIP] ViewInternal: Review drop event" to 
"ViewInternal: Review drop event".
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Fix cursor position after undo...harr
  - Improve readability
  - More code comments
  - Autotest still looks good
  
  These changhes sadly obscure slightly the patch diff
  
  - Update Summary/Title, I think patch its so far final now, beside...
  - Please see (and comment) code comments
  
  TODO
  Block mode after selection is buggy when mixed tab+spaces are involved.
  But that should not be an issue of this patch, perhaps can't that never be 
fixed(?)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19691?vs=53681=53702

REVISION DETAIL
  https://phabricator.kde.org/D19691

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim planned changes to this revision.
bonghyunkim added a comment.


  I finally got some time to install various dependencies to set up the tests 
and run them, but three tests keep failing. They are: folding_test, 
testhighlighter_test, htmlhighlighter_test.
  
  The error message is always same:
  
FAIL!  : HTMLHighlighterTest::testHighlight(highlight.elm) 
'ref.open(QIODevice::ReadOnly | QIODevice::Text)' returned FALSE. ()
   Loc: 
[/home/lambda/Documents/Projects/syntax-highlighting/autotests/test-config.h(65)]
  
  I tried giving all privileges through chmod 777, changing file name and 
extension to that of another language that already works, i.e. test.hs, and 
making the file an empty file by deleting all texts in it.
  None worked, and I couldn't google how to handle this error.
  
  I'm running Ubuntu 18.04, cmake 3.13.4, Make 4.1, and QT 5.10.0.
  
  Is there any further advice?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19696: Add blender thumbnailer

[Luigi Toscano]

ltoscano added a comment.


  I have my usual question: shouldn't this go into kdegraphics-thumbnailers? 
kio-extras shouldn't be a "dump everything which is not somewhere else".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks
Cc: ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19697: Fixes the build failure when using ECM Android toolchain

[Aleix Pol Gonzalez]

apol added a comment.


  Maybe it would make more sense to remove them instead?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19697

To: sh-zam
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When changing an `IconItem` from using a local image (e.g. PNG file) to using 
a Plasma themed icon, the implicit size wasn't updated since the old image was 
still loaded in `m_imageIcon`. Clearing it when clearing the other icon stores 
fixes this.
  
  BUG: 405298

TEST PLAN
  - Changed kickoff icon to be a rectangular image, reset it back to default, 
button size updated correctly

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19674

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[David Faure]

dfaure added a comment.


  I must be missing something.
  
  How can a job "examine the real destination" without having the URL of the 
destination?
  Is there some redirection happening or something?

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19677: Port UDisks to using DBus ObjectManager

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Right now it introspects DBus and fetches properties all over the place.
  This patch changes UDisks Manager to be the governor of all device data,
  calling GetManagedObjects (which conveniently returns all the properties)
  on startup. It also connects to change signals and updates the cache
  accordingly and tells the devices about it.
  
  This reduces impact of UDisks backend on Dolphin startup from 4.3% to 0.3%
  on my machine. On my laptop it spent 130ms on startup trying to figure out
  if something might be a optical drive or not...
  
  Since I don't have an optical drive, it is likely that handling for these
  is broken in this patch, at least one FIXME is definitely breaking it :)
  
  While it sheds quite some code and compacts property caching in a single place
  I'm not too happy about having this static Manager pointer in DeviceBackend,
  with both Manager telling the Device about changed properties and the Device
  asking the Manager about its properties.. Also, the Block directly accessing
  the Manager is somehwat awful.
  
  Fix updating existing device when it gains new interfaces
  
  So many hours wasted finding this...
  
  Fix monitoring optical drives
  
  We already listen to all change events anyway so rather than explicitly 
connecting
  to a certain path like the old one, we just process everything and try to 
figure out
  if it was meant for an optical drive whose disc became available.
  
  For the lack of an optical drive, I tested it in VirtualBox where attaching 
and
  removing CD images worked fine now.

REPOSITORY
  R245 Solid

BRANCH
  broulik/objectmanager

REVISION DETAIL
  https://phabricator.kde.org/D19677

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisks2.h
  src/solid/devices/backends/udisks2/udisksblock.cpp
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp
  src/solid/devices/backends/udisks2/udisksdevicebackend.h
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/udisks2/udisksmanager.h

To: broulik, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19677: WIP: Port UDisks to using DBus ObjectManager

[Kai Uwe Broulik]

broulik retitled this revision from "Port UDisks to using DBus ObjectManager" 
to "WIP: Port UDisks to using DBus ObjectManager".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16579: Remove support for non-standard APE tag field names from the test files

[James Smith]

smithjd added a comment.


  The change was ack'ed in this review, and this review closed by the commit.
  
  There was no code that required further review, only binary changes. The 
posted concerns were addressed by D18826 .
  
  If you really are that concerned that this review is cleaned up, request 
yourself that the reviewers that requested changes clear their request. I don't 
need to ask them to when the request is no longer valid. Otherwise, please at 
least read the full review closely before complaining about events you weren't 
consulted on or involved with, and have imo little reason to force a re-visit 
of.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2404693b9975: [CopyJob] Treat URL as dirty when renaming 
file as conflict resolution (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19586?vs=53347=53640

REVISION DETAIL
  https://phabricator.kde.org/D19586

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/52/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 10:40:45 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32866/60425)38%
(17069/44398)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4372/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8408/14403)51%
(4727/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4354/7987)40%
(1918/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[Kai Uwe Broulik]

broulik added a comment.


  Isn't "where the job first has to examine the real destination and only can 
then set it and start." and "In plasma-browser-integration I only get the 
destination after the job has been started." sufficient?

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/56/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Mar 2019 10:40:45 +
 Build duration:
9 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/38/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Mar 2019 10:40:45 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32880/60431)39%
(17111/44401)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8416/14410)51%
(4750/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4348/7987)40%
(1912/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D19672: [knewstuff] make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R304 KNewStuff

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19672

AFFECTED FILES
  CMakeLists.txt
  autotests/kmoretools/kmoretoolstest.cpp
  autotests/kmoretools/kmoretoolstest2.cpp
  src/attica/atticaprovider.cpp
  src/core/cache.cpp
  src/core/engine.cpp
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/downloadwidget.cpp
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolspresets.cpp
  src/qtquick/quickitemsmodel.cpp
  src/staticxml/staticxmlprovider.cpp
  src/ui/entrydetailsdialog.cpp
  src/ui/itemsgridviewdelegate.cpp
  src/ui/itemsviewdelegate.cpp
  src/upload/atticahelper.cpp
  src/uploaddialog.cpp
  tests/khotnewstuff.cpp
  tests/khotnewstuff_test.cpp
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16579: Remove support for non-standard APE tag field names from the test files

[Matthieu Gallien]

mgallien added a comment.


  In D16579#428835 , @smithjd wrote:
  
  > The change was ack'ed in this review, and this review closed by the commit.
  >
  > There was no code that required further review, only binary changes. The 
posted concerns were addressed by D18826 .
  >
  > If you really are that concerned that this review is cleaned up, request 
yourself that the reviewers that requested changes clear their request. I don't 
need to ask them to when the request is no longer valid. Otherwise, please at 
least read the full review closely before complaining about events you weren't 
consulted on or involved with, and have imo little reason to force a re-visit 
of.
  
  
  Hello, the tone of your comment is not appropriate.
  
  Please avoid this.
  
  I agree with @ngraham, you should have asked both commenters if they were in 
agreement with the content and scope of the review before landing it. This is 
the way reviews work.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

Re: KDE Frameworks 5.56.0 released

[David Faure]

On lundi 11 mars 2019 08:43:27 CET Kai Uwe Broulik wrote:
> Hi,
> 
> > KItemModels
> > 
> >KRearrangeColumnsProxyModel: make the two column-mapping methods public
> 
> I thought that was not allowed? According to [1]:
> 
> You cannot...
> * For existing functions of any type:
> ** change its signature. This includes:
> *** changing the access rights to some functions or data members, for
> example from private to public. With some compilers, this information
> may be part of the signature. If you need to make a private function
> protected or even public, you have to add a new function that calls the
> private one.

That is a very very odd piece of reasoning.

I know that MSVC builds the access right into the signature.
That means, changing from protected to public would break apps that derive 
from the class and call the formerly-protected method.

But if it's private nobody could possibly call it from the outside 
[assuming no "friends" hack, but that's not the case here], so why would it 
matter?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D19681: IconBorder: Accept drag events

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ..and forward them to KateViewInternal. This way is dropping text to
  column 1 of the view much less cumbersome
  
  BUG: 405280
  FIXED-IN: 5.57

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19681

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19672: [knewstuff] make it compile without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19672

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19674

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:017954185c83: [Icon Item] Also clear image icon when 
using Plasma Svg (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19674?vs=53637=53646

REVISION DETAIL
  https://phabricator.kde.org/D19674

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19679: Support image/vnd.zbrush.pcx mime type

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f74cec16ec01: Support image/vnd.zbrush.pcx mime type 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19679?vs=53647=53648#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19679?vs=53647=53648

REVISION DETAIL
  https://phabricator.kde.org/D19679

AFFECTED FILES
  thumbnail/imagethumbnail.desktop

To: broulik, #frameworks, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19677: WIP: Port UDisks to using DBus ObjectManager

[Stefan Brüns]

bruns added a comment.


  +10 on porting to ObjectManager
  
  Will do a proper review later

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19679: Support image/vnd.zbrush.pcx mime type

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `image/x-pcx` is deprecated

TEST PLAN
  I now get thumbnails for pcx image files again
  F6683663: Screenshot_20190311_134141.png 


REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19679

AFFECTED FILES
  thumbnail/imagethumbnail.desktop

To: broulik, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah! See that's the information I was missing (download job + user chooses 
interactively). In KIO we typically ask for a dest first, and only then start a 
job.
  
  If you could add a word in the commit log about the fact that user chooses 
interactively the dest as part of the job itself, that would be ideal.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[Kai Uwe Broulik]

broulik added a comment.


  In plasma-browser-integration I get a download started event by the browser 
right away and only when the user chose a download location I will get notified 
of that, so the job does not have a `destUrl` in the beginning.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19583

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19672: [knewstuff] make it compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:20870ce8cc79: [knewstuff] make it compile without foreach 
(authored by mlaurent).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19672?vs=53633=53650

REVISION DETAIL
  https://phabricator.kde.org/D19672

AFFECTED FILES
  CMakeLists.txt
  autotests/kmoretools/kmoretoolstest.cpp
  autotests/kmoretools/kmoretoolstest2.cpp
  src/attica/atticaprovider.cpp
  src/core/cache.cpp
  src/core/engine.cpp
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/downloadwidget.cpp
  src/kmoretools/kmoretools.cpp
  src/kmoretools/kmoretools_p.h
  src/kmoretools/kmoretoolsconfigdialog_p.cpp
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolspresets.cpp
  src/qtquick/quickitemsmodel.cpp
  src/staticxml/staticxmlprovider.cpp
  src/ui/entrydetailsdialog.cpp
  src/ui/itemsgridviewdelegate.cpp
  src/ui/itemsviewdelegate.cpp
  src/upload/atticahelper.cpp
  src/uploaddialog.cpp
  tests/khotnewstuff.cpp
  tests/khotnewstuff_test.cpp
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: mlaurent, dfaure, apol, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

D19672: [knewstuff] make it compile without foreach

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  Looks good to me... None of the scary ones that'll trigger various nasty side 
effects as far as i can tell.

REPOSITORY
  R304 KNewStuff

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19672

To: mlaurent, dfaure, apol, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/45/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Mar 2019 12:28:25 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Mar 2019 12:28:25 +
 Build duration:
7 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13345)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2264)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/41/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 12:28:25 +
 Build duration:
8 min 3 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3607/13345)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2264)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
 

D19679: Support image/vnd.zbrush.pcx mime type

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19679

To: broulik, #frameworks, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D16579: Remove support for non-standard APE tag field names from the test files

[Stefan Brüns]

bruns added a comment.


  The change, as you pushed it, was never open for review, so there was not 
even the chance to review.
  
  The new test files change the tested tag from one allowed variant to another. 
Both variants exist in the wild, and you changed the test coverage to the one 
you seemed to be more important. A good change would have increased the 
coverage.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

D19683: autotests: use new signal failedToLoad in ProviderTest

[David Faure]

dfaure created this revision.
dfaure added a reviewer: leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This is an attempt to improve error handling to fix CI failures

TEST PLAN
  Running the test, but it was already passing here

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19683

AFFECTED FILES
  autotests/providertest.cpp

To: dfaure, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

[Marco Martin]

mart edited the summary of this revision.
mart added a reviewer: Frameworks.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D19686

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19683: autotests: use new signal failedToLoad in ProviderTest

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  This does seem very much sensible, yes, well thought :)

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19683

To: dfaure, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

[Marco Martin]

mart added a comment.


  F6684042: Screenshot_20190311_162844.png 

  F6684047: Screenshot_20190311_164519.png 

  
  F6684051: Screenshot_20190311_164524.png 


REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D19686

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis added a comment.


  @trickyricky26 do you mind if I commandeer this so I can get it finished 
today?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19683: autotests: use new signal failedToLoad in ProviderTest

[David Faure]

dfaure closed this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19683

To: dfaure, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.10 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.10/11/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 16:49:15 +
 Build duration:
8 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FrameworkIntegration-5.57.0.xmlcompat_reports/KF5FrameworkIntegration_compat_report.htmllogs/KF5FrameworkIntegration/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)33%
(2/6)33%
(2/6)17%
(75/447)10%
(31/315)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)92%
(24/26)50%
(4/8)src.integrationplugin0%
(0/2)0%
(0/2)0%
(0/70)0%
(0/106)src.kpackage-install-handlers.kns0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/36)src.kstyle100%
(1/1)100%
(1/1)21%
(51/248)16%
(27/165)tests0%
(0/1)0%
(0/1)0%
(0/24)100%
(0/0)

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/32/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 09 Mar 2019 09:40:04 +
 Build duration:
2 days 5 hr and counting

D19686: don't scale when we are in AA_UseHighDpiPixmaps

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  when the flag AA_UseHighDpiPixmaps is set, the pixmap is already scaled,
  no need to scale it twice.
  the code calling virtual_hook in QIcon calls it with the following
  ScaledPixmapArgument:
  scalePixmapArg = { size * devicePixelRatio, mode, state, devicePixelRatio, 
QPixmap() }
  The requested pixmap size is already scaled, counting devicePixelRatio
  again will result in a pixmap scaled two times.

TEST PLAN
  Icons in apps with fractional scaling look a lot better

REPOSITORY
  R302 KIconThemes

BRANCH
  phab/iconRendering

REVISION DETAIL
  https://phabricator.kde.org/D19686

AFFECTED FILES
  src/kiconengine.cpp

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This extracts thumbnail from .blend files.
  
  Before: Default icon.
  After:
  F6685286: Blender thumbnail 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/blendercreator.cpp
  thumbnail/blendercreator.h
  thumbnail/blenderthumbnail.desktop

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19697: Fixes the build failure when using ECM Android toolchain

[Sharaf Zaman]

sh-zam created this revision.
Herald added a project: Frameworks.
sh-zam requested review of this revision.

REVISION SUMMARY
  ECM Android toolchain: 
https://phabricator.kde.org/source/extra-cmake-modules/browse/master/toolchain/Android.cmake
  Build failure log: https://paste.ubuntu.com/p/NBjfYXjXKx/

REPOSITORY
  R244 KCoreAddons

BRANCH
  android-bug-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19697

AFFECTED FILES
  src/lib/util/kuser_unix.cpp

To: sh-zam
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Mar 2019 17:10:34 +
 Build duration:
7 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.57.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/15/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Mar 2019 17:10:34 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D19652: Add cross-compilation support for kpackagetool5

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:d32f2d4e5ab2: Add cross-compilation support for 
kpackagetool5 (authored by vkrause).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19652?vs=53590=53680

REVISION DETAIL
  https://phabricator.kde.org/D19652

AFFECTED FILES
  CMakeLists.txt
  KF5PackageConfig.cmake.in
  src/kpackagetool/CMakeLists.txt

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19692: openwithdialog: use recursive flag in proxy filter

[Simone Gaiarin]

simgunz created this revision.
simgunz added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
simgunz requested review of this revision.

REVISION SUMMARY
  Use the flag introduced in Qt 5.10 instead of custom code

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-recursive-filtering

REVISION DETAIL
  https://phabricator.kde.org/D19692

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: simgunz, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

[Antonio Rojas]

arojas added a comment.


  This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19418

To: mlaurent, dfaure, apol
Cc: arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D19691: [WIP] ViewInternal: Review drop event

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Fix wrong selection when text is moved down
  - Allow drop into own area, but is only noticable when copy, not move
  - Code looks simpler, I think
  
  - Autotest looks good
  - Please see (and comment) code comments
  
  TODO/Help is appreciated
  
  - Cursor is wrong placed after undo
  - Block mode after selection is buggy when mixed tab+spaces are involved
  - Rename some variables, like targetCursor/2

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19691

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/15/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 17:10:34 +
 Build duration:
3 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.57.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D19313: Remove URLs being fetched when listing job is `completed`

[David Palacio]

dpalacio added a comment.


  Yes, all kdirmodel tests pass

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19313

To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19313: Remove URLs being fetched when listing job is `completed`

[David Palacio]

dpalacio closed this revision.
dpalacio added a comment.


  I regained write access and I committed it myself. Sorry for the noise.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19313

To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 added a comment.


  Sure, go ahead. I'm busy right now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/53/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 20:27:42 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32927/60432)39%
(17139/44400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4375/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8430/14403)51%
(4752/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4353/7987)40%
(1917/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(347/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D19691: [WIP] ViewInternal: Review drop event

[loh tar]

loh.tar added a comment.


  > Cursor is wrong placed after undo
  
  I'm confused. Can't see how that has worket before this patch. I tend to add 
a cursor info to the m_dragInfo struct. Reset to that position just before 
editStart()

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19691

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19686: don't scale when we are in AA_UseHighDpiPixmaps

[Kai Uwe Broulik]

broulik added a comment.


  I'm confused. Doesnt this undo the use of @2x icons and return to the old 
behavior of just loading a larger icon?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D19686

To: mart, #plasma, #frameworks
Cc: broulik, ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D19313: Remove URLs being fetched when listing job is `completed`

[David Palacio]

dpalacio added a comment.


  Could you commit this patch in my stead? I don't have commit access.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19313

To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

[Nathaniel Graham]

ngraham added a comment.


  Sweet, this makes so many things look a little bit better.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D19686

To: mart, #plasma, #frameworks
Cc: ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/39/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Mar 2019 20:27:42 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32923/60439)39%
(17133/44403)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4367/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8433/14411)51%
(4757/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4350/7987)40%
(1914/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(349/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/57/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Mar 2019 20:27:42 +
 Build duration:
6 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19681: IconBorder: Accept drag events

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks ok to me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19681

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19692: openwithdialog: use recursive flag in proxy filter

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-recursive-filtering

REVISION DETAIL
  https://phabricator.kde.org/D19692

To: simgunz, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE Frameworks 5.56.0 released

[Albert Astals Cid]

El dilluns, 11 de març de 2019, a les 9:26:43 CET, David Faure va escriure:
> On lundi 11 mars 2019 08:43:27 CET Kai Uwe Broulik wrote:
> > Hi,
> > 
> > > KItemModels
> > > 
> > >KRearrangeColumnsProxyModel: make the two column-mapping methods public
> > 
> > I thought that was not allowed? According to [1]:
> > 
> > You cannot...
> > * For existing functions of any type:
> > ** change its signature. This includes:
> > *** changing the access rights to some functions or data members, for
> > example from private to public. With some compilers, this information
> > may be part of the signature. If you need to make a private function
> > protected or even public, you have to add a new function that calls the
> > private one.
> 
> That is a very very odd piece of reasoning.
> 
> I know that MSVC builds the access right into the signature.
> That means, changing from protected to public would break apps that derive 
> from the class and call the formerly-protected method.
> 
> But if it's private nobody could possibly call it from the outside 
> [assuming no "friends" hack, but that's not the case here], so why would it 
> matter?

And honestly it's not like we care about MSVC binary compatibility at this 
point, right?

Our "binary compatibility users" are linux distros, whoever is using 
KItemModels in Windows using MSVC isn't most probably sharing it with anyone 
else so a binary incompatible change for them means "nothing".

Cheers,
  Albert

> 
> 

D16579: Remove support for non-standard APE tag field names from the test files

[James Smith]

smithjd added a comment.


  In D16579#428993 , @bruns wrote:
  
  > The change, as you pushed it, was never open for review, so there was not 
even the chance to review.
  
  
  Diff 44708 included these changes for review. No one requested changes then, 
and they were ack'ed since: 
https://phabricator.kde.org/D16579?vs=on=44708=ignore-most#420650 
.
  
  > Hello, the tone of your comment is not appropriate.
  
  You might as well have said, 'the change as you pushed it, fulfilled my 
request for changes, and there was not even a chance to lift it'. That's now 
praise instead of misinformation.
  
  > from the latest comments, it's not clear that their concerns were addressed 
first.
  
  Also misinformation: 
https://phabricator.kde.org/D16579?vs=on=44708=ignore-most#420650.
 There was also no dissension during the time since this comment was posted and 
the review was closed.
  
  If any subset of review changes were already in principle agreed upon and 
with no requested changes, //AND// the code requested changed is to be removed 
from the final patch, //AND// the changes are binary-only, and the differences 
not rendered on the review ticket:
  
  A) Further review is unnecessary, if only to allow the reviewers to cancel 
their (obsolete) change requests before it is closed;
  B) I'm not aware where it is required that ALL reviewers must cancel their 
requested changes before the review is closed. The review could have been just 
as simply closed without the commit hook and the agreed repository changes made 
without referencing the review in the commit message, of course ignoring the 
fabulous background this review brought before it was turned into an argument 
over why it was closed with 2 reviewers still left to cancel their 
(superfluous) involvement as they see fit.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: trickyricky26; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19665: Add Q_OBJECT to KFilterDev

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19665

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19666: Remove reference from const KConfigIniBackend::BufferFragment

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19666

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Mar 2019 22:38:17 +
 Build duration:
6 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/19/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Mar 2019 22:38:17 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D19668: Convert two old-style connects to new-style

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R271:1ed358b9022e: Convert two old-style connects to new-style 
(authored by aacid).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19668?vs=53627=53695

REVISION DETAIL
  https://phabricator.kde.org/D19668

AFFECTED FILES
  src/kdbusinterprocesslock.cpp
  src/kdbusservice.cpp

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19667: Add Q_EMIT to emit signal call

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:a37f2df41a03: Add Q_EMIT to emit signal call (authored by 
aacid).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19667?vs=53626=53694

REVISION DETAIL
  https://phabricator.kde.org/D19667

AFFECTED FILES
  src/lib/plugin/kpluginfactory.cpp

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 22:38:17 +
 Build duration:
4 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)