D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

[David Hallas]

hallas added a comment.


  Note that I haven't tested this patch locally because I don't know how to 
"run" the locally compiled devicenotifier. I can see that I get a 
`plasma_engine_devicenotifications.so` library from building the project, but I 
don't know how to "run" it, do we have a cli tool to load the shared library 
for testing? Or how do you guys test?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven updated this revision to Diff 69208.
meven added a comment.


  Fix test JobTest::cancelCopyAndCleanDest

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25117?vs=69204=69208

BRANCH
  better-kill

REVISION DETAIL
  https://phabricator.kde.org/D25117

AFFECTED FILES
  autotests/jobtest.cpp
  src/core/filecopyjob.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: meven, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: D25084: Allow a Multiple instances to become Unique

[Tomaz Canabrava]

https://invent.kde.org/kde/konsole/merge_requests/45

But it’s not related to this path, it’s just another bug


On Fri, 1 Nov 2019 at 07:06 David Edmundson 
wrote:

> davidedmundson added a comment. View Revision
> 
>
> I think I just need to verify if the name would be the same as the name
> minus the uuid. because if you open an app on ::Multiple and later the same
> app on ::Unique, merging them seems sane.
>
> Could you link your konsole patch, I don't yet see why we would want our
> now unique konsole to use a different path to normal.
>
> *REPOSITORY*
> R271 KDBusAddons
>
> *BRANCH*
> multiple_to_unique
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D25084
>
> *To: *tcanabrava, adridg
> *Cc: *davidedmundson, adridg, ngraham, kde-frameworks-devel, LeGast00n,
> GB_2, michaelh, bruns
>

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> deletejob.cpp:406
> +QMetaObject::invokeMethod(worker(), "rmfile", 
> Qt::QueuedConnection,
> +  Q_ARG(const QUrl&, m_currentURL),
> +  Q_ARG(bool, isLink));

Since you're already using m_currentURL here, I'd say this is acceptable.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven updated this revision to Diff 69204.
meven marked an inline comment as done.
meven added a comment.


  Better safe than sorry, keep the doKill override

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25117?vs=69187=69204

BRANCH
  better-kill

REVISION DETAIL
  https://phabricator.kde.org/D25117

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: meven, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25113: ftp ioslave: remove redundant variable

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d03551cd0367: ftp ioslave: remove redundant variable 
(authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25113?vs=69180=69205

REVISION DETAIL
  https://phabricator.kde.org/D25113

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/ftp/ftp.h

To: meven, #frameworks, kossebau, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  This patch will still need some work to make dark mode available.
  Kate will be able to switch to it via the color theme switcher, as that will 
just switch over to breeze-dark.
  
  Could you elaborate on
  
  "Also, our icon loading has kind of evolved and we've got a bit of code for 
switching between dark and light icons ourselves."
  
  If you have some hints where to look in the Krita code for ideas how that is 
done, I would be grateful ;=)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:0c195d0ff947: embed trigrams.map into shared library 
(authored by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25122?vs=69200=69211

REVISION DETAIL
  https://phabricator.kde.org/D25122

AFFECTED FILES
  data/CMakeLists.txt
  data/trigrams.qrc.in
  src/core/CMakeLists.txt
  src/core/guesslanguage.cpp

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

[Anthony Fieroni]

anthonyfieroni added a comment.


  Set QT_PLUGIN_PATH to you local path with plugin after that set the system 
path for others
  `QT_PLUGIN_PATH=/local/path:/system/path executable`

INLINE COMMENTS

> ksolidnotify.h:50
>  void notify(Solid::ErrorType solidError, const QString& error, const 
> QString& errorDetails, const QString );
> -void blockingAppsReady(const QStringList );
>  void clearNotification(const QString );

This is public signal, are you sure none use it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

[David Hallas]

hallas added a comment.


  In D25125#558043 , @anthonyfieroni 
wrote:
  
  > Set QT_PLUGIN_PATH to you local path with plugin after that set the system 
path for others
  >  `QT_PLUGIN_PATH=/local/path:/system/path executable`
  
  
  Thanks for the info :) But what executable would load the plugins? Would I 
have to set the `QT_PLUGIN_PATH` globally on my system, and use my installed 
kde to test? Or do we have a command line tool to load these plugins?

INLINE COMMENTS

> anthonyfieroni wrote in ksolidnotify.h:50
> This is public signal, are you sure none use it?

I think ;) As far as I can tell this is an internal class so it's API is not 
exported. I have also done a `git grep` in the plasma-workspace repository for 
any users, but I have found none.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 168 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/168/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 07:27:59 +
 Build duration:
7 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Boudewijn Rempt]

rempt added a comment.


  It sounds like it would be something very useful and easy to use. Right now, 
we package all icons Krita uses in rc files that are compiled in as well. Also, 
our icon loading has kind of evolved and we've got a bit of code for switching 
between dark and light icons ourselves.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

[David Hallas]

hallas created this revision.
hallas added reviewers: Frameworks, broulik, bruns.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Use the KListOpenFilesJob class from KCoreAddons to retrieve the
  applications that are blocking an unmount. The KListOpenFilesJob is a
  generalized version of the code here.

TEST PLAN
  Insert a USB stick
  Open a file from the USB stick
  Remove the USB stick using the Device Notifier
  Notice the error message

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use_klistopenfilesjob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25125

AFFECTED FILES
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/devicenotifications/ksolidnotify.h

To: hallas, #frameworks, broulik, bruns
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added a comment.


  @bruns - ping :) I have updated this patch with the changes you requested, I 
hope you are ok with it now.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25123: [WIP] New yakuake logo/icon

[Carl Schwan]

ognarb added a reviewer: hein.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, 
LeGast00n, GB_2, michaelh, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  I also think that this is too thin.
  If you'd like to do the updates, please go ahead! You can do it much better 
than me I think

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio removed a dependent revision: D25130: [dolphin/search] Search by 
(multiple) tags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The current icon is a black droplet which doesn't really communicate "pick a 
color from
  the screen", though that's what this icon is used for. Other apps use an 
eyedropper for
  this too.
  
  BUG: 403924
  FIXED-IN: 5.65
  (Or maybe if it's approved quickly we can still get it into 5.64?)

TEST PLAN
  Montage: F7729066: color-picker.png 
  
  In Kolourpaint: F7729065: In Kolourpaint.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  eyedropper-style-color-picker-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25132

AFFECTED FILES
  icons-dark/actions/16/color-picker.svg
  icons-dark/actions/22/color-picker.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/32/color-picker.svg
  icons/actions/16/color-picker.svg
  icons/actions/22/color-picker.svg
  icons/actions/24/color-picker.svg
  icons/actions/32/color-picker.svg

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  Done (in the process of being pushed), you can push this.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:11:45 +
 Build duration:
5 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 169 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/169/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:13:28 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:14:09 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:879769daf047: KDEFrameworkCompilerSettings: enable all Qt 
% KF deprecation warnings (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24990?vs=68847=69235

REVISION DETAIL
  https://phabricator.kde.org/D24990

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  As soon as we use the rcc file for the icons, we set an icon theme name.
  
  If you have an icon theme name set, QIcon::fromTheme will do:
  
bool hasUserTheme = QIconLoader::instance()->hasUserTheme();
QIconEngine * const engine = (platformTheme && !hasUserTheme) ? 
platformTheme->createIconEngine(name)
   : new QIconLoaderEngine(name);
   
  
  This IMHO means no longer KIconLoader will be used at all.
  (On Windows it will never be used, as the platform theme doesn't use it there 
anyways I assume)
  
  But yes, packaging Breeze Dark icons in addition will not help to fix this :/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25084: Allow a Multiple instances to become Unique

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Same reservations as davidedmundson.
  Furthermore this would break talking to dbus-activated unique apps, too, 
since they wouldn't register with the expected service name.
  -2 from me.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D25084

To: tcanabrava, adridg, dfaure
Cc: dfaure, GB_2, davidedmundson, adridg, ngraham, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:13:20 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

D25123: [WIP] New yakuake logo/icon

[KonqiDragon]

KonqiDragon added a comment.


  I like A.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, 
ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  In D25119#558092 , @broulik wrote:
  
  > In D25119#558084 , @cullmann 
wrote:
  >
  > > Hmm, where does that happen?
  >
  >
  > https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888
  >
  > > And does that work for icons you get via QIcon::fromTheme?
  >
  > Yes. As long as you pass a `QIcon` to the button or widget instead of an 
already rendered `QPixmap`.
  >
  > On Windows you probably don't use `KIconEngine` but whatever Qt provides by 
itself.
  >  There's some discussion on a fdo symbolic icon colorization 
(@davidedmundson should know more), which would be useful having in Qt then?
  
  
  Hmm, all KIconThemes related stuff should be in the application installer.
  Need to investigate this more.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer updated this revision to Diff 69225.
thomasfischer added a comment.


  I updated the diff. I was quite surprised about the time it takes to compute 
the number of commits (26 seconds), thus I removed this functionality 
completely. As of now, only 'revision' and 'branch' are queried for.
  There are three functions now:
  
  - `ecm_source_version_control_probe_revison` retrieves the source directory's 
Git revision and stores it in `ECM_SOURCE_VERSION_CONTROL_REVISION`. A check is 
made to return immediately if the revision got retrieved earlier. The Git 
executable is only searched for once, the path is stored in the private 
variable `_ECM_SOURCE_VERSION_GIT_EXECUTABLE`. Two warnings may be shown if 
source directory is either not under version control or the version control 
system is not Git. Private boolean variables are used to supress showing the 
same warning again once `ecm_source_version_control_probe_branch` (see below) 
gets invoked.
  - `ecm_source_version_control_probe_branch` is very similar to the function 
above, except for that it retrieves the branch and stores it in 
`ECM_SOURCE_VERSION_CONTROL_BRANCH`.
  - `ecm_source_version_control_status` will print out a status line about the 
current Git revision and branch. Invoking this function is optional. The 
function will invoke `ecm_source_version_control_probe_revison` and 
`ecm_source_version_control_probe_branch` to retrieve the necessary data. 
Nothing will be printed if no revision and no branch are known.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24641?vs=68072=69225

REVISION DETAIL
  https://phabricator.kde.org/D24641

AFFECTED FILES
  modules/ECMSourceVersionControl.cmake

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Vacations

[David Faure]

I'm going to be away on vacations until Nov 20, so don't worry if you don't 
get patches reviewed during that time.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D25123: [WIP] New yakuake logo/icon

[Nathaniel Graham]

ngraham added a comment.


  In D25123#558205 , @ndavis wrote:
  
  > #vdg ,  Should we allow some types of 
icons to be vertically off center? If not that, should we allow some icons to 
not reach all the way to the top and bottom margins? There are already some 
icons like that, but that doesn't necessarily mean we should want that.
  
  
  I don't think we should allow vertically off-center icons. The only reason to 
do this is to align the baselines of all icons, but that's only useful for 
horizontal rows of icons and looks bad with vertical columns of icons or 
anytime an icon is put within a container that is centered.
  
  I recently fixed a bug report about non-centered icons that shows the 
problems arising from this: https://bugs.kde.org/show_bug.cgi?id=393550

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/56/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:12:11 +
 Build duration:
9 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Merci, will land later tonight. Bonnes vacances :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:14:56 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:15:40 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  In D25119#558082 , @broulik wrote:
  
  > > If you e.g. want to switch to "breeze-dark" this fails as the icons will 
not be found.
  >
  > But why would you need this anyway? At least with `KIconEngine` we colorize 
the icons dynamically. I don't have to switch to breeze-dark when I use a dark 
color scheme on Plasma at least.
  
  
  Hmm, where does that happen?
  
  And does that work for icons you get via QIcon::fromTheme?
  
  For me, on Windows, just switching to dark mode via the color theme chooser 
nicely changes the palette colors but my icons stay "normal".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Kai Uwe Broulik]

broulik added a subscriber: davidedmundson.
broulik added a comment.


  In D25119#558084 , @cullmann wrote:
  
  > Hmm, where does that happen?
  
  
  https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888
  
  > And does that work for icons you get via QIcon::fromTheme?
  
  Yes. As long as you pass a `QIcon` to the button or widget instead of an 
already rendered `QPixmap`.
  
  On Windows you probably don't use `KIconEngine` but whatever Qt provides by 
itself.
  There's some discussion on a fdo symbolic icon colorization (@davidedmundson 
should know more), which would be useful having in Qt then?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 added a comment.


  What do you think of this? The symbol with 1px lines.
  
  F7727547: preferences-desktop-search.svg 

  
  F7727552: montage.png 
  I thought this might look nicer, but it is too thin IMO.
  
  In your current icon, the shadow is a bit off, the upper edge isn't quite 45° 
and it doesn't originate exactly from the circle. I can fix these tiny details 
if you like.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer edited the test plan for this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24641

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  You could use KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) to already put in place 
the trigger for the compat code to disappear when KF6 comes around, like you 
did in file_unix.cpp.
  It will also make it easier for the future developer who cleans this up.
  
  I mean deletejob.cpp:401, directorysizejob.cpp:137, those places with a "TODO 
KF6".

INLINE COMMENTS

> meven wrote in listjobtest.cpp:44
> > Does KIO::DefaultDetails make sense beyond stat in the KIO namespace? How 
> > does it match other similar flags?
> 
> It was @kossebau concern as well.
> 
> I am open to suggestion to improve on that, maybe this enum should be in KIO 
> namespace ?
> In the meantime, it was what was made the most sense to me.

Well if it's called KIO::StatDefaultDetails (with the extra "Stat" compared to 
the question above), then it doesn't need to be in KIO::StatJob.

So yes, you could move the enum to the KIO namespace and define it in 
src/core/global.h
This will keep the two jobs a bit more separate (no need to add #include 
"statjob.h" in a few places)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/49/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:14:39 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Kai Uwe Broulik]

broulik added a comment.


  > If you e.g. want to switch to "breeze-dark" this fails as the icons will 
not be found.
  
  But why would you need this anyway? At least with `KIconEngine` we colorize 
the icons dynamically. I don't have to switch to breeze-dark when I use a dark 
color scheme on Plasma at least.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio added a dependent revision: D25130: [dolphin/search] Search by 
(multiple) tags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Christoph Cullmann]

cullmann added a comment.


  Ok, I traced this now a bit.
  The KIconLoaderPrivate::createIconImage processing seems already not to work 
for resource based themes on Linux.
  
  To try, e.g. use Kate, add the binary resource icon theme to the right 
location
  
  cp /local/cullmann/kde/usr/share/icons/breeze/breeze-icons.rcc 
~/.local/share/kate/icontheme.rcc
  
  Switch in Kate to dark mode with Settings -> Color Theme -> Breeze Dark.
  
  Without the rcc file, this works.
  With the rcc file, the icons stay dark and are more or less invisible.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

Re: Vacations

[Alexander Potashev]

Hi David,

I wish you to have nice vacations!

Who is going to release and announce KDE Frameworks 5.64.0 next Saturday?

вс, 3 нояб. 2019 г. в 22:45, David Faure :
>
> I'm going to be away on vacations until Nov 20, so don't worry if you don't
> get patches reviewed during that time.
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>


-- 
Alexander Potashev

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:12:34 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D25123: [WIP] New yakuake logo/icon

[Nathaniel Graham]

ngraham added subscribers: hein, ngraham.
ngraham added a comment.


  My vote is for A. I love it. It looks like a pull-down terminal just like the 
parent icon, re-uses the `>_` iconography common to our terminal icons, but 
adds a flair that makes the > look like a Y, conjuring up the app's name. I 
think this is fantastic.
  
  Adding @hein to the reviewers list, as he's the former maintainer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake
Cc: ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, 
GB_2, michaelh, bruns

D25123: [WIP] New yakuake logo/icon

[Noah Davis]

ndavis added a comment.


  A or C for me.
  
  `A` looks more like how I imagine a "drop down terminal", but it's got a lot 
of margin below the bottom of it.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728707: Screenshot_20191103_135015.png 
  
  `C` looks more like a pull down projector screen, but that's not necessarily 
bad. It also doesn't quite reach the bottom.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728733: Screenshot_20191103_135310.png 
  
  #vdg ,  Should we allow some types of 
icons to be vertically off center? If not that, should we allow some icons to 
not reach all the way to the top and bottom margins? There are already some 
icons like that, but that doesn't necessarily mean we should want that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

kossebau added a subscriber: dfaure.
kossebau added a comment.


  @dfaure Hi. Any chance you  you can sneak in before you are away (enjoy :) ) 
to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all the KF modules 
in the next days? Otherwise would land this here with just the 
-DKF_DEPRECATED_WARNINGS_SINCE=0x06 for now, otherwise people do not see 
warnings in KF modules when they should.
  
  I sadly have no setup for easy mass removal of 
"-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all KF modules,otherwise I would 
have done that
  
  Cmp. also 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/096307.html

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 20:14:24 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

[Friedrich W. H. Kossebau]

Hi,

with KF 5.64 now branched and thus the new deprecation macros going to be 
released for the first time, now please make sure when in the future marking 
API as deprecated to use the correct current version, i.e. the one where the 
deprecation will be made public the first time.

So if pushing a commit which deprecates API, make sure the "x" is matching the 
upcoming version of KF where the deprecation will be released the first time:

#if KFOO_ENABLE_DEPRECATED_SINCE(5, x)
/**
 * @deprecated Since 5.x. Use bar(). // Sadly doxygen needs data duplicated
 */
KFOO_DEPRECATED_VERSION(5, x, "Use bar()")
void foo();
#endif

((In a perfect world this boilerplate/duplication would not be needed and 
tools would automate this for us, but for now we have to do it manually.))

Do _not_ use an older KF version where the API might already have been 
considered deprecated, but was forgotten to be marked. Use the upcoming KF 
release version only.


In the last weeks, since 5.63 was branched, while the new deprecation macros 
generated with ECMGenerateExportHeader were introduced you may have seen also 
lots of older versions being used. But that was fine due to the macros not yet 
been released and changes done to be historically correct, like also matching 
any already existing version info in the API dox by the @deprecated tag. 
Hopefully we have catched any existing KF API which has been considered 
deprecated before.

But now with KF 5.64 being branched and going to be officially released 
exposing the new deprecation macros and thus the options to control visibility 
of and warnings about deprecated KF API, people using KF libraries in their 
software will e.g. start to use the *_DISABLE_DEPRECATED_BEFORE_AND_AT macros, 
to protect themselves against usage of API deprecated the first time up to a 
certain version, for which they have checked their code builds fine against.
And we would thus ran chance to break their software builds if we now marked 
more API as being deprecated in previous versions in future KF releases. Not 
our mission :)

Cheers
Friedrich

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella updated this revision to Diff 69241.
nicolasfella added a comment.


  - Put into namespace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=69239=69241

BRANCH
  arcpatch-D24443

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarentry.cpp
  src/calendarentry.h
  src/calendarentry_p.h
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham added a comment.


  Like this maybe?
  
  F7730326: Screenshot_20191103_154347.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 03 Nov 2019 20:14:56 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(238/268)89%
(238/268)82%
(26169/32027)51%
(10429/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11866/12569)48%
(6229/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client95%
(72/76)95%
(72/76)81%
(6029/7457)59%
(1676/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7820/9345)64%
(2347/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D25107: Add install dir for systemd units

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fb275fb95d9c: Add install dir for systemd units (authored 
by davidedmundson).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25107?vs=69160=69238

REVISION DETAIL
  https://phabricator.kde.org/D25107

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake
  tests/KDEInstallDirsTest/var_list.cmake

To: davidedmundson, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Is that because I moved the target to the other cmake file? The generation 
process should be unchanged.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/35/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 03 Nov 2019 20:14:56 +
 Build duration:
2 hr 40 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)88%
(237/268)88%
(237/268)79%
(25154/32004)48%
(9930/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(41/43)95%
(41/43)88%
(11064/12567)44%
(5816/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client95%
(72/76)95%
(72/76)80%
(5949/7447)58%
(1657/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)82%
(7687/9334)62%
(2280/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D25084: Allow a Multiple instances to become Unique

[Tomaz Canabrava]

tcanabrava added a comment.


  Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid,
  this will fix your second point.
  About your first point, do you think it’s a problem?
  
  Just speculating, if an app opens as multiple and then another instance
  tries to open as unique, it should reuse the existing one or merge?
  
  I did not try to change the registered name as actually nothing happens
  when a second instance of an unique app opens, it silently closes - so in a
  way I did not registered an unique application as name - pid, I just passed
  the arguments to the currently opened ::multiple application, and quit.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D25084

To: tcanabrava, adridg, dfaure
Cc: dfaure, GB_2, davidedmundson, adridg, ngraham, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D24979: KRunner: port away from deprecated KF5 API

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Untested, but looks okay, besides the unneeded #f in the sources.

INLINE COMMENTS

> abstractrunner.cpp:327
>  
> +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) // Plasma::Package is defined with 
> this condition
>  Package AbstractRunner::package() const

This one should be removed.

We have defined

  add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00)
  add_definitions(-DPLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050500) # needed 
because we use Plasma::Package in the API

with this in the build of KRunner itselt PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) 
is always true, and people building KRunner do not have the option to change 
this.

This condition is only interesting in the header currently, as this is what 
then is used by 3rd-party building against KRunner and being allowed to set 
different visibility limits.

REPOSITORY
  R308 KRunner

BRANCH
  D24979

REVISION DETAIL
  https://phabricator.kde.org/D24979

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

[Nicolas Fella]

nicolasfella added a comment.


  This seems to break several Android builds
  https://binary-factory.kde.org/view/Android/job/Koko_android/36/console

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24979: KRunner: port away from deprecated KF5 API

[David Faure]

dfaure added a comment.


  Thanks for the detailed analysis. I'm ok with option A. Let's not complicate 
this by adding submodule granularity.
  
  I have submitted the removal of the "package" member variable separately, 
that one is obvious and almost unrelated.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D24979

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: D25084: Allow a Multiple instances to become Unique

[Tomaz Canabrava]

im Open to redo the patch but I don’t see the problems you guys see. The
only thing this patch does is to quit early if you trigger a unique
application *after* a multiple one has been spawned.

See:
Konsole (register as multiple)
Konsole —new-tab (register as single)

But instead of adding a tab to the old, multiple, instance - it opens a new
window instead.

I’ve tested with multiple single ones, and mixing singles with multiples So
I don’t understand why you say it would break anything.

Also, is there anything that I can do to fix this konsole bug I explained
any other way?

On Sun, 3 Nov 2019 at 11:01 David Faure  wrote:

> dfaure requested changes to this revision.
> dfaure added a comment.
> This revision now requires changes to proceed. View Revision
> 
>
> Same reservations as davidedmundson.
> Furthermore this would break talking to dbus-activated unique apps, too,
> since they wouldn't register with the expected service name.
> -2 from me.
>
> *REPOSITORY*
> R271 KDBusAddons
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D25084
>
> *To: *tcanabrava, adridg, dfaure
> *Cc: *dfaure, GB_2, davidedmundson, adridg, ngraham,
> kde-frameworks-devel, LeGast00n, michaelh, bruns
>

Re: D25084: Allow a Multiple instances to become Unique

[Tomaz Canabrava]

Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid,
this will fix your second point.
About your first point, do you think it’s a problem?

Just speculating, if an app opens as multiple and then another instance
tries to open as unique, it should reuse the existing one or merge?

I did not try to change the registered name as actually nothing happens
when a second instance of an unique app opens, it silently closes - so in a
way I did not registered an unique application as name - pid, I just passed
the arguments to the currently opened ::multiple application, and quit.


On Sun, 3 Nov 2019 at 15:07 David Faure  wrote:

> dfaure added a comment. View Revision 
>
> If I read the patch correctly, then running a multi-instance app (
> konsole-1234) and then running it as unique will lead to konsole-1234
> instead of the expected konsole.
> Worse, if there was a completely unrelated konsolesettings application
> running, then konsole would try to register as konsolesettings instead of
> konsole.
> In other words, at least this should be startsWith(d->serviceName + '-'),
> right?
>
> *REPOSITORY*
> R271 KDBusAddons
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D25084
>
> *To: *tcanabrava, adridg, dfaure
> *Cc: *dfaure, GB_2, davidedmundson, adridg, ngraham,
> kde-frameworks-devel, LeGast00n, michaelh, bruns
>

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  Here's another idea: F7730258: Screenshot_20191103_173337.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella updated this revision to Diff 69239.
nicolasfella marked 9 inline comments as done.
nicolasfella added a comment.


  - Drop property
  - Use QVector
  - Use unique_ptr
  - Make unique_ptr const
  - Comments
  - Make calendars pure virtual
  - ref

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=67385=69239

BRANCH
  arcpatch-D24443

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarentry.cpp
  src/calendarentry.h
  src/calendarentry_p.h
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> dvratil wrote in calendarentry.h:57
> I would move `sync()` from here to be a virtual method on the plugin - 
> `sync(const CalendarEntry::Ptr &)`. The implementations would reimplement it 
> to handle sync, which feels cleaner than having to connect to 
> `syncRequested()` signal on each calendar that the plugin owns, and it 
> decouples data (calendar) from logic (plugin).

I decided to make it a virtual member of CalendarEntry because that simplifies 
the implementation in calindori. This way it's enough to keep track of the 
entries, otherwise I'd need to keep track of the plugins too. Also this allows 
for more fine-grained sync, interesting for large numbers of calendars that are 
expensive to sync

> dvratil wrote in calendarplugin.h:39
> Unused?

My idea was to be able to add a d-ptr later if needed without breaking ABI

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

D24979: KRunner: port away from deprecated KF5 API

[David Faure]

dfaure updated this revision to Diff 69242.
dfaure added a comment.


  rebase, add PLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050500

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24979?vs=68815=69242

BRANCH
  D24979

REVISION DETAIL
  https://phabricator.kde.org/D24979

AFFECTED FILES
  CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25084: Allow a Multiple instances to become Unique

[David Faure]

dfaure added a comment.


  If I read the patch correctly, then running a multi-instance app 
(`konsole-1234`) and then running it as unique will lead to `konsole-1234` 
instead of the expected `konsole`.
  Worse, if there was a completely unrelated `konsolesettings` application 
running, then konsole would try to register as `konsolesettings` instead of 
`konsole`.
  In other words, at least this should be `startsWith(d->serviceName + '-')`, 
right?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D25084

To: tcanabrava, adridg, dfaure
Cc: dfaure, GB_2, davidedmundson, adridg, ngraham, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  I think it needs to be a little more Breezy. Here are 2 of my attempts with 
the 16px version: F7730187: Screenshot_20191103_172328.png 
 F7730173: Screenshot_20191103_172121.png 
 F7730179: color-picker.svg 

  
  In order to make the lines crisper at small sizes: used the technique 
described here: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines
  
  For the 1st attempt, I tried to make it more like your version. The round 
bubble at the end was tricky. If you want me to explain exactly how I did it, I 
can, but it's rather lengthy. There might be a faster way that I haven't 
discovered.
  
  For the 2nd attempt, I tried to make it more like what I usually see when I 
see eyedroppers IRL. I just made a simple 3x3 circle, put it in the top right, 
cut it in half from top left to bottom right and drew a diagonal box from the 
ends of the semicircle to the main body of the shape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham added a comment.


  I dunno, the alternative you've produced looks has a really chunky and 
unattractive tip to me, but I like some of the other elements. I could maybe 
square off the little protruding wings on the side though, and make the 
squeezey bit on the top part more straight. I also like the liquid level inside 
in yours.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25084: Allow a Multiple instances to become Unique

[Tomaz Canabrava]

tcanabrava added a comment.


  im Open to redo the patch but I don’t see the problems you guys see. The
  only thing this patch does is to quit early if you trigger a unique
  application *after* a multiple one has been spawned.
  
  See:
  Konsole (register as multiple)
  Konsole —new-tab (register as single)
  
  But instead of adding a tab to the old, multiple, instance - it opens a new
  window instead.
  
  I’ve tested with multiple single ones, and mixing singles with multiples So
  I don’t understand why you say it would break anything.
  
  Also, is there anything that I can do to fix this konsole bug I explained
  any other way?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D25084

To: tcanabrava, adridg, dfaure
Cc: dfaure, GB_2, davidedmundson, adridg, ngraham, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis added a comment.


  The chunky look works well at 16px, but I can see it sticking out at larger 
sizes.
  
  These ones have pointier tips:
  
  1x F7730340: Screenshot_20191103_174917.png 
 4x F7730343: 
Screenshot_20191103_175058.png 
  
  partially filled: F7730357: Screenshot_20191103_175409.png 

  
  F7730361: Screenshot_20191103_175458.png 

  
  In D25132#558307 , @ngraham wrote:
  
  > Like this maybe?
  >
  > F7730326: Screenshot_20191103_154347.png 

  
  
  Can you show it at 16px and 4x 16px?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25123: [WIP] New yakuake logo/icon

[Mariusz Glebocki]

mglb added a comment.


  In D25123#558205 , @ndavis wrote:
  
  > I tried seeing how it would look extended down to the bottom margin: 
F7728707: Screenshot_20191103_135015.png 
  
  
  Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  I agree with vertical alignment - I'll fix it.
  
  In D25123#558205 , @ndavis wrote:
  
  > If not that, should we allow some icons to not reach all the way to the top 
and bottom margins? There are already some icons like that, but that doesn't 
necessarily mean we should want that.
  
  
  Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  The icon C is 48px wide (44px when counting only the screen), so 36px (38px 
with "handle" on the bottom) height makes its sizes visually similar to 40x40px 
square icons.
  
  The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 170 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/170/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 04 Nov 2019 04:17:57 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25123: [WIP] New yakuake logo/icon

[Noah Davis]

ndavis added a comment.


  In D25123#558353 , @mglb wrote:
  
  > Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  
  
  I agree, the modified `A` didn't turn out that well.
  
  > Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  >  The icon C is 48px wide (44px when counting only the screen), so 36px 
(38px with "handle" on the bottom) height makes its sizes visually similar to 
40x40px square icons.
  > 
  > The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.
  
  I'm aware of that. I know Material Design uses different sizes for circles, 
squares and rectangles for that reason. Unfortunately, switching to that system 
means we would need to change many icons. I believe the reason why we use the 
system we use is because of horizontal text alignment, but I think that matters 
more for monochrome icons than color icons. On the other hand, nothing actually 
lines up with text in a way that stands out as lining up particularly well 
whether you choose 10, 11 or 12pt Noto Sans.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25122: embedd trigrams.map into shared library

[Christoph Cullmann]

cullmann planned changes to this revision.
cullmann added a comment.


  Ok, I see.
  For cross-compiling the trigrams were never generated...
  I don't think this is a good idea, but I can guard the resource creation with 
the same code.
  
  Volker: You are more familiar with the Android stuff, how can we fix that 
properly? Perhaps like for syntax-highlighting?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

[Christoph Cullmann]

cullmann added a comment.


  Fix see 
https://commits.kde.org/sonnet/be0414de6b921a1b926ea5e6c75ea3df02240379

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

[Christoph Cullmann]

cullmann added a comment.


  I re-scheduled the build, seems to work for me now.
  
  @vkrause : have you some solution to run the trigrams stuff for cross 
compiles, too?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns