D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka added a comment.


  In D28470#641230 , @davidre wrote:
  
  > In D28470#640468 , @cblack wrote:
  >
  > > Splitting into multiple classes seems like a good idea, but "strategy"? 
Seems like an odd choice of name to me.
  >
  >
  > I had assumed it's because of 
https://en.m.wikipedia.org/wiki/Strategy_pattern
  
  
  Yeah, I totally agree, it is really confusing now. I'm bad at creating class 
names :)
  I wanted to extract source handling (logic, internal state) to separate 
classes. "Handler" is overused, maybe something like this:
  IconItemSource (or AbstractIconItemSource, or AbstractSource), then:
  QImageSource (or QImageIconItemSource)
  QIconSource (or QIconIconItemSource)
  SvgSource (or SvgIconItemSource)
  What do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24443: Add a plugin system

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> calendarentry.cpp:36
> +
> +CalendarEntry::~CalendarEntry()
> +{

` = default` (instead of empty body)

> calendarentry.cpp:57
> +{
> +return ReadWrite;
> +}

Should that be `d->type`? How can implementations change it? Will 
implementation have to access `calendarentry_p.h`?

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka updated this revision to Diff 79283.
kmaterka added a comment.


  Change class name: *Strategy -> *Source

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28470?vs=79281=79283

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

[Méven Car]

meven abandoned this revision.
meven added a comment.


  In favor of D28555 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25079

To: meven, dfaure, #frameworks, davidedmundson
Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Changes :
  
  - use sendfile when copying file bigger than 2 GB
  - copy 512 kB instead of previously 32 kB for each sendfile copying iteration
  
  This effectively:
  1/ increase the copying speed, since the filesystem is asked to copy more at 
once, it lets it reach higher speed,
  2/ reduce the overhead of `processedSize` dbus progress notification in each 
iteration since it is called less often, adding some more speed.
  
  CCBUG: 342056
  CCBUG: 402276

TEST PLAN
  Copying large files or folders with medium sized files (for instance photos) 
is noticebly faster.

REPOSITORY
  R241 KIO

BRANCH
  sendfile-opt

REVISION DETAIL
  https://phabricator.kde.org/D28555

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

[Méven Car]

meven added a revision: D28555: File ioslave : use Better setting for sendfile 
syscall.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven
Cc: ahartmetz, broulik, ognarb, #dolphin, #frameworks, meven, dfaure, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven added a task: T11627: Improve KIO asynchronicity.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[David Hurka]

davidhurka added a comment.


  Cuttlefish (Ubuntu release)?
  
  So that means all icons should be changed from Highlight to ButtonFocus? That 
would also affect colorful icons. Some of them have Highlight and ButtonFocus 
in the stylesheet, fortunately with the same color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[David Faure]

dfaure added a comment.


  any idea what buff_src.st_size < 0x7FFF was for?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[Noah Davis]

ndavis added a comment.


  In D28553#641271 , @davidhurka 
wrote:
  
  > Cuttlefish (Ubuntu release)?
  >
  > So that means all icons should be changed from Highlight to ButtonFocus? 
That would also affect colorful icons. Some of them have Highlight and 
ButtonFocus in the stylesheet, fortunately with the same color.
  
  
  Don't worry about it. I'll do a pass once KF5.69 is released.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Kai Uwe Broulik]

broulik added a comment.


  >   reduce the overhead of processedSize dbus progress notification in each 
iteration since it is called less often, adding some more speed.
  
  From what I recall in copy job the processed size in emitted by a timer and 
not every time a chunk got processed

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[David Hurka]

davidhurka abandoned this revision.
davidhurka added a comment.


  Ok, then I’ll let you do it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This fixes the 3 icons with blue elements, which I recently modified. I used 
ButtonFocus, but it should be Highlight.

REPOSITORY
  R266 Breeze Icons

BRANCH
  rename-buttonfocus-highlight

REVISION DETAIL
  https://phabricator.kde.org/D28553

AFFECTED FILES
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/insert-page-break.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/filename-title-amarok.svg
  icons/actions/22/insert-page-break.svg

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28421: Add static method to check start condition

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> hchain wrote in kautostart.h:289
> I think you added it to the wrong method ;)

Fixed with 79fea5fc4043be72f3addf8980d4d78ef04530ff 


REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/7/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 04 Apr 2020 11:26:20 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/305)60%
(110/184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)80%
(199/250)60%
(100/166)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 300 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/300/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 04 Apr 2020 11:26:20 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/305)60%
(110/184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)80%
(199/250)60%
(100/166)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 76 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/76/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 04 Apr 2020 11:26:19 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 04 Apr 2020 11:26:20 +
 Build duration:
2 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D28203: Move corner fold to top right in 24 icons

[Noah Davis]

ndavis added a comment.


  Fixed it. I missed a few more symlinks that weren't relative in the review. I 
couldn't test it locally during review because `arc` can't download patches 
that convert a file into a symlink or vice versa.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi abandoned this revision.
trmdi added a comment.


  In D27951#641173 , @meven wrote:
  
  > In D27951#639386 , @trmdi wrote:
  >
  > > In D27951#639350 , @meven 
wrote:
  > >
  > > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect 
ioslave, including the stat call made in `KIO::StatJob`.
  > > >  It is in the kdeconnect code base, the issue you point to is there.
  > >
  > >
  > > Thanks, got it. Then could we simply use KMountPoint instead of 
UDS_Device_ID ? KMountPoint seems more reliable.
  >
  >
  > But KMountPoint induces more cost (it makes a syscall and a bunch of 
parsing).
  >  So instead I would recommend fixing the issue in kdeconnect (and 
potentially other ioslave) as it will fix things here and elsewhere potentially 
too.
  >
  > Also `local = url.isLocalFile` should return false for kdeconnect in the 
first place.
  >  So I belive you can avoid using KMountPoint at all and use only stat.
  
  
  No, kde connect files has local urls.
  Fixing every ioslave is too difficult. 
  So I should drop this idea.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham

D28203: Move corner fold to top right in 24 icons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Yay for quick fixing, thanks (in name of KF release interest group) :)
  
  Do not forget to set this review request as Closed again if you are done here 
now (cannot tell myself).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Good idea

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 04 Apr 2020 09:56:13 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 178 lines...][2020-04-04T09:56:33.033Z] [2020-04-04T09:56:33.033Z]  * ECM (required version >= 5.68.0), Extra CMake Modules., [2020-04-04T09:56:33.033Z]  * Qt5Core[2020-04-04T09:56:33.033Z]  * Qt5Test[2020-04-04T09:56:33.033Z]  * Qt5 (required version >= 5.12.0)[2020-04-04T09:56:33.033Z] [2020-04-04T09:56:33.033Z] -- Configuring done[2020-04-04T09:56:33.294Z] -- Generating done[2020-04-04T09:56:33.294Z] CMake Warning:[2020-04-04T09:56:33.294Z]   Manually-specified variables were not used by the project:[2020-04-04T09:56:33.294Z] [2020-04-04T09:56:33.294Z] BUILD_QCH[2020-04-04T09:56:33.294Z] [2020-04-04T09:56:33.294Z] [2020-04-04T09:56:33.294Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-04-04T09:56:34.000Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-04-04T09:56:34.000Z] Scanning dependencies of target qrcAlias_autogen[2020-04-04T09:56:34.000Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-04-04T09:56:34.000Z] Scanning dependencies of target breeze-generate-24px-versions[2020-04-04T09:56:34.000Z] Scanning dependencies of target scalable_autogen[2020-04-04T09:56:34.000Z] Scanning dependencies of target dupe_autogen[2020-04-04T09:56:34.000Z] Scanning dependencies of target newline_autogen[2020-04-04T09:56:34.000Z] [  7%] Generating 24px icons dark[2020-04-04T09:56:34.000Z] [  7%] Automatic MOC for target qrcAlias[2020-04-04T09:56:34.000Z] [ 11%] Automatic MOC for target dupe[2020-04-04T09:56:34.000Z] [ 15%] Automatic MOC for target scalable[2020-04-04T09:56:34.000Z] [ 19%] Generating 24px icons[2020-04-04T09:56:34.000Z] [ 23%] Automatic MOC for target newline[2020-04-04T09:56:34.000Z] Using POSIX-style sed arguments[2020-04-04T09:56:34.000Z] Using POSIX-style sed arguments[2020-04-04T09:56:34.259Z] [ 23%] Built target qrcAlias_autogen[2020-04-04T09:56:34.259Z] Scanning dependencies of target symlink_autogen[2020-04-04T09:56:34.259Z] [ 26%] Automatic MOC for target symlink[2020-04-04T09:56:34.841Z] [ 26%] Built target newline_autogen[2020-04-04T09:56:34.841Z] Scanning dependencies of target breeze-icons-mkdir[2020-04-04T09:56:34.841Z] [ 26%] Built target scalable_autogen[2020-04-04T09:56:34.841Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-04-04T09:56:34.841Z] [ 26%] Built target breeze-icons-mkdir[2020-04-04T09:56:34.841Z] [ 26%] Built target dupe_autogen[2020-04-04T09:56:34.841Z] [ 26%] Built target breeze-icons-dark-mkdir[2020-04-04T09:56:34.841Z] [ 26%] Built target symlink_autogen[2020-04-04T09:56:34.841Z] Scanning dependencies of target qrcAlias[2020-04-04T09:56:34.841Z] [ 30%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-04-04T09:56:34.841Z] Scanning dependencies of target scalable[2020-04-04T09:56:34.841Z] [ 34%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-04-04T09:56:34.841Z] [ 38%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-04-04T09:56:34.841Z] Scanning dependencies of target dupe[2020-04-04T09:56:34.841Z] [ 42%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-04-04T09:56:34.841Z] Scanning dependencies of target newline[2020-04-04T09:56:34.841Z] [ 46%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-04-04T09:56:34.841Z] [ 50%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-04-04T09:56:34.841Z] [ 53%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-04-04T09:56:34.841Z] [ 57%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-04-04T09:56:36.242Z] [ 61%] Linking CXX executable bin/qrcAlias[2020-04-04T09:56:36.503Z] [ 61%] Built target qrcAlias[2020-04-04T09:56:36.503Z] Scanning dependencies of target symlink[2020-04-04T09:56:36.503Z] [ 65%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-04-04T09:56:36.503Z] [ 69%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-04-04T09:56:36.503Z] /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.14/autotests/scalabletest.cpp:76:26: warning: result of comparison of constant -1 with _expression_ of type 'KIconLoaderDummy::Context' is always true [-Wtautological-constant-out-of-range-compare][2020-04-04T09:56:36.503Z] QVERIFY2(context 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/6/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 04 Apr 2020 09:56:13 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 184 lines...][2020-04-04T09:57:04.599Z] EXECUTOR_NUMBER   = '0'[2020-04-04T09:57:04.599Z] CVS_RSH   = 'ssh'[2020-04-04T09:57:04.599Z] LIBGL_DEBUG   = 'quiet'[2020-04-04T09:57:04.599Z] STAGE_NAME= 'Configuring Build'[2020-04-04T09:57:04.599Z] NODE_LABELS   = 'Docker Swarm-e4c54d274ff2 SUSEQt5.14'[2020-04-04T09:57:04.599Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-04-04T09:57:04.599Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-04-04T09:57:04.599Z] PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-04-04T09:57:04.599Z] PROFILEREAD   = 'true'[2020-04-04T09:57:04.600Z] MAIL  = '/var/spool/mail/jenkins'[2020-04-04T09:57:04.600Z] HOSTTYPE  = 'x86_64'[2020-04-04T09:57:04.600Z] BUILD_ID  = '6'[2020-04-04T09:57:04.600Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-04-04T09:57:04.600Z] OLDPWD= '/home/jenkins'[2020-04-04T09:57:04.600Z] LC_CTYPE  = 'C.UTF-8'[2020-04-04T09:57:04.600Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-04-04T09:57:04.600Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-04-04T09:57:04.600Z] QT_SELECT = 'qt5'[2020-04-04T09:57:04.600Z] LANG  = 'en_US.UTF-8'[2020-04-04T09:57:04.600Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-04-04T09:57:04.600Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-04-04T09:57:04.600Z] [2020-04-04T09:57:04.600Z] [2020-04-04T09:57:04.600Z] == Commencing Configuration:[2020-04-04T09:57:04.600Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14"[2020-04-04T09:57:04.875Z] -- The C compiler identification is GNU 9.2.1[2020-04-04T09:57:04.875Z] -- The CXX compiler identification is GNU 9.2.1[2020-04-04T09:57:04.875Z] -- Check for working C compiler: /usr/bin/cc[2020-04-04T09:57:05.139Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-04-04T09:57:05.139Z] -- Detecting C compiler ABI info[2020-04-04T09:57:05.139Z] -- Detecting C compiler ABI info - done[2020-04-04T09:57:05.404Z] -- Detecting C compile features[2020-04-04T09:57:05.405Z] -- Detecting C compile features - done[2020-04-04T09:57:05.405Z] -- Check for working CXX compiler: /usr/bin/c++[2020-04-04T09:57:05.405Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-04-04T09:57:05.405Z] -- Detecting CXX compiler ABI info[2020-04-04T09:57:05.676Z] -- Detecting CXX compiler ABI info - done[2020-04-04T09:57:05.676Z] -- Detecting CXX compile features[2020-04-04T09:57:05.676Z] -- Detecting CXX compile features - done[2020-04-04T09:57:05.676Z] -- [2020-04-04T09:57:05.676Z] [2020-04-04T09:57:05.676Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.14/build/prefix.sh to set the environment for BreezeIcons.[2020-04-04T09:57:05.676Z] -- Looking for __GLIBC__[2020-04-04T09:57:05.937Z] -- Looking for __GLIBC__ - found[2020-04-04T09:57:05.937Z] -- Performing Test _OFFT_IS_64BIT[2020-04-04T09:57:06.200Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-04-04T09:57:06.200Z] -- Performing Test HAVE_DATE_TIME[2020-04-04T09:57:06.463Z] -- Performing Test HAVE_DATE_TIME - Success[2020-04-04T09:57:06.737Z] -- The following features have been enabled:[2020-04-04T09:57:06.737Z] [2020-04-04T09:57:06.737Z]  * 24x24 generation, 'bash' is required to generate 24x24 variants[2020-04-04T09:57:06.737Z] [2020-04-04T09:57:06.737Z] -- The following REQUIRED packages have been found:[2020-04-04T09:57:06.737Z] [2020-04-04T09:57:06.737Z]  * ECM (required version >= 5.68.0), Extra CMake Modules., [2020-04-04T09:57:06.737Z]  * Qt5Core[2020-04-04T09:57:06.737Z]  * Qt5Test[2020-04-04T09:57:06.737Z]  * Qt5 (required version >= 5.12.0)[2020-04-04T09:57:06.737Z] [2020-04-04T09:57:06.737Z] -- Configuring done[2020-04-04T09:57:06.996Z] -- Generating done[2020-04-04T09:57:06.996Z] CMake Warning:[2020-04-04T09:57:06.996Z]   Manually-specified variables were not used by the project:[2020-04-04T09:57:06.996Z] [2020-04-04T09:57:06.996Z] BUILD_QCH[2020-04-04T09:57:06.996Z] [2020-04-04T09:57:06.996Z] [2020-04-04T09:57:06.996Z] -- Build files have been written to: 

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:60d7cfec0595: [CommandLauncherJob] Also mention 
setDesktopName in constructor (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28552?vs=79271=79274

REVISION DETAIL
  https://phabricator.kde.org/D28552

AFFECTED FILES
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 299 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/299/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 04 Apr 2020 09:56:13 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 184 lines...][2020-04-04T09:57:05.966Z] EXECUTOR_NUMBER   = '0'[2020-04-04T09:57:05.966Z] CVS_RSH   = 'ssh'[2020-04-04T09:57:05.966Z] LIBGL_DEBUG   = 'quiet'[2020-04-04T09:57:05.966Z] STAGE_NAME= 'Configuring Build'[2020-04-04T09:57:05.966Z] NODE_LABELS   = 'Docker Swarm-bfea521eb0fc SUSEQt5.12'[2020-04-04T09:57:05.966Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-04-04T09:57:05.966Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-04-04T09:57:05.966Z] PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-04-04T09:57:05.966Z] PROFILEREAD   = 'true'[2020-04-04T09:57:05.966Z] MAIL  = '/var/spool/mail/jenkins'[2020-04-04T09:57:05.966Z] HOSTTYPE  = 'x86_64'[2020-04-04T09:57:05.966Z] BUILD_ID  = '299'[2020-04-04T09:57:05.966Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-04-04T09:57:05.966Z] OLDPWD= '/home/jenkins'[2020-04-04T09:57:05.966Z] LC_CTYPE  = 'C.UTF-8'[2020-04-04T09:57:05.966Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-04-04T09:57:05.966Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-04-04T09:57:05.966Z] QT_SELECT = 'qt5'[2020-04-04T09:57:05.966Z] LANG  = 'en_US.UTF-8'[2020-04-04T09:57:05.966Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-04-04T09:57:05.966Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-04-04T09:57:05.966Z] [2020-04-04T09:57:05.966Z] [2020-04-04T09:57:05.966Z] == Commencing Configuration:[2020-04-04T09:57:05.966Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12"[2020-04-04T09:57:06.230Z] -- The C compiler identification is GNU 9.2.1[2020-04-04T09:57:06.230Z] -- The CXX compiler identification is GNU 9.2.1[2020-04-04T09:57:06.230Z] -- Check for working C compiler: /usr/bin/cc[2020-04-04T09:57:06.506Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-04-04T09:57:06.506Z] -- Detecting C compiler ABI info[2020-04-04T09:57:06.774Z] -- Detecting C compiler ABI info - done[2020-04-04T09:57:06.774Z] -- Detecting C compile features[2020-04-04T09:57:06.774Z] -- Detecting C compile features - done[2020-04-04T09:57:06.774Z] -- Check for working CXX compiler: /usr/bin/c++[2020-04-04T09:57:06.774Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-04-04T09:57:06.774Z] -- Detecting CXX compiler ABI info[2020-04-04T09:57:07.063Z] -- Detecting CXX compiler ABI info - done[2020-04-04T09:57:07.063Z] -- Detecting CXX compile features[2020-04-04T09:57:07.063Z] -- Detecting CXX compile features - done[2020-04-04T09:57:07.063Z] -- [2020-04-04T09:57:07.063Z] [2020-04-04T09:57:07.063Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for BreezeIcons.[2020-04-04T09:57:07.063Z] -- Looking for __GLIBC__[2020-04-04T09:57:07.334Z] -- Looking for __GLIBC__ - found[2020-04-04T09:57:07.334Z] -- Performing Test _OFFT_IS_64BIT[2020-04-04T09:57:07.599Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-04-04T09:57:07.599Z] -- Performing Test HAVE_DATE_TIME[2020-04-04T09:57:07.599Z] -- Performing Test HAVE_DATE_TIME - Success[2020-04-04T09:57:08.168Z] -- The following features have been enabled:[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z]  * 24x24 generation, 'bash' is required to generate 24x24 variants[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z] -- The following REQUIRED packages have been found:[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z]  * ECM (required version >= 5.68.0), Extra CMake Modules., [2020-04-04T09:57:08.168Z]  * Qt5Core[2020-04-04T09:57:08.168Z]  * Qt5Test[2020-04-04T09:57:08.168Z]  * Qt5 (required version >= 5.12.0)[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z] -- Configuring done[2020-04-04T09:57:08.168Z] -- Generating done[2020-04-04T09:57:08.168Z] CMake Warning:[2020-04-04T09:57:08.168Z]   Manually-specified variables were not used by the project:[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z] BUILD_QCH[2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z] [2020-04-04T09:57:08.168Z] -- Build files have been written to: 

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 75 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/75/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 04 Apr 2020 09:56:27 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 199 lines...][2020-04-04T09:57:34.230Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-04-04T09:57:34.230Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-04-04T09:57:34.230Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\breeze-icons;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-04-04T09:57:34.230Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\breeze-icons\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-04-04T09:57:34.230Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-04-04T09:57:34.230Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-04-04T09:57:34.230Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-04-04T09:57:34.230Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\breeze-icons\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-04-04T09:57:34.230Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-04-04T09:57:34.230Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-04-04T09:57:34.230Z] [2020-04-04T09:57:34.230Z] [2020-04-04T09:57:34.230Z] == Commencing Configuration:[2020-04-04T09:57:34.230Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/breeze-icons/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-04-04T09:57:34.492Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-04-04T09:57:34.753Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-04-04T09:57:34.753Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-04-04T09:57:35.693Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-04-04T09:57:35.693Z] -- Detecting C compiler ABI info[2020-04-04T09:57:36.264Z] -- Detecting C compiler ABI info - done[2020-04-04T09:57:36.264Z] -- Detecting C compile features[2020-04-04T09:57:36.843Z] -- Detecting C compile features - done[2020-04-04T09:57:36.843Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-04-04T09:57:37.414Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-04-04T09:57:37.414Z] -- Detecting CXX compiler ABI info[2020-04-04T09:57:37.983Z] -- Detecting CXX compiler ABI info - done[2020-04-04T09:57:37.983Z] -- Detecting CXX compile features[2020-04-04T09:57:38.554Z] -- Detecting CXX compile features - done[2020-04-04T09:57:38.554Z] -- [2020-04-04T09:57:38.554Z] [2020-04-04T09:57:38.554Z] Installing in C:/CI/Software Installs/breeze-icons. Run C:/CI/Job Build/build/prefix.sh to set the environment for BreezeIcons.[2020-04-04T09:57:38.554Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-04-04T09:57:38.554Z] -- Looking for __GLIBC__[2020-04-04T09:57:38.814Z] -- Looking for __GLIBC__ - not found[2020-04-04T09:57:38.814Z] -- The following REQUIRED packages have been found:[2020-04-04T09:57:38.814Z] [2020-04-04T09:57:38.814Z]  * ECM (required version >= 5.68.0), Extra CMake Modules., [2020-04-04T09:57:38.814Z]  * Qt5Core[2020-04-04T09:57:38.814Z]  * Qt5Test[2020-04-04T09:57:38.814Z]  * Qt5 (required version >= 5.12.0)[2020-04-04T09:57:38.814Z] [2020-04-04T09:57:38.814Z] -- Configuring done[2020-04-04T09:57:39.075Z] -- Generating done[2020-04-04T09:57:39.075Z] CMake Warning:[2020-04-04T09:57:39.075Z]   Manually-specified variables were not used by the project:[2020-04-04T09:57:39.075Z] [2020-04-04T09:57:39.075Z] BUILD_QCH[2020-04-04T09:57:39.075Z] [2020-04-04T09:57:39.075Z] [2020-04-04T09:57:39.075Z] -- Build files have been written to: C:/CI/Job Build/build[Pipeline] 

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[David Redondo]

davidre added a comment.


  In D28470#640468 , @cblack wrote:
  
  > Splitting into multiple classes seems like a good idea, but "strategy"? 
Seems like an odd choice of name to me.
  
  
  I had assumed it's because of https://en.m.wikipedia.org/wiki/Strategy_pattern

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[Noah Davis]

ndavis added a comment.


  Actually, I just tested the icons in Cuttlefish and apparently ButtonFocus 
works now, so it's preferred to Highlight. Sorry to give you the run around.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5f2be012c27d: [CommandLauncherJob] Add constructor taking 
an executable and argument list (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28515?vs=79267=79270

REVISION DETAIL
  https://phabricator.kde.org/D28515

AFFECTED FILES
  autotests/commandlauncherjobtest.cpp
  autotests/commandlauncherjobtest.h
  src/gui/commandlauncherjob.cpp
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27983: Make find-location show a magnifier on a map, to be different to mark-location

[David Hurka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:aff4a3e23d92: Make find-location show a magnifier on a 
map, to be different to mark-location (authored by davidhurka).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27983?vs=77419=79269

REVISION DETAIL
  https://phabricator.kde.org/D27983

AFFECTED FILES
  icons-dark/actions/16/find-location.svg
  icons-dark/actions/22/find-location.svg
  icons-dark/actions/symbolic/find-location-symbolic.svg
  icons/actions/16/find-location.svg
  icons/actions/22/find-location.svg
  icons/actions/symbolic/find-location-symbolic.svg

To: davidhurka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka updated this revision to Diff 79272.
davidhurka added a comment.


  Rebase on an initial commit which points to D28203 
, not D28204 
.
  
  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons
  - Fix symlinks: make relative
  - Give **/acrobat.svg its fixed color back

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78484=79272

BRANCH
  temp-2

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:1510
> +{
> +// this test doesn't make sense on the CI as it's an LXC container with 
> one partition
> +if (!otherTmpDirIsOnSamePartition()) {

This should only apply to the `QVERIFY(device != otherDevice);`

> bruns wrote in jobtest.cpp:1524
> Its 'statDetails**With**Inode' not 'statDetailsInode**Only**'

i.e. the test should be renamed now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored 
by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28540?vs=79226=79290

REVISION DETAIL
  https://phabricator.kde.org/D28540

AFFECTED FILES
  src/qtquick/qml/DownloadItemsSheet.qml

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28535: [KIO-MTP] Fix null pointer dereference

[Anthony Fieroni]

anthonyfieroni added a comment.


  Ok that's look good to me. We can move that code in constructor just before 
loop for storages, then use m_mtpdevice instead of raw device, but it looks 
like removed code is just a noise and it shouldn't present at all.
  
  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6327a9f05eb2: FileWidgets: Ignore Return events from 
KDirOperator (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27455?vs=79039=79265

REVISION DETAIL
  https://phabricator.kde.org/D27455

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: meven, dfaure, ngraham, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik updated this revision to Diff 79267.
broulik added a comment.
This revision is now accepted and ready to land.


  - Add test for binary in path with space

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28515?vs=79189=79267

REVISION DETAIL
  https://phabricator.kde.org/D28515

AFFECTED FILES
  autotests/commandlauncherjobtest.cpp
  autotests/commandlauncherjobtest.h
  src/gui/commandlauncherjob.cpp
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Méven Car]

meven accepted this revision.
meven added a comment.


  Seems good to me

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28520: Fix lifetime of slot in KIO-MTP

[Méven Car]

meven accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

T11627: Improve KIO asynchronicity

[Méven Car]

meven added a comment.


  I have tried using 
https://www.kdab.com/uiwatchdog-a-keepalive-monitor-for-the-gui-thread/ to see 
what makes the system stutter during file operation, it seems it is due to 
Breeze processing with styling loading, and QXcb* events.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven
Cc: ahartmetz, broulik, ognarb, #dolphin, #frameworks, meven, dfaure, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/33/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 04 Apr 2020 09:43:38 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in kfileplacesitem.cpp:244
> What if it isn't mounted?

`if (m_access)` checks this

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven updated this revision to Diff 79277.
meven marked 2 inline comments as done.
meven added a comment.


  Clean superfluous variable

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26113?vs=71861=79277

BRANCH
  arcpatch-D26113

REVISION DETAIL
  https://phabricator.kde.org/D26113

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> meven wrote in jobtest.cpp:1524
> add `QCOMPARE(entry.count(), 2);`

Its 'statDetails**With**Inode' not 'statDetailsInode**Only**'

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28421: Add static method to check start condition

[David Edmundson]

davidedmundson added a comment.


  That was embarrassing, I shouldn't try and rush. Sorry. Thanks for cleaning 
up after me.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28470: WIP: IconItem: Refactor source handling for different types

[Konrad Materka]

kmaterka marked 2 inline comments as done.
kmaterka added inline comments.

INLINE COMMENTS

> cblack wrote in iconitem.cpp:58
> Is this class necessary? I feel like this class's behaviour should be what 
> its parent does without a child implementation.

I wanted `IconItemStrategy` to be just an abstract base class, so that to have 
no strategy selected one needs to select null strategy explicitly.

> cblack wrote in iconitem.cpp:80
> Seems unused.

removed unused variable from NullStrategy

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28421: Add static method to check start condition

[Henri Chain]

hchain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kautostart.h:289
> Added.
> https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1

I think you added it to the wrong method ;)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/32/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 04 Apr 2020 09:01:52 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28552

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  I just want to keep as much checks as possible

INLINE COMMENTS

> jobtest.cpp:1524
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_DEVICE_ID));
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_INODE));
> +

add `QCOMPARE(entry.count(), 2);`

> jobtest.cpp:1535
> +QVERIFY(otherEntry.contains(KIO::UDSEntry::UDS_DEVICE_ID));
> +QVERIFY(otherEntry.contains(KIO::UDSEntry::UDS_INODE));
> +

add `QCOMPARE(otherEntry.count(), 2);`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D28203: Move corner fold to top right in 24 icons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Hi. Seems this broke the build somehow, please check: 
https://build.kde.org/view/Failing/job/Frameworks/job/breeze-icons/
  
  Remember this is KF 5.69 branching WE, so needs fixing to not block the 
release. Do not shoot the messenger :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28470: WIP: IconItem: Refactor source handling for different types

[Konrad Materka]

kmaterka updated this revision to Diff 79281.
kmaterka marked an inline comment as done.
kmaterka added a comment.


  be consistent with old implementation

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28470?vs=79279=79281

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka retitled this revision from "WIP: IconItem: Refactor source handling 
for different types" to "[PlasmaCore.IconItem] Refactor source handling for 
different types".
kmaterka edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella planned changes to this revision.
nicolasfella added a comment.


  - single level hierarchy with a calendargroup object
  - calendar entry folded into calendar
  - calendar::open

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Méven Car]

meven added a comment.


  In D27951#639386 , @trmdi wrote:
  
  > In D27951#639350 , @meven wrote:
  >
  > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect 
ioslave, including the stat call made in `KIO::StatJob`.
  > >  It is in the kdeconnect code base, the issue you point to is there.
  >
  >
  > Thanks, got it. Then could we simply use KMountPoint instead of 
UDS_Device_ID ? KMountPoint seems more reliable.
  
  
  But KMountPoint induces more cost (it makes a syscall and a bunch of parsing).
  So instead I would recommend fixing the issue in kdeconnect (and potentially 
other ioslave) as it will fix things here and elsewhere potentially too.
  
  Also `local = url.isLocalFile` should return false for kdeconnect in the 
first place.
  So I belive you can avoid using KMountPoint at all and use only stat.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham

D28203: Move corner fold to top right in 24 icons

[David Redondo]

davidre requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[David Redondo]

davidre reopened this revision.
davidre added a comment.


  This broke the build. Please note that tagging is today

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28470: WIP: IconItem: Refactor source handling for different types

[Konrad Materka]

kmaterka updated this revision to Diff 79279.
kmaterka added a comment.


  fix some silly errors

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28470?vs=79011=79279

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28203: Move corner fold to top right in 24 icons

[David Redondo]

davidre accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[David Redondo]

davidre closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Awesome.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I think it's to be preferred over name + icon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28552

AFFECTED FILES
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2808396a7bb8: Move corner fold to top right in 24 icons 
(authored by davidhurka).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=79272=79273

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka added a comment.


  I created revision D28204  accidentally 
when I tried to update this revision. That made my initial commit point to 
D28204  instead of D28203 
, so I couldn’t tell arc to land //this// 
revision. So I made git commit --amend on the initial commit to change the 
revision number, and rebased the other commits on the new commit. Phabricator 
UI tells me that the patch content stayed identical, so I land this now.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D26113: Places: For mounted volume display mount points instead of description

[Stefan Brüns]

bruns added a comment.


  In D26113#581228 , @ngraham wrote:
  
  > > As Vaults are not backed by an fstab entry, it would be the 
responsibility of Vaults to set a useful name (via x-gvfs-name).
  >
  > What I'm saying is that I think it makes sense for Solid to provide a 
better default display string so each app doesn't have to do this.
  
  
  What I'm saying is that Vaults should set a meaningful value via x-gvfs-name 
so Solid has not to invent something. Then Solid can use that, and it would be 
consistent everywhere.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham

D28203: Move corner fold to top right in 24 icons

[David Redondo]

davidre added a comment.


  Seems @kossebau was faster ;)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka added a comment.


  @ndavis commited (excerpt):
  
diff --git a/icons-dark/actions/22/document-export-ocal.svg 
b/icons-dark/actions/22/document-export-ocal.svg
index 4bfca303..ace4fe41 12
--- a/icons-dark/actions/22/document-export-ocal.svg
+++ b/icons-dark/actions/22/document-export-ocal.svg
@@ -1 +1 @@
-/home/david/kde/breeze-icons/icons-dark/actions/22/document-export.svg
\ No newline at end of file
+document-export.svg
\ No newline at end of file
  
  Yep, apparently you found the problem faster than me. :) I thought I fixed 
all the symlinks, wasn’t the case... Thanks for fixing my mess!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven added a comment.


  In D28555#641276 , @dfaure wrote:
  
  > any idea what buff_src.st_size < 0x7FFF was for?
  
  
  None, it does not makes sense to me, perhaps, we had an implementation 
limitation.
  
  In D28555#641277 , @broulik wrote:
  
  > >   reduce the overhead of processedSize dbus progress notification in each 
iteration since it is called less often, adding some more speed.
  >
  > From what I recall in copy job the processed size in emitted by a timer and 
not every time a chunk got processed
  
  
  You are right, it is emitted every 100ms in `SlaveBase::processedSize`, so 
this part was overzealot.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Re: New Framework Review: KDAV

[Volker Krause]

Thanks for the review! We are cutting it close again with the 20.04 deadline, 
but fortunately most of these findings aren't ABI-breaking :)

The result was discussed in more detail at the (virtual) PIM sprint, summary 
below for the record.

On Saturday, 4 April 2020 16:20:21 CEST Kevin Ottens wrote:
> Hello,
> 
> On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote:
> > during Akademy there was a request to promote KDAV from KDE PIM to
> > Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> > would be classified as a functional tier 3 framework.
> > 
> > So far we have fixed a number of obvious ABI-compatibility issues, removed
> > QtXml[Patterns] usage from the public interface and relicensed GPL parts
> > (apart from a bit of test code) to LGPL. The next step would be a more
> > thorough review to identify changes necessary before becoming a Framework.
> > 
> > To avoid the last minute invasive changes we ended up doing for
> > KCalendarCore, I'd propose the following timeline:
> > 
> > - identify and implement all necessary changes to the API and ABI until
> > the
> > 20.04 Application release (that includes the still necessary move to the
> > KF5 library namespace).
> 
> I'm likely late to the party, but here is what I found by looking at KDAV
> master today (first day of the KDE PIM sprint):
>  * There's a few private methods or Q_SLOTS that I'd hide completely by
> moving them to the d-pointer, for the slots we're using type safe connects
> so they don't even need to be marked as slots at all;

Cosmetic with no ABI impact, we can do that post 20.04 still.

>  * Is it worth making DavCollection moveable? It's only copyable right now;

Probably yes, that's new API with no ABI break, so we can do that post 20.04 
as well.

>  * We might want to do something about "ctag" in DavCollection it's a bit
> obscure as a name (and the API doc doesn't help), also it seems to not be an
> official standard (while being widely supported) and there's the sync-token
> mechanism which has a RFC (RFC6578);

I have no idea what ctag is (I am only doing the technical work needed to turn 
this into a framework, I didn't write this library).

>  * Why isn't DavCollectionModifyJob using DavCollection somehow? (might just
> be my ignorance but I find it surprising that it is solely based on a
> property mechanism);

I think this is to be able to control which properties get changed, rather 
than sending the full set of them.

>  * DavCollections(Multi)FetchJob has a mysterious "protocol" parameter on
> its collectionDiscovered signal, is it really necessary? if it has to stay,
> shouldn't be at least documented? or at least a safer type than int? 

Fixed in https://phabricator.kde.org/D28564 and https://phabricator.kde.org/
D28566

> * DavCollectionsMultiFetchJob is inconsistent as it's not using
> Q_DECLARE_PRIVATE;

That's due to using KJob as a base directly.

Subsequent discussion suggested this should be a KCompositeJob, David is 
taking care of this.

>  * KDAV::Error would benefit from more apidox;

Yes, not blocked by the 20.04 freeze though.

>  * Is it worth making DavItem moveable? It's only copyable right now;

See above, same as DavCollection.

>  * Same comment about etag for DavItem than the ctag one for DavCollection

See above, same as ctag.

>  * I'd be tempted to move all the protected methods of DavJobBase on its d-
> pointer, the job subclasses would have access to them anyway, it'd make
> sense to put them protected in the header only if we expect subclasses
> outside of the lib (and I doubt this is actually supported);

ABI impact mitigated by https://phabricator.kde.org/D28562 so we can clean 
this up after 20.04.

>  * It needs to decide between Qt smart pointers or STL ones I think, found a
> bit of both so far (I'd lean toward STL ones but maybe that's just me); 

Also fixed by https://phabricator.kde.org/D28562.

> * Make DavUrl moveable?

See above, same as DavCollection and DavItem.

>  * EtagCache probably shouldn't have anything protected, also, why is it a
> QObject at all?

This is why: https://lxr.kde.org/source/kde/pim/kdepim-runtime/resources/dav/
resource/akonadietagcache.cpp

>  * Are we sure we want to return a QLatin1String in ProtocolInfo? this
> strike me as an odd choice.

Fixed in https://phabricator.kde.org/D28563.

> Overall apidox would likely need a big pass of cleanups as well.

> I think that's it from me.

I hope we managed to address everything on short notice that would require ABI 
breaks after the 20.04 release (and thus cause a delay of the frameworks move 
Volker

signature.asc
Description: This is a digitally signed message part.

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:10cf5aca5b3d: File ioslave : use Better setting for 
sendfile syscall (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28555?vs=79284=79338

REVISION DETAIL
  https://phabricator.kde.org/D28555

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  sendfile-opt

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28555: File ioslave : use Better setting for sendfile syscall

[Stefan Brüns]

bruns added a comment.


  @dfaure: probably this:
  
  man sendfile, NOTES
  
  >   The  original Linux sendfile() system call was not designed to handle 
large file offsets.  Consequently, Linux 2.4 added sendfile64(), with a wider 
type for the offset argument.  The glibc sendfile() wrapper function 
transparently deals with the kernel differences.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28561: Remove border from format-border-set-* icons

[David Hurka]

davidhurka added a comment.


  There are 22px versions of these icons. They passed the auto-generation, 
because they use a different approach. They have a border, but it is not in 
ViewBackground, but in Text with transparency 0.1. Should I add such a border 
to the 16px version, or remove it in the 22px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  These icons had a kind of border in ViewBackground color, which made them 
look a bit strange. I don’t know whether that was intended.
  But with swap_colors.sed (T12855 ), the 
generated dark version didn’t match the original dark version.
  So I removed the ViewBackground elements.
  
  - set-bottom and set-internal didn’t have this border, but they had elements 
outside the canvas (actually the border), which are removed now.
  - set-internal also had one element outside the canvas.
  - set-internal-vertical had the vertical edge outside the canvas. I fixed 
that.
  - set-none had all outer edges, so it was identical to set-all. I removed the 
edges, because it should probably have “none” edges.
  - set-all does not need fixing.
  
  Screenshots:
  Before: Light and dark versions have the ViewBackground border.
  
  In the autogenerated dark version, the border looks different.
  
  After: No border in light version and autogenerated dark version.
  
  Template file. Cyan is a proxy color for ColorScheme-Text with transparency 
0.5.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

AFFECTED FILES
  icons-dark/actions/16/format-border-set-bottom.svg
  icons-dark/actions/16/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/16/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/16/format-border-set-external.svg
  icons-dark/actions/16/format-border-set-internal-horizontal.svg
  icons-dark/actions/16/format-border-set-internal-vertical.svg
  icons-dark/actions/16/format-border-set-internal.svg
  icons-dark/actions/16/format-border-set-left.svg
  icons-dark/actions/16/format-border-set-none.svg
  icons-dark/actions/16/format-border-set-right.svg
  icons-dark/actions/16/format-border-set-top.svg
  icons/actions/16/format-border-set-bottom.svg
  icons/actions/16/format-border-set-diagonal-bl-tr.svg
  icons/actions/16/format-border-set-diagonal-tl-br.svg
  icons/actions/16/format-border-set-external.svg
  icons/actions/16/format-border-set-internal-horizontal.svg
  icons/actions/16/format-border-set-internal-vertical.svg
  icons/actions/16/format-border-set-internal.svg
  icons/actions/16/format-border-set-left.svg
  icons/actions/16/format-border-set-none.svg
  icons/actions/16/format-border-set-right.svg
  icons/actions/16/format-border-set-top.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah sorry, I missed the fact that one doesn't actually need to call 
sendfile64() explicitly.
  
  And if sendfile fails we have a fall back, so yeah, might as well try in all 
cases.

REPOSITORY
  R241 KIO

BRANCH
  sendfile-opt

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28565: [QueryParser] Replace single-use helper with std::none_of

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28565

AFFECTED FILES
  src/engine/queryparser.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28570: Add 3mf thumbnail support

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28570

To: davidedmundson, broulik
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> bruns wrote in jobtest.cpp:1510
> The first goal should be to test if it works at all, i.e. if there is an 
> UDS_DEVICE_ID/INODE at all.

OK, that makes sense. Done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79339.
ahmadsamir added a comment.


  Skip the smallest part of the unit test

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79315=79339

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79315.
ahmadsamir marked 2 inline comments as done.
ahmadsamir added a comment.


  - Change unit test name
  - More QCOMPARE()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79133=79315

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven accepted this revision.
meven added a comment.


  Nice, plus a nice test added.
  Give some time to others to have a final say before merging.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  sendfile-opt

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

T12641: Refactor KFileProtocol::copy

[Méven Car]

meven updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T12641

To: meven
Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28573: Add 16px System Settings icon

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.
manueljlin added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28573

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28574: KRunner: Improve code snippet

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, davidedmundson, broulik, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The code snippet now uses the Qt5 syntax for the signals and the formatting 
has been fixed.

TEST PLAN
  /

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28574

AFFECTED FILES
  src/abstractrunner.h

To: alex, #plasma, davidedmundson, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> bruns wrote in jobtest.cpp:1510
> This should only apply to the `QVERIFY(device != otherDevice);`

Why? The goal is to test if the UDS_DEVICE_ID is unique for individual 
partitions, which won't work unless there are two separate partitions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in jobtest.cpp:1510
> Why? The goal is to test if the UDS_DEVICE_ID is unique for individual 
> partitions, which won't work unless there are two separate partitions.

The first goal should be to test if it works at all, i.e. if there is an 
UDS_DEVICE_ID/INODE at all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

[David Hurka]

davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

[Stefan Brüns]

bruns added a comment.


  In D28555#641390 , @dfaure wrote:
  
  > Sounds like the size check should stay then.
  
  
  Pessimizing sendfile for everyone, for the sake of Linux 2.2.x users?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28570: Add 3mf thumbnail support

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  3D Modelling Format is based on "Open Packaging Conventions" which is
  already supported by the opendocumentthumbnail spec, we just need to add
  the relevant mime type so our thumbnailer gets used.
  
  CCBUG: 407431

TEST PLAN
  Registed mime type from glob.
  (I should submit this to fd-shared-mime spec)
  Opened dolphin with a 3mf file with a thumbnail.
  It "just worked"

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28570

AFFECTED FILES
  thumbnail/opendocumentthumbnail.desktop

To: davidedmundson
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/35/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 04 Apr 2020 18:52:59 +
 Build duration:
5 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: New Framework Review: KDAV

[Kevin Ottens]

Hello,

On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote:
> during Akademy there was a request to promote KDAV from KDE PIM to
> Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> would be classified as a functional tier 3 framework.
> 
> So far we have fixed a number of obvious ABI-compatibility issues, removed
> QtXml[Patterns] usage from the public interface and relicensed GPL parts
> (apart from a bit of test code) to LGPL. The next step would be a more
> thorough review to identify changes necessary before becoming a Framework.
> 
> To avoid the last minute invasive changes we ended up doing for
> KCalendarCore, I'd propose the following timeline:
> 
> - identify and implement all necessary changes to the API and ABI until the
> 20.04 Application release (that includes the still necessary move to the KF5
> library namespace).

I'm likely late to the party, but here is what I found by looking at KDAV 
master today (first day of the KDE PIM sprint):
 * There's a few private methods or Q_SLOTS that I'd hide completely by moving 
them to the d-pointer, for the slots we're using type safe connects so they 
don't even need to be marked as slots at all;
 * Is it worth making DavCollection moveable? It's only copyable right now;
 * We might want to do something about "ctag" in DavCollection it's a bit 
obscure as a name (and the API doc doesn't help), also it seems to not be an 
official standard (while being widely supported) and there's the sync-token 
mechanism which has a RFC (RFC6578);
 * Why isn't DavCollectionModifyJob using DavCollection somehow? (might just 
be my ignorance but I find it surprising that it is solely based on a property 
mechanism);
 * DavCollections(Multi)FetchJob has a mysterious "protocol" parameter on its 
collectionDiscovered signal, is it really necessary? if it has to stay, 
shouldn't be at least documented? or at least a safer type than int?
 * DavCollectionsMultiFetchJob is inconsistent as it's not using 
Q_DECLARE_PRIVATE;
 * KDAV::Error would benefit from more apidox;
 * Is it worth making DavItem moveable? It's only copyable right now;
 * Same comment about etag for DavItem than the ctag one for DavCollection
 * I'd be tempted to move all the protected methods of DavJobBase on its d-
pointer, the job subclasses would have access to them anyway, it'd make sense 
to put them protected in the header only if we expect subclasses outside of 
the lib (and I doubt this is actually supported);
 * It needs to decide between Qt smart pointers or STL ones I think, found a 
bit of both so far (I'd lean toward STL ones but maybe that's just me);
 * Make DavUrl moveable?
 * EtagCache probably shouldn't have anything protected, also, why is it a 
QObject at all?
 * Are we sure we want to return a QLatin1String in ProtocolInfo? this strike 
me as an odd choice.

Overall apidox would likely need a big pass of cleanups as well.

I think that's it from me.

Regards.
-- 
Kevin Ottens, http://ervin.ipsquad.net

enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en

signature.asc
Description: This is a digitally signed message part.

D28555: File ioslave : use Better setting for sendfile syscall

[David Faure]

dfaure added a comment.


  Sounds like the size check should stay then.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham

D28573: Add 16px System Settings icon

[Manuel Jesús de la Fuente]

manueljlin created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
manueljlin requested review of this revision.

REVISION SUMMARY
  Adds a pixel fitted icon for System Settings

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28573

AFFECTED FILES
  icons-dark/apps/16/preferences-system.svg
  icons-dark/apps/16/systemsettings.svg
  icons/apps/16/preferences-system.svg
  icons/apps/16/systemsettings.svg

To: manueljlin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/2/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 04 Apr 2020 22:14:41 +
 Build duration:
1 min 30 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.69.0.xmllogs/KF5Package/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testpackage_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)74%
(1641/2230)51%
(1035/2022)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(567/763)63%
(532/843)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)42%
(227/536)36%
(190/526)

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis updated this revision to Diff 79358.
ndavis added a comment.


  Remove unused element

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79357=79358

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis updated this revision to Diff 79359.
ndavis added a comment.


  Update breeze dark version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79358=79359

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns