Review Request 127015: Move to tier2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127015/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- 6934d5441778a09d157836a590236e3dc8d5a492 added an optional dependency on karchive. This also means that it doesn't merely depend on Qt and a small number of third-party libs anymore and needs to moved to tier 2. Diffs - metainfo.yaml 10d0df9d41bd759174d99f387673a5fa6df66321 Diff: https://git.reviewboard.kde.org/r/127015/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127015: Move to tier2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127015/ --- (Updated Feb. 8, 2016, 8:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit baf894ba199623510ec9c894f947f001b863c5ce by Heiko Becker to branch master. Repository: kimageformats Description --- 6934d5441778a09d157836a590236e3dc8d5a492 added an optional dependency on karchive. This also means that it doesn't merely depend on Qt and a small number of third-party libs anymore and needs to moved to tier 2. Diffs - metainfo.yaml 10d0df9d41bd759174d99f387673a5fa6df66321 Diff: https://git.reviewboard.kde.org/r/127015/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127334: Fix build with -DBUILD_TEST=TRUE
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/ --- Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin. Repository: polkit-qt-1 Description --- Otherwise it fails with "test/test.cpp:49:14: error: 'qVariantValue' was not declared in this scope". qVariantValue is a obsolete workaround for MSVC 6, which was released 1998 and thus seems ancient enough to change this. Diffs - test/test.cpp afb7f64333e1122d86d2692f9cbaa94a08bec800 Diff: https://git.reviewboard.kde.org/r/127334/diff/ Testing --- Builds at least. The test doesn't run successfully though (Totals: 6 passed, 3 failed, 0 skipped, 0 blacklisted). I doubt it did before. There's also no target to run it. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/ --- (Updated March 10, 2016, 7:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin. Changes --- Submitted with commit 1b4b6b721d4f853f0ef93808ccf6648f3a7b3b9f by Heiko Becker to branch master. Repository: polkit-qt-1 Description --- Otherwise it fails with "test/test.cpp:49:14: error: 'qVariantValue' was not declared in this scope". qVariantValue is a obsolete workaround for MSVC 6, which was released 1998 and thus seems ancient enough to change this. Diffs - test/test.cpp afb7f64333e1122d86d2692f9cbaa94a08bec800 Diff: https://git.reviewboard.kde.org/r/127334/diff/ Testing --- Builds at least. The test doesn't run successfully though (Totals: 6 passed, 3 failed, 0 skipped, 0 blacklisted). I doubt it did before. There's also no target to run it. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127597: Fix generation of path to xcb plugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/#review94371
---
Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited to
solve the relative/absolute PLUGINDIR issue?
- Heiko Becker
On April 7, 2016, 7:55 vorm., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127597/
> ---
>
> (Updated April 7, 2016, 7:55 vorm.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwindowsystem
>
>
> Description
> ---
>
> The path was wrong which is the reason why X11 windows don't have
> icons in kwin_wayland.
>
>
> Diffs
> -
>
> src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164
>
> Diff: https://git.reviewboard.kde.org/r/127597/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Martin Gräßlin
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127597: Fix generation of path to xcb plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94420 --- Ship it! Ship It! - Heiko Becker On April 8, 2016, 6:28 vorm., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127597/ > --- > > (Updated April 8, 2016, 6:28 vorm.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > --- > > The path was wrong which is the reason why X11 windows don't have > icons in kwin_wayland. > > > Diffs > - > > src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164 > > Diff: https://git.reviewboard.kde.org/r/127597/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- Review request for KDE Frameworks. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated March 31, 2014, 2:44 p.m.) Review request for KDE Frameworks and Àlex Fiestas. Changes --- Let's see Alex opinion on that one. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated April 1, 2014, 4:31 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61601 --- cmake/modules/FindGettext.cmake <https://git.reviewboard.kde.org/r/119111/#comment42863> This also removes the first po_file argument resulting in no installed translations at all if a single po file per language directory is shipped. After removing the " 1" I've successfully built and installed systemsettings-4.98.0 - Heiko Becker On July 4, 2014, 10:12 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119111/ > --- > > (Updated July 4, 2014, 10:12 a.m.) > > > Review request for Build System, KDE Frameworks and Jonathan Riddell. > > > Repository: kdelibs4support > > > Description > --- > > This version will accept the old GETTEXT_PROCESS_PO_FILES() syntax (no > PO_FILES argument), but will also accept the new syntax required by > CMake's version of this file. It will also warn when PO_FILES is not > given. > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7e00ac52539066e71eeffb7df6c2148196 > > Diff: https://git.reviewboard.kde.org/r/119111/diff/ > > > Testing > --- > > None whatsoever: Jonathan, you know where this isssue has been seen, can you > test? > > > Thanks, > > Alex Merry > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119230: Import FindOpenGLES from kwin.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119230/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Import FindOpenGLES from kwin. Besides kwin it's also needed for kinfocenter and plasma-desktop. This is a follow-up of https://git.reviewboard.kde.org/r/119227/. Diffs - find-modules/FindOpenGLES.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119230/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119230: Import FindOpenGLES from kwin.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119230/ --- (Updated Juli 11, 2014, 11:31 vorm.) Status -- This change has been discarded. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Import FindOpenGLES from kwin. Besides kwin it's also needed for kinfocenter and plasma-desktop. This is a follow-up of https://git.reviewboard.kde.org/r/119227/. Diffs - find-modules/FindOpenGLES.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119230/diff/ Testing --- Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121272/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- KSharedConfig has been ported to QStandardPaths in KF5. I don't have commit access, so I would need someone to push this. Diffs - src/core/kconfig.h cc16792 Diff: https://git.reviewboard.kde.org/r/121272/diff/ Testing --- Generated the api docs and tested the link took me to KSharedConfig's page. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121272/ --- (Updated Nov. 28, 2014, 1 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- KSharedConfig has been ported to QStandardPaths in KF5. I don't have commit access, so I would need someone to push this. Diffs - src/core/kconfig.h cc16792 Diff: https://git.reviewboard.kde.org/r/121272/diff/ Testing --- Generated the api docs and tested the link took me to KSharedConfig's page. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122606: Fix startup of kssld5 dbus service
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606/#review76754 --- I'm not acquainted with the codebase, but I can confirm that the patch solves the described problem for me. - Heiko Becker On Feb. 17, 2015, 2:34 nachm., Bartosz Sławianowski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122606/ > --- > > (Updated Feb. 17, 2015, 2:34 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > KSslCertificateManager is trying to connect to org.kde.kssld5 directly which > doesn't work because it lacks it's own .service dbus file needed for > start-on-demand. > > This patch makes it connect correctly to org.kde.kiod5 (which then loads > kssld5 module and makes service available) instead. > > > Diffs > - > > src/core/ksslcertificatemanager.cpp a47ca68 > > Diff: https://git.reviewboard.kde.org/r/122606/diff/ > > > Testing > --- > > KIO git with patch, tested with Konversation which used to spam SSL errors > before applying patch. > > > Thanks, > > Bartosz Sławianowski > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81439 --- Ping? - Heiko Becker On Mai 8, 2015, 7:15 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123692/ > --- > > (Updated Mai 8, 2015, 7:15 nachm.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > --- > > The tests still work fine with it, allowing them to run without a > display server. > > > Diffs > - > > autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 > autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 > > Diff: https://git.reviewboard.kde.org/r/123692/diff/ > > > Testing > --- > > Built and ran the tests successfully. > > > Thanks, > > Heiko Becker > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated June 13, 2015, 7:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 5a63345aa9f9a3e27bcc25f53328687e519c1fdc by Heiko Becker to branch master. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81451 --- I've pushed this after Jeremy's comment. As someone who has no clue about Mac OS, I do wonder in what respect GUI-less tests are special on Mac OS. - Heiko Becker On Juni 13, 2015, 7:56 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123692/ > --- > > (Updated Juni 13, 2015, 7:56 nachm.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > --- > > The tests still work fine with it, allowing them to run without a > display server. > > > Diffs > - > > autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 > autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 > > Diff: https://git.reviewboard.kde.org/r/123692/diff/ > > > Testing > --- > > Built and ran the tests successfully. > > > Thanks, > > Heiko Becker > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124321: Fix building with the fake backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- Review request for KDE Frameworks. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given unknown export "KF5AuthToolsTargets"' Diffs - CMakeLists.txt 4e237afe40199df2b154cf10868e27993fa0fa27 src/CMakeLists.txt 7527bea4e3b971e5d4471301d4133c9827571dfa Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124321: Fix building with the fake backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 7:22 nachm.) Review request for KDE Frameworks. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given unknown export "KF5AuthToolsTargets"' Diffs (updated) - CMakeLists.txt 4e237afe40199df2b154cf10868e27993fa0fa27 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124321: Fix building with the fake backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 9:09 nachm.) Review request for KDE Frameworks. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given unknown export "KF5AuthToolsTargets"' Diffs (updated) - CMakeLists.txt 4e237afe40199df2b154cf10868e27993fa0fa27 KF5AuthConfig.cmake.in b7aa445aedef308a47de326475db91e483a078e1 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124321: Fix building with the fake backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 11:34 nachm.) Review request for KDE Frameworks. Changes --- Moved the if/else statement inside the if block. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given unknown export "KF5AuthToolsTargets"' Diffs (updated) - CMakeLists.txt 4e237afe40199df2b154cf10868e27993fa0fa27 KF5AuthConfig.cmake.in b7aa445aedef308a47de326475db91e483a078e1 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124321: Fix building with the fake backend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated July 11, 2015, 12:16 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5c026991572eb44eccf0e50c33199e80984c733e by Heiko Becker to branch master. Repository: kauth Description --- Otherwise it fails with: '-- Configuring done CMake Error: INSTALL(EXPORT) given unknown export "KF5AuthToolsTargets"' Diffs - CMakeLists.txt 4e237afe40199df2b154cf10868e27993fa0fa27 KF5AuthConfig.cmake.in b7aa445aedef308a47de326475db91e483a078e1 Diff: https://git.reviewboard.kde.org/r/124321/diff/ Testing --- Successfully build with the fake backend. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124636: Remove DDS and JPEG-2000 plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124636/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- They were already disabled when building with Qt >= 5.3 in commit 3d45b270ea8341d1516d5863cc49884c2744f2f2 because Qt has better plugins for those image formats. Now that we depend on Qt 5.3 we can remove them. Diffs - src/imageformats/CMakeLists.txt 7e75c213586bda8b4e36b39bb9f961e01ed058c0 autotests/CMakeLists.txt 8a2209df3ee267c11d3f6b242767a05c2f86a6c0 README.md c22c8cf2496912236eee29d40b2a6c466c493253 CMakeLists.txt e9915be7de139fea92abfde5d6bac2a45de4745f src/imageformats/config-jp2.h.cmake 1ef5135ae5e81029000f92228b570154e86d92f3 src/imageformats/dds.cpp bef46b1f840a1b255b61705fea1f47f2a219b270 src/imageformats/dds.desktop 27f0318ca74bf800d9976c469f86ec527d44b02a src/imageformats/dds.json bc30795640f385230de7ef4b09a7115e53c95ead src/imageformats/dds_p.h 51c9fd778852623797e718b5f31d331e9c7ad5cb src/imageformats/jp2.cpp dc9998c4bb6e17517dc98cfd4fa1e3906300454b src/imageformats/jp2.json 3ff6cde33f4a2906b86ae08a2afb50ce6a3c7fcd src/imageformats/jp2_p.h 448e847018e00b37a88b4b602adcbb2c22978035 Diff: https://git.reviewboard.kde.org/r/124636/diff/ Testing --- Successfully built it, ran the tests and installed it. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124636: Remove DDS and JPEG-2000 plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124636/ --- (Updated Aug. 5, 2015, 11:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit e5fce91de6ef72f15c7d31b16b2494f534c7157c by Heiko Becker to branch master. Repository: kimageformats Description --- They were already disabled when building with Qt >= 5.3 in commit 3d45b270ea8341d1516d5863cc49884c2744f2f2 because Qt has better plugins for those image formats. Now that we depend on Qt 5.3 we can remove them. Diffs - src/imageformats/CMakeLists.txt 7e75c213586bda8b4e36b39bb9f961e01ed058c0 autotests/CMakeLists.txt 8a2209df3ee267c11d3f6b242767a05c2f86a6c0 README.md c22c8cf2496912236eee29d40b2a6c466c493253 CMakeLists.txt e9915be7de139fea92abfde5d6bac2a45de4745f src/imageformats/config-jp2.h.cmake 1ef5135ae5e81029000f92228b570154e86d92f3 src/imageformats/dds.cpp bef46b1f840a1b255b61705fea1f47f2a219b270 src/imageformats/dds.desktop 27f0318ca74bf800d9976c469f86ec527d44b02a src/imageformats/dds.json bc30795640f385230de7ef4b09a7115e53c95ead src/imageformats/dds_p.h 51c9fd778852623797e718b5f31d331e9c7ad5cb src/imageformats/jp2.cpp dc9998c4bb6e17517dc98cfd4fa1e3906300454b src/imageformats/jp2.json 3ff6cde33f4a2906b86ae08a2afb50ce6a3c7fcd src/imageformats/jp2_p.h 448e847018e00b37a88b4b602adcbb2c22978035 Diff: https://git.reviewboard.kde.org/r/124636/diff/ Testing --- Successfully built it, ran the tests and installed it. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125386: qca-ossl: Fix build without SSLv3
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125386/ --- Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- This fixes building with LibreSSL >= 2.3.0 which has removed support for SSLv3 completely. As far as I know OpenSSL can be configured to build without it, so it might be helpful there as well. Diffs - plugins/qca-ossl/qca-ossl.cpp cfb1e9f Diff: https://git.reviewboard.kde.org/r/125386/diff/ Testing --- Successfully built, ran the tests and installed. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125387: qca-ossl: Fix build without support for SHA-0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125387/ --- Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- LibreSSL >= 2.3.0 removed support for SHA-0, so there's no EVP_sha anymore. Wikipedia says about SHA-0: "160-bit hash function published in 1993 under the name SHA. It was withdrawn shortly after publication due to an undisclosed "significant flaw" and replaced by the slightly revised version SHA-1.' Diffs - plugins/qca-ossl/qca-ossl.cpp cfb1e9f456bbd22e3fbb5320be17cfa56ca1bc27 plugins/qca-ossl/CMakeLists.txt 3124f02c416ed32026c781e68d41fff5916e7ebe Diff: https://git.reviewboard.kde.org/r/125387/diff/ Testing --- Successfully built, ran the tests and installed (with LibreSSL-2.3.0 and OpenSSL-1.0.2d). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125819/
---
Review request for KDE Frameworks.
Repository: kwallet
Description
---
Two reasons to do this:
- DBUS_INTERFACES_INSTALL_DIR is marked deprecated
- It's helpful on a multiarch layout where the prefix is /usr/${host}
but arch-independent files should still be installed to /usr/share.
Diffs
-
src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6
src/api/KWallet/KF5WalletConfig.cmake.in
82a18aa342d7e4abcde3fadec0b0dc802a2ef4ef
Diff: https://git.reviewboard.kde.org/r/125819/diff/
Testing
---
Successfully installed it with
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and
-DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces
> On Okt. 26, 2015, 10:03 nachm., Alex Merry wrote:
> > This shouldn't be necessary. I think the issue you're having is that you're
> > giving the wrong arguments to CMake. Rather than using
> >
> > -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
> >
> > you should be using
> >
> > -DCMAKE_INSTALL_DATAROOTDIR:PATH=/usr/share
> >
> > The "FULL" versions are calculated from the non-"FULL" ones. Perhaps I
> > should make that clearer in the KDEInstallDirs documentation...
Indeed, I did misunderstand that part. However, my problem is caused by
${PACKAGE_PREFIX_DIR} in the cmake config file. Omitting ..._FULL_... doesn't
change anything there.
- Heiko
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125819/#review87474
---
On Okt. 26, 2015, 8:40 nachm., Heiko Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125819/
> ---
>
> (Updated Okt. 26, 2015, 8:40 nachm.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwallet
>
>
> Description
> ---
>
> Two reasons to do this:
> - DBUS_INTERFACES_INSTALL_DIR is marked deprecated
> - It's helpful on a multiarch layout where the prefix is /usr/${host}
> but arch-independent files should still be installed to /usr/share.
>
>
> Diffs
> -
>
> src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6
> src/api/KWallet/KF5WalletConfig.cmake.in
> 82a18aa342d7e4abcde3fadec0b0dc802a2ef4ef
>
> Diff: https://git.reviewboard.kde.org/r/125819/diff/
>
>
> Testing
> ---
>
> Successfully installed it with
> -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and
> -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
>
>
> Thanks,
>
> Heiko Becker
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125819/
---
(Updated Okt. 27, 2015, 8:41 vorm.)
Review request for KDE Frameworks.
Changes
---
A slightly different approach without the _FULL_ variable
Repository: kwallet
Description
---
Two reasons to do this:
- DBUS_INTERFACES_INSTALL_DIR is marked deprecated
- It's helpful on a multiarch layout where the prefix is /usr/${host}
but arch-independent files should still be installed to /usr/share.
Diffs (updated)
-
src/api/KWallet/KF5WalletConfig.cmake.in
82a18aa342d7e4abcde3fadec0b0dc802a2ef4ef
src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6
Diff: https://git.reviewboard.kde.org/r/125819/diff/
Testing
---
Successfully installed it with
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and
-DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125819/
---
(Updated Oct. 27, 2015, 6:46 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 59509139a33829a5b76424d2a8c1cb2f3b885580 by Heiko Becker
to branch master.
Repository: kwallet
Description
---
Two reasons to do this:
- DBUS_INTERFACES_INSTALL_DIR is marked deprecated
- It's helpful on a multiarch layout where the prefix is /usr/${host}
but arch-independent files should still be installed to /usr/share.
Diffs
-
src/api/KWallet/KF5WalletConfig.cmake.in
82a18aa342d7e4abcde3fadec0b0dc802a2ef4ef
src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6
Diff: https://git.reviewboard.kde.org/r/125819/diff/
Testing
---
Successfully installed it with
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and
-DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125387: qca-ossl: Fix build without support for SHA-0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125387/ --- (Updated Oct. 28, 2015, 9:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Changes --- Submitted with commit 0dbed8eb38afd1561907a52283091c37e7b85156 by Heiko Becker to branch master. Repository: qca Description --- LibreSSL >= 2.3.0 removed support for SHA-0, so there's no EVP_sha anymore. Wikipedia says about SHA-0: "160-bit hash function published in 1993 under the name SHA. It was withdrawn shortly after publication due to an undisclosed "significant flaw" and replaced by the slightly revised version SHA-1.' Diffs - plugins/qca-ossl/qca-ossl.cpp cfb1e9f456bbd22e3fbb5320be17cfa56ca1bc27 plugins/qca-ossl/CMakeLists.txt 3124f02c416ed32026c781e68d41fff5916e7ebe Diff: https://git.reviewboard.kde.org/r/125387/diff/ Testing --- Successfully built, ran the tests and installed (with LibreSSL-2.3.0 and OpenSSL-1.0.2d). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125386: qca-ossl: Fix build without SSLv3
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125386/ --- (Updated Oct. 28, 2015, 9:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Changes --- Submitted with commit 20a587d77636186edb044cd2b71d6d90fe98d232 by Heiko Becker to branch master. Repository: qca Description --- This fixes building with LibreSSL >= 2.3.0 which has removed support for SSLv3 completely. As far as I know OpenSSL can be configured to build without it, so it might be helpful there as well. Diffs - plugins/qca-ossl/qca-ossl.cpp cfb1e9f Diff: https://git.reviewboard.kde.org/r/125386/diff/ Testing --- Successfully built, ran the tests and installed. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/ --- Review request for KDE Frameworks and Ivan Čukić. Bugs: 354521 http://bugs.kde.org/show_bug.cgi?id=354521 Repository: kactivities Description --- This "fixes" the build with said cmake param when boost isn't available. The boost dependency was introduced with 9274281f68b9fc387848a4b49b36934b6b216b3c. BUG:354521 Diffs - src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 Diff: https://git.reviewboard.kde.org/r/125852/diff/ Testing --- Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE. Not sure if this is an acceptable way to fix the issue, or if the option should be made to work without boost (or the option should possibly get removed). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled
> On Nov. 3, 2015, 5:21 nachm., Ivan Čukić wrote: > > The current master (the library) should build without boost now. Indeed. Thanks for the fix. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/#review87947 --- On Okt. 28, 2015, 9:48 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125852/ > --- > > (Updated Okt. 28, 2015, 9:48 nachm.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 354521 > http://bugs.kde.org/show_bug.cgi?id=354521 > > > Repository: kactivities > > > Description > --- > > This "fixes" the build with said cmake param when boost isn't available. > The boost dependency was introduced with > 9274281f68b9fc387848a4b49b36934b6b216b3c. > > BUG:354521 > > > Diffs > - > > src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 > > Diff: https://git.reviewboard.kde.org/r/125852/diff/ > > > Testing > --- > > Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE. > > Not sure if this is an acceptable way to fix the issue, or if the option > should be made to work without boost (or the option should possibly get > removed). > > > Thanks, > > Heiko Becker > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/ --- (Updated Nov. 3, 2015, 5:48 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks and Ivan Čukić. Bugs: 354521 http://bugs.kde.org/show_bug.cgi?id=354521 Repository: kactivities Description --- This "fixes" the build with said cmake param when boost isn't available. The boost dependency was introduced with 9274281f68b9fc387848a4b49b36934b6b216b3c. BUG:354521 Diffs - src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 Diff: https://git.reviewboard.kde.org/r/125852/diff/ Testing --- Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE. Not sure if this is an acceptable way to fix the issue, or if the option should be made to work without boost (or the option should possibly get removed). Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/
---
Review request for KDE Frameworks and Uri Herrera.
Repository: breeze-icons
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
Diffs
-
icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
Diff: https://git.reviewboard.kde.org/r/126056/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126057: Use KDE_INSTALL_FULL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/
---
Review request for KDE Frameworks and andreas kainz.
Repository: oxygen-icons5
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/$\{arch\}
but arch independent files should still go into /usr/share.
Diffs
-
CMakeLists.txt 8596219
Diff: https://git.reviewboard.kde.org/r/126057/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126058: Add .reviewboardrc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126058/ --- Review request for KDE Frameworks and andreas kainz. Repository: oxygen-icons5 Description --- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126058/diff/ Testing --- Ran rbt post -g to upload this patch. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126058: Add .reviewboardrc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126058/ --- (Updated Nov. 15, 2015, 8:54 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and andreas kainz. Changes --- Submitted with commit 52f003969e510b6f874dbc69e191b67daa9d4b12 by Heiko Becker to branch Applications/15.12. Repository: oxygen-icons5 Description --- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126058/diff/ Testing --- Ran rbt post -g to upload this patch. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/
---
(Updated Nov. 17, 2015, 12:42 nachm.)
Review request for KDE Frameworks and Uri Herrera.
Changes
---
Removed the unnecessary code and win32 handling, s/FULL_//
Summary (updated)
-
Use KDE_INSTALL_ICONDIR to install the icons
Repository: breeze-icons
Description (updated)
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)"
was already set to a higher value in the root CMakeLists.txt, same for
"set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")".
Furthermore I couldn't find any '*.sh' files in the repo.
REVIEW: 126056
Diffs (updated)
-
icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
Diff: https://git.reviewboard.kde.org/r/126056/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/
---
(Updated Nov. 17, 2015, 12:45 nachm.)
Review request for KDE Frameworks and andreas kainz.
Changes
---
Removed win32 handling, s/FULL_//
Summary (updated)
-
Use KDE_INSTALL_ICONDIR to install the icons
Repository: oxygen-icons5
Description (updated)
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
REVIEW: 126057
Diffs (updated)
-
CMakeLists.txt 85962199e481572e05e45dab6848983b8f22c3e1
Diff: https://git.reviewboard.kde.org/r/126057/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126057/
---
(Updated Nov. 22, 2015, 11:31 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and andreas kainz.
Changes
---
Submitted with commit a341a4a9fc8290cb9d453ec12f3bca79b09f92bd by Heiko Becker
to branch master.
Repository: oxygen-icons5
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
REVIEW: 126057
Diffs
-
CMakeLists.txt 85962199e481572e05e45dab6848983b8f22c3e1
Diff: https://git.reviewboard.kde.org/r/126057/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/
---
(Updated Nov. 22, 2015, 11:43 vorm.)
Review request for KDE Frameworks and Uri Herrera.
Changes
---
Back to the absolute dir
Summary (updated)
-
Use KDE_INSTALL_FULL_ICONDIR to install the icons
Repository: breeze-icons
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)"
was already set to a higher value in the root CMakeLists.txt, same for
"set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")".
Furthermore I couldn't find any '*.sh' files in the repo.
REVIEW: 126056
Diffs (updated)
-
icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
Diff: https://git.reviewboard.kde.org/r/126056/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126056/
---
(Updated Nov. 22, 2015, 1:57 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Uri Herrera.
Changes
---
Submitted with commit 5a501dd330b6a61cf6eb909946e5295115fe7693 by Heiko Becker
to branch master.
Repository: breeze-icons
Description
---
It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.
Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)"
was already set to a higher value in the root CMakeLists.txt, same for
"set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")".
Furthermore I couldn't find any '*.sh' files in the repo.
REVIEW: 126056
Diffs
-
icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd
icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0
Diff: https://git.reviewboard.kde.org/r/126056/diff/
Testing
---
Icons get installed into the desired location.
Thanks,
Heiko Becker
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128139: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128139/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt ec570193ee5ec0533dc2a0ae7e600ccb5bd9d6d1 Diff: https://git.reviewboard.kde.org/r/128139/diff/ Testing --- Warning disappears, still builds successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128139: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128139/ --- (Updated June 9, 2016, 3:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit a4de98aa4f77c393116be91ec2fbc8945895f4ff by Heiko Becker to branch master. Repository: kimageformats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt ec570193ee5ec0533dc2a0ae7e600ccb5bd9d6d1 Diff: https://git.reviewboard.kde.org/r/128139/diff/ Testing --- Warning disappears, still builds successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128250: Silence CMake policy CMP0063 warning also for tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128250/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Description --- Despite NO_POLICY_SCOPE being added to the inclusion of KDEFrameworkCompilerSettings warnings still appeared because ECMAddTests was included before it. Diffs - CMakeLists.txt e7554a9d6b2292fe27eadd86ea7a62d589db185e Diff: https://git.reviewboard.kde.org/r/128250/diff/ Testing --- Warnings disappeared, still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128251: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128251/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt 4b0d924aaa064e914e443155b11e29b0fd11fd5c Diff: https://git.reviewboard.kde.org/r/128251/diff/ Testing --- Warning disappears, it still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128252: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128252/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities-stats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt b11cb46a753f9abbce48aa290fe105e4184842f5 Diff: https://git.reviewboard.kde.org/r/128252/diff/ Testing --- Warning disappears, it still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128251: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128251/ --- (Updated June 29, 2016, 12:42 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 93fd546cb9f6455bc47bdc11df12dbab67284c0f by Heiko Becker to branch master. Repository: kactivities Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt 4b0d924aaa064e914e443155b11e29b0fd11fd5c Diff: https://git.reviewboard.kde.org/r/128251/diff/ Testing --- Warning disappears, it still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128252: Silence CMake policy CMP0063 warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128252/ --- (Updated June 28, 2016, 10:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 62ce194fe00ce0a7c04027db78a91a6dab72a11c by Heiko Becker to branch master. Repository: kactivities-stats Description --- ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's documentation. Diffs - CMakeLists.txt b11cb46a753f9abbce48aa290fe105e4184842f5 Diff: https://git.reviewboard.kde.org/r/128252/diff/ Testing --- Warning disappears, it still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128250: Silence CMake policy CMP0063 warning also for tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128250/ --- (Updated June 28, 2016, 10:45 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 1c1b2130235f0019d31f490bb95549a91d3ef342 by Heiko Becker to branch master. Repository: kpeople Description --- Despite NO_POLICY_SCOPE being added to the inclusion of KDEFrameworkCompilerSettings warnings still appeared because ECMAddTests was included before it. Diffs - CMakeLists.txt e7554a9d6b2292fe27eadd86ea7a62d589db185e Diff: https://git.reviewboard.kde.org/r/128250/diff/ Testing --- Warnings disappeared, still builds. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128357: Fix warning from uic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128357/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Gets rid of the following warning: "src/downloadwidget.ui: Warning: Z-order assignment: '' is not a valid widget." by removing an empty pair of tags. Diffs - src/downloadwidget.ui 456556df63158e3bb075d026944eac9d43dd Diff: https://git.reviewboard.kde.org/r/128357/diff/ Testing --- Warning disappears, builds fine. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128357: Fix warning from uic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128357/ --- (Updated July 4, 2016, 1:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 7099aab54289b2a8be742b110e58759f9bad9a0c by Heiko Becker to branch master. Repository: knewstuff Description --- Gets rid of the following warning: "src/downloadwidget.ui: Warning: Z-order assignment: '' is not a valid widget." by removing an empty pair of tags. Diffs - src/downloadwidget.ui 456556df63158e3bb075d026944eac9d43dd Diff: https://git.reviewboard.kde.org/r/128357/diff/ Testing --- Warning disappears, builds fine. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128739: Fix build with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- Also correct the other #ifdef because like QChar::Script_SignWriting 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the other enums as well. That commit was first released with Qt 5.6 BUG: 366789 CCMAIL: martin.sandsm...@kde.org Diffs - src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 Diff: https://git.reviewboard.kde.org/r/128739/diff/ Testing --- Haven't an old Qt around, tested building with 5.7. though. Thanks, Heiko Becker
Re: Review Request 128739: Fix build with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/#review98566 --- Ship it! ?[12:11] ?? commit it if someone can test with the appropriate Qt versions ... ?[12:13] ?? hmm, I have the right Qt versions. I can download the pat- ... ?[12:31] ?? heirecka: I ended up applying to patch manually..., and it compiles fine now :) - Heiko Becker On Aug. 23, 2016, 12:10 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128739/ > --- > > (Updated Aug. 23, 2016, 12:10 nachm.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: sonnet > > > Description > --- > > Also correct the other #ifdef because like QChar::Script_SignWriting > 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the > other enums as well. That commit was first released with Qt 5.6 > > BUG: 366789 > CCMAIL: martin.sandsm...@kde.org > > > Diffs > - > > src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 > > Diff: https://git.reviewboard.kde.org/r/128739/diff/ > > > Testing > --- > > Haven't an old Qt around, tested building with 5.7. though. > > > Thanks, > > Heiko Becker > >
Re: Review Request 128739: Fix build with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/ --- (Updated Aug. 23, 2016, 11:28 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit b241c854c42931280ee5366439af40144f1268af by Heiko Becker to branch master. Repository: sonnet Description --- Also correct the other #ifdef because like QChar::Script_SignWriting 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the other enums as well. That commit was first released with Qt 5.6 BUG: 366789 CCMAIL: martin.sandsm...@kde.org Diffs - src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 Diff: https://git.reviewboard.kde.org/r/128739/diff/ Testing --- Haven't an old Qt around, tested building with 5.7. though. Thanks, Heiko Becker
Re: Review Request 128739: Fix build with Qt < 5.6
> On Aug. 23, 2016, 1:27 nachm., Heiko Becker wrote: > > ?[12:11] ?? commit it if someone can test with the appropriate > > Qt versions > > ... > > ?[12:13] ?? hmm, I have the right Qt versions. I can download the > > pat- > > ... > > ?[12:31] ?? heirecka: I ended up applying to patch manually..., and > > it compiles fine now :) > > Burkhard Lück wrote: > Your patch breaks build with Qt 5.6.1 for me > > I need this patch on to of yours to get it build: > index 4607966..abc50af 100644 > --- a/src/core/guesslanguage.cpp > +++ b/src/core/guesslanguage.cpp > @@ -489,7 +489,7 @@ GuessLanguagePrivate::GuessLanguagePrivate() > case QChar::Script_WarangCiti: > names = getNames(QLocale::VarangKshitiScript); > break; > -#if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0) > +#if QT_VERSION > QT_VERSION_CHECK(5, 6, 1) > case QChar::Script_Ahom: > names = getNames(QLocale::AhomScript); > break; Yeah, sorry about that. I misread git's output, when determining in which qt version it had landed. Fixed with: https://quickgit.kde.org/?p=sonnet.git&a=commit&h=3d7d09fb7bae81ab5d277c1862b85955df96f1f5 - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128739/#review98566 --- On Aug. 23, 2016, 1:28 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128739/ > --- > > (Updated Aug. 23, 2016, 1:28 nachm.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: sonnet > > > Description > --- > > Also correct the other #ifdef because like QChar::Script_SignWriting > 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the > other enums as well. That commit was first released with Qt 5.6 > > BUG: 366789 > CCMAIL: martin.sandsm...@kde.org > > > Diffs > - > > src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 > > Diff: https://git.reviewboard.kde.org/r/128739/diff/ > > > Testing > --- > > Haven't an old Qt around, tested building with 5.7. though. > > > Thanks, > > Heiko Becker > >
Review Request 128980: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128980/ --- Review request for KDE Frameworks and Volker Krause. Repository: syntax-highlighting Description --- Allowing the tests to pass without a running X server. Diffs - autotests/highlighter_benchmark.cpp 7c17101 autotests/htmlhighlighter_test.cpp bad322d autotests/repository_benchmark.cpp 8a467f9 autotests/syntaxrepository_test.cpp 0011f7d autotests/testhighlighter.cpp e903e97 autotests/theme_test.cpp f602e11 autotests/wildcardmatcher_test.cpp 3cf61bc Diff: https://git.reviewboard.kde.org/r/128980/diff/ Testing --- Tests build and run fine. Thanks, Heiko Becker
Review Request 128981: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128981/ --- Review request for KDE Frameworks and David Rosca. Repository: bluez-qt Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 Diff: https://git.reviewboard.kde.org/r/128981/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128981: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128981/ --- (Updated Sept. 21, 2016, 6:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Rosca. Changes --- Submitted with commit 40dc1493ab859223a093a9b9f6f5c84795376066 by Heiko Becker to branch master. Repository: bluez-qt Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 Diff: https://git.reviewboard.kde.org/r/128981/diff/ Testing --- Thanks, Heiko Becker
Review Request 128982: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128982/ --- Review request for KDE Frameworks and David Faure. Repository: karchive Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 Diff: https://git.reviewboard.kde.org/r/128982/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128980: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128980/ --- (Updated Sept. 21, 2016, 4:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Volker Krause. Changes --- Submitted with commit 0fea247d1afdeccb2fbba9ce4375f108953701f4 by Heiko Becker to branch master. Repository: syntax-highlighting Description --- Allowing the tests to pass without a running X server. Diffs - autotests/highlighter_benchmark.cpp 7c17101 autotests/htmlhighlighter_test.cpp bad322d autotests/repository_benchmark.cpp 8a467f9 autotests/syntaxrepository_test.cpp 0011f7d autotests/testhighlighter.cpp e903e97 autotests/theme_test.cpp f602e11 autotests/wildcardmatcher_test.cpp 3cf61bc Diff: https://git.reviewboard.kde.org/r/128980/diff/ Testing --- Tests build and run fine. Thanks, Heiko Becker
Review Request 128983: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128983/ --- Review request for KDE Frameworks and Michael Pyne. Repository: kcoreaddons Description --- Frameworks already require Qt 5.5.0. Diffs - src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 Diff: https://git.reviewboard.kde.org/r/128983/diff/ Testing --- Thanks, Heiko Becker
Review Request 128984: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128984/ --- Review request for KDE Frameworks. Repository: kidletime Description --- Frameworks already require Qt 5.5.0. Diffs - src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 Diff: https://git.reviewboard.kde.org/r/128984/diff/ Testing --- Thanks, Heiko Becker
Review Request 128985: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128985/ --- Review request for KDE Frameworks. Repository: kitemmodels Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/klinkitemselectionmodeltest.cpp 1399700cf58dec0ca9f661b7bc2c361e0df2349e autotests/kselectionproxymodeltest.cpp fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 Diff: https://git.reviewboard.kde.org/r/128985/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128982: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128982/ --- (Updated Sept. 21, 2016, 4:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit f9ed1d9c9f090457223c88df8729161bc811f0a2 by Heiko Becker to branch master. Repository: karchive Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 Diff: https://git.reviewboard.kde.org/r/128982/diff/ Testing --- Thanks, Heiko Becker
Review Request 128986: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128986/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- Frameworks already require Qt 5.5.0. Diffs - src/plugins/hunspell/hunspelldebug.cpp 5f9aebe0821cffb44adfe2b82595bce724dc53d7 src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 Diff: https://git.reviewboard.kde.org/r/128986/diff/ Testing --- Thanks, Heiko Becker
Review Request 128987: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128987/ --- Review request for KDE Frameworks. Repository: kauth Description --- Frameworks already require Qt 5.5.0. Diffs - src/backends/dbus/DBusHelperProxy.cpp decc2676a005def1cb6feea0670f3eb981c4519d src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 Diff: https://git.reviewboard.kde.org/r/128987/diff/ Testing --- Thanks, Heiko Becker
Review Request 128988: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/ --- Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128988/diff/ Testing --- Thanks, Heiko Becker
Review Request 128989: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128989/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Frameworks already require Qt 5.5.0. Diffs - src/imageformats/eps.cpp e566cc41d70ff66e38d7915ef5c9d561a2c23349 Diff: https://git.reviewboard.kde.org/r/128989/diff/ Testing --- Thanks, Heiko Becker
Review Request 128990: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128990/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp 445b7ee4b40560577488b6a3fcd15f593693fbb3 Diff: https://git.reviewboard.kde.org/r/128990/diff/ Testing --- Thanks, Heiko Becker
Review Request 128991: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128991/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- Frameworks already require Qt 5.5.0. Diffs - src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 Diff: https://git.reviewboard.kde.org/r/128991/diff/ Testing --- Thanks, Heiko Becker
Review Request 128992: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128992/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarative Description --- Frameworks already require Qt 5.5.0. Diffs - src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp 351d99fc435f9ba8d58269e0b92dab3483f77580 src/qmlcontrols/kquickcontrolsaddons/plotter.h b9177690a5268c26697a7f0b37470ef0058112c6 src/qmlcontrols/kquickcontrolsaddons/plotter.cpp ffcb4ee4b43f5d99f419ef0e1680064f57cb1002 Diff: https://git.reviewboard.kde.org/r/128992/diff/ Testing --- Thanks, Heiko Becker
Review Request 128993: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128993/ --- Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c Diff: https://git.reviewboard.kde.org/r/128993/diff/ Testing --- Thanks, Heiko Becker
Review Request 128994: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128994/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- Frameworks already require Qt 5.5.0. Diffs - src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c Diff: https://git.reviewboard.kde.org/r/128994/diff/ Testing --- Thanks, Heiko Becker
Review Request 128995: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128995/ --- Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Frameworks already require Qt 5.5.0. Diffs - src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 Diff: https://git.reviewboard.kde.org/r/128995/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128993: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128993/ --- (Updated Sept. 22, 2016, 3:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 1536ab6c8996d5f21d7a59089bf99de675faee18 by Heiko Becker to branch master. Repository: kdesignerplugin Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c Diff: https://git.reviewboard.kde.org/r/128993/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128988: Drop obsolete version check
> On Sept. 22, 2016, 9:12 nachm., David Faure wrote: > > src/kcrash.cpp, line 62 > > <https://git.reviewboard.kde.org/r/128988/diff/1/?file=477287#file477287line62> > > > > While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or > > review 128232). I'd rather put that in a separate commit. Also, I've seen that in quite a number of other frameworks. Should I mail kde-frameworks one time instead of posting another round of review requests? - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/#review99438 ------- On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128988/ > --- > > (Updated Sept. 21, 2016, 7:11 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcrash > > > Description > --- > > Frameworks already require Qt 5.5.0. > > > Diffs > - > > src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 > > Diff: https://git.reviewboard.kde.org/r/128988/diff/ > > > Testing > --- > > > Thanks, > > Heiko Becker > >
Re: Review Request 128988: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/ --- (Updated Sept. 22, 2016, 4:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128988/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128988: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/ --- (Updated Sept. 22, 2016, 10:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128988/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128984: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128984/ --- (Updated Sept. 23, 2016, 12:36 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8c58398b4cafe22ce1cf28fdaf9fb62948425d36 by Heiko Becker to branch master. Repository: kidletime Description --- Frameworks already require Qt 5.5.0. Diffs - src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 Diff: https://git.reviewboard.kde.org/r/128984/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128985: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128985/ --- (Updated Sept. 22, 2016, 4:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ed9e2553a92844567f76e7ce468a5d3128e9fb51 by Heiko Becker to branch master. Repository: kitemmodels Description --- Frameworks already require Qt 5.5.0. Diffs - autotests/klinkitemselectionmodeltest.cpp 1399700cf58dec0ca9f661b7bc2c361e0df2349e autotests/kselectionproxymodeltest.cpp fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 Diff: https://git.reviewboard.kde.org/r/128985/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128986: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128986/ --- (Updated Sept. 23, 2016, 12:40 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit c55f73557ca7ab09caaa593d951297cc551c6d72 by Heiko Becker to branch master. Repository: sonnet Description --- Frameworks already require Qt 5.5.0. Diffs - src/plugins/hunspell/hunspelldebug.cpp 5f9aebe0821cffb44adfe2b82595bce724dc53d7 src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 Diff: https://git.reviewboard.kde.org/r/128986/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128987: Drop obsolete version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128987/ --- (Updated Sept. 22, 2016, 6:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 61c63d6b8e08c60f3336604f45a647691c32cf91 by Heiko Becker to branch master. Repository: kauth Description --- Frameworks already require Qt 5.5.0. Diffs - src/backends/dbus/DBusHelperProxy.cpp decc2676a005def1cb6feea0670f3eb981c4519d src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 Diff: https://git.reviewboard.kde.org/r/128987/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128990: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128990/ --- (Updated Sept. 23, 2016, 12:43 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 36142ace3236517180a3ccbcb3e692beebe53498 by Heiko Becker to branch master. Repository: kjobwidgets Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp 445b7ee4b40560577488b6a3fcd15f593693fbb3 Diff: https://git.reviewboard.kde.org/r/128990/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128991: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128991/ --- (Updated Sept. 22, 2016, 11:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 40077d52b554d5903aa53fffaba46912aa55918a by Heiko Becker to branch master. Repository: kactivities Description --- Frameworks already require Qt 5.5.0. Diffs - src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 Diff: https://git.reviewboard.kde.org/r/128991/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128995: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128995/ --- (Updated Sept. 23, 2016, 12:46 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 270c0546b1248aebf4d8698d80ac5be461d1784d by Heiko Becker to branch master. Repository: kinit Description --- Frameworks already require Qt 5.5.0. Diffs - src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 Diff: https://git.reviewboard.kde.org/r/128995/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128994: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128994/ --- (Updated Sept. 23, 2016, 12:48 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Changes --- Submitted with commit f2f0b2722e2cf53d982c5ebb52425e84278140e1 by Heiko Becker to branch master. Repository: kglobalaccel Description --- Frameworks already require Qt 5.5.0. Diffs - src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c Diff: https://git.reviewboard.kde.org/r/128994/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128983: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128983/ --- (Updated Sept. 23, 2016, 12:51 vorm.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Michael Pyne. Repository: kcoreaddons Description --- Frameworks already require Qt 5.5.0. Diffs - src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 Diff: https://git.reviewboard.kde.org/r/128983/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 128989: Drop obsolete version check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128989/ --- (Updated Sept. 23, 2016, 12:52 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 5fdcdff6e387b5f6285a6eb5ad0c7f7a99b8bd1a by Heiko Becker to branch master. Repository: kimageformats Description --- Frameworks already require Qt 5.5.0. Diffs - src/imageformats/eps.cpp e566cc41d70ff66e38d7915ef5c9d561a2c23349 Diff: https://git.reviewboard.kde.org/r/128989/diff/ Testing --- Thanks, Heiko Becker
Review Request 129351: Only search for a avatar if loginName isn't empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/ --- Review request for KDE Frameworks, David Edmundson and Michael Pyne. Repository: kcoreaddons Description --- 70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user avatars via AccountsService. It's seems pointless to search for an avatar with an empty user name, e.g. an invalid user, though. Furthermore it makes kusertest fail with the following message if ACCOUNTS_SERVICE_ICON_DIR exists: 'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/" Expected (QString())' Diffs - src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 Diff: https://git.reviewboard.kde.org/r/129351/diff/ Testing --- kusertest doesn't fail anymore. Thanks, Heiko Becker
Re: Review Request 129351: Only search for a avatar if loginName isn't empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/ --- (Updated Nov. 6, 2016, 7:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Edmundson and Michael Pyne. Changes --- Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker to branch master. Repository: kcoreaddons Description --- 70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user avatars via AccountsService. It's seems pointless to search for an avatar with an empty user name, e.g. an invalid user, though. Furthermore it makes kusertest fail with the following message if ACCOUNTS_SERVICE_ICON_DIR exists: 'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/" Expected (QString())' Diffs - src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 Diff: https://git.reviewboard.kde.org/r/129351/diff/ Testing --- kusertest doesn't fail anymore. Thanks, Heiko Becker
Review Request 129417: Add metainfo.yaml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129417/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: prison Description --- Striking one requirement for becoming a framework from the list. Diffs - metainfo.yaml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129417/diff/ Testing --- Thanks, Heiko Becker
Review Request 129418: Adjust directory structure to Frameworks policies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129418/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: prison Description --- According to the requirements listed on https://community.kde.org/Frameworks/Policies#Framework_directory_structure Diffs - CMakeLists.txt 37fb3a0 lib/CMakeLists.txt lib/abstractbarcode.h lib/abstractbarcode.cpp lib/code39barcode.h lib/code39barcode.cpp lib/code93barcode.h lib/code93barcode.cpp lib/datamatrixbarcode.h lib/datamatrixbarcode.cpp lib/prison.h lib/prison.cpp lib/qrcodebarcode.h lib/qrcodebarcode.cpp src/CMakeLists.txt PRE-CREATION tests/barcodeexamplewidget.cpp ef385a5 tests/prison.cpp a722367 tools/CMakeLists.txt tools/prison-datamatrix.cpp 6491b76 Diff: https://git.reviewboard.kde.org/r/129418/diff/ Testing --- cmake .. && make Thanks, Heiko Becker
Re: Review Request 129417: Add metainfo.yaml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129417/ --- (Updated Nov. 16, 2016, 5:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 1b72429bdd256711b1f430367408abe9ddee8186 by Heiko Becker to branch master. Repository: prison Description --- Striking one requirement for becoming a framework from the list. Diffs - metainfo.yaml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129417/diff/ Testing --- Thanks, Heiko Becker
Re: Review Request 129418: Adjust directory structure to Frameworks policies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129418/ --- (Updated Nov. 16, 2016, 6:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 96d2e4e7dfe3d13b85ee37df0961d33566e8659a by Heiko Becker to branch master. Repository: prison Description --- According to the requirements listed on https://community.kde.org/Frameworks/Policies#Framework_directory_structure Diffs - CMakeLists.txt 37fb3a0 lib/CMakeLists.txt lib/abstractbarcode.h lib/abstractbarcode.cpp lib/code39barcode.h lib/code39barcode.cpp lib/code93barcode.h lib/code93barcode.cpp lib/datamatrixbarcode.h lib/datamatrixbarcode.cpp lib/prison.h lib/prison.cpp lib/qrcodebarcode.h lib/qrcodebarcode.cpp src/CMakeLists.txt PRE-CREATION tests/barcodeexamplewidget.cpp ef385a5 tests/prison.cpp a722367 tools/CMakeLists.txt tools/prison-datamatrix.cpp 6491b76 Diff: https://git.reviewboard.kde.org/r/129418/diff/ Testing --- cmake .. && make Thanks, Heiko Becker
Review Request 129559: Also search for hunspell-1.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129559/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- Also search for hunspell-1.5 Diffs - cmake/FindHUNSPELL.cmake f028abe Diff: https://git.reviewboard.kde.org/r/129559/diff/ Testing --- Thanks, Heiko Becker
