D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added a comment.


  In D23917#530297 , @broulik wrote:
  
  > If the container is `const` already there's no real reason to explicitly 
use `constBegin` which is effectively the same
  
  
  Yes, however it's still a good idea to be explicit about it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> output_interface.cpp:119
> +auto rit = std::find_if(resources.constBegin(), 
> resources.constEnd(), [native] (const ResourceData ) { return 
> data.resource == native; });
>  if (rit != resources.end()) {
>  return (*it);

constEnd

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23916

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> registry.cpp:879
>  });
>  if (it == m_interfaces.end()) {
>  qCDebug(KWAYLAND_CLIENT) << "Don't have interface " << 
> int(interface) << "with name " << name << "and minimum version" << version;

constEnd

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23930

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24002: Sort files alphabetically in cmake list

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> CMakeLists.txt:49-50
>  shell_interface.cpp
>  surface_interface.cpp
>  subcompositor_interface.cpp
>  textinput_interface.cpp

Open vim, select all relevant lines in visual mode, and run sort command.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24002

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24003: kwaylandScanner produce version enum per class

[Vlad Zahorodnii]

zzag added a comment.


  FYI, https://phabricator.kde.org/D22362#493722

INLINE COMMENTS

> generator.cpp:431
>  auto it = std::find_if(m_interfaces.constBegin(), 
> m_interfaces.constEnd(), [] (const Interface ) { return i.isGlobal(); });
> -if (it != m_interfaces.constEnd()) {
> +while (it != m_interfaces.constEnd()) {
>  const QString templateString = QStringLiteral(

Is it correct thogugh? Can you provide some test input so it's easier to see 
the problem?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24003

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24002: Sort files alphabetically in cmake list

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D24002

REVISION DETAIL
  https://phabricator.kde.org/D24002

To: gladhorn, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> test_wayland_surface.cpp:396
>  
> -wl_buffer *blackBuffer = *(m_shm->createBuffer(black).data());
> -auto redBuffer = m_shm->createBuffer(red);
> +auto blackBufferPtr = m_shm->createBuffer(black).toStrongRef();
> +QVERIFY(blackBufferPtr);

I know it's unrelated, but erasing smart pointer types perhaps is not the 
greatest idea. Could you please use concrete type instead of auto while you're 
on this?

> region.cpp:61
>  {
> -for (const auto  : region.rects()) {
> -installRegion(rect);
> +for (auto it = region.begin(); it != region.end(); ++it) {
> +installRegion(*it);

Heh, you could make it a bit simpler:

  for (const QRect  : region) {
  ...
  }

> surface_interface_p.h:26-27
>  // Qt
>  #include 
> +#include 
>  // Wayland

Keep includes sorted please.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24014

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in test_wayland_surface.cpp:396
> The "Almost Always Auto" crowd would disagree with you, but sure, your 
> choice. Done.

Putting auto everywhere is a terrible thing! Surely it makes refactoring a bit 
easier, however you kill readability by erasing types.

Qt has a really good auto keyword usage guideline. 
https://wiki.qt.io/Coding_Conventions#auto_Keyword

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24014

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23915: Add some docstrings

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> dpms.h:44
>   *
> + * Display Power Management Signaling allows power management for monitors.
> + *

Not sure that this is valid documentation for org_kde_kwin_dpms_manager because 
it's nothing more but a factory.

> dpms_interface.h:38-41
> + * Display Power Management Signaling allows power management for monitors.
> + * A DpmsManagerInterface allows a client to query the DPMS state
> + * on a given OutputInterface and request changes to it.
> + * The code interaction happens only via the OutputInterface.

While it's sort of true, I don't think it's valid description. The line above 
precisely describes what DpmsManagerInterface is.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

[Vlad Zahorodnii]

zzag abandoned this revision.
zzag added a comment.


  Okay, I see.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Vlad Zahorodnii]

zzag added a comment.


  In D20261#443859 , @broulik wrote:
  
  > This is a bug in Quassel, a violation of the FDO spec, it should have ebeen 
`quassel-tray-inactive` or something
  
  
  See https://github.com/quassel/quassel/pull/515

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: zzag, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

[Vlad Zahorodnii]

zzag retitled this revision from "Add property definition for 
"X-Plasma-MainScript" for Plasma/Wallpaper" to "Define property 
X-Plasma-MainScript for Plasma/Wallpaper".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25184: Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  This commit fixes `Unknown property type for key "X-Plasma-MainScript"`
  warning that pops up when building a wallpaper plugin.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  property-def

REVISION DETAIL
  https://phabricator.kde.org/D25184

AFFECTED FILES
  src/scriptengines/qml/data/plasma-wallpaper.desktop

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  > IT seems that it was a error during modernize code by using nullptr
  
  Yeah, we had the same issue with running modernize-use-nullptr over kwin's 
code base.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

To: mlaurent, romangg, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added a comment.


  In D24663#549764 , @kossebau wrote:
  
  > @zzag Hi. Any chance you can have time to review this today/the WE? One of 
the last ECMGenerateExportHeader patches.
  
  
  Hi, sorry for the late response. Yes, I think this change is/was good to go.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag removed a dependent revision: D24660: [x11] Add support for 
_GTK_FRAME_EXTENTS.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

[Vlad Zahorodnii]

zzag added a comment.


  I suggest to set ColumnLimit to 0 by default and allow projects to override 
it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:741
>  
> -#ifndef KWAYLANDSERVER_NO_DEPRECATED
>  void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop)

Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in 
KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.

Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag edited reviewers, added: KWin; removed: Plasma.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin, #plasma
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag added a dependent revision: D24660: [x11] Add support for 
_GTK_FRAME_EXTENTS.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag removed a dependent revision: D24660: [x11] Add support for 
_GTK_FRAME_EXTENTS.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  _GTK_FRAME_EXTENTS is a property set by the client that specifies extents
  of the client-side drop-shadow, which should be ignored when doing things
  like resizing, placing, snapping to screen borders, etc.
  
  _GTK_FRAME_EXTENTS is a proprietary GTK atom, it's not in the NetWM spec.

REPOSITORY
  R278 KWindowSystem

BRANCH
  gtk-frame-extents

REVISION DETAIL
  https://phabricator.kde.org/D24657

AFFECTED FILES
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> dfaure wrote in clang-format.cmake:75
> typo: ternary

I've been always wondering how one should break long ternary operators when 
writing KF code. There are several ways to do it

(a) w/o breaking (BreakBeforeTernaryOperators: false)

  const FooBar *foobar = someStupidCondition() ?
  someSuperDuperBeatifulFunctionWithLongName() :
  anotherSuperDuperBeatiflFunctionWithLongName();

(b) w/ breaking (BreakBeforeTernaryOperators: true)

  const FooBar *foobar = someStupidCondition()
  ? someSuperDuperBeatifulFunctionWithLongName()
  : anotherSuperDuperBeatiflFunctionWithLongName();

According to the _clang-format file from the qt5 super repo, Qt fellas prefer 
(b) to break before ternary operators.

Do we really want to not break before ternary opeartors?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag closed this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

[Vlad Zahorodnii]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:d0b3eab864a2: [server] Make double-buffered properties in 
xdg-shell double-buffered (authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23745?vs=65603=70425#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23745?vs=65603=70425

REVISION DETAIL
  https://phabricator.kde.org/D23745

AFFECTED FILES
  autotests/client/test_xdg_shell_stable.cpp
  autotests/client/test_xdg_shell_v6.cpp
  src/server/CMakeLists.txt
  src/server/generic_shell_surface_p.h
  src/server/shell_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h
  src/server/surfacerole.cpp
  src/server/surfacerole_p.h
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> netwm_def.h:336-339
>  /**
> @deprecated has unclear meaning and is KDE-only
>  **/
>  Override = 6, // NON STANDARD

This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 
0)`, right?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new class provides a way for monitoring system clock changes. This
  class can be useful for applications that build their logic around time,
  for example dynamic wallpapers, so reacting to system clock changes is
  quite crucial for them.
  
  The new class can also be useful for Night Color in KWin and time data
  engine as they two don't have support for FreeBSD. KClockSkewNotifier
  also doesn't have support for FreeBSD at this moment, however when it
  gains that, we'll have to patch only one place rather than two.
  
  All good stuff happens in so called "notifier engines." A notifier
  engine is responsible for detecting system clock changes and all
  platform-specific code must reside there. KClockSkewNotifier is just a
  thin wrapper around the corresponding engine, which is loaded and
  unloaded as needed.
  
  In long term, we need to add a couple more notifier engines. One for
  Windows(?), one for FreeBSD(?), and one that doesn't use any platform
  specific APIs but QTimer.
  
  "KClockSkewNotifier" is not the best name. I'm open to suggestions.

TEST PLAN
  No autotests because setting time requires root privileges.

REPOSITORY
  R244 KCoreAddons

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag abandoned this revision.
zzag added a comment.


  Okay

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Problems in KWayland causes by API and ABI compatibility promises

[Vlad Zahorodnii]

Hi,

KWayland is a library that provides convenience wrappers for Wayland 
protocols. Usually, when we want to implement some Wayland protocol, 
first, we add corresponding wrappers in KWayland and after that we 
actually implement the protocol in KWin.


Unfortunately, we made a bad design choice in KWayland. It is common in 
KWayland to see abstractions over unstable protocols. We do it in the 
name of "don't repeat yourself" principle. This reduces the amount of 
duplicated code in KWin, but it also makes much more difficult to extend 
KWayland. Abstracting unstable protocols turns out to be really bad when 
the next version of an unstable protocol contains big changes, e.g. 
xdg-shell-unstable-v5 -> xdg-shell-unstable-v6. Due to the API and ABI 
compatibility promises, we can't fix the broken design of those 
wrappers. We should not try to abstract over Wayland protocols in the 
first place!


We need to fix those wrappers in order to implement the corresponding 
protocols properly in KWin (and fix a few bugs).


One option is to make KWayland unstable so we are free to do necessary 
changes to fix the wrappers, but it doesn't really go along with the 
Frameworks' policies. Another option is to move KWayland somewhere else, 
e.g. KWin or Plasma.


Alternatively, we could provide new wrappers and append a suffix to 
class names, e.g. "2" or "V2". But I don't like this approach for a 
couple of reasons. First, we are going to mix two types of versions in a 
single class name, e.g. XdgToplevelV6InterfaceV2, etc. Second, some 
protocols are not completely implemented in KWin, so we may still need 
to change wrappers in a way that may break API or ABI compatibility. 
Arguably, we just don't have to push semi-finished changes, but 
implementing everything all at once is a bit difficult and tackling one 
problem at a time is much easier.


I'm writing this email to bring problems that we currently have in 
KWayland up to discussion and find the way in which we can address them.


For what it's worth the question of moving KWayland out of Frameworks to 
somewhere else had been raised before, but the discussion got stalled... 
sort of. [1]


Cheers,
Vlad

[1] https://phabricator.kde.org/T11903

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag added a comment.


  I'll merge this patch after 5.68 is tagged.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag added a comment.


  In D27828#621821 , @apol wrote:
  
  > Maybe producing the patch that is meant to consume this will help see 
what's the use for this patch.
  
  
  D27831 

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  This can be useful for implementing out-of-tree shell surface protocols.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/generic_shell_surface_p.h
  src/server/surface_interface.cpp
  src/server/surfacerole.cpp
  src/server/surfacerole.h
  src/server/surfacerole_p.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag added a dependent revision: D27860: [server] Add some sub-surface life 
cycle signals.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  These signals can be very useful when one wants to monitor changes in a
  sub-surface tree.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27860

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

[Vlad Zahorodnii]

zzag added a dependency: D27859: [server] Expose SurfaceRole class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27860

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag added a dependent revision: D27859: [server] Expose SurfaceRole class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag added a dependency: D27828: [server] Introduce 
SurfaceInterface::boundingRect().

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new method provides a convenient way for determining the rectangle
  that bounds the given surface and all of its sub-surfaces. This can be
  very handy when determining the effective window geometry.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag updated this revision to Diff 76922.
zzag added a comment.


  Add missing @since

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27828?vs=76921=76922

REVISION DETAIL
  https://phabricator.kde.org/D27828

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> plasmawindowmanagement.cpp:363
>  
> +void PlasmaWindow::Private::appmenuChangedCallback(void *data, 
> org_kde_plasma_window *window, const char* service_name, const char* 
> object_path)
> +{

Coding style: put whitespace before `*` and keep using snake_case.

  void PlasmaWindow::Private::appmenuChangedCallback(void *data, 
org_kde_plasma_window *window, const char *service_name, const char 
*object_path)

> zzag wrote in plasma-window-management.xml:312
> and this one should be
> 
>   
>   
>   

Also, please drop "_changed".

> plasmawindowmanagement_interface.h:234
> + */
> +void setApplicationMenuPaths(const QString& service_name, const QString& 
> object_path);
> +

Coding style: put whitespace before `&` and use camelCase.

  void setApplicationMenuPaths(const QString , const QString 
);

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Thanks. Even though the patch is accepted, please do not land it yet. 
https://phabricator.kde.org/D27464#621521

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added a comment.


  Looks good to me, but please don't land without corresponding KWin patch.

INLINE COMMENTS

> plasmawindowmanagement.h:700
> +/**
> + *  TODO: Documentation.
> + **/

You missed this one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement.cpp:372
> +
> +Q_UNUSED(window);
> +}

Please move it to the top of the method and remove the semicolon.

> plasmawindowmanagement.h:526-527
>  
> +QString applicationMenuServiceName() const;
> +QString applicationMenuObjectPath() const;
> +

Please add documentation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:85
>  void setGeometry(const QRect );
> +void setApplicationMenuPaths(const QString& service, const QString& 
> object);
>  wl_resource *resourceForParent(PlasmaWindowInterface *parent, 
> wl_resource *child) const;

You forgot to fix coding style here ;-)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasma-window-management.xml:20
>  
>
>  

version="10"

> plasma-window-management.xml:87
>  
> -  
> +  
>  

version="10"

> plasma-window-management.xml:312
>  
> +
> +  

and this one should be

  
  
  

> davidedmundson wrote in plasmawindowmanagement_interface.cpp:129
> how is this 9 already?

Urgh, it seems like versioning in the plasma window management protocol is 
messed up. For some reason, `org_kde_plasma_window_management` and 
`org_kde_plasma_window` have different versions.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Re: Introducing SPDX License Headers

[Vlad Zahorodnii]

Hi,

On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote:

Does this approach sound reasonable? If anybody wants to review my conversion
tool and the license-header-to-SPDX-translations, I am happy for feedback!


+1

It appears like the SPDX markers are not used in the source code of your 
licensedigger tool ;-). It would be great to have an option or something 
that could be used to replace all instances of "Copyright (C)" with 
"SPDX-FileCopyrightText:" for consistency sake.


Cheers,
vlad

D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_tablet_interface.cpp:2
> +/
> +Copyright 2014  Martin Gräßlin 
> +

Haven't you written this autotest?

> test_tablet_interface.cpp:40
> +
> +class Tablet : public QtWayland::zwp_tablet_v2 {
> +public:

The opening has to be on its own line.

> test_tablet_interface.cpp:78-79
> +
> +QVector m_tablets;
> +QVector m_tools;
> +

Put a single space before `*` and `&`.

> test_tablet_interface.cpp:205
> +{
> +TabletSeatInterface* s = m_tabletManager->seat(m_seat);
> +QVERIFY(s);

No short names.

> test_tablet_interface.cpp:225
> +QCOMPARE(m_surfaces.count(), 3);
> +for (auto s : m_surfaces) {
> +m_tool->setCurrentSurface(s);

No `auto`.

https://community.kde.org/Policies/Library_Code_Policy#auto_Keyword

> test_tablet_interface.cpp:231
> +
> +static uint n = 0;
> +void TestTabletInterface::testInteractSimple()

What's `n`?

> tablet_interface.h:46
> +
>  class KWAYLANDSERVER_EXPORT TabletManagerInterface : public QObject
>  {

This revision seems to be incomplete. I don't see where 
`TabletManagerInterface` was introduced.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_tablet_interface.cpp:227
> +QCOMPARE(m_surfaces.count(), 3);
> +for (SurfaceInterface* surface : m_surfaces) {
> +m_tool->setCurrentSurface(surface);

Align pointers to right.

> test_tablet_interface.cpp:102-118
> +KWayland::Client::ConnectionThread* m_connection;
> +KWayland::Client::EventQueue* m_queue;
> +KWayland::Client::Compositor* m_clientCompositor;
> +KWayland::Client::Seat* m_clientSeat = nullptr;
> +
> +QThread* m_thread;
> +Display m_display;

Put a single space before `*`.

> display.h:328
>  
> +TabletManagerInterface* createTabletManagerInterface(QObject* parent = 
> nullptr);
> +

Wrong pointer alignment + missing `@since`.

> tablet_interface.cpp:53
> + const QString , const QStringList 
> ,
> + QObject* parent)
> +: QObject(parent)

Align pointers to right.

> tablet_interface.cpp:366
> +TabletManagerInterface* const q;
> +Display* const m_display;
> +QHash m_seats;

Put a single space before `*`.

  Display * const m_display;

> tablet_interface.cpp:63
> +{
> +auto *client = surface->client();
> +const auto r = d->resourceMap().value(*client);

No `auto`.

> tablet_interface.cpp:236-237
> +void zwp_tablet_seat_v2_bind_resource(Resource *resource) override {
> +for (auto iface : qAsConst(m_tablets))
> +sendTabletAdded(resource, iface);
> +

Add braces.

> tablet_interface.h:52
> +
> +TabletSeatInterface* seat(SeatInterface* seat) const;
> +

Wrong pointer alignment.

> tablet_interface.h:121
> +
> +wl_resource* resourceForSurface(SurfaceInterface* surface);
> +

This method lacks documentation. At first, I thought that it returns the 
`wl_resource` for a `wl_surface`. However, the best thing would be not to leak 
`wl_resource` to the public API at all.

> tablet_interface.h:126
> +friend class TabletToolInterface;
> +explicit TabletInterface(quint32 vendorId, quint32 productId, const 
> QString , const QStringList , QObject* parent);
> +class Private;

Put a single space before `*`.

> tablet_interface.h:137-145
> +TabletInterface* addTablet(quint32 vendorId, quint32 productId, const 
> QString , const QString , const QStringList );
> +TabletToolInterface* addTool(TabletToolInterface::Type type, quint64 
> hardwareSerial, quint64 hardwareId, const 
> QVector );
> +
> +TabletToolInterface* toolByHardwareId(quint64 hardwareId) const;
> +TabletInterface* tabletByName(const QString ) const;
> +
> +private:

Align pointers to right.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 74590.
zzag added a comment.


  s/const QWindow/QWindow/

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26503?vs=74098=74590

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27190

To: davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
zzag requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  heic-thumbnailer

REVISION DETAIL
  https://phabricator.kde.org/D27087

AFFECTED FILES
  cmake/Findlibheif.cmake
  thumbnail/CMakeLists.txt
  thumbnail/heifcreator.cpp
  thumbnail/heifcreator.h
  thumbnail/heifthumbnail.desktop

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag updated this revision to Diff 74836.
zzag added a comment.


  missing copyright stuff in Findlibheif.cmake

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27087?vs=74835=74836

BRANCH
  heic-thumbnailer

REVISION DETAIL
  https://phabricator.kde.org/D27087

AFFECTED FILES
  cmake/Findlibheif.cmake
  thumbnail/CMakeLists.txt
  thumbnail/heifcreator.cpp
  thumbnail/heifcreator.h
  thumbnail/heifthumbnail.desktop

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag added a comment.


  In D27087#604479 , @broulik wrote:
  
  > There's a Qt heif image plug in in the works in Qt. If any, we should help 
there or at least get our own into kimageformats, so Gwenview and others can 
open such files properly.
  
  
  I assume that you want to get the first image stored in a heif file and use 
it as a thumbnail. I'm not sure whether it's a good idea to completely ignore 
thumbnails that are associated with the primary image.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag added a comment.


  In D27087#604477 , @ngraham wrote:
  
  > Very cool. So QImage supports this file format now such that you could open 
the image in, say, Gwenview?
  
  
  No, as far as I know there is no `QImageIOHandler` for HEIF files. However, 
applications such as GIMP, Krita, and digiKam are able to open HEIF files.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

[Vlad Zahorodnii]

zzag abandoned this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a subscriber: davidedmundson.
zzag added a comment.
This revision is now accepted and ready to land.


  Code-wise, this change looks good. I don't have a tablet device to test this 
patch so you may want to wait for a +1 from @davidedmundson.

INLINE COMMENTS

> tablet_interface.cpp:369
> +void zwp_tablet_manager_v2_get_tablet_seat(Resource *resource, uint32_t 
> tablet_seat,
> +   struct ::wl_resource 
> *seat_resource) override {
> +SeatInterface* seat = SeatInterface::get(seat_resource);

The opening brace must be on its own line.

> tablet_interface.cpp:370
> +   struct ::wl_resource 
> *seat_resource) override {
> +SeatInterface* seat = SeatInterface::get(seat_resource);
> +TabletSeatInterface *tsi = get(seat);

SeatInterface *seat = SeatInterface::get(seat_resource);

REPOSITORY
  R127 KWayland

BRANCH
  apol/tablet-unstable-v2-1

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26960: RFC: [KWindowShadows] Check for X connection

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26960

To: broulik, #plasma, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag added a comment.


  Looks good to me. There are still many coding style issues. I suggest to run 
`clang-format` over individual files in this patch and then adjust the most 
problematic places (I don't think there are that many).
  
  You could borrow a `.clang-format` file from 
https://github.com/KDE/extra-cmake-modules/blob/master/kde-modules/clang-format.cmake.
 Just make sure that `ColumnLimit` is set to 0.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27535: Add XdgOutputV1 version 2

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27538: Registry: don't destroy the callback on globalsync

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27538

To: dvratil, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:181d4f31f5c7: Deprecate KWindowEffects::markAsDashboard() 
(authored by zzag).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26633?vs=73440=73655

REVISION DETAIL
  https://phabricator.kde.org/D26633

AFFECTED FILES
  autotests/kwindoweffectstest.cpp
  src/CMakeLists.txt
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

[Vlad Zahorodnii]

zzag marked an inline comment as done.

REPOSITORY
  R278 KWindowSystem

BRANCH
  deprecate-dashboard

REVISION DETAIL
  https://phabricator.kde.org/D26633

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

[Vlad Zahorodnii]

zzag updated this revision to Diff 73440.
zzag added a comment.


  Add `@deprecated since`

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26633?vs=73436=73440

BRANCH
  deprecate-dashboard

REVISION DETAIL
  https://phabricator.kde.org/D26633

AFFECTED FILES
  autotests/kwindoweffectstest.cpp
  src/CMakeLists.txt
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  "Support" for dashboard windows in KWin was removed long time ago.

REPOSITORY
  R278 KWindowSystem

BRANCH
  deprecate-dashboard

REVISION DETAIL
  https://phabricator.kde.org/D26633

AFFECTED FILES
  autotests/kwindoweffectstest.cpp
  src/CMakeLists.txt
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag updated this revision to Diff 73471.
zzag added a comment.


  Fix a typo.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24629?vs=73158=73471

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f5f43514af0d: [Plasma Quick] Add WaylandIntegration class 
(authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26491?vs=72969=74068#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72969=74068

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:493452e98f99: Introduce shadows API (authored by zzag).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=74055=74060

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 74055.
zzag added a comment.


  Set padding of 1 for missing borders

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73733=74055

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 74098.
zzag added a comment.


  Specify the parent object

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26503?vs=73010=74098

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73728.
zzag added a comment.


  No `noexcept`
  
  `noexcept` is a very rare thing to see in KF code so let's not deviate too 
much.

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73352=73728

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73733.
zzag added a comment.


  Update doc.

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73728=73733

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

Hi,

I would like to update our coding conventions
https://community.kde.org/Policies/Library_Code_Policy.

The auto keyword is not mentioned leading to it being a common point of
contention in reviews as we can't point to a reference.

I would like us to copy Qt's policy [1] for consistency:

Optionally, you can use the auto keyword in the following cases. If in
doubt, for example if using auto could make the code less readable, do
not use auto. Keep in mind that code is read much more often than
written.
When it avoids repetition of a type in the same statement.

auto something = new MyCustomType;
auto keyEvent = static_cast(event);
auto myList = QStringList() << QLatin1String("FooThing") <<
QLatin1String("BarThing");

When assigning iterator types.

auto it = myList.const_iterator();

In addition to the coding conventions, I would like to update the KDE
Frameworks Coding Style to include a statement about whitespace before
range-based for loop colons.

The common practice used in KDE seems to be:

for (a:b)

Cheers,
vlad

[1] https://wiki.qt.io/Coding_Conventions#auto_Keyword

Re: Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

On 1/17/20 12:46 AM, Kai Uwe Broulik wrote:
> It provides useful visual information.
> 
> auto foo = bar();
> auto baz = 

I don't think that you should use auto in either case since it's not
clear what type foo and baz have.

Cheers,
Vlad

Re: Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

On 1/17/20 12:27 AM, David Faure wrote:
> On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote:
>> I would like us to copy Qt's policy [1] for consistency:
> 
> OK, please do.

Done. Please notice that I did not annotate auto keywords with '*'. Once
we have an official policy, we can fix coding style in those code samples.

Cheers,
Vlad

Re: Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

On 1/16/20 7:46 PM, Kai Uwe Broulik wrote:
> for "auto" I think we should always annotate it with const, *, and/or & 
> where appropriate:
> 
> auto *something = new MyCustomType;
> auto *keyEvent = static_cast(event);
> const auto myList = QStringList({QLatin1String("FooThing"), 
> QLatin1String("BarThing")});
> auto  = foo[bar];

I also prefer to do that. On the other hand, I'd like our code to be as
close as possible to Qt's code in terms of coding style. Perhaps, this
discussion must be moved to the Qt/Development mailing list unless the
question of annotating auto with const/*/& had been raised before there.

Cheers,
Vlad

Re: Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

On 1/16/20 7:29 PM, Vlad Zahorodnii wrote:

> The common practice used in KDE seems to be:
> 
> for (a:b)

Alright, it looks like we all agree on this one, so I'm going to update
the Frameworks Coding Style.

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag updated this revision to Diff 73158.
zzag added a comment.


  Build with older versions of glibc. See D26553 


REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24629?vs=72993=73158

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag retitled this revision from "Introduce shadow API" to "Introduce shadows 
API".

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26457

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73352.
zzag added a comment.


  - Make KWindowShadow a QObject subclass (for memory management)
  - Clarify that it is okay to call destroy() after window() had been removed
  - Check whether QWindow has QPlatformWindow associated with it

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=72880=73352

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwindowshadow.h:201
> For KWindowEffects I did put window tracking into the wayland plugin and it 
> improved the readability of all the client code considerably.
> 
> I would recommend looking at doing so, especially as we could probably even 
> share the implementation that kwayland-integration windoweffects.cpp has.

Could you please point me to that code?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26457

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kwindowshadow.h:201
> kwayland-integration
> 
> 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb 
> 
> src/windowsystem/windoweffects.cpp

Oh, that one... Yeah, perhaps it will be worth to handle surface 
creation/destruction in kwayland-integration.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26457

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new API provides a platform-independent way for setting drop-shadows
  on a window. X11 and Wayland details are completely hidden from the users
  of the new API, but you still need to be cautious about QPAs that destroy
  the underlying native resources(e.g. wl_surface) upon a window becoming
  hidden. It is highly recommended to install an event filter that reacts
  to events of type QEvent::PlatformSurface.

REPOSITORY
  R278 KWindowSystem

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag updated this revision to Diff 72880.
zzag added a comment.


  Remove pointless default member initializers in KWindowShadowPrivate.

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=72862=72880

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag added a task: T12496: Shadows API in KWindowSystem.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26457

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in kwindowshadow.h:201
> Oh, that one... Yeah, perhaps it will be worth to handle surface 
> creation/destruction in kwayland-integration.

Okay, looks like it's do-able. However, we would need to call 
`QWidget::winId()` in `Breeze::ShadowHelper::installShadows()` to create a 
`QWindow`...

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26457

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag reclaimed this revision.
zzag added a comment.


  D25962  adds one usage of 
(K)ClockSkewNotifier in KWin.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  It allows us to get rid of DialogShadows::plasmaShellInterface().

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag added a task: T12496: Shadows API in KWindowSystem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72968.
zzag added a comment.


  Update logs.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72967=72968

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72969.
zzag added a comment.


  Rename a function.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72968=72969

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag added a comment.


  The KWin patch has landed. Can we proceed now?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72993.
zzag added a comment.


  Rename signal.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24629?vs=67889=72993

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

TEST PLAN
  Run `qmlscene tests/dialog.qml`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag retitled this revision from "[WIP] [Dialog Shadows] Port to KWindowSystem 
shadows API" to "[Dialog Shadows] Port to KWindowSystem shadows API".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns