D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ppeter requested review of this revision.

REVISION SUMMARY
  The current string I think have some issues, for example:
  
  This is a text file:
  
ABC DEF GHI JKL
  
  When I selected "DEF GHI", I expect this message:
  
Words 2/4, Chars 6/12
  
  but the current message shows:
  
Words 4/2, Chars 12/6
  
  This is a fix of this issue.

REPOSITORY
  R39 KTextEditor

BRANCH
  fixStatusBarString (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19798

AFFECTED FILES
  src/view/katestatusbar.cpp

To: ppeter
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter added a comment.


  The reason why I just change `%1/%2` to `%2/%1` not swap `wordsInDocument` 
and `wordsInSelection`, because I want to notify
  translators about this change (or those current translation may have some 
issue when applied this fix.)
  
  Sorry for my poor English :(

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19798

To: ppeter
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter added a reviewer: Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19798

To: ppeter, #kate
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter updated this revision to Diff 53985.
ppeter added a comment.


  Fix the newline issue.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19798?vs=53984=53985

BRANCH
  fixStatusBarString (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19798

AFFECTED FILES
  src/view/katestatusbar.cpp

To: ppeter
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter added a comment.


  Good idea.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19798

To: ppeter, #kate
Cc: pino, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter updated this revision to Diff 53989.
ppeter added a comment.


  Use i18nc instead of swaping order.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19798?vs=53985=53989

BRANCH
  fixStatusBarString (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19798

AFFECTED FILES
  src/view/katestatusbar.cpp

To: ppeter, #kate
Cc: pino, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

2019-03-16 Thread Yi-Jyun Pan 
ppeter added a comment.


  Done, thanks! :D

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19798

To: ppeter, #kate
Cc: pino, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan 
ppeter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ppeter requested review of this revision.

REPOSITORY
  R292 KUnitConversion

BRANCH
  Pb_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22521

AFFECTED FILES
  src/binary_data.cpp

To: ppeter
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan 
ppeter updated this revision to Diff 61949.
ppeter added a comment.


  Remove the useless `{'

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22521?vs=61947=61949

BRANCH
  Pb_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22521

AFFECTED FILES
  src/binary_data.cpp

To: ppeter
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan 
ppeter added a reviewer: Frameworks.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D22521

To: ppeter, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-08 Thread Yi-Jyun Pan 
ppeter added inline comments.

INLINE COMMENTS

> executablefileopendialog.cpp:58
> +
> +if (mode == OnlyExecute) {
> +connect(executeButton, ::clicked, 
> [=]{done(ExecuteFile);});

if (mode == OnlyExecute)
connect(executeButton, ...)
  else if (mode == OpenAsExecute)
...

looks better :)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns