Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-11-15 Thread Gleb Popov 


> On Nov. 16, 2016, 2:37 a.m., Christoph Feck wrote:
> > Any hope that this could have fixed the cause for bug 345871?

Can't comment on that, since I've been developing on FreeBSD, and our UDisks2 
implementation doesn't handle partitions properly yet.


- Gleb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100864
---


On Oct. 31, 2016, 1:49 p.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> ---
> 
> (Updated Oct. 31, 2016, 1:49 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> This patch replaces uses of `typedef QList ByteArrayList;` with 
> built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
> requires 5.5.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udisks2/udisks2.h 0abf915 
>   src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
>   src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
>   src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 
> 
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
> 
> 
> Testing
> ---
> 
> Compiles, mounting works.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-11-15 Thread Christoph Feck 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100864
---



Any hope that this could have fixed the cause for bug 345871?

- Christoph Feck


On Oct. 31, 2016, 11:49 a.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> ---
> 
> (Updated Oct. 31, 2016, 11:49 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> This patch replaces uses of `typedef QList ByteArrayList;` with 
> built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
> requires 5.5.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udisks2/udisks2.h 0abf915 
>   src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
>   src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
>   src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 
> 
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
> 
> 
> Testing
> ---
> 
> Compiles, mounting works.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-10-31 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/
---

(Updated Oct. 31, 2016, 10:49 a.m.)


Status
--

This change has been marked as submitted.


Review request for Solid.


Changes
---

Submitted with commit 5bb0525e3d119473950f7e727730b7f088f58620 by Gleb Popov to 
branch master.


Repository: solid


Description
---

This patch replaces uses of `typedef QList ByteArrayList;` with 
built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
requires 5.5.


Diffs
-

  src/solid/devices/backends/udisks2/udisks2.h 0abf915 
  src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
  src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 

Diff: https://git.reviewboard.kde.org/r/129277/diff/


Testing
---

Compiles, mounting works.


Thanks,

Gleb Popov

Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-10-28 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100374
---


Fix it, then Ship it!





src/solid/devices/backends/udisks2/udisksmanager.cpp (line 51)


Remove


+1 makes sense

- Aleix Pol Gonzalez


On Oct. 28, 2016, 6:59 p.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> ---
> 
> (Updated Oct. 28, 2016, 6:59 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> This patch replaces uses of `typedef QList ByteArrayList;` with 
> built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
> requires 5.5.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udisks2/udisks2.h 0abf915 
>   src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
>   src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
>   src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 
> 
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
> 
> 
> Testing
> ---
> 
> Compiles, mounting works.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Review Request 129277: Use built-in QByteArrayList type instead of our own.

2016-10-28 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/
---

Review request for Solid.


Repository: solid


Description
---

This patch replaces uses of `typedef QList ByteArrayList;` with 
built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
requires 5.5.


Diffs
-

  src/solid/devices/backends/udisks2/udisks2.h 0abf915 
  src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
  src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 

Diff: https://git.reviewboard.kde.org/r/129277/diff/


Testing
---

Compiles, mounting works.


Thanks,

Gleb Popov