Re: Calligra fails on MSVC

[Andrius da Costa Ribas]

I can't check it right now, but we shouldn't be linking to a plugin
(calligra_shape_spreadsheet target having calligrasheetspart
in target_link_libraries). Other libs are SHARED instead of MODULE.

--


Em seg., 8 de mar. de 2021 às 06:01, Dag 
escreveu:

> Hi,
> I don't have windows to test on so any pointers are very much appreciated!
>
> Linking fails, see:
> https://binary-factory.kde.org/job/Calligra_Nightly_win64/1101/console
> with error:
> 22:05:44  bin\calligrasheetspart.dll : fatal error LNK1107: invalid or
> corrupt file: cannot read at 0x3A8
>
> So, it seems it to want to link to the dll file:
> bin\calligrasheetspart.dll
> According to some ms forum that is not legal?
>
> This is from the log:
>
> 22:05:44  LINK Pass 1: command
> "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe
>
> /nologo
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\calligra_shape_spreadsheet_autogen\mocs_compilation.cpp.obj
>
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\TablePageManager.cpp.obj
>
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\TableShape.cpp.obj
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\TableTool.cpp.obj
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\TableShapeFactory.cpp.obj
>
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\TableToolFactory.cpp.obj
>
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\SheetsEditor.cpp.obj
>
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\ToolHeaders.cpp.obj
> sheets\shape\CMakeFiles\calligra_shape_spreadsheet.dir\ScreenConversions.cpp.obj
>
> /out:bin\calligra_shape_spreadsheet.dll
> /implib:lib\calligra_shape_spreadsheet.lib
> /pdb:bin\calligra_shape_spreadsheet.pdb /dll /version:0.0 /machine:x64
> /debug /INCREMENTAL lib\calligrasheetscommon.lib
> bin\calligrasheetspart.dll
> lib\calligrasheetsodf.lib lib\komain.lib lib\kowidgets.lib
> lib\kotextlayout.lib lib\kotext.lib lib\flake.lib lib\pigmentcms.lib
> lib\kowidgetutils.lib lib\koodf.lib lib\kostore.lib lib\kundo2.lib
> lib\koversion.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5KDELibs4Support.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5KIOFileWidgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Bookmarks.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Solid.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Notifications.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5UnitConversion.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Parts.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5TextWidgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\kdewin.lib uuid.lib
> ole32.lib user32.lib netapi32.lib userenv.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\kdewin-qt-static.lib
> advapi32.lib shell32.lib ws2_32.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5SonnetUi.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5KIOWidgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Completion.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5KIOGui.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5KIOCore.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Crash.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5WindowSystem.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5JobWidgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Concurrent.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5XmlGui.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5PrintSupport.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5IconThemes.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5ConfigWidgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5WidgetsAddons.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Codecs.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5ConfigGui.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Auth.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5AuthCore.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5GuiAddons.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5Service.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5I18n.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Xml.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5CoreAddons.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5ConfigCore.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5DBus.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\KF5ItemViews.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Widgets.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Gui.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Network.lib
> C:\Craft\BinaryFactory\windows-msvc2019_64-cl\lib\Qt5Core.lib kernel32.lib
> user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
> 

Re: A new tier1 for icontheme.rcc handling

[Andrius da Costa Ribas]

+1 for the name kiconsupport as Ben suggested.


Em 19 de jan de 2018 21:49, "Ben Cooksley"  escreveu:

On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth  wrote:
> Hi everyone.

Hi Hannah,

>
> Only some few of you will be aware of KIconThemes ability to load binary
> icon themes automagically.
>
> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48
>
> The code looks for a icontheme.rcc and sets it as default theme.
>
> On Windows and Mac we rely on that code as it is more feasible to
> install that one
> file with an single application installer. This code also ensures that
> the theme path is set,
> which on Linux is done by the qpa.
>
> The problem with the current solution is that it only allows one single
> theme and is in a tier3
> framework.
>
> I recently talked to David Faure and we agreed that it would be best to
> put those few line of code into a new
> created tier1 framework, with an explicit call instead of the magical
> loading.
>
> The explicit call would allow to specify the theme loaded and we  can
> still maintain the current behaviour by putting a call to
> that new framework into KIconThemes.
>
> Now we need a name for that tier1 framework and ideally someone who
> steps up for the once in a lifetime chance to become
> maintainer of a glorious new tier1 framework.

While I can't be the maintainer for the framework, to get the ball
rolling may I suggest the name of 'kiconsupport' for the Framework?

>
> Cheers,
>
> Hannah
>

Cheers,
Ben

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127728/
---

(Updated Feb. 4, 2017, 11:09 a.m.)


Status
--

This change has been discarded.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag.


Diffs
-

  src/CMakeLists.txt 529b786 

Diff: https://git.reviewboard.kde.org/r/127728/diff/


Testing
---

Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for 
"lib/indexerconfig.cpp"). No further testing done.


Thanks,

Andrius da Costa Ribas

Re: Review Request 115192: Fix building 32bit target on 64bit machine

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115192/
---

(Updated Sept. 15, 2016, 11:18 a.m.)


Status
--

This change has been discarded.


Review request for kdewin and Plasma.


Repository: kdeplasma-addons


Description
---

with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with 
THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in 
render_with_SSE2_explicitly_enabled.cpp, but this source is only built when 
using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is 
defined, though, in global.h, since this is not a 64bit target.


Diffs
-

  wallpapers/mandelbrot/renderthread.cpp c1b5c60 

Diff: https://git.reviewboard.kde.org/r/115192/diff/


Testing
---

Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 
(it's a x86_64 processor)


Thanks,

Andrius da Costa Ribas

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127728/#review95441
---



ping?

- Andrius da Costa Ribas


On Abril 23, 2016, 4:44 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127728/
> ---
> 
> (Updated Abril 23, 2016, 4:44 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 529b786 
> 
> Diff: https://git.reviewboard.kde.org/r/127728/diff/
> 
> 
> Testing
> ---
> 
> Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for 
> "lib/indexerconfig.cpp"). No further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127727/
---

(Updated April 24, 2016, 12:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Changes
---

Submitted with commit 0475e40d65036cb46f84740f4195d239030f13f1 by Andrius da 
Costa Ribas to branch master.


Repository: baloo


Description
---

This fixes compilation on Windows, where QT_LSTAT is not available.


Diffs
-

  src/engine/idutils.h 7c4f898 

Diff: https://git.reviewboard.kde.org/r/127727/diff/


Testing
---

Fixes compiling error on MSVC 2015. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127726: Fix EXPORT usage.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127726/
---

(Updated April 24, 2016, 12:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Changes
---

Submitted with commit 07e3fe88f35eae9c5fdbbc408b9d222a060f9641 by Andrius da 
Costa Ribas to branch master.


Repository: baloo


Description
---

The export macro should not be used in the namespace declaration.


Diffs
-

  src/engine/global.h aba5495 

Diff: https://git.reviewboard.kde.org/r/127726/diff/


Testing
---

Fixes compiling error on MSVC 2015. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

[Andrius da Costa Ribas]

> On Abril 23, 2016, 11:40 p.m., Michael Pyne wrote:
> > This is a duplicate of RR 127598, which is about to get marked as 'change 
> > then commit' (I missed that it was updated a few days ago when my email was 
> > futzy :( ).

Thanks! I'm discarding this one, then.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/#review94797
---


On Abril 23, 2016, 11:54 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127729/
> ---
> 
> (Updated Abril 23, 2016, 11:54 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Although there is currently no problem on building kcoreaddons, when building 
> okular (and possibly other apps) the compiler gets confused when it reaches 
> std::numeric_limits::max() as  is also included and it 
> defines a 'max' macro.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 3c9ff00 
> 
> Diff: https://git.reviewboard.kde.org/r/127729/diff/
> 
> 
> Testing
> ---
> 
> Okular is buildable on MSVC after this patch. No further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/
---

(Updated Abril 23, 2016, 11:54 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and kdewin.


Repository: kcoreaddons


Description
---

Although there is currently no problem on building kcoreaddons, when building 
okular (and possibly other apps) the compiler gets confused when it reaches 
std::numeric_limits::max() as  is also included and it defines 
a 'max' macro.


Diffs
-

  src/lib/util/kuser.h 3c9ff00 

Diff: https://git.reviewboard.kde.org/r/127729/diff/


Testing
---

Okular is buildable on MSVC after this patch. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/
---

Review request for KDE Frameworks and kdewin.


Repository: kcoreaddons


Description
---

Although there is currently no problem on building kcoreaddons, when building 
okular (and possibly other apps) the compiler gets confused when it reaches 
std::numeric_limits::max() as  is also included and it defines 
a 'max' macro.


Diffs
-

  src/lib/util/kuser.h 3c9ff00 

Diff: https://git.reviewboard.kde.org/r/127729/diff/


Testing
---

Okular is buildable on MSVC after this patch. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127728/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

Build targets under dbus subdirectory regardless of BUILD_KINOTIFY flag.


Diffs
-

  src/CMakeLists.txt 529b786 

Diff: https://git.reviewboard.kde.org/r/127728/diff/


Testing
---

Fixes compiling problem on MSVC 2015 (missing generated "maininterface.h" for 
"lib/indexerconfig.cpp"). No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127726: Fix EXPORT usage.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127726/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

The export macro should not be used in the namespace declaration.


Diffs
-

  src/engine/global.h aba5495 

Diff: https://git.reviewboard.kde.org/r/127726/diff/


Testing
---

Fixes compiling error on MSVC 2015. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127727/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

This fixes compilation on Windows, where QT_LSTAT is not available.


Diffs
-

  src/engine/idutils.h 7c4f898 

Diff: https://git.reviewboard.kde.org/r/127727/diff/


Testing
---

Fixes compiling error on MSVC 2015. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

(Updated April 23, 2016, 8:21 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
---

Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da 
Costa Ribas to branch master.


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


File Attachments


Native Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127709: Fix exports and avoid using sources already linked on tests.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127709/
---

(Updated April 23, 2016, 3:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Dolphin and kdewin.


Changes
---

Submitted with commit c6d4cae26343b3f9f390374b70668fde428853f0 by Andrius da 
Costa Ribas to branch master.


Repository: dolphin


Description
---

Rework from scratch on Review Request - 123270


Diffs
-

  src/CMakeLists.txt 48a7c1d 
  src/kitemviews/kitemset.h 31fe1d2 
  src/tests/CMakeLists.txt 22a8b48 
  src/views/versioncontrol/kversioncontrolplugin.h 85835e0 

Diff: https://git.reviewboard.kde.org/r/127709/diff/


Testing
---

I'm currently unable to run ctest, but this fixes all inconsistent linkage 
errors and warnings on Windows (MSVC 2015 64-bit).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127715: Remove KMess

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127715/
---

(Updated Abril 23, 2016, 2:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin.


Repository: emerge


Description
---

There is neither KMess nor Windows Live Messenger anymore.


Diffs
-

  portage/kdeapps/kmess/kmess.py 4e3fcf4 

Diff: https://git.reviewboard.kde.org/r/127715/diff/


Testing
---

not applicable.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127715: Remove KMess

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127715/
---

Review request for kdewin.


Repository: emerge


Description
---

There is neither KMess nor Windows Live Messenger anymore.


Diffs
-

  portage/kdeapps/kmess/kmess.py 4e3fcf4 

Diff: https://git.reviewboard.kde.org/r/127715/diff/


Testing
---

not applicable.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

(Updated Abril 22, 2016, 7:55 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

Added screenshots (note: Icoutils version doesn't support all icon formats).


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


File Attachments (updated)


Native Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127714: Enable ICO and EXE thumbnails again.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

Review request for KDE Frameworks and kdewin.


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 114476: Fix MSBuild of glib

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114476/
---

(Updated Abril 22, 2016, 7:42 p.m.)


Status
--

This change has been discarded.


Review request for kdewin.


Repository: emerge


Description
---

The patch currently being applied do not match the sources of 2.36.3. Also 
libintl headers and lib were not found so our include and lib dir needs to be 
added to %INCLUDE% and %LIB%, and /p:useenv=true needs to be passed to msbuild 
to make use of these environment variables.


Diffs
-

  portage/testing/glib-src/glib-2.36.3-20131215.diff PRE-CREATION 
  portage/testing/glib-src/glib-src-2.29.14.py a1f3cbd 

Diff: https://git.reviewboard.kde.org/r/114476/diff/


Testing
---

Builds and installs fine for MSVC.
For Intel Compiler, I'm figuring out a way to correctly determine the value in 
"/PlatformToolset=..." according to compiler version. Also the dependency 
libffi-src needs some fixes first.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127709: Fix exports and avoid using sources already linked on tests.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127709/
---

Review request for Dolphin and kdewin.


Repository: dolphin


Description
---

Rework from scratch on Review Request - 123270


Diffs
-

  src/CMakeLists.txt 48a7c1d 
  src/kitemviews/kitemset.h 31fe1d2 
  src/tests/CMakeLists.txt 22a8b48 
  src/views/versioncontrol/kversioncontrolplugin.h 85835e0 

Diff: https://git.reviewboard.kde.org/r/127709/diff/


Testing
---

I'm currently unable to run ctest, but this fixes all inconsistent linkage 
errors and warnings on Windows (MSVC 2015 64-bit).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 123270: Fix exports and avoid using sources already linked on tests.

[Andrius da Costa Ribas]

FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1343) : failure location
FAIL!  : KFileItemModelTest::testNameRoleGroupsWithExpandedItems() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1411) : failure location
FAIL!  : KFileItemModelTest::testInconsistentModel() 'itemsInsertedSpy.wait()' 
returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1448) : failure location
FAIL!  : KFileItemModelTest::testChangeRolesForFilteredItems() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1504) : failure location
PASS   : KFileItemModelTest::testChangeSortRoleWhileFiltering()
FAIL!  : KFileItemModelTest::testRefreshFilteredItems() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1597) : failure location
FAIL!  : KFileItemModelTest::testCollapseFolderWhileLoading() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1657) : failure location
FAIL!  : KFileItemModelTest::testCreateMimeData() 'itemsInsertedSpy.wait()' 
returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1630) : failure location
FAIL!  : KFileItemModelTest::testDeleteFileMoreThanOnce() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location
PASS   : KFileItemModelTest::cleanupTestCase()
Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted
***** Finished testing of KFileItemModelTest *


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/
---

(Updated April 17, 2016, 7:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin and Phonon.


Changes
---

Submitted with commit 92adeaf2851a1f94ea3b3cdfdf3e6b27394d2a53 by Andrius da 
Costa Ribas to branch master.


Repository: phonon


Description
---

s_pulseActive is used inside PulseSupport::isUsable but is declared under 
HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this 
method to always return false when we don't HAVE_PULSEAUDIO.


Diffs
-

  phonon/pulsesupport.cpp dd79204 

Diff: https://git.reviewboard.kde.org/r/127672/diff/


Testing
---

It builds on windows after this patch, no further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/
---

Review request for kdewin and Phonon.


Repository: phonon


Description
---

s_pulseActive is used inside PulseSupport::isUsable but is declared under 
HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this 
method to always return false when we don't HAVE_PULSEAUDIO.


Diffs
-

  phonon/pulsesupport.cpp dd79204 

Diff: https://git.reviewboard.kde.org/r/127672/diff/


Testing
---

It builds on windows after this patch, no further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: [kde-windows] [Bug 357240] New: emerging KCoreAddons fails by CMake Internal Error on Win 8.1 x64

[Andrius da Costa Ribas]

I've got those too, is there any known solution?

2015-12-28 1:39 GMT-02:00 Shunsuke Shimizu via KDE Bugzilla <
bugzilla_nore...@kde.org>:

> https://bugs.kde.org/show_bug.cgi?id=357240
>
> Bug ID: 357240
>Summary: emerging KCoreAddons fails by CMake Internal Error on
> Win 8.1 x64
>Product: kde-windows
>Version: unspecified
>   Platform: MS Windows
> OS: MS Windows
> Status: UNCONFIRMED
>   Severity: normal
>   Priority: NOR
>  Component: buildsystem
>   Assignee: kde-windows@kde.org
>   Reporter: gr...@grafi.jp
>
> I'm using Windows 8.1 x64.
> I checkout the master of emerge, and make the build target x64 by editing
> kdesettings.ini (other parts are kept unchanged).
> I tried on two machines and the result was same.
>
> Reproducible: Always
>
> Steps to Reproduce:
> 1. checkout the master branch of emerge
> 2. make the target x64
> 3. emerge kcoreaddons (I encountered to the error when emerging
> frameworks,
> after qt is emerged)
>
>
> Actual Results:
> PS R:\> emerge kcoreaddons
> emerge debug: buildAction: all
> emerge debug: packageName: ['kcoreaddons']
> emerge debug: buildType: RelWithDebInfo
> emerge debug: buildTests: False
>
> 
> emerge debug: fetching [git]kde:kcoreaddons|master|
> Already up-to-date.
> Already on 'master'
> Your branch is up-to-date with 'origin/master'.
> Already up-to-date.
> Already on 'master'
> Your branch is up-to-date with 'origin/master'.
> entering:
> r:\build\frameworks\kcoreaddons\work\mingw-w64-RelWithDebInfo-master
> cleaning
> r:\build\frameworks\kcoreaddons\work\mingw-w64-RelWithDebInfo-master
> entering:
> r:\build\frameworks\kcoreaddons\work\mingw-w64-RelWithDebInfo-master
> emerge debug: cmake -G "MinGW Makefiles"  -DCMAKE_INSTALL_PREFIX="r:/"
> -DCMAKE_PREFIX_PATH="r:/" -DCMAKE_BUILD_TYPE=RelW
> ithDebInfo "q:\kcoreaddons"
> -- The C compiler identification is GNU 5.2.0
> -- The CXX compiler identification is GNU 5.2.0
> -- Check for working C compiler: R:/mingw64/bin/gcc.exe
> -- Check for working C compiler: R:/mingw64/bin/gcc.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler: R:/mingw64/bin/g++.exe
> -- Check for working CXX compiler: R:/mingw64/bin/g++.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> --
>
> -- Looking for __GLIBC__
> -- Looking for __GLIBC__ - not found
> -- Could NOT find FAM (missing:  FAM_INCLUDE_DIR FAM_LIBRARIES)
> -- Looking for include file sys/inotify.h
> -- Looking for include file sys/inotify.h - not found
> -- Looking for include files sys/types.h, sys/mman.h
> -- Looking for include files sys/types.h, sys/mman.h - not found
> -- Looking for getgrouplist
> -- Looking for getgrouplist - not found
> -- Performing Test COMPILER_HAS_DEPRECATED_ATTR
> -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
> -- Found SharedMimeInfo: R:/bin/update-mime-database.exe (found suitable
> version "0.71", minimum required is "0.70")
> -- Performing Test HAVE_QFILESYSTEMWATCHER
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> CMake Internal Error (please report a bug):
>   Missing cmGeneratorTarget instance!
>
> Note: The stack could not be examined because backtrace is not supported.
>
>
> -- Performing Test HAVE_QFILESYSTEMWATCHER - Success
> --
> -- The following OPTIONAL packages have been found:
>
>  * SharedMimeInfo (required version >= 0.70) , A database of common MIME
> types
> ,  hared-mime-info/>
>Allows KDE applications to determine file types
>
> -- The following REQUIRED packages have been found:
>
>  * ECM (required version >= 5.17.0) , Extra CMake Modules. ,
>  odules>
>  * Qt5Core
>  * Qt5 (required version >= 5.3.0)
>
> -- The following OPTIONAL 

Re: Problem using Vc with CMake 3.0 and kf5

[Andrius da Costa Ribas]

I'm not sure if I understood the issue. If we need to pass the -I
parameters to vc_compile_for_all_implementations, then something like
https://git.reviewboard.kde.org/r/115110/diff/1/ might work.
 Em 23/05/2015 09:07, Aleix Pol aleix...@kde.org escreveu:

 On Sat, May 23, 2015 at 11:51 AM, Boudewijn Rempt b...@valdyas.org
 wrote:
  Sorry for the extensive cross-posting in advance, please when replying,
 do a
  reply-all.
 
  Just so everyone is on the same page: Vc is a template library that
 makes it
  easy to build vectorized code using a single source file. Krita uses Vc
 to
  optimize blending colors, creating masks and much more. Krita uses the
 most
  recent Vc release, 0.7.4: http://code.compeng.uni-frankfurt.de/news/27
 
  We're currently porting Krita to Qt5 and KF5 and the way KF5 and Vc
 handle
  include directories is a big roadblock for us:
  https://git.reviewboard.kde.org/r/123179/ .
 
  In a nutshell: Vc builds many different object files from single cpp
 file.
  It does this by creating a custom command for each target vectorization
  extension. To do that, it needs to access the contents of
  INCLUDE_DIRECTORIES, like this (in VcMacros.cmake:
 
 http://code.compeng.uni-frankfurt.de/projects/vc/repository/entry/cmake/VcMacros.cmake?rev=0.7
 )
 
 get_directory_property(_inc INCLUDE_DIRECTORIES)
 foreach(_i ${_inc})
list(APPEND _flags -I${_i})
 endforeach()
 
  In the end the command is generated like this:
 
   add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_out}
  COMMAND ${CMAKE_CXX_COMPILER} ${_flags} ${_extra_flags}
  -DVC_IMPL=${_impl}
  ${_outfile_flag}${_out}
  ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  MAIN_DEPENDENCY
 ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  IMPLICIT_DEPENDS CXX
  ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  COMMENT Building CXX object ${_out}
  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
  VERBATIM
  )
  KF5 uses cmake generator expressions to derive the include directories
 from
  the target_link_libraries lines. This means that when we try to build our
  per-extensions object files we get this:
 
 
 
  [  0%] Building CXX object
  KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
  cd /home/boud/kde/build/calligra/libs/pigment  /usr/bin/c++
 -std=c++0x
  -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts
  -Wformat-security -Wno-long-long -Wpointer-arith -Wundef
 -Wnon-virtual-dtor
  -Woverloaded-virtual -Werror=return-type
 -D__GNUC_UBUNTU_VERSION__=0xf040a
  -Wabi -fabi-version=0 -ffp-contract=fast -mtune=core2 -fPIC
  -I/home/boud/kde/src/calligra/interfaces -I/home/boud/kde/build/calligra
  -I/home/boud/kde/src/calligra -I/home/boud/kde/src/calligra/libs/version
  -I/home/boud/kde/build/calligra/libs/version
  -I/home/boud/kde/src/calligra/libs/koplugin
  -I/home/boud/kde/src/calligra/libs/version
  -I/home/boud/kde/build/calligra/libs/version
  -I/home/boud/kde/src/calligra/libs/pigment
  -I/home/boud/kde/src/calligra/libs/pigment/compositeops
  -I/home/boud/kde/src/calligra/libs/pigment/resources -I/usr/include
  -I/usr/include -I/usr/include/OpenEXR -I/usr/include -mavx -DVC_IMPL=AVX
 -c
  -oKoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
 
 /home/boud/kde/src/calligra/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.cpp
 
 
 /home/boud/kde/src/calligra/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.cpp:22:19:
  fatal error: QString: No such file or directory
   #include QString
 ^
  compilation terminated.
  libs/pigment/CMakeFiles/pigmentcms.dir/build.make:72: recipe for
 target
  'libs/pigment/KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o' failed
 
  On other words, INCLUDE_DIRECTORIES is empty, there's no Qt5, no Kf5 to
 be
  found.
 
  If we manually set include directories like this:
 
  if (HAVE_VC)
  message(. ${KDE4_INCLUDES})
  include_directories(${KDE4_INCLUDES} ${Qt5Core_INCLUDE_DIRS}
  ${Qt5Gui_INCLUDE_DIRS} ${Qt5Xml_INCLUDE_DIRS} ${PIGMENT_INCLUDES}
  ${Boost_INCLUDE_DIR})
  endif()
 
  We end up with the entire include line for the contents of KDE4_INCLUDES
  ($TARGET_PROPERTY:KF5::KDELibs4Support,INTERFACE_INCLUDE_DIRECTORIES)
  expanded to a string with quotes around it:
 
 [  0%] Building CXX object
 KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
  cd /home/boud/kde/build/calligra/libs/pigment  /usr/bin/c++
 -std=c++0x
  -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts
  -Wformat-security -Wno-long-long -Wpointer-arith -Wundef
 -Wnon-virtual-dtor
  -Woverloaded-virtual -Werror=return-type
 -D__GNUC_UBUNTU_VERSION__=0xf040a
  -Wabi -fabi-version=0 -ffp-contract=fast -mtune=core2 -fPIC
  -I/home/boud/kde/src/calligra/interfaces -I/home/boud/kde/build/calligra
  -I/home/boud/kde/src/calligra -I/home/boud/kde/src/calligra/libs/version
  

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

[Andrius da Costa Ribas]

 On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
  lib/konq/src/konq_historyentry.h, line 57
  https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
 
  const ref, no?
 
 Andrius da Costa Ribas wrote:
 before I try to fix the pending issues: what are we going to decide?
 
 - Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
 - Should it apply to MSVC-only or should it be ifdef-free?
 
 David Faure wrote:
 Clearly this is not KDE specific. Any QListcustom type requires this on 
 MSVC, right? Then I would strongly suggest a solution within Qt itself, *if* 
 a central solution such as a macro is indeed needed. But thinking about it, a 
 one-line dummy impl that returns 0 doesn't really seem worth a macro to me.
 I.e. why not do like qitemselectionmodel.h does, everywhere where this is 
 needed?
 
 But I am still surprised that Qt only needs this in qitemselectionmodel.h
 Take this for instance:
 src/corelib/io/qstorageinfo.h:static QListQStorageInfo 
 mountedVolumes();
 Why doesn't this require a qHash(QStorageInfo)?
 If I explicitly call toSet() on such a list, I do get a compile error (on 
 Linux) due to the missing qHash implementation. 
 http://www.davidfaure.fr/2015/storageview.diff
 So MSVC doesn't *always* instanciate the toSet() method, but only in some 
 cases?
 Or are we looking at an old MSVC issue which doesn't exist anymore with 
 more recent MSVC versions? i.e. did you try removing this block (in 
 konq_historyentry.h) altogether to check it's still needed?

There is some historic reference here: 
http://marc.info/?l=kde-core-develm=113069150408826w=2

MSVC 2013 still has the same beahviour.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121080/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
 not available. Implement it instead.
 
 
 Diffs
 -
 
   lib/konq/src/konq_historyentry.h de34d6b 
 
 Diff: https://git.reviewboard.kde.org/r/121080/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121079: Fix building dolphin tests on MSVC

[Andrius da Costa Ribas]

 On Fev. 12, 2015, 10:54 p.m., Albert Astals Cid wrote:
  Patch doesn't apply, please rebase

superseded by RR https://git.reviewboard.kde.org/r/123270/, discarding this one.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/#review75951
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121079/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 MSVC complains about missing symbols from their respective moc files on 
 linking step.
 
 
 Diffs
 -
 
   dolphin/src/tests/CMakeLists.txt 60f6517 
 
 Diff: https://git.reviewboard.kde.org/r/121079/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121079: Fix building dolphin tests on MSVC

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/
---

(Updated Abril 19, 2015, 3:13 p.m.)


Status
--

This change has been discarded.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

MSVC complains about missing symbols from their respective moc files on linking 
step.


Diffs
-

  dolphin/src/tests/CMakeLists.txt 60f6517 

Diff: https://git.reviewboard.kde.org/r/121079/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115110/
---

(Updated April 16, 2015, 11:50 a.m.)


Status
--

This change has been discarded.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

This was needed because the generated object files are not generated as part of 
the shared lib target, having not defined the -DMAKE__LIB that is 
automatically defined by CMake otherwise.


Diffs
-

  CMakeLists.txt 62f8e79 
  krita/image/CMakeLists.txt eefaf61 
  libs/pigment/CMakeLists.txt 0073377 

Diff: https://git.reviewboard.kde.org/r/115110/diff/


Testing
---

Tested building on both MSVC and MinGW


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 123270: Fix exports and avoid using sources already linked on tests.

[Andrius da Costa Ribas]

 FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1411) : failure location
FAIL!  : KFileItemModelTest::testInconsistentModel() 'itemsInsertedSpy.wait()' 
returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1448) : failure location
FAIL!  : KFileItemModelTest::testChangeRolesForFilteredItems() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1504) : failure location
PASS   : KFileItemModelTest::testChangeSortRoleWhileFiltering()
FAIL!  : KFileItemModelTest::testRefreshFilteredItems() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1597) : failure location
FAIL!  : KFileItemModelTest::testCollapseFolderWhileLoading() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1657) : failure location
FAIL!  : KFileItemModelTest::testCreateMimeData() 'itemsInsertedSpy.wait()' 
returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1630) : failure location
FAIL!  : KFileItemModelTest::testDeleteFileMoreThanOnce() 
'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location
PASS   : KFileItemModelTest::cleanupTestCase()
Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted
* Finished testing of KFileItemModelTest *


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

[Andrius da Costa Ribas]

 On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
  lib/konq/src/konq_historyentry.h, line 57
  https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
 
  const ref, no?

before I try to fix the pending issues: what are we going to decide?

- Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
- Should it apply to MSVC-only or should it be ifdef-free?


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121080/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
 not available. Implement it instead.
 
 
 Diffs
 -
 
   lib/konq/src/konq_historyentry.h de34d6b 
 
 Diff: https://git.reviewboard.kde.org/r/121080/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

[Andrius da Costa Ribas]

 On Out. 15, 2014, 4:31 p.m., Boudewijn Rempt wrote:
  I'm sorry for the late reply, this just slipped past me somehow. I guess it 
  isn't needed for my own builds... Is it still necessary for you, or should 
  we discard this patch?
 
 Andrius da Costa Ribas wrote:
 It's quite a while since I've built last time ... Only MinGW can't build 
 without this, iirc.

I don't have a MinGW setup anymore (and don't intend to any soon), may I 
discard this?


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115110/#review68470
---


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115110/
 ---
 
 (Updated Jan. 19, 2014, 3:42 a.m.)
 
 
 Review request for Calligra and kdewin.
 
 
 Repository: calligra
 
 
 Description
 ---
 
 This was needed because the generated object files are not generated as part 
 of the shared lib target, having not defined the -DMAKE__LIB that is 
 automatically defined by CMake otherwise.
 
 
 Diffs
 -
 
   CMakeLists.txt 62f8e79 
   krita/image/CMakeLists.txt eefaf61 
   libs/pigment/CMakeLists.txt 0073377 
 
 Diff: https://git.reviewboard.kde.org/r/115110/diff/
 
 
 Testing
 ---
 
 Tested building on both MSVC and MinGW
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120648: Encode the URIs which end up in DTD files

[Andrius da Costa Ribas]

 On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote:
  src/CMakeLists.txt, line 20
  https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
 
  It's already committed (but there's been a long time since I hadn't 
  build anything), but now I see that DocBookXML4_DTD_DIR is used only inside 
  the else(NOT WIN32) part, is this what's been intended? Also, this 
  doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows 
  path V: becomes V%3A and xmllint fails to recognise it as an absolute 
  path (see below) and CMake would fail to install to such location. (maybe 
  we should prepend it with file:// ?)
  
  
  
  
  file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
   warning: failed to load external
  
  ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
  %DocBookDTD;
 
 Luigi Toscano wrote:
 - DocBookXML4_DTD_DIR is properly touched both for non WIN32 (line 4) and 
 WIN32 (lines 4 and 20). The WIN32 logic is a bit complicated, but basically 
 it rewrites again the generated ${_custom_dtd_kdex} file using the DTD path 
 which is knows during the installation. Or something like that.
 - Oh, that's the feedback I was looking for. Can you please copy the 
 exact content of the path to docbookx.dtd as referenced into kdedbx45.dtd?

!ENTITY % DocBookDTD   PUBLIC
  -//OASIS//DTD DocBook XML V4.5//EN
  v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd 
%DocBookDTD;


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120648: Encode the URIs which end up in DTD files

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---



cmake/uriencode.cmake (line 15)
https://git.reviewboard.kde.org/r/120648/#comment53670

I've tried changing this to:

execute_process(COMMAND perl -MURI::Escape -e print 
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)

it works here, but I'm not sure if it'd be the proper fix.


- Andrius da Costa Ribas


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120648: Encode the URIs which end up in DTD files

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---



src/CMakeLists.txt (line 20)
https://git.reviewboard.kde.org/r/120648/#comment53667

It's already committed (but there's been a long time since I hadn't build 
anything), but now I see that DocBookXML4_DTD_DIR is used only inside the 
else(NOT WIN32) part, is this what's been intended? Also, this doesn't work 
when the original DocBookXML4_DTD_DIR is an absolute Windows path V: becomes 
V%3A and xmllint fails to recognise it as an absolute path (see below) and 
CMake would fail to install to such location. (maybe we should prepend it with 
file:// ?)


file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
 warning: failed to load external

///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
%DocBookDTD;


- Andrius da Costa Ribas


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121077/
---

(Updated feb. 12, 2015, 10:56 p.m.)


Status
--

This change has been discarded.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

A simple cmake check to avoid errors on MSVC.


Diffs
-

  dolphin/src/CMakeLists.txt c074908 

Diff: https://git.reviewboard.kde.org/r/121077/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121081: QT_WA

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/
---

(Updated Feb. 12, 2015, 10:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

QT_WA is not available on Qt5. We also only use the Unicode version, anyways.


Diffs
-

  lib/konq/src/konq_copytomenu.cpp 7f97c12 

Diff: https://git.reviewboard.kde.org/r/121081/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121992: Add Battery energyFull and energyFullDesign

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121992/#review73796
---



src/solid/devices/backends/win/winbattery.h
https://git.reviewboard.kde.org/r/121992/#comment51337

Your patch doesn't contain the implementation of these in winbattery.cpp


- Andrius da Costa Ribas


On Jan. 11, 2015, 4:41 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121992/
 ---
 
 (Updated Jan. 11, 2015, 4:41 p.m.)
 
 
 Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl.
 
 
 Repository: solid
 
 
 Description
 ---
 
 To properly calculate cumulative values we need to know the actual Wh values 
 of the batteries (deducing it from the current energy and percentage or 
 capacity produces significant rounding errors).
 
 
 Diffs
 -
 
   src/solid/devices/frontend/battery.h 4c3c3f7 
   src/solid/devices/frontend/battery.cpp 7b95fc9 
   src/solid/devices/ifaces/battery.h 055af62 
   src/solid/devices/backends/win/winbattery.h 5dfe7c7 
   src/solid/devices/backends/win/winbattery.cpp 95dbbb3 
   src/solid/devices/backends/iokit/iokitbattery.h ccf6b20 
   src/solid/devices/backends/upower/upowerbattery.h 0f0c7b6 
   src/solid/devices/backends/upower/upowerbattery.cpp 7c1689e 
   src/solid/devices/backends/hal/halbattery.h 0d91009 
   src/solid/devices/backends/hal/halbattery.cpp 24dde4b 
   src/solid/devices/backends/fakehw/fakebattery.h 3066f24 
   src/solid/devices/backends/fakehw/fakebattery.cpp f90cb76 
 
 Diff: https://git.reviewboard.kde.org/r/121992/diff/
 
 
 Testing
 ---
 
 energyFull and energyFullDesign report correct values on UPower here. I 
 implemented it for HAL and Windows as well (and IOKit stubs) but I cannot 
 test these, hence adding kdewin and kde-mac groups. Also, we should really 
 add Q_DECL_OVERRIDE all over the place since adding new methods at 5 
 different places is quite error-prone.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120878: Remove unused header

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/
---

(Updated Jan. 10, 2015, 4:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: krunner


Description
---

Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
exporting but not defining RunnerScript.


Diffs
-

  src/abstractrunner.cpp 4da0394 

Diff: https://git.reviewboard.kde.org/r/120878/diff/


Testing
---

Tested building using MSVC 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120878: Remove unused header

[Andrius da Costa Ribas]

 On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote:
  I should have asked, do you have commit access or do you need someone to 
  merge this?

I do have commit access, but I am okay if anyone commits it too. I just had 
little time to do so.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/#review73573
---


On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120878/
 ---
 
 (Updated Out. 29, 2014, 2:27 a.m.)
 
 
 Review request for KDE Frameworks, kdewin and Plasma.
 
 
 Repository: krunner
 
 
 Description
 ---
 
 Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
 exporting but not defining RunnerScript.
 
 
 Diffs
 -
 
   src/abstractrunner.cpp 4da0394 
 
 Diff: https://git.reviewboard.kde.org/r/120878/diff/
 
 
 Testing
 ---
 
 Tested building using MSVC 64bit
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121075/
---

(Updated Dec. 6, 2014, 8:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kbookmarks


Description
---

Konqueror references KBookmarkOwner::FutureBookmark, which is not properly 
exported, causing the build to fail.


Diffs
-

  src/kbookmarkowner.h 4d6fe0b 

Diff: https://git.reviewboard.kde.org/r/121075/diff/


Testing
---

It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along 
other patches I'm sending to review today). Kdebase-apps is still not very 
functional, though (missing icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Kate / KDevelop Sprint

[Andrius da Costa Ribas]

As of now kf5-kate builds fine on windows (plugin loading in kf5 still
needs some love,  though, so lots of functionality are missing in kate UI,
as well as in other apps). KF5 modularity is indeed a step towards
single-app installers, by reducing the dependency bloatwarehell, and Kate
is indeed a very good use case.


Em 26/11/2014 14:29, Doug dmcgarr...@optonline.net escreveu:

 On 11/22/2014 05:39 PM, Andrew Udvare wrote:


  On 2014-11-22, at 07:50, John Layt jl...@kde.org wrote:
 I really can't emphasise enough how good an idea this is. As someone
 who spends a lot of time on Windows and Mac machines I know how poor
 the alternative text editors are and how much I miss Kate when I can't
 install it. We could win many Win/Mac developers as users if we had an
 easy to deploy package on both platforms, and it would be a good
 'gateway drug' to them making use of KF5 in their own code. Having a
 small targeted goal like deploying Kate would be also give the Win and
 Mac teams clear achievable goals to work towards in getting KF5 ready
 with active feedback from the Kate community.


 I agree on both points. Both Mac and Windows lack a simple installer, and
 in reality sometimes all I want on OS X is Kate (a proper KDevelop would be
 nice too).

 I use Kate on OS X almost daily building out of MacPorts. Most issues
 seem to be related to OS integration and retina (high DPI) support. Isn't
 this a thing with KDE on other platforms as a whole? This would not only
 fix Mac, but it would also fix how KDE functions on a high DPI screen (on
 other platforms besides OS X).

 Andrew

 ___
 Kde-windows mailing list
 Kde-windows@kde.org
 https://mail.kde.org/mailman/listinfo/kde-windows

  KDE for Windows lets you install Kate. You don't have to install the KDE
 desktop, just Kate and , if you like, Find Files.

 --doug
 ___
 Kde-windows mailing list
 Kde-windows@kde.org
 https://mail.kde.org/mailman/listinfo/kde-windows

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121078: Fix exports.

[Andrius da Costa Ribas]

 On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote:
  Actually it's still broken: I didn't notice because I did not build tests:
  
   
  /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46:
   error: expected initializer before ‘:’ token
  
  The line being 
  
  class KONQ_TESTS_EXPORT KonquerorApplication : public KApplication
 
 Luca Beltrame wrote:
 And finally fixed.

I'm sorry, I'll pay more attention next time.
I had to revert my tree to not include the other commits (of the other review 
requests I sent the same day) and had left it out when doing so. I'm not sure 
what happened regarding the KONQ_TESTS_EXPORT typo, since the build went ok (no 
clean build?)

I don't have a linux build set up to double-check, so I rely on the review 
request.


@Luca: Thanks for the prompt fix, and sorry again!


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/#review70681
---


On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121078/
 ---
 
 (Updated Nov. 20, 2014, 3:29 a.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 Use CMake's generate_export_header whenever possible, and fix some 
 inconsistent exports.
 Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for 
 kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use).
 
 
 Diffs
 -
 
   dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
   dolphin/src/views/dolphinitemlistview.h 7fd72e5 
   dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
   dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
   dolphin/src/views/viewmodecontroller.h 9ea717a 
   dolphin/src/views/viewproperties.h d3ea428 
   keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
   keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
   keditbookmarks/main.cpp bc64193 
   konqueror/client/kfmclient.cpp 276452b 
   konqueror/src/CMakeLists.txt 6831c88 
   konqueror/src/konq_statusbarmessagelabel.h a115d39 
   konqueror/src/konqmain.cpp 7a73231 
   konqueror/src/konqprivate_export.h 2dec78b 
   dolphin/src/libdolphin_export.h ff0f125 
   dolphin/src/main.cpp 91d32a0 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
   dolphin/src/CMakeLists.txt c074908 
   dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
   dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
   dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
   dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
   dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
   dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
   dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
   dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
   dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
   dolphin/src/kitemviews/kitemlistview.h cc0754f 
   dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
   dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
   dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
   dolphin/src/kitemviews/kstandarditem.h 59190bf 
   dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
   dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
   dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
   dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
   dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
   dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
   dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
   dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
   dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
   dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
   dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
   dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
   dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
   dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 
 
 Diff: https://git.reviewboard.kde.org/r/121078/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
---

(Updated Nov. 21, 2014, 10:44 p.m.)


Review request for kde-workspace and kdewin.


Repository: oxygen


Description
---

These files currently use  

```
__attribute__((visibility(...)))
```

which doesn't work on MSVC.


Diffs (updated)
-

  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 
  liboxygen/CMakeLists.txt 69b7bd2 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
---

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
---

(Updated Nov. 21, 2014, 10:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and kdewin.


Repository: oxygen


Description
---

These files currently use  

```
__attribute__((visibility(...)))
```

which doesn't work on MSVC.


Diffs
-

  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 
  liboxygen/CMakeLists.txt 69b7bd2 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
---

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

[Andrius da Costa Ribas]

 On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote:
  This breaks the kde4 build as ECM is not being used there and 
  generate_export_header is not available without ECM.

generate_export_header isn't in ECM, but in cmake itself 
(http://www.cmake.org/cmake/help/v3.0/module/GenerateExportHeader.html). Does 
kde4 required cmake version not support it? Should I revert this commit?


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/#review70761
---


On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121083/
 ---
 
 (Updated Nov. 21, 2014, 10:47 p.m.)
 
 
 Review request for kde-workspace and kdewin.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 These files currently use  
 
 ```
 __attribute__((visibility(...)))
 ```
 
 which doesn't work on MSVC.
 
 
 Diffs
 -
 
   liboxygen/oxygen_config_export.h 02ea29d 
   liboxygen/oxygen_export.h b8877a0 
   liboxygen/CMakeLists.txt 69b7bd2 
 
 Diff: https://git.reviewboard.kde.org/r/121083/diff/
 
 
 Testing
 ---
 
 Builds with msvc 2013 64bit
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121076: Do not require KF5::Su on Windows

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 20, 2014, 3:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121078: Fix exports.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/
---

(Updated Nov. 20, 2014, 3:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Use CMake's generate_export_header whenever possible, and fix some inconsistent 
exports.
Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit 
apps (removing kdemacros.h where KDE_EXPORT was being in use).


Diffs
-

  dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
  dolphin/src/views/dolphinitemlistview.h 7fd72e5 
  dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
  dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
  dolphin/src/views/viewmodecontroller.h 9ea717a 
  dolphin/src/views/viewproperties.h d3ea428 
  keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
  keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
  keditbookmarks/main.cpp bc64193 
  konqueror/client/kfmclient.cpp 276452b 
  konqueror/src/CMakeLists.txt 6831c88 
  konqueror/src/konq_statusbarmessagelabel.h a115d39 
  konqueror/src/konqmain.cpp 7a73231 
  konqueror/src/konqprivate_export.h 2dec78b 
  dolphin/src/libdolphin_export.h ff0f125 
  dolphin/src/main.cpp 91d32a0 
  dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
  dolphin/src/CMakeLists.txt c074908 
  dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
  dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
  dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
  dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
  dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
  dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
  dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
  dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
  dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
  dolphin/src/kitemviews/kitemlistview.h cc0754f 
  dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
  dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
  dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
  dolphin/src/kitemviews/kstandarditem.h 59190bf 
  dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
  dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
  dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
  dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
  dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
  dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
  dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
  dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
  dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
  dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
  dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
  dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 

Diff: https://git.reviewboard.kde.org/r/121078/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121083: Replace manual export files with CMake's generate_export_header

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
---

Review request for kde-workspace and kdewin.


Repository: oxygen


Description
---

These files currently use  

```
__attribute__((visibility(...)))
```

which doesn't work on MSVC.


Diffs
-

  liboxygen/CMakeLists.txt 69b7bd2 
  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
---

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121075/
---

Review request for KDE Frameworks and kdewin.


Repository: kbookmarks


Description
---

Konqueror references KBookmarkOwner::FutureBookmark, which is not properly 
exported, causing the build to fail.


Diffs
-

  src/kbookmarkowner.h 4d6fe0b 

Diff: https://git.reviewboard.kde.org/r/121075/diff/


Testing
---

It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along 
other patches I'm sending to review today). Kdebase-apps is still not very 
functional, though (missing icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121076: Do not require KF5::Su on Windows

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

Review request for KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121076: Do not require KF5::Su on Windows

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 8, 2014, 10:14 p.m.)


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121077: Check before using -Wno-deprecated-declarations.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121077/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

A simple cmake check to avoid errors on MSVC.


Diffs
-

  dolphin/src/CMakeLists.txt c074908 

Diff: https://git.reviewboard.kde.org/r/121077/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121078: Fix exports.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Use CMake's generate_export_header whenever possible, and fix some inconsistent 
exports.
Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit 
apps (removing kdemacros.h where KDE_EXPORT was being in use).


Diffs
-

  dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
  dolphin/src/views/dolphinitemlistview.h 7fd72e5 
  dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
  dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
  dolphin/src/views/viewmodecontroller.h 9ea717a 
  dolphin/src/views/viewproperties.h d3ea428 
  keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
  keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
  keditbookmarks/main.cpp bc64193 
  konqueror/client/kfmclient.cpp 276452b 
  konqueror/src/CMakeLists.txt 6831c88 
  konqueror/src/konq_statusbarmessagelabel.h a115d39 
  konqueror/src/konqmain.cpp 7a73231 
  konqueror/src/konqprivate_export.h 2dec78b 
  dolphin/src/libdolphin_export.h ff0f125 
  dolphin/src/main.cpp 91d32a0 
  dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
  dolphin/src/CMakeLists.txt c074908 
  dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
  dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
  dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
  dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
  dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
  dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
  dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
  dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
  dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
  dolphin/src/kitemviews/kitemlistview.h cc0754f 
  dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
  dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
  dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
  dolphin/src/kitemviews/kstandarditem.h 59190bf 
  dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
  dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
  dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
  dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
  dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
  dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
  dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
  dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
  dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
  dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
  dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
  dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 

Diff: https://git.reviewboard.kde.org/r/121078/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121079: Fix building dolphin tests on MSVC

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

MSVC complains about missing symbols from their respective moc files on linking 
step.


Diffs
-

  dolphin/src/tests/CMakeLists.txt 60f6517 

Diff: https://git.reviewboard.kde.org/r/121079/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not 
available. Implement it instead.


Diffs
-

  lib/konq/src/konq_historyentry.h de34d6b 

Diff: https://git.reviewboard.kde.org/r/121080/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121081: QT_WA

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

QT_WA is not available on Qt5. We also only use the Unicode version, anyways.


Diffs
-

  lib/konq/src/konq_copytomenu.cpp 7f97c12 

Diff: https://git.reviewboard.kde.org/r/121081/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/
---

(Updated Out. 30, 2014, 1:35 a.m.)


Review request for kdewin and Plasma.


Changes
---

Fix coding style.


Repository: plasma-framework


Description
---

MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as 
a compile-time const expression (error C2051: case expression not constant)


Diffs (updated)
-

  src/plasma/private/framesvg_helpers.h 5b96cd5 

Diff: https://git.reviewboard.kde.org/r/120877/diff/


Testing
---

Builds with MSVC 2013 64bit.

framesvg related tests pass, other unrelated tests still fail.

Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master
  Start  1: plasma-dialogqmltest
 1/10 Test  #1: plasma-dialogqmltest ...***Failed1.15 sec
  Start  2: plasma-fallbackpackagetest
 2/10 Test  #2: plasma-fallbackpackagetest .   Passed0.16 sec
  Start  3: plasma-packagestructuretest
 3/10 Test  #3: plasma-packagestructuretest ***Failed0.19 sec
  Start  4: plasma-packageurlinterceptortest
 4/10 Test  #4: plasma-packageurlinterceptortest ...   Passed0.12 sec
  Start  5: plasma-pluginloadertest
 5/10 Test  #5: plasma-pluginloadertest    Passed1.44 sec
  Start  6: plasma-framesvgtest
 6/10 Test  #6: plasma-framesvgtest    Passed0.64 sec
  Start  7: coronatest
 7/10 Test  #7: coronatest .***Failed0.16 sec
  Start  8: plasma-storagetest
 8/10 Test  #8: plasma-storagetest .***Failed0.12 sec
  Start  9: plasma-sortfiltermodeltest
 9/10 Test  #9: plasma-sortfiltermodeltest .   Passed0.14 sec
  Start 10: i18ndcheck
Could not find executable SH-NOTFOUND
Looked in the following places:
SH-NOTFOUND
SH-NOTFOUND.exe
Release/SH-NOTFOUND
Release/SH-NOTFOUND.exe
Debug/SH-NOTFOUND
Debug/SH-NOTFOUND.exe
MinSizeRel/SH-NOTFOUND
MinSizeRel/SH-NOTFOUND.exe
RelWithDebInfo/SH-NOTFOUND
RelWithDebInfo/SH-NOTFOUND.exe
Deployment/SH-NOTFOUND
Deployment/SH-NOTFOUND.exe
Development/SH-NOTFOUND
Development/SH-NOTFOUND.exe
Unable to find executable: SH-NOTFOUND
10/10 Test #10: i18ndcheck .***Not Run   0.00 sec

50% tests passed, 5 tests failed out of 10


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120816: Add Pushover Notification option

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120816/
---

(Updated Oct. 29, 2014, 1:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin.


Repository: emerge


Description
---

This patch adds Pushover (http://pushover.net) notification option.


Diffs
-

  bin/Notifier/Backends/Pushover.py PRE-CREATION 
  kdesettings.ini c8cb835 

Diff: https://git.reviewboard.kde.org/r/120816/diff/


Testing
---

Tested using my phone.


File Attachments


pushover.jpg
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/b159a680-e496-496d-b78c-97559bf02911__pushover.jpg


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120877: Convert switch statements to if/else due to MSVC limitation

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/
---

Review request for kdewin and Plasma.


Repository: plasma-framework


Description
---

MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as 
a compile-time const expression (error C2051: case expression not constant)


Diffs
-

  src/plasma/private/framesvg_helpers.h 5b96cd5 

Diff: https://git.reviewboard.kde.org/r/120877/diff/


Testing
---

Builds with MSVC 2013 64bit.

framesvg related tests pass, other unrelated tests still fail.

Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master
  Start  1: plasma-dialogqmltest
 1/10 Test  #1: plasma-dialogqmltest ...***Failed1.15 sec
  Start  2: plasma-fallbackpackagetest
 2/10 Test  #2: plasma-fallbackpackagetest .   Passed0.16 sec
  Start  3: plasma-packagestructuretest
 3/10 Test  #3: plasma-packagestructuretest ***Failed0.19 sec
  Start  4: plasma-packageurlinterceptortest
 4/10 Test  #4: plasma-packageurlinterceptortest ...   Passed0.12 sec
  Start  5: plasma-pluginloadertest
 5/10 Test  #5: plasma-pluginloadertest    Passed1.44 sec
  Start  6: plasma-framesvgtest
 6/10 Test  #6: plasma-framesvgtest    Passed0.64 sec
  Start  7: coronatest
 7/10 Test  #7: coronatest .***Failed0.16 sec
  Start  8: plasma-storagetest
 8/10 Test  #8: plasma-storagetest .***Failed0.12 sec
  Start  9: plasma-sortfiltermodeltest
 9/10 Test  #9: plasma-sortfiltermodeltest .   Passed0.14 sec
  Start 10: i18ndcheck
Could not find executable SH-NOTFOUND
Looked in the following places:
SH-NOTFOUND
SH-NOTFOUND.exe
Release/SH-NOTFOUND
Release/SH-NOTFOUND.exe
Debug/SH-NOTFOUND
Debug/SH-NOTFOUND.exe
MinSizeRel/SH-NOTFOUND
MinSizeRel/SH-NOTFOUND.exe
RelWithDebInfo/SH-NOTFOUND
RelWithDebInfo/SH-NOTFOUND.exe
Deployment/SH-NOTFOUND
Deployment/SH-NOTFOUND.exe
Development/SH-NOTFOUND
Development/SH-NOTFOUND.exe
Unable to find executable: SH-NOTFOUND
10/10 Test #10: i18ndcheck .***Not Run   0.00 sec

50% tests passed, 5 tests failed out of 10


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120816: Add Pushover Notification option

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120816/
---

Review request for kdewin.


Repository: emerge


Description
---

This patch adds Pushover (http://pushover.net) notification option.


Diffs
-

  bin/Notifier/Backends/Pushover.py PRE-CREATION 
  kdesettings.ini c8cb835 

Diff: https://git.reviewboard.kde.org/r/120816/diff/


Testing
---

Tested using my phone.


File Attachments


pushover.jpg
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/b159a680-e496-496d-b78c-97559bf02911__pushover.jpg


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

[Andrius da Costa Ribas]

 On Out. 15, 2014, 4:31 p.m., Boudewijn Rempt wrote:
  I'm sorry for the late reply, this just slipped past me somehow. I guess it 
  isn't needed for my own builds... Is it still necessary for you, or should 
  we discard this patch?

It's quite a while since I've built last time ... Only MinGW can't build 
without this, iirc.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115110/#review68470
---


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115110/
 ---
 
 (Updated Jan. 19, 2014, 3:42 a.m.)
 
 
 Review request for Calligra and kdewin.
 
 
 Repository: calligra
 
 
 Description
 ---
 
 This was needed because the generated object files are not generated as part 
 of the shared lib target, having not defined the -DMAKE__LIB that is 
 automatically defined by CMake otherwise.
 
 
 Diffs
 -
 
   CMakeLists.txt 62f8e79 
   krita/image/CMakeLists.txt eefaf61 
   libs/pigment/CMakeLists.txt 0073377 
 
 Diff: https://git.reviewboard.kde.org/r/115110/diff/
 
 
 Testing
 ---
 
 Tested building on both MSVC and MinGW
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---

(Updated April 26, 2014, 10:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kjsembed


Description
---

Currently kjsembed CMake file tries to install both 
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
allowed in a case-insensitive filesystem, causing the install step to fail on 
Windows.


Diffs
-

  src/kjsembed/CMakeLists.txt e0ab74c 

Diff: https://git.reviewboard.kde.org/r/117012/diff/


Testing
---

Tested using MSVC 2013


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117011: Use bin/../share on Windows as a workaround

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/
---

(Updated April 24, 2014, 9:57 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and kdewin.


Repository: kdoctools


Description
---

This is a workaround for kdoctools for the same problem discussed in review 
#115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share.


Diffs
-

  src/xslt.cpp db67599 

Diff: https://git.reviewboard.kde.org/r/117011/diff/


Testing
---

Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this 
patch (KJsEmbed still has an unrelated problem on install step).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

[Andrius da Costa Ribas]

 On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
  Until now we had no problems with the data installed to bin/../share  and 
  this setup would make it impossible to have multiple independent  kde 
  setups on one system.
 
 Alexander Richardson wrote:
 I know. The problem is QStandardPaths with 
 QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I 
 think %APPDATA%. KF5 based KDE software won't work otherwise since it can't 
 find the data. I think the better way of fixing this is patching Qt, but for 
 now this works.
 
 Patrick Spendrin wrote:
 Can you keep that patch locally for now and we try and come up with a 
 patch for Qt instead? We cannot restrict ourselves at that point I think.
 
 Alexander Richardson wrote:
 Sure no problem. I'll drop this request
 
 David Faure wrote:
 So what do you recommend instead, for QStandardPaths? Checking some 
 non-standard environment variable? or?
 
 Alexander Richardson wrote:
 I would go for the environment variable. Something like 
 QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default 
 dirs.
 
 Would also be useful for other cases: e.g. in the okteta unit tests I set 
 XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there 
 is QFINDTESTDATA, but that won't work in that case).
 
 It would also be nice if there were some cross-platform solution like 
 QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString 
 path) to inject (like KStandardDirs::addResourceDir).
 
 Patrick von Reth wrote:
 I don't like the idea of using the env var as this would require the user 
 to setup the variables or a kde process to set them up.
 We also would get an undefined behaviour if the env var is not set.
 I think kde is not the only qt project ported to windows wich uses the 
 bin/../share location on windows, so why not only add this path with a low 
 priority to QStrandardpathes?

 
 David Faure wrote:
 I agree that the env var would be quite inconvenient, which is why I was 
 dubious about that approach.
 
 A method to add paths wouldn't help either (how would all apps do it?)
 
 bin/../share means go up one level from the location of the executable 
 and enter share? I thought Windows apps didn't use a bin/ dir actually, but 
 were rather in the toplevel?
 Anyhow I'd be fine with that, especially if you can find any 
 documentation of this outside of kde (to explain the reasoning in the Qt 
 change request).
 
 Andrius da Costa Ribas wrote:
 As far as I can see:
 
 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, 
 $PREFIX/share etc... and PREFIX is not standard on windows (those apps 
 normally don't use %PROGRAMFILES%)
  * Other autoconf-based apps and libs also follow this structure
  * even those using %PROGRAMFILES% also follow this structure (e.g. for 
 GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside 
 it)
 2 - Most CMake-based apps also follow a similar pattern, relative to 
 $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a 
 different directory structure
  * Cmake itself is distributed in this kind of structure 
 (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip)
 
 I think those can explain the reasoning needed for a Qt request.
 
 David Faure wrote:
 Yes, a single monolithic can somehow find out about its own PREFIX (e.g. 
 by writing it into the registry at install time, right? Or indeed from the 
 path where the .exe is being started, simply).
 
 But the issue here is what if you install several apps (and possibly 
 several frameworks), and they need to find each other's stuff...


That's the exact same situation of using XDG_DATA_DIRS on *nix. For KDE-Windows 
we install all packages into the same prefix for a given KDE set up.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/#review47983
---


On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115210/
 ---
 
 (Updated Jan. 22, 2014, 2:53 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
 
 Otherwise QStandardPaths will always fail with e.g. GenericDataLocation
 
 
 Diffs
 -
 
   kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 
 
 Diff: https://git.reviewboard.kde.org/r/115210/diff/
 
 
 Testing
 ---
 
 
 Thanks

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

[Andrius da Costa Ribas]

 On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
  Until now we had no problems with the data installed to bin/../share  and 
  this setup would make it impossible to have multiple independent  kde 
  setups on one system.
 
 Alexander Richardson wrote:
 I know. The problem is QStandardPaths with 
 QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I 
 think %APPDATA%. KF5 based KDE software won't work otherwise since it can't 
 find the data. I think the better way of fixing this is patching Qt, but for 
 now this works.
 
 Patrick Spendrin wrote:
 Can you keep that patch locally for now and we try and come up with a 
 patch for Qt instead? We cannot restrict ourselves at that point I think.
 
 Alexander Richardson wrote:
 Sure no problem. I'll drop this request
 
 David Faure wrote:
 So what do you recommend instead, for QStandardPaths? Checking some 
 non-standard environment variable? or?
 
 Alexander Richardson wrote:
 I would go for the environment variable. Something like 
 QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default 
 dirs.
 
 Would also be useful for other cases: e.g. in the okteta unit tests I set 
 XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there 
 is QFINDTESTDATA, but that won't work in that case).
 
 It would also be nice if there were some cross-platform solution like 
 QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString 
 path) to inject (like KStandardDirs::addResourceDir).
 
 Patrick von Reth wrote:
 I don't like the idea of using the env var as this would require the user 
 to setup the variables or a kde process to set them up.
 We also would get an undefined behaviour if the env var is not set.
 I think kde is not the only qt project ported to windows wich uses the 
 bin/../share location on windows, so why not only add this path with a low 
 priority to QStrandardpathes?

 
 David Faure wrote:
 I agree that the env var would be quite inconvenient, which is why I was 
 dubious about that approach.
 
 A method to add paths wouldn't help either (how would all apps do it?)
 
 bin/../share means go up one level from the location of the executable 
 and enter share? I thought Windows apps didn't use a bin/ dir actually, but 
 were rather in the toplevel?
 Anyhow I'd be fine with that, especially if you can find any 
 documentation of this outside of kde (to explain the reasoning in the Qt 
 change request).

As far as I can see:

1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, 
$PREFIX/share etc... and PREFIX is not standard on windows (those apps normally 
don't use %PROGRAMFILES%)
 * Other autoconf-based apps and libs also follow this structure
 * even those using %PROGRAMFILES% also follow this structure (e.g. for GIMP 2, 
$PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside it)
2 - Most CMake-based apps also follow a similar pattern, relative to 
$CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a different 
directory structure
 * Cmake itself is distributed in this kind of structure 
(http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip)

I think those can explain the reasoning needed for a Qt request.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/#review47983
---


On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115210/
 ---
 
 (Updated Jan. 22, 2014, 2:53 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
 
 Otherwise QStandardPaths will always fail with e.g. GenericDataLocation
 
 
 Diffs
 -
 
   kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 
 
 Diff: https://git.reviewboard.kde.org/r/115210/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---

(Updated April 21, 2014, 1:59 a.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

place all includes under include/KJsEmbed (instead of having another kjsembed 
subdir) and remove 
$INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed from 
target_include_directories.


Summary (updated)
-

Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead 
of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed 
camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed]


Repository: kjsembed


Description
---

Currently kjsembed CMake file tries to install both 
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
allowed in a case-insensitive filesystem, causing the install step to fail on 
Windows.


Diffs (updated)
-

  src/kjsembed/CMakeLists.txt e0ab74c 

Diff: https://git.reviewboard.kde.org/r/117012/diff/


Testing
---

Tested using MSVC 2013


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review55788
---


I've been short of time these days, I'll update the patch by next weekend.

- Andrius da Costa Ribas


On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117012/
 ---
 
 (Updated March 24, 2014, 1:33 a.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kjsembed
 
 
 Description
 ---
 
 Currently kjsembed CMake file tries to install both 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
 allowed in a case-insensitive filesystem, causing the install step to fail on 
 Windows.
 
 
 Diffs
 -
 
   src/kjsembed/CMakeLists.txt e0ab74c 
 
 Diff: https://git.reviewboard.kde.org/r/117012/diff/
 
 
 Testing
 ---
 
 Tested using MSVC 2013
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: The future of KDE Development on Windows

[Andrius da Costa Ribas]

Hello,

Sticking to the items pointed by Aleix, in my humble opinion:
- We want KDE on Windows to keep being a distribution? Should it be a
development platform or a site to download installers?
*We are both a distribution (installer) and a development platform (emerge)
and I think we should keep being both. I've been playing with kde-windows
development for a while, mostly in my small-free-spare-time to fix one or
another bug or feature in some applications of my interest. We're a very
small team and only a small part of this team is involved in packaging (I'm
not). Being a small team makes it difficult to keep a good documentation on
techbase to help newcomers find their way with the development environment
(we have techbase and userbase pages but they are rarely updated). I've
never played with KDE development outside of Windows, but once when I tried
building KDE software with BSD Ports I ran into problems very similar to
what people use to report about emerge, so I think IMHO it's more a matter
of getting used to the tool (sure emerge has bugs to be fixed but they're
not a major problem). The other problem I see is that we don't have CI,
sometimes it's tiresome to fix the very same bugs again and again, because
they're not reproducible in gcc/linux and we don't have a proper
documentation on what to avoid for better cross-platform (e.g. templates
vs. forward declarations, exports/imports)

- Do we want to focus on applications?
*Yes, we've been always focused on applications, plasma-desktop works more
like a proof-of-concept built isn't really usable.

- What's the Plasma role in KDE Windows?
*As a user I install kde-workspace mostly because of oxygen :) If plasma
itself could get more love I think it could get into a more usable state
:). Particularly I'd like to write a wrapper to KDE launcher to make it a
DeskBand (like ClassicStart8 and similar to Chrome's launcher) since
windows 8 and 8.1 don't have a good start menu (people say it'll be back on
win9) I'm just trying to find more free time to work on it.

- What frameworks to we want supported on Windows? [1]
*Most of them, except those Unix specific like KPty. For X11 specific
stuff, if there is a Wayland way, there is probably also a Windows way too.

- How has Windows changed since 4.0 release
Certainly more mature and stable. I use lots of the base apps at work
(Kate, dolphin, konqueror) and I'm also starting to use more complex ones
like Kexi.
KF5 modularity will help addressing the issue of having to install tons of
dependencies for a single app, but since windows is not like a distro that
includes common packages we will still have some overhead because of those
extra packages.

On 04/03/2014 03:41 AM, Jaroslaw Staniek wrote:
/snip/

 I find people expect native installers on windows, be it exe or msi. If
 you ask I'd look at priorities to see what apps to maintain on Windows,
 look what type of app is otherwise unavailable on Windows/Mac. Krita or
 Kexi comes as example. For apps that exist on Windows/Mac already and are
 hugely popular, like web browsers or text editors (Notepad++ which is
 FOSS), porting KDE equivalent (Kate) still can happen but mostly if there's
 special interest at KDE side. I do not expect particular popularity just
 because the app comes from KDE, expect when other ported apps benefit from
 them as components (here: Kate part).


I guess I'm at least partly to blame for this discussion. I happen to like
Kate, as I'm familiar with it, and not with Notepad++, but in my original
post, I mentioned
specifically something you can't get on Windows, AFAIK, even if you pay for
it: KSnapshot. A single app that lets you save a piece of the screen and
print it
all from the same app, without having to open another app and paste and
then print. But it doesn't work. It would be nice if you folks would fix
it.  There's something
fundamentally dumb about the snipping Tool!

 I think there's a huge space for discussion there and now it's the moment
 when it should take place, so that we can plan the bigger picture by
 taking
 Windows into account.

 Aleix

 [1] http://community.kde.org/Frameworks/List

 ___
 Kde-windows mailing list
 Kde-windows@kde.org
 https://mail.kde.org/mailman/listinfo/kde-windows




___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

[Andrius da Costa Ribas]

 On March 27, 2014, 3:47 p.m., Kevin Ottens wrote:
  src/kjsembed/CMakeLists.txt, line 75
  https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75
 
  Agreed, that should be the preferred way.
  
  Note that some other frameworks probably carry the same mistake

I'll update the patch as per Cristophe's and Aleix's comments.

From what I can see from the frameworks I've built on Windows at the moment 
(all tier1 and most tier2), most of them has 
include/KF5/FrameworkName/headers, except:
Attica (include/KF5/Attica/Attica/headers)
KDNSSD (include/KF5/KDNSSD/DNSSD/headers)
Solid (include/KF5/Solid/Solid/headers)
ThreadWeaver (include/KF5/ThreadWeaver/ThreadWeaver/headers)
*Sonnet (include/Kf5/SonnetCore/Sonnet/headers and 
include/Kf5/SonnetUi/Sonnet/headers)
*KDocTools (include/KF5/XsltKde/headers)

Can we consider fixing those too? (I'm just not sure about the ones I marked 
with *)


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review54308
---


On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117012/
 ---
 
 (Updated March 24, 2014, 1:33 a.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kjsembed
 
 
 Description
 ---
 
 Currently kjsembed CMake file tries to install both 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
 allowed in a case-insensitive filesystem, causing the install step to fail on 
 Windows.
 
 
 Diffs
 -
 
   src/kjsembed/CMakeLists.txt e0ab74c 
 
 Diff: https://git.reviewboard.kde.org/r/117012/diff/
 
 
 Testing
 ---
 
 Tested using MSVC 2013
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115114: Rename lst1 and lst2 variables

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115114/
---

(Updated March 23, 2014, 12:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

lst1 and lst2 are #defined in MinGW internal headers, this patch renames them 
to list1 and list2.


Diffs
-

  plan/libs/kernel/kptappointment.cpp de23bd6 
  plan/libs/kernel/tests/AppointmentIntervalTester.cpp 0ce19e9 
  plan/libs/ui/kptpertresult.cpp 1c05dd7 
  plan/libs/ui/kptresourceallocationeditor.cpp 30e4e0e 
  plan/libs/ui/kptresourceappointmentsview.cpp 042a3a6 
  plan/libs/ui/kptresourceeditor.cpp 2f27665 
  plan/libs/ui/kpttaskeditor.cpp 5067b7d 
  plan/libs/ui/kpttaskstatusview.cpp be9f1a4 
  plan/libs/ui/kptviewbase.cpp 2fae0cf 
  plan/workpackage/taskworkpackageview.cpp 95446b6 

Diff: https://git.reviewboard.kde.org/r/115114/diff/


Testing
---

Tested using MSVC and MinGW.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115116: Disable KoM2MMLForumulaTool also on MinGW

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115116/
---

(Updated March 23, 2014, 12:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

Those files generated by flex (is this flex/yacc?) also fail to build on MinGW. 
For MinGW I had tried renaming the conflicting token names (CHAR and CAL to 
CHARTOKEN and CALTOKEN) but besides succeding to build the Show MathML button 
does not work for me, so I don't know if this would be a correct fix (although 
even so it would be only for MinGW).


Diffs
-

  plugins/formulashape/CMakeLists.txt 015cb8f 
  plugins/formulashape/KoFormulaShapePlugin.cpp 5d5ed61 

Diff: https://git.reviewboard.kde.org/r/115116/diff/


Testing
---

Builds on both MinGW and MSVC.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Updating DocBookXML to 4.5 for KF5

[Andrius da Costa Ribas]

Hello,

Since KDocTools framework bumped supported DocBookXml version to 4.5 I'm
not sure on how to update the files created in (
http://quickgit.kde.org/?p=emerge.gita=commith=9317bbe942d995b279c0587f7ae2b83e2bb0a849
)

As far as I can see, those entries would be needed inside catalog/group:

delegatePublic publicIdStartString=-//OASIS//DTD DocBook XML V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//DTD DocBook XML CALS Table
Model V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//DTD XML Exchange Table Model
19990315//EN catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ELEMENTS DocBook XML
Information Pool V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ELEMENTS DocBook XML
Document Hierarchy V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ELEMENTS DocBook XML HTML
Tables V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ENTITIES DocBook XML
Notations V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ENTITIES DocBook XML
Character Entities V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegatePublic publicIdStartString=-//OASIS//ENTITIES DocBook XML
Additional General Entities V4.5//EN
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegateSystem systemIdStartString=
http://www.oasis-open.org/docbook/xml/4.5;
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
delegateURI uriStartString=http://www.oasis-open.org/docbook/xml/4.5;
catalog=../../share/xml/docbook/schema/dtd/4.5/catalog.xml/
rewriteSystem systemIdStartString=
http://www.oasis-open.org/docbook/xml/4.5;
rewritePrefix=../../share/xml/docbook/schema/dtd/4.5/


but I'm not sure about what should be done for the existing references to
4.2 and 4.4 in that file.


--
Andrius.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117011: Use bin/../share on Windows as a workaround

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/
---

Review request for KDE Frameworks and kdewin.


Repository: kdoctools


Description
---

This is a workaround for kdoctools for the same problem discussed in review 
#115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share.


Diffs
-

  src/xslt.cpp db67599 

Diff: https://git.reviewboard.kde.org/r/117011/diff/


Testing
---

Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this 
patch (KJsEmbed still has an unrelated problem on install step).


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Qt5 modules dev branch

[Andrius da Costa Ribas]

Hi,

According to http://community.kde.org/Frameworks/Building they're using
stable branch of qt modules. Also I'm getting some errors in dev branch
(for e.g. QtDeclarative) which are not happening on stable. May I change
those modules to stable in our qt5 branch? Is there some specific
reason to use dev instead?

--
Andrius.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Fwd: [Kde-cvs-announce] [REMINDER] KDE SC 4.13 is Frozen, KDE/4.13 branches created, Beta 1 tag next week

[Andrius da Costa Ribas]

So are we going to skip 4.12, and start a 4.13 branch on emerge instead?

--
Andrius

-- Forwarded message --
From: Albert Astals Cid aa...@kde.org
Date: 2014-02-26 21:36 GMT-03:00
Subject: [Kde-cvs-announce] [REMINDER] KDE SC 4.13 is Frozen, KDE/4.13
branches created, Beta 1 tag next week
To: kde-cvs-annou...@kde.org


Wednesday, February 26, 2014 has
 * KDE SC 4.13 Feature Freeze
 * KDE SC 4.13 Dependency Freeze
 * KDE SC 4.13 API Freeze
 * KDE SC 4.13 Artwork and Bindings Freeze
 * KDE SC 4.13 Message Freeze

From now on only bugfixes, if you have any feature you could not land for
any
reason please contact the release-team

KDE/4.13 branches have been created, please make sure any bug you fix in
master
is landed there as well as in KDE/4.12

Next week Wednesday March 5 we will be tagging KDE 4.13 Beta 1 with version
number 4.12.80

Read http://techbase.kde.org/Schedules/KDE4/4.13_Release_Schedule for
further
explanation of what each freeze means.

Cheers,
  Albert
___

== This is a read-only list.  Do not reply to this message. ==

== Unsubscribing is only possible by disabling your KDE commit account ==
== To do so, enter KDE Sysadmin Ticket at https://sysadmin.kde.org/tickets/==
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

[Andrius da Costa Ribas]

 On Feb. 6, 2014, 1:14 a.m., Alexander Richardson wrote:
  src/kwindowsystem.cpp, line 342
  https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342
 
  The non-MSVC macro has a return statement, I think this one needs it as 
  well

Why is this conditioned to Q_CC_MSVC in first place? if it's  because of the 
variadic macros, gcc accepts __VA_ARGS__ too (the other way is a gcc 
extension), otherwise if it's because of the Xcb case, then it should be 
conditioned to the OS, not the compiler.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115459/#review49088
---


On Feb. 5, 2014, 4:55 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115459/
 ---
 
 (Updated Feb. 5, 2014, 4:55 p.m.)
 
 
 Review request for KDE Frameworks, kdewin and Alexander Richardson.
 
 
 Repository: kwindowsystem
 
 
 Description
 ---
 
 Introduce runtime platform support in KWindowSystem
 
 This is a change similar to the one in KWindowInfo, but with variation
 to the pattern due to the static container.
 
 There is now a generic implementation of KWindowSystem which is
 completely windowing system platform independent. This implementation
 delegates all methods into a KWindowSystemPrivate class.
 
 Each windowing system platform implementation needs to provide a
 subclass (e.g. KWindowSystemPrivateX11) and provide all the methods
 which are delegated. Note that there are no virtual methods defined,
 instead the d-pointer gets casted into the proper type. Thus if a
 method is not provided it will end in a compile error.
 
 To make use of a platform implementation it needs to be included in
 the ctor of KWindowSystemStaticContainer and the PlatformImplementation
 enum needs to be extended by a value for the platform. This is used in
 the D macro to cast and delegate correctly.
 
 There is a dummy implementation for all not supported windowing system
 platforms.
 
 This change also includes some API changes:
 * KWindowSystem::windows() returns a copy instead of const-ref
 * All methods are provided, there is no longer X11 specific methods
 * private methods and enums are removed
 
 NOTE: This change breaks the implementation for Windows and Mac OS!
 They are currently excluded from build.
 
 
 Diffs
 -
 
   src/CMakeLists.txt 23133d581944a8373b9b753b300d97054b7d6f18 
   src/kwindowinfo.cpp c706b29b306b65c992a178d490819b76e1aeca84 
   src/kwindowsystem.h d288e1ab7c49f68482c94285c2aab695f08f3524 
   src/kwindowsystem.cpp PRE-CREATION 
   src/kwindowsystem_p.h PRE-CREATION 
   src/kwindowsystem_p_x11.h PRE-CREATION 
   src/kwindowsystem_x11.cpp 8d841cbcec41dc2d4df381338803902badf3f35e 
 
 Diff: https://git.reviewboard.kde.org/r/115459/diff/
 
 
 Testing
 ---
 
 Unit tests still succeed for X11, but they are not complete, though the most 
 important aspects are tested.
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: KDE 4.12 Windows release getting close

[Andrius da Costa Ribas]

Hello all,

Last build on the build server is from Jan-8, so, just to track what is
still listed as a failed in there:

* kde/kdeartwork (mingw-w32 only) - looks simple to fix, however maybe a
better approach is to skip kdesavers as they need some adaptation to really
work as screensavers on Windows (I notice we also build ktux, probably it
came from a package split, I think we can take it out for the same reason)
* kde/cantor (msvc) - I've fixed it upstream, should appear green in the
next rebuild
* kde/kstars (both mingw) - hadn't checked it yet, but looks like it's a
simple fix too
* kde/kfourinline (both mingw) - hadn't checked it yet
* kde/kdepim (msvc) - hadn't checked it yet
* kde/kdeplasma-addons (32bit builds) - I have a patch that got reviewed
today, will push on saturday.
* extragear/libktorrent (both mingw) - hadn't checked it yet
* extragear/amarok (msvc) - I can build it but can't run with the patches
I've sent in a previous e-mail
* extragear/ktorrent (both mingw) - not sure but probably depends on
libktorrent fix
* extragear/skrooge (all) - hadn't checked it
* kdeapps/calligra (both mingw) - already patched on emerge

I'm not sure if I can check them by the next days, but I'm happy there are
not many left :)

One package I think would be nice to have is rekonq. Last release 2.4.2
builds and runs fine here and 2.4.x would probably be the last using
QtWebkit before switching to the new QtWebEngine. Also Konqueror would
benefit from having kwebkitpart. What do you think?

Cheers,
Andrius.


2014-01-08 Patrick von Reth patr...@von-reth.de:

  Hi everyone

 We have a new year and a new KDE windows release is getting close.
 Only a few packages are still failing to build, see the dashboard
 *http://winkde.org/pub/kde/ports/win32/dashboard/release/*http://winkde.org/pub/kde/ports/win32/dashboard/release/,
  and as a usual your help is welcome.

 In addition if you can't find your favourite package in the list or its
 version is totally outdated please report it.


 Cheers
 Patrick

 ___
 Kde-windows mailing list
 Kde-windows@kde.org
 https://mail.kde.org/mailman/listinfo/kde-windows


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115113: Static libs must come first in linkage order

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115113/
---

(Updated Jan. 23, 2014, 8:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

Fix build on MinGW due to shared libs being linked before static libs (MinGW 
complains about symbol being defined more than once).


Diffs
-

  filters/words/msword-odf/CMakeLists.txt 8342552 
  krita/image/CMakeLists.txt eefaf61 

Diff: https://git.reviewboard.kde.org/r/115113/diff/


Testing
---

Tested building using MinGW and MSVC.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115108/
---

(Updated Jan. 23, 2014, 8:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

This patch fixes the build issues on MinGW due to mode_t typedef and struct 
timezone being defined in both kdewin and winquirks.


Diffs
-

  winquirks/sys/time.h e6852ca 
  winquirks/unistd.h 82a9ab4 

Diff: https://git.reviewboard.kde.org/r/115108/diff/


Testing
---

Tested building on both MSVC and MinGW.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115107: Link tests to kritaimage instead of using directly its sources

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115107/
---

(Updated Jan. 23, 2014, 8:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

Avoid conflicts on MinGW since these sources refer to headers where the classes 
are dllimport (since at this point we are not building the library).

Obs.: This is not the case for the next targets in this CMake file, since 
kis_tile_data is not exported.


Diffs
-

  krita/image/tiles3/tests/CMakeLists.txt 5339543 

Diff: https://git.reviewboard.kde.org/r/115107/diff/


Testing
---

Builds on both MinGW and MSVC.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115109: _isnan is present only in MSVC's cfloat, for MinGW we still use std::isnan

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115109/
---

(Updated Jan. 23, 2014, 12:51 a.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra and kdewin.


Repository: calligra


Description
---

Fix building on MinGW since we only need the additional header and define for 
MSVC. Also changed math.h and float.h to cmath and cfloat.


Diffs
-

  krita/image/brushengine/kis_paintop.cc 304317a 

Diff: https://git.reviewboard.kde.org/r/115109/diff/


Testing
---

Tested building on MSVC and MinGW


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115108/#review48089
---


This one is not needed anymore after review #115128 got submitted, should I 
discard this one?

- Andrius da Costa Ribas


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115108/
 ---
 
 (Updated Jan. 19, 2014, 3:42 a.m.)
 
 
 Review request for Calligra and kdewin.
 
 
 Repository: calligra
 
 
 Description
 ---
 
 This patch fixes the build issues on MinGW due to mode_t typedef and struct 
 timezone being defined in both kdewin and winquirks.
 
 
 Diffs
 -
 
   winquirks/sys/time.h e6852ca 
   winquirks/unistd.h 82a9ab4 
 
 Diff: https://git.reviewboard.kde.org/r/115108/diff/
 
 
 Testing
 ---
 
 Tested building on both MSVC and MinGW.
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115184: Fix build on MSVC x64

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115184/#review47907
---


where is it previously defined?

- Andrius da Costa Ribas


On Jan. 21, 2014, 4:29 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115184/
 ---
 
 (Updated Jan. 21, 2014, 4:29 p.m.)
 
 
 Review request for kdewin.
 
 
 Repository: emerge
 
 
 Description
 ---
 
 size_t is 64 bit with MSVC x64 so the build fails otherwise
 
 
 Diffs
 -
 
   portage/win32libs/shared-mime-info/unistd.c 2f04997 
 
 Diff: https://git.reviewboard.kde.org/r/115184/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115192: Fix building 32bit target on 64bit machine

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115192/
---

Review request for kdewin and Plasma.


Repository: kdeplasma-addons


Description
---

with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with 
THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in 
render_with_SSE2_explicitly_enabled.cpp, but this source is only built when 
using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is 
defined, though, in global.h, since this is not a 64bit target.


Diffs
-

  wallpapers/mandelbrot/renderthread.cpp c1b5c60 

Diff: https://git.reviewboard.kde.org/r/115192/diff/


Testing
---

Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 
(it's a x86_64 processor)


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115108/
---

Review request for Calligra and kdewin.


Repository: calligra


Description
---

This patch fixes the build issues on MinGW due to mode_t typedef and struct 
timezone being defined in both kdewin and winquirks.


Diffs
-

  winquirks/sys/time.h e6852ca 
  winquirks/unistd.h 82a9ab4 

Diff: https://git.reviewboard.kde.org/r/115108/diff/


Testing
---

Tested building on both MSVC and MinGW.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115107: Link tests to kritaimage instead of using directly its sources

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115107/
---

Review request for Calligra and kdewin.


Repository: calligra


Description
---

Avoid conflicts on MinGW since these sources refer to headers where the classes 
are dllimport (since at this point we are not building the library).

Obs.: This is not the case for the next targets in this CMake file, since 
kis_tile_data is not exported.


Diffs
-

  krita/image/tiles3/tests/CMakeLists.txt 5339543 

Diff: https://git.reviewboard.kde.org/r/115107/diff/


Testing
---

Builds on both MinGW and MSVC.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115114: Rename lst1 and lst2 variables

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115114/
---

Review request for Calligra and kdewin.


Repository: calligra


Description
---

lst1 and lst2 are #defined in MinGW internal headers, this patch renames them 
to list1 and list2.


Diffs
-

  plan/libs/kernel/kptappointment.cpp de23bd6 
  plan/libs/kernel/tests/AppointmentIntervalTester.cpp 0ce19e9 
  plan/libs/ui/kptpertresult.cpp 1c05dd7 
  plan/libs/ui/kptresourceallocationeditor.cpp 30e4e0e 
  plan/libs/ui/kptresourceappointmentsview.cpp 042a3a6 
  plan/libs/ui/kptresourceeditor.cpp 2f27665 
  plan/libs/ui/kpttaskeditor.cpp 5067b7d 
  plan/libs/ui/kpttaskstatusview.cpp be9f1a4 
  plan/libs/ui/kptviewbase.cpp 2fae0cf 
  plan/workpackage/taskworkpackageview.cpp 95446b6 

Diff: https://git.reviewboard.kde.org/r/115114/diff/


Testing
---

Tested using MSVC and MinGW.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115109: _isnan is present only in MSVC's cfloat, for MinGW we still use std::isnan

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115109/
---

Review request for Calligra and kdewin.


Repository: calligra


Description
---

Fix building on MinGW since we only need the additional header and define for 
MSVC. Also changed math.h and float.h to cmath and cfloat.


Diffs
-

  krita/image/brushengine/kis_paintop.cc 304317a 

Diff: https://git.reviewboard.kde.org/r/115109/diff/


Testing
---

Tested building on MSVC and MinGW


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 114986: Fix usage of KDE4_ENABLE_EXCEPTIONS

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114986/
---

(Updated Jan. 17, 2014, 6:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra, kdewin and Boudewijn Rempt.


Repository: calligra


Description
---

${KDE4_ENABLE_EXCEPTIONS} should go into CMAKE_CXX_FLAGS instead of 
add_definitions, otherwise the same flags get added also into resource compiler 
rc.exe where this flag is unknown.

A similar error is described in: 
http://www.cmake.org/pipermail/cmake/2008-June/022381.html - this patch makes 
the same of what ksirk currently does.


Diffs
-

  krita/CMakeLists.txt e825c03 

Diff: https://git.reviewboard.kde.org/r/114986/diff/


Testing
---

Tested using MSVC.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114984/
---

Review request for KDE Runtime and kdewin.


Repository: kde-runtime


Description
---

When building with MinGW new conflicts appeared when including strsafe before 
Qt headers (specially QString included from QBuffer). Also a new weird 
compiling error telling 'lstrcpy_instead_use_stringcbcopy_or_stringcchcopy' 
undeclared identifier appeared, so I replaced lstrcpy with the equivalent use 
of StringCchCopy 
(http://msdn.microsoft.com/en-us/library/windows/desktop/ms647527(v=vs.85).aspx).


Diffs
-

  kioslave/thumbnail/icoutils_win.cpp e223aa1 

Diff: https://git.reviewboard.kde.org/r/114984/diff/


Testing
---

Tested using MinGW, thumbnails still work fine. No errors when building with 
MSVC either.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/
---

Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.


Repository: cantor


Description
---

This typedef is in both kdewin's sys/types (msvc/include) and python config 
headers. By adding this definition the typedef present in kdewin is skipped.


Diffs
-

  src/backends/python2/CMakeLists.txt d27d88f 

Diff: https://git.reviewboard.kde.org/r/114964/diff/


Testing
---

Python backend builds and run fine from a clean MSVC build.
MinGW build was already okay, as per 
http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

[Andrius da Costa Ribas]

 On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote:
  src/backends/python2/CMakeLists.txt, line 15
  https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15
 
  Shouldn't this go into the kdewin include files then?
 
 Andrius da Costa Ribas wrote:
 kdewin does this
 
 http://quickgit.kde.org/?p=kdewin.gita=blobh=056cd64165e3e5c76d7878c13806551dca7c3182hb=ae1c0ac291cc97d432b73091bb17b32120038b6cf=include%2Fmsvc%2Fsys%2Ftypes.h
 
 #ifndef _SSIZE_T_DEFINED
 #define _SSIZE_T_DEFINED
 typedef SSIZE_T ssize_t;
 #endif
 
 the problem is that the python one doesn't.

 
 Albert Astals Cid wrote:
 Ah, i see what you mean. Quick question, how does kdewin headers end up 
 in cantor?

kdewin's include/msvc include path is part of ${KDE4_INCLUDES}
Python's Python.h includes limits.h which is in present in include/msvc 
include path, this then which includes sys/types.h, also from kdewin.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/#review47190
---


On Jan. 11, 2014, 2:37 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114964/
 ---
 
 (Updated Jan. 11, 2014, 2:37 p.m.)
 
 
 Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
 
 
 Repository: cantor
 
 
 Description
 ---
 
 This typedef is in both kdewin's sys/types (msvc/include) and python config 
 headers. By adding this definition the typedef present in kdewin is skipped.
 
 
 Diffs
 -
 
   src/backends/python2/CMakeLists.txt d27d88f 
 
 Diff: https://git.reviewboard.kde.org/r/114964/diff/
 
 
 Testing
 ---
 
 Python backend builds and run fine from a clean MSVC build.
 MinGW build was already okay, as per 
 http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

[Andrius da Costa Ribas]

 On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote:
  src/backends/python2/CMakeLists.txt, line 15
  https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15
 
  Shouldn't this go into the kdewin include files then?
 
 Andrius da Costa Ribas wrote:
 kdewin does this
 
 http://quickgit.kde.org/?p=kdewin.gita=blobh=056cd64165e3e5c76d7878c13806551dca7c3182hb=ae1c0ac291cc97d432b73091bb17b32120038b6cf=include%2Fmsvc%2Fsys%2Ftypes.h
 
 #ifndef _SSIZE_T_DEFINED
 #define _SSIZE_T_DEFINED
 typedef SSIZE_T ssize_t;
 #endif
 
 the problem is that the python one doesn't.

 
 Albert Astals Cid wrote:
 Ah, i see what you mean. Quick question, how does kdewin headers end up 
 in cantor?
 
 Andrius da Costa Ribas wrote:
 kdewin's include/msvc include path is part of ${KDE4_INCLUDES}
 Python's Python.h includes limits.h which is in present in include/msvc 
 include path, this then which includes sys/types.h, also from kdewin.
 
 Albert Astals Cid wrote:
 Ok, makes sense to me, but I'm not one of the cantor devels, so I'll wait 
 for them to give you the Ship it. If they don't show up in a few days/weeks 
 ping me and we'll see what we can do.

Okay, dropping the issue by now.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/#review47190
---


On Jan. 11, 2014, 2:37 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114964/
 ---
 
 (Updated Jan. 11, 2014, 2:37 p.m.)
 
 
 Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
 
 
 Repository: cantor
 
 
 Description
 ---
 
 This typedef is in both kdewin's sys/types (msvc/include) and python config 
 headers. By adding this definition the typedef present in kdewin is skipped.
 
 
 Diffs
 -
 
   src/backends/python2/CMakeLists.txt d27d88f 
 
 Diff: https://git.reviewboard.kde.org/r/114964/diff/
 
 
 Testing
 ---
 
 Python backend builds and run fine from a clean MSVC build.
 MinGW build was already okay, as per 
 http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 114476: Fix MSBuild of glib

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114476/
---

Review request for kdewin.


Repository: emerge


Description
---

The patch currently being applied do not match the sources of 2.36.3. Also 
libintl headers and lib were not found so our include and lib dir needs to be 
added to %INCLUDE% and %LIB%, and /p:useenv=true needs to be passed to msbuild 
to make use of these environment variables.


Diffs
-

  portage/testing/glib-src/glib-2.36.3-20131215.diff PRE-CREATION 
  portage/testing/glib-src/glib-src-2.29.14.py a1f3cbd 

Diff: http://git.reviewboard.kde.org/r/114476/diff/


Testing
---

Builds and installs fine for MSVC.
For Intel Compiler, I'm figuring out a way to correctly determine the value in 
/PlatformToolset=... according to compiler version. Also the dependency 
libffi-src needs some fixes first.


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Patch for freetype recipe

[Andrius da Costa Ribas]

Hi,

Freetype recipe doesn't install one header that is used on poppler's
FindFreetype cmake. This patch fixes it, however my ssh keys are in the old
computer and I'm not with it right now, so I'm asking if someone could
kindly push this attached patch into emerge meanwhile.

--
Andrius


ft2build.patch
Description: Binary data
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112009/#review43272
---


ping? may I ship it?

- Andrius da Costa Ribas


On Aug. 17, 2013, 1:43 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112009/
 ---
 
 (Updated Aug. 17, 2013, 1:43 p.m.)
 
 
 Review request for KDE Runtime, kdewin and Pali Rohár.
 
 
 Repository: kde-runtime
 
 
 Description
 ---
 
 This patch intends to enable Windows exe/dll thumbnailing by using winapi. It 
 derives from the unsubmitted patch from Pali Rohár from 
 https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few 
 adjustments on the original patch, split that patch into a common part and a 
 icoutils-specific part, and then created the winapi-based part to replace the 
 icoutils one on Windows (porting icoutils to windows wasn't going to be easy).
 
 
 Diffs
 -
 
   kioslave/thumbnail/CMakeLists.txt b81339b 
   kioslave/thumbnail/icoutils.h 6468bc1 
   kioslave/thumbnail/icoutils.cpp 31db85d 
   kioslave/thumbnail/icoutils_common.cpp PRE-CREATION 
   kioslave/thumbnail/icoutils_win.cpp PRE-CREATION 
   kioslave/thumbnail/icoutils_wrestool.cpp PRE-CREATION 
   kioslave/thumbnail/windowsexecreator.h a407982 
   kioslave/thumbnail/windowsexecreator.cpp 9e24aee 
   kioslave/thumbnail/windowsexethumbnail.desktop f10efef 
   kioslave/thumbnail/windowsimagecreator.h 0b68cc6 
   kioslave/thumbnail/windowsimagecreator.cpp 08b063d 
 
 Diff: http://git.reviewboard.kde.org/r/112009/diff/
 
 
 Testing
 ---
 
 Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
 Tested using ico files and both 32-bit and 64-bit executables and dlls, 
 including jumbo-size icons.
 I've used QLibrary for all winapi functions in order to avoid issues with 
 MinGW compiler, but I don't have a MinGW setup to check.
 
 Not tested on *nix, but the original patch was not changed except for 
 iterating order in the common part and namespacing.
 
 
 File Attachments
 
 
 screenshot
   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Concerns about deprecating KFileDialog

[Andrius da Costa Ribas]

Hello,

(crosspost between kde-frameworks-devel and kde-windows)

I've posted a question in a recent review request that deprecates
KFileDialog in favor of QFileDialog for KF5, however this question got
probably unnoticed (as no one responded and later the review got submitted).

My concern about deprecating KFileDialog is that on Windows there is in
systemsettings the option to choose between using either native or KDE
dialog. I heavily use kioslaves to open/save files in different remote
locations (SFTP) and I hevily use the places panel to bookmark those
locations, that's something that can't be done with native Windows dialog.
As far as I can see there is no such option when using QFileDialog, so
Windows users will lose the power of the kioslaves :(

Was this considered when it was decided to deprecate KFileDialog?

Cheers,
Andrius da Costa Ribas.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112009/
---

(Updated Aug. 17, 2013, 1:43 p.m.)


Review request for KDE Runtime, kdewin and Pali Rohár.


Changes
---

Removed all the dynamic loading on the Windows side.
Removed the Cursor/Group Cursor part on the wrestool side (so it can be added 
later when Qt is patched).
CMake fixes as per comments below.
A few style fixes.
Renamed icotools_icoutils.cpp to icotools_wrestool.cpp to make it more explicit 
that wrestool is used as a backend on non win32.


Note: The beforementioned LNK thumbnailer will go into a different review 
request, after this one gets in.


Description
---

This patch intends to enable Windows exe/dll thumbnailing by using winapi. It 
derives from the unsubmitted patch from Pali Rohár from 
https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few 
adjustments on the original patch, split that patch into a common part and a 
icoutils-specific part, and then created the winapi-based part to replace the 
icoutils one on Windows (porting icoutils to windows wasn't going to be easy).


Diffs (updated)
-

  kioslave/thumbnail/CMakeLists.txt b81339b 
  kioslave/thumbnail/icoutils.h 6468bc1 
  kioslave/thumbnail/icoutils.cpp 31db85d 
  kioslave/thumbnail/icoutils_common.cpp PRE-CREATION 
  kioslave/thumbnail/icoutils_win.cpp PRE-CREATION 
  kioslave/thumbnail/icoutils_wrestool.cpp PRE-CREATION 
  kioslave/thumbnail/windowsexecreator.h a407982 
  kioslave/thumbnail/windowsexecreator.cpp 9e24aee 
  kioslave/thumbnail/windowsexethumbnail.desktop f10efef 
  kioslave/thumbnail/windowsimagecreator.h 0b68cc6 
  kioslave/thumbnail/windowsimagecreator.cpp 08b063d 

Diff: http://git.reviewboard.kde.org/r/112009/diff/


Testing
---

Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
Tested using ico files and both 32-bit and 64-bit executables and dlls, 
including jumbo-size icons.
I've used QLibrary for all winapi functions in order to avoid issues with MinGW 
compiler, but I don't have a MinGW setup to check.

Not tested on *nix, but the original patch was not changed except for iterating 
order in the common part and namespacing.


File Attachments


screenshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png


Thanks,

Andrius da Costa Ribas

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows