from:"Patrick Spendrin"

Re: Review Request 126378: remove kactivities on windows

2017-03-17 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/
---

(Updated March 17, 2017, 5:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin and Okular.


Changes
---

Submitted with commit 3859fba07d67db264974b16838f76d2e5f20eb57 by Albert Vaca 
on behalf of Oliver Sander to branch master.


Repository: okular


Description
---

KActivities is not used on Windows, so a hard dependency on it
only brings unneeded code.
This patch removes it completely under Windows.


Diffs
-

  CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
  shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
  shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 

Diff: https://git.reviewboard.kde.org/r/126378/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

Re: Review Request 127123: Update information on windows.kde.org index page.

2016-03-11 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127123/#review93417
---


Ship it!




Ship It!

- Patrick Spendrin


On März 6, 2016, 11:17 vorm., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127123/
> ---
> 
> (Updated März 6, 2016, 11:17 vorm.)
> 
> 
> Review request for KDE Websites, kdewin, Ralf Habacker, and Patrick Spendrin.
> 
> 
> Repository: windows-kde-org
> 
> 
> Description
> ---
> 
> So, while trying to find out, how to bring a KF5 version of RKWard to 
> Windows, one of the places where I was looking for information was 
> windows.kde.org. That did not help me much. Here's a suggestion for slightly 
> more up-to-date information.
> 
> Key changes:
> - Mention the fact that the KDE installer is still the easy way to install 
> most KDE apps, but in a rather old version.
> - Mention the fact that at least some applications offer more recent 
> single-app installers.
> - Remove the overly caution warning about applications being "not yet in a 
> final state". What really is? And many apps can in fact be used productively 
> on Windows, even if they may have more bugs on that platform, than on Linux.
> - Links to techbase seemed to be a bit redundant, I tried to reduce that.
> - Remove mention of specific version of Windows. Win 8 and Win 10 seem to 
> work, too. Support for Win XP applies to the old installer, only, not current 
> (emerge).
> 
> 
> Diffs
> -
> 
>   index.php 19b54bd 
> 
> Diff: https://git.reviewboard.kde.org/r/127123/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126375: Remove kdelibs4support from the generator plugins

2016-01-30 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/
---

(Updated Jan. 30, 2016, 4:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin and Okular.


Changes
---

Submitted with commit 37d562310266a85b21896cbe8ab333f0e7f680d5 by Aleix Pol on 
behalf of Patrick Spendrin to branch frameworks.


Repository: okular


Description
---

This removes kdelibs4support for all generators except the mobipocket one.
The test executable for kimgio needs some windows fixes too, so I'll try
to make a separate review for that.


Diffs
-

  CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
  generators/comicbook/CMakeLists.txt 684613b5bd756696eff79b52f0e184588f19f3d5 
  generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 
  generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
  generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
  generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 
  generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
  generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 
  generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
  generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
  generators/kimgio/generator_kimgio.cpp 
84c155b5ad8da5057a28faaffa417ecb60a64ab3 
  generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
  generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 
  generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
  generators/poppler/generator_pdf.cpp 90db80a41ecef76733ab79ebc41c162725cf30ed 
  generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
  generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
  generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
  ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 
  ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a 

Diff: https://git.reviewboard.kde.org/r/126375/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[kde-windows] [Bug 357240] emerging KCoreAddons fails by CMake Internal Error on Win 8.1 x64

2015-12-28 Thread Patrick Spendrin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=357240

Patrick Spendrin <ps...@gmx.de> changed:

   What|Removed |Added

 CC||ps...@gmx.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Patrick Spendrin <ps...@gmx.de> ---
Hi, I haven't had an in-depth look yet, but I know a work-around:
run 
emerge -i --target=gitHEAD cmake-pkg
and then go ahead.
This will hopefully be fixed in the next cmake release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126379: Windows string fixes

2015-12-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126379/
---

(Updated Dec. 28, 2015, 9:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin and Okular.


Changes
---

Submitted with commit d0ecab47368288ec00318dccb6dfcd9fc79a8e8b by Patrick 
Spendrin to branch frameworks.


Repository: okular


Description
---

This patch changes multiline QStringLiterals to QString::fromLatin1
as QStringLiterals doesn't understand multiline strings on windows.
Also, strncasecmp is replaced by the portable qstricmp function provided
by QByteArray header.


Diffs
-

  generators/dvi/dviRenderer_prescan.cpp 
783c7273c6f7d1be03f5e970dc23e0a24a31197f 
  generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 
  generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c 
  generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 
  ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a 
  ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 

Diff: https://git.reviewboard.kde.org/r/126379/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126415: simple windows fixes

2015-12-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126415/
---

(Updated Dez. 28, 2015, 11:15 nachm.)


Review request for kdewin and Ivan Čukić.


Repository: kactivities


Description
---

I just used nullptr for the dbus interface as keeping this place empty
wasn't allowed by the preprocessor.
source code is utf8, so likely this needs to be utf8 here as well.


Diffs (updated)
-

  src/lib/core/controller.cpp 24954ae5a6f27247b92355c923528f5c6311f446 

Diff: https://git.reviewboard.kde.org/r/126415/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126415: simple windows fixes

2015-12-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126415/
---

(Updated Dec. 28, 2015, 11:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdewin and Ivan Čukić.


Changes
---

Submitted with commit fef6eec9699d380118e34f6e1c974ff75dd31b5d by Patrick R. 
Spendrin to branch master.


Repository: kactivities


Description
---

I just used nullptr for the dbus interface as keeping this place empty
wasn't allowed by the preprocessor.
source code is utf8, so likely this needs to be utf8 here as well.


Diffs
-

  src/lib/core/controller.cpp 24954ae5a6f27247b92355c923528f5c6311f446 

Diff: https://git.reviewboard.kde.org/r/126415/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[kde-windows] [Bug 357117] Changed ActivePerl version

2015-12-26 Thread Patrick Spendrin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=357117

Patrick Spendrin <ps...@gmx.de> changed:

   What|Removed |Added

 CC||ps...@gmx.de
   Severity|grave   |normal

--- Comment #1 from Patrick Spendrin <ps...@gmx.de> ---
Which branch are you working on? Please keep in mind that all non-master
branches are basically not maintained...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126379: Windows string fixes

2015-12-26 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126379/
---

(Updated Dez. 27, 2015, 12:28 vorm.)


Review request for kdewin and Okular.


Repository: okular


Description
---

This patch changes multiline QStringLiterals to QString::fromLatin1
as QStringLiterals doesn't understand multiline strings on windows.
Also, strncasecmp is replaced by the portable qstricmp function provided
by QByteArray header.


Diffs
-

  generators/dvi/dviRenderer_prescan.cpp 
783c7273c6f7d1be03f5e970dc23e0a24a31197f 
  generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 
  generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c 
  generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 
  ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a 
  ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 

Diff: https://git.reviewboard.kde.org/r/126379/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126378: remove kactivities on windows

2015-12-16 Thread Patrick Spendrin



> On Dez. 16, 2015, 4:45 nachm., Alex Richardson wrote:
> > shell/shell.cpp, line 48
> > <https://git.reviewboard.kde.org/r/126378/diff/1/?file=423785#file423785line48>
> >
> > `#if HAVE_KACTIVITIES` would be nicer and then KActivities could just 
> > be turned into an optional dependency which wouldn't be found on Windows?
> > 
> > I prefer having ifdefs based on available features rather than 
> > hardcoded on the OS
> 
> Luigi Toscano wrote:
> I think some commits ago (can't check now) kactivities was made 
> mandatory, so there is something wrong that can happen reintroducing this 
> check. Maybe. Not sure about the status on Windows, but please please ping 
> Ivan as kactivities maintainer.

Well, there would be also the possibility to make kactivities mandatory on 
Linux, and optional on Windows/Mac.
I'll try to get a comment from ivan first...


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/#review89610
-------


On Dez. 16, 2015, 1:16 vorm., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126378/
> ---
> 
> (Updated Dez. 16, 2015, 1:16 vorm.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> KActivities is not used on Windows, so a hard dependency on it
> only brings unneeded code.
> This patch removes it completely under Windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
>   shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 
> 
> Diff: https://git.reviewboard.kde.org/r/126378/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126375: Remove kdelibs4support from the generator plugins

2015-12-16 Thread Patrick Spendrin



> On Dez. 16, 2015, 4:42 nachm., Alex Richardson wrote:
> > generators/djvu/kdjvu.cpp, line 39
> > <https://git.reviewboard.kde.org/r/126375/diff/1/?file=422860#file422860line39>
> >
> > Use qCDebug() together with ecm_qt_declare_logging_category() ?

Yes, I only saw that after the review was opened, I'll adapt this to the way 
the other generators handle it.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/#review89607
---


On Dez. 16, 2015, 12:41 vorm., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126375/
> ---
> 
> (Updated Dez. 16, 2015, 12:41 vorm.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This removes kdelibs4support for all generators except the mobipocket one.
> The test executable for kimgio needs some windows fixes too, so I'll try
> to make a separate review for that.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   generators/comicbook/CMakeLists.txt 
> 684613b5bd756696eff79b52f0e184588f19f3d5 
>   generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 
>   generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
>   generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
>   generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 
>   generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
>   generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 
>   generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
>   generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
>   generators/kimgio/generator_kimgio.cpp 
> 84c155b5ad8da5057a28faaffa417ecb60a64ab3 
>   generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
>   generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 
>   generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
>   generators/poppler/generator_pdf.cpp 
> 90db80a41ecef76733ab79ebc41c162725cf30ed 
>   generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
>   generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
>   generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
>   ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 
>   ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a 
> 
> Diff: https://git.reviewboard.kde.org/r/126375/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 126375: Remove kdelibs4support from the generator plugins

2015-12-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/
---

Review request for kdewin and Okular.


Repository: okular


Description
---

This removes kdelibs4support for all generators except the mobipocket one.
The test executable for kimgio needs some windows fixes too, so I'll try
to make a separate review for that.


Diffs
-

  CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
  generators/comicbook/CMakeLists.txt 684613b5bd756696eff79b52f0e184588f19f3d5 
  generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 
  generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
  generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
  generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 
  generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
  generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 
  generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
  generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
  generators/kimgio/generator_kimgio.cpp 
84c155b5ad8da5057a28faaffa417ecb60a64ab3 
  generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
  generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 
  generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
  generators/poppler/generator_pdf.cpp 90db80a41ecef76733ab79ebc41c162725cf30ed 
  generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
  generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
  generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
  ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 
  ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a 

Diff: https://git.reviewboard.kde.org/r/126375/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 126378: remove kactivities on windows

2015-12-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/
---

Review request for kdewin and Okular.


Repository: okular


Description
---

KActivities is not used on Windows, so a hard dependency on it
only brings unneeded code.
This patch removes it completely under Windows.


Diffs
-

  CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
  shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
  shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 

Diff: https://git.reviewboard.kde.org/r/126378/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126378: remove kactivities on windows

2015-12-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/#review89574
---


If you prefer to have an optional dependency on kactivities on windows, I can 
of course also change this review...

- Patrick Spendrin


On Dez. 16, 2015, 1:16 vorm., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126378/
> ---
> 
> (Updated Dez. 16, 2015, 1:16 vorm.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> KActivities is not used on Windows, so a hard dependency on it
> only brings unneeded code.
> This patch removes it completely under Windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
>   shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 
> 
> Diff: https://git.reviewboard.kde.org/r/126378/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 126379: Windows string fixes

2015-12-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126379/
---

Review request for kdewin and Okular.


Repository: okular


Description
---

This patch changes multiline QStringLiterals to QString::fromLatin1
as QStringLiterals doesn't understand multiline strings on windows.
Also, strncasecmp is replaced by the portable qstricmp function provided
by QByteArray header.


Diffs
-

  generators/dvi/dviRenderer_prescan.cpp 
783c7273c6f7d1be03f5e970dc23e0a24a31197f 
  generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 
  generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c 
  generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 
  ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a 
  ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 

Diff: https://git.reviewboard.kde.org/r/126379/diff/


Testing
---

Windows.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: QStandardPaths Patch

2015-10-13 Thread Patrick Spendrin

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 12.10.2015 um 22:15 schrieb Christoph Cullmann:
> Hi,
> 
> I have seen some patch floating around to allow to overwrite the
> QStandardPaths locations via qt.conf.
> 
> I like that idea, thought in the patch I have seen the writable
> location is overwritten.
> 
> Should not be the "non-writable" ones overwritten?

Well, not sure if it is my patch that you saw, (I attached it for
reference), but what we want to achieve is not to modify the install
location (that is a different topic) but the location of the
equivalent of the .kde directory; this now maps to some %APPDATA%-like
location directly, meaning that it will collide if a certain framework
is used in two different installations:
Say you install kile and you install kdevelop on the other hand,
settings for the ktexteditor framework are now mapped to the same
file, even though you might not want that (these are different apps
after all) and might also be dangerous due to version conflicts (in
contrary to Linux distributions, you have no way to make sure that
both installations are updated).

If there are similar problems for the non-writeable location, this
patch of course can be adapted too.

I am not sure if the patch is ok to submit yet, but maybe I should try i
t.

> 
> Greetings Christoph
> 
regards,
Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.21 (MingW32)

iQIcBAEBAgAGBQJWHKd5AAoJEPAKI6QtGt1xiR0P/RG1HnE4sNWHOv9lIC8spuSK
GO5SsfexcgGEhRNpJeQo+EJUyl+eU7hN1cCU8UYOhZZ2Jv3xvCf32l4LLG4FR+Se
N7RGlm5U5q7ZixNZQIErRYRvtw2hHWQW55pnC3Hw45mEvJm6za+lbyM/n7MmeIKR
xkEHJ4qA9UoQFppKtYXIeRwpfQQuuGbqpTDyyZCQVgusqmcr9XKiwrj2nbsD9o4Q
g1NNBlxl+4BUlpTKN72M4a/8ZtPpEx2GI1WPB5XbQWvOLugC74yDaK6KBqYuAt6d
q6oxUcbs+dzF4YtPmutvn496EDmXg8rTUOR+ilvMgsuqf8KHs0i8SJBn4my7EF5L
vrJDm7ZjsqXmQ231LvjFEN//SSYmr1CWiLVTIVfwCtvCFan9sdjlZXvcFzeGQLhg
6eRksCVOIB+xuiBFEM8w1a5tM29kVUaYtPFSRHxQPxcHE1QEVQVYSqrd7g+mhYED
HBJd8MBLVwwitNYKdDLQ/yw0EYH/2ZwbfNl1wbgUKaiNKWE1tXzC9IR0h9PgJikW
JTR13PdkoHosc4Km2NeS0ePPPolHy95l9/jIjAQeDLi7Ey3V+RwqY1UXrOuqVqqC
DYDp/NkPXsgx2HAMopNb0qRcpj7GBmOcgC7TkYrFHqSiKtXEQfzAOPrTklYhsaD/
eihYIY+6EpGbDhwWRwnE
=ZEVq
-END PGP SIGNATURE-
From c6524a252fc362abe5b8412dcabec499ff092143 Mon Sep 17 00:00:00 2001
From: Patrick Spendrin <ps...@gmx.de>
Date: Tue, 29 Sep 2015 15:47:09 +0200
Subject: [PATCH] WIP: configurable standardpaths

---
 src/corelib/global/global.pri |  1 +
 src/corelib/global/qlibraryinfo.cpp   | 49 +---
 src/corelib/global/qlibraryinfo_p.h   | 61 +++
 src/corelib/io/qstandardpaths.cpp | 42 
 src/corelib/io/qstandardpaths.h   |  2 ++
 src/corelib/io/qstandardpaths_mac.mm  |  4 +++
 src/corelib/io/qstandardpaths_win.cpp |  4 ++-
 7 files changed, 136 insertions(+), 27 deletions(-)
 create mode 100644 src/corelib/global/qlibraryinfo_p.h

diff --git a/src/corelib/global/global.pri b/src/corelib/global/global.pri
index 6a8104b..a905cb2 100644
--- a/src/corelib/global/global.pri
+++ b/src/corelib/global/global.pri
@@ -10,6 +10,7 @@ HEADERS +=  \
 global/qnumeric_p.h \
 global/qnumeric.h \
 global/qglobalstatic.h \
+global/qlibraryinfo_p.h \
 global/qlibraryinfo.h \
 global/qlogging.h \
 global/qtypeinfo.h \
diff --git a/src/corelib/global/qlibraryinfo.cpp 
b/src/corelib/global/qlibraryinfo.cpp
index 0cfcc4e..640e9cf 100644
--- a/src/corelib/global/qlibraryinfo.cpp
+++ b/src/corelib/global/qlibraryinfo.cpp
@@ -38,6 +38,7 @@
 #include "qsettings.h"
 #include "qlibraryinfo.h"
 #include "qscopedpointer.h"
+#include "qlibraryinfo_p.h"
 
 #ifdef QT_BUILD_QMAKE
 QT_BEGIN_NAMESPACE
@@ -77,37 +78,33 @@ struct QLibrarySettings
 };
 Q_GLOBAL_STATIC(QLibrarySettings, qt_library_settings)
 
-class QLibraryInfoPrivate
-{
-public:
-static QSettings *findConfiguration();
 #ifdef QT_BUILD_QMAKE
-static bool haveGroup(QLibraryInfo::PathGroup group)
-{
-QLibrarySettings *ls = qt_library_settings();
-return ls ? (group == QLibraryInfo::EffectiveSourcePaths
- ? ls->haveEffectiveSourcePaths
- : group == QLibraryInfo::EffectivePaths
-   ? ls->haveEffectivePaths
-   : group == QLibraryInfo::DevicePaths
- ? ls->haveDevicePaths
- : ls->havePaths) : false;
-}
+bool QLibraryInfoPrivate::haveGroup(QLibraryInfo::PathGroup group)
+{
+QLibrarySettings *ls = qt_library_settings();
+return ls ? (group == QLibraryInfo::EffectiveSourcePaths
+? ls->haveEffectiveSourcePaths
+: group == QLibraryInfo::EffectivePaths
+? ls->haveEffectivePaths
+: group == QLibraryInfo::DevicePaths
+? ls->h

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-12 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86693
---

Ship it!


Ship It!

- Patrick Spendrin


On Okt. 11, 2015, 4:54 nachm., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> ---
> 
> (Updated Okt. 11, 2015, 4:54 nachm.)
> 
> 
> Review request for kdewin and Pino Toscano.
> 
> 
> Repository: emerge
> 
> 
> Description
> ---
> 
> I've had to put #include  everywhere, not sure if it is a right 
> thing to do.
> 
> 
> Diffs
> -
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-10 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86615
---



portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (line 8)
<https://git.reviewboard.kde.org/r/125580/#comment59623>

This shouldn't be removed, because it might still be needed in other 
versions...



portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (line 34)
<https://git.reviewboard.kde.org/r/125580/#comment59624>

This should go into the default buildsystem as if(MSVC)
add_definitions(-DWIN32_LEAN_AND_MEAN)
endif()

I think.


- Patrick Spendrin


On Okt. 10, 2015, 9:13 vorm., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> ---
> 
> (Updated Okt. 10, 2015, 9:13 vorm.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> ---
> 
> I've had to put #include  everywhere, not sure if it is a right 
> thing to do.
> 
> 
> Diffs
> -
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-10 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86617
---


It might be good to have Albert Astals Cid (tsdgeos) or Pino Toscano (pinotree) 
as the patch needs to get upstream to poppler.

- Patrick Spendrin


On Okt. 10, 2015, 9:13 vorm., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> ---
> 
> (Updated Okt. 10, 2015, 9:13 vorm.)
> 
> 
> Review request for kdewin.
> 
> 
> Repository: emerge
> 
> 
> Description
> ---
> 
> I've had to put #include  everywhere, not sure if it is a right 
> thing to do.
> 
> 
> Diffs
> -
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: KCM's and Plasma-desktop

2015-10-09 Thread Patrick Spendrin

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 09.10.2015 um 13:30 schrieb Vishesh Handa:
> On Mon, Oct 5, 2015 at 5:20 PM, Hannah von Reth 
> wrote:
>> Baloo could be useful.
> 
> Baloo is only for linux. Windows has its own search solution far 
> superior to ours.

Well, I wouldn't remove the possibility to have a *free* and
opensource search solution available on Windows, even if there are
other solutions that seem to be far better; There should be a really
really good reason for that, there won't be users cannot even count as
an argument.
There will be people in the future that will attempt to get everything
running on Windows as well, I am pretty sure of that, and then this
decision will only make their way unnecessarily harder.

regards,
Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.21 (MingW32)

iQIcBAEBAgAGBQJWF6vrAAoJEPAKI6QtGt1xPzMP/AklOWk0HpCpbo58vv/pQgZY
+yu3i7oozH0IspkACzBPx36WsZqF6LWzrfvMsYfb2cTIOHQeHeusoKAa1BxQ2Kpj
cusZ1HEPSyLcuX7EX6Lsu2ozMNdqSQBiHR4qilFgg2X3g46TWU66jx5OBw4W9PiZ
U+bJQJD1xhJ6hLQCkOD3UgWZ4evwZOtZFCCRaBeFInETs1WLLzIZAGBsfW8znqbR
z0/54CvbmtPJrpCTUyDohU2kdWWqALvB2xJkOPCNzUJThuie7JBR707n6Zyo/yAu
NEsR8UNVuMSMT6JgqZHFWsIv6IvSwSppewNdqWo37/wcqCGhEf9WGl625/xzx3Ng
iayxamydn4VCQiLOqCPMhaL/W0zOt+6i66+3KZwUNcMmp/SIBsAOxIexzjyD8PcM
XYAokdjFBjoLkwmlUYvypXZXUoGM8c77GgjzNNaFzbOk23VqYPPgyh0Rd9b0DZmp
2kKFOCdaMSU6PO2EP50sdfOQyxgI8R/yK7zSQHG4fxGQKAuy5LmKh6JTQOfC8br/
AJyj4ZDh5Z/r1fk/HM+bMn1FGdbXwgfX9kHORM9+lDl8LiO53rKE+YOIXRRwqMWD
pUdhq45laxKDKQMeK9+tckq7R/7oZGLQDHD6b33Ptx+me4uH96bG7SZlmx0fGno/
maislStv5WqozXcWGuTP
=q9NB
-END PGP SIGNATURE-
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125401: implement windows usermetadata

2015-09-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125401/
---

(Updated Sept. 28, 2015, 9:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Changes
---

Submitted with commit da334383058cc72af032b811c6dda21d7b879f6d by Patrick R. 
Spendrin on behalf of Patrick Spendrin to branch master.


Repository: kfilemetadata


Description
---

I implemented all the functions for storing and retrieving user metadata
using Alternate Data Streams (ADS).


Diffs
-

  src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 
  src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 
  src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba 
  src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 

Diff: https://git.reviewboard.kde.org/r/125401/diff/


Testing
---

On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for 
other platforms


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125401: implement windows usermetadata

2015-09-27 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125401/
---

(Updated Sept. 27, 2015, 11:17 vorm.)


Review request for Baloo and kdewin.


Repository: kfilemetadata


Description
---

I implemented all the functions for storing and retrieving user metadata
using Alternate Data Streams (ADS).


Diffs
-

  src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 
  src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 
  src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba 
  src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 

Diff: https://git.reviewboard.kde.org/r/125401/diff/


Testing
---

On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for 
other platforms


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125401: implement windows usermetadata

2015-09-26 Thread Patrick Spendrin



> On Sept. 26, 2015, 10:52 vorm., Vishesh Handa wrote:
> > I cannot really comment on the windows parts. But the ideas seems good. 
> > Ship it?

Since I moved code around for *nix as well, could you check that it compiles at 
least (and maybe also works as before)? Otherwise I'll push it tomorrow...


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125401/#review85951
---


On Sept. 25, 2015, 10:43 nachm., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125401/
> ---
> 
> (Updated Sept. 25, 2015, 10:43 nachm.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> I implemented all the functions for storing and retrieving user metadata
> using Alternate Data Streams (ADS).
> 
> 
> Diffs
> -
> 
>   src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 
>   src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba 
>   src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 
>   src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 
> 
> Diff: https://git.reviewboard.kde.org/r/125401/diff/
> 
> 
> Testing
> ---
> 
> On Windows; since most of the code is ifdeffed anyway, it shouldn't matter 
> for other platforms
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 125401: implement windows usermetadata

2015-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125401/
---

Review request for Baloo and kdewin.


Repository: kfilemetadata


Description
---

I implemented all the functions for storing and retrieving user metadata
using Alternate Data Streams (ADS).


Diffs
-

  src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 
  src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba 
  src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 
  src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 

Diff: https://git.reviewboard.kde.org/r/125401/diff/


Testing
---

On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for 
other platforms


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 124911: replace noexcept by Q_DECL_NOEXCEPT

2015-08-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124911/
---

Review request for KDevelop and kdewin.


Repository: kdevplatform


Description
---

This makes it possible to build kdevplatform with msvc2013


Diffs
-

  plugins/outlineview/outlinenode.h fef935ac7d11a6e29190ae8330835a3fcf1b934d 

Diff: https://git.reviewboard.kde.org/r/124911/diff/


Testing
---

msvc2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 124881: Disable building GSL tests on MSVC

2015-08-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124881/#review84320
---


Hm, I'd prefer if we could fix the issue itself instead? Maybe we can also 
update gsl (if it hasn't happened yet).

- Patrick Spendrin


On Aug. 22, 2015, 3:43 nachm., Michael Abrahams wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124881/
 ---
 
 (Updated Aug. 22, 2015, 3:43 nachm.)
 
 
 Review request for kdewin.
 
 
 Repository: emerge
 
 
 Description
 ---
 
 Silences a linking error with multiply defined symbols in cdf/test.c in MSVC 
 2015
 
 
 Diffs
 -
 
   portage/win32libs/gsl/gsl-disable-testing-msvc.patch PRE-CREATION 
   portage/win32libs/gsl/gsl.py 8432312 
 
 Diff: https://git.reviewboard.kde.org/r/124881/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Michael Abrahams
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 124847: add COMMON_HEADER option and multiple header functionality

2015-08-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124847/
---

(Updated Aug. 25, 2015, 9:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, kdewin, and Allen Winter.


Changes
---

Submitted with commit 8ef3f474e3a6def47dce36b54fbdce2d98c79342 by Patrick 
Spendrin to branch master.


Repository: extra-cmake-modules


Description
---

This adds a new keyword COMMON_HEADER which generates a new header
containing all other headers. Also it is possible now to have multiple
dummy headers per header file. It is assumed that the first header is the
existing one.
This patch has been developed originally for kdsoap / kdreports.


Diffs
-

  modules/ECMGenerateHeaders.cmake b6290223cdf696968637b75f66217abcd680b3e2 
  tests/ECMGenerateHeadersTest/CommonHeader PRE-CREATION 
  tests/ECMGenerateHeadersTest/headtest4.h PRE-CREATION 
  tests/ECMGenerateHeadersTest/run_test.cmake.config 
1db623b7349d72ff3e90dcb274d9a0c8cba8dab0 

Diff: https://git.reviewboard.kde.org/r/124847/diff/


Testing
---

Windows and Linux


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 124847: add COMMON_HEADER option and multiple header functionality

2015-08-20 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124847/
---

Review request for Extra Cmake Modules, kdewin and Allen Winter.


Repository: extra-cmake-modules


Description
---

This adds a new keyword COMMON_HEADER which generates a new header
containing all other headers. Also it is possible now to have multiple
dummy headers per header file. It is assumed that the first header is the
existing one.
This patch has been developed originally for kdsoap / kdreports.


Diffs
-

  modules/ECMGenerateHeaders.cmake b6290223cdf696968637b75f66217abcd680b3e2 
  tests/ECMGenerateHeadersTest/CommonHeader PRE-CREATION 
  tests/ECMGenerateHeadersTest/headtest4.h PRE-CREATION 
  tests/ECMGenerateHeadersTest/run_test.cmake.config 
1db623b7349d72ff3e90dcb274d9a0c8cba8dab0 

Diff: https://git.reviewboard.kde.org/r/124847/diff/


Testing
---

Windows and Linux


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 124818: Fix update-mime-database crash.

2015-08-19 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124818/#review84066
---


it worked under 32bit, and worked on Linux. I haven't seen the crash on x64 
though, so maybe you can describe it a bit more?

- Patrick Spendrin


On Aug. 19, 2015, 1:42 nachm., arrowdodger arrowdodger wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124818/
 ---
 
 (Updated Aug. 19, 2015, 1:42 nachm.)
 
 
 Review request for kdewin.
 
 
 Repository: emerge
 
 
 Description
 ---
 
 VS was picking wrong function types for opendir/readdir because there was no 
 prototypes for them in dirent.h, which lead to crash.
 The second crash was due to writing 8-byte intptr_t value returned by 
 _findfirst() into a 4-byte long variable.
 No idea how it was working before.
 
 
 Diffs
 -
 
   portage/win32libs/shared-mime-info/dirent.h b98296a 
   portage/win32libs/shared-mime-info/dirent.c 2ca945a 
 
 Diff: https://git.reviewboard.kde.org/r/124818/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 arrowdodger arrowdodger
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Removal help needed

2015-08-12 Thread Patrick Spendrin

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 11.08.2015 um 11:58 schrieb Anne Wilson:
 Hi.  I have KDE installed on an older laptop which has just been 
 upgraded from Windows 7 to Windows 10.  The KDE apps are no longer
 used on that laptop (they are 2 years old), so I wanted to remove
 them, but all my efforts have failed.
 
 They are not installed within the Windows Programs system, and I
 thought I remembered that they had to be uninstalled using the KDE 
 Installer-GUI.  I did that, and got messages that they were 
 uninstalling, but coming back to the laptop afterwards I found that
 the command window with a message from kdewin4init (misremembered
 name?) still opens, and all the programs are back in the
 appropriate folders.
 
 Since another family member will be using that laptop I need to
 clean it up, so what should I do to properly remove them?

Try to open the windows task manager, navigate to the processes tab,
and close all KDE processes, that is kded4.exe, kdeinit4.exe... and
dbus-daemon.exe .

Then go to the installation directory and remove the complete
installation directory.

To cleanup also the user settings, open the explorer, and go to
%APPDATA% and remove the .kde directory.

If removing a file fails, check that you really killed all processes
in question.

 
 Anne

regards,
Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.21 (MingW32)

iQIcBAEBAgAGBQJVyveKAAoJEPAKI6QtGt1xNnEQAI8DQq2bYsD6oevjtwHh6FP8
CxFOHp0c23c/VHW/0uFclgFe/GrR3NCVCxrCOMwITjAD9Qo3hsTKmKoAMN1n3KJl
L24xFKcvMhXgo0YQyxsbPY/sAouZ9se1ysbjE/wPMVI9dgx4SysgysBiMc3/0Y/p
d4VEYDeYa2xVE79c8jSkTWg+ml50FrdXn9afkNOG0huGxdJAdLIMezCREjm6mNL2
2fmVDUKGMCRDRBH1ddnnT6bzZbpBVTuM9zSqQY7AQwAuQSJ7opGjwOGSsJNXAlSn
04kybQuR4Zru2b2rCKjxjMGYjwSygEQbgQy3qNSX9nABLJtuWj42R2wWoi+r59z+
lbzJh+3US9CIl7chqzUc0Nqq/SIp85/obn56GKCyNgeIvlduIoVSDDqMQXMM5b+Y
9tnjnDDb1Wi7cdHpM9lrm8uyA/cTgJwOA48adzcsdReck66vsC/YgMXo7uA5vpLY
qsvC3EjnfBdaJAuhwZxTBvBheivFjnJIJSpdrTQ6stwP7hOrXjq6Xw/iVXYDUIBN
F1BG8j0bwCvUliiHc6SBrDwBXbZzLpetTF7l1pqCrGGJNVWyL9ibH5dlCW4/QdaK
D49GFnVZQaDZahDa3FGponconbTuD3L8V3E9+pAfF/Croc1qpu9tRuanxEuHwHUg
+i7DXBUsIYWntGEq5+oP
=kBpf
-END PGP SIGNATURE-
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117829: do not raise unknown signal on windows

2015-02-04 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/
---

(Updated Feb. 4, 2015, 4:09 p.m.)


Status
--

This change has been discarded.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

this signal is not available on windows. Also exit should behave in a similar 
way, so maybe exit can be used everywhere?


Diffs
-

  src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 

Diff: https://git.reviewboard.kde.org/r/117829/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 122177: some minor fixes for windows

2015-01-20 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122177/
---

Review request for KDE Frameworks and kdewin.


Repository: kglobalaccel


Description
---

some minor fixes for windows


Diffs
-

  src/runtime/CMakeLists.txt a8fbfa1612a86f7371bf56926ec46fe14422a73a 
  src/runtime/main.cpp f9cf9b353f00f1f68906d97f61cea5314a3663e4 

Diff: https://git.reviewboard.kde.org/r/122177/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows

2014-10-17 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120481/#review68626
---


Well, I have two different things in mind: first of all, I can see the point of 
simplification, I doubt that it will be interesting though to build KDE in the 
near (next 5y) future with X11/Wayland. Second, the X11 situation is normally 
abstracted by Qt, so there is nearly never a need to have X11 code on windows, 
we don't build most of the stuff. And third, it is easy to add a REQUIRED in 
the find_package line, because normally developers don't think twice (This is 
linux after all, why shouldn't it have X11?!???). This will likely produce some 
errors, although I am not sure how severe this will be. So I am not really for 
it, but I am also not against it.

- Patrick Spendrin


On Okt. 16, 2014, 6:48 nachm., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120481/
 ---
 
 (Updated Okt. 16, 2014, 6:48 nachm.)
 
 
 Review request for Extra Cmake Modules, kdewin and Martin Gräßlin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 While the search is unlikely to succeed on Windows, having different
 behaviour between the platforms (eg: find_package(Wayland REQUIRED) was
 not fatal on Windows, even though Wayland_FOUND would always be FALSE)
 is not ideal, and if someone did port them to Windows for some reason,
 the find modules should support that.
 
 If applications actually want different behaviour between platforms
 (like requiring a module on Unix, but not on Windows), they should
 implement that logic themselves (since they will have to deal with
 targets not being defined, etc, anyway).
 
 
 Diffs
 -
 
   find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da 
   find-modules/FindWayland.cmake 11716f0497db380e94b3d8ef69f41546f789 
   find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79 
   find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081 
 
 Diff: https://git.reviewboard.kde.org/r/120481/diff/
 
 
 Testing
 ---
 
 None whatsoever, since I want Martin's feedback on the idea first.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120365: export functions that are needed in the other dlls

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120365/
---

(Updated Sept. 25, 2014, 2:02 nachm.)


Review request for KDevelop, kdewin and Miquel Sabaté Solà.


Repository: kdev-ruby


Description
---

On Windows, functions that are needed in another dll, need to be exported


Diffs
-

  parser/node.h 70472d200462a2df64caf144c0a06d23b54a7417 
  parser/parser.y 56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 

Diff: https://git.reviewboard.kde.org/r/120365/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120366: variable length arrays can't be static on windows

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120366/
---

(Updated Sept. 25, 2014, 2:03 nachm.)


Review request for KDevelop, kdewin and Miquel Sabaté Solà.


Repository: kdev-ruby


Description
---

variable length arrays can't be static on windows, so we use malloc/free 
instead. Since I am not sure if this is suitable and if there is a better way 
around this restriction, I want you to review this.


Diffs
-

  parser/parser.y 56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 

Diff: https://git.reviewboard.kde.org/r/120366/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120364: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120364/
---

(Updated Sept. 25, 2014, 2:02 nachm.)


Review request for KDevelop, kdewin and Miquel Sabaté Solà.


Repository: kdev-ruby


Description
---

This generates export headers and removes the self written versions


Diffs
-

  completion/CMakeLists.txt efa1c1c5c1f21bd8ccf49d95fe781bfc21b117af 
  completion/completionexport.h dc27f1abb5978e04f39bd710490655a4805b4fe5 
  duchain/CMakeLists.txt 15bf13a7d7d605c53e158d4901465d19b0cb2aff 
  duchain/duchainexport.h 8bda0c6243167c8ce2fe92c188851d37ee6346fe 
  parser/CMakeLists.txt d62947f2e2574a29b715d95795da0541ad12c195 
  parser/export.h ca61e6116172d9ad2ca8db378fc76e5c2551039d 
  rails/CMakeLists.txt 043d347f32caead63f9df009cac0985b2343bc8e 
  rails/export.h 4b6260282df53726d4b3b60b17dc5237a61dd5dc 

Diff: https://git.reviewboard.kde.org/r/120364/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120367: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120367/
---

Review request for KDevelop, kdewin, Milian Wolff, and Niko Sams.


Repository: kdev-php


Description
---

replace export headers w. generate_export_headers

the include_directories are needed because it isn't possible to reference the 
build directory from inside the source files.


Diffs
-

  duchain/CMakeLists.txt d57c45224fe3d5ece78ac432489becd1b3d1ce02 
  completion/CMakeLists.txt e68290b59acf5882d315d44da117ca66778fac02 
  completion/phpcompletionexport.h 5958009d3429a8154f26c37b10b0ea4521f71a54 
  completion/tests/CMakeLists.txt 749ae72e0c1932a5d502b29a957daa9aef8c54e6 
  parser/CMakeLists.txt d658dff79e8a536015def29077fafeed1aae72e3 
  parser/parserexport.h 42820da8f22ca4b127e64bf8288af645af10ed83 
  duchain/navigation/navigationwidget.h 
56b4dc3d66b1660d9d23cfe47eac02a40cfdc3ad 
  duchain/phpduchainexport.h 0b8328239d768dbf5e898e8e5c3b9037b88ba08b 
  duchain/tests/CMakeLists.txt 524466d985a4fe0c80e4c1315c34258eb3cd976e 

Diff: https://git.reviewboard.kde.org/r/120367/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120368: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120368/
---

Review request for KDevelop, kdewin and Denis Steckelmacher.


Repository: kdev-qmljs


Description
---

replace export headers w. generate_export_headers


Diffs
-

  codecompletion/CMakeLists.txt 3a1c071eb32eb50b13e4469d1029a8cb9fb427a1 
  codecompletion/codecompletionexport.h 
9761699217d04f1e96283a3056edd14f25ef37e3 
  duchain/CMakeLists.txt 583f37f3651366490467a95716df52d632cb4a57 
  duchain/duchainexport.h 3447989cdc43260a7c1d07a8165f4d4a77f5efea 
  duchain/frameworks/nodejs.h 7f00d01a900c0d53a435794f80de513e06c0c6d3 
  duchain/navigation/navigationwidget.h 
0d462223f81aacf2f920503d7c064c338b16c05e 

Diff: https://git.reviewboard.kde.org/r/120368/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120365: export functions that are needed in the other dlls

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120365/
---

(Updated Sept. 25, 2014, 9:40 nachm.)


Status
--

This change has been marked as submitted.


Review request for KDevelop, kdewin and Miquel Sabaté Solà.


Repository: kdev-ruby


Description
---

On Windows, functions that are needed in another dll, need to be exported


Diffs
-

  parser/node.h 70472d200462a2df64caf144c0a06d23b54a7417 
  parser/parser.y 56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 

Diff: https://git.reviewboard.kde.org/r/120365/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120364: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120364/
---

(Updated Sept. 25, 2014, 9:40 nachm.)


Status
--

This change has been marked as submitted.


Review request for KDevelop, kdewin and Miquel Sabaté Solà.


Repository: kdev-ruby


Description
---

This generates export headers and removes the self written versions


Diffs
-

  completion/CMakeLists.txt efa1c1c5c1f21bd8ccf49d95fe781bfc21b117af 
  completion/completionexport.h dc27f1abb5978e04f39bd710490655a4805b4fe5 
  duchain/CMakeLists.txt 15bf13a7d7d605c53e158d4901465d19b0cb2aff 
  duchain/duchainexport.h 8bda0c6243167c8ce2fe92c188851d37ee6346fe 
  parser/CMakeLists.txt d62947f2e2574a29b715d95795da0541ad12c195 
  parser/export.h ca61e6116172d9ad2ca8db378fc76e5c2551039d 
  rails/CMakeLists.txt 043d347f32caead63f9df009cac0985b2343bc8e 
  rails/export.h 4b6260282df53726d4b3b60b17dc5237a61dd5dc 

Diff: https://git.reviewboard.kde.org/r/120364/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120367: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120367/
---

(Updated Sept. 25, 2014, 9:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDevelop, kdewin, Milian Wolff, and Niko Sams.


Repository: kdev-php


Description
---

replace export headers w. generate_export_headers

the include_directories are needed because it isn't possible to reference the 
build directory from inside the source files.


Diffs
-

  duchain/CMakeLists.txt d57c45224fe3d5ece78ac432489becd1b3d1ce02 
  completion/CMakeLists.txt e68290b59acf5882d315d44da117ca66778fac02 
  completion/phpcompletionexport.h 5958009d3429a8154f26c37b10b0ea4521f71a54 
  completion/tests/CMakeLists.txt 749ae72e0c1932a5d502b29a957daa9aef8c54e6 
  parser/CMakeLists.txt d658dff79e8a536015def29077fafeed1aae72e3 
  parser/parserexport.h 42820da8f22ca4b127e64bf8288af645af10ed83 
  duchain/navigation/navigationwidget.h 
56b4dc3d66b1660d9d23cfe47eac02a40cfdc3ad 
  duchain/phpduchainexport.h 0b8328239d768dbf5e898e8e5c3b9037b88ba08b 
  duchain/tests/CMakeLists.txt 524466d985a4fe0c80e4c1315c34258eb3cd976e 

Diff: https://git.reviewboard.kde.org/r/120367/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120368: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120368/
---

(Updated Sept. 25, 2014, 9:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDevelop, kdewin and Denis Steckelmacher.


Repository: kdev-qmljs


Description
---

replace export headers w. generate_export_headers


Diffs
-

  codecompletion/CMakeLists.txt 3a1c071eb32eb50b13e4469d1029a8cb9fb427a1 
  codecompletion/codecompletionexport.h 
9761699217d04f1e96283a3056edd14f25ef37e3 
  duchain/CMakeLists.txt 583f37f3651366490467a95716df52d632cb4a57 
  duchain/duchainexport.h 3447989cdc43260a7c1d07a8165f4d4a77f5efea 
  duchain/frameworks/nodejs.h 7f00d01a900c0d53a435794f80de513e06c0c6d3 
  duchain/navigation/navigationwidget.h 
0d462223f81aacf2f920503d7c064c338b16c05e 

Diff: https://git.reviewboard.kde.org/r/120368/diff/


Testing
---

windows msvc 2013


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Patrick Spendrin



 On Sept. 22, 2014, 10:53 nachm., Luigi Toscano wrote:
  Re-reading the code and the comments, the core of the problem is described 
  later, in another part which should be touched by the patch. The comment 
  says:
  
  # WARNING: this has severe limitations on the windows platform since the 
  .xsl
  #  docbook files need to be relocatable. We cannot just replace the paths 
  in
  # the .xsl with relative paths because these files are not installed while
  # building kdoctools. Instead, we will reconfigure those files at install 
  time
  # with relative paths.
  So is the limitation due to the fact that file(RELATIVE_PATH can't compute 
  in advance the relative path with non-existing files as argument?

I think the issue was the following: when building kdelibs, kdoctools was used 
to generate documentation for the stuff in kdelibs. For this to work, there had 
to be a hardcoded path to the windows location of the docbook dtds inside some 
of the dtds from kdoctools. When installing, you would take a second copy of 
the configured file, and install that; this copy would have a relative path in 
it.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120324/#review67245
---


On Sept. 22, 2014, 10:44 nachm., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120324/
 ---
 
 (Updated Sept. 22, 2014, 10:44 nachm.)
 
 
 Review request for Build System, KDE Frameworks and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 Unify most of the CMake code which generates the DTD instead of duplicating 
 the functionalities for WIN32 and non-WIN32 execution. The WIN32 branch only 
 needs to compute the relative path, the rest of the code can be shared.
 
 If accepted, a similar patch can be applied to kdelibs4support.
 
 
 Diffs
 -
 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120324/diff/
 
 
 Testing
 ---
 
 Tested on a Linux-based based system only, needs input from Windows 
 developers.
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120096/
---

Review request for KDE Frameworks and kdewin.


Repository: karchive


Description
---

on windows static arrays can only be initialized with a const


Diffs
-

  src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 

Diff: https://git.reviewboard.kde.org/r/120096/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118852/#review60850
---



autotests/kconfigtest.cpp
https://git.reviewboard.kde.org/r/118852/#comment42406

Did you try out whether removing the Flags calls did change something?


- Patrick Spendrin


On June 21, 2014, 12:20 a.m., Nicolás Alvarez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118852/
 ---
 
 (Updated June 21, 2014, 12:20 a.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kconfig
 
 
 Description
 ---
 
 Visual C++ 2010 throws an internal compiler error trying to compile 
 kconfigtest, since 5f4dc2973f. I couldn't figure out a non-intrusive code 
 tweak that would work around the ICE, so I had to skip compiling this 
 particular initialization code on this particular compiler version, and skip 
 running the test that relies on it (testEnums).
 
 The dummy=42 entry is so that the config group isn't empty, which makes 
 testGroupCopyTo and testReparent still run and pass.
 
 
 Diffs
 -
 
   autotests/kconfigtest.cpp a8482b7 
 
 Diff: https://git.reviewboard.kde.org/r/118852/diff/
 
 
 Testing
 ---
 
 Compiles on MSVC2010, kconfigtest passes (with testEnums skipped).
 
 I haven't tried compiling on other compilers.
 
 
 Thanks,
 
 Nicolás Alvarez
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

2014-06-11 Thread Patrick Spendrin

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



Am 11.06.2014 12:25, schrieb Marco Martin:
 On Wednesday 11 June 2014, Martin Gräßlin wrote:
 Hi all!
 
 The review request [1] raised the question whether it makes sense
 that we have any support for building without X11 support. Right
 now the build without X11 is broken, nevertheless there are many
 checks of the kind
 
 if(NOT WIN32)
 
 or
 
 #if defined(Q_OS_UNIX)  !defined(Q_OS_MAC)
 
 Personally I care more about plasma-framework building and working
 (even if partially) on as much platforms as possible. 
 plasma-workspace and plasma-desktop.. not really.
 
 However, if the kde-windows team takes the responsibility to
 maintain them building for me is fine. (on windows would have
 anyways to be a very partial build i guess)
 
 

to say the truth, the quality of the KDE4 code on windows is bad, if
working at all. There is no real need as well, so unless someone
actually either steps up to fix this and invest serious time (or
serious money) into that, I don't want to have plasma desktop on
windows for now. We have a lot of other places to work on.
So my conclusion is that you should go ahead and cleanup your code as
it won't be to much help anyway if somebody wants to port plasma to
windows again in the future.

regards,
Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.21 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTmFwGAAoJEPAKI6QtGt1xBYsP/RLudNXwK9j2EfDPRET+Ve7d
nx7rcmqpf0tM1pPZXEjCaRNAkfk+vjI06ger8wK4pQvd8hrxPdkhHgu+s+uFm+DO
ecYPSyOOrSbH+qPfoUDC3S+LSD5R+IAocyxCZ5WSSBDd7fn1IhkfTKrnoE6jx4Ph
6Pw8NI0YArD3vhgYXzwoi8j8mj65W1jSkghqzKP6eglYg8+yMQMY7ZRARBApW8Sr
XHPT8D9lfcYDhB8NLnFtlVpKRsdP/qb6ei0O8NvpQ+1xZGOXJjpTMBl5jc4WWRiF
FNIQoz0YGHBTPSZVo27qUh7j5q9fpgYI7XLlM27RdcwEUlRl/9y6G9zLeEWuh9jN
zHLmfiiBzLpkQ5uHIb0IL9xys/nubZOGhwcJQR6Oe52EmAOSNwUzRtHttVD0ahsJ
6rU5qkBxNmAGYHZGhwvBsmrWtUR84eGoIcj9RRhli2pjQAPhdXsiHEMQxuzgcizQ
L5Vd7x5jGLyTPke8GmZWZb4WnIGBWKzDcd7UiRBYx/AuR1OkftjxWxBrGumYidz6
YY6S3DPU7VPKVD+X80Jh4qgkE2Xh4z1zFPSo2NfdGqL0rEELiahpvwIj6xMfEp9F
MpyBd2rYvSBZmoHtB3MsK/2xzFCbJI7hc8yITobVG4nVU6MEC2LDZq6zqAbS3YoH
/CtlZ2+PQkjJHljDhmX2
=/uc1
-END PGP SIGNATURE-
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118147/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

fix running ECMKDEModules test


Diffs
-

  tests/ExecuteKDEModules/CMakeLists.txt 
e149ec7af0f85cf3b4a0e3501fc23befad6403b9 

Diff: https://git.reviewboard.kde.org/r/118147/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118119/
---

(Updated May 15, 2014, 2:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

remove unneeded header


Diffs
-

  src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 

Diff: https://git.reviewboard.kde.org/r/118119/diff/


Testing
---

mingw windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118153/
---

Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

remove unneeded file which collides with kf5plasma exports


Diffs
-

  autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 

Diff: https://git.reviewboard.kde.org/r/118153/diff/


Testing
---

mingw


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118155/
---

Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

adapt to ecm_add_tests so that tests can be found


Diffs
-

  autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 

Diff: https://git.reviewboard.kde.org/r/118155/diff/


Testing
---

mingw


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118147/
---

(Updated May 15, 2014, 7:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

fix running ECMKDEModules test


Diffs
-

  tests/ExecuteKDEModules/CMakeLists.txt 
e149ec7af0f85cf3b4a0e3501fc23befad6403b9 

Diff: https://git.reviewboard.kde.org/r/118147/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118153/
---

(Updated May 15, 2014, 9:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

remove unneeded file which collides with kf5plasma exports


Diffs
-

  autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 

Diff: https://git.reviewboard.kde.org/r/118153/diff/


Testing
---

mingw


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118115: adapt to ecm_add_test

2014-05-13 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118115/
---

Review request for Kate, KDE Frameworks, kdewin, and Christoph Cullmann.


Repository: ktexteditor


Description
---

adapt to ecm_add_test


Diffs
-

  autotests/CMakeLists.txt 24b3f1f711d41d692b48b90ba0830812f80a 
  autotests/src/vimode/CMakeLists.txt 1bac4ff5670d9ba60b019365c08aa9de50f8f192 

Diff: https://git.reviewboard.kde.org/r/118115/diff/


Testing
---

mingw

I have no idea how the current state without this patch would be on windows, 
since this patch is required to run the tests at all.

The following tests FAILED:
 34 - movingrange_test (Failed)
 35 - kateview_test (Failed)
 42 - completion_test (Failed)
 43 - indenttest (Failed)
 44 - commands_test (Failed)
 45 - scripting_test (SEGFAULT)
 46 - bug313759 (Failed)
 51 - keys (Failed)

If some of these now fail on Linux too, please tell me.


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118119: remove unneeded header

2014-05-13 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118119/
---

Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

remove unneeded header


Diffs
-

  src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 

Diff: https://git.reviewboard.kde.org/r/118119/diff/


Testing
---

mingw windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118085: adapt to ecm_add_tests

2014-05-12 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118085/
---

(Updated May 12, 2014, 8:53 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kservice


Description
---

adapt to ecm_add_tests


Diffs
-

  autotests/CMakeLists.txt 0584baad2b0b4f2ddb7c8cbfbfbb33ade072007e 
  tests/pluginlocator/CMakeLists.txt cae2a8b823f14acd93eef6e2dc01783b67810626 

Diff: https://git.reviewboard.kde.org/r/118085/diff/


Testing
---

windows gcc, not all tests pass, and I can't say if that is due to my change 
(it shouldn't be)


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118085: adapt to ecm_add_tests

2014-05-11 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118085/
---

Review request for KDE Frameworks and kdewin.


Repository: kservice


Description
---

adapt to ecm_add_tests


Diffs
-

  autotests/CMakeLists.txt 0584baad2b0b4f2ddb7c8cbfbfbb33ade072007e 
  tests/pluginlocator/CMakeLists.txt cae2a8b823f14acd93eef6e2dc01783b67810626 

Diff: https://git.reviewboard.kde.org/r/118085/diff/


Testing
---

windows gcc, not all tests pass, and I can't say if that is due to my change 
(it shouldn't be)


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118026: Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows

2014-05-07 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118026/#review57477
---

Ship it!


looks good, I don't remember what weird reason required us to use the current 
setup. If it becomes a problem, we have to modify it anyway.

- Patrick Spendrin


On May 6, 2014, 8:29 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118026/
 ---
 
 (Updated May 6, 2014, 8:29 p.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kinit
 
 
 Description
 ---
 
 Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows
 
 No longer create an empty dummy library, instead create a static library
 with all the sources and link the exectuable to that.
 
 This fixes the build of Kate on Windows since some unit tests use
 target_link_libraries(test kdeinit_kate) and since that library was empty
 it would not contain the required symbols
 
 
 Diffs
 -
 
   CMakeLists.txt 9e34058ab612732adba50331db624d2c307da0dd 
   KF5InitMacros.cmake 1768bc96573ca0fabf6bf620e4ff0a3f5f3646a5 
   kde5init_win32lib_dummy.cpp.in d727297578834ba2f2c3ee8f086c355244f116de 
 
 Diff: https://git.reviewboard.kde.org/r/118026/diff/
 
 
 Testing
 ---
 
 Kate tests link now, didn't before
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117962: forward declare specialisation

2014-05-06 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117962/
---

(Updated May 6, 2014, 1:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

This is needed because otherwise mingw will use the inherited
specialisations for KUserId / KGroupId instead and fail with an
error that specialisation happens after instantiation.


Diffs
-

  src/lib/util/kuser.h 7b14ab2b2b31fcc3c624bba6068df6ad80b779fe 

Diff: https://git.reviewboard.kde.org/r/117962/diff/


Testing
---

mingw gcc, *nix and msvc still required


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117961: remove several warnings on mingw

2014-05-06 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/
---

(Updated May 6, 2014, 1:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

remove several warnings on mingw


Diffs
-

  autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
  autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
  autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
  src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 

Diff: https://git.reviewboard.kde.org/r/117961/diff/


Testing
---

mingw only, needs testing on *nix and on msvc


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

KF5 on Windows IRC meeting tonight

2014-05-06 Thread Patrick Spendrin

Hi everybody,

for those interested, there will be a kf5 meeting on #kde-windows on
freenode tonight at 20:00 UTC (22:00 CEST).

Some topics can be gathered on the wiki page:
http://techbase.kde.org/Projects/KDE_on_Windows/kf5/meetingnotes-2014-05-06

sorry for the short notice,

regards,
Patrick
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-04 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---

(Updated May 4, 2014, 4:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use the correct global variables 
CMAKE_[RUNTIME|ARCHIVE|LIBRARY]_OUTPUT_DIRECTORY. dlls and executables are 
built into the bin subdir and import  static libraries and plugins end up in 
the lib subdir of the build directory.


Diffs
-

  kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 

Diff: https://git.reviewboard.kde.org/r/117965/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117961: remove several warnings on mingw

2014-05-03 Thread Patrick Spendrin



 On May 3, 2014, 4:25 a.m., Nicolás Alvarez wrote:
  src/lib/util/kuser_win.cpp, line 849
  https://git.reviewboard.kde.org/r/117961/diff/1/?file=271202#file271202line849
 
  What's the warning here? Is it about signed vs unsigned? If so, change 
  the format specifier to %u instead of casting.

no, the warning is about DWORD vs. (long) int.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57173
---


On May 2, 2014, 9:16 p.m., Patrick Spendrin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117961/
 ---
 
 (Updated May 2, 2014, 9:16 p.m.)
 
 
 Review request for KDE Frameworks, kdewin and Alexander Richardson.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 remove several warnings on mingw
 
 
 Diffs
 -
 
   autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
   autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
   autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
   src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 
 
 Diff: https://git.reviewboard.kde.org/r/117961/diff/
 
 
 Testing
 ---
 
 mingw only, needs testing on *nix and on msvc
 
 
 Thanks,
 
 Patrick Spendrin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin



 On May 3, 2014, 10:10 a.m., Alex Merry wrote:
  kde-modules/KDECMakeSettings.cmake, lines 170-176
  https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
 
  Now the comment doesn't match the code - which is correct?

The fix here is that RUNTIME_OUTPUT_DIRECTORY - CMAKE_RUNTIME_OUTPUT_DIRECTORY 
because the first one is a target property and not a global variable. I also 
modified the CMAKE_ARCHIVE|LIBRARY_OUTPUT_DIRECTORY's values, but that isn't 
strictly required.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
---


On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117965/
 ---
 
 (Updated May 2, 2014, 10:53 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 use the correct global variables
 
 
 Diffs
 -
 
   kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 
 
 Diff: https://git.reviewboard.kde.org/r/117965/diff/
 
 
 Testing
 ---
 
 windows
 
 
 Thanks,
 
 Patrick Spendrin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---

(Updated May 3, 2014, 3:35 p.m.)


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description (updated)
---

use the correct global variables 
CMAKE_[RUNTIME|ARCHIVE|LIBRARY]_OUTPUT_DIRECTORY. dlls and executables are 
built into the bin subdir and import  static libraries and plugins end up in 
the lib subdir of the build directory.


Diffs
-

  kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 

Diff: https://git.reviewboard.kde.org/r/117965/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin



 On May 3, 2014, 10:10 a.m., Alex Merry wrote:
  kde-modules/KDECMakeSettings.cmake, lines 170-176
  https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170
 
  Now the comment doesn't match the code - which is correct?
 
 Patrick Spendrin wrote:
 The fix here is that RUNTIME_OUTPUT_DIRECTORY - 
 CMAKE_RUNTIME_OUTPUT_DIRECTORY because the first one is a target property and 
 not a global variable. I also modified the 
 CMAKE_ARCHIVE|LIBRARY_OUTPUT_DIRECTORY's values, but that isn't strictly 
 required.
 
 Patrick von Reth wrote:
 yes but you install the dll to ${CMAKE_BINARY_DIR}/lib
 
   set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
 Patrick Spendrin wrote:
 No, the dll is RUNTIME so it goes into /bin.
 
 Alex Merry wrote:
 Well, I would view the comment as misleading, then. The code isn't 
 combining the executable and dll locations, CMake does that anyway.

I modified the comment now, as I said before, this has nothing to do with 
whether dlls or exes end up anywhere, but that both currently are in the 
default location (CMAKE_CURRENT_BINARY_DIR) and not in one location as it is 
needed to run unittests etc. without modifying the path.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
---


On May 3, 2014, 3:35 p.m., Patrick Spendrin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117965/
 ---
 
 (Updated May 3, 2014, 3:35 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 use the correct global variables 
 CMAKE_[RUNTIME|ARCHIVE|LIBRARY]_OUTPUT_DIRECTORY. dlls and executables are 
 built into the bin subdir and import  static libraries and plugins end up in 
 the lib subdir of the build directory.
 
 
 Diffs
 -
 
   kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 
 
 Diff: https://git.reviewboard.kde.org/r/117965/diff/
 
 
 Testing
 ---
 
 windows
 
 
 Thanks,
 
 Patrick Spendrin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-03 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117967/
---

(Updated May 3, 2014, 9:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use different syntax to run the target in question instead of an executable in 
the path.
Currently cmake uses some logic to find the executable in the path or in some 
subdirectories of the current directory. It doesn't look for targets of the 
same name though, which is the wanted behaviour here.


Diffs
-

  modules/ECMAddTests.cmake 9052d8863fb9447b751387199e649efaedc69a3d 

Diff: https://git.reviewboard.kde.org/r/117967/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---

(Updated May 3, 2014, 10:45 p.m.)


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use the correct global variables 
CMAKE_[RUNTIME|ARCHIVE|LIBRARY]_OUTPUT_DIRECTORY. dlls and executables are 
built into the bin subdir and import  static libraries and plugins end up in 
the lib subdir of the build directory.


Diffs (updated)
-

  kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 

Diff: https://git.reviewboard.kde.org/r/117965/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated May 2, 2014, 12:55 p.m.)


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/tests/CMakeLists.txt 52662c1515b07a79126d387241f192c3d46dab30 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated May 2, 2014, 1:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/tests/CMakeLists.txt 52662c1515b07a79126d387241f192c3d46dab30 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/
---

Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

remove several warnings on mingw


Diffs
-

  autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
  autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
  autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
  src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 

Diff: https://git.reviewboard.kde.org/r/117961/diff/


Testing
---

mingw only, needs testing on *nix and on msvc


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117962: forward declare specialisation

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117962/
---

Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

This is needed because otherwise mingw will use the inherited
specialisations for KUserId / KGroupId instead and fail with an
error that specialisation happens after instantiation.


Diffs
-

  src/lib/util/kuser.h 7b14ab2b2b31fcc3c624bba6068df6ad80b779fe 

Diff: https://git.reviewboard.kde.org/r/117962/diff/


Testing
---

mingw gcc, *nix and msvc still required


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117965: use the correct global variables

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use the correct global variables


Diffs
-

  kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 

Diff: https://git.reviewboard.kde.org/r/117965/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117851: fix finding the dummy extractor

2014-04-29 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117851/
---

(Updated April 29, 2014, 11:09 a.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

the dummy extractor executable is moved into the local build directory and
the setting of the path is adapted to the required windows path separator


Diffs
-

  src/file/autotest/fileindexingjob/CMakeLists.txt 
3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a 
  src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 
8a0ca84f74f622990766d737ee6a1b108dca9068 

Diff: https://git.reviewboard.kde.org/r/117851/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117825/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

at the moment, extended attributes are not supported on windows. The headers do 
not exist as well, so the check fails all the time.


Diffs
-

  ConfigureChecks.cmake 34db1e4 

Diff: https://git.reviewboard.kde.org/r/117825/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117826/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

Since removing the directories still fails on windows atm, I want to let the 
test fail in the correct place.


Diffs
-

  src/pim/akonadiplugin/autotests/searchplugintest.cpp 1c0b452 

Diff: https://git.reviewboard.kde.org/r/117826/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure 
what the exact purpose of this call is (is the memory not freed elsewhere?), so 
I'd like to have some comments on it.


Diffs
-

  src/xapian/xapiandatabase.cpp 0478139 

Diff: https://git.reviewboard.kde.org/r/117827/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

If using class definitions of exported classes in tests, the export/import 
mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.


Diffs
-

  src/file/autotest/CMakeLists.txt a54736e 
  src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
  src/file/lib/autotests/CMakeLists.txt 95a0916 
  src/file/search/autotest/CMakeLists.txt eb058d2 
  src/file/tests/CMakeLists.txt 102c981 

Diff: https://git.reviewboard.kde.org/r/117828/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117829: do not raise unknown signal on windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

this signal is not available on windows. Also exit should behave in a similar 
way, so maybe exit can be used everywhere?


Diffs
-

  src/file/autotest/fileindexingjob/extractor.cpp a6d14d7 

Diff: https://git.reviewboard.kde.org/r/117829/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

At the moment, there is no support available for extended attributes for 
Windows/NTFS. So we simply disable it.


Diffs
-

  src/file/lib/baloo_xattr_p.h fefc3d9 
  src/file/lib/xattrdetector.cpp 9bff838 

Diff: https://git.reviewboard.kde.org/r/117830/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

hidden files on windows must not start with a . So instead use QFileInfo to 
correctly check that files are hidden and also modify the test and use the 
native function.


Diffs
-

  src/file/autotest/fileindexerconfigutils.h ab52f3b 

Diff: https://git.reviewboard.kde.org/r/117832/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin



 On April 28, 2014, 12:41 p.m., Vishesh Handa wrote:
  I'm a little surprised that NTFS doesn't support xattr, but sure!
 
 Thomas Lübking wrote:
 NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite 
 length xattr via ADS only, so basically xattr invocation would have to be 
 ported for Windows.

I think that would be indeed a way to address this, but I don't want to port it 
right away.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/#review56737
---


On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117830/
 ---
 
 (Updated April 28, 2014, 9:58 a.m.)
 
 
 Review request for Baloo and kdewin.
 
 
 Repository: baloo
 
 
 Description
 ---
 
 At the moment, there is no support available for extended attributes for 
 Windows/NTFS. So we simply disable it.
 
 
 Diffs
 -
 
   src/file/lib/baloo_xattr_p.h fefc3d9 
   src/file/lib/xattrdetector.cpp 9bff838 
 
 Diff: https://git.reviewboard.kde.org/r/117830/diff/
 
 
 Testing
 ---
 
 windows msvc 2010
 
 
 Thanks,
 
 Patrick Spendrin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin



 On April 28, 2014, 1:24 p.m., Reece Dunn wrote:
  The *A Windows API variants use the ASCII (referred to as ANSI in the 
  Windows docs), not UTF-8, encoding. Therefore, this will not work as 
  expected for non-ASCII characters. This should use SetFileAttributeW with 
  toUtf16.

The files used in the test use ascii encoding though, so it works.
I'll change it anyway though.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/#review56750
---


On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117832/
 ---
 
 (Updated April 28, 2014, 10:05 a.m.)
 
 
 Review request for Baloo and kdewin.
 
 
 Repository: baloo
 
 
 Description
 ---
 
 hidden files on windows must not start with a . So instead use QFileInfo to 
 correctly check that files are hidden and also modify the test and use the 
 native function.
 
 
 Diffs
 -
 
   src/file/autotest/fileindexerconfigutils.h ab52f3b 
 
 Diff: https://git.reviewboard.kde.org/r/117832/diff/
 
 
 Testing
 ---
 
 windows msvc 2010
 
 
 Thanks,
 
 Patrick Spendrin
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

If using class definitions of exported classes in tests, the export/import 
mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.


Diffs
-

  src/file/autotest/CMakeLists.txt a54736e 
  src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
  src/file/lib/autotests/CMakeLists.txt 95a0916 
  src/file/search/autotest/CMakeLists.txt eb058d2 
  src/file/tests/CMakeLists.txt 102c981 

Diff: https://git.reviewboard.kde.org/r/117828/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117830/
---

(Updated April 28, 2014, 2:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

At the moment, there is no support available for extended attributes for 
Windows/NTFS. So we simply disable it.


Diffs
-

  src/file/lib/baloo_xattr_p.h fefc3d9 
  src/file/lib/xattrdetector.cpp 9bff838 

Diff: https://git.reviewboard.kde.org/r/117830/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117827/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

malloc_trim is a gnu extension, so it doesn't work on windows. I am not sure 
what the exact purpose of this call is (is the memory not freed elsewhere?), so 
I'd like to have some comments on it.


Diffs
-

  src/xapian/xapiandatabase.cpp 0478139 

Diff: https://git.reviewboard.kde.org/r/117827/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117825/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

at the moment, extended attributes are not supported on windows. The headers do 
not exist as well, so the check fails all the time.


Diffs
-

  ConfigureChecks.cmake 34db1e4 

Diff: https://git.reviewboard.kde.org/r/117825/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117826/
---

(Updated April 28, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

Since removing the directories still fails on windows atm, I want to let the 
test fail in the correct place.


Diffs
-

  src/pim/akonadiplugin/autotests/searchplugintest.cpp 1c0b452 

Diff: https://git.reviewboard.kde.org/r/117826/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117846/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

make filesearchstoretest a console application
This is essentially only needed to not have the output of the file when running 
make test cluttered between the ctest output.


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 

Diff: https://git.reviewboard.kde.org/r/117846/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117845: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 28, 2014, 3:33 p.m.)


Review request for Baloo and kdewin.


Summary (updated)
-

rename test as another exists with the same name


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 28, 2014, 8:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
  src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117846/
---

(Updated April 28, 2014, 8:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

make filesearchstoretest a console application
This is essentially only needed to not have the output of the file when running 
make test cluttered between the ctest output.


Diffs
-

  src/file/search/autotest/CMakeLists.txt 
836ef2bfb29562aa36d8ebca8678932e5f01e0f3 

Diff: https://git.reviewboard.kde.org/r/117846/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/
---

(Updated April 29, 2014, 12:01 a.m.)


Review request for Baloo and kdewin.


Repository: baloo


Description
---

rename test as another exists with the same name


Diffs
-

  src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 

Diff: https://git.reviewboard.kde.org/r/117845/diff/


Testing
---

msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117851: fix finding the dummy extractor

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117851/
---

(Updated April 29, 2014, 12:02 a.m.)


Review request for Baloo and kdewin.


Repository: baloo


Description
---

the dummy extractor executable is moved into the local build directory and
the setting of the path is adapted to the required windows path separator


Diffs
-

  src/file/autotest/fileindexingjob/CMakeLists.txt 
3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a 
  src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 
8a0ca84f74f622990766d737ee6a1b108dca9068 

Diff: https://git.reviewboard.kde.org/r/117851/diff/


Testing (updated)
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117832/
---

(Updated April 29, 2014, 12:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
---

hidden files on windows must not start with a . So instead use QFileInfo to 
correctly check that files are hidden and also modify the test and use the 
native function.


Diffs
-

  src/file/autotest/fileindexerconfigutils.h ab52f3b 

Diff: https://git.reviewboard.kde.org/r/117832/diff/


Testing
---

windows msvc 2010


Thanks,

Patrick Spendrin

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-24 Thread Patrick Spendrin



 On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
  Until now we had no problems with the data installed to bin/../share  and 
  this setup would make it impossible to have multiple independent  kde 
  setups on one system.
 
 Alexander Richardson wrote:
 I know. The problem is QStandardPaths with 
 QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I 
 think %APPDATA%. KF5 based KDE software won't work otherwise since it can't 
 find the data. I think the better way of fixing this is patching Qt, but for 
 now this works.
 
 Patrick Spendrin wrote:
 Can you keep that patch locally for now and we try and come up with a 
 patch for Qt instead? We cannot restrict ourselves at that point I think.
 
 Alexander Richardson wrote:
 Sure no problem. I'll drop this request
 
 David Faure wrote:
 So what do you recommend instead, for QStandardPaths? Checking some 
 non-standard environment variable? or?
 
 Alexander Richardson wrote:
 I would go for the environment variable. Something like 
 QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default 
 dirs.
 
 Would also be useful for other cases: e.g. in the okteta unit tests I set 
 XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there 
 is QFINDTESTDATA, but that won't work in that case).
 
 It would also be nice if there were some cross-platform solution like 
 QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString 
 path) to inject (like KStandardDirs::addResourceDir).
 
 Patrick von Reth wrote:
 I don't like the idea of using the env var as this would require the user 
 to setup the variables or a kde process to set them up.
 We also would get an undefined behaviour if the env var is not set.
 I think kde is not the only qt project ported to windows wich uses the 
 bin/../share location on windows, so why not only add this path with a low 
 priority to QStrandardpathes?

 
 David Faure wrote:
 I agree that the env var would be quite inconvenient, which is why I was 
 dubious about that approach.
 
 A method to add paths wouldn't help either (how would all apps do it?)
 
 bin/../share means go up one level from the location of the executable 
 and enter share? I thought Windows apps didn't use a bin/ dir actually, but 
 were rather in the toplevel?
 Anyhow I'd be fine with that, especially if you can find any 
 documentation of this outside of kde (to explain the reasoning in the Qt 
 change request).
 
 Andrius da Costa Ribas wrote:
 As far as I can see:
 
 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, 
 $PREFIX/share etc... and PREFIX is not standard on windows (those apps 
 normally don't use %PROGRAMFILES%)
  * Other autoconf-based apps and libs also follow this structure
  * even those using %PROGRAMFILES% also follow this structure (e.g. for 
 GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside 
 it)
 2 - Most CMake-based apps also follow a similar pattern, relative to 
 $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a 
 different directory structure
  * Cmake itself is distributed in this kind of structure 
 (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip)
 
 I think those can explain the reasoning needed for a Qt request.
 
 David Faure wrote:
 Yes, a single monolithic can somehow find out about its own PREFIX (e.g. 
 by writing it into the registry at install time, right? Or indeed from the 
 path where the .exe is being started, simply).
 
 But the issue here is what if you install several apps (and possibly 
 several frameworks), and they need to find each other's stuff...

 
 Andrius da Costa Ribas wrote:
 That's the exact same situation of using XDG_DATA_DIRS on *nix. For 
 KDE-Windows we install all packages into the same prefix for a given KDE set 
 up.

We had these arguments already when thinking about how to install KDE on 
Windows, a thing where we do have almost all possible control.
- One argument why this doesn't work is that there are multiple (incompatible) 
compilers on windows. Since e.g. plugins etc. are incompatible, you can either 
enforce one single compiler (that is virtually impossible for pure Qt 
applications, but it would be possible to some extend for KDE apps).
- Since shared data is very likely also version dependent, you'll have to 
invent versioned folders (e.g. %ALLUSERSPROFILE%\kde-share-5.4.0-123deadbeef 
vs. %ALLUSERSPROFILE%\kde-share-5.4.0-123cafecafe). This actually moves the 
problem of finding compatible versions to another location and messes up 
ALLUSERSPROFILE.
- What about security issues? If I install an application as a single user in a 
separate partition (so to hide it from cops... ;-)), you'd leave an unwanted 
trace in that case. Similar problems can occur with portable apps where you 
might not even have access

Re: Review Request 117649: gcrypt: Fix VERSION variable in generated gcrypt.h

2014-04-19 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117649/#review56069
---

Ship it!


I guess the reason for the problem originally is that the cmake config.h file 
is derived from the autotools one (only with some scripted changes 
sed/#define/#cmakedefine/ etc.). So the way to provide the correct version 
number is this ugly way in cmake. If this change improves the version handling, 
then it obviously should go in right away though.
I have to say though that for gcrypt we will have to maintain the cmake stuff 
ourselves anyway, so no need to be shy here: just commit it.

- Patrick Spendrin


On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117649/
 ---
 
 (Updated April 19, 2014, 7:24 p.m.)
 
 
 Review request for kdewin.
 
 
 Repository: emerge
 
 
 Description
 ---
 
 It was generating #define GCRYPT_VERSION 1.5.3 (with duplicated quotes), 
 now it's the correct 1.5.3.
 
 Note that this patch might not apply cleanly on its own as I made it on top 
 of review #117646; but I can rebase it if requested.
 
 
 Diffs
 -
 
   portage/win32libs/gcrypt/libgcrypt-1.5.3-cmake.diff 5f0ad04 
 
 Diff: https://git.reviewboard.kde.org/r/117649/diff/
 
 
 Testing
 ---
 
 Builds, MSVC2010. Visually inspected generated gcrypt.h.
 
 
 Thanks,
 
 Nicolás Alvarez
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117646: Drop support for Windows CE on gcrypt

2014-04-19 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117646/#review56070
---

Ship it!


As Andy said, it isn't used, so just go ahead.

- Patrick Spendrin


On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117646/
 ---
 
 (Updated April 19, 2014, 7:24 p.m.)
 
 
 Review request for kdewin.
 
 
 Repository: emerge
 
 
 Description
 ---
 
 Remove Windows CE compatibility code from the gcrypt patches and CMake build 
 system.
 
 We don't really support Windows CE anymore (that was for an old kdepim-on-CE 
 project that is long over and dead), and removing the compat code simplifies 
 the patches and makes them more maintainable.
 
 
 Diffs
 -
 
   portage/win32libs/gcrypt/libgcrypt-1.5.3-cmake.diff 5f0ad04 
   portage/win32libs/gcrypt/libgcrypt-1.5.0-20110831.diff 35bbd39 
 
 Diff: https://git.reviewboard.kde.org/r/117646/diff/
 
 
 Testing
 ---
 
 Still builds, MSVC2010 32-bit.
 
 
 Thanks,
 
 Nicolás Alvarez
 


___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[kde-windows] [Bug 330827] When I start kde on cygwin64, kded4 seems like go to infinity loop and KDE stucks. If i remove kded, all OK, but all servcies are disabled

2014-02-09 Thread Patrick Spendrin

https://bugs.kde.org/show_bug.cgi?id=330827

Patrick Spendrin ps...@gmx.de changed:

   What|Removed |Added

 CC||ps...@gmx.de

--- Comment #2 from Patrick Spendrin ps...@gmx.de ---
Hm, normally KDE on cygwin is not KDE on Windows...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

Re: Where is konsole?

2014-01-24 Thread Patrick Spendrin

Am 23.01.2014 14:08, schrieb Yuri Samoilenko:
 Because Konsole is just way to display a terminal window, and not the
 terminal itself. Konsole itself only sends and receives the information
 from the terminal, which means on Windows, Konsole actually wraps those
 nice black shitty console windows you can see sometimes.
 
 
 Yes, there is no nice display for terminal window under windows, for
 example KDE for Windows team uses Console2 for this puproses but it is
 ugly in compare to Konsole/Yakuake. Does Konsole theoreticaly can wrap
 windows cmd.exe or MSYS/Cygwin sh implementations and provide nice
 tabbing, shortcuts etc...?
Yes, it can use both cmd.exe and sh.exe (whichever you want). Tabbing is
standard, not sure about shortcuts, I might not have implemented
everything yet.

regards,
Patrick
 
  
 
 
 ___
 Kde-windows mailing list
 Kde-windows@kde.org
 https://mail.kde.org/mailman/listinfo/kde-windows
 

___
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

1 2 3 4 5 6 7 >

1 - 100 of 689 matches

Mail list logo