Re: [Kicad-developers] Wrong dependencies in build
Thanks for chasing this down. It couldn't have been easy. On Thu, May 30, 2019 at 3:38 PM Simon Richter wrote: > > Hi, > > we have some intermittent build failures that I've tried to debug today. As > parallelism is involved, I now want to set everything on fire. > > Symptom: if we have enough CPUs, the lexer generation is started multiple > times in parallel for the same outputs. The first platform where we saw > this was MSVC, but I can also get it on Linux, although the timing is a bit > tighter there. As a result, the generated header file is broken in various > ways -- on MSVC, every second token in the enumeration swaps place with its > comma, on Linux we get two copies of the file interleaved. > > According to the fine folks on the #cmake IRC channel, what we're doing > since b7f890adb "Fix parallel build bugs." is illegal, because output files > from a custom command are consumed by two different projects -- i.e. rather > than the intention that the files are built in the custom target, now the > custom target causes another avenue where a parallel build needs to prepare > the files. > > I have no immediate idea how to write this so it is safe for any number of > CPUs and portable everywhere, so if anyone does, it'd be nice if they'd fix > it, because I probably won't get around to it for a while. > >Simon > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Wrong dependencies in build
Hi, we have some intermittent build failures that I've tried to debug today. As parallelism is involved, I now want to set everything on fire. Symptom: if we have enough CPUs, the lexer generation is started multiple times in parallel for the same outputs. The first platform where we saw this was MSVC, but I can also get it on Linux, although the timing is a bit tighter there. As a result, the generated header file is broken in various ways -- on MSVC, every second token in the enumeration swaps place with its comma, on Linux we get two copies of the file interleaved. According to the fine folks on the #cmake IRC channel, what we're doing since b7f890adb "Fix parallel build bugs." is illegal, because output files from a custom command are consumed by two different projects -- i.e. rather than the intention that the files are built in the custom target, now the custom target causes another avenue where a parallel build needs to prepare the files. I have no immediate idea how to write this so it is safe for any number of CPUs and portable everywhere, so if anyone does, it'd be nice if they'd fix it, because I probably won't get around to it for a while. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Crash Reporter
On 5/30/19 2:49 PM, Tomasz Wlostowski wrote: > On 30/05/2019 16:46, Wayne Stambaugh wrote: >> Hey Tom, >> >> On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: >>> On 30/05/2019 00:35, Wayne Stambaugh wrote: A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up to date. A note to the lead dev team, please do not push your personal development branches to the main kicad repo. Thanks. >>> >>> Hi Wayne, >>> >>> I hope I didn't push anything personal to the repo on Launchpad (if so, >>> it could have happened by accident). >> >> No problem. I see that your already removed it from the main repo. Thanks. >> >>> >>> Just in case, I attached the crash reporter as patches. >> >> I finally got the crash reporter to build on windows. Just out of >> curiosity, does the crash reporter not show anything to the user? When >> I force a crash using the menu entry, I don't see anything indicating >> that a crash report was generated or where the crash information might >> be saved. Are my expectations out of line here or is there something >> wrong with the crash reporter on windows builds. I haven't tested this >> on linux yet. I should get to that later today. >> > > Hi Wayne, > > It should show a big 'We're sorry, Kicad just crashed' window. Do you > run KiCad standalone or from the project manager? What is your build > configuration under Windows? > > Tom > Nothing was displayed. I was running from the project manager. I even crashed the project manager. I'm using msys2 to create mingw32 and mingw64 debug builds of KiCad. I'm using wxWidgets 3.0.4 (not a debug build). I did not check to see if the msys2 wxWidgets package builds are configured with wxDebugReport enabled so maybe that was the issue. I'll check the next time I'm in windows. However, your debug reporter branch built fine so I suspect this was not the issue. Wayne ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [RFC] Test for Copper zones using solid polygons without outline thickness.
Le 29/05/2019 à 21:31, Seth Hillbrand a écrit : > On 2019-05-29 10:33, jp charras wrote: >> Attached a patch that modify the way filled areas (solid polygons) are >> built in copper areas. >> >> Currently, solid polygons are slightly smaller than the exact area, and >> the polygon outlines have a thickness to fill the exact area. >> With this patch, polygon outlines have no thickness and the polygons >> have the exact area. >> >> To test it on a given zone, the zone setting must be edited with the >> "Fill polys without thick outline" checked. > > > Hi JP- > > Why did you decide to make this a user option? Is there some feature > that it prevents that a user would want for some areas but not for others? > > I tested it with a large board and it reduces the polygon point count by > almost 50% (!) for complex fills. If I zoom in on an edge, it appears > that the approximation count is substantially coarsened by the patch. > See attached image. The edge on the right is with the new option > enabled. The edge of the left is without the new option. > > I didn't find any other issues. Large boards were much faster and DRC / > plotting appear consistent between options (with the exception noted above) > > -Seth Thanks Seth for your test. Currently, having a user option is useful to test and compare the 2 options (the current way, and the new way). The new way can reduce or augment the polygon points count, depending on the board. However the the polygon points count should not significantly change. (this is important to avoid to many calculation time in DRC, connections...) The old (current way) using segments to draw outlines, rounded acute angles are more beautiful (are perfect). The new way approximate rounded acute angles by segments (16 segments by circle). This is really enough, but this is less beautiful, and this is the price to pay to remove thick outlines, and the associated issues. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Crash Reporter
On 30/05/2019 16:46, Wayne Stambaugh wrote: > Hey Tom, > > On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: >> On 30/05/2019 00:35, Wayne Stambaugh wrote: >>> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up >>> to date. >>> >>> A note to the lead dev team, please do not push your personal >>> development branches to the main kicad repo. Thanks. >>> >> >> Hi Wayne, >> >> I hope I didn't push anything personal to the repo on Launchpad (if so, >> it could have happened by accident). > > No problem. I see that your already removed it from the main repo. Thanks. > >> >> Just in case, I attached the crash reporter as patches. > > I finally got the crash reporter to build on windows. Just out of > curiosity, does the crash reporter not show anything to the user? When > I force a crash using the menu entry, I don't see anything indicating > that a crash report was generated or where the crash information might > be saved. Are my expectations out of line here or is there something > wrong with the crash reporter on windows builds. I haven't tested this > on linux yet. I should get to that later today. > Hi Wayne, It should show a big 'We're sorry, Kicad just crashed' window. Do you run KiCad standalone or from the project manager? What is your build configuration under Windows? Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Crash Reporter
Hey Tom, On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: > On 30/05/2019 00:35, Wayne Stambaugh wrote: >> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up >> to date. >> >> A note to the lead dev team, please do not push your personal >> development branches to the main kicad repo. Thanks. >> > > Hi Wayne, > > I hope I didn't push anything personal to the repo on Launchpad (if so, > it could have happened by accident). No problem. I see that your already removed it from the main repo. Thanks. > > Just in case, I attached the crash reporter as patches. I finally got the crash reporter to build on windows. Just out of curiosity, does the crash reporter not show anything to the user? When I force a crash using the menu entry, I don't see anything indicating that a crash report was generated or where the crash information might be saved. Are my expectations out of line here or is there something wrong with the crash reporter on windows builds. I haven't tested this on linux yet. I should get to that later today. Wayne > > Tom > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
