Re: [Kicad-developers] 5.1.5 release tag

[Adam Wolf]

I set rc1 to build earlier today.  I can upload it when it finishes and if
folks can test it, I can easily rebuild as 5.1.5 tomorrow!

On Wed, Nov 20, 2019, 4:59 PM Wayne Stambaugh  wrote:

> I'm willing to push the release date up if the MacOS package is ready.
> Just let me know.
>
> Cheers,
>
> Wayne
>
> On 11/20/19 5:46 PM, Nick Østergaard wrote:
> > 5.1.5 is fairly well rolled out now, thanks to various good people :)
> >
> > To make the release official, I think we are only needing the macos
> > build. @Adam Wolf  if you need any help, please speak up.
> >
> >
> > Nick
> >
> > On Wed, 20 Nov 2019 at 19:33, Steven A. Falco 
> wrote:
> >>
> >> Fedora Rawhide has 5.1.5 now.  Fedora 30 and 31 will have 5.1.5 in a
> week or so, depending on whether we get any karma.
> >>
> >> Also of note - as of 5.1.5 we are now using OCC on all builds.  OCE is
> no longer needed for current Fedora releases.
> >>
> >> Steve
> >>
> >> On 11/17/19 11:56 AM, Rene Pöschl wrote:
> >>> Libraries have been tagged.
> >>>
> >>> On 14/11/2019 18:36, Wayne Stambaugh wrote:
>  The 5.1 branch has been tagged for 5.1.5 and the source archive has be
>  uploaded to launchpad.  Please tag the library, doc, and translation
>  repos so we can fire up those packages builders.
> 
>  Thanks,
> 
>  Wayne
> 
>  On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
> > It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
> > seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow
> around
> > noon EST unless something comes up.  I'm assuming the libraries,
> > documentation, and translations are ready to go and that it shouldn't
> > take too long to get most of the installer packages build and
> uploaded
> > to the KiCad website.  I would like to make the release announcement
> on
> > Wednesday, November 27th.  It would be something to be thankful for
> > leading into the US Thanksgiving Holiday.  If there are any issues
> with
> > this date, please let me know.  Thank you everyone for your continued
> > support of the KiCad project.
> >
> > Cheers,
> >
> > Wayne
> >
>  ___
>  Mailing list: https://launchpad.net/~kicad-developers
>  Post to : kicad-developers@lists.launchpad.net
>  Unsubscribe : https://launchpad.net/~kicad-developers
>  More help   : https://help.launchpad.net/ListHelp
> >>>
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release tag

[Brüns , Stefan]

On Mittwoch, 20. November 2019 19:33:53 CET Steven A. Falco wrote:
> Fedora Rawhide has 5.1.5 now.  Fedora 30 and 31 will have 5.1.5 in a week or
> so, depending on whether we get any karma.
> 
> Also of note - as of 5.1.5 we are now using OCC on all builds.  OCE is no
> longer needed for current Fedora releases.
> 

openSUSE provides 5.1.5 for all stable (Leap) and rolling (Tumbleweed) 
distribution versions in the "electronics" project, and Tumbleweed users will 
receive it automatically in a few days.

electronics repo:

https://software.opensuse.org/download/package?
package=kicad=electronics

Kind regards,

Stefan
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release tag

[Wayne Stambaugh]

I'm willing to push the release date up if the MacOS package is ready.
Just let me know.

Cheers,

Wayne

On 11/20/19 5:46 PM, Nick Østergaard wrote:
> 5.1.5 is fairly well rolled out now, thanks to various good people :)
> 
> To make the release official, I think we are only needing the macos
> build. @Adam Wolf  if you need any help, please speak up.
> 
> 
> Nick
> 
> On Wed, 20 Nov 2019 at 19:33, Steven A. Falco  wrote:
>>
>> Fedora Rawhide has 5.1.5 now.  Fedora 30 and 31 will have 5.1.5 in a week or 
>> so, depending on whether we get any karma.
>>
>> Also of note - as of 5.1.5 we are now using OCC on all builds.  OCE is no 
>> longer needed for current Fedora releases.
>>
>> Steve
>>
>> On 11/17/19 11:56 AM, Rene Pöschl wrote:
>>> Libraries have been tagged.
>>>
>>> On 14/11/2019 18:36, Wayne Stambaugh wrote:
 The 5.1 branch has been tagged for 5.1.5 and the source archive has be
 uploaded to launchpad.  Please tag the library, doc, and translation
 repos so we can fire up those packages builders.

 Thanks,

 Wayne

 On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
> It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
> seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow around
> noon EST unless something comes up.  I'm assuming the libraries,
> documentation, and translations are ready to go and that it shouldn't
> take too long to get most of the installer packages build and uploaded
> to the KiCad website.  I would like to make the release announcement on
> Wednesday, November 27th.  It would be something to be thankful for
> leading into the US Thanksgiving Holiday.  If there are any issues with
> this date, please let me know.  Thank you everyone for your continued
> support of the KiCad project.
>
> Cheers,
>
> Wayne
>
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release tag

[Nick Østergaard]

5.1.5 is fairly well rolled out now, thanks to various good people :)

To make the release official, I think we are only needing the macos
build. @Adam Wolf  if you need any help, please speak up.


Nick

On Wed, 20 Nov 2019 at 19:33, Steven A. Falco  wrote:
>
> Fedora Rawhide has 5.1.5 now.  Fedora 30 and 31 will have 5.1.5 in a week or 
> so, depending on whether we get any karma.
>
> Also of note - as of 5.1.5 we are now using OCC on all builds.  OCE is no 
> longer needed for current Fedora releases.
>
> Steve
>
> On 11/17/19 11:56 AM, Rene Pöschl wrote:
> > Libraries have been tagged.
> >
> > On 14/11/2019 18:36, Wayne Stambaugh wrote:
> >> The 5.1 branch has been tagged for 5.1.5 and the source archive has be
> >> uploaded to launchpad.  Please tag the library, doc, and translation
> >> repos so we can fire up those packages builders.
> >>
> >> Thanks,
> >>
> >> Wayne
> >>
> >> On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
> >>> It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
> >>> seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow around
> >>> noon EST unless something comes up.  I'm assuming the libraries,
> >>> documentation, and translations are ready to go and that it shouldn't
> >>> take too long to get most of the installer packages build and uploaded
> >>> to the KiCad website.  I would like to make the release announcement on
> >>> Wednesday, November 27th.  It would be something to be thankful for
> >>> leading into the US Thanksgiving Holiday.  If there are any issues with
> >>> this date, please let me know.  Thank you everyone for your continued
> >>> support of the KiCad project.
> >>>
> >>> Cheers,
> >>>
> >>> Wayne
> >>>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Back annotate references from PCB

[Wayne Stambaugh]

On 11/7/19 5:06 AM, Alexander Shuklin wrote:
> Hi,
> is it alright to answer anybody in one letter?
> First of all, don't take amiss if I keep silence for a day, as I have
> 2 little children and at the best case I have couple of hours a day on
> my own.
> 
> On Wed, 6 Nov 2019 at 16:27, Wayne Stambaugh  wrote:
>> Complex schematic hierarchies (using the same schematic more than once in a 
>> design) always trips up new developers.
> Can you please explain a bit more? I know that you can use
> hierarchical sheets, so there will be more than one sch files in the
> schematic. And there's also "multi-symbols" which have few eeschema
> symbols but one footprint. I'm not quite understand what means "using
> the same schematic more than once in a design", as every symbol has
> unique ID. Is it something else I'm not aware of?

Yes, every symbol has a unique path ID but that doesn't mean that the
board and the schematic will always be in sync so this is where issues
come into play.  There also can be unique IDs from other projects
because schematics can be shared between projects so you have to be
careful not to break all of these cases.

>> You'll want to take a close look at KIWAY::ExpressMail() and 
>> KIWAY_PLAYER::KiwayMailIn()
> Ok, I'll look at that. I think I've seen that in footprints back annotation.
>> This is unfortunate.  Being able to work directly with on of the lead 
>> developers would have made this task a lot easier to understand.  You are 
>> always free to reach out for help on this mailing list.
> Thanks for that. Actually now i think to join FOSDEM, but I need visa
> and I'm not sure yet.
>> Asking first prevents you from working on something that someone else may 
>> already be working on and writing code that would be immediately rejected
> Actually I already made that mistake, when made board statistics
> dialog. It was accepted, but I felt myself really stupid.
>> Good luck and thank you for your interest in contributing to KiCad.
> Thanks! I will try hard to match coding and git polices.
> 
> On Wed, 6 Nov 2019 at 17:24, Jon Evans  wrote:
>> Eeschema now keeps its internal net state up to date continuously, but I 
>> didn't work on any continuous syncing to PcbNew.  The way it works in 
>> Eeschema, the graphical schematic is still the driving source of truth; the 
>> netlist does not drive the schematic.
> Am I right in general idea: Eeschema creates netlist which updates
> continuously. And PCB updates through eeschema by "uppdate PCB from
> schematic" tool. It isn't planned to do that automatically and
> continuously, is it?
> 
> On Wed, 6 Nov 2019 at 17:56, Brian Piccioni  
> wrote:
>> My utility is up on GitHub as a standalone app. I learned enough c++ and 
>> wxWidgets so porting it to Kicad should be useful.
> I've seen your app, and bug report. And actually I try to jump in
> because I use geometrical renumber of components as well)))
>> Replacing my homebrew parsing of PCB, Schematic, and netlist files to calls 
>> to internal Kicad functions/methods in the respective apps;
>> Once this is done I’ll use Kiway to communicate the changes between eeSchema 
>> and PCBNew.
> Have you already start to create communication between eeschema and
> pcbnew? If not, don't you mind if I'll start with that first? From my
> point of view, that's a worst part in this question today. For example
> you can renumber modules in pcbnew even by python scripts, but you
> have no any tool to change schematic after that. And by the way it's
> not only about renumber of all components. Somebody would like to
> change some references in pcbnew by hand at push that data back to
> schematics.
>> In the final version, if I understand correctly, in V6 changes to the PCB 
>> will be back-annotated to the schematic in order to support pin and  gate 
>> swapping. So updating the PCB will immediately incorporate the changes to 
>> the schematic. I haven’t seen any discussions of how this will be done but 
>> clearly if the prototype as described above works it will be trivial to 
>> support the V6 common database.
> Hm... I haven't think about that... I'm not sure if pin swapping will
> interact with back-annotation tool. I wouldn't say that, but if
> somebody has comments and thoughts about that, it would be greatly
> appreciated.
> 
> As far as I see now, It should be some tool a bit similar to "Update
> PCB from schematic", which will utilize KiWay functions to send data
> between PCBnew and eeschema..
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

[Franck Jullien]

Le lun. 11 nov. 2019 à 16:59, Franck Jullien
 a écrit :
>
> Hi again !
>
> I now have fixed the commit message to include a tag (ADD).
>
> Franck.

If it can help the review, you can find this patch on github:

https://github.com/fjullien/kicad/commit/350f5fc0ad7c128c3d152317297468a7b9516e62

Franck.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] suggestion: draw text selection as simple rectangle

[ja...@veith.net]

On 20.11.19 20:37, Jonatan Liljedahl wrote:

  If yes, does it need to be configurable?


We had a color blind fellow designer. The schematic entry
(ACE-Plus) derived its colors from the library
- no chance for user setup ...

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] suggestion: draw text selection as simple rectangle

[Eeli Kaikkonen]

Jonatan, have you read this forum discussion:
https://forum.kicad.info/t/selection-highlighting-in-development-version/18694
?

Eeli Kaikkonen


ke 20. marrask. 2019 klo 21.37 Jonatan Liljedahl (li...@kymatica.com)
kirjoitti:

> Hi list,
> Here's another suggestion, to draw the boundary box of selected text
> instead of drawing the text itself with the thick selection shadow.
> See attached screenshot.
>
> Is this a good idea? If yes, does it need to be configurable?
> Personally I find it a lot easier and visually less tiresome.
>
> --
> /Jonatan
> http://kymatica.com
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] suggestion: draw text selection as simple rectangle

[Jonatan Liljedahl]

Hi list,
Here's another suggestion, to draw the boundary box of selected text
instead of drawing the text itself with the thick selection shadow.
See attached screenshot.

Is this a good idea? If yes, does it need to be configurable?
Personally I find it a lot easier and visually less tiresome.

-- 
/Jonatan
http://kymatica.com
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema selection appearance

[Jonatan Liljedahl]

On Wed, Nov 20, 2019 at 5:55 PM Seth Hillbrand  wrote:

> On 11/20/19 7:11 AM, Jonatan Liljedahl wrote:
>
> Ok, I'll look into making it configurable. However, I find the current
> default appearance hard to use, so maybe one could consider changing
> the defaults in that case?
>
> Everyone likes to have their preferences as the default.  This is not a
> useful line of discussion for the project.  Once the options are
> configurable, it shouldn't be an issue.
>

My point was that maybe it's not only a matter of personal preference, but
usability and good UX design. Options are good, but that's no reason not
trying to find the best possible defaults for those options. Of course, if
it's only me that thinks my proposal improves things in general, let me
know :)

> Additionally, I changed the shadow width algo constants as follows, to
> avoid the feeling of the selection shadow changing size drastically as
> you zoom:
>
> Please move this idea into a separate patch and propose it.  The selection
> highlight width works well at all zoom levels for me but if this idea helps
> some people without negatively impacting the current situation, there
> should be no issues.  Please keep this distinct from the options patch,
> however.
>

Ok, will do! BTW, this is an example where I don't think a user setting
makes sense, which might be called something like "Amount of zoom-level
impact on selection shadow thickness". Better to just find the values for
those constants that looks good and coherent.

-- 
/Jonatan
http://kymatica.com
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release tag

[Steven A. Falco]

Fedora Rawhide has 5.1.5 now.  Fedora 30 and 31 will have 5.1.5 in a week or 
so, depending on whether we get any karma.

Also of note - as of 5.1.5 we are now using OCC on all builds.  OCE is no 
longer needed for current Fedora releases.

Steve

On 11/17/19 11:56 AM, Rene Pöschl wrote:
> Libraries have been tagged.
> 
> On 14/11/2019 18:36, Wayne Stambaugh wrote:
>> The 5.1 branch has been tagged for 5.1.5 and the source archive has be
>> uploaded to launchpad.  Please tag the library, doc, and translation
>> repos so we can fire up those packages builders.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
>>> It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
>>> seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow around
>>> noon EST unless something comes up.  I'm assuming the libraries,
>>> documentation, and translations are ready to go and that it shouldn't
>>> take too long to get most of the installer packages build and uploaded
>>> to the KiCad website.  I would like to make the release announcement on
>>> Wednesday, November 27th.  It would be something to be thankful for
>>> leading into the US Thanksgiving Holiday.  If there are any issues with
>>> this date, please let me know.  Thank you everyone for your continued
>>> support of the KiCad project.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Fwd: eeschema selection appearance

[Drew Van Zandt]

Ruth, brilliant!  This behavior in commercial apps has irritated me for
decades.


*Drew Van Zandt*


On Wed, Nov 20, 2019 at 12:29 PM Ian McInerney 
wrote:

> (Ruth, I think you meant to send this to the entire list).
>
> -- Forwarded message -
> From: Ruth Ivimey-Cook 
> Date: Wed, Nov 20, 2019 at 5:23 PM
> Subject: Re: [Kicad-developers] eeschema selection appearance
> To: 
>
>
> This looks like an improvement on v5.1, anyway. Thanks!
>
> A side request if you're looking at the selection code: I would really
> appreciate it if selections were included in the history buffer and could
> be added-to and subtracted-from incrementally. It would make working with
> selections much easier!
>
> A related thing - if you make a selection and then try to perform an
> action on it, and then cancel the action (e.g. because a dialog appeared
> warning you of some condition), it is frustrating that the selection is
> cancelled.
>
> Regards
>
> Ruth
>
>
> On 20/11/2019 14:28, Ian McInerney wrote:
>
> I'm on the fence about the text highlighting, on the one hand not doing it
> does make it so the text is still easily legible when selected, but on the
> other it can be nice to show that it is part of the selected symbol. I
> think this would definitely be a case where making it a configurable option
> would allow people to experiment and see what they prefer.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 2:18 PM Seth Hillbrand  wrote:
>
>> On 2019-11-20 05:48, Jonatan Liljedahl wrote:
>> > Hi,
>> >
>> > I'm tweaking the appearance of the new selection, what do you think?
>> > Except a change of color, transparency and width, it also skips
>> > drawing the fields and pin labels of components. I think it gives a
>> > much cleaner look with less clutter.
>>
>> This will always be a matter of opinion.  Right now the color is
>> configurable.  If you'd like to add additional configurable parameters
>> to the selection, you should place them in the Eeschema preferences and
>> allow the user to choose them.  Then post the patch for review.
>>
>> Otherwise, we'll end up bike shedding on this which would be nice to
>> avoid.
>>
>> Best-
>> Seth
>>
>>
>> Seth Hillbrand
>> KiCad Services Corporation
>> https://www.kipro-pcb.com
>> +1 530 302 5483 | +1 212 603 9372
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Fwd: eeschema selection appearance

[Ian McInerney]

(Ruth, I think you meant to send this to the entire list).

-- Forwarded message -
From: Ruth Ivimey-Cook 
Date: Wed, Nov 20, 2019 at 5:23 PM
Subject: Re: [Kicad-developers] eeschema selection appearance
To: 


This looks like an improvement on v5.1, anyway. Thanks!

A side request if you're looking at the selection code: I would really
appreciate it if selections were included in the history buffer and could
be added-to and subtracted-from incrementally. It would make working with
selections much easier!

A related thing - if you make a selection and then try to perform an action
on it, and then cancel the action (e.g. because a dialog appeared warning
you of some condition), it is frustrating that the selection is cancelled.

Regards

Ruth


On 20/11/2019 14:28, Ian McInerney wrote:

I'm on the fence about the text highlighting, on the one hand not doing it
does make it so the text is still easily legible when selected, but on the
other it can be nice to show that it is part of the selected symbol. I
think this would definitely be a case where making it a configurable option
would allow people to experiment and see what they prefer.

-Ian

On Wed, Nov 20, 2019 at 2:18 PM Seth Hillbrand  wrote:

> On 2019-11-20 05:48, Jonatan Liljedahl wrote:
> > Hi,
> >
> > I'm tweaking the appearance of the new selection, what do you think?
> > Except a change of color, transparency and width, it also skips
> > drawing the fields and pin labels of components. I think it gives a
> > much cleaner look with less clutter.
>
> This will always be a matter of opinion.  Right now the color is
> configurable.  If you'd like to add additional configurable parameters
> to the selection, you should place them in the Eeschema preferences and
> allow the user to choose them.  Then post the patch for review.
>
> Otherwise, we'll end up bike shedding on this which would be nice to
> avoid.
>
> Best-
> Seth
>
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema selection appearance

[Seth Hillbrand]

On 11/20/19 7:11 AM, Jonatan Liljedahl wrote:

Ok, I'll look into making it configurable. However, I find the current
default appearance hard to use, so maybe one could consider changing
the defaults in that case?
Everyone likes to have their preferences as the default.  This is not a 
useful line of discussion for the project.  Once the options are 
configurable, it shouldn't be an issue.



Additionally, I changed the shadow width algo constants as follows, to
avoid the feeling of the selection shadow changing size drastically as
you zoom:
Please move this idea into a separate patch and propose it.  The 
selection highlight width works well at all zoom levels for me but if 
this idea helps some people without negatively impacting the current 
situation, there should be no issues.  Please keep this distinct from 
the options patch, however.




So now the question is at what granularity all this should be
configurable? Perhaps:

- selection draw child-items: bool
- selection thickness: float
- selection color (already there)

Those options make sense to me.

-Seth
--
KiCad Services Corporation KiCad Services Corporation Logo
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬ 
Davis, CA
www.kipro-pcb.com  i...@kipro-pcb.com 

https://twitter.com/KiProEDA  
https://www.linkedin.com/company/kicad 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building current master fails

[Wayne Stambaugh]

I do the same thing.  Trying to switch between the master and 5.1
branches to work is not very productive.

On 11/20/19 11:13 AM, Ian McInerney wrote:
> I keep 5.1 and master in separate worktrees because I find that the
> compile time if you switch branches is excruciatingly painful (we have
> some differences in the base header files now that basically mean an
> almost full recompile). That is probably why I never saw this issue.
> 
> -Ian
> 
> On Wed, Nov 20, 2019 at 3:16 PM Jeff Young  > wrote:
> 
> I switch between 5.1 and master and back in the same tree.  You have
> to run the clean each time you go from 5.1 to master.
> 
>> On 20 Nov 2019, at 14:34, Ian McInerney > > wrote:
>>
>> Thats correct, all those lexer files should now be in the build
>> folder. I think that only the board file has had new keywords
>> added, so it would be the only one that is different.
>>
>> Ok, so there is probably another cause of the files appearing. Did
>> you switch branches between master and 5.1 and back? 5.1 looks
>> like it uses the old method of generating the lexer files, so it
>> puts them in the source tree. Master was switched over in July to
>> use the new way that puts them in the build folder.
>>
>> -Ian
>>
>> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl
>> mailto:li...@kymatica.com>> wrote:
>>
>> Hi,
>>
>> I see. So then I assume all these should also not exist?
>>
>> $ ls include/*_lexer.h
>> include/lib_table_lexer.h          include/netlist_lexer.h
>> include/page_layout_reader_lexer.h include/pcb_lexer.h
>> include/pcb_plot_params_lexer.h
>>
>> Of these files, only pcb_lexer.h differed between include/ and
>> build/common/.
>>
>> This is a fresh clone, I'm not sure how these files ended up in
>> include/. I see that the files are not in the git file tree of
>> either
>> 5.1 or master branch. Maybe it happened when I built using
>> kicad-mac-builder pointing it to my kicad source tree?
>>
>> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney
>> mailto:ian.s.mciner...@ieee.org>>
>> wrote:
>> >
>> > Jonatan,
>> >
>> > The pcb_lexer.h in include/ shouldn't exist anymore. There
>> was a switchover a few months ago in how that file was
>> generated, and that change moved it into the build directory.
>> As a consequence of that switchover, you need to clean out the
>> stray files that existed from old build.
>> >
>> > Try running this command in the repository (note, this
>> command will remove any files you are ignoring in the git, so
>> make sure you have everything you want to save copied before
>> running):
>> > 'git clean -fx'
>> >
>> > Out of curiosity, is this an older build system that you are
>> just updating, or is this a fresh clone since July?
>> >
>> > -Ian
>> >
>> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard
>> mailto:oe.n...@gmail.com>> wrote:
>> >>
>> >> It seems to build ok for linux on jenkins.
>> >>
>> >> Maybe double chevk you are not in a merge state or
>> something.  Also, please state the has of the version you are
>> trying to build.
>> >>
>> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl
>> mailto:li...@kymatica.com>>:
>> >>>
>> >>> Hi, I'm trying to build the current master, cmake
>> configured like this:
>> >>>
>> >>> cmake
>> 
>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>> >>>
>> 
>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>> >>>
>> 
>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> >>> -DKICAD_BUILD_QA_TESTS=OFF
>> -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>> >>>
>> >>> but it fails here:
>> >>>
>> >>> [ 42%] Building CXX object
>> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18:
>> error: use of
>> >>> undeclared identifier 'T_copper_finish'
>> >>>             case T_copper_finish:
>> >>>                  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18:
>> error: use of
>> >>> undeclared identifier 'T_edge_plating'
>> >>>             case T_edge_plating:
>> >>>                  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18:
>> 

Re: [Kicad-developers] 5.1.5 release tag

[Jean-Samuel Reynaud]

And there is already 1200 downloads since yesterday...

Le 20/11/2019 à 17:17, Jean-Samuel Reynaud a écrit :
> Hi All,
> 
> Version 5.1.5 are now available on the PPA (ubuntu).
> 
> 
> Le 18/11/2019 à 12:06, Nick Østergaard a écrit :
>> Everything is tagged.
>>
>> @adam, you should be able to bump the macos releases as well.
>>
>> søn. 17. nov. 2019 17.57 skrev Rene Pöschl > >:
>>
>> Libraries have been tagged.
>>
>> On 14/11/2019 18:36, Wayne Stambaugh wrote:
>> > The 5.1 branch has been tagged for 5.1.5 and the source archive has be
>> > uploaded to launchpad.  Please tag the library, doc, and translation
>> > repos so we can fire up those packages builders.
>> >
>> > Thanks,
>> >
>> > Wayne
>> >
>> > On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
>> >> It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
>> >> seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow
>> around
>> >> noon EST unless something comes up.  I'm assuming the libraries,
>> >> documentation, and translations are ready to go and that it shouldn't
>> >> take too long to get most of the installer packages build and
>> uploaded
>> >> to the KiCad website.  I would like to make the release
>> announcement on
>> >> Wednesday, November 27th.  It would be something to be thankful for
>> >> leading into the US Thanksgiving Holiday.  If there are any
>> issues with
>> >> this date, please let me know.  Thank you everyone for your continued
>> >> support of the KiCad project.
>> >>
>> >> Cheers,
>> >>
>> >> Wayne
>> >>
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@lists.launchpad.net
>> 
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release tag

[Jean-Samuel Reynaud]

Hi All,

Version 5.1.5 are now available on the PPA (ubuntu).


Le 18/11/2019 à 12:06, Nick Østergaard a écrit :
> Everything is tagged.
> 
> @adam, you should be able to bump the macos releases as well.
> 
> søn. 17. nov. 2019 17.57 skrev Rene Pöschl  >:
> 
> Libraries have been tagged.
> 
> On 14/11/2019 18:36, Wayne Stambaugh wrote:
> > The 5.1 branch has been tagged for 5.1.5 and the source archive has be
> > uploaded to launchpad.  Please tag the library, doc, and translation
> > repos so we can fire up those packages builders.
> >
> > Thanks,
> >
> > Wayne
> >
> > On 11/13/19 3:55 PM, Wayne Stambaugh wrote:
> >> It's been a couple of weeks since 5.1.5-rc1 was tagged and everything
> >> seems to have stabilized nicely.  I'm going to tag 5.1.5 tomorrow
> around
> >> noon EST unless something comes up.  I'm assuming the libraries,
> >> documentation, and translations are ready to go and that it shouldn't
> >> take too long to get most of the installer packages build and
> uploaded
> >> to the KiCad website.  I would like to make the release
> announcement on
> >> Wednesday, November 27th.  It would be something to be thankful for
> >> leading into the US Thanksgiving Holiday.  If there are any
> issues with
> >> this date, please let me know.  Thank you everyone for your continued
> >> support of the KiCad project.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building current master fails

[Ian McInerney]

I keep 5.1 and master in separate worktrees because I find that the compile
time if you switch branches is excruciatingly painful (we have some
differences in the base header files now that basically mean an almost full
recompile). That is probably why I never saw this issue.

-Ian

On Wed, Nov 20, 2019 at 3:16 PM Jeff Young  wrote:

> I switch between 5.1 and master and back in the same tree.  You have to
> run the clean each time you go from 5.1 to master.
>
> On 20 Nov 2019, at 14:34, Ian McInerney  wrote:
>
> Thats correct, all those lexer files should now be in the build folder. I
> think that only the board file has had new keywords added, so it would be
> the only one that is different.
>
> Ok, so there is probably another cause of the files appearing. Did you
> switch branches between master and 5.1 and back? 5.1 looks like it uses the
> old method of generating the lexer files, so it puts them in the source
> tree. Master was switched over in July to use the new way that puts them in
> the build folder.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl 
> wrote:
>
>> Hi,
>>
>> I see. So then I assume all these should also not exist?
>>
>> $ ls include/*_lexer.h
>> include/lib_table_lexer.h  include/netlist_lexer.h
>> include/page_layout_reader_lexer.h include/pcb_lexer.h
>> include/pcb_plot_params_lexer.h
>>
>> Of these files, only pcb_lexer.h differed between include/ and
>> build/common/.
>>
>> This is a fresh clone, I'm not sure how these files ended up in
>> include/. I see that the files are not in the git file tree of either
>> 5.1 or master branch. Maybe it happened when I built using
>> kicad-mac-builder pointing it to my kicad source tree?
>>
>> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney 
>> wrote:
>> >
>> > Jonatan,
>> >
>> > The pcb_lexer.h in include/ shouldn't exist anymore. There was a
>> switchover a few months ago in how that file was generated, and that change
>> moved it into the build directory. As a consequence of that switchover, you
>> need to clean out the stray files that existed from old build.
>> >
>> > Try running this command in the repository (note, this command will
>> remove any files you are ignoring in the git, so make sure you have
>> everything you want to save copied before running):
>> > 'git clean -fx'
>> >
>> > Out of curiosity, is this an older build system that you are just
>> updating, or is this a fresh clone since July?
>> >
>> > -Ian
>> >
>> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard 
>> wrote:
>> >>
>> >> It seems to build ok for linux on jenkins.
>> >>
>> >> Maybe double chevk you are not in a merge state or something.  Also,
>> please state the has of the version you are trying to build.
>> >>
>> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>> >>>
>> >>> Hi, I'm trying to build the current master, cmake configured like
>> this:
>> >>>
>> >>> cmake
>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>> >>>
>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>> >>>
>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> >>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>> >>>
>> >>> but it fails here:
>> >>>
>> >>> [ 42%] Building CXX object
>> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>> >>> undeclared identifier 'T_copper_finish'
>> >>> case T_copper_finish:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>> >>> undeclared identifier 'T_edge_plating'
>> >>> case T_edge_plating:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>> >>> undeclared identifier 'T_dielectric_constraints'
>> >>> case T_dielectric_constraints:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>> >>> undeclared identifier 'T_edge_connector'; did you mean
>> >>> 'T_zone_connect'?
>> >>> case T_edge_connector:
>> >>>  ^~~~
>> >>>  T_zone_connect
>> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>> >>> 'T_zone_connect' declared here
>> >>> T_zone_connect,
>> >>> ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>> >>> undeclared identifier 'T_bevelled'
>> >>> else if( token == T_bevelled )
>> >>>   ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>> >>> undeclared identifier 'T_castellated_pads'
>> >>> case T_castellated_pads:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>> 

Re: [Kicad-developers] Building current master fails

[Jeff Young]

This will do it in one step:

find . -name *_lexer.h -delete

> On 20 Nov 2019, at 15:57, Adam Wolf  wrote:
> 
> Thanks for this! I have just been cleaning a lot.. :)
> 
> On Wed, Nov 20, 2019 at 9:16 AM Jeff Young  wrote:
>> 
>> I switch between 5.1 and master and back in the same tree.  You have to run 
>> the clean each time you go from 5.1 to master.
>> 
>> On 20 Nov 2019, at 14:34, Ian McInerney  wrote:
>> 
>> Thats correct, all those lexer files should now be in the build folder. I 
>> think that only the board file has had new keywords added, so it would be 
>> the only one that is different.
>> 
>> Ok, so there is probably another cause of the files appearing. Did you 
>> switch branches between master and 5.1 and back? 5.1 looks like it uses the 
>> old method of generating the lexer files, so it puts them in the source 
>> tree. Master was switched over in July to use the new way that puts them in 
>> the build folder.
>> 
>> -Ian
>> 
>> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl  
>> wrote:
>>> 
>>> Hi,
>>> 
>>> I see. So then I assume all these should also not exist?
>>> 
>>> $ ls include/*_lexer.h
>>> include/lib_table_lexer.h  include/netlist_lexer.h
>>> include/page_layout_reader_lexer.h include/pcb_lexer.h
>>> include/pcb_plot_params_lexer.h
>>> 
>>> Of these files, only pcb_lexer.h differed between include/ and 
>>> build/common/.
>>> 
>>> This is a fresh clone, I'm not sure how these files ended up in
>>> include/. I see that the files are not in the git file tree of either
>>> 5.1 or master branch. Maybe it happened when I built using
>>> kicad-mac-builder pointing it to my kicad source tree?
>>> 
>>> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney  
>>> wrote:
 
 Jonatan,
 
 The pcb_lexer.h in include/ shouldn't exist anymore. There was a 
 switchover a few months ago in how that file was generated, and that 
 change moved it into the build directory. As a consequence of that 
 switchover, you need to clean out the stray files that existed from old 
 build.
 
 Try running this command in the repository (note, this command will remove 
 any files you are ignoring in the git, so make sure you have everything 
 you want to save copied before running):
 'git clean -fx'
 
 Out of curiosity, is this an older build system that you are just 
 updating, or is this a fresh clone since July?
 
 -Ian
 
 On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  wrote:
> 
> It seems to build ok for linux on jenkins.
> 
> Maybe double chevk you are not in a merge state or something.  Also, 
> please state the has of the version you are trying to build.
> 
> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>> 
>> Hi, I'm trying to build the current master, cmake configured like this:
>> 
>> cmake 
>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>> 
>> but it fails here:
>> 
>> [ 42%] Building CXX object
>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>> undeclared identifier 'T_copper_finish'
>>case T_copper_finish:
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>> undeclared identifier 'T_edge_plating'
>>case T_edge_plating:
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>> undeclared identifier 'T_dielectric_constraints'
>>case T_dielectric_constraints:
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>> undeclared identifier 'T_edge_connector'; did you mean
>> 'T_zone_connect'?
>>case T_edge_connector:
>> ^~~~
>> T_zone_connect
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>> 'T_zone_connect' declared here
>>T_zone_connect,
>>^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>> undeclared identifier 'T_bevelled'
>>else if( token == T_bevelled )
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>> undeclared identifier 'T_castellated_pads'
>>case T_castellated_pads:
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>> undeclared identifier 

Re: [Kicad-developers] Building current master fails

[Adam Wolf]

Thanks for this! I have just been cleaning a lot.. :)

On Wed, Nov 20, 2019 at 9:16 AM Jeff Young  wrote:
>
> I switch between 5.1 and master and back in the same tree.  You have to run 
> the clean each time you go from 5.1 to master.
>
> On 20 Nov 2019, at 14:34, Ian McInerney  wrote:
>
> Thats correct, all those lexer files should now be in the build folder. I 
> think that only the board file has had new keywords added, so it would be the 
> only one that is different.
>
> Ok, so there is probably another cause of the files appearing. Did you switch 
> branches between master and 5.1 and back? 5.1 looks like it uses the old 
> method of generating the lexer files, so it puts them in the source tree. 
> Master was switched over in July to use the new way that puts them in the 
> build folder.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl  wrote:
>>
>> Hi,
>>
>> I see. So then I assume all these should also not exist?
>>
>> $ ls include/*_lexer.h
>> include/lib_table_lexer.h  include/netlist_lexer.h
>> include/page_layout_reader_lexer.h include/pcb_lexer.h
>> include/pcb_plot_params_lexer.h
>>
>> Of these files, only pcb_lexer.h differed between include/ and build/common/.
>>
>> This is a fresh clone, I'm not sure how these files ended up in
>> include/. I see that the files are not in the git file tree of either
>> 5.1 or master branch. Maybe it happened when I built using
>> kicad-mac-builder pointing it to my kicad source tree?
>>
>> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney  
>> wrote:
>> >
>> > Jonatan,
>> >
>> > The pcb_lexer.h in include/ shouldn't exist anymore. There was a 
>> > switchover a few months ago in how that file was generated, and that 
>> > change moved it into the build directory. As a consequence of that 
>> > switchover, you need to clean out the stray files that existed from old 
>> > build.
>> >
>> > Try running this command in the repository (note, this command will remove 
>> > any files you are ignoring in the git, so make sure you have everything 
>> > you want to save copied before running):
>> > 'git clean -fx'
>> >
>> > Out of curiosity, is this an older build system that you are just 
>> > updating, or is this a fresh clone since July?
>> >
>> > -Ian
>> >
>> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  wrote:
>> >>
>> >> It seems to build ok for linux on jenkins.
>> >>
>> >> Maybe double chevk you are not in a merge state or something.  Also, 
>> >> please state the has of the version you are trying to build.
>> >>
>> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>> >>>
>> >>> Hi, I'm trying to build the current master, cmake configured like this:
>> >>>
>> >>> cmake 
>> >>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>> >>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>> >>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> >>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>> >>>
>> >>> but it fails here:
>> >>>
>> >>> [ 42%] Building CXX object
>> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>> >>> undeclared identifier 'T_copper_finish'
>> >>> case T_copper_finish:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>> >>> undeclared identifier 'T_edge_plating'
>> >>> case T_edge_plating:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>> >>> undeclared identifier 'T_dielectric_constraints'
>> >>> case T_dielectric_constraints:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>> >>> undeclared identifier 'T_edge_connector'; did you mean
>> >>> 'T_zone_connect'?
>> >>> case T_edge_connector:
>> >>>  ^~~~
>> >>>  T_zone_connect
>> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>> >>> 'T_zone_connect' declared here
>> >>> T_zone_connect,
>> >>> ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>> >>> undeclared identifier 'T_bevelled'
>> >>> else if( token == T_bevelled )
>> >>>   ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>> >>> undeclared identifier 'T_castellated_pads'
>> >>> case T_castellated_pads:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>> >>> undeclared identifier 'T_addsublayer'
>> >>> if( token == T_addsublayer )
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: 

Re: [Kicad-developers] Building current master fails

[Jeff Young]

I switch between 5.1 and master and back in the same tree.  You have to run the 
clean each time you go from 5.1 to master.

> On 20 Nov 2019, at 14:34, Ian McInerney  wrote:
> 
> Thats correct, all those lexer files should now be in the build folder. I 
> think that only the board file has had new keywords added, so it would be the 
> only one that is different.
> 
> Ok, so there is probably another cause of the files appearing. Did you switch 
> branches between master and 5.1 and back? 5.1 looks like it uses the old 
> method of generating the lexer files, so it puts them in the source tree. 
> Master was switched over in July to use the new way that puts them in the 
> build folder.
> 
> -Ian
> 
> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl  > wrote:
> Hi,
> 
> I see. So then I assume all these should also not exist?
> 
> $ ls include/*_lexer.h
> include/lib_table_lexer.h  include/netlist_lexer.h
> include/page_layout_reader_lexer.h include/pcb_lexer.h
> include/pcb_plot_params_lexer.h
> 
> Of these files, only pcb_lexer.h differed between include/ and build/common/.
> 
> This is a fresh clone, I'm not sure how these files ended up in
> include/. I see that the files are not in the git file tree of either
> 5.1 or master branch. Maybe it happened when I built using
> kicad-mac-builder pointing it to my kicad source tree?
> 
> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney  > wrote:
> >
> > Jonatan,
> >
> > The pcb_lexer.h in include/ shouldn't exist anymore. There was a switchover 
> > a few months ago in how that file was generated, and that change moved it 
> > into the build directory. As a consequence of that switchover, you need to 
> > clean out the stray files that existed from old build.
> >
> > Try running this command in the repository (note, this command will remove 
> > any files you are ignoring in the git, so make sure you have everything you 
> > want to save copied before running):
> > 'git clean -fx'
> >
> > Out of curiosity, is this an older build system that you are just updating, 
> > or is this a fresh clone since July?
> >
> > -Ian
> >
> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  > > wrote:
> >>
> >> It seems to build ok for linux on jenkins.
> >>
> >> Maybe double chevk you are not in a merge state or something.  Also, 
> >> please state the has of the version you are trying to build.
> >>
> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl  >> >:
> >>>
> >>> Hi, I'm trying to build the current master, cmake configured like this:
> >>>
> >>> cmake 
> >>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
> >>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
> >>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
> >>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
> >>>
> >>> but it fails here:
> >>>
> >>> [ 42%] Building CXX object
> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
> >>> undeclared identifier 'T_copper_finish'
> >>> case T_copper_finish:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
> >>> undeclared identifier 'T_edge_plating'
> >>> case T_edge_plating:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
> >>> undeclared identifier 'T_dielectric_constraints'
> >>> case T_dielectric_constraints:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
> >>> undeclared identifier 'T_edge_connector'; did you mean
> >>> 'T_zone_connect'?
> >>> case T_edge_connector:
> >>>  ^~~~
> >>>  T_zone_connect
> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
> >>> 'T_zone_connect' declared here
> >>> T_zone_connect,
> >>> ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
> >>> undeclared identifier 'T_bevelled'
> >>> else if( token == T_bevelled )
> >>>   ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
> >>> undeclared identifier 'T_castellated_pads'
> >>> case T_castellated_pads:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
> >>> undeclared identifier 'T_addsublayer'
> >>> if( token == T_addsublayer )
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
> >>> undeclared identifier 'T_type'; did you mean 'T_top'?
> >>>   

Re: [Kicad-developers] Building current master fails

[Jonatan Liljedahl]

Ah, yes I have switched between 5.1 and master so that would probably
be it then!
Thanks.

On Wed, Nov 20, 2019 at 3:34 PM Ian McInerney  wrote:
>
> Thats correct, all those lexer files should now be in the build folder. I 
> think that only the board file has had new keywords added, so it would be the 
> only one that is different.
>
> Ok, so there is probably another cause of the files appearing. Did you switch 
> branches between master and 5.1 and back? 5.1 looks like it uses the old 
> method of generating the lexer files, so it puts them in the source tree. 
> Master was switched over in July to use the new way that puts them in the 
> build folder.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl  wrote:
>>
>> Hi,
>>
>> I see. So then I assume all these should also not exist?
>>
>> $ ls include/*_lexer.h
>> include/lib_table_lexer.h  include/netlist_lexer.h
>> include/page_layout_reader_lexer.h include/pcb_lexer.h
>> include/pcb_plot_params_lexer.h
>>
>> Of these files, only pcb_lexer.h differed between include/ and build/common/.
>>
>> This is a fresh clone, I'm not sure how these files ended up in
>> include/. I see that the files are not in the git file tree of either
>> 5.1 or master branch. Maybe it happened when I built using
>> kicad-mac-builder pointing it to my kicad source tree?
>>
>> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney  
>> wrote:
>> >
>> > Jonatan,
>> >
>> > The pcb_lexer.h in include/ shouldn't exist anymore. There was a 
>> > switchover a few months ago in how that file was generated, and that 
>> > change moved it into the build directory. As a consequence of that 
>> > switchover, you need to clean out the stray files that existed from old 
>> > build.
>> >
>> > Try running this command in the repository (note, this command will remove 
>> > any files you are ignoring in the git, so make sure you have everything 
>> > you want to save copied before running):
>> > 'git clean -fx'
>> >
>> > Out of curiosity, is this an older build system that you are just 
>> > updating, or is this a fresh clone since July?
>> >
>> > -Ian
>> >
>> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  wrote:
>> >>
>> >> It seems to build ok for linux on jenkins.
>> >>
>> >> Maybe double chevk you are not in a merge state or something.  Also, 
>> >> please state the has of the version you are trying to build.
>> >>
>> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>> >>>
>> >>> Hi, I'm trying to build the current master, cmake configured like this:
>> >>>
>> >>> cmake 
>> >>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>> >>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>> >>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> >>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>> >>>
>> >>> but it fails here:
>> >>>
>> >>> [ 42%] Building CXX object
>> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>> >>> undeclared identifier 'T_copper_finish'
>> >>> case T_copper_finish:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>> >>> undeclared identifier 'T_edge_plating'
>> >>> case T_edge_plating:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>> >>> undeclared identifier 'T_dielectric_constraints'
>> >>> case T_dielectric_constraints:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>> >>> undeclared identifier 'T_edge_connector'; did you mean
>> >>> 'T_zone_connect'?
>> >>> case T_edge_connector:
>> >>>  ^~~~
>> >>>  T_zone_connect
>> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>> >>> 'T_zone_connect' declared here
>> >>> T_zone_connect,
>> >>> ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>> >>> undeclared identifier 'T_bevelled'
>> >>> else if( token == T_bevelled )
>> >>>   ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>> >>> undeclared identifier 'T_castellated_pads'
>> >>> case T_castellated_pads:
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>> >>> undeclared identifier 'T_addsublayer'
>> >>> if( token == T_addsublayer )
>> >>>  ^
>> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
>> >>> undeclared identifier 'T_type'; did you mean 'T_top'?
>> >>> case T_type:
>> >>>  

Re: [Kicad-developers] eeschema selection appearance

[Jonatan Liljedahl]

Ok, I'll look into making it configurable. However, I find the current
default appearance hard to use, so maybe one could consider changing
the defaults in that case?

Not only does it make the text easily legible, but also the whole
symbol less cluttered when selected. You can still select individual
text fields as expected, but only the symbol and its pins are drawn as
selected when the whole component is selected.

These are the parts I've disabled for drawing of the selection shadow:
- pin labels/names
- component fields
- subsheet pins
- subsheet title/file

Additionally, I changed the shadow width algo constants as follows, to
avoid the feeling of the selection shadow changing size drastically as
you zoom:

float SCH_PAINTER::getShadowWidth()
{
const MATRIX3x3D& matrix = m_gal->GetScreenWorldMatrix();

// For best visuals the selection width must be a cross between
the zoom level and the
// default line width.
return (float) ( ( fabs( matrix.GetScale().x * 1.0 ) +
GetDefaultLineThickness() ) * 4.0 );
}

So now the question is at what granularity all this should be
configurable? Perhaps:

- selection draw child-items: bool
- selection thickness: float
- selection color (already there)

Cheers

On Wed, Nov 20, 2019 at 3:29 PM Ian McInerney  wrote:
>
> I'm on the fence about the text highlighting, on the one hand not doing it 
> does make it so the text is still easily legible when selected, but on the 
> other it can be nice to show that it is part of the selected symbol. I think 
> this would definitely be a case where making it a configurable option would 
> allow people to experiment and see what they prefer.
>
> -Ian
>
> On Wed, Nov 20, 2019 at 2:18 PM Seth Hillbrand  wrote:
>>
>> On 2019-11-20 05:48, Jonatan Liljedahl wrote:
>> > Hi,
>> >
>> > I'm tweaking the appearance of the new selection, what do you think?
>> > Except a change of color, transparency and width, it also skips
>> > drawing the fields and pin labels of components. I think it gives a
>> > much cleaner look with less clutter.
>>
>> This will always be a matter of opinion.  Right now the color is
>> configurable.  If you'd like to add additional configurable parameters
>> to the selection, you should place them in the Eeschema preferences and
>> allow the user to choose them.  Then post the patch for review.
>>
>> Otherwise, we'll end up bike shedding on this which would be nice to
>> avoid.
>>
>> Best-
>> Seth
>>
>>
>> Seth Hillbrand
>> KiCad Services Corporation
>> https://www.kipro-pcb.com
>> +1 530 302 5483 | +1 212 603 9372
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building current master fails

[Ian McInerney]

Thats correct, all those lexer files should now be in the build folder. I
think that only the board file has had new keywords added, so it would be
the only one that is different.

Ok, so there is probably another cause of the files appearing. Did you
switch branches between master and 5.1 and back? 5.1 looks like it uses the
old method of generating the lexer files, so it puts them in the source
tree. Master was switched over in July to use the new way that puts them in
the build folder.

-Ian

On Wed, Nov 20, 2019 at 11:51 AM Jonatan Liljedahl 
wrote:

> Hi,
>
> I see. So then I assume all these should also not exist?
>
> $ ls include/*_lexer.h
> include/lib_table_lexer.h  include/netlist_lexer.h
> include/page_layout_reader_lexer.h include/pcb_lexer.h
> include/pcb_plot_params_lexer.h
>
> Of these files, only pcb_lexer.h differed between include/ and
> build/common/.
>
> This is a fresh clone, I'm not sure how these files ended up in
> include/. I see that the files are not in the git file tree of either
> 5.1 or master branch. Maybe it happened when I built using
> kicad-mac-builder pointing it to my kicad source tree?
>
> On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney 
> wrote:
> >
> > Jonatan,
> >
> > The pcb_lexer.h in include/ shouldn't exist anymore. There was a
> switchover a few months ago in how that file was generated, and that change
> moved it into the build directory. As a consequence of that switchover, you
> need to clean out the stray files that existed from old build.
> >
> > Try running this command in the repository (note, this command will
> remove any files you are ignoring in the git, so make sure you have
> everything you want to save copied before running):
> > 'git clean -fx'
> >
> > Out of curiosity, is this an older build system that you are just
> updating, or is this a fresh clone since July?
> >
> > -Ian
> >
> > On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard 
> wrote:
> >>
> >> It seems to build ok for linux on jenkins.
> >>
> >> Maybe double chevk you are not in a merge state or something.  Also,
> please state the has of the version you are trying to build.
> >>
> >> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
> >>>
> >>> Hi, I'm trying to build the current master, cmake configured like this:
> >>>
> >>> cmake
> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
> >>>
> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
> >>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
> >>>
> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
> >>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
> >>>
> >>> but it fails here:
> >>>
> >>> [ 42%] Building CXX object
> >>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
> >>> undeclared identifier 'T_copper_finish'
> >>> case T_copper_finish:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
> >>> undeclared identifier 'T_edge_plating'
> >>> case T_edge_plating:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
> >>> undeclared identifier 'T_dielectric_constraints'
> >>> case T_dielectric_constraints:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
> >>> undeclared identifier 'T_edge_connector'; did you mean
> >>> 'T_zone_connect'?
> >>> case T_edge_connector:
> >>>  ^~~~
> >>>  T_zone_connect
> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
> >>> 'T_zone_connect' declared here
> >>> T_zone_connect,
> >>> ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
> >>> undeclared identifier 'T_bevelled'
> >>> else if( token == T_bevelled )
> >>>   ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
> >>> undeclared identifier 'T_castellated_pads'
> >>> case T_castellated_pads:
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
> >>> undeclared identifier 'T_addsublayer'
> >>> if( token == T_addsublayer )
> >>>  ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
> >>> undeclared identifier 'T_type'; did you mean 'T_top'?
> >>> case T_type:
> >>>  ^~
> >>>  T_top
> >>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top'
> declared here
> >>> T_top,
> >>> ^
> >>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
> >>> undeclared identifier 'T_material'; did you mean 

Re: [Kicad-developers] eeschema selection appearance

[Ian McInerney]

I'm on the fence about the text highlighting, on the one hand not doing it
does make it so the text is still easily legible when selected, but on the
other it can be nice to show that it is part of the selected symbol. I
think this would definitely be a case where making it a configurable option
would allow people to experiment and see what they prefer.

-Ian

On Wed, Nov 20, 2019 at 2:18 PM Seth Hillbrand  wrote:

> On 2019-11-20 05:48, Jonatan Liljedahl wrote:
> > Hi,
> >
> > I'm tweaking the appearance of the new selection, what do you think?
> > Except a change of color, transparency and width, it also skips
> > drawing the fields and pin labels of components. I think it gives a
> > much cleaner look with less clutter.
>
> This will always be a matter of opinion.  Right now the color is
> configurable.  If you'd like to add additional configurable parameters
> to the selection, you should place them in the Eeschema preferences and
> allow the user to choose them.  Then post the patch for review.
>
> Otherwise, we'll end up bike shedding on this which would be nice to
> avoid.
>
> Best-
> Seth
>
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema selection appearance

[Seth Hillbrand]

On 2019-11-20 05:48, Jonatan Liljedahl wrote:

Hi,

I'm tweaking the appearance of the new selection, what do you think?
Except a change of color, transparency and width, it also skips
drawing the fields and pin labels of components. I think it gives a
much cleaner look with less clutter.


This will always be a matter of opinion.  Right now the color is 
configurable.  If you'd like to add additional configurable parameters 
to the selection, you should place them in the Eeschema preferences and 
allow the user to choose them.  Then post the patch for review.


Otherwise, we'll end up bike shedding on this which would be nice to 
avoid.


Best-
Seth


Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] eeschema selection appearance

[Jonatan Liljedahl]

Hi,

I'm tweaking the appearance of the new selection, what do you think?
Except a change of color, transparency and width, it also skips
drawing the fields and pin labels of components. I think it gives a
much cleaner look with less clutter.

-- 
/Jonatan
http://kymatica.com
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] KiCad Assembly at 36C3

[Simon Richter]

Hi,

On Wed, Nov 20, 2019 at 12:57:31PM +0100, Carlo Maragno wrote:

> I saw that Seth was planning to do something similar at fosdem.

Yes, I'm also going there, and that is probably where the interesting stuff
happens, since there are people there with insight into the codebase and a
general idea where it is headed.

If we wanted to do KiCad hacking at Congress, the opportunity I see there
is more shaped like "we can motivate each other, and if anyone needs to
repeatedly compile stuff, I can just throw the big machines into the van
that's going anyway, so the logistical effort is minimal."

I'm not carrying these boxes around just for the fun of it, especially if
there is no good place to put them, so we should decide if there are enough
people that it makes sense to reserve a table.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] KiCad Assembly at 36C3

[Carlo Maragno]

Hi Simon,

I saw that Seth was planning to do something similar at fosdem.

It would be super cool to do the same thing at the congress. I for sure
will bring my big laptop.

Carlo


On Wed, 20 Nov 2019, 12:28 Simon Richter,  wrote:

> Hi,
>
> On Tue, Nov 19, 2019 at 10:31:36PM +0100, Carlo Maragno wrote:
>
> > an assembly is just a table and some power cords. It's meant to serve as
> a
> > base for people to gather and hack around.
>
> If there is a critical mass of people who want to do development work, I
> could bring two machines for compiling stuff on.
>
>Simon
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building current master fails

[Jonatan Liljedahl]

Hi,

I see. So then I assume all these should also not exist?

$ ls include/*_lexer.h
include/lib_table_lexer.h  include/netlist_lexer.h
include/page_layout_reader_lexer.h include/pcb_lexer.h
include/pcb_plot_params_lexer.h

Of these files, only pcb_lexer.h differed between include/ and build/common/.

This is a fresh clone, I'm not sure how these files ended up in
include/. I see that the files are not in the git file tree of either
5.1 or master branch. Maybe it happened when I built using
kicad-mac-builder pointing it to my kicad source tree?

On Wed, Nov 20, 2019 at 12:09 PM Ian McInerney  wrote:
>
> Jonatan,
>
> The pcb_lexer.h in include/ shouldn't exist anymore. There was a switchover a 
> few months ago in how that file was generated, and that change moved it into 
> the build directory. As a consequence of that switchover, you need to clean 
> out the stray files that existed from old build.
>
> Try running this command in the repository (note, this command will remove 
> any files you are ignoring in the git, so make sure you have everything you 
> want to save copied before running):
> 'git clean -fx'
>
> Out of curiosity, is this an older build system that you are just updating, 
> or is this a fresh clone since July?
>
> -Ian
>
> On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  wrote:
>>
>> It seems to build ok for linux on jenkins.
>>
>> Maybe double chevk you are not in a merge state or something.  Also, please 
>> state the has of the version you are trying to build.
>>
>> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>>>
>>> Hi, I'm trying to build the current master, cmake configured like this:
>>>
>>> cmake 
>>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>>>
>>> but it fails here:
>>>
>>> [ 42%] Building CXX object
>>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>>> undeclared identifier 'T_copper_finish'
>>> case T_copper_finish:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>>> undeclared identifier 'T_edge_plating'
>>> case T_edge_plating:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>>> undeclared identifier 'T_dielectric_constraints'
>>> case T_dielectric_constraints:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>>> undeclared identifier 'T_edge_connector'; did you mean
>>> 'T_zone_connect'?
>>> case T_edge_connector:
>>>  ^~~~
>>>  T_zone_connect
>>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>>> 'T_zone_connect' declared here
>>> T_zone_connect,
>>> ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>>> undeclared identifier 'T_bevelled'
>>> else if( token == T_bevelled )
>>>   ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>>> undeclared identifier 'T_castellated_pads'
>>> case T_castellated_pads:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>>> undeclared identifier 'T_addsublayer'
>>> if( token == T_addsublayer )
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
>>> undeclared identifier 'T_type'; did you mean 'T_top'?
>>> case T_type:
>>>  ^~
>>>  T_top
>>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top' declared 
>>> here
>>> T_top,
>>> ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
>>> undeclared identifier 'T_material'; did you mean 'T_general'?
>>> case T_material:
>>>  ^~
>>>  T_general
>>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:100:9: note: 'T_general'
>>> declared here
>>> T_general,
>>> ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1129:26: error: use of
>>> undeclared identifier 'T_epsilon_r'
>>> case T_epsilon_r:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1135:26: error: use of
>>> undeclared identifier 'T_loss_tangent'
>>> case T_loss_tangent:
>>>  ^
>>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1141:26: error: use of
>>> undeclared 

Re: [Kicad-developers] KiCad Assembly at 36C3

[Simon Richter]

Hi,

On Tue, Nov 19, 2019 at 10:31:36PM +0100, Carlo Maragno wrote:

> an assembly is just a table and some power cords. It's meant to serve as a
> base for people to gather and hack around.

If there is a critical mass of people who want to do development work, I
could bring two machines for compiling stuff on.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Building current master fails

[Ian McInerney]

Jonatan,

The pcb_lexer.h in include/ shouldn't exist anymore. There was a switchover
a few months ago in how that file was generated, and that change moved it
into the build directory. As a consequence of that switchover, you need to
clean out the stray files that existed from old build.

Try running this command in the repository (note, this command will remove
any files you are ignoring in the git, so make sure you have everything you
want to save copied before running):
'git clean -fx'

Out of curiosity, is this an older build system that you are just updating,
or is this a fresh clone since July?

-Ian

On Wed, Nov 20, 2019 at 10:46 AM Nick Østergaard  wrote:

> It seems to build ok for linux on jenkins.
>
> Maybe double chevk you are not in a merge state or something.  Also,
> please state the has of the version you are trying to build.
>
> ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :
>
>> Hi, I'm trying to build the current master, cmake configured like this:
>>
>> cmake
>> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>>
>> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
>> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>>
>> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
>> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>>
>> but it fails here:
>>
>> [ 42%] Building CXX object
>> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
>> undeclared identifier 'T_copper_finish'
>> case T_copper_finish:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
>> undeclared identifier 'T_edge_plating'
>> case T_edge_plating:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
>> undeclared identifier 'T_dielectric_constraints'
>> case T_dielectric_constraints:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
>> undeclared identifier 'T_edge_connector'; did you mean
>> 'T_zone_connect'?
>> case T_edge_connector:
>>  ^~~~
>>  T_zone_connect
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
>> 'T_zone_connect' declared here
>> T_zone_connect,
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
>> undeclared identifier 'T_bevelled'
>> else if( token == T_bevelled )
>>   ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
>> undeclared identifier 'T_castellated_pads'
>> case T_castellated_pads:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
>> undeclared identifier 'T_addsublayer'
>> if( token == T_addsublayer )
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
>> undeclared identifier 'T_type'; did you mean 'T_top'?
>> case T_type:
>>  ^~
>>  T_top
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top'
>> declared here
>> T_top,
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
>> undeclared identifier 'T_material'; did you mean 'T_general'?
>> case T_material:
>>  ^~
>>  T_general
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:100:9: note: 'T_general'
>> declared here
>> T_general,
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1129:26: error: use of
>> undeclared identifier 'T_epsilon_r'
>> case T_epsilon_r:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1135:26: error: use of
>> undeclared identifier 'T_loss_tangent'
>> case T_loss_tangent:
>>  ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1141:26: error: use of
>> undeclared identifier 'T_color'; did you mean 'T_bold'?
>> case T_color:
>>  ^~~
>>  T_bold
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:60:9: note: 'T_bold'
>> declared here
>> T_bold,
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1431:14: error: use of
>> undeclared identifier 'T_stackup'; did you mean 'T_status'?
>> case T_stackup:
>>  ^
>>  T_status
>> /Users/lijon/Coding/kicad/include/pcb_lexer.h:183:9: note: 'T_status'
>> declared here
>> T_status,
>> ^
>> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1524:14: error: use of
>> undeclared identifier 'T_user_diff_pair'
>> 

Re: [Kicad-developers] Building current master fails

[Nick Østergaard]

It seems to build ok for linux on jenkins.

Maybe double chevk you are not in a merge state or something.  Also, please
state the has of the version you are trying to build.

ons. 20. nov. 2019 11.34 skrev Jonatan Liljedahl :

> Hi, I'm trying to build the current master, cmake configured like this:
>
> cmake
> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
>
> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
>
> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>
> but it fails here:
>
> [ 42%] Building CXX object
> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
> undeclared identifier 'T_copper_finish'
> case T_copper_finish:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
> undeclared identifier 'T_edge_plating'
> case T_edge_plating:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
> undeclared identifier 'T_dielectric_constraints'
> case T_dielectric_constraints:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
> undeclared identifier 'T_edge_connector'; did you mean
> 'T_zone_connect'?
> case T_edge_connector:
>  ^~~~
>  T_zone_connect
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
> 'T_zone_connect' declared here
> T_zone_connect,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
> undeclared identifier 'T_bevelled'
> else if( token == T_bevelled )
>   ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
> undeclared identifier 'T_castellated_pads'
> case T_castellated_pads:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
> undeclared identifier 'T_addsublayer'
> if( token == T_addsublayer )
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
> undeclared identifier 'T_type'; did you mean 'T_top'?
> case T_type:
>  ^~
>  T_top
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top'
> declared here
> T_top,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
> undeclared identifier 'T_material'; did you mean 'T_general'?
> case T_material:
>  ^~
>  T_general
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:100:9: note: 'T_general'
> declared here
> T_general,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1129:26: error: use of
> undeclared identifier 'T_epsilon_r'
> case T_epsilon_r:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1135:26: error: use of
> undeclared identifier 'T_loss_tangent'
> case T_loss_tangent:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1141:26: error: use of
> undeclared identifier 'T_color'; did you mean 'T_bold'?
> case T_color:
>  ^~~
>  T_bold
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:60:9: note: 'T_bold'
> declared here
> T_bold,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1431:14: error: use of
> undeclared identifier 'T_stackup'; did you mean 'T_status'?
> case T_stackup:
>  ^
>  T_status
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:183:9: note: 'T_status'
> declared here
> T_status,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1524:14: error: use of
> undeclared identifier 'T_user_diff_pair'
> case T_user_diff_pair:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error: use of
> undeclared identifier 'T_defaults'; did you mean 'default'?
> case T_defaults:
>  ^~
>  default
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error:
> expected expression
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1638:14: error: use of
> undeclared identifier 'T_max_error'; did you mean 'T_mirror'?
> case T_max_error:
>  ^~~
>  T_mirror
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:122:9: note: 'T_mirror'
> declared here
> T_mirror,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1639:58: error: use of
> undeclared identifier 

Re: [Kicad-developers] Building current master fails

[Jonatan Liljedahl]

include/pcb_lexer.h does not include T_copper_finish etc. However,
build/common/pcb_lexer.h does!
How come? I'm guessing the one in common is generated during build,
but for some reason it picks the other one when including the header.

On Wed, Nov 20, 2019 at 11:34 AM Jonatan Liljedahl  wrote:
>
> Hi, I'm trying to build the current master, cmake configured like this:
>
> cmake 
> -DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
> -DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
> -DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
> -DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
> -DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..
>
> but it fails here:
>
> [ 42%] Building CXX object
> common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
> undeclared identifier 'T_copper_finish'
> case T_copper_finish:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
> undeclared identifier 'T_edge_plating'
> case T_edge_plating:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
> undeclared identifier 'T_dielectric_constraints'
> case T_dielectric_constraints:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
> undeclared identifier 'T_edge_connector'; did you mean
> 'T_zone_connect'?
> case T_edge_connector:
>  ^~~~
>  T_zone_connect
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
> 'T_zone_connect' declared here
> T_zone_connect,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
> undeclared identifier 'T_bevelled'
> else if( token == T_bevelled )
>   ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
> undeclared identifier 'T_castellated_pads'
> case T_castellated_pads:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
> undeclared identifier 'T_addsublayer'
> if( token == T_addsublayer )
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
> undeclared identifier 'T_type'; did you mean 'T_top'?
> case T_type:
>  ^~
>  T_top
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top' declared 
> here
> T_top,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
> undeclared identifier 'T_material'; did you mean 'T_general'?
> case T_material:
>  ^~
>  T_general
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:100:9: note: 'T_general'
> declared here
> T_general,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1129:26: error: use of
> undeclared identifier 'T_epsilon_r'
> case T_epsilon_r:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1135:26: error: use of
> undeclared identifier 'T_loss_tangent'
> case T_loss_tangent:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1141:26: error: use of
> undeclared identifier 'T_color'; did you mean 'T_bold'?
> case T_color:
>  ^~~
>  T_bold
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:60:9: note: 'T_bold' declared 
> here
> T_bold,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1431:14: error: use of
> undeclared identifier 'T_stackup'; did you mean 'T_status'?
> case T_stackup:
>  ^
>  T_status
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:183:9: note: 'T_status'
> declared here
> T_status,
> ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1524:14: error: use of
> undeclared identifier 'T_user_diff_pair'
> case T_user_diff_pair:
>  ^
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error: use of
> undeclared identifier 'T_defaults'; did you mean 'default'?
> case T_defaults:
>  ^~
>  default
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error:
> expected expression
> /Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1638:14: error: use of
> undeclared identifier 'T_max_error'; did you mean 'T_mirror'?
> case T_max_error:
>  ^~~
>  T_mirror
> /Users/lijon/Coding/kicad/include/pcb_lexer.h:122:9: note: 'T_mirror'
> declared here
> T_mirror,
> ^
> 

[Kicad-developers] Building current master fails

[Jonatan Liljedahl]

Hi, I'm trying to build the current master, cmake configured like this:

cmake 
-DNGSPICE_INCLUDE_DIR=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/include/
-DNGSPICE_LIBRARY=/Users/lijon/Coding/kicad-mac-builder/build/ngspice-dest/lib/libngspice.dylib
-DKICAD_USE_OCE=OFF -DKICAD_SCRIPTING=OFF
-DwxWidgets_CONFIG_EXECUTABLE=/Users/lijon/Coding/kicad-mac-builder/build/wxwidgets-dest/bin/wx-config
-DKICAD_BUILD_QA_TESTS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.14 ../..

but it fails here:

[ 42%] Building CXX object
common/CMakeFiles/pcbcommon.dir/__/pcbnew/pcb_parser.cpp.o
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:996:18: error: use of
undeclared identifier 'T_copper_finish'
case T_copper_finish:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1002:18: error: use of
undeclared identifier 'T_edge_plating'
case T_edge_plating:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1008:18: error: use of
undeclared identifier 'T_dielectric_constraints'
case T_dielectric_constraints:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1014:18: error: use of
undeclared identifier 'T_edge_connector'; did you mean
'T_zone_connect'?
case T_edge_connector:
 ^~~~
 T_zone_connect
/Users/lijon/Coding/kicad/include/pcb_lexer.h:232:9: note:
'T_zone_connect' declared here
T_zone_connect,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1020:35: error: use of
undeclared identifier 'T_bevelled'
else if( token == T_bevelled )
  ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1026:18: error: use of
undeclared identifier 'T_castellated_pads'
case T_castellated_pads:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1088:30: error: use of
undeclared identifier 'T_addsublayer'
if( token == T_addsublayer )
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1100:26: error: use of
undeclared identifier 'T_type'; did you mean 'T_top'?
case T_type:
 ^~
 T_top
/Users/lijon/Coding/kicad/include/pcb_lexer.h:196:9: note: 'T_top' declared here
T_top,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1123:26: error: use of
undeclared identifier 'T_material'; did you mean 'T_general'?
case T_material:
 ^~
 T_general
/Users/lijon/Coding/kicad/include/pcb_lexer.h:100:9: note: 'T_general'
declared here
T_general,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1129:26: error: use of
undeclared identifier 'T_epsilon_r'
case T_epsilon_r:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1135:26: error: use of
undeclared identifier 'T_loss_tangent'
case T_loss_tangent:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1141:26: error: use of
undeclared identifier 'T_color'; did you mean 'T_bold'?
case T_color:
 ^~~
 T_bold
/Users/lijon/Coding/kicad/include/pcb_lexer.h:60:9: note: 'T_bold' declared here
T_bold,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1431:14: error: use of
undeclared identifier 'T_stackup'; did you mean 'T_status'?
case T_stackup:
 ^
 T_status
/Users/lijon/Coding/kicad/include/pcb_lexer.h:183:9: note: 'T_status'
declared here
T_status,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1524:14: error: use of
undeclared identifier 'T_user_diff_pair'
case T_user_diff_pair:
 ^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error: use of
undeclared identifier 'T_defaults'; did you mean 'default'?
case T_defaults:
 ^~
 default
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1571:14: error:
expected expression
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1638:14: error: use of
undeclared identifier 'T_max_error'; did you mean 'T_mirror'?
case T_max_error:
 ^~~
 T_mirror
/Users/lijon/Coding/kicad/include/pcb_lexer.h:122:9: note: 'T_mirror'
declared here
T_mirror,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1639:58: error: use of
undeclared identifier 'T_max_error'; did you mean 'T_mirror'?
designSettings.m_MaxError = parseBoardUnits( T_max_error );
 ^~~
 T_mirror
/Users/lijon/Coding/kicad/include/pcb_lexer.h:122:9: note: 'T_mirror'
declared here
T_mirror,
^
/Users/lijon/Coding/kicad/pcbnew/pcb_parser.cpp:1643:14: error: use of
undeclared identifier