Re: [Kicad-developers] [PATCH] minor icon improvements

2017-09-19 Thread Wayne Stambaugh
Fabrizio,

I merged your patch into the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 9/14/2017 6:59 AM, Fabrizio Tappero wrote:
> Hi Wayne,
> reviewed the patch and re-submit here. Changes are:
> 
> 1) "Edit PCB" is now "Edit PCB Layout"
> 2) "View GERBER" is now "View Gerber Files"
> 3) "Edit Schematic Symbol" is now "Manage Symbol Libraries"
> 4) "Edit Sheet Layout" is now "Edit Page Layout"
> 5) "Convert Bitmap to Footprint" is now "Convert Image"
> 
> This should include all the suggestions in this email chain.
> Thanks a lot
> Fabrizio
> 
> 
> 
> On Tue, Sep 12, 2017 at 5:00 PM, Wayne Stambaugh  > wrote:
> 
> Fabrizio,
> 
> Did you submit a revised patch with the suggestions that I made?  I just
> looked in the mailing list archives and all I see is the original patch.
> 
> Cheers,
> 
> Wayne
> 
> On 9/12/2017 8:57 AM, Fabrizio Tappero wrote:
> > gentle reminder 
> >
> > cheers
> > Fabrizio
> >
> >
> > On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh  
> > >> wrote:
> >
> >     On 8/29/2017 12:44 PM, Simon Küppers wrote:
> >     > -    Run Pcbnew
> >     >
> >     > +   Edit PCB
> >     >
> >     > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds 
> more
> >     > professional imho.
> >
> >     I'm fine with "Edit PCB Layout".
> >
> >     >
> >     >
> >     > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
> >     >  
>  >>:
> >     >
> >     >     Hi Wayne,
> >     >     it sound good. 
> >     >     I think "Run" should go and I think "Edit Schematic" in
> place of
> >     >     "Run Eeschema" is a great step up.
> >     >
> >     >     The considerations about the use of the words "Symbol"
> and "Table"
> >     >     sound good too.
> >     >
> >     >     I changed the patch accordingly and resubmitted here.
> Just as
> >     >     reference, this is what I came up with:
> >     >
> >     >     -    Run Eeschema
> >     >     +   Edit Schematic
> >     >
> >     >     -    Run Library Editor
> >     >     +   Edit Schematic Symbol
> >     >
> >     >     -    Run Pcbnew
> >     >     +   Edit PCB
> >     >
> >     >     -    Run Footprint Editor
> >     >     +   Edit PCB Footprint
> >     >
> >     >     -    Run Gerbview
> >     >     +   View GERBER
> >     >
> >     >     -    Run Bitmap2Component
> >     >     +   Convert Bitmap to Footprint
> >     >
> >     >     -    Run Pcb Calculator
> >     >     +   Run PCB Calculator
> >     >
> >     >     -    Run Page Layout Editor
> >     >     +   Edit Sheet Layout
> >     >
> >     >     Wayne, please feel free to change the content of this
> patch as you
> >     >     think it is best.
> >     >
> >     >     cheers
> >     >     Fabrizio
> >     >
> >     >
> >     >
> >     >
> >     >
> >     >     On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
> >     >     
> >
> >     
>  >     >
> >     >         Fabrizio,
> >     >
> >     >         I'm fine with the icon changes.  The menu entry
> changes could
> >     >         use some
> >     >         improvement.  I'm not sure removing "Run" from the KiCad
> >     >         launcher menu
> >     >         entries is a good idea.  Generally (at least in most
> of the
> >     >         applications
> >     >         that I've looked at), actions are used in menu
> string when the
> >     >         entry is
> >     >         an action.  I also think it's probably time to get
> rid of
> >     the old
> >     >         Eeschema/Pcbnew application names.  Since KiCad normally
> >     runs in a
> >     >         single process, better menu entries might be "Edit
> Schematic"
> >     >         and "Edit
> >     >         Board (or PCB)".  New users aren't going to know what
> >     Eeschema and
> >     >         Pcbnew are.
> >     >
> >     >         I would also would not refer to the footprint
> library "table"
> >     >         either.
> >     >         The word table seems to confuse users.  I know we
> refer to
> >     it as
> >     >        

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-09-19 Thread Fabrizio Tappero
gentle reminder.



On Thu, Sep 14, 2017 at 12:59 PM, Fabrizio Tappero
 wrote:
> Hi Wayne,
> reviewed the patch and re-submit here. Changes are:
>
> 1) "Edit PCB" is now "Edit PCB Layout"
> 2) "View GERBER" is now "View Gerber Files"
> 3) "Edit Schematic Symbol" is now "Manage Symbol Libraries"
> 4) "Edit Sheet Layout" is now "Edit Page Layout"
> 5) "Convert Bitmap to Footprint" is now "Convert Image"
>
> This should include all the suggestions in this email chain.
> Thanks a lot
> Fabrizio
>
>
>
> On Tue, Sep 12, 2017 at 5:00 PM, Wayne Stambaugh 
> wrote:
>>
>> Fabrizio,
>>
>> Did you submit a revised patch with the suggestions that I made?  I just
>> looked in the mailing list archives and all I see is the original patch.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 9/12/2017 8:57 AM, Fabrizio Tappero wrote:
>> > gentle reminder
>> >
>> > cheers
>> > Fabrizio
>> >
>> >
>> > On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh > > > wrote:
>> >
>> > On 8/29/2017 12:44 PM, Simon Küppers wrote:
>> > > -Run Pcbnew
>> > >
>> > > +   Edit PCB
>> > >
>> > > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds
>> > more
>> > > professional imho.
>> >
>> > I'm fine with "Edit PCB Layout".
>> >
>> > >
>> > >
>> > > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
>> > > >:
>> > >
>> > > Hi Wayne,
>> > > it sound good.
>> > > I think "Run" should go and I think "Edit Schematic" in place
>> > of
>> > > "Run Eeschema" is a great step up.
>> > >
>> > > The considerations about the use of the words "Symbol" and
>> > "Table"
>> > > sound good too.
>> > >
>> > > I changed the patch accordingly and resubmitted here. Just as
>> > > reference, this is what I came up with:
>> > >
>> > > -Run Eeschema
>> > > +   Edit Schematic
>> > >
>> > > -Run Library Editor
>> > > +   Edit Schematic Symbol
>> > >
>> > > -Run Pcbnew
>> > > +   Edit PCB
>> > >
>> > > -Run Footprint Editor
>> > > +   Edit PCB Footprint
>> > >
>> > > -Run Gerbview
>> > > +   View GERBER
>> > >
>> > > -Run Bitmap2Component
>> > > +   Convert Bitmap to Footprint
>> > >
>> > > -Run Pcb Calculator
>> > > +   Run PCB Calculator
>> > >
>> > > -Run Page Layout Editor
>> > > +   Edit Sheet Layout
>> > >
>> > > Wayne, please feel free to change the content of this patch as
>> > you
>> > > think it is best.
>> > >
>> > > cheers
>> > > Fabrizio
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
>> > > 
>> > >> wrote:
>> > >
>> > > Fabrizio,
>> > >
>> > > I'm fine with the icon changes.  The menu entry changes
>> > could
>> > > use some
>> > > improvement.  I'm not sure removing "Run" from the KiCad
>> > > launcher menu
>> > > entries is a good idea.  Generally (at least in most of
>> > the
>> > > applications
>> > > that I've looked at), actions are used in menu string when
>> > the
>> > > entry is
>> > > an action.  I also think it's probably time to get rid of
>> > the old
>> > > Eeschema/Pcbnew application names.  Since KiCad normally
>> > runs in a
>> > > single process, better menu entries might be "Edit
>> > Schematic"
>> > > and "Edit
>> > > Board (or PCB)".  New users aren't going to know what
>> > Eeschema and
>> > > Pcbnew are.
>> > >
>> > > I would also would not refer to the footprint library
>> > "table"
>> > > either.
>> > > The word table seems to confuse users.  I know we refer to
>> > it as
>> > > a table
>> > > on the developers mailing list but I think users are more
>> > > comfortable
>> > > with "Manage Footprint Libraries".  I am aware that I used
>> > table
>> > > for the
>> > > symbol library table dialog menus entry but this is
>> > temporary.
>> > > Once I
>> > > finish the symbol library table remapping code, this
>> > dialog will
>> > > go away
>> > > and "Manage Symbol Libraries" will open the symbol library
>> > table
>> > > edit
>> > > dialog.
>> > >
>> > > The use of symbol was intentional so I would prefer that
>> >   

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-09-14 Thread Fabrizio Tappero
Hi Wayne,
reviewed the patch and re-submit here. Changes are:

1) "Edit PCB" is now "Edit PCB Layout"
2) "View GERBER" is now "View Gerber Files"
3) "Edit Schematic Symbol" is now "Manage Symbol Libraries"
4) "Edit Sheet Layout" is now "Edit Page Layout"
5) "Convert Bitmap to Footprint" is now "Convert Image"

This should include all the suggestions in this email chain.
Thanks a lot
Fabrizio



On Tue, Sep 12, 2017 at 5:00 PM, Wayne Stambaugh 
wrote:

> Fabrizio,
>
> Did you submit a revised patch with the suggestions that I made?  I just
> looked in the mailing list archives and all I see is the original patch.
>
> Cheers,
>
> Wayne
>
> On 9/12/2017 8:57 AM, Fabrizio Tappero wrote:
> > gentle reminder
> >
> > cheers
> > Fabrizio
> >
> >
> > On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh  > > wrote:
> >
> > On 8/29/2017 12:44 PM, Simon Küppers wrote:
> > > -Run Pcbnew
> > >
> > > +   Edit PCB
> > >
> > > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds
> more
> > > professional imho.
> >
> > I'm fine with "Edit PCB Layout".
> >
> > >
> > >
> > > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
> > > >:
> > >
> > > Hi Wayne,
> > > it sound good.
> > > I think "Run" should go and I think "Edit Schematic" in place
> of
> > > "Run Eeschema" is a great step up.
> > >
> > > The considerations about the use of the words "Symbol" and
> "Table"
> > > sound good too.
> > >
> > > I changed the patch accordingly and resubmitted here. Just as
> > > reference, this is what I came up with:
> > >
> > > -Run Eeschema
> > > +   Edit Schematic
> > >
> > > -Run Library Editor
> > > +   Edit Schematic Symbol
> > >
> > > -Run Pcbnew
> > > +   Edit PCB
> > >
> > > -Run Footprint Editor
> > > +   Edit PCB Footprint
> > >
> > > -Run Gerbview
> > > +   View GERBER
> > >
> > > -Run Bitmap2Component
> > > +   Convert Bitmap to Footprint
> > >
> > > -Run Pcb Calculator
> > > +   Run PCB Calculator
> > >
> > > -Run Page Layout Editor
> > > +   Edit Sheet Layout
> > >
> > > Wayne, please feel free to change the content of this patch as
> you
> > > think it is best.
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > >
> > >
> > >
> > > On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
> > > 
> > >> wrote:
> > >
> > > Fabrizio,
> > >
> > > I'm fine with the icon changes.  The menu entry changes
> could
> > > use some
> > > improvement.  I'm not sure removing "Run" from the KiCad
> > > launcher menu
> > > entries is a good idea.  Generally (at least in most of the
> > > applications
> > > that I've looked at), actions are used in menu string when
> the
> > > entry is
> > > an action.  I also think it's probably time to get rid of
> > the old
> > > Eeschema/Pcbnew application names.  Since KiCad normally
> > runs in a
> > > single process, better menu entries might be "Edit
> Schematic"
> > > and "Edit
> > > Board (or PCB)".  New users aren't going to know what
> > Eeschema and
> > > Pcbnew are.
> > >
> > > I would also would not refer to the footprint library
> "table"
> > > either.
> > > The word table seems to confuse users.  I know we refer to
> > it as
> > > a table
> > > on the developers mailing list but I think users are more
> > > comfortable
> > > with "Manage Footprint Libraries".  I am aware that I used
> > table
> > > for the
> > > symbol library table dialog menus entry but this is
> > temporary.
> > > Once I
> > > finish the symbol library table remapping code, this
> > dialog will
> > > go away
> > > and "Manage Symbol Libraries" will open the symbol library
> > table
> > > edit
> > > dialog.
> > >
> > > The use of symbol was intentional so I would prefer that
> > it not be
> > > changed.  There was a discussion about this not too long
> > ago and the
> > > consensus was that symbol made the most sense versus
> component
> > > or part.
> > > I realize that component (and part) are used in the 

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-09-12 Thread Wayne Stambaugh
Fabrizio,

Did you submit a revised patch with the suggestions that I made?  I just
looked in the mailing list archives and all I see is the original patch.

Cheers,

Wayne

On 9/12/2017 8:57 AM, Fabrizio Tappero wrote:
> gentle reminder 
> 
> cheers
> Fabrizio
> 
> 
> On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh  > wrote:
> 
> On 8/29/2017 12:44 PM, Simon Küppers wrote:
> > -    Run Pcbnew
> >
> > +   Edit PCB
> >
> > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds more
> > professional imho.
> 
> I'm fine with "Edit PCB Layout".
> 
> >
> >
> > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
> > >:
> >
> >     Hi Wayne,
> >     it sound good. 
> >     I think "Run" should go and I think "Edit Schematic" in place of
> >     "Run Eeschema" is a great step up.
> >
> >     The considerations about the use of the words "Symbol" and "Table"
> >     sound good too.
> >
> >     I changed the patch accordingly and resubmitted here. Just as
> >     reference, this is what I came up with:
> >
> >     -    Run Eeschema
> >     +   Edit Schematic
> >
> >     -    Run Library Editor
> >     +   Edit Schematic Symbol
> >
> >     -    Run Pcbnew
> >     +   Edit PCB
> >
> >     -    Run Footprint Editor
> >     +   Edit PCB Footprint
> >
> >     -    Run Gerbview
> >     +   View GERBER
> >
> >     -    Run Bitmap2Component
> >     +   Convert Bitmap to Footprint
> >
> >     -    Run Pcb Calculator
> >     +   Run PCB Calculator
> >
> >     -    Run Page Layout Editor
> >     +   Edit Sheet Layout
> >
> >     Wayne, please feel free to change the content of this patch as you
> >     think it is best.
> >
> >     cheers
> >     Fabrizio
> >
> >
> >
> >
> >
> >     On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
> >     
> >> wrote:
> >
> >         Fabrizio,
> >
> >         I'm fine with the icon changes.  The menu entry changes could
> >         use some
> >         improvement.  I'm not sure removing "Run" from the KiCad
> >         launcher menu
> >         entries is a good idea.  Generally (at least in most of the
> >         applications
> >         that I've looked at), actions are used in menu string when the
> >         entry is
> >         an action.  I also think it's probably time to get rid of
> the old
> >         Eeschema/Pcbnew application names.  Since KiCad normally
> runs in a
> >         single process, better menu entries might be "Edit Schematic"
> >         and "Edit
> >         Board (or PCB)".  New users aren't going to know what
> Eeschema and
> >         Pcbnew are.
> >
> >         I would also would not refer to the footprint library "table"
> >         either.
> >         The word table seems to confuse users.  I know we refer to
> it as
> >         a table
> >         on the developers mailing list but I think users are more
> >         comfortable
> >         with "Manage Footprint Libraries".  I am aware that I used
> table
> >         for the
> >         symbol library table dialog menus entry but this is
> temporary. 
> >         Once I
> >         finish the symbol library table remapping code, this
> dialog will
> >         go away
> >         and "Manage Symbol Libraries" will open the symbol library
> table
> >         edit
> >         dialog.
> >
> >         The use of symbol was intentional so I would prefer that
> it not be
> >         changed.  There was a discussion about this not too long
> ago and the
> >         consensus was that symbol made the most sense versus component
> >         or part.
> >         I realize that component (and part) are used in the source
> code
> >         and most
> >         of the UI strings but I would prefer that we change the UI
> >         strings to
> >         symbol for the stable 5 release rather than continue to use
> >         component
> >         and/or part.  I will change the source when I get a chance so
> >         that the
> >         terminology is coherent between the source and the UI
> strings. 
> >         I know
> >         we still have the module/footprint distinction in the Pcbnew
> >         source but
> >         at least all of the UI strings are "footprint".
> >
> >         Cheers,
> >
> >         Wayne
> >
> >         On 8/22/2017 5:47 PM, Fabrizio 

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-09-12 Thread Fabrizio Tappero
gentle reminder

cheers
Fabrizio


On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh 
wrote:

> On 8/29/2017 12:44 PM, Simon Küppers wrote:
> > -Run Pcbnew
> >
> > +   Edit PCB
> >
> > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds more
> > professional imho.
>
> I'm fine with "Edit PCB Layout".
>
> >
> >
> > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
> > :
> >
> > Hi Wayne,
> > it sound good.
> > I think "Run" should go and I think "Edit Schematic" in place of
> > "Run Eeschema" is a great step up.
> >
> > The considerations about the use of the words "Symbol" and "Table"
> > sound good too.
> >
> > I changed the patch accordingly and resubmitted here. Just as
> > reference, this is what I came up with:
> >
> > -Run Eeschema
> > +   Edit Schematic
> >
> > -Run Library Editor
> > +   Edit Schematic Symbol
> >
> > -Run Pcbnew
> > +   Edit PCB
> >
> > -Run Footprint Editor
> > +   Edit PCB Footprint
> >
> > -Run Gerbview
> > +   View GERBER
> >
> > -Run Bitmap2Component
> > +   Convert Bitmap to Footprint
> >
> > -Run Pcb Calculator
> > +   Run PCB Calculator
> >
> > -Run Page Layout Editor
> > +   Edit Sheet Layout
> >
> > Wayne, please feel free to change the content of this patch as you
> > think it is best.
> >
> > cheers
> > Fabrizio
> >
> >
> >
> >
> >
> > On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
> > > wrote:
> >
> > Fabrizio,
> >
> > I'm fine with the icon changes.  The menu entry changes could
> > use some
> > improvement.  I'm not sure removing "Run" from the KiCad
> > launcher menu
> > entries is a good idea.  Generally (at least in most of the
> > applications
> > that I've looked at), actions are used in menu string when the
> > entry is
> > an action.  I also think it's probably time to get rid of the old
> > Eeschema/Pcbnew application names.  Since KiCad normally runs in
> a
> > single process, better menu entries might be "Edit Schematic"
> > and "Edit
> > Board (or PCB)".  New users aren't going to know what Eeschema
> and
> > Pcbnew are.
> >
> > I would also would not refer to the footprint library "table"
> > either.
> > The word table seems to confuse users.  I know we refer to it as
> > a table
> > on the developers mailing list but I think users are more
> > comfortable
> > with "Manage Footprint Libraries".  I am aware that I used table
> > for the
> > symbol library table dialog menus entry but this is temporary.
> > Once I
> > finish the symbol library table remapping code, this dialog will
> > go away
> > and "Manage Symbol Libraries" will open the symbol library table
> > edit
> > dialog.
> >
> > The use of symbol was intentional so I would prefer that it not
> be
> > changed.  There was a discussion about this not too long ago and
> the
> > consensus was that symbol made the most sense versus component
> > or part.
> > I realize that component (and part) are used in the source code
> > and most
> > of the UI strings but I would prefer that we change the UI
> > strings to
> > symbol for the stable 5 release rather than continue to use
> > component
> > and/or part.  I will change the source when I get a chance so
> > that the
> > terminology is coherent between the source and the UI strings.
> > I know
> > we still have the module/footprint distinction in the Pcbnew
> > source but
> > at least all of the UI strings are "footprint".
> >
> > Cheers,
> >
> > Wayne
> >
> > On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
> > > Reminder.
> > >
> > > Regards
> > > Fabrizio
> > >
> > >
> > > On Aug 17, 2017 4:42 PM, "Fabrizio Tappero" <
> fabrizio.tapp...@gmail.com 
> > >  gmail.com>>>
> > wrote:
> > >
> > > Hello,
> > > the following patch does the following:
> > > 1) correct few pcbnew and eeschema menu text entries
> > > 2) add the library table icon (minor look change)
> > > 3) delete the redundant word "Run" into the KiCad - Tools
> menu entry
> > >
> > > cheers
> > > Fabrzio
> > >
> > >
> > >
> > > ___
> > > Mailing list: 

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Wayne Stambaugh
On 8/29/2017 12:44 PM, Simon Küppers wrote:
> -    Run Pcbnew
> 
> +   Edit PCB
> 
> What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds more
> professional imho.

I'm fine with "Edit PCB Layout".

> 
> 
> Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
> :
> 
> Hi Wayne,
> it sound good. 
> I think "Run" should go and I think "Edit Schematic" in place of
> "Run Eeschema" is a great step up.
> 
> The considerations about the use of the words "Symbol" and "Table"
> sound good too.
> 
> I changed the patch accordingly and resubmitted here. Just as
> reference, this is what I came up with:
> 
> -    Run Eeschema
> +   Edit Schematic
> 
> -    Run Library Editor
> +   Edit Schematic Symbol
> 
> -    Run Pcbnew
> +   Edit PCB
> 
> -    Run Footprint Editor
> +   Edit PCB Footprint
> 
> -    Run Gerbview
> +   View GERBER
> 
> -    Run Bitmap2Component
> +   Convert Bitmap to Footprint
> 
> -    Run Pcb Calculator
> +   Run PCB Calculator
> 
> -    Run Page Layout Editor
> +   Edit Sheet Layout
> 
> Wayne, please feel free to change the content of this patch as you
> think it is best.
> 
> cheers
> Fabrizio
> 
> 
> 
> 
> 
> On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
> > wrote:
> 
> Fabrizio,
> 
> I'm fine with the icon changes.  The menu entry changes could
> use some
> improvement.  I'm not sure removing "Run" from the KiCad
> launcher menu
> entries is a good idea.  Generally (at least in most of the
> applications
> that I've looked at), actions are used in menu string when the
> entry is
> an action.  I also think it's probably time to get rid of the old
> Eeschema/Pcbnew application names.  Since KiCad normally runs in a
> single process, better menu entries might be "Edit Schematic"
> and "Edit
> Board (or PCB)".  New users aren't going to know what Eeschema and
> Pcbnew are.
> 
> I would also would not refer to the footprint library "table"
> either.
> The word table seems to confuse users.  I know we refer to it as
> a table
> on the developers mailing list but I think users are more
> comfortable
> with "Manage Footprint Libraries".  I am aware that I used table
> for the
> symbol library table dialog menus entry but this is temporary. 
> Once I
> finish the symbol library table remapping code, this dialog will
> go away
> and "Manage Symbol Libraries" will open the symbol library table
> edit
> dialog.
> 
> The use of symbol was intentional so I would prefer that it not be
> changed.  There was a discussion about this not too long ago and the
> consensus was that symbol made the most sense versus component
> or part.
> I realize that component (and part) are used in the source code
> and most
> of the UI strings but I would prefer that we change the UI
> strings to
> symbol for the stable 5 release rather than continue to use
> component
> and/or part.  I will change the source when I get a chance so
> that the
> terminology is coherent between the source and the UI strings. 
> I know
> we still have the module/footprint distinction in the Pcbnew
> source but
> at least all of the UI strings are "footprint".
> 
> Cheers,
> 
> Wayne
> 
> On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
> > Reminder.
> >
> > Regards
> > Fabrizio
> >
> >
> > On Aug 17, 2017 4:42 PM, "Fabrizio Tappero" 
> 
> >  >>
> wrote:
> >
> >     Hello,
> >     the following patch does the following:
> >     1) correct few pcbnew and eeschema menu text entries
> >     2) add the library table icon (minor look change)
> >     3) delete the redundant word "Run" into the KiCad - Tools menu 
> entry
> >
> >     cheers
> >     Fabrzio
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Simon Küppers
-    Run Pcbnew

+   Edit PCB

What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds more 
professional imho. 


Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero 
:
>Hi Wayne,
>it sound good.
>I think "Run" should go and I think "Edit Schematic" in place of "Run
>Eeschema" is a great step up.
>
>The considerations about the use of the words "Symbol" and "Table"
>sound
>good too.
>
>I changed the patch accordingly and resubmitted here. Just as
>reference,
>this is what I came up with:
>
>-Run Eeschema
>+   Edit Schematic
>
>-Run Library Editor
>+   Edit Schematic Symbol
>
>-Run Pcbnew
>+   Edit PCB
>
>-Run Footprint Editor
>+   Edit PCB Footprint
>
>-Run Gerbview
>+   View GERBER
>
>-Run Bitmap2Component
>+   Convert Bitmap to Footprint
>
>-Run Pcb Calculator
>+   Run PCB Calculator
>
>-Run Page Layout Editor
>+   Edit Sheet Layout
>
>Wayne, please feel free to change the content of this patch as you
>think it
>is best.
>
>cheers
>Fabrizio
>
>
>
>
>
>On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh 
>wrote:
>
>> Fabrizio,
>>
>> I'm fine with the icon changes.  The menu entry changes could use
>some
>> improvement.  I'm not sure removing "Run" from the KiCad launcher
>menu
>> entries is a good idea.  Generally (at least in most of the
>applications
>> that I've looked at), actions are used in menu string when the entry
>is
>> an action.  I also think it's probably time to get rid of the old
>> Eeschema/Pcbnew application names.  Since KiCad normally runs in a
>> single process, better menu entries might be "Edit Schematic" and
>"Edit
>> Board (or PCB)".  New users aren't going to know what Eeschema and
>> Pcbnew are.
>>
>> I would also would not refer to the footprint library "table" either.
>> The word table seems to confuse users.  I know we refer to it as a
>table
>> on the developers mailing list but I think users are more comfortable
>> with "Manage Footprint Libraries".  I am aware that I used table for
>the
>> symbol library table dialog menus entry but this is temporary.  Once
>I
>> finish the symbol library table remapping code, this dialog will go
>away
>> and "Manage Symbol Libraries" will open the symbol library table edit
>> dialog.
>>
>> The use of symbol was intentional so I would prefer that it not be
>> changed.  There was a discussion about this not too long ago and the
>> consensus was that symbol made the most sense versus component or
>part.
>> I realize that component (and part) are used in the source code and
>most
>> of the UI strings but I would prefer that we change the UI strings to
>> symbol for the stable 5 release rather than continue to use component
>> and/or part.  I will change the source when I get a chance so that
>the
>> terminology is coherent between the source and the UI strings.  I
>know
>> we still have the module/footprint distinction in the Pcbnew source
>but
>> at least all of the UI strings are "footprint".
>>
>> Cheers,
>>
>> Wayne
>>
>> On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
>> > Reminder.
>> >
>> > Regards
>> > Fabrizio
>> >
>> >
>> > On Aug 17, 2017 4:42 PM, "Fabrizio Tappero"
>> > > wrote:
>> >
>> > Hello,
>> > the following patch does the following:
>> > 1) correct few pcbnew and eeschema menu text entries
>> > 2) add the library table icon (minor look change)
>> > 3) delete the redundant word "Run" into the KiCad - Tools menu
>entry
>> >
>> > cheers
>> > Fabrzio
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Eldar Khayrullin

Hello.
Maybe it is right to use "Actions" instead "Run" in menu entry.

В Вторник, 29 авг. 2017 в 11:05 , Fabrizio Tappero 
 написал:

Hi Wayne,
it sound good.
I think "Run" should go and I think "Edit Schematic" in place of "Run 
Eeschema" is a great step up.


The considerations about the use of the words "Symbol" and "Table" 
sound good too.


I changed the patch accordingly and resubmitted here. Just as 
reference, this is what I came up with:


-Run Eeschema
+   Edit Schematic

-Run Library Editor
+   Edit Schematic Symbol

-Run Pcbnew
+   Edit PCB

-Run Footprint Editor
+   Edit PCB Footprint

-Run Gerbview
+   View GERBER

-Run Bitmap2Component
+   Convert Bitmap to Footprint

-Run Pcb Calculator
+   Run PCB Calculator

-Run Page Layout Editor
+   Edit Sheet Layout

Wayne, please feel free to change the content of this patch as you 
think it is best.


cheers
Fabrizio





On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh 
 wrote:

Fabrizio,

I'm fine with the icon changes.  The menu entry changes could use 
some
improvement.  I'm not sure removing "Run" from the KiCad launcher 
menu
entries is a good idea.  Generally (at least in most of the 
applications
that I've looked at), actions are used in menu string when the entry 
is

an action.  I also think it's probably time to get rid of the old
Eeschema/Pcbnew application names.  Since KiCad normally runs in a
single process, better menu entries might be "Edit Schematic" and 
"Edit

Board (or PCB)".  New users aren't going to know what Eeschema and
Pcbnew are.

I would also would not refer to the footprint library "table" either.
The word table seems to confuse users.  I know we refer to it as a 
table

on the developers mailing list but I think users are more comfortable
with "Manage Footprint Libraries".  I am aware that I used table for 
the
symbol library table dialog menus entry but this is temporary.  Once 
I
finish the symbol library table remapping code, this dialog will go 
away

and "Manage Symbol Libraries" will open the symbol library table edit
dialog.

The use of symbol was intentional so I would prefer that it not be
changed.  There was a discussion about this not too long ago and the
consensus was that symbol made the most sense versus component or 
part.
I realize that component (and part) are used in the source code and 
most

of the UI strings but I would prefer that we change the UI strings to
symbol for the stable 5 release rather than continue to use component
and/or part.  I will change the source when I get a chance so that 
the
terminology is coherent between the source and the UI strings.  I 
know
we still have the module/footprint distinction in the Pcbnew source 
but

at least all of the UI strings are "footprint".

Cheers,

Wayne

On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
> Reminder.
>
> Regards
> Fabrizio
>
>
> On Aug 17, 2017 4:42 PM, "Fabrizio Tappero" 
 > wrote:
>
> Hello,
> the following patch does the following:
> 1) correct few pcbnew and eeschema menu text entries
> 2) add the library table icon (minor look change)
> 3) delete the redundant word "Run" into the KiCad - Tools menu 
entry

>
> cheers
> Fabrzio
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Kevin Cozens

On 2017-08-29 09:46 AM, Wayne Stambaugh wrote:

Maybe "View Gerber Files"?


That sounds better and is more indicative of what it does.

--
Cheers!

Kevin.

http://www.ve3syb.ca/   |"Nerds make the shiny things that distract
Owner of Elecraft K2 #2172  | the mouth-breathers, and that's why we're
| powerful!"
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Kevin Cozens

On 2017-08-29 09:35 AM, Wayne Stambaugh wrote:

"Manage Symbol Libraries" would be accurate.

I think we have a winner.

--
Cheers!

Kevin.

http://www.ve3syb.ca/   |"Nerds make the shiny things that distract
Owner of Elecraft K2 #2172  | the mouth-breathers, and that's why we're
| powerful!"
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Wayne Stambaugh
On 8/29/2017 9:30 AM, Kevin Cozens wrote:
> On 2017-08-29 05:51 AM, Clemens Koller wrote:
>> On 2017-08-29 10:04, Fabrizio Tappero wrote:
>>> I changed the patch accordingly and resubmitted here. Just as
>>> reference, this is what I came up with:
>>> -    Run Gerbview
>>> +   View GERBER
>>
>> I suggest to use "Gerber" intead of "GERBER" in general.
> 
> Would it be better to use "Gerbers" as there is more than one file?
> 

Maybe "View Gerber Files"?

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Wayne Stambaugh
On 8/29/2017 9:26 AM, Kevin Cozens wrote:
> On 2017-08-29 04:04 AM, Fabrizio Tappero wrote:
>> I changed the patch accordingly and resubmitted here. Just as
>> reference, this is what I came up with:
> 
> Most of the suggestions look good to me with a couple of exceptions.
> 
>> -    Run Library Editor
>> +   Edit Schematic Symbol
> 
> The suggested change would read like a menu entry that will let you edit
> a single symbol rather than starting a program to work on the libraries.
> Perhaps someone else can suggest a better alternative as I can't think
> of a better one right now.

"Manage Symbol Libraries" would be accurate.

> 
>> -    Run Page Layout Editor
>> +   Edit Sheet Layout
> I just read another email from the mailing list that mentioned the use
> of "Page Layout" vs "Worksheet". A point was made that "Worksheet" may
> be the better choice. If so, that should be used here for consistency.
> 

"Worksheet" would be a better choice assuming we change all references
of "Page Layout" to "Worksheet" including the documentation.  I'm pretty
sure "Page Layout" is the term that is used in most places.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Kevin Cozens

On 2017-08-29 04:04 AM, Fabrizio Tappero wrote:
I changed the patch accordingly and resubmitted here. Just as reference, 
this is what I came up with:


Most of the suggestions look good to me with a couple of exceptions.


- Â  Â Run Library Editor
+ Â  Edit Schematic Symbol


The suggested change would read like a menu entry that will let you edit a 
single symbol rather than starting a program to work on the libraries. 
Perhaps someone else can suggest a better alternative as I can't think of a 
better one right now.



- Â  Â Run Page Layout Editor
+ Â  Edit Sheet Layout
I just read another email from the mailing list that mentioned the use of 
"Page Layout" vs "Worksheet". A point was made that "Worksheet" may be the 
better choice. If so, that should be used here for consistency.


--
Cheers!

Kevin.

http://www.ve3syb.ca/   |"Nerds make the shiny things that distract
Owner of Elecraft K2 #2172  | the mouth-breathers, and that's why we're
| powerful!"
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Wayne Stambaugh
On 8/29/2017 4:18 AM, Oliver Walters wrote:
> Note:
> 
> The hover-text for the large buttons in the KiCad launcher window has
> already been updated, so you should either match the menu entries to
> these new texts, or update both :)

Agreed, the toolbar button tooltips should be consistent with the menu
entries.

> 
> On Tue, Aug 29, 2017 at 6:13 PM, Gaurav Juvekar  > wrote:
> 
> Hi all,
> 
> Chiming in with a minor suggestion.
> 
> > -    Run Bitmap2Component
> > +   Convert Bitmap to Footprint
> 
> Perhaps this could be "Convert Bitmap Image to Footprint"?
> I think the image part is more user-friendly and informative than
> just saying
> "bitmap".
> 
> --
> Regards,
> Gaurav Juvekar
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Wayne Stambaugh
On 8/29/2017 4:13 AM, Gaurav Juvekar wrote:
> Hi all,
> 
> Chiming in with a minor suggestion.
> 
>> -Run Bitmap2Component
>> +   Convert Bitmap to Footprint
> 
> Perhaps this could be "Convert Bitmap Image to Footprint"?
> I think the image part is more user-friendly and informative than just saying
> "bitmap".

"Image" would be more accurate.  Bitmap is a type of image file.
Bitmap2Component can load bitmaps, pngs, jpegs, etc.

Footprint is not entirely accurate either.  Bitmap2Component can also
generate symbol libraries, worksheet title block logos, and postscript
files.  Perhaps "Convert Image" would be better.

> 
> --
> Regards,
> Gaurav Juvekar
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Clemens Koller
Hi!

On 2017-08-29 10:04, Fabrizio Tappero wrote:
> I changed the patch accordingly and resubmitted here. Just as reference, this 
> is what I came up with:
> -    Run Gerbview
> +   View GERBER

I suggest to use "Gerber" intead of "GERBER" in general. "Gerber" is not an 
abbreviation.

Regards,

Clemens

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Oliver Walters
Note:

The hover-text for the large buttons in the KiCad launcher window has
already been updated, so you should either match the menu entries to these
new texts, or update both :)

On Tue, Aug 29, 2017 at 6:13 PM, Gaurav Juvekar 
wrote:

> Hi all,
>
> Chiming in with a minor suggestion.
>
> > -Run Bitmap2Component
> > +   Convert Bitmap to Footprint
>
> Perhaps this could be "Convert Bitmap Image to Footprint"?
> I think the image part is more user-friendly and informative than just
> saying
> "bitmap".
>
> --
> Regards,
> Gaurav Juvekar
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Gaurav Juvekar
Hi all,

Chiming in with a minor suggestion.

> -Run Bitmap2Component
> +   Convert Bitmap to Footprint

Perhaps this could be "Convert Bitmap Image to Footprint"?
I think the image part is more user-friendly and informative than just saying
"bitmap".

--
Regards,
Gaurav Juvekar

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-29 Thread Fabrizio Tappero
Hi Wayne,
it sound good.
I think "Run" should go and I think "Edit Schematic" in place of "Run
Eeschema" is a great step up.

The considerations about the use of the words "Symbol" and "Table" sound
good too.

I changed the patch accordingly and resubmitted here. Just as reference,
this is what I came up with:

-Run Eeschema
+   Edit Schematic

-Run Library Editor
+   Edit Schematic Symbol

-Run Pcbnew
+   Edit PCB

-Run Footprint Editor
+   Edit PCB Footprint

-Run Gerbview
+   View GERBER

-Run Bitmap2Component
+   Convert Bitmap to Footprint

-Run Pcb Calculator
+   Run PCB Calculator

-Run Page Layout Editor
+   Edit Sheet Layout

Wayne, please feel free to change the content of this patch as you think it
is best.

cheers
Fabrizio





On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh 
wrote:

> Fabrizio,
>
> I'm fine with the icon changes.  The menu entry changes could use some
> improvement.  I'm not sure removing "Run" from the KiCad launcher menu
> entries is a good idea.  Generally (at least in most of the applications
> that I've looked at), actions are used in menu string when the entry is
> an action.  I also think it's probably time to get rid of the old
> Eeschema/Pcbnew application names.  Since KiCad normally runs in a
> single process, better menu entries might be "Edit Schematic" and "Edit
> Board (or PCB)".  New users aren't going to know what Eeschema and
> Pcbnew are.
>
> I would also would not refer to the footprint library "table" either.
> The word table seems to confuse users.  I know we refer to it as a table
> on the developers mailing list but I think users are more comfortable
> with "Manage Footprint Libraries".  I am aware that I used table for the
> symbol library table dialog menus entry but this is temporary.  Once I
> finish the symbol library table remapping code, this dialog will go away
> and "Manage Symbol Libraries" will open the symbol library table edit
> dialog.
>
> The use of symbol was intentional so I would prefer that it not be
> changed.  There was a discussion about this not too long ago and the
> consensus was that symbol made the most sense versus component or part.
> I realize that component (and part) are used in the source code and most
> of the UI strings but I would prefer that we change the UI strings to
> symbol for the stable 5 release rather than continue to use component
> and/or part.  I will change the source when I get a chance so that the
> terminology is coherent between the source and the UI strings.  I know
> we still have the module/footprint distinction in the Pcbnew source but
> at least all of the UI strings are "footprint".
>
> Cheers,
>
> Wayne
>
> On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
> > Reminder.
> >
> > Regards
> > Fabrizio
> >
> >
> > On Aug 17, 2017 4:42 PM, "Fabrizio Tappero"  > > wrote:
> >
> > Hello,
> > the following patch does the following:
> > 1) correct few pcbnew and eeschema menu text entries
> > 2) add the library table icon (minor look change)
> > 3) delete the redundant word "Run" into the KiCad - Tools menu entry
> >
> > cheers
> > Fabrzio
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
From b977fa7899d3aac0ac925aa57b31edf4d79b510c Mon Sep 17 00:00:00 2001
From: Fabrizio Tappero 
Date: Thu, 17 Aug 2017 16:39:11 +0200
Subject: [PATCH] library option reviewed and renamed, minor menu text changes

---
 bitmaps_png/CMakeLists.txt|   1 -
 bitmaps_png/cpp_26/library_option.cpp | 117 +++
 bitmaps_png/cpp_26/library_table.cpp  | 170 ++
 bitmaps_png/cpp_26/move_zone.cpp  |  67 --
 bitmaps_png/sources/library_table.svg | 137 ++-
 bitmaps_png/sources/move_zone.svg | 169 -
 cvpcb/menubar.cpp |   2 +-
 eeschema/menubar.cpp  |   8 +-
 eeschema/menubar_libedit.cpp  |   6 +-
 include/bitmaps.h |   1 -
 kicad/menubar.cpp |  16 ++--
 pcbnew/help_common_strings.h  |   4 +-
 pcbnew/menubar_modedit.cpp|   4 +-
 pcbnew/menubar_pcbframe.cpp   |   4 +-
 pcbnew/onrightclick.cpp   |   2 +-
 15 files changed, 258 insertions(+), 450 deletions(-)
 create mode 100644 

Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-28 Thread Wayne Stambaugh
Fabrizio,

I'm fine with the icon changes.  The menu entry changes could use some
improvement.  I'm not sure removing "Run" from the KiCad launcher menu
entries is a good idea.  Generally (at least in most of the applications
that I've looked at), actions are used in menu string when the entry is
an action.  I also think it's probably time to get rid of the old
Eeschema/Pcbnew application names.  Since KiCad normally runs in a
single process, better menu entries might be "Edit Schematic" and "Edit
Board (or PCB)".  New users aren't going to know what Eeschema and
Pcbnew are.

I would also would not refer to the footprint library "table" either.
The word table seems to confuse users.  I know we refer to it as a table
on the developers mailing list but I think users are more comfortable
with "Manage Footprint Libraries".  I am aware that I used table for the
symbol library table dialog menus entry but this is temporary.  Once I
finish the symbol library table remapping code, this dialog will go away
and "Manage Symbol Libraries" will open the symbol library table edit
dialog.

The use of symbol was intentional so I would prefer that it not be
changed.  There was a discussion about this not too long ago and the
consensus was that symbol made the most sense versus component or part.
I realize that component (and part) are used in the source code and most
of the UI strings but I would prefer that we change the UI strings to
symbol for the stable 5 release rather than continue to use component
and/or part.  I will change the source when I get a chance so that the
terminology is coherent between the source and the UI strings.  I know
we still have the module/footprint distinction in the Pcbnew source but
at least all of the UI strings are "footprint".

Cheers,

Wayne

On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
> Reminder.
> 
> Regards
> Fabrizio
> 
> 
> On Aug 17, 2017 4:42 PM, "Fabrizio Tappero"  > wrote:
> 
> Hello,
> the following patch does the following:
> 1) correct few pcbnew and eeschema menu text entries
> 2) add the library table icon (minor look change)
> 3) delete the redundant word "Run" into the KiCad - Tools menu entry
> 
> cheers
> Fabrzio
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH] minor icon improvements

2017-08-22 Thread Fabrizio Tappero
Reminder.

Regards
Fabrizio


On Aug 17, 2017 4:42 PM, "Fabrizio Tappero" 
wrote:

> Hello,
> the following patch does the following:
> 1) correct few pcbnew and eeschema menu text entries
> 2) add the library table icon (minor look change)
> 3) delete the redundant word "Run" into the KiCad - Tools menu entry
>
> cheers
> Fabrzio
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] [PATCH] minor icon improvements

2017-08-17 Thread Fabrizio Tappero
Hello,
the following patch does the following:
1) correct few pcbnew and eeschema menu text entries
2) add the library table icon (minor look change)
3) delete the redundant word "Run" into the KiCad - Tools menu entry

cheers
Fabrzio
From b977fa7899d3aac0ac925aa57b31edf4d79b510c Mon Sep 17 00:00:00 2001
From: Fabrizio Tappero 
Date: Thu, 17 Aug 2017 16:39:11 +0200
Subject: [PATCH] library option reviewed and renamed, minor menu text changes

---
 bitmaps_png/CMakeLists.txt|   1 -
 bitmaps_png/cpp_26/library_option.cpp | 117 +++
 bitmaps_png/cpp_26/library_table.cpp  | 170 ++
 bitmaps_png/cpp_26/move_zone.cpp  |  67 --
 bitmaps_png/sources/library_table.svg | 137 ++-
 bitmaps_png/sources/move_zone.svg | 169 -
 cvpcb/menubar.cpp |   2 +-
 eeschema/menubar.cpp  |   8 +-
 eeschema/menubar_libedit.cpp  |   6 +-
 include/bitmaps.h |   1 -
 kicad/menubar.cpp |  16 ++--
 pcbnew/help_common_strings.h  |   4 +-
 pcbnew/menubar_modedit.cpp|   4 +-
 pcbnew/menubar_pcbframe.cpp   |   4 +-
 pcbnew/onrightclick.cpp   |   2 +-
 15 files changed, 258 insertions(+), 450 deletions(-)
 create mode 100644 bitmaps_png/cpp_26/library_option.cpp
 delete mode 100644 bitmaps_png/cpp_26/move_zone.cpp
 delete mode 100644 bitmaps_png/sources/move_zone.svg

diff --git a/bitmaps_png/CMakeLists.txt b/bitmaps_png/CMakeLists.txt
index 40003dc..33bcdbc 100644
--- a/bitmaps_png/CMakeLists.txt
+++ b/bitmaps_png/CMakeLists.txt
@@ -345,7 +345,6 @@ set( BMAPS_MID
 move_rectangle
 move_sheet
 move_target
-move_zone
 move
 move_relative
 mw_add_gap
diff --git a/bitmaps_png/cpp_26/library_option.cpp b/bitmaps_png/cpp_26/library_option.cpp
new file mode 100644
index 000..8e90fbf
--- /dev/null
+++ b/bitmaps_png/cpp_26/library_option.cpp
@@ -0,0 +1,117 @@
+
+/* Do not modify this file, it was automatically generated by the
+ * PNG2cpp CMake script, using a *.png file as input.
+ */
+
+#include 
+
+static const unsigned char png[] = {
+ 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d, 0x49, 0x48, 0x44, 0x52,
+ 0x00, 0x00, 0x00, 0x1a, 0x00, 0x00, 0x00, 0x1a, 0x08, 0x06, 0x00, 0x00, 0x00, 0xa9, 0x4a, 0x4c,
+ 0xce, 0x00, 0x00, 0x06, 0x41, 0x49, 0x44, 0x41, 0x54, 0x48, 0xc7, 0xad, 0x96, 0x6b, 0x4c, 0x93,
+ 0x57, 0x18, 0xc7, 0x0b, 0x7e, 0xd8, 0x96, 0x7d, 0xdc, 0xfc, 0xb2, 0x2d, 0x93, 0xf7, 0x2d, 0x83,
+ 0x4d, 0x65, 0x43, 0x05, 0x26, 0x8a, 0x02, 0x6d, 0xb9, 0x33, 0x83, 0x2e, 0x5e, 0xe2, 0x15, 0x50,
+ 0xc8, 0x20, 0x92, 0xa9, 0x44, 0x68, 0x01, 0x95, 0xcc, 0x88, 0x20, 0x0e, 0x04, 0x26, 0xcc, 0x11,
+ 0x05, 0x17, 0x30, 0xd0, 0x22, 0xe3, 0x32, 0x19, 0xb0, 0x04, 0x27, 0x2a, 0xde, 0xca, 0x45, 0xee,
+ 0x20, 0x13, 0x14, 0x08, 0xa0, 0x68, 0xb9, 0x94, 0x16, 0x69, 0xcb, 0x7f, 0xe7, 0x9c, 0x42, 0x27,
+ 0x48, 0xa6, 0x26, 0x7b, 0x93, 0x27, 0x39, 0x79, 0xfb, 0xe6, 0xfc, 0xce, 0xf3, 0xfc, 0xff, 0xe7,
+ 0x79, 0x2a, 0x10, 0xcc, 0x7b, 0xc4, 0xd1, 0xc2, 0x08, 0x71, 0x34, 0x97, 0x2d, 0x91, 0x72, 0xc1,
+ 0xa2, 0x08, 0xce, 0xc1, 0xf1, 0xe0, 0x27, 0xef, 0x09, 0xde, 0xf0, 0x69, 0x56, 0x98, 0xa9, 0x5a,
+ 0x14, 0x66, 0x93, 0xf3, 0x83, 0xbc, 0x9f, 0x78, 0xe5, 0x63, 0xd7, 0x68, 0xae, 0xe9, 0xeb, 0x64,
+ 0x1e, 0x8e, 0xa7, 0x79, 0xb5, 0x73, 0x2c, 0x37, 0x2a, 0x91, 0xf1, 0x3a, 0x71, 0x0c, 0xf7, 0xc8,
+ 0xe5, 0x88, 0x45, 0xa1, 0x9b, 0x4c, 0xb8, 0xf6, 0xbf, 0x40, 0x2d, 0x72, 0x81, 0x7e, 0xb2, 0xce,
+ 0x12, 0xba, 0x06, 0xab, 0x39, 0xd1, 0xaa, 0x30, 0x7b, 0x31, 0xe7, 0xc3, 0xd8, 0x58, 0x81, 0xb9,
+ 0x44, 0xc6, 0x4d, 0x5a, 0x29, 0x2c, 0x61, 0x59, 0x64, 0x8c, 0xcf, 0x0a, 0x2d, 0xb1, 0x2c, 0xc7,
+ 0x12, 0x04, 0xaa, 0x91, 0x48, 0xf9, 0x6f, 0x5f, 0x07, 0xd2, 0xdf, 0xb7, 0x06, 0x9a, 0x97, 0xce,
+ 0x89, 0xd6, 0x02, 0xf3, 0xc9, 0xb9, 0x65, 0x93, 0xf1, 0x56, 0xa2, 0x18, 0x4e, 0x4d, 0x01, 0xd6,
+ 0xc5, 0xd6, 0x70, 0xf8, 0xc3, 0xc1, 0x04, 0x24, 0xef, 0x27, 0x24, 0xd2, 0x4f, 0xf9, 0x37, 0x06,
+ 0xa9, 0x4a, 0x80, 0x16, 0xdb, 0x85, 0x41, 0x92, 0x48, 0x6e, 0xcb, 0xda, 0x38, 0x7e, 0x94, 0x6e,
+ 0xec, 0x5d, 0xe5, 0x8d, 0x46, 0x55, 0x23, 0x83, 0x58, 0x93, 0x0c, 0xc5, 0x32, 0x4e, 0x6b, 0xe6,
+ 0x26, 0x1f, 0x11, 0xb8, 0xc9, 0x0d, 0xaf, 0x84, 0x84, 0xc4, 0x7c, 0x90, 0x6e, 0x08, 0x68, 0x5d,
+ 0xb9, 0x30, 0x48, 0x14, 0x65, 0x11, 0x6f, 0x9f, 0xc6, 0xeb, 0xe9, 0xe6, 0xe1, 0xca, 0x70, 0xe4,
+ 0xf7, 0xe4, 0x33, 0x90, 0x4d, 0xb6, 0x10, 0xae, 0x31, 0x5c, 0x83, 0xb9, 0x7b, 0x81, 0xc6, 0xf3,
+ 0xf4, 0x18, 0xfc, 0xce, 0x4e, 0x99, 0xe2, 0x9b, 0x14, 0x2d, 0x08, 0x08, 0x6f, 0x05, 0x22, 0x9b,
+ 0xdd, 0xf8, 0xf2, 0x82, 0x90, 0x6d, 0x9e, 0xf9, 0x20, 0x13, 0xb1, 0xf7, 0x63, 0xd9, 0x7a, 0x55,
+ 0x3a, 0x3f, 0x2d, 0x89, 0xe2, 0x33, 0x28, 0xc8, 0xf7, 0x8c, 0x06, 0x9b, 0xcf, 0xc1, 0x14, 0x9b,
+ 0xd2, 0xf5, 0x6f, 0x0f, 0x12, 0x45, 0x73, 0xaa, 0xcf, 0xf3, 0x8c, 0x9a, 0xdc, 0x7c, 0x72, 0x13,
+ 0x5b,