Re: [Kicad-developers] Serious Lib cache issue, and fix in commit 2974a2c10
On 4/16/2018 9:25 AM, Maciej Sumiński wrote: > Hi Wayne, > > I see, but I wonder if there is any benefit in making the colon > exception just for rescue/cache libraries? I suppose it makes them > special in the sense they cannot be used as regular libraries due to > illegal character in symbol names. Using a colon does have the side effect of not being able to directly copy and rename the cache library file as a normal library file and add it to the symbol library table. This should no longer be necessary because I fixed a bug in the rescuer that would not rescue symbols from the cache when they no longer can be found in the library list prior the symbol library table and have been removed or renamed after the symbol library table implementation. > > As I said, I am not familiar with caching/rescue code, but I imagine > that once eeschema finds "LibraryName:SymbolName" missing, it could > search for "LibraryName_SymbolName" in rescue/cache libraries. I do not > insist on a change, just taking an opportunity to learn about caching > mechanism. That is a possible solution if we want to make the cache library relocatable as a normal library and I'm not opposed to this. > > Cheers, > Orson > > On 04/16/2018 03:08 PM, Wayne Stambaugh wrote: >> Hey Orson, >> >> The colons are required to prevent symbol name clashes in the cache >> library. I had to prefix the library nickname to the symbol name to >> prevent symbols from being overwritten when they exist in more than on >> library. In other words, cache library symbol names look just like >> LIB_IDs using the LIB_NICKNAME:SYMBOL_NAME format. >> >> Cheers, >> >> Wayne >> >> On 4/16/2018 9:03 AM, Maciej Sumiński wrote: >>> Hi Jean-Pierre, >>> >>> I understand the patch and thank you for the fix, but apparently I do >>> not have enough knowledge about caching in eeschema to comment on the >>> approach. Frankly, I was a bit surprised to find out that colons are >>> permitted in symbol names stored in a cache library. >>> >>> Regards, >>> Orson >>> >>> On 04/16/2018 11:06 AM, jp charras wrote: Hi Wayne and Orson, Could you have a look into the fix I committed in rev 2974a2c10. Before this fix, the library cache was broken (all symbol names incorrectly saved). This is specific to the cache, but really annoying... Please, see comments in commit 2974a2c10. But I am not sure this is the best way to fix this issue. Thanks. >>> >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Serious Lib cache issue, and fix in commit 2974a2c10
Hi Wayne, I see, but I wonder if there is any benefit in making the colon exception just for rescue/cache libraries? I suppose it makes them special in the sense they cannot be used as regular libraries due to illegal character in symbol names. As I said, I am not familiar with caching/rescue code, but I imagine that once eeschema finds "LibraryName:SymbolName" missing, it could search for "LibraryName_SymbolName" in rescue/cache libraries. I do not insist on a change, just taking an opportunity to learn about caching mechanism. Cheers, Orson On 04/16/2018 03:08 PM, Wayne Stambaugh wrote: > Hey Orson, > > The colons are required to prevent symbol name clashes in the cache > library. I had to prefix the library nickname to the symbol name to > prevent symbols from being overwritten when they exist in more than on > library. In other words, cache library symbol names look just like > LIB_IDs using the LIB_NICKNAME:SYMBOL_NAME format. > > Cheers, > > Wayne > > On 4/16/2018 9:03 AM, Maciej Sumiński wrote: >> Hi Jean-Pierre, >> >> I understand the patch and thank you for the fix, but apparently I do >> not have enough knowledge about caching in eeschema to comment on the >> approach. Frankly, I was a bit surprised to find out that colons are >> permitted in symbol names stored in a cache library. >> >> Regards, >> Orson >> >> On 04/16/2018 11:06 AM, jp charras wrote: >>> Hi Wayne and Orson, >>> >>> Could you have a look into the fix I committed in rev 2974a2c10. >>> Before this fix, the library cache was broken (all symbol names incorrectly >>> saved). >>> This is specific to the cache, but really annoying... >>> >>> Please, see comments in commit 2974a2c10. >>> >>> But I am not sure this is the best way to fix this issue. >>> >>> Thanks. >>> >> >> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Serious Lib cache issue, and fix in commit 2974a2c10
Hey Orson, The colons are required to prevent symbol name clashes in the cache library. I had to prefix the library nickname to the symbol name to prevent symbols from being overwritten when they exist in more than on library. In other words, cache library symbol names look just like LIB_IDs using the LIB_NICKNAME:SYMBOL_NAME format. Cheers, Wayne On 4/16/2018 9:03 AM, Maciej Sumiński wrote: > Hi Jean-Pierre, > > I understand the patch and thank you for the fix, but apparently I do > not have enough knowledge about caching in eeschema to comment on the > approach. Frankly, I was a bit surprised to find out that colons are > permitted in symbol names stored in a cache library. > > Regards, > Orson > > On 04/16/2018 11:06 AM, jp charras wrote: >> Hi Wayne and Orson, >> >> Could you have a look into the fix I committed in rev 2974a2c10. >> Before this fix, the library cache was broken (all symbol names incorrectly >> saved). >> This is specific to the cache, but really annoying... >> >> Please, see comments in commit 2974a2c10. >> >> But I am not sure this is the best way to fix this issue. >> >> Thanks. >> > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Serious Lib cache issue, and fix in commit 2974a2c10
Hi Jean-Pierre, I understand the patch and thank you for the fix, but apparently I do not have enough knowledge about caching in eeschema to comment on the approach. Frankly, I was a bit surprised to find out that colons are permitted in symbol names stored in a cache library. Regards, Orson On 04/16/2018 11:06 AM, jp charras wrote: > Hi Wayne and Orson, > > Could you have a look into the fix I committed in rev 2974a2c10. > Before this fix, the library cache was broken (all symbol names incorrectly > saved). > This is specific to the cache, but really annoying... > > Please, see comments in commit 2974a2c10. > > But I am not sure this is the best way to fix this issue. > > Thanks. > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Serious Lib cache issue, and fix in commit 2974a2c10
Hi Wayne and Orson, Could you have a look into the fix I committed in rev 2974a2c10. Before this fix, the library cache was broken (all symbol names incorrectly saved). This is specific to the cache, but really annoying... Please, see comments in commit 2974a2c10. But I am not sure this is the best way to fix this issue. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
