Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Nick Østergaard]

I just tried to test this on windows, but with your patch applied it
does not seem to find the wizards...


I have them in %PROGRAMFILES%\KiCad\share\kicad\scripting\plugins

And run pcbnew directly from the bin dir. KiCad can find the wizards
just fine before your patch.

2016-09-18 16:26 GMT+02:00 Nick Østergaard :
> Hi Oliver
>
> The new checkbox works better i think. But thre is still some jumping
> around with it when it sort of "selected" by the cursor. Also it shows
> that small dashed box where there is usallly text for a checkbox it
> seems.
>
> This is on linux, I don't know if the same is seen on other platforms.
>
> 2016-09-15 14:55 GMT+02:00 Oliver Walters :
>> Ok, round two!
>>
>> 1. I have fixed the issue relating to comma-separated decimals.
>>
>> 2. Boolean values now use the wxGridCellBoolRenderer which means they always
>> display as checkboxes
>>
>> Here is an example of the boolean values rendering ->
>> http://oi65.tinypic.com/24pmp9d.jpg
>>
>> And an example of the multiple-choice parameter ->
>> http://oi67.tinypic.com/xkrvw5.jpg
>>
>> Finally, a screenshot of available parameter types ->
>> http://oi63.tinypic.com/2lne6gh.jpg
>>
>> I have attached the updated patch.
>>
>> LMK if there's anything else I need to do :)
>>
>> On Wed, Sep 14, 2016 at 10:09 PM, Oliver Walters
>>  wrote:
>>>
>>> Hi all,
>>>
>>> First time submitting a patch, so here goes
>>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Nick Østergaard]

Hi Oliver

The new checkbox works better i think. But thre is still some jumping
around with it when it sort of "selected" by the cursor. Also it shows
that small dashed box where there is usallly text for a checkbox it
seems.

This is on linux, I don't know if the same is seen on other platforms.

2016-09-15 14:55 GMT+02:00 Oliver Walters :
> Ok, round two!
>
> 1. I have fixed the issue relating to comma-separated decimals.
>
> 2. Boolean values now use the wxGridCellBoolRenderer which means they always
> display as checkboxes
>
> Here is an example of the boolean values rendering ->
> http://oi65.tinypic.com/24pmp9d.jpg
>
> And an example of the multiple-choice parameter ->
> http://oi67.tinypic.com/xkrvw5.jpg
>
> Finally, a screenshot of available parameter types ->
> http://oi63.tinypic.com/2lne6gh.jpg
>
> I have attached the updated patch.
>
> LMK if there's anything else I need to do :)
>
> On Wed, Sep 14, 2016 at 10:09 PM, Oliver Walters
>  wrote:
>>
>> Hi all,
>>
>> First time submitting a patch, so here goes
>>
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[jp charras]

Le 15/09/2016 à 14:55, Oliver Walters a écrit :
> Ok, round two!
> 
> 1. I have fixed the issue relating to comma-separated decimals.
> 
> 2. Boolean values now use the wxGridCellBoolRenderer which means they always 
> display as checkboxes
> 
> Here is an example of the boolean values rendering -> 
> http://oi65.tinypic.com/24pmp9d.jpg
> 
> And an example of the multiple-choice parameter -> 
> http://oi67.tinypic.com/xkrvw5.jpg
> 
> Finally, a screenshot of available parameter types -> 
> http://oi63.tinypic.com/2lne6gh.jpg
> 
> I have attached the updated patch. 
> 
> LMK if there's anything else I need to do :)
> 

Works fine for me now. Thanks.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[jp charras]

Le 15/09/2016 à 13:32, Oliver Walters a écrit :
> JP, I think I have worked it out!
>  
> 
> Unfortunately, it does not work in countries which use a comma as 
> floating point separator:
> I cannot enter floating point values:
> 
> The validator expects a comma as floating point separator, and the python 
> script expects a point as
> separator.
> 
> 
> The python script now strips out commas and replaces them with periods. When 
> the KiCad function
> reads the values back in, it replaces all commas or periods (for numeric 
> values only)
> with wxNumberFormatter::GetDecimalSeparator()
> 
> I have tested this by switching my locale settings to use commas and it seems 
> to work well.


Thanks!

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Oliver Walters]

JP, I think I have worked it out!


> Unfortunately, it does not work in countries which use a comma as floating
> point separator:
> I cannot enter floating point values:
>
> The validator expects a comma as floating point separator, and the python
> script expects a point as
> separator.


The python script now strips out commas and replaces them with periods.
When the KiCad function reads the values back in, it replaces all commas or
periods (for numeric values only)
with wxNumberFormatter::GetDecimalSeparator()

I have tested this by switching my locale settings to use commas and it
seems to work well.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Oliver Walters]

Yep, understood. The new footprint wizard script doesn't actually change
the string values that are sent in from KiCad so it sends back identical
values.

On Thu, Sep 15, 2016 at 6:49 PM, Simon Wells  wrote:

> the problem is what happens if/when it needs to convert back into a
> string, it needs to know whether to show a comma or period
>
> On Thu, Sep 15, 2016 at 8:25 PM, Oliver Walters
>  wrote:
> > I'm not 100% that I understand the issue, but here is my proposed fix:
> >
> > Allow "native" separators in KiCad (comma or period) and when the Python
> > script converts these string values to numbers it will automatically
> turn a
> > comma into a period.
> >
> > On Thu, Sep 15, 2016 at 4:58 PM, jp charras 
> wrote:
> >>
> >> This is a language setting.
> >> It could be no so easy to test, if the system language uses the same
> >> separator as the "C" language
> >>
> >> The easy fix is do not use the wxWidgets floating point validator (no
> >> validator).
> >> The user must enter fp numbers using the "C" locale separator (the
> point).
> >> The best fix is more complicated, and imply :
> >> - Use the selected language (usually the system language, but not
> always)
> >> fp separator to display fp
> >> number in dialog (this is not currently the case: currently this is the
> >> "C" locale separator, used
> >> by the Python script)
> >> - In countries which use an other separator (a comma), allow both the
> >> current locale separator *and*
> >> the "C" locale separator.
> >>
> >> This issue is well known in Kicad.
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Simon Wells]

the problem is what happens if/when it needs to convert back into a
string, it needs to know whether to show a comma or period

On Thu, Sep 15, 2016 at 8:25 PM, Oliver Walters
 wrote:
> I'm not 100% that I understand the issue, but here is my proposed fix:
>
> Allow "native" separators in KiCad (comma or period) and when the Python
> script converts these string values to numbers it will automatically turn a
> comma into a period.
>
> On Thu, Sep 15, 2016 at 4:58 PM, jp charras  wrote:
>>
>> This is a language setting.
>> It could be no so easy to test, if the system language uses the same
>> separator as the "C" language
>>
>> The easy fix is do not use the wxWidgets floating point validator (no
>> validator).
>> The user must enter fp numbers using the "C" locale separator (the point).
>> The best fix is more complicated, and imply :
>> - Use the selected language (usually the system language, but not always)
>> fp separator to display fp
>> number in dialog (this is not currently the case: currently this is the
>> "C" locale separator, used
>> by the Python script)
>> - In countries which use an other separator (a comma), allow both the
>> current locale separator *and*
>> the "C" locale separator.
>>
>> This issue is well known in Kicad.
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Oliver Walters]

I'm not 100% that I understand the issue, but here is my proposed fix:

Allow "native" separators in KiCad (comma or period) and when the Python
script converts these string values to numbers it will automatically turn a
comma into a period.

On Thu, Sep 15, 2016 at 4:58 PM, jp charras  wrote:
>
> This is a language setting.
> It could be no so easy to test, if the system language uses the same
> separator as the "C" language

The easy fix is do not use the wxWidgets floating point validator (no
> validator).
> The user must enter fp numbers using the "C" locale separator (the point).
> The best fix is more complicated, and imply :
> - Use the selected language (usually the system language, but not always)
> fp separator to display fp
> number in dialog (this is not currently the case: currently this is the
> "C" locale separator, used
> by the Python script)
> - In countries which use an other separator (a comma), allow both the
> current locale separator *and*
> the "C" locale separator.
>
> This issue is well known in Kicad.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[jp charras]

Le 15/09/2016 à 00:16, Oliver Walters a écrit :
> JP,
> 
> Ok, that should be a pretty easy fix. For testing on my side, how do I get 
> KiCad to use a comma for
> floating point separator? Is this a language setting?

This is a language setting.
It could be no so easy to test, if the system language uses the same separator 
as the "C" language.

The easy fix is do not use the wxWidgets floating point validator (no 
validator).
The user must enter fp numbers using the "C" locale separator (the point).

The best fix is more complicated, and imply :
- Use the selected language (usually the system language, but not always) fp 
separator to display fp
number in dialog (this is not currently the case: currently this is the "C" 
locale separator, used
by the Python script)
- In countries which use an other separator (a comma), allow both the current 
locale separator *and*
the "C" locale separator.

This issue is well known in Kicad.

> 
> On Thu, Sep 15, 2016 at 1:56 AM, jp charras  >
> wrote:
> 
> Le 14/09/2016 à 14:09, Oliver Walters a écrit :
> > Hi all,
> >
> > First time submitting a patch, so here goes
> >
> > The attached patch deals with a number of issues with regards to the 
> footprint wizards manager. It
> > started off as what I imagined was a fairly simple task to improve the 
> UX of the FP wizards
> > interface, but it evolved into something a bit more complex as I delved 
> deeper into the source!
> >
> > Improvements are as follows:
> >
> > 1. I have done away with the use of a leading asterisk to designate the 
> "units" of a wizard
> > parameter. Multiple parameter types can now be defined (integer, float, 
> mm, mils, bool, etc..)
> >
> > 2. Input validation. Each type of parameter is now validated properly 
> within the wizards screen.
> > Integer parameters can only be set to integers, dimensions can only be 
> floating point, etc.
> 
> Unfortunately, it does not work in countries which use a comma as 
> floating point separator:
> I cannot enter floating point values:
> 
> The validator expects a comma as floating point separator, and the python 
> script expects a point as
> separator.
> 
> >


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Niki Guldbrand]

On tor, 2016-09-15 at 08:20 +1000, Oliver Walters wrote:
> > Patches that can be applied with git am is good. In this case it
> > seems
> > like all newlines in commit comments are stripped which is not so
> > good.
> 
> Any suggestions on how I could fix this? Should I be submitting one
> patch per commit, or a single patch as I have done here? Also, can I
> submit a pull-request straight from git or is the patch-email method
> preferred? 

Normally how I format commit messages is like this:

Short description

 * More detailed description
   May span multiple lines
 * Some times there is a need for multiple detailes descriptions


See the short description as the subject line in an email.


-- 
Niki Guldbrand 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Oliver Walters]

On Thu, Sep 15, 2016 at 6:19 AM, Nick Østergaard  wrote:

> 2016-09-14 14:09 GMT+02:00 Oliver Walters  >:
> > Hi all,
> >
> > First time submitting a patch, so here goes
> >
>
> Welcome. Please be aware that your patches contain tabs, as per the
> coding style policy; the indentation level for the KiCad source code
> is defined as four spaces. Please do not use tabs.


Ok, will fix.


>
> > The attached patch deals with a number of issues with regards to the
> > footprint wizards manager. It started off as what I imagined was a fairly
> > simple task to improve the UX of the FP wizards interface, but it evolved
> > into something a bit more complex as I delved deeper into the source!
> >
>
> Lovely to see some improments. I think there are great improvements in
> here and I have tried to add some more comments inline.
>
> > Improvements are as follows:
> >
> > 1. I have done away with the use of a leading asterisk to designate the
> > "units" of a wizard parameter. Multiple parameter types can now be
> defined
> > (integer, float, mm, mils, bool, etc..)
> >
> > 2. Input validation. Each type of parameter is now validated properly
> within
> > the wizards screen. Integer parameters can only be set to integers,
> > dimensions can only be floating point, etc.
> >
> > 3. Boolean values are now treated properly. Simply click the cell to
> toggle,
> > rather than awkwardly typing "True" or "False"
> >
>
> I this this works a bit strange right now because it switches between
> showing the True/False text, but when clicking it will show the
> checkbox. Why this switching between content?
>
> To make it easer than manually typing true or false as before I would
> have expected either a combobox or a checkbox that is constantly
> there.


It looks like using a wxGridCellBoolRenderer will fix this. I'll look into
this.


> > 4. Multiple choice options available - If the python script specifies a
> list
> > of options, then a drop-down box will be displayed for that parameter
> >
>
> Is there an example script that uses lists? I could not find any of
> the default wizards proviing this option.


I'll add an example script.


>
> > 5. Param designators. Instead of the row numbers being shown, each param
> can
> > optionally be assigned a designator (such as 'e' for pitch) which will be
> > show to the left of that row.
> >
>
> I think this makes sense.
>
> It would be cool if we in the future could render dimension arrows on
> the plot for some things using those references.
>

That is a very cool idea. I had been planning on implementing the
GetImage() method which would require a dimensional drawing for each
wizard. However, with the ability to draw on the screen, you could easily
show the dimensions only for the current page of parameters, which would
de-clutter it a lot. I'm not sure how much work this would be, though.


>
> > 6. "Reset to default" - A new button in the top toolbar which resets all
> > wizard parameters to their default values
> >
> >
> > 7. More logical parameter checking within the python wizard helpers.
> > Currently each parameter needs to be explicitly checked e.g. "CheckInt"
> to
> > make sure the value is a valid integer. This patch defines a Parameter
> > holder class that automatically checks values based on their specified
> type.
> > Additionally, parameters can have other checks specified when they are
> > added, e.g:
> >
> > AddParam("Pads","width",uMM, 2.5, min_value=0.1, max_value=5.5)
> >
> > 8. Fixed script import errors in the case of "bad" scripts. Currently if
> a
> > wizard contains any errors, the LoadPlugins functions fail and no
> subsequent
> > wizards are loaded. A simple try-except block has been added around the
> > specific file loading so that one bad plugin file does not break the
> others
> >
> > 9. Auto-sizing of the parameter grid. Not a huge deal but the grid width
> now
> > expands to fill the available space.
> >
> > General Notes:
> >
> > a) To provide the functionality for multiple unit types I have had to
> > slightly break compatibility with the way that parameter types were
> defined
> > in the current wizards. However, I have designed the new Parameter class
> (in
> > kicadplugins.i) to be as close-to-compatible as it can be.
> >
>
> Maybe some notes are required on how to update the older scripts to
> ease a transition.
>
> > I have updated each of the default plugins to be compatible with the new
> > system. Only minor changes were required.
> >
> > b) I have also consolidated the helper classes
> > (HelpfulFootprintWizardPlugin) into the simpler FootprintWizard base
> class.
> >
> > c) There is now a GitHub repository for FootprintWizards -
> > https://github.com/KiCad/Footprint_Wizards - should this patch be
> accepted I
> > propose that the default wizards be further improved, and removed from
> the
> > source files. Instead, provide a link to the GitHub page or a
> > download-helper for the 

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[Nick Østergaard]

2016-09-14 14:09 GMT+02:00 Oliver Walters :
> Hi all,
>
> First time submitting a patch, so here goes
>

Welcome. Please be aware that your patches contain tabs, as per the
coding style policy; the indentation level for the KiCad source code
is defined as four spaces. Please do not use tabs.

> The attached patch deals with a number of issues with regards to the
> footprint wizards manager. It started off as what I imagined was a fairly
> simple task to improve the UX of the FP wizards interface, but it evolved
> into something a bit more complex as I delved deeper into the source!
>

Lovely to see some improments. I think there are great improvements in
here and I have tried to add some more comments inline.

> Improvements are as follows:
>
> 1. I have done away with the use of a leading asterisk to designate the
> "units" of a wizard parameter. Multiple parameter types can now be defined
> (integer, float, mm, mils, bool, etc..)
>
> 2. Input validation. Each type of parameter is now validated properly within
> the wizards screen. Integer parameters can only be set to integers,
> dimensions can only be floating point, etc.
>
> 3. Boolean values are now treated properly. Simply click the cell to toggle,
> rather than awkwardly typing "True" or "False"
>

I this this works a bit strange right now because it switches between
showing the True/False text, but when clicking it will show the
checkbox. Why this switching between content?

To make it easer than manually typing true or false as before I would
have expected either a combobox or a checkbox that is constantly
there.

> 4. Multiple choice options available - If the python script specifies a list
> of options, then a drop-down box will be displayed for that parameter
>

Is there an example script that uses lists? I could not find any of
the default wizards proviing this option.

> 5. Param designators. Instead of the row numbers being shown, each param can
> optionally be assigned a designator (such as 'e' for pitch) which will be
> show to the left of that row.
>

I think this makes sense.

It would be cool if we in the future could render dimension arrows on
the plot for some things using those references.

> 6. "Reset to default" - A new button in the top toolbar which resets all
> wizard parameters to their default values
>
>
> 7. More logical parameter checking within the python wizard helpers.
> Currently each parameter needs to be explicitly checked e.g. "CheckInt" to
> make sure the value is a valid integer. This patch defines a Parameter
> holder class that automatically checks values based on their specified type.
> Additionally, parameters can have other checks specified when they are
> added, e.g:
>
> AddParam("Pads","width",uMM, 2.5, min_value=0.1, max_value=5.5)
>
> 8. Fixed script import errors in the case of "bad" scripts. Currently if a
> wizard contains any errors, the LoadPlugins functions fail and no subsequent
> wizards are loaded. A simple try-except block has been added around the
> specific file loading so that one bad plugin file does not break the others
>
> 9. Auto-sizing of the parameter grid. Not a huge deal but the grid width now
> expands to fill the available space.
>
> General Notes:
>
> a) To provide the functionality for multiple unit types I have had to
> slightly break compatibility with the way that parameter types were defined
> in the current wizards. However, I have designed the new Parameter class (in
> kicadplugins.i) to be as close-to-compatible as it can be.
>

Maybe some notes are required on how to update the older scripts to
ease a transition.

> I have updated each of the default plugins to be compatible with the new
> system. Only minor changes were required.
>
> b) I have also consolidated the helper classes
> (HelpfulFootprintWizardPlugin) into the simpler FootprintWizard base class.
>
> c) There is now a GitHub repository for FootprintWizards -
> https://github.com/KiCad/Footprint_Wizards - should this patch be accepted I
> propose that the default wizards be further improved, and removed from the
> source files. Instead, provide a link to the GitHub page or a
> download-helper for the scripts. This way the community can contribute
> quality wizards, and I shall endeavour to add some good documentation to the
> wiki page for wizard creation.
>
> .diff is attached - hopefully this is the right way of doing this?
>

Patches that can be applied with git am is good. In this case it seems
like all newlines in commit comments are stripped which is not so
good.

I wonder why you make a construct like this in 0001.
#if defined( __MINGW32__ )
path = A
#elif defined( __WXMAC__ )
path = B
#else
path = A
#endif

Why not like this?
#if defined( __WXMAC__ )
path = B
#else
path = A
#endif

> Please let me know what I can do to help this process along.
>
> Regards,
>
> Oliver
>
>
> ___
> Mailing list: 

Re: [Kicad-developers] [PATCH][RFC] Footprint wizards

[jp charras]

Le 14/09/2016 à 14:09, Oliver Walters a écrit :
> Hi all,
> 
> First time submitting a patch, so here goes
> 
> The attached patch deals with a number of issues with regards to the 
> footprint wizards manager. It
> started off as what I imagined was a fairly simple task to improve the UX of 
> the FP wizards
> interface, but it evolved into something a bit more complex as I delved 
> deeper into the source!
> 
> Improvements are as follows:
> 
> 1. I have done away with the use of a leading asterisk to designate the 
> "units" of a wizard
> parameter. Multiple parameter types can now be defined (integer, float, mm, 
> mils, bool, etc..)
> 
> 2. Input validation. Each type of parameter is now validated properly within 
> the wizards screen.
> Integer parameters can only be set to integers, dimensions can only be 
> floating point, etc.

Unfortunately, it does not work in countries which use a comma as floating 
point separator:
I cannot enter floating point values:

The validator expects a comma as floating point separator, and the python 
script expects a point as
separator.

> 
> 3. Boolean values are now treated properly. Simply click the cell to toggle, 
> rather than awkwardly
> typing "True" or "False"
> 
> 4. Multiple choice options available - If the python script specifies a list 
> of options, then a
> drop-down box will be displayed for that parameter
> 
> 5. Param designators. Instead of the row numbers being shown, each param can 
> optionally be assigned
> a designator (such as 'e' for pitch) which will be show to the left of that 
> row.
> 
> 6. "Reset to default" - A new button in the top toolbar which resets all 
> wizard parameters to their
> default values
> 
> 7. More logical parameter checking within the python wizard helpers. 
> Currently each parameter needs
> to be explicitly checked e.g. "CheckInt" to make sure the value is a valid 
> integer. This patch
> defines a Parameter holder class that automatically checks values based on 
> their specified type.
> Additionally, parameters can have other checks specified when they are added, 
> e.g:
> 
> AddParam("Pads","width",uMM, 2.5, min_value=0.1, max_value=5.5)
> 
> 8. Fixed script import errors in the case of "bad" scripts. Currently if a 
> wizard contains any
> errors, the LoadPlugins functions fail and no subsequent wizards are loaded. 
> A simple try-except
> block has been added around the specific file loading so that one bad plugin 
> file does not break the
> others
> 
> 9. Auto-sizing of the parameter grid. Not a huge deal but the grid width now 
> expands to fill the
> available space.
> 
> General Notes:
> 
> a) To provide the functionality for multiple unit types I have had to 
> slightly break compatibility
> with the way that parameter types were defined in the current wizards. 
> However, I have designed the
> new Parameter class (in kicadplugins.i) to be as close-to-compatible as it 
> can be. 
> 
> I have updated each of the default plugins to be compatible with the new 
> system. Only minor changes
> were required.
> 
> b) I have also consolidated the helper classes (HelpfulFootprintWizardPlugin) 
> into the simpler
> FootprintWizard base class. 
> 
> c) There is now a GitHub repository for FootprintWizards
> - https://github.com/KiCad/Footprint_Wizards - should this patch be accepted 
> I propose that the
> default wizards be further improved, and removed from the source files. 
> Instead, provide a link to
> the GitHub page or a download-helper for the scripts. This way the community 
> can contribute quality
> wizards, and I shall endeavour to add some good documentation to the wiki 
> page for wizard creation.
> 
> .diff is attached - hopefully this is the right way of doing this?
> 
> Please let me know what I can do to help this process along.
> 
> Regards,
> 
> Oliver

Thanks for your contribution.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp