Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-14 Thread Wayne Stambaugh 
I'm just wondering if this will make typed in unit support more obvious
or if it will lead to more confusion.  I guess we could try it and see
what happens.

On 3/14/2018 11:19 AM, Jeff Young wrote:
> Hi Wayne,
> 
> The units would still be displayed, just in the box instead of out of it.  We 
> already do this for some grids (for instance Edit > Edit All Tracks and Vias).
> 
> Cheers,
> Jeff
> 
> 
>> On 14 Mar 2018, at 13:59, Wayne Stambaugh  wrote:
>>
>> On 3/13/2018 5:58 AM, Jeff Young wrote:
>>> There’s a wishlish item to make support for typed-in units more 
>>> discoverable.
>>>
>>> I think the easiest way to do this is to adopt a policy of removing unit 
>>> static-texts following a value textCtrl in favour of displaying the current 
>>> units in the text.
>>
>> I can't imagine this not leading to a bug report.  While I agree the
>> units static text doesn't help to make typed-in units support more
>> obvious, I don't really see how it hurts either.  At least the user has
>> an indication of the current units.  Maybe a fancy wxRichTooltip[1]
>> would be a decent solution to let users know about typed in unit support.
>>
>>>
>>> If the user clicks into the control and types only a number, we’ll assume 
>>> current units and display them with the value when the textCtrl loses focus.
>>>
>>> We already have all the code to support this.  I can clean up existing 
>>> dialogs when I fix them for the eradication of g_UserUnit.
>>>
>>> Thoughts?
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-14 Thread Jeff Young 
Hi Wayne,

The units would still be displayed, just in the box instead of out of it.  We 
already do this for some grids (for instance Edit > Edit All Tracks and Vias).

Cheers,
Jeff


> On 14 Mar 2018, at 13:59, Wayne Stambaugh  wrote:
> 
> On 3/13/2018 5:58 AM, Jeff Young wrote:
>> There’s a wishlish item to make support for typed-in units more discoverable.
>> 
>> I think the easiest way to do this is to adopt a policy of removing unit 
>> static-texts following a value textCtrl in favour of displaying the current 
>> units in the text.
> 
> I can't imagine this not leading to a bug report.  While I agree the
> units static text doesn't help to make typed-in units support more
> obvious, I don't really see how it hurts either.  At least the user has
> an indication of the current units.  Maybe a fancy wxRichTooltip[1]
> would be a decent solution to let users know about typed in unit support.
> 
>> 
>> If the user clicks into the control and types only a number, we’ll assume 
>> current units and display them with the value when the textCtrl loses focus.
>> 
>> We already have all the code to support this.  I can clean up existing 
>> dialogs when I fix them for the eradication of g_UserUnit.
>> 
>> Thoughts?
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-14 Thread Wayne Stambaugh 
On 3/13/2018 5:58 AM, Jeff Young wrote:
> There’s a wishlish item to make support for typed-in units more discoverable.
> 
> I think the easiest way to do this is to adopt a policy of removing unit 
> static-texts following a value textCtrl in favour of displaying the current 
> units in the text.

I can't imagine this not leading to a bug report.  While I agree the
units static text doesn't help to make typed-in units support more
obvious, I don't really see how it hurts either.  At least the user has
an indication of the current units.  Maybe a fancy wxRichTooltip[1]
would be a decent solution to let users know about typed in unit support.

> 
> If the user clicks into the control and types only a number, we’ll assume 
> current units and display them with the value when the textCtrl loses focus.
> 
> We already have all the code to support this.  I can clean up existing 
> dialogs when I fix them for the eradication of g_UserUnit.
> 
> Thoughts?
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-13 Thread Seth Hillbrand 
Thanks!

Chris, your example link is dead but I'll use my imagination here.

1) I like the idea of making it more obvious.  For 5, could we just add a
tooltip?

2) I think that the extra step of only selecting the number is extraneous.
Since we default to the document units, it doesn't matter if the user
removes the units when typing.

3) Long term, I like the way SolidWorks handles this issue (see attached).
When there are no units in the box, it adds a drop-down underneath that
shows which units it accepts.  When there are valid units, the box is not
shown.  When there are invalid units the text color changes.  Right now, we
simply ignore units that are mistyped or that we don't know.

-S


2018-03-13 9:18 GMT-07:00 Jeff Young :

> Hi Seth,
>
> https://bugs.launchpad.net/kicad/+bug/1660156
>
> Cheers,
> Jeff.
>
>
> On 13 Mar 2018, at 15:39, Seth Hillbrand  wrote:
>
> Hi Jeff-
>
> I can't find which bug report this can you send the link?  I'm not sure
> that I follow what the issue is and I'd like to understand the problem it's
> addressing.
>
> Thanks!
> -S
>
> 2018-03-13 2:58 GMT-07:00 Jeff Young :
>
>> There’s a wishlish item to make support for typed-in units more
>> discoverable.
>>
>> I think the easiest way to do this is to adopt a policy of removing unit
>> static-texts following a value textCtrl in favour of displaying the current
>> units in the text.
>>
>> If the user clicks into the control and types only a number, we’ll assume
>> current units and display them with the value when the textCtrl loses focus.
>>
>> We already have all the code to support this.  I can clean up existing
>> dialogs when I fix them for the eradication of g_UserUnit.
>>
>> Thoughts?
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-13 Thread Jeff Young 
Hi Seth,

https://bugs.launchpad.net/kicad/+bug/1660156 


Cheers,
Jeff.


> On 13 Mar 2018, at 15:39, Seth Hillbrand  wrote:
> 
> Hi Jeff-
> 
> I can't find which bug report this can you send the link?  I'm not sure that 
> I follow what the issue is and I'd like to understand the problem it's 
> addressing.
> 
> Thanks!
> -S
> 
> 2018-03-13 2:58 GMT-07:00 Jeff Young >:
> There’s a wishlish item to make support for typed-in units more discoverable.
> 
> I think the easiest way to do this is to adopt a policy of removing unit 
> static-texts following a value textCtrl in favour of displaying the current 
> units in the text.
> 
> If the user clicks into the control and types only a number, we’ll assume 
> current units and display them with the value when the textCtrl loses focus.
> 
> We already have all the code to support this.  I can clean up existing 
> dialogs when I fix them for the eradication of g_UserUnit.
> 
> Thoughts?
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Making typed-in unit support more obvious

2018-03-13 Thread Seth Hillbrand 
Hi Jeff-

I can't find which bug report this can you send the link?  I'm not sure
that I follow what the issue is and I'd like to understand the problem it's
addressing.

Thanks!
-S

2018-03-13 2:58 GMT-07:00 Jeff Young :

> There’s a wishlish item to make support for typed-in units more
> discoverable.
>
> I think the easiest way to do this is to adopt a policy of removing unit
> static-texts following a value textCtrl in favour of displaying the current
> units in the text.
>
> If the user clicks into the control and types only a number, we’ll assume
> current units and display them with the value when the textCtrl loses focus.
>
> We already have all the code to support this.  I can clean up existing
> dialogs when I fix them for the eradication of g_UserUnit.
>
> Thoughts?
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp