[Koha-bugs] [Bug 7695] New: Boolean operator AND in XSLT gets translated

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7695

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7695
  Assignee: frede...@tamil.fr
   Summary: Boolean operator AND in XSLT gets translated
QA Contact: koha.sek...@gmail.com
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: mag...@enger.priv.no
  Hardware: All
Status: NEW
   Version: master
 Component: I18N/L10N
   Product: Koha

* Problem

In koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl (and the
corresponding XSLT for the intranet) this:

476xsl:with-param name=delimeter and /xsl:with-param

gets translated into this, for nb-NO: 

476xsl:with-param name=delimeter og /xsl:with-param

(og being Norwegian for and), resulting in searches like this, when
TraceSubjectSubdivisions is set to include: 

(su,complete-subfield:USA ) og (su,complete-subfield:Borgerkrigen,
1861-1865)

Zebra does not know how to handle og as a boolean operator, of course,
resulting in zero hits. 

In the OPAC this can currently be avoided by not translating the string and ,
since this is the only occurrence of that string (but there is one occurrence
of and), but in the intranet there are three occurrences of and , and only
one of them is a boolean operator, so you can't just not translate the one
place where it is. 

* One possible solution

Since the translation process is case sensitive, but Zebra is not, it might be
a way out to change and into AND in the line above, to make it stand out
from the cases where and occurs as a regular word. Then we would just have
to remember not to translate AND, but just copy it over. 

Does anyone have a better idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Severity|enhancement |blocker

--- Comment #78 from Ian Walls koha.sek...@gmail.com ---
De-nesting C4::Items has resulted in bulkmarcimport.pl throwing the error: 

ERROR: Adding items to bib 1 failed: Undefined subroutine
C4::Items::GetBranchName called at /home/sekjal/kohaclone/C4/Items.pm line
656, GEN13 line 435.

GetBranchName is not scoped properly.  Adding the C4::Branch:: prefix will fix
this.  Patch forthcoming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

--- Comment #79 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8133action=edit
Bug 6875 Followup:  De-nesting C4::Items breaks bulkmarcimport

Removing 'use C4::Branch' in favour of a subroutine-specific 'require
C4::Branch'
causes the GetBranchName subroutine to return an error, as it's not defined
in C4::Items.  Adding C4::Branch:: scoping fixes the error, which is what's
done here.

To confirm problem:
1.  Attempt to run bulkmarcimport.pl before applying the patch.  You should get
ERROR: Adding items to bib 435 failed: Undefined subroutine
C4::Items::GetBranchName
called at /home/sekjal/kohaclone/C4/Items.pm line 656, GEN13 line 435.

To test:
2.  apply patch
3.  run bulkmarcimport again.  Error should disappear.

Signed-off-by: Ian Walls koha.sek...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

--- Comment #80 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8134
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8134action=edit
Bug 6875 Followup: De-nesting C4::Items breaks bulkmarcimport

Removing 'use C4::Branch' in favour of a subroutine-specific 'require
C4::Branch'
causes the GetBranchName subroutine to return an error, as it's not defined
in C4::Items.  Adding C4::Branch:: scoping fixes the error, which is what's
done here.

To confirm problem:
1.  Attempt to run bulkmarcimport.pl before applying the patch.  You should get
ERROR: Adding items to bib 435 failed: Undefined subroutine
C4::Items::GetBranchName
called at /home/sekjal/kohaclone/C4/Items.pm line 656, GEN13 line 435.

To test:
2.  apply patch
3.  run bulkmarcimport again.  Error should disappear.

Signed-off-by: Ian Walls koha.sek...@gmail.com
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Note that this problem only appears when importing records with item (952)
fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

--- Comment #81 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8135
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8135action=edit
Bug 6875 Followup: De-nesting C4::Items breaks bulkmarcimport

Removing 'use C4::Branch' in favour of a subroutine-specific 'require
C4::Branch'
causes the GetBranchName subroutine to return an error, as it's not defined
in C4::Items.  Adding C4::Branch:: scoping fixes the error, which is what's
done here.

To confirm problem:
1.  Attempt to run bulkmarcimport.pl before applying the patch.  You should get
ERROR: Adding items to bib 435 failed: Undefined subroutine
C4::Items::GetBranchName
called at /home/sekjal/kohaclone/C4/Items.pm line 656, GEN13 line 435.

To test:
2.  apply patch
3.  run bulkmarcimport again.  Error should disappear.

Signed-off-by: Ian Walls koha.sek...@gmail.com
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Note that this problem only appears when importing records with item (952)
fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8133|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8134|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6875] de-nesting C4 packages

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

--- Comment #2 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8136
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8136action=edit
Bug 5698:  Add date picker option to SQL Runtime Parameters

Adds a date picker for SQL reports with the 'date' authorised_value.  Updates
help
documentation for this new feature, as well.

To test:
1.  Create a new report with two date parameters, using the syntax:
Label for this selection of date|date
2.  Run the report
3.  Select dates
4.  The SQL generated should format the dates properly in ISO, and keep track
of which
date is which

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||koha.sek...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |koha.sek...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8066|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

--- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8137
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8137action=edit
[3.6.x] Bug 7284: Authority matching improvements

Squashed patch incorporating all previous patches (there is no functional
change compared to the previous version of this patch, this patch merely
squashes the original patch and follow-up, and rebases on latest master).

=== TL;DR VERSION ===
*** Installation ***
1. Run installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt1
and installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt2
2. Make sure you copy the following files from kohaclone to koha-dev:
etc/zeradb/authorities/etc/bib1.att,
etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
etc/zebradb/marc_defs/marc21/authorities/koha-indexdefs-to-zebra.xsl, and
etc/zebradb/marc_defs/unimarc/authorities/record.abs
3. Run misc/migration_tools/rebuild_zebra.pl -a -r

*** New sysprefs ***
* AutoCreateAuthorities
* CatalogModuleRelink
* LinkerModule
* LinkerOptions
* LinkerRelink
* LinkerKeepStale

*** Important notes ***
You must have rebuild_zebra processing the zebraqueue for bibs when testing
this
patch.

=== DESCRIPTION ===

*** Cataloging module ***
* Added an additional box to the authority finder plugin for Heading match,
  which consults not just the main entry but also See-from and See-also-from
  headings.

* With this patch, the automatic authority linking will actually work properly
  in the cataloging module. As Owen pointed out while testing the patch,
  though, longtime users of Koha will not be expecting that. In keeping with
  the principles of least surprise and maximum configurability, a new syspref,
  CatalogModuleRelink makes it possible to disable authority relinking in the
  cataloging module only (i.e. leaving it enabled for future runs of
  link_bibs_to_authorities.pl).  Note that though the default behavior matches
  the current behavior of Koha, it does not match the intended behavior.
  Libraries that want the intended behavior rather than the current behavior
  will need to adjust the CatalogModuleRelink syspref.

*** misc/link_bibs_to_authorities.pl ***
Added the following options to the misc/link_bibs_to_authorities.pl script:
--auth-limitOnly process those headings that match the authorities
matching the user-specified WHERE clause.
--bib-limit Only process those bib records that match the
user-specified WHERE clause.
--commitCommit the results to the database after every N records
are processed.
--link-report   Display a report of all the headings that were processed.

Converted misc/link_bibs_to_authorities.pl to use POD.

Added a detailed report of headings that linked, did not link, and linked
in a fuzzy fashion (the exact semantics of fuzzy are up to the individual
linker modules) during the run.

*** C4::Linker ***
Implemented new C4::Linker functionality to make it possible to easily add
custom authority linker algorithms. Currently available linker options are:
* Default: retains the current behavior of only creating links when there is
  an exact match to one and only one authority record; if the
'broader_headings'
  option is enabled, it will try to link to headings to authority records for
  broader headings by removing subfields from the end of the heading (NOTE:
  test the results before enabling broader_headings in a production system
  because its usefulness is very much dependent on individual sites' authority
  files)
* First Match: based on Default, creates a link to the *first* authority
  record that matches a given heading, even if there is more than one
  authority record that matches
* Last Match: based on Default, creates a link to the *last* authority
  record that matches a given heading, even if there is more than one record
  that matches

The API for linker modules is very simple. All modules should implement the
following two functions:
get_link ($field) - return the authid for the authority that should be
linked to the provided MARC::Field object, and a boolean to indicate whether
the match is fuzzy (the semantics of fuzzy are up to the individual
plugin).
In order to handle authority limits, get_link should always end with:
return $self-SUPER::_handle_auth_limit($authid), $fuzzy;

flip_heading ($field) - return a MARC::Field object with the heading flipped
to the preferred form. At present this routine is not used, and can be a stub.

Made the linking functionality use the SearchAuthorities in C4::AuthoritiesMarc
rather than SimpleSearch in C4::Search. Once C4::Search has been refactored,
SearchAuthorities should be rewritten to simply call into C4::Search. However,
at this time C4::Search cannot handle 

[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7284] Authority matching algorithm improvements

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8136|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8138
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8138action=edit
Bug 5698: Add date picker option to SQL Runtime Parameters

Adds a date picker for SQL reports with the 'date' authorised_value.  Updates
help
documentation for this new feature, as well.

To test:
1.  Create a new report with two date parameters, using the syntax:
Label for this selection of date|date
2.  Run the report
3.  Select dates
4.  The SQL generated should format the dates properly in ISO, and keep track
of which
date is which

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7092] Complete-subfield searches TraceCompleteSubfields syspref not working correctly

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8118|0   |1
is obsolete||

--- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8139
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8139action=edit
Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not
working correctly

This patch adds a syspref TracingQuotes for toggling between using  and {}
for quoting in
subject tracings. With normal Zebra indexing,  must be used. With ICU Zebra
indexing, {}
must be used.

This syspref interacts with TraceCompleteSubfields and
TraceSubjectSubdivisions.

To test:

- marcflavour = MARC21
- make sure you have a record with a complex subject, like
  Internet -- Law and legislation

Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and
check that you
get the expected results for the clickable links in the OPAC *and* intranet
detail views:

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su:{Internet}

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su,complete-subfield:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su,complete-subfield:{Internet}

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su:Internet) and (su:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.})

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su,complete-subfield:Internet) and
(su,complete-subfield:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su,complete-subfield:{Internet}) and
(su,complete-subfield:{Law and legislation.})

Check that clicking on the generated links gives the expected search results,
bot with normal and ICU
indexing. (I have actually not tested this with ICU, so doing that before
signing off is crucial.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7092] Complete-subfield searches TraceCompleteSubfields syspref not working correctly

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7092] Complete-subfield searches TraceCompleteSubfields syspref not working correctly

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8139|0   |1
is obsolete||

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8140
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8140action=edit
Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not
working correctly

This patch adds a syspref TracingQuotes for toggling between using  and {}
for quoting in
subject tracings. With normal Zebra indexing,  must be used. With ICU Zebra
indexing, {}
must be used.

This syspref interacts with TraceCompleteSubfields and
TraceSubjectSubdivisions.

To test:

- marcflavour = MARC21
- make sure you have a record with a complex subject, like
  Internet -- Law and legislation

Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and
check that you
get the expected results for the clickable links in the OPAC *and* intranet
detail views:

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su:{Internet}

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su,complete-subfield:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su,complete-subfield:{Internet}

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su:Internet) and (su:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.})

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su,complete-subfield:Internet) and
(su,complete-subfield:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su,complete-subfield:{Internet}) and
(su,complete-subfield:{Law and legislation.})

Check that clicking on the generated links gives the expected search results,
bot with normal and ICU
indexing. (I have actually not tested this with ICU, so doing that before
signing off is crucial.)

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7537] Implement TraceCompleteSubfields, TraceSubjectSubdivisions and TracingQuotes for NORMARC XSLT

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7537

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8119|0   |1
is obsolete||

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8141
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8141action=edit
Bug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and
TracingQuotes for NORMARC XSLT

IMPORTANT! This patch relies on the patch for Bug 7092, and should be applied
on top of that patch! It will not work without it.

As the title says, this patch implements TraceCompleteSubfields,
TraceSubjectSubdivisions and TracingQuotes for NORMARC XSLT, both for the OPAC
and the Intranet. This affects how clickable subject-links are constructed.

To make this work the indexing of MARC fields in the 600 range is changed
to include Subject:p in several new places.

To test:

Find a record with a complex subject, like Internet -- Law and legislation.
MARC21 and NORMARC are very similar in how they handle subjects, so testing
on a MARC21 database should be OK. (Changes in indexing reflect changes already
made to the MARC21 indexing.)

Make sure you have these syspref settings:
- marcflavour = NORMARC
- XSLTDetailsDisplay = using XSLT stylesheets
- OPACXSLTDetailsDisplay = using XSLT stylesheets

(Ideally, testing should be done on a real NORMARC setup, but since the changes
to indexing only reflect how it's already done in MARC21, I think testing
on a MARC21 installation with marcflavour = NORMARC should be OK.)

Now try the different combinations of TraceCompleteSubfields,
TraceSubjectSubdivisions and TracingQuotes, and check the format of the
clickable links, both in the OPAC and staff client. Here's what you should
be seeing:

1.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su:{Internet}

2.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
TracingQuotes = quotes
  opac-search.pl?q=su,complete-subfield:Internet
TracingQuotes = curlybrace
  opac-search.pl?q=su,complete-subfield:{Internet}

3.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su:Internet) and (su:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.})

4.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
TracingQuotes = quotes
  opac-search.pl?q=(su,complete-subfield:Internet) and
(su,complete-subfield:Law and legislation.)
TracingQuotes = curlybrace
  opac-search.pl?q=(su,complete-subfield:{Internet}) and
(su,complete-subfield:{Law and legislation.})

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7537] Implement TraceCompleteSubfields, TraceSubjectSubdivisions and TracingQuotes for NORMARC XSLT

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7537

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7400] Add auto-completion on auth_finder

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8120|0   |1
is obsolete||

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8142
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8142action=edit
Bug 7400: Add auto-completion on auth_finder

While typing an authority, will automatically propose authorities (similar to
autocompletion for patron search if activated)

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Tested searching for authorities with and without autocomplete. Note that
this is most useful when used in the Main entry box instead of the
Main entry ($a only) box.
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Corrected tabs to spaces in auth-finder-search.inc while resolving merge
conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7400] Add auto-completion on auth_finder

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6296] Allow authentication to Koha via PKI / x.509 certificates

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6296

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #6386|0   |1
is obsolete||

--- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8143
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8143action=edit
Rebased but not signed off.

Bug 6296: allow users to be authenticated by SSL client certs

This adds a new syspref: AllowPKIAuth. It can have one of three states:
* None
* Common Name
* emailAddress

If a) this is set to something that's not None, and b) the webserver
is passing SSL client cert details on to Koha, then the relevant field
in the user's certificate will be matched up against the field in the
database and they will be automatically logged in. This is used as a
secure form of single sign-on in some organisations.

The Common Name field is matched up against the userid, while
emailAddress is matched against the primary email.

This is an example of what might go in the Apache configuration for the
virtual host:

SSLVerifyClient require
SSLVerifyDepth 2
SSLCACertificateFile /etc/apache2/ssl/test/ca.crt
SSLOptions +StdEnvVars

The last line ensures that the required details are passed to Koha.

Conflicts:

installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6372] Batch progress bar does not check for 0 size jobs; should be in separate js too

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6372

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #7607|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8144
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8144action=edit
bug 6372: moved background-job.inc to background-job-progressbar.js

Check for div 0 when calculating percentage.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
The batch item modification tool now handles zero-size batches properly, and
staging MARC records still works.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6372] Batch progress bar does not check for 0 size jobs; should be in separate js too

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6372

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7162] Factorize code for order cancellation

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
What functionality needs to be tested to confirm that this patch works? A test
plan would be very useful here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #2)
 (In reply to comment #1)
  Tested your patch: it works as described.
  I see your point when you should clear a subfield at the authority side and 
  you
  want to see the same at the biblio side. [How often would that happen?]
 
 Well, me myself was not convinced that it happens and that such a refinement
 is  is necessary--it was the library staff that told me it really happens
 sometimes and demanded to make Koha to behave like described in the
 proposal.  It does not happen often perhaps, but if it happens then the
 staff would have to edit even hundreds of biblio records by hand without
 this refinement.
 
  However, if the subfield was already empty at the authority side and you 
  update
  the auth record, do you also want to clear at that moment any possible info 
  in
  that subfield at the biblio side?
 
 Yes, because I was told this exactly means that the set of subfields of a
 field in biblio is *controlled* by the authority record.  In other words, if
 a subfield can have a value in authority (in Koha: it is not in 'ignored'
 state), then you are not supposed to edit it by hand in biblio.  I do not
 know if it is really so--I was told that.

I do not think this is correct. Subfield 'e' is not authority-controlled, but
Koha treats all non-numeric subfields in authority-controlled fields as if they
are. Or am I misunderstanding what this bug does, and there is a workaround for
this?

 
  Does an empty authority subfield that is not in the ignore tab in the
  framework, really mean that that subfield should always be empty too at the
  biblio side? I am not sure about that; I will copy this comment to the Koha
  list for possible further discussion.
 
 At least this is what I was told.  This means of course that with my
 refinement you have to carefully check which subfields are active in the
 authority framework, in order not to delete what you do not intend to.
 
 I will appreciate any comments.  For now this is what was needed in my
 library.  I thought it worth to share this with others.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7696] New: NORMARC lacks staff results XSLT

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7696

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7696
  Assignee: mag...@enger.priv.no
   Summary: NORMARC lacks staff results XSLT
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: MARC Bibliographic data support
   Product: Koha

Now that the staff results XSLT has been implemented for MARC21 and UNIMARC,
NORMARC should have the staff results XSLT, so that if XSLTResultsDisplay is
set to using XSLT stylesheets there won't be an error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5657] biblio records update fails when updating multiple authorities linked with the same biblio

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5657

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #7415|0   |1
is obsolete||

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8145
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8145action=edit
Bug 5657: Changes made to sub merge to eliminate errors occuring when updating
bibio records in batch (after updating multiple authority records)

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5657] biblio records update fails when updating multiple authorities linked with the same biblio

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5657

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7488] Errors with logs about moremember.pl / Messaging.pm

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I cannot reproduce this error. Could you explain the steps to reproduce?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5698] Provide datepicker for sql reports runtime parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5698

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6199] Allow bulkmarcimport to blank duplicate barcodes rather than skipping items

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6199

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #5846|0   |1
is obsolete||

--- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8146
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8146action=edit
Bug 6199 - allow bulkmarkimport.pl to remove duplicate barcodes

This adds the -dedupbarcode option that allows bulkmarkimport to erase
a barcode but keep the item of any items it finds with duplicate
barcodes.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6199] Allow bulkmarcimport to blank duplicate barcodes rather than skipping items

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6199

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7697] New: Clean up borrower.textmessaging leftover code

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7697
CC: gmcha...@gmail.com
  Assignee: koha.sek...@gmail.com
   Summary: Clean up borrower.textmessaging leftover code
QA Contact: m.de.r...@rijksmuseum.nl
  Severity: trivial
Classification: Unclassified
OS: All
  Reporter: koha.sek...@gmail.com
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Patrons
   Product: Koha

opac/opac-main.pl and opac/opac-user.pl export a template param
'textmessaging', based on the database field borrower.textmessaging, which does
not exist in Koha 3.X.  While this is generally harmless, it does add a
dependency on C4/Members to opac/opac-main.pl, which goes nowhere and does
nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7697] Clean up borrower.textmessaging leftover code

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697

--- Comment #1 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8147
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8147action=edit
Bug 7697:  Remove unused textmessaging parameter from OPAC main/user

Removes the textmessaging parameter from opac/opac-main.pl and
opac/opac-user.pl,
since it's not utilized anywhere in the templates, and is sourced from a field
that no longer exists in the borrower table (textmessaging).

This also removes a dependency on C4/Members.pm from opac-main.pl

To Test:  Login to the OPAC, and view both opac-user.pl and opac-main.pl.  Both
pages
should still render properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7697] Clean up borrower.textmessaging leftover code

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7434] Display of issue number for serials in overdues

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jcam...@cpbibliography.com

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
It sounds like the conclusion was that a revised patch which uses
items.enumchron is required. Marking Failed QA until the revised patch is
provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Could give us more details on what the problem is?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7587] Wrong table name for local cover images

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7587

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #8117|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 8148
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8148action=edit
[SIGNED-OFF] Bug 7587: Fix table name for biblioimages table

The kohastructure.sql file had the wrong name for the biblioimages table,
which broke the local cover images feature for new installations, and filled
the log with error messages.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
1) Checked a broken installation with wrong table name.
2) Checked for a new installation
Feature works perfectly.

http://bugs.koha-community.org/show_bug.cgi?id=7487

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7587] Wrong table name for local cover images

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7587

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jcam...@cpbibliography.com

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I agree with Nicole. Using a literal string is inconsistent and just asking for
trouble.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Marking failed QA because of the security issues noted by Frere Marie. Once
those have been resolved, I look forward to testing this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7697] Clean up borrower.textmessaging leftover code

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8147|0   |1
is obsolete||

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8149
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8149action=edit
Bug 7697: Remove unused textmessaging parameter from OPAC main/user

Removes the textmessaging parameter from opac/opac-main.pl and
opac/opac-user.pl, since it's not utilized anywhere in the templates, and is
sourced from a field that no longer exists in the borrower
table (textmessaging).

This also removes a dependency on C4/Members.pm from opac-main.pl

To Test:  Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both
pages should still render properly.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7697] Clean up borrower.textmessaging leftover code

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7698] New: Add ICU option to Koha out of the box

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7698

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7698
  Assignee: frede...@tamil.fr
Blocks: 3216
   Summary: Add ICU option to Koha out of the box
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: I18N/L10N
   Product: Koha

Word search with multi-part facets works properly only with Zebra ICU
tokenization. This patch add a new question to Koha command line
installer:

  Zebra has two methods to perform records tokenization
  and characters normalization: CHR and ICU. ICU is
  recommended for catalogs containing non-Latin
  characters. (chr, icu) [chr]

How to test:

  - perl ./Makefile.PL
  - Try each possible value for new parameter
  - Take a look at zebradb/etc/default.idx file.
Depending of the parameter you get this line:
  icuchain words-icu.xml
or this one:
  charmap word-phrase-utf.chr

(copied from bug 3216)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3216] UNIMARC author facets

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3216

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Depends on||7698

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7698] Add ICU option to Koha out of the box

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7698

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7698] Add ICU option to Koha out of the box

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7698

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3216] UNIMARC author facets

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3216

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #6716|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Marcel,

Are you sure a file like this should go in xt? xt/ is generally for tests, I
think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8065|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8152
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8152action=edit
Bug 7669: Add CSS classes to OPAC results thumbnails

Looks at the code for the images in the template I notices some were raw
images, some were encased in div tags, and no-images were in spans. I added
classes to the elements to make then more easily modified by the end user
through the OPAC CSS options.

Also, all images and no-images now have float:left (this was in the .thumbnail
class). I combines the thumbnail elements into the .no-image{} class. It does
not have div.no-image like the still active span.no-image, because that is an
element specific class and thus any settings in it override user settings. So,
it has to stay simply .no-image.

Images img now have a class thumbnail_image. This was in keeping with
consistent and unique element classes. thumbnail is used by all the div
elements.

Here are the new classes I have added, that are vendor/company specific:
/* New Classes for Thumbnail Images */
.thumbnail_image { /* specific class for the actual img tag */
}

/* specific classes for thumbnails */
.opac_thumb, .amazon_thumb, .google_thumb, .syndetics_thumb,
.openlibrary_thumb, .bakertaylor_thumb{
}

/* specific classes for no-image */
.amazon_no, .google_no, .openlibrary_no, .bakertaylor_no{
}

Example Code to see why:
/*examples how a specific class works*/
div.amazon_no{ /*Amazon no image [seem broken in code]*/
border: 1px solid #FFA500; /*amazon is ornage*/
}
.google_thumb, .google_no{/*Google no image*/
border-top: 2px solid #F00;
border-right: 2px solid #080;
border-bottom: 2px solid #FF0;
border-left: 2px solid #00F;
padding: 2px;
}
.openlibrary_no{
background: url(http://openlibrary.org/images/logo_IA-sm.png) right center
no-repeat;
color: #00F;
text-align: left;
}

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7699] New: Restricted until datepicker broken

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7699

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 7699
CC: gmcha...@gmail.com
  Assignee: paul.poul...@biblibre.com
   Summary: Restricted until datepicker broken
QA Contact: koha.sek...@gmail.com
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Staff Client
   Product: Koha

The icon for the Restricted until datepicker on the edit patron page does not
call up a datepicker. Indeed, it doesn't even appear to be a link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #8130|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 8153
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8153action=edit
Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin

Removes all date formatting done in circ/circulation, and sets any/all date
outputs to iso format.  The formatting of dates is now handled in the template
using the KohaDates plugin.

This allows use to remove a dependency on C4/Dates.pm from the script.

This patch also removes the usage of C4/Overdues/CheckBorrowerDebarred.  Since
borrowers.debarred is returned by GetMemberDetails, it doesn't make sense to
include another module to run another MySQL query just to fetch the date again.

To Test:

1. View the checkout page for a patron with materials checked out today and in
days past, as
well as items on reserve.
2. View a patron who is nearing their expiry date
3. Renew a patron
4. Renew a material from the checkout page using the renewal date selector
5. Attempt to checkout a book to a patron that is on hold for someone else
6. Attempt to checkout a book that is currently checked out
7. View a debarred patron

In all cases, any dates displayed should be in syspref format

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Corrected issue display of dates in warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus

2012-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/