[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Marc Véron ve...@veron.ch changed: What|Removed |Added Priority|P5 - low|P3 Status|NEW |ASSIGNED Version|unspecified |master Assignee|kyle.m.h...@gmail.com |ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 --- Comment #1 from Marc Véron ve...@veron.ch --- Created attachment 10918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10918action=edit Bug 7628 - Required format is not enforced for Patron Categories Enforces category code with allowed characters only. Test plan: - Before applying patch, create a category code like Test+ - Try to delete category with this code - does not work - Apply patch - Try to create category with code containg other characters than letters, numbers, - and _ - Result: You are not allowed to do so, appropriate message pops up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8083] Granular parameters permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz --- I think it gives the permission to all patrons that already had the 'admin' permission. But: 1- please confirm Confirmed, except it is 'parameters' permission 2- a comment just before the request would be usefull for a future reader. Done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 --- Comment #36 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 10919 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10919action=edit bug_5911: Make tt_valid.t happy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #2 from David Cook dc...@prosentient.com.au --- To test: Before applying the patch: 1) Place a hold on item XX for Patron 1 2) Place a hold on item XX for Patron 2 3) Check in item XX and confirm hold for Patron 1 3) Go to Holds Awaiting Pickup in the Circulation module 4) Cancel the hold for Patron 1 5) Instead of seeing a prompt or the table, you should see nothing but white and the masthead/header at the top of the page After applying the patch: Follow steps 1-4 again. This time, you should see a prompt telling you to retain the hold (or transfer it, if Patron 2 had a different pick-up location) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #32 from claire.hernan...@biblibre.com claire.hernan...@biblibre.com --- Jared, you're right. With Robin at Kohacon12, we did some packages I put here for the moment (except xml::easy wich is a core lib) https://depot.biblibre.com/chernandez/lib/all/ you can give it a try. To be really sure, I would need to test on a fresh install. I'll have a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #10739|0 |1 is obsolete|| Attachment #10742|0 |1 is obsolete|| Attachment #10743|0 |1 is obsolete|| Attachment #10903|0 |1 is obsolete|| --- Comment #26 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 10920 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10920action=edit Bug 7688: Change subscription numbering pattern and frequencies Squash of the 4 previous patches. Freshly rebased on current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 --- Comment #2 from David Cook dc...@prosentient.com.au --- Created attachment 10921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10921action=edit Bug 7628 - Required format is not enforced for Patron Categories Enforces category code with allowed characters only. Test plan: - Before applying patch, create a category code like Test+ - Try to delete category with this code - does not work - Apply patch - Try to create category with code containg other characters than letters, numbers, - and _ - Result: You are not allowed to do so, appropriate message pops up Signed-off-by: David Cook dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||dc...@prosentient.com.au --- Comment #4 from David Cook dc...@prosentient.com.au --- Small patch that does what it says. I'm not sure why someone would put a + into a category code, but data validation is always a good thing, and without it you stumble into the problems that Marc has outlined. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 David Cook dc...@prosentient.com.au changed: What|Removed |Added Attachment #10922|0 |1 is obsolete|| --- Comment #5 from David Cook dc...@prosentient.com.au --- Created attachment 10923 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10923action=edit [SIGNED-OFF] Bug 7628 - Required format is not enforced for Patron Categories Enforces category code with allowed characters only. Test plan: - Before applying patch, create a category code like Test+ - Try to delete category with this code - does not work - Apply patch - Try to create category with code containg other characters than letters, numbers, - and _ - Result: You are not allowed to do so, appropriate message pops up Signed-off-by: David Cook dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8415] Link Serial with Acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4198] deleting an authority refreshes the page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #10646|0 |1 is obsolete|| --- Comment #3 from Frédéric Demians frede...@tamil.fr --- Created attachment 10924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10924action=edit Bug 4198 - deleting an authority refreshes the page Works as advertised. Very useful. Still the issue that indexing being not in real time, the search result displays the just deleted authority. But there is no way to do better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4198] deleting an authority refreshes the page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #10647|0 |1 is obsolete|| --- Comment #4 from Frédéric Demians frede...@tamil.fr --- Created attachment 10925 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10925action=edit Bug 4198 - Followup - PerlTidy authorities-home.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4198] deleting an authority refreshes the page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||frede...@tamil.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #26 from Chris Cormack ch...@bigballofwax.co.nz --- Still waiting on the final patch before pushing to 3.8.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8381] Paging broken in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- Holding off pushing until the problem with chrome is fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed in conjunction with bug 8398 which undoes the regression this patch adds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6891] LDIF interoperability - a proposal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6891 --- Comment #24 from Robin Sheat ro...@catalyst.net.nz --- I haven't looked to see what they contain, but here are a couple that are used in the patch testing sandboxes: http://git.koha-community.org/gitweb/?p=contrib/global.git;a=tree;f=sandbox;h=83030c458a12c39c56fddbab3c60b329655bc612;hb=HEAD Additionally, the Koha database schema is here: http://schema.koha-community.org/ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Nicole and Owen, I agree, It is a lot of discussion for a little patch. But I think this kind of patch should have never exist :) Let me explain you why. When I arrived on this patch to make QA, I thought: it is an easy patch. I was surprised to find an unique space for a patch. I didn't know we wanted to add space after a input radio. Apparently, I am not alone in this case. My job as a part of QA team is to put in question each patch. I think this one should not have exist, because the ajustement between input and label should automatically be taken into account. Otherwise, for each patch adding these lines, inevitably a patch will have to be created to fix that. It's not very productive, I think. Given that, we can fix that definitely and don't create a new patch for each space to add. You patch works well, but it fixes one problem rather than fixing all futur problems Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10905|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #33 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #31) This new code introduces some rather serious problems. The packages required for Solr do not work on Squeeze, which means that t/00-load.t bails out without some serious black magic. Since all tests should pass is supposed to be one of the things that people who are signing off and doing QA are checking, this is a huge problem. In order to work around it when signing off, I ran relevant tests individually, but that is not a long-term solution, and certainly will not be a viable option when it comes time to actually release 3.10. Perhaps the packaging manager could be told which modules need to be packaged for Squeeze, so that we could get Koha working again? As solr stuff is experimental, couldn't we just skip Koha::SearchEngine::Solr for now, like what is done for cache: return if $m =~ /Cache/; # Cache modules are a WIP, add the tests back when we are using them more ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #27 from Koha Team Lyon 3 k...@univ-lyon3.fr --- This patch should not be pushed because it causes false calculation of late delay when patron is more than one month late. Here's how you can test it : First you have to install patch of Bug 8348 (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10619) to correct 2 errors on day closed calculation (if not, day_month_closed_days and single_holidays won't be subtracted in 'while( DateTime...' loop, so the test would be falsed). Another patch fixes these errors and could be simpler and prefered but I have not tested it (bug 8418 : http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10840). Then you must have Follow-up of this page (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10418) installed too. In our install the finesCalendar syspref is set to 'not including days the library is closed' and the useDaysMode syspref to 'the calendar to push the due date to the next open day'. Go to checkout tab of a patron. paste a barcode in barcode textbox In specify due date textbox set a date in order that the patron should be more than one month late (say '2012-05-07'). checkout and confirm Go to Calendar Tool and set between date due and today a number of closed days slightly greater than the nth day (7) of date due (say 9). Checkin the barcode. You 'll see that patron is not restricted. Uninstall the previous Patrons are systematically debarred at checkin patch, Go to obsolete patches of this page and install this one (Patrons get incorrectly debarred, 2012-07-02) : http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10597 Redo the same test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10878|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10926 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10926action=edit Bug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8415] Link Serial with Acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Attachment #10782|0 |1 is obsolete|| --- Comment #5 from Amit Gupta amit.gu...@osslabs.biz --- Created attachment 10927 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10927action=edit Link Serial with Acquisition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8464] Age limitations not handled during patron creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8464] Age limitations not handled during patron creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 10928 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10928action=edit proposed patch #1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8465] New: CancelReserve sub is doing wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8465 Priority: P5 - low Change sponsored?: --- Bug ID: 8465 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: CancelReserve sub is doing wrong Severity: critical Classification: Unclassified OS: All Reporter: christophe.croulleb...@biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha In request.pl when you cancel a waiting hold, with the red cross,the next becomes waiting, but: in the same page, the details column shows No Barcode in detail.pl, the status column shows available that is bad too, but: behind the scene, it's worse, because the CancelReserve function is poorly formated. The matter is that this sub puts a W on the next hold, that is impossible due to many constraints An other point, the sub increases priority for all other holds, that is good, except in one case: if we delete an hold with priority=0 and found=W the next waiting with priority=1 will be 0, and that is not good. So I have just corrected that and cleaned the code. After discussions, I have decided to avoid a manual checkin of the item. So, in the case of deleting a waiting hold, no need to checkin the item, if we have an hold following, a requester will propose to transfer or to confirm the hold. cleaning CancelReserve API : the biblionumber is retrieved in the SELECT * FROM reserves WHERE reservenumber = ?' at the beginning of the sub, so removing it from API. To test : * put 2 different holds on a biblio with 1 item * checkin and confirm the first hold * all is correct you can see it in the piority column Waiting * now use the red cross on the right to cancel this hold * check request.pl and detail.pl you'll see the results of the bug. Thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8465] CancelReserve sub is doing wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8465 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8465] CancelReserve sub is doing wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8465 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8465] CancelReserve sub is doing wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8465 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- There is a problem with the new routine GetMultiHoldsCountSameEnum. It returns a query string and the only place where it is used, the return is not used (CanItemBeReserved). However, when I place hold, I get 2 errors: Cannot place hold Too Many Holds: [USER] has too many holds. [USER] has already placed the maximum allowed number of holds on this record However, my syspref maxreserves is equal to 50 and I should not have the first error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8458] $stemmed_operand in C4::Search _build_stemmed_operand is not initialized.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8458 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 Assignee|gmcha...@gmail.com |mtomp...@hotmail.com QA Contact||m...@kohaaloha.com Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- Seeing the change, yes, I think a new signoff is required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Same behaviour with my last tests. Signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8218] Add a script to sanitize entity where character was wrongly replaced with amp;
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@biblibre.co
||m
Assignee|sophie.meyni...@biblibre.co |alex.arn...@biblibre.com
|m |
--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:
1/ Please use
use strict;
use warnings;
OR
use Modern::Perl;
2/ Perltidied for misc/maintenance/batchSanitizeEntity.pl
3/ Bad encoding (N°)
Technically:
4/ $count += 1; = $count++;
5/
+# We remove spaces
+my @biblio;
+foreach my $bib(@biblios) {
+$bib =~ s/(^\s*|\s*$)//g;
+next if $bib eq ;
+push @biblio, $bib;
+}
+@biblios = @biblio;
The second tmp array is useless:
# We remove spaces
s/(^\s*|\s*$)//g for @biblios;
# Remove empty lines
@biblios = grep {!/^$/} @biblios;
6/ if ($biblios =~ /\//)
is more readable as:
if ( $biblio =~ m|/| )
for example
7/ +while (my $bib = $sth- fetchrow_array()){
There is a useless space ;-)
Marking as Failed QA for 1 and 2
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #7) Should we allow for the possibility of a stylesheet served by https:// ? Sure, good point. Will send new version. Thx. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #10913|0 |1 is obsolete|| --- Comment #38 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 10929 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10929action=edit Bug 5079 - Make display of shelving location and call number in XSLT results controlled by sysprefs * Don't show the Location line if there are no copies available, since it will inevitably be blank * Also, don't show locations for Checked Out, Lost, Damaged, Withdrawn, On Hold or In transit items; it doesn't really make sense, since the items aren't actually there, and it results in repetitive listing of the shelving location * Added system preference to display shelving location of an item on opac results. The system preference is called OpacItemLocation. I also moved the call number to a new line called Location along with the shelving location if it is enabled. To Test: 1) Run database update script to add syspref. 2) Set OpacItemLocation to show locations or collection codes on the opac-search page. If it is working you should see the shelving location of the item before the call number. Multiple home branch shelving locations are seperated by a pipe character ( i.e. '|' ). Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Rebased on latest master, removed the reformatting, and changed the syspref to be a choice between showing the call number only, the location, and the collection code. Signed-off-by: Elliott Davis elli...@bywatersolutions.com Works as Advertised. I would like to see the logic added to differenciate between multiple locations and a single location for the word 'location(s)' but that goes beyond the scope of this ticket. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #10379|0 |1 is obsolete|| --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 10930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10930action=edit Patch for 8263 Allows https too for css url. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #4 from Julian Maurice julian.maur...@biblibre.com --- Switching to 'in discussion' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8415] Link Serial with Acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #6 from claire.hernan...@biblibre.com claire.hernan...@biblibre.com --- Hello Amit, Help is welcomed, thanks. I think we should have a look closer because you seem to add the same (but not the same) sub as another bz from us: Bug 5357 and there is maybe others overlaps with our work. More information soon... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8466] New: Holds on MARC records with no item causes silent error in koha-error_log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8466 Priority: P5 - low Change sponsored?: --- Bug ID: 8466 CC: m.de.r...@rijksmuseum.nl Assignee: gmcha...@gmail.com Summary: Holds on MARC records with no item causes silent error in koha-error_log Severity: minor Classification: Unclassified OS: All Reporter: kol...@o2.pl Hardware: All Status: NEW Version: rel_3_6 Component: Cataloging Product: Koha Created attachment 10931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10931action=edit proposed (two) patches While cataloging, viewing MARC details of record that hasn't items yet, a silent error occurs in koha-error_log when a librarian clicks on the Holds tab. The error messages are like that: request.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3 at /usr/share/koha/lib/C4/Koha.pm line 811., request.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /usr/share/koha/lib/C4/Koha.pm line 814., The reason is an empty items value in dynamically build query in procedures: - Module: Items.pm, procedure: GetItemInfosOf - Module: Biblio.pm, procedure: GetBiblioItemInfosOf Proposed patch refers to the version 3.6.4 The bug occurs also in later Koha versions (ie. 3.6.6, 3.8) and the same patches should be implemented there (it is only one line add), respectively: Module: Items.pm - line 1064 in version 3.6.6; line 1069 in version 3.8 Module: Biblio.pm - line 1014 in version 3.6.6; line 1026 in version 3.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8466] Holds on MARC records with no item causes silent error in koha-error_log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8466 Piotr Kowalski kol...@o2.pl changed: What|Removed |Added CC||kol...@o2.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8456] Capture the invoice number, price, date of a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8456 --- Comment #1 from Amit Gupta amit.gu...@osslabs.biz --- Created attachment 10932 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10932action=edit Capture the invoice number, price, date of a subscription Create an order using a subscription. This order is different from regular orders in that it is for a serial subscription, not for a book. When receiving, the item add function does not work as it does in the case of books. Here no item is added since items are added from serials module. But invoice, invoice date, actual cost is captured when receiving. Two cases here: 1) Systempreferences AcqCreateItem is set to receiving an order When receiving this message is displayed instead of the usual add item fields -- This order is for a serial subscription. Items are added in the serial module. 2) Systempreferences AcqCreateItem is set to placing an order When ordering this message is displayed instead of the usual add item fields -- This order is for a serial subscription. Items are added in the serial module. this bug depends on 8415 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8456] Capture the invoice number, price, date of a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8456 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8463] Koha/SearchEngine/Solr/Search.pm fails perlcritic test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|ve...@veron.ch |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10485|Bug 6679 - fix 19 |[FAILED-QA]Bug 6679 - fix description|perlcritic violations from |19 perlcritic violations |C4::Letters.pm |from C4::Letters.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10486|0 |1 is obsolete|| --- Comment #125 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10935 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10935action=edit Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm Bareword file handle opened at line 558, column 17. See pages 202,204 of PBP. (Severity: 5) Two-argument open used at line 558, column 17. See page 207 of PBP. (Severity: 5) http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10491|0 |1 is obsolete|| --- Comment #126 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10936 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10936action=edit Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm - Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) - return statement with explicit undef at line 102, column 28. See page 199 of PBP. (Severity: 5) - Expression form of eval at line 108, column 20. See page 161 of PBP. (Severity: 5) - Variable declared in conditional statement at line 126, column 5. Declare variables outside of the condition. (Severity: 5) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 10937 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10937action=edit Patch for adding perl dependency Html::FormatText is used in opac-sendbasket.pl and may be part of default Debian. But it is not a default Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies. Corrected a typo too in comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10492|0 |1 is obsolete|| --- Comment #127 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10493|0 |1 is obsolete|| --- Comment #128 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10940 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10940action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm - Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) - return statement with explicit undef at line 1112, column 4. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #10891|0 |1 is obsolete|| Attachment #10911|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 10941 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10941action=edit Bug 3387 - WITHDRAWN items shouldn't check in Adds a system preference BlockReturnOfWithdrawnItems to control whether or not Koha should allow a withdrawn item to be returned or not. Also fixes the behavior where Koha will attempt to use a withdrawn item to fill a hold. Test Plan: 1) Set BlockReturnOfWithdrawnItems to Block ( this is the default ) 2) Check an item out to a patron 3) Mark item as withdrawn 4) Attempt to return the item, you should still see the item on the borrower's record 5) Set BlockReturnOfWithdrawnItems to Don't Block 6) Attempt to return the item, you should see the item is no longer on the borrower's record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- This new patch should solve the holds issue, and also fixes the dbrev description. I've squashed everything down to one patch for convenience, as none of them have been signed off yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #13) Hi Nicole and Owen, I agree, It is a lot of discussion for a little patch. But I think this kind of patch should have never exist :) Let me explain you why. When I arrived on this patch to make QA, I thought: it is an easy patch. I was surprised to find an unique space for a patch. I didn't know we wanted to add space after a input radio. Apparently, I am not alone in this case. My job as a part of QA team is to put in question each patch. I think this one should not have exist, because the ajustement between input and label should automatically be taken into account. Otherwise, for each patch adding these lines, inevitably a patch will have to be created to fix that. It's not very productive, I think. Given that, we can fix that definitely and don't create a new patch for each space to add. You patch works well, but it fixes one problem rather than fixing all futur problems Marking as Passed QA We're not really consistent: * moremember.pl page (patron adding) show yes [] no [] for flags sex (checkbox on the right of the label) * the inventory.pl page show the checkbox on the left, description is not clicable * the tools/holidays.pl page show the checkbox on the left, the description itself is clickable My preference goes to what we have in tools/holidays.pl, but let me know your's. Should we start a discussion on koha-devel for that ? In the meantime, this patch is pushed, even if i'm not a fan of the space (owen, your voice is a leader one for all what is related to interface for me) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8464] Age limitations not handled during patron creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Is this the same as Bug 8392? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8464] Age limitations not handled during patron creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com --- Oh yes, didn't find this one :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8464] Age limitations not handled during patron creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Adrien SAURAT adrien.sau...@biblibre.com --- *** This bug has been marked as a duplicate of bug 8392 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8244] Script to find exporter problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #10542|Bug 8244: New script|[SIGNED-OFF] Bug 8244: New description|xt/find-undefined-subroutin |script |es.pl |xt/find-undefined-subroutin ||es.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #30 from M. de Rooy m.de.r...@rijksmuseum.nl --- Forget the latest patch please. I think we should remove this use statement after all; it seems not to be used anyhow.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #10939|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10499|0 |1 is obsolete|| --- Comment #129 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10944 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10944action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10500|0 |1 is obsolete|| --- Comment #130 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10945 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10945action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10944|0 |1 is obsolete|| --- Comment #131 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10946 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10946action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10945|0 |1 is obsolete|| --- Comment #132 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10947 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10947action=edit Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10502|0 |1 is obsolete|| --- Comment #134 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10949 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10949action=edit Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Reports/Guided.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #10892|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 10951 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10951action=edit Bug 7189 - preference to control if returning lost items gives refund Right now when you return an item that was lost the patron's card is credited with the lost fee, but not all libraries refund lost fees and sometimes the fee is refunded after the patron has paid for it, causing all kinds of financial issues. Adds the syspref RefundLostItemFeeOnReturn to control whether returning a lost item refunds the fee charged for losing that item. Enabled by default to maintain Koha's current functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10505|0 |1 is obsolete|| --- Comment #136 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10952 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10952action=edit Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #10676|0 |1 is obsolete|| --- Comment #12 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 10954 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10954action=edit Bug 5600: Command line interface for tools/export.pl Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5600] Bulk MARC biblio export script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10509|0 |1 is obsolete|| --- Comment #138 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10955 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10955action=edit Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Here is an updated patch. I now understand Jonathan's comment, he swapped the subroutines in his sentence. The old patch worked, but only when trying to issue a lost item. New patch works for explicit returning of a lost item as well. I've also added the messages suggested by Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10512|0 |1 is obsolete|| --- Comment #140 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10958 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10958action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10513|0 |1 is obsolete|| --- Comment #141 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10959 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10959action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10515|0 |1 is obsolete|| --- Comment #143 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10961 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10961action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10517|0 |1 is obsolete|| --- Comment #144 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10962 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10962action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/ClassSortRoutine.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10522|0 |1 is obsolete|| --- Comment #145 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10963 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10963action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10524|0 |1 is obsolete|| --- Comment #146 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10964 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10964action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10525|0 |1 is obsolete|| --- Comment #147 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10965 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10526|0 |1 is obsolete|| --- Comment #148 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10966 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10966action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10527|0 |1 is obsolete|| --- Comment #149 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10967 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10967action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/AuthoritiesMarc.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- I submitted a patch for the dependency under 7368. But Robin is right that the code in opac-basket does not directly use FormatText. So the use statement can be deleted. But note that the Template::Plugin::HtmlToText requires HTML::FormatText. So it is a core Koha dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7292] new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #9618|0 |1 is obsolete|| --- Comment #9 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 10968 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10968action=edit Bug 7292: More granular permissions for claiming orders Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7292] new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #9875|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #9940|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8062] Cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 10969 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10969action=edit Patch for HTML::FormatText Deletes use statement only in opac-sendbasket.pl Template::Plugin::HtmlToText does require it on its own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6716] Database Documentation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 --- Comment #111 from Nicole C. Engard neng...@gmail.com --- Created attachment 10970 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10970action=edit Bug 6716: Document import_batches table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 10974 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10974action=edit Bug 7189 - Followup - perltidy renewscript.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
