[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382
--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Christophe: A followup is mandatory !
This line does not do what we want:
+my $datereceived = ($input-param('op') eq ('new' or search)) ?
C4::Dates-new($input-param('datereceived'))
+: C4::Dates-new($input-param('datereceived'), 'iso');
$s eq ('foo' or 'bar') does not return true if $s = 'bar'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7409] Missing dependencies for Debian package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 12263 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12263action=edit Bug 7409 : Missing dependency on DBD::Mock -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8366] Meaning of All in issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #8) Sorry for the delay, I was doing some research. Librarians seem to like the idea of going back to 'Default' instead of 'All'. But we might want to ask why it was changed to all originally - who was confused by 'All'? Nicole The main issue here is that the all (same word) has different meanings. See the initial description of this bug: * for libraries and patrons, it means value to use if there is no rule for this library/patron * for itemtypes it means otherwise, it's not exactly the same default Let me take another example: 3 libraries LA, LB, LC 3 patron categories PA, PB, PC 3 itemtypes IA, IB, IC If you define LA, PA, IA = 5 items LA, PA, IB = 5 items LA, PA, IC = 5 items *, *, * = 10 items it will mean one can issue 10 items from LB *and* 10 items from LC That's not the same behaviour as for itemtypes, where LA, PA, IA = 5 LA, PA, * = 10 means 10 IB *or* IC (= 10 IB, 9 IB+1IC, 8+2, 7+3,...) Different behaviour = different terms should be used ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12257|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12264 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12264action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger-new; $log-debug(This is a debug message); $log-info(This is an information); $log-error(This is an error !); The Logger constructor can take an hash reference with file and level to define a filepath or a log level. For a log level = warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7409] Missing dependencies for Debian package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #12 from Robin Sheat ro...@catalyst.net.nz --- Assuming that these deps are recorded in the standard dependencies file, they'll get picked up on their own, and I tend to roll them into a bigger patch, along with changelog updates and such. If not, then this patch will be needed for them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12265 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12265action=edit Bug 8190: Followup Logger: FIX perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- First patch replace LOG with KOHA_LOG Second patch fixes perlcritic errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7409] Missing dependencies for Debian package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- They aren't currently, which means that the 3.8.x daily builds are failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #11535|0 |1 is obsolete|| --- Comment #77 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12266 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12266action=edit [SIGNED-OFF] Bug 5339: Invoices management improvement Patch rebased on master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #11574|0 |1 is obsolete|| --- Comment #78 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12267 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12267action=edit Bug 5339: perltidy on added files Patch rebased on master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241
--- Comment #29 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #27)
(In reply to comment #24)
Well, Thinking of it a little bit more, I've reverted the patch.
Having history badly broken for existing instances is really bad, because we
will never be able to fix the problem properly once action_logs contains
mixed informations (biblio items)
And I've an easy proposal to fix what can be fixed:
The following SQL:
UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE
biblionumber= action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND
action in ('ISSUE','RETURN');
Set the 1st item number (as we can't know which item was circulated once
things have been anonymised). It's better than nothing.
I propose that you submit a new patch including an updatedatabase with this
SQL
As a possible supplement, how about tagging the object column with an
indication of whether it's an old-style log of a biblionumber. E.g.,
UPDATE action_logs SET object = 'biblio ' || object WHERE module =
'CIRCULATION' AND action IN ('ISSUE', 'RETURN');
Then viewlog.pl could assume that if the value is tagged with a 'biblio '
prefix that it contains an bib number; if it isn't, it contains an item
number.
Doing it this way would mean that the logs are as accurate as possible.
It means Adrien would have to update viewlog.pl to take care of this ? I'm not
sure I'm for it. It introduce some specific code to circumvent an error in what
is saved.
Another, farther-reaching option would be to add biblionumber and itemnumber
columns to action_logs.
mmm... the 'object' term is generic, it can also contain a borrowernumber,...
Maybe that was a mistake, and it would be better to have a biblionumber,
itemnumber, borrowernumber,... field (one field for each needed kind of
information). But that would be for another patch ;-)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Assignee|neng...@gmail.com |jonathan.dru...@biblibre.co ||m --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Jonathan, if you could make a patch for fixing those term issues, that would be perfect ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #42 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12268 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12268action=edit Bug 7688 follow-up: Small fixes for QA #2 - return undef - return - :utf8 - :encoding(UTF-8) - TAB - SPACES -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #43 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12269 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12269action=edit Bug 7688: Translate sample frequencies for french -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #17 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #16) Although I agree that some web font css label solution or such may be the worth pursuing. I investigated a lot Perl libraries for managing PDF. I feel we will have a better results investigating the CSS way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #44 from Julian Maurice julian.maur...@biblibre.com ---
(In reply to comment #40)
QUESTION : why in the FR-fr samples do you have english strings (and not
french) :
diff --git a/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql
b/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql
shouldn't :
+('2/day', 'day', 1, 2, 1),
+('1/day', 'day', 1, 1, 2),
+('3/week', 'week', 1, 3, 3),
+('1/week', 'week', 1, 1, 4),
+('1/2 weeks', 'week', 2, 1, 5),
+('1/3 weeks', 'week', 3, 1, 6),
be
+('2/jour', 'day', 1, 2, 1),
+('1/jour', 'day', 1, 1, 2),
+('3/semaine', 'week', 1, 3, 3),
+('1/semaine', 'week', 1, 1, 4),
+('1/2 semaines', 'week', 2, 1, 5),
+('1/3 semaines', 'week', 3, 1, 6),
(if yes, please confirm -so i can ask koha-translate mailing list for SP,
IT, NO,... translations, and provide a french version)
Yes it should be translated. Note that it can also be done through staff
interface.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #11489|Bug 7688: Change|[SIGNED-OFF] Bug 7688: description|subscription numbering |Change subscription |pattern and frequencies |numbering pattern and ||frequencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #12265|0 |1 is obsolete|| --- Comment #14 from Mason James m...@kohaaloha.com --- Created attachment 12270 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12270action=edit Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #11490|Bug 7688 follow-up: Small |[SIGNED-OFF] Bug 7688 description|fixes for QA|follow-up: Small fixes for ||QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Mason James m...@kohaaloha.com --- (In reply to comment #9) Jonathan. looks good, signing-off... but, perlcritic errors... errors fixed, signing-off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 --- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 12271 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12271action=edit Proposed patch (for 3.8.X) Rebased patch for 3.8.X version. Only one existing line is different form master version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11653|0 |1 is obsolete|| Attachment #11982|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12272 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12272action=edit Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In order to be valid XHTML ampersands must be encoded (amp;). Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12273 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12273action=edit Bug 8382: Followup: FIX wrong comparaison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12274 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12274action=edit Bug 8370: Change term issues (smart-rules) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- I also change the Holds policy by item type part for more consistency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8428] can't save contracts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|rel_3_8 |rel_3_10 --- Comment #12 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #11) Doesn't apply on 3.8.x please reformat if needed Not needed. The bug is related to the addition of the jQueryUI datepicker which isn't in 3.8.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12250|0 |1 is obsolete|| Attachment #12252|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12275 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12275action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12275|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12276action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #242 from Kyle M Hall k...@bywatersolutions.com --- I think there is general agreement that future patches for this issue should be filed as separate bugs and set as depending on this bug. The number of comments on this one is becoming unwieldy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #94 from Owen Leonard oleon...@myacpl.org --- Created attachment 12277 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12277action=edit Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8776] New: note on why a fine was waived
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Priority: P5 - low Change sponsored?: --- Bug ID: 8776 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: note on why a fine was waived Severity: major Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha There used to be a way to add notes to payments and waived fines, but that's not possible anymore. We need a way to record why we're waiving fines for auditors and accounting reasons. This may be related to bug 6413, but I don't know how so I'm not putting it in depends or blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8776] note on why a fine was waived
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6413 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8776 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard oleon...@myacpl.org --- I think this patch represents the best possible solution given the way we handle holds right now. I wish we didn't have to force the hold to be an item-level hold, but it's a limitation of how we store hold information. I would ask for two changes: 1. Make revert the default option. That is the less destructive of the two. 2. Change the markup of the radio buttons to allow clicking on the text: p label for=cancelreserveCancel hold/label input type=radio checked=checked value=cancel name=cancelreserve id=cancelreserve /br / label for=revertreserveRevert waiting status/label input type=radio value=revert name=cancelreserve id=revertreserve / /p The label must match the id of the input field. Note that the input name and the input id do not have to match. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12277|0 |1 is obsolete|| --- Comment #95 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12278 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12278action=edit [SIGNED-OFF] Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12276|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12279 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12279action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7351] ability to edit a range of holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #46 from Christophe Croullebois christophe.croulleb...@biblibre.com --- hum Paul, this patch just works on the second feature about a range a date, the deletion. The first one I have made allows to create holidays on a range, and it is pushed. This one allows to delete on a range, so I don't understand, you says you can't add holidays on a range ? But it's not the purpose of this patch, anyway, I have just tested again few minutes ago, all is ok, even creating holidays on a range... Could you test again ? I see an other trouble with you there is some time = Christophe Croullebois 2012-06-01 09:45:21 UTC I have seen with Paul, maybe due to his hook git... Tested with two others PC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #30 from Colin Campbell colin.campb...@ptfs-europe.com --- Yes thats it, except DecreaseLoanHighholdsDuration is the value to reduce the loan by. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12280 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12280action=edit Bug 8015: Followup: On move, we cant delete existing fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- *Quick and dirty patch* :-/ But it could fix the issue. Kyle, what do you think about it ? It could introduces some regressions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #12279|0 |1 is obsolete|| --- Comment #11 from Owen Leonard oleon...@myacpl.org --- Created attachment 12281 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12281action=edit [SIGNED-OFF] Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. Signed-off-by: Owen Leonard oleon...@myacpl.org All three cases tested, correct outcome each time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8559] conflicting item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #58 from Paul Poulain paul.poul...@biblibre.com --- will test and think of it again, it's a damn useful enhancement ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8777] New: Quiet errors in circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 Priority: P5 - low Change sponsored?: --- Bug ID: 8777 CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assignee: oleon...@myacpl.org Summary: Quiet errors in circulation.pl Severity: normal Classification: Unclassified OS: All Reporter: oleon...@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha Reference found where even-sized list expected at /circ/circulation.pl line 97. Use of uninitialized value $print in string eq at /circ/circulation.pl line 161. Use of uninitialized value in string eq at /circ/circulation.pl line 166. Use of uninitialized value $print in string eq at /circ/circulation.pl line 173. Use of uninitialized value in string eq at /circ/circulation.pl line 364. Use of uninitialized value in string ne at /circ/circulation.pl line 382. Use of uninitialized value in string eq at /circ/circulation.pl line 388. Use of uninitialized value in string gt at /circ/circulation.pl line 464. Use of uninitialized value in string eq at /circ/circulation.pl line 461. Use of uninitialized value in hash element at /circ/circulation.pl line 644. Use of uninitialized value in concatenation (.) or string at /circ/circulation.pl line 644. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library = wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #7 from Marc Véron ve...@veron.ch --- As Nicole pointed out in comment #2 the insturctions at the top of the page should be changed as well. Now the points regarding the defaults read as follows: all libraries, same patron type, same item type all libraries, same patron type, all item types all libraries, all patron types, same item type all libraries, all patron types, all item types It would be better to have e.g. default (all libraries), same patron type, same item type default (all libraries), same patron type, all item types default (all libraries), all patron types, same item type default (all libraries), all patron types, all item types Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8110] Add tests for Calendar modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #46 from Paul Poulain paul.poul...@biblibre.com --- QA comment : the 3rd patch adds some localized files: .../mysql/fr-FR/2-Optionel/sample_holidays.sql |4 .../data/mysql/it-IT/optional/sample_holidays.sql |4 why are they needed ? in fr-FR, there is no branch in the sample 'MPL' afaik PS: is it still a blocker ? I think no, the blocker was bug 8486, and it's pushed now, this one is just the test suite -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12264|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12282 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12282action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger-new; $log-debug(This is a debug message); $log-info(This is an information); $log-error(This is an error !); The Logger constructor can take an hash reference with file and level to define a filepath or a log level. For a log level = warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12270|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12283 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12283action=edit Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #18) Created attachment 12284 [details] Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context-logger * Embed logged messageds to a comment in the template html I forget to add that I ran perltidy on Logger.pm. I think this followup could be very useful. It may be better to have it controlled by a system preference, rather than always on though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #12248|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 12285 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12285action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #25 from Paul Poulain paul.poul...@biblibre.com --- Running the script says: DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at ./overdue_notices.pl line 505. DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at ./overdue_notices.pl line 518. Investigating a little, show that line 505 is running $sth2, that contains: my $sth2 = $dbh-prepare( 'END_SQL' ); SELECT biblio.title as biblio.title, biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue FROM issues,items,biblio, biblioitems WHERE items.itemnumber=issues.itemnumber AND biblio.biblionumber = items.biblionumber AND biblio.biblionumber = biblioitems.biblionumber AND issues.borrowernumber = ? AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? END_SQL the line: AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? is heavily wrong ! The signoff was probably right when it was made, but time passed, things were updated, and now it's invalid ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #35 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #33) If at least one of both sysprefs (ExportRemoveFields and ExportWithCsvProfile) is filled, the export link is displayed The column of checkboxes for export should also be shown only if one of the two system preferences is filled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|unspecified |rel_3_10 --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master I think there's no need to push it to 3.8, (just in case we missed some side effect) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #12 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|unspecified |rel_3_8 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #13 from wajasu matted-34...@mypacks.net --- Created attachment 12286 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12286action=edit Bug-8378-v3.8.x-fine-syntax-not-working-on-overdues-.patch I've attached a patch that applies to origin/3.8.x wajasu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|unspecified |rel_3_8 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8624] famfamfam should be outside theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #11) Now that you suggest it, I think it might be possible. If Owen can't think of any reason not to, I will submit a revised patch to do this. I see no reason not to from the template management point of view. If it is feasible, let's do it. And the same with itemtypeimg? Actually, this would not work with standard installs. hmm, unless we had +symlinks enabled in apache, yeah? Ooh, that's an intriguing idea. I'm not sure how to do that in a way that won't break dev installs, though, since most developers don't update their koha-httpd.conf files. mmm... I'm not sure I should push this patch. Is there still a debate ? why famfam and not itemtypeimg ? Has anyone checked it will it work with standard installs as well as dev ones ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA CC||paul.poul...@biblibre.com --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- QA comment: shouldn't +=head2 GetTotalFines + +my $total_fines_owed = GetTotalFines( $borrowernumber ); + +Returns the total amount owed by the given borrower. be in C4/Accounts.pm more than in C4/Overdues.pm ? I know there is calcfine and UpdateFine in C4/Overdues.pm, but I think it's a mistake ! If you agree with me and move GetTotalFines to C4/Accounts.pm, you're welcomed to factorize getcharges, getcredits, getrefunds, that are Getting things in accountlines table. Note this is not requested for earning QA, just a suggestion You're also welcomed to name your sub GetFines, as GetSomethings() is already supposed to return a list of something, so the Total is useless -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8765] Add series title to intranet search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master. Note I replaced tab by 4 spaces before pushing. Please don't use tabs, use 4 spaces instead (see coding guidelines) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- Koha team Lyon 3, do you agree with the counter fix proposed by Fridolyn ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #29 from Paul Poulain paul.poul...@biblibre.com --- The patch does not apply anymore, sorry: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt Please rebase resubmit (and switch back to passed QA) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #21 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master. I've revised my judgement, it's a very handy feature ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7913] Automatically receive serial issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * Stéphane, in comment 4 you say: the use of this function is limited to subscriptions without items records.And the bulk reception start always from the last issue expected then it would be better to choose which serial number you want to begin receiving and not always from the last number expected. it seems it's still the case, this is a reason for failing QA : libraries won't know or will make a mistake, for sure ! To earn QA, this patch should hide the link when the subscrition.serialsadditems=1 Optional suggestion (that isn't requested to pass QA) = have the link/feature also available from serials/serials-edit.pl page Other than this, it's a very handy feature ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7913] Automatically receive serial issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #11 from Paul Poulain paul.poul...@biblibre.com --- Koha team Lyon 3, if you provide a follow-up, please attach the follow-up, and switch back to passed QA, i'll test/check and push if everything is OK with the follow-up I've checked the main patch, works nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #13) *Quick and dirty patch* :-/ But it could fix the issue. Kyle, what do you think about it ? It could introduces some regressions. I think that looks good to me. I don't think it will cause any problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Koha does not have a logging module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12284|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12287 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12287action=edit Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context-logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12280|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12288 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12288action=edit Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12288|Bug 8015: Followup: On |[SIGNED-OFF] Bug 8015: description|move, we cant delete|Followup: On move, we cant |existing fields |delete existing fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7986] Export issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #11581|0 |1 is obsolete|| Attachment #11582|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 12289 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12289action=edit Bug 8623 - Fix YUI path for OPAC in debian/rules After the changes to YUI path the build process is broken. For testing this I had to set the build process to ommit the tests as there are some db_dependent test being called (which failed). To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Note: Even when this is fixed, there are still issues with some files missing dh_install: etc/koha/searchengine/solr/config.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/searchengine/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: missing files, aborting make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8624] famfamfam should be outside theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 wajasu matted-34...@mypacks.net changed: What|Removed |Added CC||matted-34...@mypacks.net --- Comment #14 from wajasu matted-34...@mypacks.net --- ok, i did a standard install from the signed off patch. i inspected /usr/share/koha/.../lib/famfamfam and such and it looked fine. i turned on the XSLT Details( with default and see the BK.png in my details in opac and staff client. I'm assuming the SIGNED-OFF patch had other places confirmed. wajasu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #6 from David Cook dc...@prosentient.com.au --- Yep, Jonathan. It looks good. Sorry about the tabs! I've started using two different editors, and I hadn't switched the second from tabs to spaces. That should be remedied now :) (In reply to comment #4) Hi Owen and David, Could you confirmed that my proposed patch does the same job as previously ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8765] Add series title to intranet search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 --- Comment #6 from David Cook dc...@prosentient.com.au --- (In reply to comment #5) Patch pushed to master. Note I replaced tab by 4 spaces before pushing. Please don't use tabs, use 4 spaces instead (see coding guidelines) Thanks for the reminder, Paul. I've started using another editor and I thought that I had it switched to spaces, but now I see the error. Future patches should be tab free :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #11128|0 |1 is obsolete|| --- Comment #37 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 12290 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12290action=edit Bug 8233 - SolR-related /etc/ files break deb building Remove them using debian/rules when building .deb packages until we figure out what to do with them in a .deb install. To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] New: Add Phrase Searching to OPAC Search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Priority: P5 - low Change sponsored?: --- Bug ID: 8778 Assignee: oleon...@myacpl.org Summary: Add Phrase Searching to OPAC Search Severity: enhancement Classification: Unclassified OS: All Reporter: dc...@prosentient.com.au Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Add Keyword phrase, Title phrase, and Notes/Comments to drop-down menu in masthead.inc, which populates top search box in OPAC. Also, edit opac-search.pl so that the correct index appears in the drop-down menu following a search (which doesn't seem possible using JQuery) Finally, add Keyword phrase to OPAC Advanced Search, and move Title phrase and Notes/Comments so that they appear on the default advanced search screen rather than after clicking More Options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] Add Phrase Searching to OPAC Search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |dc...@prosentient.com.au --- Comment #1 from David Cook dc...@prosentient.com.au --- Created attachment 12291 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12291action=edit Bug 8778 - Add Phrase Searching to OPAC Search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #12285|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 12292 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12292action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Derryn derr...@gmail.com changed: What|Removed |Added CC||derr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #12292|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 12293 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12293action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Until we get Koha::Contrib::Tamil::IndexerDaemon packed as a .deb file (Bug 8774), it needs to be manually installed for testing this patch. As building the packages takes some time depending on your hardware, i've uploaded the .deb files to http://es.koha-community.org/kc_files/ so they can be tested. You need to grab the koha-common*.deb file, install it (using dpkg -i file) and probably create a new koha instance (koha-create --create-db instance). It is worth checking if upon upgrade the running instances get their indexer daemon running automagically. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #6 from wajasu matted-34...@mypacks.net --- Created attachment 12294 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12294action=edit initial test run for koha-common .deb (newer one) I got my VM with the current koha-common. I did dpkg -i yourkoha-commom and I've attached what I saw. See initial test run for koha-common .deb (newer one) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to comment #6) Created attachment 12294 [details] initial test run for koha-common .deb (newer one) I got my VM with the current koha-common. I did dpkg -i yourkoha-commom and I've attached what I saw. See initial test run for koha-common .deb (newer one) Looks like you had a 'biblio' instance previously created, with an uninitialized db. I think that is a bug on the installer / upgrader itself. I'd purge Koha-common, delete /etc/Koha/sites and install the .deb. other option would be going through the webinstall process prior To the dpkg upgrade. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6689] Improve styling of table pager
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #12251|0 |1 is obsolete|| --- Comment #6 from Nicole C. Engard neng...@gmail.com --- Created attachment 12295 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12295action=edit [SIGNED-OFF] Bug 6689 [Follow-up] Improve styling of table pager Small correction to add non-vendor-prefixed border radius declaration to make style consistent on newer browsers. To test, view a page with a sorted table and pager controls, like members/readingrec.pl. The pager controls box should show rounded corners in Firefox 15+ Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6689] Improve styling of table pager
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7724] Tests requiring Zebra should be skipped if Zebra isn't set up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7724 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7617] Authority search results should optionally be sorted by system order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7617 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7702] Test for C4::Heading::MARC21 should only run under MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7702 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
