[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Bernardo, Could you create a new bug and submit your patch in it please? Since this patch has been pushed to master, all new followups must be proposed in a new bug. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9443] Use DataTables on MARC frameworks administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9443 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9443] Use DataTables on MARC frameworks administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9443 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14752|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14769 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14769action=edit Bug 9443 - Use DataTables on MARC frameworks administration page Replace the tablesorter plugin with the DataTables plugin on the MARC frameworks administration page. To test, open the MARC frameworks dministration page (Administration - MARC bibliographic framework - MARC structure). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Add the All entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14754|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14770 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14770action=edit Bug 9444 - Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the new system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #15 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Ok, no problem for me. A new bug is cleaner, but this patch do not solve all cases. So, have to be several patches and/or bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14755|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14771 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14771action=edit Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the head for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14756|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14772 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14772action=edit Bug 9446 - Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a th with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the head for sake of consistency. To test, open the Z39.50 servers administration page (Administration - Z39.50 client targets). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9449] Use Datatables on staff client cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9449 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9449] Use Datatables on staff client cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9449 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14758|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14773 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14773action=edit Bug 9449 - Use Datatables on staff client cart Replace the tablesorter plugin with the DataTables plugin in the staff client cart. To test, add multiple items to the Cart in the staff client. View the cart and confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14774 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14774action=edit sort issue Owen, I don't know why this table is not sort correctly. Please see the screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14505|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Works on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Rolando Isidoro rolando.isid...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||rolando.isid...@gmail.com --- Comment #5 from Rolando Isidoro rolando.isid...@gmail.com --- Tested and working in version 3.8.5. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Version|3.10|unspecified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] New: Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Bug ID: 9453 Summary: Update records acording to the new UNIMARCField100Language system preference Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P1 - high Component: Cataloging Assignee: gmcha...@gmail.com Reporter: rolando.isid...@gmail.com CC: m.de.r...@rijksmuseum.nl Depends on: 8347 The solution to bug 8347 introduced a new system preference, UNIMARCField100Language, which allows us to set the value for the mandatory Language of cataloguing field in the UNIMARC field 100 builder form. Before this bug was fixed all values on that field were set to 'fre', so we need to update all the existing records to match the new system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Rolando Isidoro rolando.isid...@gmail.com changed: What|Removed |Added Blocks||9453 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Rolando Isidoro rolando.isid...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |rolando.isid...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #7 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 14775 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14775action=edit [SIGNED-OFF] Bug 7973- Allow for new type of LDAP authentication This patch aims to solve the LDAP bind authentication method. Here are some considerations: - This is a standalone patch, so all the previous submitted ones are rendered obsolete; - LDAP bind authentication is now done in 3 steps: 1 - LDAP anonymous bind; 2 - LDAP search entry for the given username; 3 - LDAP bind with the DN of the found entry + the given password. - The process fails if none or more than 1 entries are found for the given username; - The principal_name setting in koha-conf.xml isn't used anymore; - The patch is backwards compatible, so users already using the previously implemented LDAP bind authentication should be able to use it the same. http://bugs.koha-community.org/show_bug.cgi?id=7973 Signed-off-by: Vitor Fernandes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Attachment #12955|1 |0 is patch|| Attachment #12955|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vfernan...@keep.pt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9418] Some corrections and additions to about.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] New: NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Bug ID: 9454 Summary: NewBasket does not use placeholders in sql Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com NewBasket interpolates variables into the sql string which is used to insert a new basket in the database. This is a bad practice, placeholders should be used instead allowing DBI to quote the input correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 14776 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14776action=edit Proposed patch Patch should not change functional behaviour. To test check baskets still correctly created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9263] Trim barcodes in offline circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) This patch has been pushed to master. Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) This patch has been pushed to master. Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9263] Trim barcodes in offline circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) This patch has been pushed to master. Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) This patch has been pushed to master. Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9455] New: Embedded mysql quotes in sql string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Bug ID: 9455 Summary: Embedded mysql quotes in sql string Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com The sql in C4::Acquisitions::GetBasketgroups contains mysql specific backtick quotes. We have been removing these from sql files. They should be removed from the code for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9455] Embedded mysql quotes in sql string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 14777 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14777action=edit Proposed patch Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 --- Comment #1 from Rolando Isidoro rolando.isid...@gmail.com --- Created attachment 14778 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14778action=edit Script to update field 100a language value with the one defined in the UNIMARC field 100 default language system preference This script aims to allow users to update UNIMARC field 100a language value with the one defined in the UNIMARC field 100 default language system preference in a easy way. The script uses KOHA's API methods to ensure that the DB data remains valid and that it gets reindexed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Rolando Isidoro rolando.isid...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] New: Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Bug ID: 9456 Summary: Add callnumber column to the cart Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com CC: gmcha...@gmail.com Adding a separate callnumber column to the cart will allow it to be sorted by callnumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- This would still be a cool feature and probably not that hard to implement since the searches all have RSS feeds already. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14779 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14779action=edit Bug 9456 - Add callnumber column to the cart Test Plan: 1) Apply patch 2) Add items to the cart 3) View the cart, note the new column for callnumbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9263] Trim barcodes in offline circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #11 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #10) (In reply to comment #8) This patch has been pushed to master. Please try to remember to sign off on patches when QAing. Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel Yes, a Passed-QA-by line would be much appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14779|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14780 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14780action=edit Bug 9456 - Add callnumber column to the cart Test Plan: 1) Apply patch 2) Add items to the cart 3) View the cart, note the new column for callnumbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2645] Put Total Due at top of Fines page/seperate paid from unpaid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2645 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- I still have libraries ask for this in training - when the patron has a long history, it's a lot to scroll through. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] why is there a 'do not notify' option?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- This still confuses people in training. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9457] New: Ordering branches should be case independent (2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457 Bug ID: 9457 Summary: Ordering branches should be case independent (2) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: bgkrie...@gmail.com Reporter: bgkrie...@gmail.com On the footsteps of Bug 5634. Some libraries use lower case upper case in branch description. The list is ordered case sensitively, it's hard to read. Use C4::Branch::GetBranchesLoop() to get an ordered list of branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Robin, is there a chance you can look at this again? I think it would be a nice improvment. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] New: Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Bug ID: 9458 Summary: Add sorting to lists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com CC: m.de.r...@rijksmuseum.nl Add the ability to sort results on lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14781 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14781action=edit Bug 9458 - Add sorting to lists Test Plan: 1) Apply patch 2) View list in staff interface, try sorting by title, then author 3) Repeat 2 with same list in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 14782 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14782action=edit Screenshot of cart with multi-call-number title I question whether this is universally useful, given the fact that call number is item-level and each title can have any number of call numbers. This screenshot shows a made-up example. I don't know how divergent one system's call numbers might be, but if you test with this kind of data it's clear that the sort will be based on the first call number in the list of many. The same is true for location, of course. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 14783 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14783action=edit Proposed alternate structure What about this instead? I didn't test the nested sorting with DataTables, but I think it is doable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
||m
--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hi Jared,
Great patches!
In a first time I tested the patch and do not find anything to say.
It seems working well.
So I tried to find something to discuss, but I just found stuffs to quibble ;)
e.g.
1/ I don't understand your test (t/Cache.t):
ok(exists $myhash-{'anotherkey'}, 'Cache reset properly');
2/ qa-tools had helped me! :)
* Koha/Cache.pm
FAIL
pod FAIL
*** ERROR: =over on line 281 without closing =back (at head2) in file
Koha/Cache.pm
forbidden patterns FAIL
The patch introduces a forbidden pattern: withespace character (369)
And I was going to sign off yours patches (bug 9434 and this one), but I had a
last idea : check the perfs.
I think we expect from this patch a gain of performance.
(Results produce by NYTProf)
On the preferences.pl page (admin/preferences.pl?tab=cataloguing) I got:
with the master branch:
admin/preferences.pl for 839ms (of 922ms), executing 180787 statements and
30350 subroutine calls in 175 source files and 39 string evals.
with bug 9434 and bug 9089:
admin/preferences.pl for 1.13s (of 1.27s), executing 300952 statements and
53214 subroutine calls in 183 source files and 39 string evals.
On a search result page (catalogue/search.pl?q=d) I got:
with the master branch:
catalogue/search.pl for 1.51s (of 1.85s), executing 659967 statements and
122242 subroutine calls in 119 source files and 29 string evals.
Statements | time | Module
249908 147ms Template/Parser.pm
140543 124ms MARC/Field.pm
95389 80.1ms C4/Biblio.pm
255270.9ms C4/Reserves.pm
23 67.4ms CGI/Session/Driver/mysql.pm
19488 37.7ms MARC/Record.pm
with bug 9434 and bug 9089:
catalogue/search.pl for 2.59s (of 3.19s), executing 1136765 statements and
218314 subroutine calls in 131 source files and 29 string evals.
174117 249ms Carp.pm
161178 153ms Compress/Raw/Zlib.pm
249908 139ms Template/Parser.pm
15360 134ms Compress/Zlib.pm
5067130ms Storable.pm
140543 125ms MARC/Field.pm
3378100ms Koha/Cache.pm
It will be very difficult to gain 1 second by caching some others stuffs.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8266] remove location from pull down on search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Also, the one a the top doesn't seem to work still ... a bug i can't find though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard oleon...@myacpl.org --- I have some issues with this: In the staff client: - Sortable columns do not have a visual indicator that they are sortable. They should have an icon like JavaScript-sorted table headers do. - Only DESC sorting is implemented. This is contrary to user expectations based on how table sorting is handled everywhere else in Koha. - How do you sort by call number if there can be any number of call numbers attached to a particular title? In the OPAC: - Sorting depends on JavaScript, but isn't hidden if JavaScript is disabled. Two options here: 1. Hide the sorting form by default and reveal it via JS. 2. Add a submit button to the sort form and hide it with JS. - The call number sort here is just as problematic as in the staff client. I assume that server-side sorting was chosen because these interfaces have server-side pagination. Although it depends on JavaScript, I like the DataTables option for sorting, particularly in the staff client, because it keeps things consistent. I wouldn't reject a patch for not using DataTables, but I think it should be considered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Just a remark about the multiple items: See bug report 8032. The sorting on call number works on the first item (just an arbitrary choice). But all call numbers are listed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3001] Add call number to staff output of virtual shelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3001 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |RESOLVED CC||m.de.r...@rijksmuseum.nl Resolution|--- |FIXED --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- See also report 8032. All call numbers are listed. The list can be sorted on call number; in that case the first one is used. This report can be closed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 --- Comment #2 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 14784 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14784action=edit Bug 9453: Update records acording to the new UNIMARCField100Language system preference Script to update field 100a language value with the one defined in the UNIMARC field 100 default language system preference This script aims to allow users to update UNIMARC field 100a language value with the one defined in the UNIMARC field 100 default language system preference in a easy way. The script uses KOHA's API methods to ensure that the DB data remains valid and that it gets reindexed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Attachment #14778|1 |0 is patch|| Attachment #14778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 --- Comment #3 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 14785 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14785action=edit [SIGNED-OFF] Bug 9453: Update records acording to the new UNIMARCField100Language system preference Script to update field 100a language value with the one defined in the UNIMARC field 100 default language system preference This script aims to allow users to update UNIMARC field 100a language value with the one defined in the UNIMARC field 100 default language system preference in a easy way. The script uses KOHA's API methods to ensure that the DB data remains valid and that it gets reindexed. Signed-off-by: Vitor Fernandes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Attachment #14784|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vfernan...@keep.pt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9434] Static variables used for caches are not Plack-friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9434
Jared Camins-Esakov jcam...@cpbibliography.com changed:
What|Removed |Added
Attachment #14764|0 |1
is obsolete||
--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14786
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14786action=edit
Bug 9434: Introduce new tied cache system
At the moment we cache numerous pieces of information in module-level
variables which then do not get updated in other threads/processes when
they are changed by the user. This is a serious usability issue.
Examples of this include the way we treat sysprefs (there is now a
method to disable the syspref cache, but by default it is enabled),
notices, frameworks, field mappings, and koha-conf.xml, at least.
This patch sets the stage for eliminating this problem by making it
possible to convert module-level cache variables into variables that
are actually backed by whatever caching system may be configured. This
is done through a special Koha::Cache::Object class which can be tied
to the variables that are being used for caching and provided with a
constructor method/closure to allow the cache to be reloaded when it
expires. For example:
my $cache= Koha::Cache-new();
my $data = 'whatever';
my $variable = Koha::Cache-create_scalar(
{
'key' = 'whatever',
'timeout' = 2,
'constructor' = sub { return $data; },
}
);
print $$variable\n; # Prints whatever
The one change this necessitates for accessing the data is that the
variable must be dereferenced an additional time before use (i.e.
$$variable instead of $variable). There is no difference when the
variable tied is a hash (created with Koha::Cache-create_hash). This
is a small price to pay for Koha working in a multi-threaded, persistent
environment. This change will also make caching easier in general.
CHI was incompatible with the variable tying, so this patch also removes
the dependency on CHI, using instead Cache::Memcached::Fast,
Cache::FastMmap, and Cache::Memory, when they are available.
To test:
1) Apply patch.
2) Run unit test t/Cache.t (after setting the MEMCACHED_SERVERS and
CACHING_SYSTEM environment variables). As no changes were made to
the tests already in that file, this passing demonstrates there
are no regressions.
3) With memcached caching enabled (you must set the MEMCACHED_SERVERS
and CACHING_SYSTEM environment variables) and DEBUG turned on (i.e.
the DEBUG environment variable set to 1), try running a report via
the web service ([intranet]/cgi-bin/koha/svc/report?id=1 and check
your web server logs to confirm that there are messages like
get_from_cache for intranet:report:id:1 in them.
4) If the reports worked, sign off.
NOTE: Technically you could test this without needing memcached by
installing libcache-fastmmap-perl and setting CACHING_SYSTEM to
'fastmmap' instead of 'memcached'. You could also install libcache-perl
and set CACHING_SYSTEM to 'memory' but there would be little point as
the cached variables would go out of scope in between runs.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9457] Ordering branches should be case independent (2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457 --- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 14787 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14787action=edit Bug 9457: [ENH] Ordering branches should be case independent (2) This patch replace use of CGI::scroll_list() to show list of branches. In two files, marc21_linking_section.pl and unimarc_field_4XX.pl, the scrolling list is created but not used in the template file, so the code is removed. Also minor renaming/normalizing of variables. To test: 1) Install with some branches, records and patrons 2.1) Select a record, click 'Place hold', select user, there is a library pull-down next to 'Pickup at:', list is ordered case sensitive 2.2) Go to Reports Average loan time, next to Library is a pull-down, list without order 2.3) Go to Reports Catalog by item type, next to 'Select a library' is a pull-down, list is ordered case sensitive 2.4) This is tricky, go to Reports home, change last part of URL 'reports-home.pl' with 'manager.pl?report_name=issues_by_borrower_category' (can't find a direct link), next to 'Select a library' is a library pull-down, list without order 2.5) Edit/Add a patron, on section 'Library management' there is a library pull-down, case sensitive 2.6) OPAC, as logged user, make a suggestion or hold, there is library pull-down, correct order 3) Apply the patch 4.1) Repeat 2.1), correctly ordered list 4.2) Repeat 2.2), correctly ordered list 4.3) Repeat 2.3), correctly ordered list 4.4) Repeat 2.4), correctly ordered list 4.5) This is a bit more work There are 3 possible situations to test: A) No branches, must show a message that are no libraries defined B) New patron, must show a correctly ordered list of branches, current branch selected C) Edit patron, must show a correctly ordered list of branches, patron branch selected 4.6) Small changes on variable names, so retest 2.6) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9457] Ordering branches should be case independent (2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Change sponsored?|--- |Sponsored --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #3) Just a remark about the multiple items: See bug report 8032. The sorting on call number works on the first item (just an arbitrary choice). But all call numbers are listed. You are correct. However, the callnumber is what the sponsor specifically wants. I'd say it's better than nothing, and in many cases the items will all have the same callnumber which makes the issue moot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- In the staff client: - Sortable columns do not have a visual indicator that they are sortable. They should have an icon like JavaScript-sorted table headers do. - Only DESC sorting is implemented. This is contrary to user expectations based on how table sorting is handled everywhere else in Koha. I'll amend the patch to make it follow the conventions more closely. - How do you sort by call number if there can be any number of call numbers attached to a particular title? I believe it's sorted by the callnumber highest ranked for that sorting. In the OPAC: - Sorting depends on JavaScript, but isn't hidden if JavaScript is disabled. Two options here: 1. Hide the sorting form by default and reveal it via JS. 2. Add a submit button to the sort form and hide it with JS. I'll go with two since it will keep the feature for non-js enabled browsers. I assume that server-side sorting was chosen because these interfaces have server-side pagination. Although it depends on JavaScript, I like the DataTables option for sorting, particularly in the staff client, because it keeps things consistent. I wouldn't reject a patch for not using DataTables, but I think it should be considered. I wanted to use datatables, but when I discovered the server side paging I had to change my method. The best way to handle this would be to rip it out completely and rewrite is as an AJAX-calling DataTable, but that would require some serious development which is a bit out of line with just adding the ability to sort the results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 --- Comment #4 from Rolando Isidoro rolando.isid...@gmail.com --- Tested the patch in a standard Koha 3.8.5 installation and it works as described and expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] New: Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Bug ID: 9459 Summary: Use DataTables on hold ratios report page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/reserveratios.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The hold ratios report uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9459] Use DataTables on hold ratios report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9459 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14788 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14788action=edit Bug 9459 - Use DataTables on hold ratios report page Replace the tablesorter plugin with the DataTables plugin on the hold ratios report page. To test, open the hold ratios report (Circulation - Hold ratios). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9316] Add Nginx install options with plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14381|0 |1 is obsolete|| --- Comment #31 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14789 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14789action=edit Bug 9316: Add ability to install/configure nginx Amended permissions for plack socket and fixed type Altered mount location for opac to reflect current koha path settings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14781|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14790 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14790action=edit Bug 9458 - Add sorting to lists Test Plan: 1) Apply patch 2) View list in staff interface, try sorting by title, then author 3) Repeat 2 with same list in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9460] New: Use DataTables on transfers to receive report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9460 Bug ID: 9460 Summary: Use DataTables on transfers to receive report page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/transferstoreceive.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The transfers to receive page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14790|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14791 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14791action=edit Bug 9458 - Add sorting to lists Test Plan: 1) Apply patch 2) View list in staff interface, try sorting by title, then author 3) Repeat 2 with same list in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9458] Add sorting to lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14791|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14792 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14792action=edit Bug 9458 - Add sorting to lists Test Plan: 1) Apply patch 2) View list in staff interface, try sorting by title, then author 3) Repeat 2 with same list in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9460] Use DataTables on transfers to receive report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9460 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9460] Use DataTables on transfers to receive report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9460 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14793 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14793action=edit Bug 9460 - Use DataTables on transfers to receive report page Replace the tablesorter plugin with the DataTables plugin on the transfers to receive report page. To test, open the transfers to receive report page (Circulation - Transfers to receive). Confirm that table sorting works correctly on each of the tables. In this configuration there is no filtering or pagination. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #34)
1/ I don't understand your test (t/Cache.t):
ok(exists $myhash-{'anotherkey'}, 'Cache reset properly');
This is to confirm that after clearing a hash cache-tied variable values can
be retrieved again. The cache was reset, but even after getting reset, the
'anotherkey' value can be retrieved
So the following test is not more complete?
ok($myhash-{'anotherkey'} eq anothervalue, 'Cache reset properly');
I think we expect from this patch a gain of performance.
No, definitely not. I think I mentioned this in my commit message. On an
low-load system, caching for something as simple as sysprefs will be slower
than just retrieving the data from MySQL without any cache. We'll see a
performance improvement with frameworks/languages, which are slow to load
from the database, but with anything that can be loaded from the database,
the cache is going to be slower than MySQL. There are two reasons why
caching sysprefs is important:
1) scalability-we retrieve dozens of sysprefs on every single page load.
Load ten pages simultaneously, and that's 200+ sysprefs requested. Load a
hundred pages, and you have thousands of database requests simultaneously,
just for system preferences.
2) right now the way we do caching is not thread-safe, and you get
inconsistent results depending on what server thread you hit.
We could probably improve performance by changing the serialization method
used for caching (JSON::XS is supposed to blow everything else out of the
water, performance-wise), but for an initial patch, I figured something
using the default Storable serialization would be best.
You mentioned in the commit message that the patch will not improve
performance, not that it will be degrade them :)
I thought a gain after a 2nd refresh of the page would have observed, but it
was not the case.
1 second is so long (regarding the original 1.5s), I am wondering how it is
possible to recover it.
It will be very difficult to gain 1 second by caching some others stuffs.
If people are not concerned about scalability, they can simply disable the
cache. That is one of the other advantages of this implementation. If you
don't want it, you can disable it with minimal impact on performance.
By disabling you mean remove or unset the CACHING_SYSTEM env variable?
I am not a supporter of sysprefs but is it not a good way to have a quick
switch?
Sorry for all my questions, I am not an expert of cache issues :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Rolando, Please fix the following perlcritic issues: Bareword file handle opened at line 71, column 5. See pages 202,204 of PBP. Two-argument open used at line 69, column 5. See page 207 of PBP. Bareword file handle opened at line 69, column 5. See pages 202,204 of PBP. + the script has to display the help if it is called without parameter. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089
--- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #35)
So the following test is not more complete?
ok($myhash-{'anotherkey'} eq anothervalue, 'Cache reset properly');
is($myhash-{'anotherkey'}, 'anothervalue', 'Cache reset properly');
would work as well. I used defined because the important issue is that the
value is being set in some way.
By disabling you mean remove or unset the CACHING_SYSTEM env variable?
I am not a supporter of sysprefs but is it not a good way to have a quick
switch?
Right. It's funny you should mention adding a syspref. One of my follow-ups
will be adding a syspref for enabling/disabling caching, and, eventually,
eliminating the need for environment variables at all. One of the reasons I
decided to write Koha::Cache::Object, even though it meant losing CHI, is that
using caching like this means that we could control caching from a syspref or
koha-conf.xml and still be able to cache sysprefs and koha-conf.xml.
You can also disable the syspref cache specifically using
C4::Context-disable_syspref_cache();
Sorry for all my questions, I am not an expert of cache issues :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #4) Created attachment 14783 [details] Proposed alternate structure What about this instead? I didn't test the nested sorting with DataTables, but I think it is doable. If it can do nested sorting that would be perfect! Do you a patch you can upload? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9461] New: Use DataTables on holds awaiting pickup report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9461 Bug ID: 9461 Summary: Use DataTables on holds awaiting pickup report page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/waitingreserves.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The holds awaiting pickup page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] New: Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Bug ID: 9462 Summary: Use DataTables on patron detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The patron detail page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14795action=edit Bug 9462 - Use DataTables on patron detail page Replace the tablesorter plugin with the DataTables plugin on the patron detail page. To test, open a patron detail page for a patron who has checkouts, holds, and relatives' checkouts. Confirm that table sorting works correctly for each of those three tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] New: Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Bug ID: 9463 Summary: Use DataTables on patron sent notices page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/notices.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The patron sent notices page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14796action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9464] New: Update DataTables configuration on patron statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9464 Bug ID: 9464 Summary: Update DataTables configuration on patron statistics page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/statistics.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The patron statistics page still has a link to the old tablesorter plugin which should be removed. The DataTables configuration can be changed in such a way that empty filter boxes don't appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9464] Update DataTables configuration on patron statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9464 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9464] Update DataTables configuration on patron statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9464 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14797action=edit Bug 9464 - Update DataTables configuration on patron statistics page This page removes an unnecessary link to the old tablesorter plugin and changes the configuration details of the DataTables plugin so that an empty filter box doesn't appear as dot above and below the table (an empty div with a 1-pixel border). To test, open the patron statistics page for a patron who has entries to display. Sorting should work normally and no dots should be seen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9465] New: Use DataTables on update child to adult patron page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9465 Bug ID: 9465 Summary: Use DataTables on update child to adult patron page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/update-child.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The update child to adult patron page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9465] Use DataTables on update child to adult patron page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9465 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14798 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14798action=edit Bug 9465 - Use DataTables on update child to adult patron page Replace the tablesorter plugin with the DataTables plugin on the update child to adult patron page. Added default sort by patron category description (ascending). To test, open a patron with a child category type. Choose the 'Update child to adult patron' item from the 'More' menu. Confirm that table sorting works correctly in the popup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9465] Use DataTables on update child to adult patron page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9465 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9466] New: Use DataTables on saved reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Bug ID: 9466 Summary: Use DataTables on saved reports page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl?phase=Use saved OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The saved reports page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9466] Use DataTables on saved reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9466] Use DataTables on saved reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14799action=edit Bug 9466 - Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports Use saved). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9467] New: Use DataTables on catalog by item type report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9467 Bug ID: 9467 Summary: Use DataTables on catalog by item type report page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/manager.pl?report_name=itemtypes OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The catalog by item type report uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] New: Add ability to hide items from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Bug ID: 9468 Summary: Add ability to hide items from purchase suggestions forms Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9467] Use DataTables on catalog by item type report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9467 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14800action=edit Bug 9467 - Use DataTables on catalog by item type report page Replace the tablesorter plugin with the DataTables plugin on the catalog by item type report page. To test, run the catalog by item type report (Reports - Catalog by item type). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9467] Use DataTables on catalog by item type report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9467 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide items from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14801action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for Item type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
