[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl --- syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 323, near /) syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 327, near $_} Global symbol @loop requires explicit package name at /usr/share/koha/testclone/admin/aqbudgets.pl line 352. Unmatched right curly bracket at /usr/share/koha/testclone/admin/aqbudgets.pl line 357, at end of line syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 357, near } Unmatched right curly bracket at /usr/share/koha/testclone/admin/aqbudgets.pl line 376, at end of line syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 376, near } Execution of /usr/share/koha/testclone/admin/aqbudgets.pl aborted due to compilation errors. Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18298|0 |1 is obsolete|| --- Comment #97 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18793 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18793action=edit [PASSED-QA] Bug 7688: Change subscription numbering pattern and frequencies Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18299|0 |1 is obsolete|| --- Comment #98 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18794action=edit [SIGNED-OFF] Bug 7688: Set firstacquidate in updatedatabase if it's not set Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|koha.sek...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- The status of 7167 is not clear to me. That makes testing this patch even harder.. What I read here, sounds good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #16420|0 |1 is obsolete|| --- Comment #33 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18796action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #16421|0 |1 is obsolete|| --- Comment #34 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18797action=edit Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #16422|0 |1 is obsolete|| --- Comment #35 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18798 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18798action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #36 from M. de Rooy m.de.r...@rijksmuseum.nl --- One warning, no complaints from qa-tools. Argument isn't numeric in numeric lt () at /usr/share/koha/testclone/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt line 241. Seems not to be introduced by your patches, though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl --- I actually miss a test plan for this report. I have the impresssion that the opac change is only visible under specific circumstances (pref value and/or unimarc??) This needs more information/documentation. Please add. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #75 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18801action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #76 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18802 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18802action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #77 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18803 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18803action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #16426|0 |1 is obsolete|| Attachment #16427|0 |1 is obsolete|| Attachment #16428|0 |1 is obsolete|| Attachment #16429|0 |1 is obsolete|| Attachment #16430|0 |1 is obsolete|| --- Comment #73 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18799action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger-new; $log-debug(This is a debug message); $log-info(This is an information); $log-error(This is an error !); The Logger constructor can take an hash reference with file and level to define a filepath or a log level. For a log level = warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context-logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain paul.poul...@biblibre.com Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #74 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18800action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #38 from M. de Rooy m.de.r...@rijksmuseum.nl --- See this in the rebase of kohastructure: + `itemnumber` text default NULL, Should not be reintroduced.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #78 from M. de Rooy m.de.r...@rijksmuseum.nl --- Trivial rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #14461|0 |1 is obsolete|| --- Comment #25 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18805 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18805action=edit Bug 8993: Follow-up - LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #14460|0 |1 is obsolete|| --- Comment #24 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18804 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18804action=edit Bug 8993: LDAP authentication improvements Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16659|0 |1 is obsolete|| --- Comment #26 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18806 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18806action=edit Bug 8993 - my attempt to get this module working Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #28 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18808 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18808action=edit Bug 8993: Add branchcode and categorycode mappings for sample module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16796|0 |1 is obsolete|| --- Comment #27 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18807 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18807action=edit Bug 8993 [Follow-up] update and replicate options used at wrong place Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #29 from Julian Maurice julian.maur...@biblibre.com --- (In reply to comment #23) OOH, now that I have had enough sleep, is there really a good reason to introduce completely different configuration for LDAP server? Adding branch, transform and few other tags into existing configuration would probably result in simpler code and easier upgrade path. If you are refering to the use of xml attributes instead of xml tags, I think you can use the one you prefer, as: ldapserver update=1 / and ldapserver update1/update /ldapserver will both result in a hash: { update = 1 } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 --- Comment #1 from Amit amitddng...@gmail.com --- Created attachment 18809 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18809action=edit The ability to update Acquisitions with credit notes, with the option to link to an existing invoice. To Test: 1) Create a basket. 2) Create some orders underbakset and close the basket. 3) Receive the shipment give invoice number. 4) For entering creditnote against bookseller click on invoices link on left hand side. 5) Search invoice number,title,author,isbn etc. 6) Click on Credit note link. 7) Enter credit amount, date, notes etc and click on Save button. 8) You can edit and delete also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 --- Comment #2 from Amit amitddng...@gmail.com --- Created attachment 18810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18810action=edit Adding new table aqcreditnotes Adding new table aqcreditnotes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Amit amitddng...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Iming Chan imingc...@yahoo.com.au changed: What|Removed |Added Change sponsored?|--- |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #79 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Looks quite promising! Some questions on details: You (almost) follow common levels like: LOG_EMERG system is unusable LOG_ALERT action must be taken immediately LOG_CRIT critical conditions LOG_ERRerror conditions LOG_WARNINGwarning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message Why no alert level? Note that LogLite also supports 8 levels (0=unusable, 1=close to unusable) Displaying 1-Unusable is not intuitively clear (in the prefs)? If you include html comments in staff doc-head-open, why not in opac side? Note that you add a test in opac-search (info statement). Is the eval require+die for Koha::Utils::Logger in the third patch really an improvement? I am no packaging expert :) But is adding this module in install_misc/debian.packages enough? Changing status to reflect need for clarification (or adjustment). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18797|0 |1 is obsolete|| --- Comment #40 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18812 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18812action=edit [SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18796|0 |1 is obsolete|| --- Comment #39 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18811action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18798|0 |1 is obsolete|| --- Comment #41 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18813 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18813action=edit [SIGNED-OFF] Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Iming Chan imingc...@yahoo.com.au changed: What|Removed |Added CC||imingc...@yahoo.com.au --- Comment #5 from Iming Chan imingc...@yahoo.com.au --- Could we also add the option of using 14-digit barcodes with Mod 10 check digit? This barcode style is very common from other ILMS, including our old one! Perhaps we can specify the start of the patron barcode like 2009400123456? with the question mark (?) indicates the position of the check digit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18737|0 |1 is obsolete|| --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18814 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18814action=edit Bug 10428 - undefined check in add additem.pl In additem.pl, in the code that generates item form you find : @values = $itemrecord-field($tag)-subfield($subtag) if ($itemrecord defined($itemrecord-field($tag)-subfield($subtag))); This patch adds the check of $itemrecord-field($tag) undef. I did not found a way to test it because item tag is always defined when editing an item, but it would be safer/prettier to add this check. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passed-QA-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18689|0 |1 is obsolete|| --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18815 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18815action=edit Bug 10406 - Remove obsolete CSS related to YUI autocomplete staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. Signed-off-by: Srdjan srd...@catalyst.net.nz Passed-QA-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: For simplification, I would suggest not to copy information and create redundancy ;) but just explain what is a local use preference. What all the other pages do, is already there. Any change to the other page will be forgotten for your new page.. Or put them in an include? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #42 from Julian Maurice julian.maur...@biblibre.com --- Patches rebased on master serials.itemnumber is no longer added by these patches Test plan: - Search for a subscription and go to serial collection page - check some serials and click edit - modify text under published on (text) column and save - in opac, go to record detail, then click subscriptions tab » More details » Full history tab - you should see the text you entered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7498] Cloning a budget, enable change of description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Passed QA Patch complexity|--- |Small patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Oops sorry Maxime, I had a unique key on my aqbudgetperiod.description field, but it does not exist on the current master! So all works as described. Unit tests are presents and a big bloc of code is moved in a pm file. Just 3 tabulation characters in the .t file, my signoff patch will fix that. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7498] Cloning a budget, enable change of description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18341|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18816 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18816action=edit Add new features and tests to the budget duplication : * Allow to enter a new name for the duplicate * Add option to transfer the not received orders in the budget copy * Transfer the duplication code in Budgets.pm to allow easier testing. In doing this I removed the code block # deal with any children because I just don't understand it and it had a typo in the table name ('aqcudgets'), so I figured it was useless code * Update Budgets.t with the right field names, test the data more and tests the duplication code. Sadly I didn't write tests for the order transfers because it just depends on too much stuff :/ http://bugs.koha-community.org/show_bug.cgi?id=7498 Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Impressive. But do a grep with case insensitive please too: my $marcFlavour (no blocker, someone using this variable in bulkmarcimport) More serious: misc/migration_tools/switch_marc21_series_info.pl:if (C4::Context-preference('M ARCFLAVOUR') eq 'UNIMARC') { t/db_dependent/Linker_FirstMatch.t:if (C4::Context-preference('MARCFlavour' ) eq 'UNIMARC') { I have my doubts on your changes in xt/fix-old-fsf-address.exclude Here you are changing folder names. Please check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7498] Cloning a budget, enable change of description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18816|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18817 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18817action=edit Add new features and tests to the budget duplication : * Allow to enter a new name for the duplicate * Add option to transfer the not received orders in the budget copy * Transfer the duplication code in Budgets.pm to allow easier testing. In doing this I removed the code block # deal with any children because I just don't understand it and it had a typo in the table name ('aqcudgets'), so I figured it was useless code * Update Budgets.t with the right field names, test the data more and tests the duplication code. Sadly I didn't write tests for the order transfers because it just depends on too much stuff :/ http://bugs.koha-community.org/show_bug.cgi?id=7498 Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Your changes in updatedatabase need correction too (two updates!!) +$DBversion = 3.13.00.XXX; +if ( CheckVersion($DBversion) ) { +$dbh-do(UPDATE systempreferences SET variable = 'marcflavour' WHERE variable = 'marcflavour'); +print Upgrade to $DBversion done (Bug 10329 - Rename system preference marcflavour to marcflavour)\n; +SetVersion ($DBversion); +} + $DBversion = 3.00.00.009; if (C4::Context-preference(Version) TransformToNum($DBversion)) { @@ -3259,7 +3266,7 @@ if (C4::Context-preference(Version) TransformToNum($DBversion)) { $dbh-do(qq{ ALTER TABLE deleteditems ADD UNIQUE INDEX deleteditemsstocknumberidx (stocknumber); }); -if (C4::Context-preference('marcflavour') eq 'UNIMARC'){ +if (C4::Context-preference('marcflavour') eq 'UNIMARC'){ $dbh-do(qq{ INSERT IGNORE INTO marc_subfield_structure (frameworkcode,tagfield, tagsubfield, tab, repeatable, mandatory,kohafield) SELECT DISTINCT (frameworkcode),995,j,10,0,0,items.stocknumber from biblio_framework ; @@ -6971,6 +6978,13 @@ if(CheckVersion($DBversion)) { SetVersion ($DBversion); } +$DBversion = 3.13.00.XXX; +if ( CheckVersion($DBversion) ) { + $dbh-do(UPDATE systempreferences SET variable = 'MarcFormat' WHERE variable = 'marcflavour'); + print Upgrade to $DBversion done (Bug 10329 - Rename system preference marcflavour to MarcFormat)\n; + SetVersion ($DBversion); I did get two lines indeed when running this: Upgrade to 3.13.00.XXX done (Bug 10329 - Rename system preference marcflavour to marcflavour) Upgrade to 3.13.00.XXX done (Bug 10329 - Rename system preference marcflavour to MarcFormat) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #95 from Julian Maurice julian.maur...@biblibre.com --- This should not be a system preference. It should be something that's set in the koha-conf.xml. Library staff should not be modifying it, as they can't ensure that directories are set up with the right permissions. This is the same for all other system preferences that contain a path. So why this one is different? Moreover, I don't think a preference for a cataloguing plugin should be in koha-conf.xml (its place is not in global system preferences either but there is no other place) I'm not opposed to move this pref in koha-conf.xml, I just want to understand :) Also I would like to have someone else's opinion before writing a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #96 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #95) This should not be a system preference. It should be something that's set in the koha-conf.xml. Library staff should not be modifying it, as they can't ensure that directories are set up with the right permissions. This is the same for all other system preferences that contain a path. So why this one is different? At 1st glance, I had the same reaction. But there is a difference : writing ! Other systempreferences only require reading (opacusercss for example), this one will write, and there is no other syspref in this case I think. Moreover, I don't think a preference for a cataloguing plugin should be in koha-conf.xml (its place is not in global system preferences either but there is no other place) I hesitate... what I think is that this preference don't need to be setup during installation, because it's an additional feature that most libraries won't use. (like for ldap for example : there are default values, but the koha-conf.xml must be edited manually if you want to enable it) I'm not opposed to move this pref in koha-conf.xml, I just want to understand :) Also I would like to have someone else's opinion before writing a patch. my conclusion would be: * move the uploadPath to koha-conf.xml * add uploadPathuploadPath (without any value) to default koha-conf * add a disclaimer on the plugin page if uploadPath is empty, saying something like WARNING : your server is not properly setup, it won't work. uploadPath must be set in koha configuration file (wait for another feedback before writing the patch) PS: will this patch make it's way one day ? :\ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Would it be more clear to make the scope of this report little bit wider? 1/season (spring, summer, etc.) [do not mention quarter anymore] 1/quarter (three months) [if quarter is harder, we could also eliminate it] BTW I am curious: Why not let every 3 months just cover both? Extending this report with: 1/week= weekly 1/month = monthly 1/2 weeks is not completely clear (0,5 or 2?): 1/two weeks idem: 1/three weeks, 1/two three four months, 1/two years BTW: What do you think of every instead of 1/ So: every 2 weeks, every 3 months etc. each year or annually instead of 1/year 2/year: every 6 months, semiannual (?) 2/day= twice a day Another step: We could also just say the frequency is two weeks etc. instead of prefix 75% of the list with 'every'. So list: daily, 1 week, 2 weeks, 1 month, .., 4 months, 6 months, 1 year, 2 years What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] New: Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Bug ID: 10439 Summary: Cannot modify the notice's library Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com To reproduce: - switch on the the IndependentBranches pref - go on Home › Tools › Notices Slips - click on a edit link - change the library and save = changes are not saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18818 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18818action=edit Bug 10439: FIX modify the library for a notice. 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - switch on the IndependentBranches pref - try to change the library for a notice. Before the patch, no change is applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff URL||tools/letter.pl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Marcel, thanks for your comments! (In reply to comment #79) Why no alert level? Note that LogLite also supports 8 levels (0=unusable, 1=close to unusable) I will propose a new patch adding the alert level. Displaying 1-Unusable is not intuitively clear (in the prefs)? I created a wiki page, maybe should we add a link to this page in the syspref description? If you include html comments in staff doc-head-open, why not in opac side? Note that you add a test in opac-search (info statement). Kyle wrote this part (patch in comment 27), so I don't really why but I think it could be a security issue to display the Koha logs at the OPAC. Is the eval require+die for Koha::Utils::Logger in the third patch really an improvement? It was asked by Katrin in order to avoid an internal server error (see comment 36). I am no packaging expert :) But is adding this module in install_misc/debian.packages enough? I think so, but not really sure. Switch back to Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #81 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18819 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18819action=edit Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #82 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18820 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18820action=edit Bug 8190: Add the 'alert' level. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18821 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18821action=edit Bug 10386: VirtualShelves.t needs some more adjustments Most important: Does no longer delete all shelves! Checks if there are ten borrowers for testing. But even works without them :) When creating or modifying lists, takes name clashes into consideration. Small change to _CheckShelfName in VirtualShelves module. Making it possible to check a name for a list whose owner has been set to NULL. Note that a test like field=? with undef for placeholder will not work in MySql. Test plan: How do you test a test? Well, you could run it on various databases.. But for real hacking, you could also add some debug lines. I tested this by forcing 10 undefs in @borrowernumbers. And by overwriting the return value of randomname with an existing name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10440] New: During receipting for any holds attached to items being receipted, to be identified during the receipting process.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Bug ID: 10440 Summary: During receipting for any holds attached to items being receipted, to be identified during the receipting process. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng...@gmail.com During receipting for any holds attached to items being receipted, to be identified during the receipting process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Amit amitddng...@gmail.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||10441 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10441] New: Testing AddShare in VirtualShelves.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Bug ID: 10441 Summary: Testing AddShare in VirtualShelves.t Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl Depends on: 9032, 10386 Builds upon bug 10386 and bug 9032. Adds a unit test for routine AddShare. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||10441 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10441] Testing AddShare in VirtualShelves.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10441] Testing AddShare in VirtualShelves.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18822 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18822action=edit Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. Test plan: Run the test. All passed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #0) Will also add two small new tests for AddShare from bug 9032. This patch does not depend on bug 9032. The tests for AddShare are added on bug 10441. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Testing AddShare in |UT: Testing AddShare in |VirtualShelves.t|VirtualShelves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #83 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #81) Created attachment 18819 [details] [review] Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC I understand the changes for opac and using the Koha plugin logic. But I still cannot see the log message in the opac document. (Just empty for opac-search) Are you sure that the statement Logger.get_messages works this way? I tried logger lc too without results. It seems not to work.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 --- Comment #5 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 18823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18823action=edit Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- New patch proposed because even publication year does not need to be a datepicker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #18681|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] New: Remove references to non-standard error class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Bug ID: 10442 Summary: Remove references to non-standard error class Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org There are a few references in the templates to a very old error class which should not be used anymore. Generally speaking 'div class=dialog alert' should be used instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #0) In additem.pl, in the code that generates item form you find : @values = $itemrecord-field($tag)-subfield($subtag) if ($itemrecord defined($itemrecord-field($tag)-subfield($subtag))); This code is missing the check of $itemrecord-field($tag) undef. I did not found a way to test it because item tag is always defined when editing an item, but it would be safer/prettier to add this check. Just double-checking: did you run into any situation where the absence of the test resulted in a user-visible problem? It occurs to me that intentionally damaging the contents of the LastCreatedItem cookie would be a way of exercising this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard error class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard error class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 18824 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18824action=edit Bug 10442 - Remove references to non-standard error class The CSS for div class=error is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard div class=dialog alert. This patch also corrects some minor HTML validity and capitalization errors in the changed templates. Testing each error condition in all the modified temlates is probably overkill for the minor changes made in this patch. Markup has simply been changed to use alternate existing styles. Visual confirmation of the markup changes is probably sufficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7498] Cloning a budget, enable change of description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Failed QA CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Test cases do not pass: $ prove -v t/db_dependent/Budgets.t ... not ok 24 - 2 budgets for that budget period : the original and his child # Failed test '2 budgets for that budget period : the original and his child' # at t/db_dependent/Budgets.t line 119. # got: '1' # expected: '2' ok 25 ok 26 ok 27 not ok 28 # Failed test at t/db_dependent/Budgets.t line 123. # got: 'P�riodiques' # expected: 'Serials' ok 29 - DelBudget returned 1 # Looks like you failed 2 tests of 29. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/29 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6281] Bug in LCC sort routine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton gmcha...@gmail.com --- Pushed to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Version|3.10|master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Summary|categorycode and branchcode |categorycode and branchcode |should be required for |should be required when |patrons |adding patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 18825 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18825action=edit Bug 10297 - categorycode and branchcode should be required when adding patrons categorycode and branchcode should show as required under all circumstances, not just when they are included in the BorrowerMandatoryField system preference. This patch adds the correct classes and hints to those fields. To test, view the patron entry form for a new or existing patron. Category and Library should show that they are required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #84 from Kyle M Hall kyle.m.h...@gmail.com --- Did you add any logging code to an opac script to test it? I just added this to my opac-main.pl to test: C4::Context-logger-debug(This is a debug message); C4::Context-logger-error(This is an error !); With the default error level only the latter message will display in the embedded logs comment. (In reply to comment #83) (In reply to comment #81) Created attachment 18819 [details] [review] [review] Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC I understand the changes for opac and using the Koha plugin logic. But I still cannot see the log message in the opac document. (Just empty for opac-search) Are you sure that the statement Logger.get_messages works this way? I tried logger lc too without results. It seems not to work.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- I like Jared's suggestion from IRC, OpacAdditionalStylesheet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Katrin!. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7892] on staged marc record management open in tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #36 from Galen Charlton gmcha...@gmail.com --- I've started reviewing this. One thing that jumped out -- the QA follow-up (re?)introduces a change in the behavior of AlterPriority that should get a test case. I'll deal with that with a follow-up patch myself unless I find other reason to bounce back to QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #37 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to comment #36) I've started reviewing this. One thing that jumped out -- the QA follow-up (re?)introduces a change in the behavior of AlterPriority that should get a test case. I'll deal with that with a follow-up patch myself unless I find other reason to bounce back to QA. Good catch! I'm re-evaluating it right now and I don't think it's going to affect anything. Koha does not expose canceled reserves iirc, so a scenario where a canceled reserve has it's priority altered shouldn't come up. That may be why Jonathan added the check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #38 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #37) Good catch! I'm re-evaluating it right now and I don't think it's going to affect anything. Koha does not expose canceled reserves iirc, so a scenario where a canceled reserve has it's priority altered shouldn't come up. That may be why Jonathan added the check. Indeed; I understand the purpose of the check, I'm just trying to encourage folks to write unit tests for most any change to core routines, even obvious ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Owen, and Jurgens for reporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. I find them useful and am willing to have them in the stable branch (the same applies for the related ones if they get into master). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com Patch complexity|--- |String patch --- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10381] Hide basket links should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Jesee! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Minor merge conflict regarding course reserves. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10413] Odd space character brakes translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8600] Remove search terms in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #24 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Frédérick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10431] Spanish Zebra language definition file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Patch complexity|--- |Small patch Version|3.12|master Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/