[Koha-bugs] [Bug 10675] New: Move spinelabel.css to system preference

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675

Bug ID: 10675
   Summary: Move spinelabel.css to system preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label printing
  Assignee: cnighswon...@foundations.edu
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Editing of the spinelabel.css file should be done via a system preference as
this is thought to be library specific. 

The spinelabel.css file is used for formatting labels printed with the quick
spine label creator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820

Bob Birchall b...@calyx.net.au changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10676] New: OpacHiddenItems not working for restricted

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Bug ID: 10676
   Summary: OpacHiddenItems not working for restricted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
For this configuration in OpacHiddenItems wthdrawn and notforloan work, but
restricted does not:

notforloan: [2]
wthdrawn: [2]
restricted: [2]

Looking at the code I didn't see a reason for this. If someone could test and
confirm/invalidate this bug it would be appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #19837|0   |1
is obsolete||

--- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 20055
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20055action=edit
Bug 10588 - opac-topissues first branch always selected in filters (revised)

Revised patch, same test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588

--- Comment #9 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to Galen Charlton from comment #7)
Indeed, I changed my mind about '__ANY__'.
Because the purpose of this patch is to distinguish form display and form post
with a filter on all branches.
There is already a way to do this : use the hidden input named 'do_it' which is
undef when form is displayed and '1' when form is posted.
This is used in a lot of pages and seems to me more clear code than using
'__ANY__'.

I think '__ANY__' is only used in suggestions because there are suggestions
with no branch and so there may be a filter with 3 cases : a branch selected,
any branch and no branch. 

Setting to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Also, please provide a proper test plan with any new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20056
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20056action=edit
Screenshot of batch operation after applying the patch

This patch doesn't solve the problem for me. See the attached screenshot. I
still don't get the option to make any modifications. The table and its related
controls shouldn't be shown at all. All I should see is the message (Too many
items -- and properly styled in a div class=dialog message) and the form
for making modifications.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7380] Can't filter patron search on detail page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
upping severity on this because it causes a lot of confusion in the trainings
i'm doing lately

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10339] make the content of some help files templates marflavor dependent

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10344] add RDA support to Koha

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
(In reply to Srdjan Jankovic from comment #2)
 I propose something even better then - get rid of prepare() all together.
 For example:
 
 * GetClassSources():
 return $dbh-selectall_hashref(SELECT..., undef, 'cn_source');
 
 * AddClassSource()
 return $dbh-do(INSERT..., undef, @params)
 
 etc. How often are those used to get advantage of prepare_cached()?
 Good databases (tm) cache queries anyway, however not sure that MySQL does.

Getting rid of $sth-finish() and replacing prepare_cached() with prepare()
suffices as a minimal change, but doesn't preclude going further and using
selectall_hashref.

As far as the current patch is concerned, I do think it would be useful to at
least get rid of prepare_cached().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6293] Add a button to the intranet for registering with the Koha community

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6293

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19643|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20057
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20057action=edit
Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now()
AS date).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19644|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20058
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20058action=edit
Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by
CAST(now() AS date).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10498] Place Hold on Order

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #104 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20060
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20060action=edit
Bug 6874 - File upload in MARC - QA Followup

* Renames uploadPath to upload_path to follow the standard naming
  conventions in koha-conf which use underscores rather than camel case
* Remove reference to intranet-tmpl and replace with [% interface %]
  required to pass qa

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20059|Bug 6874: Move uploadPath   |[SIGNED-OFF] Bug 6874: Move
description|syspref to koha-conf.xml|uploadPath syspref to
   ||koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18598|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20061
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20061action=edit
Bug 10013 - Ability to link directly from an item in the Staff client to budget
information.

To Test:
1) Create budget and fund under budget administration.
2) Create Vendor in acquisitons module.
3) Create basket under vendor.
4) Create order and choose budget while creating order.
5) Receive shipment.
6) Check in catalog details, in holding tab budget information column is
displayed
, on click it should display the budget information.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

--- Comment #11 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
Created attachment 20062
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20062action=edit
Bug 9372 : Replaces carriage return with br / in printed html files for
overdues.

For pdf generation, html files need explicit br / html tags. With this patch,
carriage return are replaced by br / when letters are written into html
files.

Test plan :
- Ensure you've got at least one reader with overdue triggering notice
- Ensure that your notice template got html checked
- Run misc/cronjobs/overdue_notices.pl -v -n -html dirname
  and misc/cronjobs/printoverdues.sh dirname

Without patch, the content of the letter is all on one line in pdf file
With the patch, pdf file is correctly formated

- remove your reader email
- Run misc/cronjobs/overdue_notices.pl -v -html dirname
  and misc/cronjobs/printoverdues.sh dirname

Without patch, the content of pdf file is all on one line
with the patch, pdf file is correctly formated.

- restore reader email
- run misc/cronjobs/overdue_notice.pl -v -html dirname

Verify that the a message has been generated in message_queue table
With or without patch, the message is the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18600|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20063
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20063action=edit
Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||sophie.meyni...@biblibre.co
   ||m
   Assignee|stephane.delaune@biblibre.c |sophie.meyni...@biblibre.co
   |om  |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18600|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20064
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20064action=edit
Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

  Attachment #14548|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18894|0   |1
is obsolete||

--- Comment #103 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20059
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20059action=edit
Bug 6874: Move uploadPath syspref to koha-conf.xml

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
The feature patch works as advertised, but I'm a bit confused by the unit test.
There is language in it that says it's a stub, it it's not. Additionally, it
doesn't mock any data, and fails for me. It makes invalid assumptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

--- Comment #12 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
To take Kratin's comment into account, I propose this new patch that changes
carriage returns with br / only in printed files if paramter file format is
html.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18600|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

  Attachment #14547|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20063|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10677] New: C4::Search::GetSearchHistory is broken and unused

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10677

Bug ID: 10677
   Summary: C4::Search::GetSearchHistory is broken and unused
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org

C4::Search::GetSearchHistory does not work, as it contains a SQL syntax error:

SELECT FROM search_history WHERE...

Its broken state is not visible to users, however, because that routine is not
used -- opac-search-history.pl is doing a direct SQL query, which is not ideal.

GetSearchHistory should be fixed, then put in use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10365] Using published date on routing slips

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20065
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20065action=edit
bug 10365 change routing slips to use date published rather than planned date

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10365] Using published date on routing slips

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19950|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20066
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20066action=edit
Bug 10645: Missing zebra languages in koha-create manpage

There where some missing zebra language options in the man page for
koha-create.

Trivial string change.
To+

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #18839|0   |1
is obsolete||

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20067
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20067action=edit
Bug 10361: (follow-up) add tests for search history functions

This adds tests for the new PurgeSearchHistory function and
AddSearchHistory.  GetSearchHistory is not tested due to its
current broken state (see bug 10667).

To test:

[1] Run prove -v t/db_dependent/Search_SearchHistory.t
[2] Verify that all tests pass.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20067|0   |1
is obsolete||

--- Comment #9 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20068
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20068action=edit
Bug 10361: Add option to cleanup_database.pl to purge OPAC search history

Add an option to cleanup_database.pl to purge the search_history
entries older than X days.

Test plan:

- Apply patch
- Check that your test DB has some entries a little older than 30 days
  and a few ones even older than that in search_history:

  SELECT * FROM search_history WHERE time  DATE_SUB( NOW(), INTERVAL 30 DAY );

  If not, modify some existing entries.

- Run cleanup_database with a fixed number of days (replace XX with
  something higher than 30)

  /misc/cronjobs/cleanup_database.pl --searchhistory XX

- Check that entries older than XX days got deleted from search_history
- Run without the day parameter
  /misc/cronjobs/cleanup_database.pl --searchhistory
- Check that entries older than 30 days got deleted from search_history

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

--- Comment #10 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20069
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20069action=edit
Bug 10361: (follow-up) add tests for search history functions

This adds tests for the new PurgeSearchHistory function and
AddSearchHistory.  GetSearchHistory is not tested due to its
current broken state (see bug 10667).

To test:

[1] Run prove -v t/db_dependent/Search_SearchHistory.t
[2] Verify that all tests pass.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

--- Comment #11 from Galen Charlton gmcha...@gmail.com ---
I've signed off on the patch and added a follow-up that adds some tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10472] Receipt by line or invoice

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19673|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20070
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20070action=edit
Bug 10593 - AuthoritiesLog should default to yes

This trivial patch set the default to 'yes' for this system preference.
To test,
On a clean install
- Navigate Home  Administration  Global System preferences  Logs
- AuthoritiesLog is set to Don't log
Apply the patch, install koha on a new DB.
- Navigate Home  Administration  Global System preferences  Logs
- AuthoritiesLog should be set to Log

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20062|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20071
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20071action=edit
Bug 9372 : Replaces carriage return with br / in printed html files for
overdues.

For pdf generation, html files need explicit br / html tags. With this patch,
carriage return are replaced by br / when letters are written into html
files.

Test plan :
- Ensure you've got at least one reader with overdue triggering notice
- Ensure that your notice template got html checked
- Run misc/cronjobs/overdue_notices.pl -v -n -html dirname
  and misc/cronjobs/printoverdues.sh dirname

Without patch, the content of the letter is all on one line in pdf file
With the patch, pdf file is correctly formated

- remove your reader email
- Run misc/cronjobs/overdue_notices.pl -v -html dirname
  and misc/cronjobs/printoverdues.sh dirname

Without patch, the content of pdf file is all on one line
with the patch, pdf file is correctly formated.

- restore reader email
- run misc/cronjobs/overdue_notice.pl -v -html dirname

Verify that the a message has been generated in message_queue table
With or without patch, the message is the same

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10668] Improve suggestion detail page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20018|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20072
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20072action=edit
Bug 10668 - Improve suggestion detail page

This patch makes several improvements to the suggestions template:

- Improved breadcrumbs and page title.
- Fixed a JavaScript error which appeared when viewing or editing a
  suggestion.
- Added an 'Edit' and a 'Delete' button to the suggestion detail page.
- Corrected capitalization.

To test:
- Perform various operations with suggestions management and
  confirm that page titles and breadcrumbs are correct.
- View the detail page for an individual suggestion and confirm that
  the edit and delete buttons work correctly.
- Confirm that there are no JavaScript errors when viewing or editing a
  suggestion, in particular when changing Acquisition information
  (quantity, currency, price).

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10668] Improve suggestion detail page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10668] Improve suggestion detail page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20073
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20073action=edit
Bug 10668 - Improve suggestion detail page - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320

--- Comment #28 from Jesse Weaver jwea...@bywatersolutions.com ---
Confirmed with Brendan. Yes, this code is all licensed under GPLv3+ and
copyright 2013 ByWater.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Jonathan, your patches work quite well, but there is no way to disable all the
options at once. When I deslect them all, and hit the save button, I get the
Nothing to save message.

Not required, but it might be nice to implement something like
https://code.google.com/p/dropdown-check-list/ as a fair number of people may
not know about ctrl-click to select/deselect individual items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12507|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19793|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20074
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20074action=edit
Bug 8821 - Receive shipment page should hide inactive funds like new order form

This patch adapts the fund-handling code from neworderempty.pl
in order to limit the display of funds by default to active ones,
with the option to check a box to display all funds.

This patch also adds (inactive) to the display of funds on this and
the neworderempty.tt template because it seemed like that was useful
information.

To test, make sure you have both active and inactive funds.
Start the process of receiving a shipment. The fund option
in the receive shipment form should show only active funds.
Checking the show all checkbox should allow you to choose
from both active and inactive funds.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19548|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20075
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20075action=edit
Bug 10572: Add phone to message_transport_types table for new installs

In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added
phone to the message_transport_types table in updatedatabase.pl

This should be done also for new installs via the .sql files of the web
installer.

I am adding it only to English now, basing this change upon the work in reports
10509 and 10520. (I discovered this tiny omission there too.)

Test plan:
Apply patches 10509/10520.
Run new install or run this particular sql file from command line.
Note: If you only run this particular file, you do not need patch 10509.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19310|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20076
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20076action=edit
Bug 10509: Using i18n function for translation of MySQL web installer files

This patch makes the changes needed to progressively use a i18n function to
translate strings in the web installer's MySQL files. The English scripts may
contain fields like i18n(columnvalue); for English i18n(a) is a, but for the
other languages i18n(a) is the translation of a.
The corresponding script in the language folder contains the i18n definition.
The work is done in such a way that current installations are not affected.

Subsequent patches will make the changes in the .sql files themselves. This can
be done per folder, per language. Using the extension .i18n in the last
subfolder name triggers the new translation mechanism. (See also test plan.)

In Installer.pm the all_languages parameter is removed from load_sql_in_order.
This code was not used. This change also affects the call in install.pl.
The most important change is the use of a new subroutine _run_mysql_file in
load_sql. This new routine contains the above logic.
Although I also tested changing marc_framework_sql_list and
sample_data_sql_list, it proved imo to be easier (and more maintainable) to do
this via load_sql.

Test plan:
Since no .sql files are changed in this patch, please test if you can install
English and e.g. German (or another one) in the web installer without any
changes.

Bonus points for the following additional tests :)
They serve to illustrate the i18n concept more clearly.
1) Place in en/mandatory/userflags.sql around a few strings i18n('...').
Run English install again and check the userflags table. No changes expected.
2) Place in de-DE/mandatory/userflags.sql i18n around a few strings too. Also
precede the insert statements with this definition:
DROP FUNCTION IF EXISTS i18n;
CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN concat(d,'xx');
Now run German install again; some of the userflag strings (with i18n) should
now end with xx.
3) Before retesting German install, make some changes:
Edit en/optional/sample_holidays.sql. Add i18n calls around strings.
Create an additional folder optional.i18n in de-DE.
Copy sample_holidays.sql and sample_holidays.txt from de-DE/optional.
Edit de-DE/optional.i18n/sample_holidays.sql. Remove all text! Add:
DROP FUNCTION IF EXISTS i18n;
CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC
RETURN CASE d
WHEN 'Sundays' THEN 'Sonntag'
ELSE d END;
Now run German install again; in the optional part of the install mark
sample holidays (in the last section standing separately; do not confuse with
 the other one). Check the repeatable_holidays table afterwards. The string
above should have been translated only, the others are still English.
Undo the changes in .sql files; remove optional.i18n folder.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19311|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20077
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20077action=edit
Bug 10509: Followup for load_sql_in_order in unit tests

Although I assume that the unit tests in t/db_dependent/lib are actually
obsolete and should probably be removed, the two calls of load_sql_in_order
are updated to reflect the current parameter list. (The all_languages
parameter has been dropped.)

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19439|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20078
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20078action=edit
Bug 10520: Add i18n function to en/mandatory mysql files

Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).

Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all mandatory files.
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.

Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Tested both ways myself.
Noticed that I missed one message_transport_type (phone) and one language
description (180 vs. 181). If needed, will handle these on a separate report.
They do not directly relate to this patch.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19440|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20079
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20079action=edit
Bug 10520: Add i18n function to en/optional mysql files

Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).
Removed some locking statements in sample_creator_data.
NOTE: Some scripts insert numbers in auto-increment columns. Although this
works, I would not prefer to do so.
This patch however is not meant to change that, so leaves them for now.

Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all OPTIONAL files (in the OTHER DATA section).
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.

Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Tested all optional data via webinstaller.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19542|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20080action=edit
[PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10678] New: Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

Bug ID: 10678
   Summary: Allow framework selection when creating from Z39.50
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||tomasco...@gmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10678

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
I think the confirm popup should remain as long as you are sitting on the MARC
cataloguing form. Simply it costs less than checking every field for data.

This should be considered as a usability discussion. I have a proposal to avoid
having to choose a framework and *then* doing the search. Please look at bug
10678 Katrin.

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9742

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20081
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20081action=edit
Bug 10678 - Allow framework selection when creating from Z39.50

If we are creating a new record, we are forced to use the default framework
and then change it after we have the cataloguing form filled. This patch
adds the option to choose (from a splitted button dropdown) which framework
to use.

To test:
- Apply the patch.
- Go to More  Cataloguing
- Check there's a nice split button that says New from Z39.50
a) Click the button, the usual Z39.50 search popup should appear and work as
expected
   (check the URL parameters and see frameworkcode= has no value
b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search
popup should
   appear, this time frameworkcode= should have the chosen value.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

--- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20082
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20082action=edit
Snapshot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20083
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20083action=edit
Bug 7257 - Add a link to remove an individual title from a list

It should be possible when viewing the contents of a list to click a
link to remove an individual title from the list without having to check
a checkbox and click another button.

This patch adds a link to each list item to Remove from this list.
The functionality is JavaScript-dependent, automatically checking the
appropriate checkbox and submitting the form to delete.

To test, view a list for which you have delete permission. There should
be a Remove from this list link next to each item on the list. Test
delete functionality by:

- Clicking the link and then clicking cancel.
- Clicking the link and confirming.
- Checking more than one checkbox and then clicking a single remove
  link (only the one corresponding record should be removed).
- Checking one or more checkboxes and clicking the Remove from list
  link at the top of the page.

If JavaScript is disabled the links should not appear.

There are now two delete confirmation messages: One if you're removing
only one item, another if you're removing more than one. This is true
whether you use the links or the checkboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10679] New: Lists interface offers delete option when user doesn't have permission

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679

Bug ID: 10679
   Summary: Lists interface offers delete option when user doesn't
have permission
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Lists
  Assignee: m.de.r...@rijksmuseum.nl
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In both the OPAC and the staff client a allowremovingitems variable is used
in the template to determine whether the logged in user should be able to
delete items from a list. In both the OPAC and staff client this variable is
true when it should be false. Fortunately the user can't actually remove
something from the list. Instead the page returns an error message. However,
the remove option should not be visible in that case.

To confirm this bug, log in to the OPAC or staff client and open a public list
which was created by another user. The remove from list option will be
available but submitting the form will return an error like You could not
delete any selected items from this shelf.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7257] Add a link to remove an individual title from a list

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7257

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Note that because of Bug 10679 you can't test whether the Remove from this
list links are correctly shown or hidden based on the logged-in user's
permission to remove items from a list. The links will always appear to a
logged-in user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10680] New: Modification log gives wrong data

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680

Bug ID: 10680
   Summary: Modification log gives wrong data
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Transaction logs
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When viewing a record, the Modification log tab on the left hand side should
display the modifications for that biblionumber, but instead it will pull the
modifications for the itemnumber instead.

That is, if the record you are viewing has a biblionumber of 42, and you follow
the Modification log link, you will be seeing the modifications for the item
whose itemnumber is 42 instead!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10678] Allow framework selection when creating from Z39.50

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Everything looks good and works well with one exception: If I click the button
without choosing one of the menu choices the framworkcode is passed as
undefined instead of being empty. With undefined the default framework
isn't loaded and I get an MARC edit screen with no fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10680] Modification log gives wrong data

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
One issue is that the biblionumber is not stored in the log for cataloging
modifications, so the only way to get the list of modifications by biblionumber
is to select where object IN ( SELECT itemnumber FROM items UNION deleteditems
WHERE biblionumber = ?.

So, basically we need a special case in GetLogs for modules=CATALOGUING and
action=MODIFY.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10680] Modification log gives wrong data

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Or, I think the correct answer is to update the object to the biblionumber for 
modules=CATALOGUING and action=MODIFY, as we can never view the specific item
logs from a link in the intranet. If we do this, we can pull modification both
via biblionumber ( via object ) and itemnumber ( via searching the info field
with 'itemnumber' = '63661'.

It's really a bit of a mess, as 'object' is used for biblionumber in some
circumstances, and as itemnumber in others ( biblio vs item edit ) yet there is
no way to specify what you are looking for at that level. There is no way to
know if you are asking for biblio edits or item edits.

The only sensible way to solve this to me is to make 'object' always be
biblionumber.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||frede...@tamil.fr
  Component|Architecture, internals,|I18N/L10N
   |and plumbing|
   Assignee|gmcha...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
I notice the fr-FR version of opac-opensearch.tt is also missing the XML
declaration at the top (?xml version='1.0' encoding='utf-8'  ?).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7809] Edit Items screen should be sorted by home branch instead of holding branch

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7809

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|unspecified |master
   Severity|enhancement |normal

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Is this as simple as changing line 722 from this:

my ($holdingbrtagf,$holdingbrtagsubf) =
GetMarcFromKohaField(items.holdingbranch,$frameworkcode);


to this:

my ($holdingbrtagf,$holdingbrtagsubf) =
GetMarcFromKohaField(items.homebranch,$frameworkcode);

? 

Or does that have a ramification I'm not seeing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
(In reply to M. de Rooy from comment #3)
 
 I am wondering if we can do the other phone change like this. Lots of people
 may have entered mobile phone numbers here, and suddenly it is just an other
 phone.

The staff client already uses the other phone label. This patch simply makes
the two interfaces consistent.

The other issue (with members-update.pl) seems like it could be handled in a
separate patch and shouldn't block this one in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #20 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6775] Add option to use authorized values as reasons for restrictions

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6775

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|REOPENED|NEW
Summary|Allow reason to be  |Add option to use
   |specified when debarring|authorized values as
   ||reasons for restrictions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >