[Koha-bugs] [Bug 10697] New: Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

Bug ID: 10697
   Summary: Revert from using GetReserveStatus to use
CheckReserves
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The GetReserveStatus subroutine doesn't cover all needed use cases and the
change done by bug 9367 need to be reverted for that reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10663] Holds never block renewals

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10697

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9367,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10663

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10697

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #0)
 The GetReserveStatus subroutine doesn't cover all needed use cases and the
 change done by bug 9367 need to be reverted for that reason.

Do you have more specific information?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Yes, it's on bug 10663. Current state of things is that GetReserveStatus does:

- not return Filled (Finished) correctly, because it checks the wrong table.
- not return Reserved correctly because it leaves out lots of the logic
  that CheckReserves has to determine if an item can actually fill a hold and   
  totally ignores title level holds when only called with itemnumber.
- not return Waiting correctly, because the condition is wrong (see obsoleted
  partial fix patch on bug 10663)

I have spent hours on this as have others and a revert is IMO the best option
to fix the regression introduced by bug 9367. It was too late to revert it from
git, so doing it in smaller steps accompanied by unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10698] New: DeleteTransfer in C4::Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

Bug ID: 10698
   Summary: DeleteTransfer in C4::Circulation.pm needs return
value
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kenza.z...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Blocks||10698

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||10692
   Assignee|gmcha...@gmail.com  |kenza.z...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

--- Comment #1 from kenza kenza.z...@biblibre.com ---
Created attachment 20160
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20160action=edit
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value

This patch adds return values to DeleteTransfer:
Undef if no parameters are given
1 if a Transfer is deleted
0E0 if a wrong parameter is given

It also fixes some unit tests in t/db_dependent/Circulation_transfers.t

To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=14, 20 wallclock secs ( 0.03 usr  0.00 sys +  0.39 cusr  0.02
csys =  0.44 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 CC||kenza.z...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653

--- Comment #8 from kenza kenza.z...@biblibre.com ---
Created attachment 20161
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20161action=edit
Bug 10642 : Inappropriate uses of $sth-finish() in C4::RotatingCollections.pm

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to finish after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10034] kw,rld: in Z39.50 research

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

  Attachment #20126|1   |0
   is patch||
  Attachment #20126|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

  Attachment #20161|1   |0
   is patch||
  Attachment #20161|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

  Attachment #20106|0   |1
is obsolete||

--- Comment #9 from kenza kenza.z...@biblibre.com ---
Created attachment 20162
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20162action=edit
Bug 10653: C4::RotatingCollections.pm needs unit tests

The tests are wrap in a database transaction.

Test plan:
prove t/db_dependent/RotatingCollections.t
t/db_dependent/RotatingCollections.t .. ok
All tests successful.
Files=1, Tests=41, 20 wallclock secs ( 0.02 usr  0.01 sys +  0.41 cusr  0.02
csys =  0.46 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] New: DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

Bug ID: 10699
   Summary: DeleteBranchTransferLimits in C4/Circulation.pm needs
return value
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kenza.z...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||kenza.z...@biblibre.com
 Depends on||10692
   Assignee|gmcha...@gmail.com  |kenza.z...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Blocks||10699

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

kenza kenza.z...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

--- Comment #1 from kenza kenza.z...@biblibre.com ---
Created attachment 20163
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20163action=edit
Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value

This patch adds return values to DeleteBranchTransferLimits:
1 if a Transfer Limit is deleted
undef if no parameters is given
0E0 if a wrong parameter is given

More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t

To test :
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=14, 19 wallclock secs ( 0.02 usr  0.01 sys +  0.39 cusr  0.02
csys =  0.44 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10034] kw,rld: in Z39.50 research

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||mag...@enger.priv.no

--- Comment #3 from Magnus Enger mag...@enger.priv.no ---
Setting the status to Needs Signoff, as there is a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ah I see now, that I got a little confused - Waiting works fine, which is why
the patch here won't make much difference in most cases. I still think
reverting is the safer option and maybe we should just remove GetReserveStatus
and instead create something new and light weight that just checks for the
'Waiting' status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 20164
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20164action=edit
Bug 10697 - Adding more unit tests to CheckReserves

Adding more unit tests for CheckReserves to cover more use cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 20165
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20165action=edit
Bug 10697: Revert from using GetReserveStatus to use CheckReserves

Patch reverts switch from CheckReserves to GetReserveStatus done by
9367 in various places.

Note: You will need the patches from bug 10663 to check renewal related
functionality.

Note: When the check is only done for Waiting it will work the
same before and after applying this patch as this part of GetReserveStatus
works fine.

In order to test this, create item and title level holds on some
records, make sure that there are holds not yet pulled and items
waiting for pickup in the library.

Search.pm - searchResult
XSLT.pm - buildKohaItemsNamespace
Check item status in search result list are shown correctly using
XSLT and non-XSLT views. Only checked for 'Waiting', so verify no
regressions.

opac-detail.pl
Check on item status is shown correctly on detail pages in OPAC.
if( $reserve_status eq Reserved){ $itm-{'onhold'} = 1; }
seems to be not used, verify no regressions.

circulation.pl - build_issue_data
opac-user.pl
Check items on hold are properly marked in the list of checkouts
and can not be renewed for
- patron account pages in the staff interface
- patron account pages in the OPAC
$it-{'renew_error'} = ( $restype eq Waiting or $restype eq Reserved ) ? 1
: 0;
seems to be not used, verify no regressions.

Run unit tests from first patch and any additional tests you
can think of.

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Severity|major   |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6206] can't change framework in the middle of cataloging

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6206

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Nicole C. Engard neng...@gmail.com ---


*** This bug has been marked as a duplicate of bug 10448 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #10 from Nicole C. Engard neng...@gmail.com ---
*** Bug 6206 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5832] rss.pl limited to 15 results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5832

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
The templates for this rss script haven't been updated since before we switched
to Template Toolkit. Since then we've added the ability to make SQL reports
public. I think it's time to get rid of /misc/cronjobs/rss altogether.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20167
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20167action=edit
Bug 10521: Define i18n function for de-DE/mandatory files

This patch adjusts the de-DE/mandatory files.

Test plan:
Run German install, including all mandatory files.
Check translated strings from several tables touched in Mandatory.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20169
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20169action=edit
Bug 10521: Define i18n function for de-DE/optional files

This patch adjusts the de-DE/optional files.

Test plan:
Run German install, including all optional files.
Check translated strings from several tables touched in Optional.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20166
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20166action=edit
Bug 10521: Prepare de-DE mandatory sql files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Sample notices: remove newline between last quote and );
Stopwords: Add column name
Userflags: Convert into one insert statement with multiple values

Test plan:
See second patch for de-DE mandatory files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20168
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20168action=edit
Bug 10521: Prepare de-DE optional sql files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Sample creator data: Remove lock statements, add column names
Sample holidays: Add column names
Sample itemtypes: Convert into one insert statement with multiple values
Sample news: Add column name

Test plan:
See next patch for de-DE optional files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20170
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20170action=edit
Bug 10521: Followup for relator terms and quotes

These files were still missing in the German install.

Test plan:
Select relator terms and quotes in German optional install.
Since nothing is translated yet, you should see English strings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20171
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20171action=edit
Bug 10521: Prepare de-DE marc21/optional files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Default matching rules: added only some comment lines to skip a few
INSERT..SELECT constructs during conversion.
Fastadd framework: Add column names.

Test plan:
See next patch for de-DE marc21/optional files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10700] New: Remove misc/cronjobs/rss

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10700

Bug ID: 10700
   Summary: Remove misc/cronjobs/rss
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

The RSS cron script hasn't been touched for years, and the associated template
files predate our switch to Template Toolkit. Since we now have the ability to
make the results of saved SQL reports public, I think we should consider this
RSS system dead and remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20172
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20172action=edit
[PATCH_IN_GZ] Bug 10521:  Define i18n function for de-DE/marc21/mandatory

Patch in zipped attachment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437

--- Comment #8 from Owen Leonard oleon...@myacpl.org ---
A test plan is a simple description of the steps one would take to confirm that
a patch works. Usually this means confirming that a patch fixes a particular
problem and doesn't cause other problems. Is there a real-world case where this
fixes a browser error? If not, you should describe how to test each affected
page/action to confirm that the patch hasn't caused any problems.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 20173
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20173action=edit
[PATCH_IN_GZ]  Bug 10521: Define i18n function for de-DE/marc21/optional

Patch zipped in attachment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2806] issuingbranch isn't used

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
(In reply to Liz Rea from comment #1)

 Which still leaves the question, populate issuingbranch or just depend on
 items.branchcode and remove issuingbranch?

Since items.branchcode is updated with the branchcode of the issuing branch,
and then issues.branchcode is updated with the same value, what is the point of
having a second field, issues.issuingbranch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #41 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 20174
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20174action=edit
Bug 9811 - multilines notes brakes JSON

A small bug that brakes Ajax call and causes a forever loading member search.
See commit mesage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

--- Comment #9 from Nicole C. Engard neng...@gmail.com ---
better suggestion: 'consolidate messages' or 'consolidate msgs' to save space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

--- Comment #8 from Nicole C. Engard neng...@gmail.com ---
A suggestion I got today is 'consolidate' or 'consolidate emails'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #20174|Bug 9811 - multilines notes |Bug 9811 - multilines notes
description|brakes JSON |breaks JSON

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #42 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to Chris Cormack from comment #40)
 these patches add datatables, but they also change the behaviour
 so when you visit the members page it fetches every single borrower from the 
 database.
In C4/Utils/DataTables/Members.pm :
The SQL query does not fetch all borrowers, it uses iDisplayStart and
iDisplayLength to limit to the first page (usually 20 borrowers).
And when there is not filter, there is only  a select count(*) from borrowers,
this should not take a long time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
'consolidate msgs' might save space, but really confuse translators. I would
have no idea how to translate that seeing it out of context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7463] don't show item number on fines

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7463

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Severity|enhancement |normal

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #19530|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20175
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20175action=edit
[SIGNED-OFF] Bug 10570: Show nonpublic note on check expiration page

The check expiration page in serials only showed the OPAC note,
but it makes sense to also show the nonpublic note here.

This patch adds it.

To test:
- Add a subscription, make sure to enter different notes in
  nonpublic note and OPAC note to check for display later on.
- Go to the check expiration page and search for your subscription.
- Check both notes show up correctly.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #20132|0   |1
is obsolete||

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20176
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20176action=edit
[SIGNED-OFF] Bug 10404: add previous/next browsing to staff client

Although previous/next browsing was added for searches in the OPAC
in 2011, the staff client has been without any sort of search browsing.
Until now. This patch is an all-singing, all-dancing, all-compatible
implementation of search browsing that will work across multiple
browser tabs and on any browser since IE7 (though the staff client
layout is broken on IE7).

To test:
1) Perform a search that will bring up multiple results.
2) View one of the results.
3) Use the Previous and Next links to browse along the search results.
4) Use the Return to results button to check that you end up at the
   correct page of results, even if you page through more than 20
   records.
5) Sign off.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20177
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20177action=edit
Bug 10404 [CSS follow-up] Add previous/next browsing to staff client search
results

This patch slightly modifies the styles of the previous/next links in a
way that I think is simpler and clearer.

To test, apply the patch and clear your browser cache if necessary.
Perform a search in the staff client, click any result, and look at the
prevous/next links. If you think this is an improvement, sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6035] Mobile interface for OPAC

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6035

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Owen Leonard oleon...@myacpl.org ---
(In reply to Magnus Enger from comment #5)
 Did the CCSR theme make this obsolete?

I would say yes, not to mention Bug 10309

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8902] Many columns do not appear in batch modification if selected records do not include them

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8902

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|3.10|master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10007] Totals in checkouts table

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10007

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
It looks like Koha is displaying the total amount owed by the patron regardless
of whether that amount is from a rental charge listed in the checkouts table or
a charge for something else (like a lost item).

The total for this column should add up only rental charges listed in that
table if it is to be correct.

However, it should be noted that the rental charges listed in the table of
checkouts are not shown based on charges which are actually on the patron's
account (in the accountlines table), the charges are listed according to the
current policy.

If I checked out a DVD last week when there was no rental charge, and then
check out a DVD today after a $3.00 rental fee was added the screen will show a
$3.00 charge for both of those items even though accountlines will only have a
line for the $3.00 I actually incurred after the rental fee policy change.

We can't fix the total until we fix the way rental fees are calculated by the
script.

This leads me to wonder... Is there a good reason to be displaying the rental
fee at all on this page? Do libraries who charge rental fees have policies
which require them to be paid on a higher priority basis than other fines? If
not, showing the total of all fines and charges on this screen (as we do)
should be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8287] remove filter on checked out from overdues

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
(In reply to Nicole C. Engard from comment #2)
 So, then maybe that box needs to say Ignore Due-Date filter above instead
 - or something more accurate.

The checkbox basically switches this from a report of overdues to a report of
checkouts. Show all checkouts regardless of date due might be more accurate?
It's a strange feature to include in a report for showing overdues.

If you check the box the title of the report really should change to reflect
that it's showing more than just overdues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9861] Solr: HTTP 404 when i click on title or author in search results

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9861

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|i get HTTP 404  when i  |Solr: HTTP 404 when i click
   |click on title or author in |on title or author in
   |search results. |search results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #12 from Nicole C. Engard neng...@gmail.com ---
It's been a while on this, but can we get an updated patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19502|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20178
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20178action=edit
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #20178|0   |1
is obsolete||

--- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20179
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20179action=edit
[SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Save for translation files (that will be fixed on next release),
only occurrence of wthdrawn is on updatedatabase.pl
No koha-qa errors.

This touch many files, and I did not test everything,
but all seems normal. I think that any problem could
be fixed later.

Perhaps both entries in updatedatabase.pl could be joined
into one, but thats for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16773|0   |1
is obsolete||
  Attachment #18676|0   |1
is obsolete||
  Attachment #20180|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20181
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20181action=edit
Bug 9011 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the field items.last_borrower, foreign key to
  borrowers.borrowernumber
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha set this new
  field to the patron who last returned this item.
* If this new field has a value, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
should be a new field in the history list 'Last returned by' with a link
to the given borrowernumber.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16763|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20180
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20180action=edit
Bug 9011 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the field items.last_borrower, foreign key to
  borrowers.borrowernumber
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha set this new
  field to the patron who last returned this item.
* If this new field has a value, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
should be a new field in the history list 'Last returned by' with a link
to the given borrowernumber.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

--- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20182
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20182action=edit
Bug 8507: koha-create should be updated to use DOM indexing for bib

This patch makes the koha-create script install the file zebra-biblios-dom.cfg
with the proper string substitutions inside on the new instance.

It also adds two option switches that control the indexing mode for the
instance:

 --biblio-idx {dom|grs1}
 --auth-idx {dom|grs1}

DOM indexing is set as the default for both authorities and bibliographic
records.

To test:
- Apply the patch
- Build your own packages and install them on a test server
a) Create a new instance without using the new switches like:
 $ koha-create --create-db domtest
 - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg
 - Check that /etc/koha/sites/domtest/koha-conf.xml points to:
   * zebra-biblios-dom.cfg (biblioserver section)
   * zebra-biblios-dom.cfg (publicserver section)
   * zebra-authorities-dom.cfg (authorityserver section)
 - Success means the new default is DOM
b) Play with the 4 possible combination of option switches
 $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest
 $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest
 $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest
 $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest
 - Check the koha-conf.xml file reflects the chosen options.
c) Run
 $ koha-create --help
 - It should advertise this addition accordingly.
d) Run
 $ man koha-create
 - Man page for koha-create should provide good information on the new switches
behaviour

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19692|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20185
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20185action=edit
Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19682|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20184action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19674|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20183action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10573] French translation for printing a basketgroup

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #19577|0   |1
is obsolete||

--- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20186
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20186action=edit
Bug 10573: French translation for printing a basketgroup

If you want to print a basketgroup with pdf format, it will be in english.
The pdf is done with layout2pages.pm or layout3pages.pm which call
layout2pages.pdf or layout3pages.pdf.
This patch adds layout3pagesfr.pm in src/acqui/pdfformat/ which calls
layout3pagesfr.pdf.
And adds in basketgroup.pl the check for layout3pagesfr
To use it you have to change the systempreferences to 
pdfformat::layout3pagesfr

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Work as described, koha-qa reports some tab errors.
Corrected in a followup.

Please, always add a test plan, it's easier to test.

Test:
1) apply the patch
2) change syspref OrderPdfFormat to pdfformat::layout3pagesfr
3) select a vendor
4) create a basket group (empty works)
5) close basket group
6) print basket group
7) PDF is in french

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10573] French translation for printing a basketgroup

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573

--- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20187
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20187action=edit
Bug 10573 - Folloup - French translation for printing a basketgroup

small followup to fix tabs

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10573] French translation for printing a basketgroup

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #19988|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 20188
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20188action=edit
Bug 9247 - Add two more usage examples to the manpage for koha-mysql

It might not be immediately obvious that it is possible to send
SQL queries directly to the koha-mysql command, or that files
from mysqldump can be loaded with it. This patch adds these as
example usage to the man page for koha-mysql.

To test:

Run these commands and look at the formatted man page:
$ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \
  debian/docs/koha-mysql.xml
$ man -l koha-mysql.8

Make sure this test passes:
$ prove -v xt/verify-debian-docbook.t

This patch also corrects a couple places where Koha was written as koha.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8507] koha-create should be updated to use DOM indexing for bib

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #20182|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20189
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20189action=edit
Bug 8507: koha-create should be updated to use DOM indexing for bib

This patch makes the koha-create script install the file zebra-biblios-dom.cfg
with the proper string substitutions inside on the new instance.

It also adds two option switches that control the indexing mode for the
instance:

 --biblio-idx {dom|grs1}
 --auth-idx {dom|grs1}

DOM indexing is set as the default for both authorities and bibliographic
records.

To test:
- Apply the patch
- Build your own packages and install them on a test server
a) Create a new instance without using the new switches like:
 $ koha-create --create-db domtest
 - Check there's a file /etc/koha/sites/domtest/zebra-biblios-dom.cfg
 - Check that /etc/koha/sites/domtest/koha-conf.xml points to:
   * zebra-biblios-dom.cfg (biblioserver section)
   * zebra-biblios-dom.cfg (publicserver section)
   * zebra-authorities-dom.cfg (authorityserver section)
 - Success means the new default is DOM
b) Play with the 4 possible combination of option switches
 $ koha-create --create-db --auth-idx grs1 --biblio-idx grs1 domtest
 $ koha-create --create-db --auth-idx grs1 --biblio-idx dom domtest
 $ koha-create --create-db --auth-idx dom --biblio-idx grs1 domtest
 $ koha-create --create-db --auth-idx dom --biblio-idx dom domtest
 - Check the koha-conf.xml file reflects the chosen options.
c) Run
 $ koha-create --help
 - It should advertise this addition accordingly.
d) Run
 $ man koha-create
 - Man page for koha-create should provide good information on the new switches
behaviour

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #20131|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 20190
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20190action=edit
Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and
staffClientBaseURL

The descriptions for OPACBaseURL and staffClientBaseURL are not explicit
about including a trailing slash or not. This patch makes it explicit
that the trailing slash should *not* be included.

To test:
- Apply the patch
- Search for baseurl in the system preferences
- Check that the description of both sysprefs includes a warning about
  not including a trailing slash.
- Sign off

If you want to check that the trailing slash is in fact superfluous you
can do something like 'grep -r BaseURL *' and check that these
sysprefs are usually concatenated with some string that starts with a
slash.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10701] New: In transit information doesn't display on the bibliographic detail page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701

Bug ID: 10701
   Summary: In transit information doesn't display on the
bibliographic detail page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

My patch for Bug 10083 may have made the in-transit strings translatable, but
it messed up the template variable names so that the details don't show.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10702] New: can't create notices for a specific branch

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10702

Bug ID: 10702
   Summary: can't create notices for a specific branch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

When creating a new notice if I choose my branch and then the module the branch
changes back to 'all libraries'. I then change the branch back to mine and
enter the code and text and have everything in place and hit save.  When I save
it doesn't save. The notice is lost.  Right now you have to create the notice
for 'all libraries' and then copy the notice to my library and then delete the
'all libraries copy'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20191action=edit
Bug 10701 - In transit information doesn't display on the bibliographic detail
page

The patch for Bug 10083 incorrectly changed some template variable names
so that in-transit details could not be shown on the biblio detail page.
This patch corrects the error.

To test, perform any action that will trigger an transfer between
libraries (for instance, check in an item from Library A at Library B).
View the detail page for that title and look for the transfer details in
the status column of the holdings table. It should show correct
information:

In transit from Athens to Nelsonville since 08/08/2013

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10686] Fielded searches confuse highlighter

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #20119|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 20192
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20192action=edit
Bug 10686: Remove fields from searches for highlighting

If you do a fielded search like au:smith, Smith will not get
highlighted on the results page because the Javascript is looking for
the exact string au:smith.

To test:
1) Turn on OpacHighlightedWords.
2) Do a simple keyword search.
3) Confirm that the word is highlighted on the results and details page.
4) Do a fielded search by entering au:smith (or whatever).
5) Confirm that the word is highlighted on the results and details page.
6) Sign off.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10686] Fielded searches confuse highlighter

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #20009|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20193
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20193action=edit
Bug 10665 - koha-index-daemon-ctl.sh dependency

The daemon koha-index-daemon needs a connexion to MySQL server.
This patch sets start dependance to all in order to wait for local MySQL
server or not wait if using a remote MySQL server.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Small fix, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6489] cancelling hold from holds awaiting pickup does not trigger transit

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Owen Leonard oleon...@myacpl.org ---
This appears to have been fixed in master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6489] cancelling hold from holds awaiting pickup does not trigger transit

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|kyle.m.h...@gmail.com   |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10701] In transit information doesn't display on the bibliographic detail page

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #20191|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20194
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20194action=edit
Bug 10701 - In transit information doesn't display on the bibliographic detail
page

The patch for Bug 10083 incorrectly changed some template variable names
so that in-transit details could not be shown on the biblio detail page.
This patch corrects the error.

To test, perform any action that will trigger an transfer between
libraries (for instance, check in an item from Library A at Library B).
View the detail page for that title and look for the transfer details in
the status column of the holdings table. It should show correct
information:

In transit from Athens to Nelsonville since 08/08/2013

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Comment: Work as described, no errors.
Before patch incorrect information: In transit from to since
after patch correct information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20195
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20195action=edit
Bug 5825 - Add Item Type column to Holds Queue report

The hold queue report shows collection code but not item type. This
patch adds it. Also added is use of the KohaAuthorisedValues template
plugin to display the collection code description instead of code.

To test, apply the patch and view the holds queue. There should be a new
item type column showing an item type description for each row. The
collection column should now show the collection description instead of
code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5825] Add Item Type column to Holds Queue report

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5825

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-08-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle,

i am trying to figure out SIP right now and was hoping to use your script. But
I am running into problems - with your follow up, it looks like this:

patron admin --password admin
main::help() called too early to check prototype at ./sip_cli_emulator.pl line
46.
Use of uninitialized value $terminator in string eq at ./sip_cli_emulator.pl
line 50.

OUTBOUND: 9300CNsip|COsip|CPMPL|
Use of uninitialized value $data in concatenation (.) or string at
./sip_cli_emulator.pl line 69.

INBOUND: 
Use of uninitialized value $data in pattern match (m//) at
./sip_cli_emulator.pl line 71.

Login Failed!

Without, the warns are gone, but my login still fails?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >