[Koha-bugs] [Bug 7710] multiple holds per title

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
From Melia's description this would be quite useful, but Kyle stated later that
some of it was not implemented as described. Can you clarify?

I think for a global system preference it would not be useful without using the
enumchrom field. If it does not depend on it, it would be better in the
circulation matrix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook dc...@prosentient.com.au ---
(In reply to Galen Charlton from comment #2)
 Curious about the use case for this -- are there folks who are not actually
 deleting bibs, but instead setting the Leader/05 to 'd'?  If so, why?  Or is
 this somehow arising from record imports?

I've wondered about this before as well. I've known cataloguers to switch the
Leader/05 to 'd' before, but I've never been 100% certain what is done with the
records after that.

I think the first step was to suppress them in the OPAC, and that after
that...I'm not sure. 

I wonder if a cronjob is the best idea. After all, if the record has been set
to Leader/05 'd' rather than straight up deleting it...perhaps there is a
reason why they still want it around?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18729|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20716
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20716action=edit
Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked
out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20317|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20717
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20717action=edit
[ALT 2/3] Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20318|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20718
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20718action=edit
[ALT 3/3] Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|paul.poul...@biblibre.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #53 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
This patch removes the variable $issue from C4/ILSDI/Services.pm :

--- a/C4/ILSDI/Services.pm
+++ b/C4/ILSDI/Services.pm
@@ -561,11 +561,10 @@ sub RenewLoan {
 return { code = 'RecordNotFound' } unless $$item{itemnumber};

 # Add renewal if possible
-my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber );
+my ($blockallitems,$reasonwhy,$overduesblockrenew) =
HasAnyRenewalToBeBlocked($borrowernumber,undef);
+my @renewal = $blockallitems ? (0, $reasonwhy) : CanBookBeRenewed(
$borrowernumber, $itemnumber, undef, $overduesblockrenew );
 if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }

-my $issue = GetItemIssue($itemnumber);
-
 # Hashref building
 my $out;
 $out-{'renewals'} = $issue-{'renewals'};

Is this normal?
This variable is still used in the script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Fridolyn,

Yes you are right. I just rebased the patch against master, this deletion
existed in the precedent patch.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I could imagine that happens in a union catalog setting or for electronic
ressources where you get new records while others are removed from the licensed
package. I have recently been working on documentation on when a record can be
deleted safely, there are a lot of things you want to take into account there
to make sure you don't accidentally lose important data:

- Does the record have items?
- Are the items checked out?
- Are the items on hold? (holds can be cancelled)
- Is there an open order in acquisitions for this record?
- Are there subscriptions for this record?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

--- Comment #8 from Magnus Enger mag...@enger.priv.no ---
(In reply to Katrin Fischer from comment #7)
 I have recently been working on documentation on when a
 record can be deleted safely, there are a lot of things you want to take
 into account there to make sure you don't accidentally lose important data:

Once upon a time I tried to collect all bugs related to deleting records below
Bug 8149 - Deleting Records/Biblios Omnibus

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #17 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Hi Campbell, 

It should all be in the one patch, including the staff client piece... I can
see it's still in the patch you signed off from the diffs..

Could you give any errors you see if it's really not working?

Martin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #20716|0   |1
is obsolete||
 Status|Failed QA   |Needs Signoff
   Assignee|k...@univ-lyon3.fr  |fridolyn.som...@biblibre.co
   ||m

--- Comment #55 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 20719
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20719action=edit
Bug 8236 - Prevent renewing if overdue or restriction

I revised the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10401] Add ability to merge invoices

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #20558|0   |1
is obsolete||
 CC||paola.ro...@cineca.it

--- Comment #4 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 20720
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20720action=edit
signed off patch

The shipment cost of the resulting invoice is the shipment cost of the invoice
I kept.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10401] Add ability to merge invoices

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10801] New: ERROR: Barcode must be unique

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10801

Bug ID: 10801
   Summary: ERROR: Barcode must be unique
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: yvc...@uiwtx.edu
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Good Morning,

I've added an item to an existing record, but am encountering issues when
adding the barcode.  I keep getting an error that states barcode must be
unique.  I've tried several barcodes and I keep getting the same error.  I'm
at Incarnate Word High School and the record # is 15787.

Please help,
Yanira V. Cruz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10801] ERROR: Barcode must be unique

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10801

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||neng...@gmail.com
 Resolution|--- |INVALID

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
Yanira,

I think this was meant to be a support ticket for ByWater so I'm going to move
it there, you'll get an email about that.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context-dbh checks if the DB is still running

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Benchmarks with misc/load_testing/benchmark_staff.pl

== With a remote DB ==

= Without the patch =
Benchmarking with 20 occurences of each operation and 30 concurrent sessions 
Step 1: staff client main page  11512ms 1.737 pages/sec
Step 2: catalog detail page 15142ms 1.32 biblios/sec
Step 3: catalogue search26549ms 0.753 biblios/sec
Step 4: patron detail page  12248ms 1.632 borrowers/sec
Step 5: patron search page  26901ms 1.486 borrowers/sec
Step 6a circulation (checkouts) 8697ms  2.299 checkouts/sec
Step 6b circulation (checkins)  8779ms  2.278 checkins/sec

= With the patch =
Benchmarking with 20 occurences of each operation and 30 concurrent sessions 
Step 1: staff client main page  11404ms 1.753 pages/sec
Step 2: catalog detail page 13286ms 1.505 biblios/sec
Step 3: catalogue search19946ms 1.002 biblios/sec
Step 4: patron detail page  10962ms 1.824 borrowers/sec
Step 5: patron search page  24669ms 1.621 borrowers/sec
Step 6a circulation (checkouts) 8856ms  2.258 checkouts/sec
Step 6b circulation (checkins)  8623ms  2.319 checkins/sec

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20721
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20721action=edit
Bug 10565 - Add a Patron List feature for storing and manipulating
collections of patrons - Followup 3

* Borrower search works for names with  3 characters
* Borrowers without cardnumbers can now be added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Liz, all your comments and concerns are valid. Thanks! I believe this latest
followup should address all those issues.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8542] today token produces a funny looking time on Reserves Slip

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8542

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
This is still an issue.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20722
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20722action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20722|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20723
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20723action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20723|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20724
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20724action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10802] New: history.txt missing in packages

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802

Bug ID: 10802
   Summary: history.txt missing in packages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

While bug 8911 fixed a problem regarding history.txt, a proper fix for packages
is missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10802] history.txt missing in packages

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10802] history.txt missing in packages

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20725
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20725action=edit
Bug 10802: Packages should install history.txt

While bug 8911 fixed a problem regarding history.txt, a proper fix for packages
was missing.
This patch does three things:
 - Adds docs/history.txt to debian/koha-common.docs so it gets installed.
 - Moves the line installing the release notes from debian/koha-common.install
to debian/koha-common.docs.
 - Adds an override_dh_compress entry in debian/rules that excludes history.txt
from the dh_compress routine [1]

To test:
 - Take a picture of how /usr/share/doc/koha-common looks.
 - Apply the patch and build a package [2].
 - Upgrade and/or install using your package.
 - Look for the contents of the /usr/share/doc/koha-common, it should look the
same, but history.txt must be there.
 - More  About Koha  Koha Timeline should show the history lines.

Regards
To+

[1] As 'man dh_compress' says, it is needed as every file considered for the
doc dir that is plain text and is more than 4k size will be gzipped unless
stated otherwise. We need it uncompressed for about.pl.
[2] I did it for you, it can be grabbed here: 
http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10802] history.txt missing in packages

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
I believe this is ready for serious testing and, I hope, signoff. 

Check out the bootstrap-opac branch on Gitorious:

http://gitorious.org/koha-dev/koha-dev

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10803] New: Make payment in circ is not easily translatable

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803

Bug ID: 10803
   Summary: Make payment in circ is not easily translatable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

To test:
- Choose a patron account
- Add a fine to it
- Switch to the checkout tab of the patron account
- Check for the Make payment link. Make is not a link, but payment is.

In translation this string is divided into:
. %s Make
payment

Because of this it's difficult to translate it grammatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10803] Make payment in circ is not easily translatable

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10803] Make payment in circ is not easily translatable

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10803] Make payment in circ is not easily translatable

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 20726
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20726action=edit
Bug 10803: Make payment in circ is hard to translate in circulation

To test:
- Choose a patron account
- Add a fine to it
- Switch to the checkout tab of the patron account
- Check for the Make payment link. Make is not a link, but payment is.
- Apply patch
- Check again, now both words are linked.

In translation this string is divided into:
. %s Make
payment

Because of this it's difficult to translate it grammatically.
The patch moves 'Make' into the link text, so that both words
will show up together in translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10804] New: SQL in categorie.pl should be moved into its own module and tested

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10804

Bug ID: 10804
   Summary: SQL in categorie.pl should be moved into its own
module and tested
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Adding, modifying and deleting patron categories is done in categorie.pl and
untested. We should add a new module and unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #29 from Liz Rea l...@catalyst.net.nz ---
One weirdness: 
http://img716.imageshack.us/img716/7357/rgya.png The add patron button looks a
bit strange here. I wonder if you could just go with the word Add ?

Nice to have, but not required to have (future maybe?) - 

add a borrower to a list from their detail or circulation screen (in the more
menu perhaps?)

Add a link or button to the list interface from the borrower result screen?

Add a link or button to delete a list from a displayed list -
(patron_lists/list.pl?patron_list_id=10 for example)

The ability to export the contents of a patron list as CSV. Even cooler if you
could choose which fields to export - I'm thinking of a method by which
librarians could, without using saved reports, get a list of borrowers to
email, for example. (I know! I know. Scope creep. Just writing it down so the
idea doesn't get lost. :))

Functionally this works great - I'm still having trouble with the tests though: 

devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove
t/db_dependent/PatronLists.t 
t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Storage::DBI::_dbh_execute():
DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row:
a foreign key constraint fails (`koha_devlibrary`.`patron_lists`, CONSTRAINT
`patron_lists_ibfk_1` FOREIGN KEY (`owner`) REFERENCES `borrowers`
(`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement INSERT
INTO patron_lists ( name, owner) VALUES ( ?, ? ) with ParamValues: 0='Test
List 1', 1=1] at Koha/List/Patron.pm line 121
# Looks like you planned 9 tests but ran 2.
# Looks like your test exited with 255 just after 2.
t/db_dependent/PatronLists.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 7/9 subtests 

Test Summary Report
---
t/db_dependent/PatronLists.t (Wstat: 65280 Tests: 2 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 9 tests but ran 2.
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.52 cusr  0.02
csys =  0.57 CPU)
Result: FAIL

Of note, and possibly extremely relevant, is that my failure results came from
an *upgraded* database, and not a fresh one. All tests pass on a fresh database
with only the sample data.

I'm putting this in failed qa only because I'd like an answer about the
upgraded DB tests - assuming that is all ok, I'm happy to sign off on this
as-is.

Thanks for your continued work,

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7572] Add Clubs Services Feature

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572

--- Comment #37 from David Cook dc...@prosentient.com.au ---
I created a weekly mailing list type feature as well recently. I haven't
uploaded it yet (due to time constraints and possible intersection with this
patch), but it seems to be a bit different.

I'm wondering...why would the mailing list be for new items rather than new
bibliographic records? In my case, I opted for the latter, as I thought it
made more sense to email people when a new record has been catalogued as it
represented a completely new material that they might find interesting. 

If you send mailing lists based on items, couldn't you be receiving emails
about items that already exist in the system? Or do you only send out emails
for new items for a bib where there haven't been items before? I could see that
being quite useful.

The downside of my feature is that you might add a record but not have any
items attached, so while people would know about the new record, they wouldn't
be able to really use it. 

Could you explain a bit more about how the mailing lists work, Kyle?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/