[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #18 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
I think we should make a single function
CheckBranchTransferLimits($item, $biblio, $destinationBranch, $sourceBranch)
# either $item or $biblio should be given, preferably both due to
# C4::Context-preference(item-level_itypes)

Otherwise we get crazy code duplication since the check for
BranchTransferLimits is really messy in the calling method.
Also this check is performed during circ/branchtransfers.pl and it definetely
should be checked when placing reservations/holds as well.
Also some Restful API's we have, place holds and they should be
UseBranchTransferLimits-capable.

Placing holds is beyond the scope of this bug, but now that a patch has been
applied I'd prefer to have a central way of checking the UseBranchTransferLimit
instead of replicating this code everywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] New: Transfer limits should be checked when placing a hold/reservation.

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Bug ID: 10993
   Summary: Transfer limits should be checked when placing a
hold/reservation.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If a Borrower cannot get an Item transfered to his pickup location of choice,
the
Borrower needs to know that before he places a hold.
This is especially true when placing Item-level holds.
If a patron can place a hold on an item, he expects the item to be available at
his pickup location of choice. Currently there is no warning or hold block for
holds that violate the UseBranchTransferLimits-setting.

Solution. Create or use an existing centralized
CheckBranchTransferLimits-function inside the
C4::Reserves::CanItemBeReserved(), to see if an item can be reserved for the
desired pickup location.
When the borrower changes his pickup location in
koha/opac-reserve.pl?biblionumber=xxx, the BranchTransferLimits need to be
recalculated.


UseBranchTransferLimits should also affect placing holds via the Restful API's.
$pickuplocation is not always available in the Restful API -requests so we can
use the Borrowers homebranch as the default pickup location.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation.

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Priority|P5 - low|P4
   Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation.

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
BTW: Should this be optional?
Is it against the initial spirit of UseBranchTransferLimits?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #129 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #128)
 Hi Jonathan, guess it's ok that I retested, but please let me know if I
 missed something :)

Yep, thanks! It seems I missed to change the status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #19 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21805
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21805action=edit
When failing UseBranchTransferLimits-check, don't display the Thanks for
returning this book-message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10994] New: Email sending is not working in claim notice

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Bug ID: 10994
   Summary: Email sending is not working in claim notice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: amitddng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

From address is null acquisitions claim and serial notice.

my $userenv = C4::Context-userenv;
$userenv-{emailaddress}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10994] Email sending is not working in claim notice

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Amit amitddng...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10994] Email sending is not working in claim notice

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

--- Comment #1 from Amit amitddng...@gmail.com ---
(In reply to Amit from comment #0)
 From address is null acquisitions claim and serial notice.
 
 my $userenv = C4::Context-userenv;
 $userenv-{emailaddress}

From address contain null value in acquisitions claim and serial notice.
my $userenv = C4::Context-userenv;
$userenv-{emailaddress}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #20 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Test case parameters:
-
* UseBranchTransferLimits must be set

* define your branch transfer limit.
  IPT - CPL - FFL - IPT

Test case 1, transfer is not allowed:
-

* move the librarian to IPT (Set Library link top/right)

* check-out an item, with homebranch IPT

* move the librarian to CPL (Set Library link top/right)

* FAIL check-in the item = Book check-in fails, but the template is incorrect
(Attachment: When failing UseBranchTransferLimits-check, don't display the
Thanks for returning this book-message.)
  OK (check-in fails): Item's checkout status still Checked out to Olli-Antti2
Kivilahti2, Due back on 11/01/2013


Test case 2, transfer is allowed:
-

* move the librarian to IPT (Set Library link top/right)

* check-out an item, with homebranch IPT

* move the librarian to FFL (Set Library link top/right)

* OK check-in succeeds and printing a transfer slip is proposed.
  Item's checkout status:  undef


Test conclusion:

Covered:
Item checkout status changes (Checked out, undef)
Transfer limits (Allow transfer?, true, false)
Template in circ/returns.pl

Test fails the template check, otherwise OK.


Note:
-
Should test for SIP2 as well, but probably it works ok, since AddReturn returns
false when BranchTransferLimits check fails.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10995] New: Accessibility: Allow manual entry of renewal date and specific due date in circ

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995

Bug ID: 10995
   Summary: Accessibility: Allow manual entry of renewal date and
specific due date in circ
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

In 3.12 it's no longer possible to enter dates manually as specific due date
and renewal date in the patron account in circulation. This is a big
accessibility problem as not everyone can use the datepickers for filling those
fields. We have a library where this is a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10994] Email sending is not working in claim notice

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It has worked nicely for me in the past - does your staff user have an email
address?

I agree that it's unusual for Koha to use the staff patron's email address, so
maybe this should only be an option and not the default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10994] Email sending is not working in claim notice

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

--- Comment #3 from Amit amitddng...@gmail.com ---
Hi Katrin,

Yes if staff have an email address claim notice is working fine. But this is
not a correct behavior. If we modify the code then it will not check whether
staff have email address or not.

my $email_address = $userenv-{'branchemail'} ||
C4::Context-preference('KohaAdminEmailAddress');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Olli-Antti Kivilahti from comment #19)
 Created attachment 21805 [details]
 When failing UseBranchTransferLimits-check, don't display the Thanks for
 returning this book-message.

I don't get this message. Are you sure you applied this patch on the master
branch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] New: Cannot exclude numeric subfields on export

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Bug ID: 10996
   Summary: Cannot exclude numeric subfields on export
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Tools export allows you to specify tags and subfields to strip from exported
records. However if the subfields you specify are numeric they are not stripped

Cause the regexp used to parse the exclusion list considers all numerics to be
part of the tag number so an attempt to strip $9 from tag 110 ends up in
stripping tag 1109!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 21806
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21806action=edit
Proposed Patch

To test export a record containing a numeric subfield (e.g. 100 $9 ) with
exclusion specified thus 1009. Without patch the $9 is in the export. With
patch it should be stripped

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #130 from Pierre Angot tredok.pie...@gmail.com ---
Yeah ! Now, we are waiting for pushing. I can start to test 8230 ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #11)
 Jonathan, can you point me to the code that is currently accomplishing this?
 I'm afraid I'm having a difficult time locating it. Thanks!

I suppose it is in the C4::Circulation::_debar_user_on_return routine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10363] There is no package for authorised values.

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
I take the liberty of switching back the status to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10997] New: Modernize value_builders for NORMARC

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10997

Bug ID: 10997
   Summary: Modernize value_builders for NORMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: mag...@enger.priv.no
  Reporter: mag...@enger.priv.no
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

I have reports of the NORMARC value_bilders doing wonky things, but the MARC21
ones seem to behave better. The NORMARC ones still use the old JS-only
approach. This bug aims to upgrade them to use the XML-based approach adopted
by MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #18 from Blou philippe.blo...@inlibro.com ---
Created attachment 21807
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21807action=edit
Neglected to escape the single quotes in the sql command.  This corrects it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #19 from Blou philippe.blo...@inlibro.com ---
Thank you!  I can't believe i had done the escaping for its sister file
(sysprefs.sql) and not this one.

This new patch patches the big previous patch.

My apologies.  I'll be more careful next time.

 You forgot to escape the single quotes in the message and you then typed
 contractions like Don't and We'll in the message. Escape the single
 quotes, and this works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Oops. I forgot to mention escaping the question mark too. :) Could you patch
that up too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8667] Add budget and branch columns in histsearch.pl results

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8667

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #11)
 Blocked by bug 5336 (for the aqorders.branchcode columns).

Bug 5336 will be pushed *without* the aqorders.branchcode column!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #139 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Is there anything to do before running tests?

- prove t/SimpleMarc.t
All tests successful.
Files=1, Tests=37,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.04 cusr  0.00
csys =  0.06 CPU)
Result: PASS

- prove t/db_dependent/MarcModificationTemplates.t
...
Test Summary Report
---
t/db_dependent/MarcModificationTemplates.t (Wstat: 3584 Tests: 74 Failed: 14)
  Failed tests:  25-28, 35-39, 48-51, 65
  Non-zero exit status: 14
Files=1, Tests=74,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.22 cusr  0.02
csys =  0.28 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #21 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 21524
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21524
Adding NoLoginInstructions to system preferences

Review of attachment 21524:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10951attachment=21524)
-

::: installer/data/mysql/sysprefs.sql
@@ +418,5 @@
  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over 
 results page display on intranet','Free'),
  ('yuipath','local','local|http://yui.yahooapis.com/2.5.1/build','Insert the 
 path to YUI libraries, choose local if you use koha offline','Choice'),
  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields 
 for Personal Name Authorities to fill biblio.author','free'),
 +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will 
 replace authors in biblio.author','YesNo'),
 +('NoLoginInstructions', 'h5Don\'t have a password yet?/h5 p If you 
 don\'t have a password yet, stop by the circulation desk the next time 
 you\'re in the library. We\'ll happily set one up for you./p h5Don\'t 
 have a library card?/h5 p If you don\'t have a library card, stop by your 
 local library to sign up.  /p', '60|10', 'Instructions when a person is not 
 connected', 'Textarea')

This should probably be in the alphabetical order location. This question mark
didn't need escaping, because it isn't wrapped in perl code. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Vitor Fernandes vfernan...@keep.pt changed:

   What|Removed |Added

 CC||vfernan...@keep.pt

--- Comment #31 from Vitor Fernandes vfernan...@keep.pt ---
THis patch works fine for me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #140 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #139)
 Is there anything to do before running tests?
No! I will fix that asap

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #151 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 21434
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21434
[SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles

Review of attachment 21434:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6874attachment=21434)
-

::: C4/Installer/PerlDependencies.pm
@@ +692,5 @@
 +'Test::CGI::Multipart' = {
 +'usage'= 'Tests',
 +'required' = '0',
 +'min_ver'  = '0.0.3',
 +},

This needs a rebase now. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21486|0   |1
is obsolete||
  Attachment #21487|0   |1
is obsolete||

--- Comment #141 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21808
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21808action=edit
Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = /foo/bar/i).
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #142 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21809
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21809action=edit
Bug 8015: FIX ui issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #143 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #139)
I didn't change the unit test file after changing the table structure.
Now it is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com ---
The status of orders is managed by bug 5336.
We don't want order status information in the marc record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163

Bug 7163 depends on bug 7294, which changed state.

Bug 7294 Summary: status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #21807|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #21524|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #24 from Blou philippe.blo...@inlibro.com ---
Created attachment 21811
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21811action=edit
Corrected entry which was on two lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10998] New: code duplication introduced by Z39.50 authority search

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10998

Bug ID: 10998
   Summary: code duplication introduced by Z39.50 authority search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Bug 10096, which introduces a feature to import authority records via Z39.50,
also introduces some code duplication.

To summarize the differences:

- z3950_search.pl and z3950_auth_search.pl differ only in the input search
attributes they accept
- C4::Breeding::ImportBreeding() and C4::Breeding::ImportAuth() do mostly the
same thing
- the actual search logic in C4::Breeding::Z3950SearchAuth() and
C4::Breeding::Z3950Search() is the same; the two routines differ only in the
specific Z39.50 attributes they handle and in some details of post-retrieval
record processing.  Also, Z3950SearchAuth() does not reflect the work that was
done for bug 10462.

Consequently, there is plenty of opportunity for code consolidation, as well as
adding unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #158 from Tomás Cohen Arazi tomasco...@gmail.com ---
Ketan,

(In reply to Ketan Kulkarni from comment #155)
 Hello Tomás,
 
 Yes, we should move from utf8::encode/decode to Encode::
 This particular bug (6554) is about double encoding that happens in
 Templates.pm.

Take a look at this work from Marcel:
http://wiki.koha-community.org/wiki/Handling_UTF8_in_development

If we (currently) do things wrong inside Koha regarding encoding/decoding of
UTF-8 data (double encoding means we are encoding wrong somewhere), then fixing
those symptms will just hide the problem (using utf8::upgrade will avoid the
consequences but not fix the root cause, it might even hide new bugs introduced
by future patches).

It is up to the QA team and the RM to think of the best approach for tackling
this so I'm just leaving this comment, also I appreciate you efforts and hope
this gets fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #21811|0   |1
is obsolete||

--- Comment #25 from Blou philippe.blo...@inlibro.com ---
Created attachment 21812
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21812action=edit
Corrected entry which was on two lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #26 from Blou philippe.blo...@inlibro.com ---
Created attachment 21813
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21813action=edit
changed escape \' to '' (and \? to ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #31 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5544] All Notices from Branch Email Address

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #20 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #19 from Galen Charlton gmcha...@gmail.com ---
Pushed to master, along with a follow-up to direct people to the wiki
instructions for installing Koha on Ubuntu from packages for production. 
Thanks, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #21810|0   |1
is obsolete||
  Attachment #21812|0   |1
is obsolete||
  Attachment #21813|0   |1
is obsolete||

--- Comment #27 from Blou philippe.blo...@inlibro.com ---
Created attachment 21814
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21814action=edit
Adding NoLoginInstructions to system preferences

Ok, this is a clean one, containing all the changes, from the start.  All
previous patches are obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #28 from Blou philippe.blo...@inlibro.com ---
Created attachment 21815
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21815action=edit
Bug 10951 - Adding NoLoginInstructions to system preferences

 On a failed login, the default message is harcorded into opac-auth.tt.

 It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
 The changes modify
 -opac-auth.tt to allow for custom value
 -admin/preferences/opac.pref to add it to the preferences with a
description
 -C4/Auth.pm for the loading of the preference
 -sysprefs.sql
 -updatedatabase.pl

 TESTING
 1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the Don't have a p
 2) Apply the patch
 3) Regression Test: Redo step 1.  Same (default) message should
appear.
 4) Log in to intranet,
 - select NoLoginInstructions in system preferences.
 - Enter new (xml) message.  Possible:
 h5Welcome to Koha, please bring your passport to the front
office/h5
- and save
 5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #21814|0   |1
is obsolete||

--- Comment #29 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 21814
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21814
Adding NoLoginInstructions to system preferences

This is obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #30 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 21816
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21816action=edit
[SIGNED OFF] Bug 10951 - Adding NoLoginInstructions to system preferences

 On a failed login, the default message is harcorded into opac-auth.tt.

 It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
 The changes modify
 -opac-auth.tt to allow for custom value
 -admin/preferences/opac.pref to add it to the preferences with a
description
 -C4/Auth.pm for the loading of the preference
 -sysprefs.sql
 -updatedatabase.pl

 TESTING
 1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the Don't have a p
 2) Apply the patch
 3) Regression Test: Redo step 1.  Same (default) message should
appear.
 4) Log in to intranet,
 - select NoLoginInstructions in system preferences.
 - Enter new (xml) message.  Possible:
 h5Welcome to Koha, please bring your passport to the front
office/h5
- and save
 5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #21815|0   |1
is obsolete||

--- Comment #31 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 21815
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21815
Bug 10951 - Adding NoLoginInstructions to system preferences

Obsolete (unsigned) version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #32 from M. Tompsett mtomp...@hotmail.com ---
test plan:

- drop kohadatabase, create blank one
- go to staff client and do web install
- confirm the nologin-ish system preference was created.
- restore only koha database
- go to staff client and do web upgrade
- confirm the nologin-ish system preference was created.

play with values of the system preference
- does the message appear on failed log in? YES.
- blank the system preference, refresh OPAC, gives old default message? YES.
- set system preference to 'blah', refresh OPAC, gives 'blah'? YES.

Looks great! Signed off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10999] New: koha-restore --force option to just overwrite easily a Koha instance with an older backup

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10999

Bug ID: 10999
   Summary: koha-restore --force option to just overwrite easily a
Koha instance with an older backup
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: pablo.bian...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Right now for eg
koha-restore /var/spool/koha/myInstance/myInstance-2013-09-23.sql.gz 
/var/spool/koha/myInstance/myInstance-2013-09-23.tar.gz
gives 78 lines starting with ERROR: File exists: and a adduser: The user
`myInstance' already exists.
It would be great to just overwrite whatever needs to have the dump runing
again, without having to koha-remove.

BTW, even using koha-remove before koha-restore, a username problem that
GRANT ALL PRIVILEGES ON `koha_myInstance` . * TO 'koha_myInstance'@'localhost';
fix. Something to do with bug 10517?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11000] New: koha-restore not working: Koha username error

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

Bug ID: 11000
   Summary: koha-restore not working: Koha username error
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: pablo.bian...@gmail.com
QA Contact: testo...@bugs.koha-community.org

koha-restore without previously removing the instance give 78 links of ERROR:
File exists: and that’s more or less expected, but:
koha-remove myInstance
(OK)
Then:
koha-restore /var/spool/koha/myInstance/myInstance-2013-09-23.sql.gz 
/var/spool/koha/myInstance/myInstance-2013-09-23.tar.gz  
ERROR: File exists: /var/lib/koha/myInstance/
ERROR: File exists: /var/lib/koha/myInstance/.bash_history
ERROR: File exists: 
[total 44 lines]

ERROR 1396 (HY000) at line 1: Operation DROP USER failed for
'koha_myInstance'@'%'
DBI
connect('dbname=koha_myInstance;host=localhost;port=3306','koha_myInstance',...)
failed: Access denied for user 'koha_myInstance'@'localhost' (using password:
YES) at /usr/share/koha/lib/C4/Context.pm line 803
Access denied for user 'koha_myInstance'@'localhost' (using password: YES) at
/usr/share/koha/lib/C4/Context.pm line 803.
Something went wrong rebuilding biblio indexes for myInstance
DBI
connect('dbname=koha_myInstance;host=localhost;port=3306','koha_myInstance',...)
failed: Access denied for user 'koha_myInstance'@'localhost' (using password:
YES) at /usr/share/koha/lib/C4/Context.pm line 803
Access denied for user 'koha_myInstance'@'localhost' (using password: YES) at
/usr/share/koha/lib/C4/Context.pm line 803.
Something went wrong rebuilding authority indexes for myInstance
[ ok ] Restarting web server: apache2 ... waiting .

I fix this just with:
GRANT ALL PRIVILEGES ON `koha_myInstance` . * TO 'koha_myInstance'@'localhost';
and running again the previous command, but is very scary to erase and not
being able to restore an instance...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10999] koha-restore --force option to just overwrite easily a Koha instance with an older backup

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10999

Pablo AB pablo.bian...@gmail.com changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11000] koha-restore not working: Koha username error

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

Pablo AB pablo.bian...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11000] koha-restore not working: Koha username error

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

--- Comment #1 from Pablo AB pablo.bian...@gmail.com ---
This probably is duplicated or related to bug 10517.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx)

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_14_candidate
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, 

failing to get your attention and answers to my questions :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_14_candidate
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-10-05
last check this||

--- Comment #2 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10363] There is no package for authorised values.

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-10-05
last check this||

--- Comment #16 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4481] Search's Limit to Available filters out many available items

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4481

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 CC||ch...@bigballofwax.co.nz
 Resolution|--- |DUPLICATE

--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
This was fixed by 7031

*** This bug has been marked as a duplicate of bug 7031 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7031] More options for AdvancedSearchTypes

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7031

--- Comment #27 from Chris Cormack ch...@bigballofwax.co.nz ---
*** Bug 4481 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234

Bug 9234 depends on bug 4481, which changed state.

Bug 4481 Summary: Search's Limit to Available filters out many available items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4481

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7362] Allow searching by item number as a fallback

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7362

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
I had a crack at rebasing this but there are a lot of conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6890] Add reserves to modification logging

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6890] Add reserves to modification logging

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #14109|0   |1
is obsolete||

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21817
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21817action=edit
Bug 6890 - log reservation actions

C4/Reserves.pm: log reservation actions
catalogue/issuehistory.tt: link to viewlog for circulation log
tools/viewlog.tt: add HOLD and UNHOLD actions, move results table nearer top
tools/viewlog.tt: rewrite to use loopro.module and to link better
members/readingrec.tt: link to circulation log for hold/unhold info

To test:
  1. place a few holds and release them somehow (cancel or issue);
  2. view the reading record of an affected borrower;
  3. click the link to the modification log and see the holds;
  4. click the link to an affected biblio;
  5. click to view its circulation history;
  6. click the link to the modification log and see the holds.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #15151|0   |1
is obsolete||

--- Comment #44 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21819
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21819action=edit
Bug 9316: Add ability to install/configure nginx - Minor Corrections

This patch adds minor changes to koha-plack.sh upstart script and a few
corrections to permissions and missing directory locations to quiet errors

This patch should be applied after Elliott Davis's patch.

Test as before:
1) Ensure that you have nginx installed
2) Esure that you have the following packages installed libplack-perl
libcgi-emulate-psgi-perl libcgi-compile-perl starman
3) Apply patch
4) Run through the make file, you will notice 5 new configuration options.
5) Make sure you choose NGiNX as your webserver
6) You may choose whatever ports you wish and also whatever DNS entries you
wish
7) After you're done configuring run make
8) Run make install (you may need sudo if you've used sudo before)
9) Start plack (you may wish to copy the script to init.d) with the script in
koha-dev/bin/koha-plack.sh (requires sudo)
10) TURN OFF APACHE, and start NGiNX
11) go to your web browser and see if everything fires up as normal.

removed dependencies and updated init script to allow for the use of starman or
plackup

fixed debian control
added a warning for nginx configurations
modified koha.psgi to enable debugging only if plack::middleware::debug had
been installed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9316] Add Nginx install options with plack

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16453|0   |1
is obsolete||

--- Comment #17 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21820
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21820action=edit
Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones

If you switch BiblioItemtypeImage to Koha, you will see the Koha
itemtypes, if it is Control you will get the ones generated from
the MARC control fields.

Squashed commit of the following:

commit a36d5fdbfc484639ae7939f14e0363fda79b9323
Author: Chris Cormack chr...@catalyst.net.nz
Date:   Mon Oct 1 10:56:47 2012 +1300

WR96747, Bug 8732 Finishing staff side

commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d
Author: Chris Cormack chr...@catalyst.net.nz
Date:   Mon Oct 1 09:47:07 2012 +1300

Bug 8732 : Now working for staff side too

commit 641be286401cf1be54fddb3cc58a53566d80dcca
Author: Chris Cormack chr...@catalyst.net.nz
Date:   Mon Oct 1 09:10:27 2012 +1300

Bug 8732 - generalising syspref

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

commit c4ce95c12a773d84e6f8d0b05664649e170799d8
Author: Chris Cormack chr...@catalyst.net.nz
Date:   Wed Sep 12 09:19:31 2012 +1200

Bug 8732 : Showing the images on the OPAC detail page

commit 105acad0f76628536840577fa96fb0839f9f3e2f
Author: Chris Cormack chr...@catalyst.net.nz
Date:   Thu Sep 6 14:19:37 2012 +1200

Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones

If you switch OpacResultsItemtypeImage to Koha, you will see the Koha
itemtypes, if it is Control you will get the ones generated from the
MARC control fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16454|0   |1
is obsolete||

--- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21821
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21821action=edit
Bug 8732 Style fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #159 from Ketan Kulkarni ke...@carvingit.com ---
Hello Tomás,

I appreciate your concerns. I have read the web page. It's up to the QA and RM
to decide.

Nevertheless, the updates in the patch have been done in accordance with the
principle - decode the input and encode the output.

Although utf8::upgrade() is a temporary fix to hide the problems if any, does
fix things to a great extent. Besides, upgrade() is an inbuilt perl function.
And on production systems it's better we use upgrade() than just encode() if it
is going to break things. Once we have a plan in place, this will be replaced
by Encode:: You see, there's talk about using Encode::... instead of
utf8::
In the current scenario, utf8::upgrade() appears to be a decent (and forgiving)
way of handling errors in coding.

There's another bug related to writing a generic subroutine for utf-decoding
for input. The discussion is on.

Considering the size of the code-base, UTF handling related updates are going
to take time. The present patch tries to fix the problem that is there in the
stable release temporarily.

Regards,
Ketan

(In reply to Tomás Cohen Arazi from comment #158)
 Ketan,
 
 (In reply to Ketan Kulkarni from comment #155)
  Hello Tomás,
  
  Yes, we should move from utf8::encode/decode to Encode::
  This particular bug (6554) is about double encoding that happens in
  Templates.pm.
 
 Take a look at this work from Marcel:
 http://wiki.koha-community.org/wiki/Handling_UTF8_in_development
 
 If we (currently) do things wrong inside Koha regarding encoding/decoding of
 UTF-8 data (double encoding means we are encoding wrong somewhere), then
 fixing those symptms will just hide the problem (using utf8::upgrade will
 avoid the consequences but not fix the root cause, it might even hide new
 bugs introduced by future patches).
 
 It is up to the QA team and the RM to think of the best approach for
 tackling this so I'm just leaving this comment, also I appreciate you
 efforts and hope this gets fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-10-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #160 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Ketan Kulkarni from comment #159)
 Hello Tomás,
 
 I appreciate your concerns. I have read the web page. It's up to the QA and
 RM to decide.
 
Just one note here, Tomás is the release maintainer for the 3.12.x branch, so
it is up to him to decide if this will go into that stable release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/