[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I didn't retest - maybe someone implemented it after I filed the bug? If the new patch is more consistent with formatting, maybe it can still be signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- In this discussion I first tended to agree with Jonathan. We should not need a syspref to have odd behavior stay in Koha. But on the other hand will the potential items really be available? If there is only one other item, and you cannot longer find it? So maybe we should indeed stay on the safer side with Katrin :) yasp.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10794] Sorting on billing date column in invoices table doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #11 from Jacek Ablewicz a...@biblos.pk.edu.pl --- (In reply to Joseph Alway from comment #9) BTW (on a not quite related subject - but we'll be grateful if someone can shed some light on this mystery) we/our translation people were wondering what is the precise meaning of the Billing date: - date the invoice was issued by vendor, - date the invoice was shipped to/given to, or arrived to the client, - date the payment is due, - date the payment was actually made ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #71 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Nice work guys, excellent testing all round and excellent follow through Doug! This is such a good example of seeing things through from beginning to end.. shame not all patches get this far ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 --- Comment #5 from Marc Véron ve...@veron.ch --- Created attachment 25571 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25571action=edit [Signed-off] Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions - Suggestions - New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. The patch displays a message 'Required' near the title field. After submitting a empty title it changes to 'This field is required' Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #25539|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #25559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think it was me - I should have retested. Also Owen write that for him no message appears I think - so maybe there is some other difference we haven't found yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11820] dead code in basketgroup.pl : add operation is never invoked without a booksellerid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11820] dead code in basketgroup.pl : add operation is never invoked without a booksellerid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25551|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25572action=edit Bug 11820: remove dead code in basket group management There was some code in acqui/basketgroup.pl that was apparently intended to let one create a basket group for no (or an unknown) vendor. However, this code was never reached, as there is nothing in the templates that invokes basketgroup.pl with 'add' as the operation that doesn't also pass the vendor ID along. This patch removes that dead code. To test: [1] Create a new basket group for a vendor and verify that it is created correctly. [2] Edit an existing basket group, including moving baskets in and and out of, and verify that it works. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #83 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to M. de Rooy from comment #82) Olli, Since this is a larger set of patches, it could be helpful while reviewing it to know what you exactly tested when signing off? Is it possible to elaborate on that? Thanks in advance.. Wow, this is a big guestion. Basically I followed the test plan for this bug and for each dependant bug. Verifying from the SQL-client that data is preserved and the described database changes happen. I didn't do any Perl::Critic runs, as I am not very familiar with those and I get pretty uncontrolled results with it :) We are using this featureset in our semi-production server and have uncovered some bugs and subsequently reported them in other bug entries (which Joubu has promptly fixed). Unfortunately I didn't keep track of the test paths I took, but I can guarantee I didn't reach a 100% test coverage. Maybe 70% for this patch + the critical path. Tho I would applaud a unified Koha testing methodology to be adopted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Add a way to access log |Add a way to access files |files from the intranet.|from the intranet. --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Removing the log as I think the use case is a bit wider - it could be an interesting feature to use with printed notices (overdues, holds, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11827] New: Untranslatable Cancel Rating in jQuery rating plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Bug ID: 11827 Summary: Untranslatable Cancel Rating in jQuery rating plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The jQuery rating plugin has a string Cancel Rating which is not picked up by the translation toolchain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25573
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25573action=edit
Bug 11826: Add XSLT handler object to Koha namespace
In achieving the goals of umbrella report 6536 (Z3950 improvements), this
report adds a XSLT handler object to the Koha namespace.
A follow-up adds unit tests for this module.
This patch does not yet incorporate the new object into Z3950 search. So
it does not change any behavior and is therefore harder to test.
Test plan:
Run the unit tests of the follow-up patch on report 11826.
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
I tested the new module in two additional ways:
[1] Made a simple script (four lines as below) that ran a larger xml file
with 1500 records through a test XSLT file modifying the title.
my $eng= Koha::XSLT_Handler-new;
open my $fh1, '', '_example_file';
my @xml= $fh1;
print $eng-transform( join('', @xml), '_example_xsl_file');
[2] Incorporated the object into my local changes of Breeding.pm (based on
older work, not ready for submittal now).
Ran transformation on Z3950 search results. Worked well :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 25574 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25574action=edit Bug 11826: Add unit tests for Koha::XSLT_Handler Test plan: Verify if XSLT_Handler.t passes. You could also sabotage the test by removing one of the test xsl files. Or you could 'repair' the bad xsl file (test02). Remove the second line redefining the xsl variable. In all those cases the unit test should fail now.. Discard your changes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6536 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #31 from M. de Rooy m.de.r...@rijksmuseum.nl --- I added bug 11826 in order to add an object to facilitate xslt handling as a first step to still incorporate xslt to z3950 search results. Please have a look.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED CC||fridolyn.som...@biblibre.co ||m Assignee|k...@bywatersolutions.com |fridolyn.som...@biblibre.co ||m --- Comment #49 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 25575 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25575action=edit Bug 2720 - [Follow-up] Correct database update for debarments with -12-31 The borrowers with infinite debarments have borrowers.debarred with '-12-31'. Database update for this bug contained : INSERT INTO borrower_debarments ( borrowernumber, expiration, comment ) SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred IS NOT NULL For borrowers where borrowers.debarred is '-12-31', this value is copied into borrower_debarments.expiration. This is not correct because borrower_debarments.expiration must be NULL for infinite debarments. This patch corrects update 3.13.00.035 and also adds an update for databases already updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #5) Pushed to master, although as you can probably see from the comment I made in the commit message, I would suggest that it is a good idea to not lose perspective on the difference between a minor convention meant to reduce the chance of merge conflicts as opposed to an actual error. Galen, Yes I completely agree, it is not an error. The (small) problem occurs when the file is already badly sorted. In this case, the qa script doesn't catch a patch introducing a line in the wrong place. This means if a pref is added at the end of the file (as we previously did), there is no warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25576 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25576action=edit Bug 11803: Consistent use of $dbh in _koha_modify_item This is just some code cleanup, no behavior change expected. Also replacing errstr with err in testing the results. (See DBI.) Test plan: Modify an item and save it. Followed test plan. No problems found. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25561|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11803] Consistent use of $dbh in _koha_modify_item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11803 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6404] patron bulk delete by patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6404 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added Status|NEW |RESOLVED CC||a...@biblos.pk.edu.pl Resolution|--- |DUPLICATE --- Comment #1 from Jacek Ablewicz a...@biblos.pk.edu.pl --- This feature got added in bug 9076; status changed to RESOLVED. *** This bug has been marked as a duplicate of bug 9076 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #27 from Jacek Ablewicz a...@biblos.pk.edu.pl --- *** Bug 6404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25577 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25577action=edit Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions - Suggestions - New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. The patch displays a message 'Required' near the title field. After submitting a empty title it changes to 'This field is required' Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com The title field is required since commit d565fb02e9fca2ac9c506e4e7d44fd8b0d66f06a This one makes it more consistent with formatting. It makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25571|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11763] Consolidate fund action links into menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #3) Hm, it looks like the depending bug is still waiting for sign off? Hm, yes :) I cannot sign it off, I am the author of the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #25575|0 |1 is obsolete|| --- Comment #50 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 25578 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25578action=edit Bug 2720 - [Follow-up] Correct database update for debarments with -12-31 Small correction in new update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #25578|0 |1 is patch|| Attachment #25578|text/x-c++ |text/plain mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11746] Add edit item links to record details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11746] Add edit item links to record details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25579 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25579action=edit Bug 11746 [QA Followup 3] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #84 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Olli-Antti Kivilahti from comment #83) Thanks for responding. Wow, this is a big guestion. Really? Everything you could add, is helpful. Perhaps something for a next time: If you include more information in your signoff comment about what you tested especially when testing larger patches, your signoff gets even more weight. Basically I followed the test plan for this bug and for each dependant bug. Always feel free to leave the test plan too. This could reveal the bugs where the author was not thinking of.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #5 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- Hi, I tested the patch on 3.12.7 and it works fine. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #85 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Thanks for the feedback Mr. de Rooy. From now on I will attach a testing report for all of my sign offs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #24962|0 |1 is obsolete|| Attachment #24964|0 |1 is obsolete|| Attachment #25229|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25580 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25580action=edit Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 Signed-off-by: Havilah Lyon havi...@aflibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25581 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25581action=edit Bug 11629 [QA Followup] - Add message for librarian that status was updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25582 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25582action=edit Bug 11629 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jonathan Druart from comment #8) QA comment: 1/ I am not sure the code you added to AddReturn is put at the right place. I think the code should be put into the if ( $doreturn ) statement (if the return is not done, I suppose we don't want to update the not for loan status). Moreover, you will be able to use the existing call to ModItem (and avoid 1 call to it). 2/ Could you add unit tests for this new syspref please? Marked as Failed QA. I deprecated the patch for point 1, as we *do* want to update the not for loan status even if the return is not done. In fact, the primary reason for this is to cause a not for loan item to become for loan. I wasn't thinking when I wrote the qa followup! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25583 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25583action=edit Bug 11629 [QA Followup] - Remove strong tags to ease translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Marjorie Barry-Vila from comment #5) Hi Marjorie, Could you test this patch against the master branch using a sandbox? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #86 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Olli-Antti Kivilahti from comment #85) Thanks for the feedback Mr. de Rooy. You are welcome. From now on I will attach a testing report for all of my sign offs. olli++ Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #59 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25584 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25584action=edit Bug 9303 [QA Followup 3] - Add borrowerRelationship syspref check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] New: Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Bug ID: 11828 Summary: Add German PDF template for orders in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Add a German translation of the existing template layout2pages for creating ordres as PDF in acquisitions. See also bug 10573. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #60 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25585 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25585action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10746 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||11828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10828 Depends on|11828 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #87 from M. de Rooy m.de.r...@rijksmuseum.nl ---
First QA comment:
* General: Feature looks good (although not complete yet). Seems to be a
welcome addition.
At this moment in the process, it is not clear what is used (probably only
email) and what is not. That makes a push not very obvious?
* Patch 1
* Functionality: I can imagine that I have filled in multiple transport types
but want to activate or deactivate some of them. Would you need some status on
each of them?
* t/db_dependent/Letters.t passed
Just noting that the value 'feed' is not added in the test. Seems no
problem..
* POD of GetMessageTransportTypes says: returns a list of hashes?? But it
returns an arrayref! (See also Patch 3, yes.)
* BTW why not use my $mtts = $dbh-selectcol_arrayref.. instead of the more
complex map { } .. in GetMessageTransportTypes?
* Just noting that we still have lots of SQL code in tools/letter.pl. Too bad
you didn't move it ;) No blocker for me.
* Textual: You must specify a title and a content - Please specify title and
content [a content sounds funny to me as non-native speaker]
* IMPORTANT: The Insert button does no longer surround the fieldname with
and .
This line (among others) got killed: myQuery.value = chaineSql.substring(0,
startPos) +''+ chaineAj+'' + chaineSql.substring(endPos, chaineSql.length);
Note that this does not build up confidence in the test stage. (Did you
perhaps repair this on another report already?)
When resolving bugs crosses the boundaries of a patch set, it could be hard
to perform QA. (I simply cannot qa 30 patches at 8 reports at one time [numbers
at random, no offense]..)
* Patch 2
* Test t/db_dependent/Overdues.t passed
* Functionality clash? For Overdue notice (phone notice): I can select all
transport types. Confusing..
* From commit: [Currently, only email, sms and print are relevant.] Note that
you could hide what is not relevant now?
* Glancing through tools/overduerules.pl: If you move First, Second, etc.
from template to script, you do not translate them anymore?
Note that I would not disapprove the idea of more flexibility there..
* Patch 4
The dbrev prints: Upgrade done (Bug 9016: Adds the association table
overduerules_transport_types)
The db rev does a lot more than that (or more important things..)
It also adds e.g. message_transport_type to letter which is closer to the
'general theme'.
Please change the print message to a more generic one.
* Other patches: no specific comments at this time.
Changing status for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||10746 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks|10828 |11828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks|10746 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on|10746 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||10746 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #25585|0 |1 is obsolete|| --- Comment #61 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25586 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25586action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- (In reply to Jonathan Druart from comment #6) (In reply to Marjorie Barry-Vila from comment #5) Hi Marjorie, Could you test this patch against the master branch using a sandbox? It's the first time i am testing a patch in a sandbox. I tested on a sandbox (http://pro.test6.biblibre.com) and it works fine too. Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #10 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to Pedro Ferreira from comment #9) yes that is correct $ cp /usr/share/koha/lib/C4/Labels/Label.pm /var/www/koha3.12/lib/C4/Labels/Label.pm I tend to agree with Robin that this looks like broken non-package installs. I'm closing this as WORKSFORME since it does, indeed, work for me on my dev installs as well as the production installation we run here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] New: JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Bug ID: 11829 Summary: JavaScript error on staff client biblio details pages if template variables are undefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org In the JavaScript included in cat-toolbar.inc: var holdcount = [% holdcount %] If [% holdcount %] is undefined that line triggers an error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Blocks||11821 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11821] Staff client catalog: delete menu items greyed out without explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11821 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Depends on||11829 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11830] New: Document disk space requirements for git install on Ubuntu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11830 Bug ID: 11830 Summary: Document disk space requirements for git install on Ubuntu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcha...@gmail.com Reporter: d...@coffeecode.net QA Contact: testo...@bugs.koha-community.org Created attachment 25587 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25587action=edit Adds a HARDWARE REQUIREMENTS section to the INSTALL.ubuntu file When I installed Koha for the first time on Ubuntu, I provisioned a VM with what I assumed would be a generous 4GB of disk space. This turned out to be a very bad assumption due to the 2.3GB that a full git clone of the Koha repository requires. The symptoms of running out of disk space were sadly not immediately apparent and caused much head scratching. Therefore, in INSTALL.ubuntu, include an upfront note about hardware requirements in the case of a git install, in the hopes that others will not end up experiencing a similar fate :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11830] Document disk space requirements for git install on Ubuntu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11830 Dan Scott d...@coffeecode.net changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |d...@coffeecode.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Looks like this was caused by the QA follow-up to 9823 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 25588 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25588action=edit Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts to not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonnly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the Normal detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose Delete record from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose Delete record again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11831] New: ISBD and MARC view in Staff client (and Opac?) does not print
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11831 Bug ID: 11831 Summary: ISBD and MARC view in Staff client (and Opac?) does not print Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com See k...@lists.kapito.co.nz, 24.02.2014 15:37, Bhaskar Ghosh ISBD and MARC view page in Staff client and OPAC, print tab does not work in KOHA 3.14.xx. I can reproduce this problem for versions 3.14.01 and current master with Firefox 27 and Chrome 33 - OPAC (bootstrap and prog theme) does print, but gives JavaScript warning in console - Staff client does not print, same JavaScript warning in console Warning in Firefox (Staff): Empty string passed to getElementById() (...) intranet-tmpl/lib/jquery/jquery.js Line: 2 Warning in Firefox (Opac): Empty string passed to getElementById() Zeitstempel: 24.02.2014 17:16:31 (...) opac-tmpl/bootstrap/lib/jquery/jquery.js Line:2 In Chrome: Error: Uncaught SyntaxError: Unexpected token ; MARCdetail.pl:310 Warning: event.returnValue is deprecated. Please use the standard event.preventDefault() instead. Marc Véron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11832] New: JavaScript error on staff client place hold screen if record has no items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 Bug ID: 11832 Summary: JavaScript error on staff client place hold screen if record has no items Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reserve/request.pl?biblionumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Opening the holds page for a title which has no items attached triggers a JavaScript error: TypeError: $(...).autocomplete(...).data(...) is undefined /cgi-bin/koha/reserve/request.pl?biblionumber=X Line 313 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11831] ISBD and MARC view in Staff client (and Opac?) does not print
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11831 Marc Véron ve...@veron.ch changed: What|Removed |Added Priority|P5 - low|P3 Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11831] ISBD and MARC view in Staff client (and Opac?) does not print
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11831 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard oleon...@myacpl.org --- *** This bug has been marked as a duplicate of bug 11829 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added CC||ve...@veron.ch --- Comment #3 from Owen Leonard oleon...@myacpl.org --- *** Bug 11831 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25589 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25589action=edit Bug 11126 [QA Followup] - Make reserves returned by _Findgroupreserve sorted by priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- At this point I wonder why we still allow logins as the DB user. Wouldn't it be better to add a cli script to generate a first superlibrarian to log in with, and do away with db user logins altogether? (In reply to Chris Cormack from comment #3) (In reply to Robin Sheat from comment #2) The giant warning saying that you shouldn't do that indicates that you shouldn't do that. A better fix is is to make that warning a bit more compulsory, e.g. cutting off access to functions that aren't related to configuration/management if you're the database user. Maybe also make the warning bigger and having blinking marqueed text so it doesn't get ignored. Yep, what Robin is saying is that the real problem here is that you are logged in not as a real user but the db user. I agree that we should definitely not let the db user ever circulate. That would be a much better solution. Also, lots of other features should be blocked too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Agreed, I also think it's safer to pref it than to not. We can always remove the preference at a later date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11832] JavaScript error on staff client place hold screen if record has no items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11736] Use new DataTables include in Koha news templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11736 wajasu matted-34...@mypacks.net changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11736] Use new DataTables include in Koha news templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11736 wajasu matted-34...@mypacks.net changed: What|Removed |Added Attachment #25181|0 |1 is obsolete|| CC||matted-34...@mypacks.net --- Comment #2 from wajasu matted-34...@mypacks.net --- Created attachment 25591 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25591action=edit SIGNED-OFF-Bug-11736-Use-new-DataTables-include-in-Koha-news-tmpl sortable date columns appeared and behaved just fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11832] JavaScript error on staff client place hold screen if record has no items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 25590 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25590action=edit Bug 11832 - JavaScript error on staff client place hold screen if record has no items If a hold operation is blocked because the title has no items attached the patron search autocomplete JavaScript triggers an error. This patch modifies the template so that the JS is loaded only when items are present. To test, find a title which has no items attached. View the holds page for that title. There should be no JavaScript error. Patron search autocomplete should still work correctly for titles which have items attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11821] Staff client catalog: delete menu items greyed out without explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11821 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 25592 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25592action=edit Bug 11821 - Staff client catalog: delete menu items greyed out without explanation Biblio edit menu items which are disabled should trigger a tooltip on hover and an alert on click with explanations. This patch implements this for the relevent menu items. To test, apply the patch for Bug 11829 if necessary. Find a record which has no items attached. Test the following views: - Normal - MARC - Labeled MARC - ISBD - Items Test these Edit menu items: - Edit items in a batch - Delete items in a batch - Delete all items Hovering over these menu items should trigger an explanatory tooltip. Clicking the menu items should trigger a similar alert. Next, locate a title with items attached. On the same pages above, test the Edit - Delete record menu item. Hovering should trigger an explanatory tooltip. Clicking it should trigger a similar alert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11821] Staff client catalog: delete menu items greyed out without explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11821 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 --- Comment #4 from Marc Véron ve...@veron.ch --- Created attachment 25593 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25593action=edit [Signed-off] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts to not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonnly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the Normal detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose Delete record from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose Delete record again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. I went through the test plan, everything works OK. It resolves Bug 11831 as well. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #25588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11829] JavaScript error on staff client biblio details pages if template variables are undefined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11829 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 --- Comment #6 from Jacek Ablewicz ablew...@gmail.com --- Created attachment 25594 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25594action=edit Bug 11352 - Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete Batch patron deletion/anonymization tool has some issues: 1) If 'dateformat' setting in I18N/L10N system preferences is set to anything other then 'iso' (eg. 'metric'), bulk deletion when using 'expiration date is before' criterion is not working properly. Date entered in this field will be efectivelly ignored (or possibly sometimes wrongly interpreted as different date, in other format) on the final patron deletion stage. This may result in deleting (or moving to trash) more borrower records then intended. 2) Bulk/batch patron deletion should skip borrowers with nonzero account balance (ones with oustanding fines or credits) 3) This tool shouldn't offer to choose as deletion criterion those patron categories which have category_type set to 'S' (= staff patron categories) This patch fixes abovementioned problems. It also adds an option to test run patron batch deletion, and makes this option the default choice in warning stage. Test plan: - prepare test database with some patron records (at least 2, the more the better) set up in such a way that they will be vulnerable to issues 1 2 - confirm issues 1,2 - restore test database - apply patch - ensure issues 1 2 are no longer present - first by using new test run option: for #1, record counts in warning stage and final stage should be now the same; for #2, observe that patron records with nonzero balance are now excluded from deletion - redo the tests, this time choosing delete permanently and move to trash instead of test run - test #3 by changing Category type to S in some test patron categories - after that, those categories should no longer be choosable as deletion criteria. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-b...@lists.koha-commun |a...@biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11716] Use new DataTables include in label manage template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11716 wajasu matted-34...@mypacks.net changed: What|Removed |Added Attachment #25150|0 |1 is obsolete|| CC||matted-34...@mypacks.net --- Comment #2 from wajasu matted-34...@mypacks.net --- Created attachment 25595 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25595action=edit [SIGNED-OFF] Bug 11716 - Use new DataTables include in label manage template all sortable columns working fine in each of these pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11716] Use new DataTables include in label manage template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11716 wajasu matted-34...@mypacks.net changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8214|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #7924|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|NEW QA Contact|koha.sek...@gmail.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11590] Librarian able to checkout item without setting branch first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 --- Comment #5 from Robin Sheat ro...@catalyst.net.nz --- (In reply to Kyle M Hall from comment #4) At this point I wonder why we still allow logins as the DB user. Wouldn't it be better to add a cli script to generate a first superlibrarian to log in with, and do away with db user logins altogether? Because it's really super handy as an administrator to be able to go in and tweak or check some things for someone without having to have your own account set up in their system. I do think that a large yellow warning ought to suffice, and this hasn't seemed to have come up nearly as often since that was implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11713] Use new DataTables include in course reserves templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11713 wajasu matted-34...@mypacks.net changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||matted-34...@mypacks.net --- Comment #2 from wajasu matted-34...@mypacks.net --- 1. View the list of courses. Table sorting should work correctly. The new course button should look consistent with other staff client toolbar buttons. TESTED FINE 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. TESTED FINE - Sorting should work correctly, excluding sorting on the Edit, Remove, and Other course reserves columns. TESTED FINE - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. TESTED FINE with item-level_itypes = specific item BROKEN? with item-level_itypes = biblio Course Reserves - Course Details for NNN101 had sortable arrows on editable. None of the sorting working on other columns. Probably because item type column is not visible and the sort code is misaligned,etc. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves BROKEN? - I added permission for a PT patron add_reserves only checked. Logged in as that patron in staff client. Searched for a book I had reserved. Clicked details and clicked Link to reserves. http://192.168.122.184:8080/cgi-bin/koha/course_reserves/course-details.pl?course_id=1 None of the sort icons worked. (did not pursue combinations at this point). To test, go to cataloging and choose New from Z39.50. Perform a search and confirm that table sorting still works correctly. TESTED FINE NOTE: I expect this sorting to only apply to staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
