[Koha-bugs] [Bug 12113] New: Update German web Installer for 3.16
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12113 Bug ID: 12113 Summary: Update German web Installer for 3.16 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Revise, translate and complete German web installer files before the 3.16 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think I found the problem - staff URLs (non-public reports) don't accept the params, but it works nicely for public reports. It would be nice if the same feature could be made available for non-public reports as well, but this is still a very nice addition as it is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #25957|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27316 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27316action=edit 0001-PASSED-QA-Bug-9915-Allow-sql_params-to-be-passed-to-.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Mark, please take a look at Jonathan's question in comment 11. As Marcel signed off on the existing patch and I can find no wrong with it, I am going to pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27081|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27317action=edit 0001-PASSED-QA-Bug-11253-tools-inventory.pl-output_pref-i.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think maybe the problem here is that the biblionumber should not be nulled - I think Mathieu was working on something in that area. I think we can move this to another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11243 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10758 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Bug 10758 looks like a likely candidate to improve the situation here in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23844|0 |1 is obsolete|| Attachment #23845|0 |1 is obsolete|| Attachment #23846|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27318 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27318action=edit 0001-PASSED-QA-Bug-11243-Supplier-list-should-distinct-ca.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27319 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27319action=edit 0002-PASSED-QA-Bug-11243-Display-count-of-items-and-bibli.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27320 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27320action=edit 0003-PASSED-QA-Bug-11243-UT-unit-tests-for-GetBasketsInfo.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #25952|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27321 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27321action=edit 0001-PASSED-QA-Bug-8258-Use-patron-branchcode-notice-for-.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, a few small things: - database update is missing the bug number and a ) - there is a .. in the pref description ... I would have fixed those, but: ok 29 - Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled No branchcode argument to new. Should be C4::Calendar-new(branchcode = $branchcode) at t/db_dependent/Holds.t line 299 # Looks like you planned 32 tests but ran 29. # Looks like your test exited with 255 just after 29. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9180] Default rules are not always used for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Sophie, I have tested this twice, but I think there is still a bug/regression in this: Test user from library A has checked out - various books from library A and B in A - books from libary B in B ./misc/cronjobs/overdue_notices.pl -t -v Tests: Overdue notice triggers 1) only defined for default/all libraries - with and without patch: 2 notices are generated. Both generated notices contain a complete list of overdue items from both branches. 2) defined for default/all libraries and library C - without patch: no notice is generated - with patch: 2 notices are generated. 3) defined for default/all libraries and library A - without patch: only a notice for library A is generated - with patch: 2 notices are generated. 4) only defined for library A - with and without patch: only 1 notice is generated for library A 5) defined for library A and B, no default rule - without patch: 2 messages are generated - with patch: only 1 message is generated For this bug: 2) seems ok with the patch, but we seem to introduce a regression on 5). In general: Should the item lists be identical for the patches? I think it would only make sense if each overdue notice contained a complementary list of items. But should they be divided by checkout library/homebranch? Should it be controlled by one of the existing preferences (CircControl or HomeOrHoldingBranch)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10827] List of holds does not update correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I looked at this code a while ago, but had to stop testing in the midst of it. Now the patches no longer apply as we have changed a lot of other things in this area in the last few days, so I can't test. From memory: the removal of destBranch didn't seem quite right. Also the described behaviour worried me: - Verify the hold list: The item is waiting for B and C has a priority 2 - Delete the hold for B - Now you can see the item is not waiting for C. He has not been notified neither. If you apply all patches from this bug, at the next step, the item is marked as waiting for C and C has been notified when the hold for B has been deleted. If I read this correctly, the item would be set to waiting automatically and trigger the notice to the patron. I am not sure if this is a good idea. I think setting the waiting status should always require a check in. This way the correct slip can be printed and mistakes are much less likely. - Like sending the book back to the shelf, when it should remain at the circulation desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||katrin.fisc...@bsz-bw.de
--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Some notes from a code review, looking at all 5 patches together:
1) opac/opac-idref.pl is missing the license information on top of the file.
2) Should this be a FIXME or even be removed? It seems the code as currently
implements, is UNIMARC + Sudoc only.
+else {
+# unimarcCode and marc21Code
3) Patch only changes the the non-XSLT default view. Please add it to the XSLT
as well or update the pref description so that this won't cause confusion.
4) Changes to the bootstrap theme doesn't seem to include the opac-detail.tt
page? Maybe it got lost in rebase?
4) Why not do a more specific search using Identifier-standard? It seems the
index is updated, but then never used in the new code?
a href=/cgi-bin/koha/opac-search.pl?q=kw,phr=[% doc.ppn %]
target=_blankKoha/a/td
5) Please add some explanatory note or link to the system preference
description, so people will know what this feature is about and that it is only
useful for UNIMARC SUDOC libraries.
+yes: Enable
+no: Disable
+- the IdRef webservice from the opac detail page
6) Note: The datatables code seems duplicated in various files - should this be
an include? I feel like it is in staff, but maybe not available for the OPAC
yet?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 7) Hm, also seems to miss sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #67 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Just 2 notes about this, leaving final QA to Kyle: - I think the note on the currency page is misplaced. It would be better using a diferent styling (similar to other hints) below the table. - I am a bit torn about adding a new column for ISO code. The sample Koha currencies already have the ISO code as code and the overdue_notices.pl that prints the fine into the notices also assumes code to be the ISO code. Maybe we should just enforce the code to be the ISO code a bit more? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12112] C4::Breeding::ImportBreeding() is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12112 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Created attachment 27322 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27322action=edit Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff inteface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27321|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27323 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27323action=edit [PASSED QA] Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST If a notice is defined for the branchcode of the patron, it should be used. Without this patch, the notice used is the one defined for all libraries. Test plan: 1/ Set the advanced notice for a patron using digest. 2/ Check one item out to this patron (backdate the return date according the days in advance value). 3/ launch advance_notices.pl -c 4/ Verify the notice used is the default one. 5/ Define a notice for the library of the patron for PREDUEDGST 6/ launch advance_notices.pl -c 7/ Verify the notice used is the one previously defined. 8/ Check one item out to this patron (date due = today) 9/ launch advance_notices.pl -c 10/ Verify the notice used is the default one. 11/ Define a notice for the library of the patron for DUEDGST 12/ launch advance_notices.pl -c 13/ Verify the notice used is the one previously defined. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Test case: User from Library A, checked out books - in library A from A and B - in library B from B Verified, that the 'all libraries' notice is still used, when no specific notice is defined. Verified, that the patron's home library noticed is used, when defined. Note: Before and after the patch we print the branch information from the patron's home library, so also using the template from this branch, seems logical. All items over all branches are processed into one single reminder email, before and after the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 27324 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27324action=edit [Signed-off] Bug 12102 - Move humanmsg jQuery plugin outside of language-specific directory This patch moves the humanmsg jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and modify a system preference. The modification messages should appear normally. Patch works as expected Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #27266|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #19 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #217 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, we need an update to this to account for the changes done by 7180 - patches conflict on current master. I will continue testing the new patches on top of my old branch for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #218 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27325 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27325action=edit New staged order page - with improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27132|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27264|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27326 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27326action=edit [PASSED QA] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the # Bibs columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10875] addorderiso2709: the link show all funds is missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Tried applying it on top of my current branch for 7180, but it wouldn't apply. Please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #21 from Galen Charlton gmcha...@gmail.com --- Created attachment 27327 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27327action=edit Bug 9915: Allow sql_params to be passed to a report using the OPAC svc/report interface Test plan: 1/ Make a public report that contains SQL parameters 2/ Test it from the staff side 3/ Hit the url like cgi-bin/koha/svc/report?id=1sql_params=chrissql_params=chris2 4/ Test you get JSON Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Tested with a public report: select * from items - cgi-bin/koha/svc/report?id=6 - URL shows JSON and all items select * from items where itype = itype - cgi-bin/koha/svc/report?id=6sql_params=BK - URL shows JSON and only BK items select * from items where itype = itype and homebranch = homebranch - cgi-bin/koha/svc/report?id=6sql_params=BKsql_params=MPL - URL shows JSON and only BK items in MPL select * from items where itype = itype|itemtypes and homebranch = homebranch|branches - same as above - URL shows JSON and only BK items in MPL select * from items where dateaccessioned = 2013-12-15 - cgi-bin/koha/svc/report?id=6sql_params=BKsql_params=MPLsql_params=2013-12-15 - URL shows JSON and correct items Note: This will currently only work for public reports! Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #27316|0 |1 is obsolete|| --- Comment #22 from Galen Charlton gmcha...@gmail.com --- Created attachment 27328 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27328action=edit Bug 9915: (follow-up) use SQL placeholders This patch teaches C4::Reports::Guided::execute_query() how to accept a list of query parameter values. It then follows-up on the main patch by simplifying how it converts report parameters to a complete SQL query, and removes the use of DBI-quote() and complicated regexes. To test: [1] Verify that using the OPAC svc/report service with sql_params continues to work. [2] Verify that there are no regressions with running reports from the staff interface, both via the web service and the reports interface. [3] Verify that prove -v /db_dependent/Reports_Guided.t passes. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #23 from Galen Charlton gmcha...@gmail.com --- I've added a follow-up that replaces the use of -quote() with placeholders, and am kicking this back for QA review of the follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11248] Problems with translated list email sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #25 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10302] order from staged showing inactive funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10302 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** This bug has been marked as a duplicate of bug 10875 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10875] addorderiso2709: the link show all funds is missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||neng...@gmail.com --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** Bug 10302 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #219 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, we are almost there, only 2 problems found + testing the internal note/vendor note after rebase. If you can also rebase bug 10875 I will include it in my next test. ** Automated tests and QA script ** Passes all tests in t, xt, and t/db_dependent/Budgets.t t/db_dependent/Acquisition.t t/db_dependent/Acquisition/ Passes QA script. New GetBudgetByCode() covered by tests in t/db_dependent/Budgets.t. ** Code review ** No Capitalization problems found. No translation problems found. Terminology: Planning value 1 and 2 should be Statistic 1 and 2. BUG (trivial) Fixed for picking individual records, but still appears on the default accounting details tab. ** Database update Adds a new system preference MarcFieldsToOrder, inludes changes to sysprefs.sql, database update and .pref file. syspref.sql and database update are identical. ** Regression testing ** Comparing current functionality with functionality after applying the patches. File list - addorderiso2709.pl - List of files that include 'staged' records is shown, details include file name, comments, status, and staged date - Bug: # Bibs is not shown (bug 9063) * No regresion, still works like it should. New patch for bug 9063 also fixes the # Bibs problem. List of staged records - addorderiso2709.pl - Information in the list only includes title, isbn/issn, there is no way to preview a record * Improved: MARC preview and card preview - Clicking on 'Add order' will import the record into the catalog and set the status to 'imported'. * No regression, status is correctly set. - You can choose to import all records at once, using the Accounting details section. Options are: currency, budget (should be fund), notes, planning value1, planning value2 * Fund now correctly labelled. Options are now available for batch operation and for individual orders. Options include: - Individual order: quantity, price, discount, fund, statistic 1 + 2 - Batch: currency, fund, notes, planning value 1 + 2 No regression found. - Bug: Fund list shows all funds, including inactive funds (bug 10302) * No regression. Patches for bug 10302 currently don't apply. - Bug: Statistic values don't reload on selecting a fund, only when refreshing the page * BUG (normal): On the default accounting details page the refreshing doesn't work. For individual records it works alright, also on the neworderempty.pl page. New order form / neworderempty.pl - Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl Used on neworderempty to show the correct values for Statistic 1 + 2 on selecting a fund. * No regression, works like it should. ** MarcFieldsToOrder New system preference allows to include acq data in the uploaded MARC file. System preference settings used for testing: price: 933$a|933$c quantity: 933$q sort1: 933$1 sort2: 933$2 discount: 933$d budget_code: 933$b Lines included in my records: 933$a 12.00 $q 12 $b BOOKS1310 $d 5 $1 sort1 $2 sort2 933$c 12.99 $a 9.00 $q 12 $b BOOKS1310 $d 0.05 $1 sort1 $2 sort2 Looking at the individual details for the first 2 records revealed: all settings have been imported correctly. Discount should be given as $, so 0.05 is way too low, 5 is better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #26 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with follow-ups to enable QueryParser to use the new indexes. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27329 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27329action=edit [PASSED QA] Bug 12102 - Move humanmsg jQuery plugin outside of language-specific directory This patch moves the humanmsg jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and modify a system preference. The modification messages should appear normally. Patch works as expected Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script, works as described. No regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27324|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11596] Missing indexing options in koha-conf.xml should be reported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11596 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thank, Tomás! I note that the display logic for system configuration warnings is unnecessarily complicated and ought to be simplified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton gmcha...@gmail.com --- This patch does not apply. Since the dependency on 7180 is only textual, if Jonathan wants to rebase this one and put it back to passed QA after doing so, that's fine with me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Galen Charlton gmcha...@gmail.com --- Pushed to master. You may be amused to hear that I tested it successfully with an Evergreen SIP server. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27328|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27330 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27330action=edit [PASSED QA] Bug 9915: (follow-up) use SQL placeholders This patch teaches C4::Reports::Guided::execute_query() how to accept a list of query parameter values. It then follows-up on the main patch by simplifying how it converts report parameters to a complete SQL query, and removes the use of DBI-quote() and complicated regexes. To test: [1] Verify that using the OPAC svc/report service with sql_params continues to work. [2] Verify that there are no regressions with running reports from the staff interface, both via the web service and the reports interface. [3] Verify that prove -v /db_dependent/Reports_Guided.t passes. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. No regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] New: Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Bug ID: 12114 Summary: Reports web service JSON output has an encoding problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To reproduce: - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report .../cgi-bin/koha/svc/report?id=1 - verify the umlaut displays wrong - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27331 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27331action=edit Bug 12114: Fix encoding problem with reports JSON web service (opac) - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report OPAC BaseURL/cgi-bin/koha/svc/report?id=1 - verify the umlaut displays not correctly - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly - apply patch - verify umlaut now displays correctly from the beginning Based on paste from Galen Charlton. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27332 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27332action=edit Bug 12114: Fix encoding problem with reports JSON web service (staff) Repeat tests from first patch, but this time, access the report with your staff client base URL. Staff BaseURL/cgi-bin/koha/svc/report?id=reportid Based on paste from Galen Charlton. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27331|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27334 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27334action=edit Bug 12114: Fix encoding problem with reports JSON web service (staff) Repeat tests from first patch, but this time, access the report with your staff client base URL. Staff BaseURL/cgi-bin/koha/svc/report?id=reportid Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27333 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27333action=edit Bug 12114: Fix encoding problem with reports JSON web service (opac) - catalog a record that includes umlauts äöü - write a report, that has the record in the result set - access the JSON output of the report OPAC BaseURL/cgi-bin/koha/svc/report?id=1 - verify the umlaut displays not correctly - switch the encoding in the browser to 'western'/latin1 - verify the umlaut now displays correctly - apply patch - verify umlaut now displays correctly from the beginning Based on paste from Galen Charlton. http://bugs.koha-community.org/show_bug.cgi?id=9915 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12114] Reports web service JSON output has an encoding problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12114 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #93 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with my usual set of follow-ups. One follow-up deserving special mention is the last one, which restores the documented interpretation of the sharedate column. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #27 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #15 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #26928|0 |1 is obsolete|| --- Comment #60 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27335 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27335action=edit Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #61 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Chris Nighswonger from comment #59) Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this. If found a solution that use current code :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #26984|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27336 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27336action=edit Bug 12068 - label-create-pdf.pl Add support for RTL language On top of Bug 8375 If you print a label using arabic/hebrew script, letters are printed in logical direction, from left to right, giving a mangled result This patch will try to fix those cases adding a new perl dependency, Text::Bidi, and using the automagic feature if it's log2vis() function to rearrange chars based on detected text 'direction' To test: 1. Install Text::Bidi package (apt-get install libtext-bidi-perl) 2. Try a batch, using Helvetica, with a mix of ltr and rtl (arabic/hebrew) titles, chars are good, but direction is bad 3. Apply the patch 4. Try again, now the result is good Formerly a followup of Bug 8375, look sample pics on that Bug. Rebased following changes on Bug 8375 Note: Arabic titles will not be displayed, because current code selects Oblique variant. But Hebrew looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253
--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #11)
Why the last past does not change the call to output_pref for the $cdls
variable? It made sense!
Ah, I was looking at the line that caused the explosion. :)
There are two lines, much later in the code, which could be tweaked. However,
their disrespect for the iso parameter seems irrelevant, as dd/mm/ didn't
blow up (clicking submit button in the barcode section after choosing a file).
I suspect that $_-{datelastseen} is in SQL format (-MM-DD) for the $cdls,
and the first one's disrespect still generates a valid date for $dls.
I think there is merit for a follow up if one wants truly nice code (i.e. not
working by accident).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7844] plack scripts for developers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #33 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Dobrica! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11552] After a transfer, allow to search on the original order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11552 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #32 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with a follow-up that introduces a descriptive CSS class (child_fund_amount) and uses italics rather than a subtle font color difference to indicate that child fund amounts do not participate in the totals. Thanks, Julian and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] Merging authority entries
I am using 3.14.00.000 Koha version. While trying to merge duplicate authority entries as per 3.14 manual I encountered that one line is missing in output. When I searched for the term Highway Engineering the result was -- Authority search results Results 1 to 3 of 3 As per manual there should be one line between above two lines giving options of cancel and merge i.e. -- Authority search results Merging with authority: Highway Engineering (205) Cancel merge Results 1 to 3 of 3 Please fix this. Chitralekha M. Chitale ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11551] Allow to search on ordernumber in histsearch.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11551 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan and Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #24 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11864] Show parent_orderline in received orders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11864 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23308|0 |1 is obsolete|| --- Comment #23 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27337 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27337action=edit Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. NOTE: Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with a follow-up that adds a direct unit test. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595
--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 27337
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27337
Bug 7595 - Add branchcode to accountlines
Review of attachment 27337:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=7595attachment=27337)
-
::: C4/Accounts.pm
@@ +407,4 @@
my ( $borrowernumber, $itemnum, $desc, $type, $amount, $note ) = @_;
my $manager_id = 0;
$manager_id = C4::Context-userenv-{'number'} if C4::Context-userenv;
+my $branchcode = C4::Context-userenv-{'branch'};
Why does this differ than line 359?
my $branchcode = C4::Context-userenv ? C4::Context-userenv-{'branch'} :
undef;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with a follow-up that clarifies the logic in the case where the item to be checked out is already on loan to the patron. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
